hyrax 2.9.6 → 3.0.0.pre.beta1

data/spec/support/selectors.rb

@@ -0,0 +1,91 @@
+module Selectors
+  module Dashboard
+    def db_item_actions_toggle(item)
+      within "#document_#{item.id}" do
+        find '.dropdown-toggle'
+      end
+    end
+
+    # For use with javascript user selector that allows for searching for an existing user
+    # and granting them permission to an object.
+    # @param [User] user to select
+    # @param [String] role granting the user permission (e.g. 'Manager' | 'Depositor' | 'Viewer')
+    def select_user(user, role = 'Depositor')
+      first('a.select2-choice').click
+      find('.select2-input').set(user.user_key)
+      sleep 1
+      first('div.select2-result-label').click
+      within('div.add-users') do
+        select(role)
+        find('input.edit-collection-add-sharing-button').click
+      end
+    end
+
+    # For use with javascript collection selector that allows for searching for an existing collection from works relationship tab.
+    # Adds the collection and validates that the collection is listed in the Collection Relationship table once added.
+    # @param [Collection] collection to select
+    def select_collection(collection)
+      first('a.select2-choice').click
+      find('.select2-input').set(collection.title.first)
+      expect(page).to have_css('div.select2-result-label')
+      first('div.select2-result-label').click
+      first('[data-behavior~=add-relationship]').click
+      within('[data-behavior~=collection-relationships]') do
+        within('table.table.table-striped') do
+          expect(page).to have_content(collection.title.first)
+        end
+      end
+    end
+
+    # For use with javascript collection selector that allows for searching for an existing collection from add to collection modal.
+    # Does not save the selection.  The calling test is expected to click Save and validate the collection membership was added to the work.
+    # @param [Collection] collection to select
+    def select_member_of_collection(collection)
+      find('#s2id_member_of_collection_ids').click
+      find('.select2-input').set(collection.title.first)
+      sleep 10
+      expect(page).to have_css('.select2-result')
+      within ".select2-result" do
+        find("span", text: collection.title.first).click
+      end
+    end
+  end
+
+  module NewTransfers
+    def new_owner_dropdown
+      find '#s2id_proxy_deposit_request_transfer_to'
+    end
+
+    def new_owner_search_field
+      within '#select2-drop' do
+        find '.select2-input'
+      end
+    end
+
+    def new_owner_search_result
+      within '#select2-drop' do
+        find '.select2-result-selectable'
+      end
+    end
+  end
+
+  module Transfers
+    def first_sent_cancel_button
+      within '#outgoing-transfers' do
+        find '.btn.btn-danger'
+      end
+    end
+
+    def first_received_accept_dropdown
+      within '#incoming-transfers' do
+        find '.dropdown-toggle.accept'
+      end
+    end
+
+    def first_received_reject_button
+      within '#incoming-transfers' do
+        find '.btn.btn-danger'
+      end
+    end
+  end
+end

data/spec/support/spec_statistic.rb

@@ -0,0 +1,23 @@
+# This is a replacement for the OpenStruct usage. The idea is to expose
+# an object with a common interface.
+class SpecStatistic
+  def initialize(**kargs)
+    @attributes = kargs.symbolize_keys
+  end
+
+  def [](key)
+    @attributes[key.to_sym]
+  end
+
+  def method_missing(method_name, *arguments, &block)
+    if @attributes.key?(method_name.to_sym)
+      @attributes[method_name]
+    else
+      super
+    end
+  end
+
+  def respond_to_missing?(method_name, include_private = false)
+    @attributes.key?(method_name.to_sym) || super
+  end
+end

data/spec/support/speedup.rb

@@ -0,0 +1,6 @@
+# Prevent recompiling assets in test.
+# See: https://github.com/rails/rails/pull/27271
+# This can be removed when we use Rails 5.1.0
+class << ActionView::LookupContext::DetailsKey
+  def clear; end
+end

data/spec/support/statistic_helper.rb

@@ -0,0 +1,9 @@
+module StatisticHelper
+  def statistic_date(date)
+    date.to_datetime.to_i * 1000
+  end
+
+  RSpec.configure do |config|
+    config.include StatisticHelper
+  end
+end

data/spec/tasks/rake_spec.rb

@@ -0,0 +1,27 @@
+require 'rake'
+
+RSpec.describe "Rake tasks" do
+  describe "hyrax:user:list_emails" do
+    let!(:user1) { create(:user) }
+    let!(:user2) { create(:user) }
+
+    before do
+      load_rake_environment [File.expand_path("../../../lib/tasks/hyrax_user.rake", __FILE__)]
+    end
+
+    it "creates a file" do
+      run_task "hyrax:user:list_emails"
+      expect(File).to exist("user_emails.txt")
+      expect(IO.read("user_emails.txt")).to include(user1.email, user2.email)
+      File.delete("user_emails.txt")
+    end
+
+    it "creates a file I give it" do
+      run_task "hyrax:user:list_emails", "abc123.txt"
+      expect(File).not_to exist("user_emails.txt")
+      expect(File).to exist("abc123.txt")
+      expect(IO.read("abc123.txt")).to include(user1.email, user2.email)
+      File.delete("abc123.txt")
+    end
+  end
+end

data/spec/test_app_templates/Gemfile.extra

@@ -0,0 +1,6 @@
+# Use this file to reference specific commits of gems.
+
+group :development do
+  gem 'better_errors'
+  gem 'binding_of_caller'
+end

data/spec/test_app_templates/disable_animations_in_test_environment.rb

@@ -0,0 +1,54 @@
+# disable CSS3 and jQuery animations in test mode for speed, consistency and avoiding timing issues.
+# HT: https://gist.github.com/keithtom/8763169
+class DisableAnimationsInTestEnvironment
+  def initialize(app, _options = {})
+    @app = app
+  end
+
+  def call(env)
+    @status, @headers, @body = @app.call(env)
+    return [@status, @headers, @body] unless html?
+    response = Rack::Response.new([], @status, @headers)
+
+    @body.each { |fragment| response.write inject(fragment) }
+    @body.close if @body.respond_to?(:close)
+
+    response.finish
+  end
+
+  private
+
+    def html?
+      @headers["Content-Type"] =~ /html/
+    end
+
+    # rubocop:disable Metrics/MethodLength
+    # rubocop:disable Layout/IndentHeredoc
+    def inject(fragment)
+      disable_animations = <<-EOF
+<script type="text/javascript">(typeof jQuery !== 'undefined') && (jQuery.fx.off = true);</script>
+<style>
+  * {
+     -o-transition: none !important;
+     -moz-transition: none !important;
+     -ms-transition: none !important;
+     -webkit-transition: none !important;
+     transition: none !important;
+     -o-transform: none !important;
+     -moz-transform: none !important;
+     -ms-transform: none !important;
+     -webkit-transform: none !important;
+     transform: none !important;
+     -webkit-animation: none !important;
+     -moz-animation: none !important;
+     -o-animation: none !important;
+     -ms-animation: none !important;
+     animation: none !important;
+  }
+</style>
+      EOF
+      fragment.gsub(%r{</head>}, disable_animations + "</head>")
+    end
+  # rubocop:enable Layout/IndentHeredoc
+  # rubocop:enable Metrics/MethodLength
+end

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -0,0 +1,125 @@
+require 'rails/generators'
+
+class TestAppGenerator < Rails::Generators::Base
+  # Generator is executed from /path/to/hyrax/.internal_test_app/lib/generators/test_app_generator/
+  # so the following path gets us to /path/to/hyrax/spec/test_app_templates/
+  source_root File.expand_path('../../../../spec/test_app_templates/', __FILE__)
+
+  def install_engine
+    generate 'hyrax:install', '-f'
+  end
+
+  def browse_everything_install
+    generate "browse_everything:install --skip-assets"
+  end
+
+  def create_generic_work
+    generate 'hyrax:work GenericWork'
+  end
+
+  def create_nested_work
+    generate 'hyrax:work NamespacedWorks::NestedWork'
+    gsub_file 'app/models/namespaced_works/nested_work.rb',
+              'include ::Hyrax::WorkBehavior',
+              <<-EOS.strip_heredoc
+                property :created, predicate: ::RDF::Vocab::DC.created, class_name: TimeSpan
+                  include ::Hyrax::WorkBehavior
+              EOS
+
+    gsub_file 'app/models/namespaced_works/nested_work.rb',
+              'include ::Hyrax::BasicMetadata',
+              <<-EOS.strip_heredoc
+                include ::Hyrax::BasicMetadata
+                  accepts_nested_attributes_for :created
+              EOS
+  end
+
+  def create_time_span
+    create_file 'app/models/time_span.rb' do
+      <<-EOS.strip_heredoc
+      class TimeSpan < ActiveTriples::Resource
+        def initialize(uri = RDF::Node.new, _parent = ActiveTriples::Resource.new)
+          uri = if uri.try(:node?)
+                  RDF::URI(\"#timespan_\#{uri.to_s.gsub('_:', '')}\")
+                elsif uri.to_s.include?('#')
+                  RDF::URI(uri)
+                end
+          super
+        end
+
+        def persisted?
+          !new_record?
+        end
+
+        def new_record?
+          id.start_with?('#')
+        end
+
+        configure type: ::RDF::Vocab::EDM.TimeSpan
+        property :start, predicate: ::RDF::Vocab::EDM.begin
+        property :finish, predicate: ::RDF::Vocab::EDM.end
+      end
+      EOS
+    end
+  end
+
+  def banner
+    say_status("info", "ADDING OVERRIDES FOR TEST ENVIRONMENT", :blue)
+  end
+
+  def comment_out_web_console
+    gsub_file "Gemfile",
+              "gem 'web-console'", "# gem 'web-console'"
+  end
+
+  def add_analytics_config
+    append_file 'config/analytics.yml' do
+      <<-EOS.strip_heredoc
+        analytics:
+          app_name: My App Name
+          app_version: 0.0.1
+          privkey_path: /tmp/privkey.p12
+          privkey_secret: s00pers3kr1t
+          client_email: oauth@example.org
+      EOS
+    end
+  end
+
+  def enable_analytics
+    gsub_file "config/initializers/hyrax.rb",
+              "# config.analytics = false", "config.analytics = true"
+  end
+
+  def enable_riiif_image_server
+    gsub_file "config/initializers/hyrax.rb",
+              "# config.iiif_image_server = false", "config.iiif_image_server = true"
+  end
+
+  def enable_i18n_translation_errors
+    gsub_file "config/environments/development.rb",
+              "# config.action_view.raise_on_missing_translations = true", "config.action_view.raise_on_missing_translations = true"
+    gsub_file "config/environments/test.rb",
+              "# config.action_view.raise_on_missing_translations = true", "config.action_view.raise_on_missing_translations = true"
+  end
+
+  def enable_arkivo_api
+    generate 'hyrax:arkivo_api'
+  end
+
+  def relax_routing_constraint
+    gsub_file 'config/initializers/arkivo_constraint.rb', 'false', 'true'
+  end
+
+  def disable_animations_for_more_reliable_feature_specs
+    inject_into_file 'config/environments/test.rb', after: "Rails.application.configure do\n" do
+      "  config.middleware.use DisableAnimationsInTestEnvironment\n"
+    end
+    copy_file 'disable_animations_in_test_environment.rb', 'app/middleware/disable_animations_in_test_environment.rb'
+  end
+
+  def configure_action_cable_to_use_redis
+    gsub_file 'config/cable.yml',
+              "development:\n  adapter: async",
+              "development:\n  adapter: redis\n  url: redis://localhost:6379"
+  end
+end

data/spec/views/_flash_msg.html.erb_spec.rb

@@ -0,0 +1,32 @@
+RSpec.describe '/_flash_msg.html.erb', type: :view do
+  before do
+    allow(view).to receive(:flash).and_return(flash)
+  end
+
+  let(:flash) { { notice: notice } }
+  let(:i18n_html) { t('hyrax.works.create.after_create_html', application_name: 'Whatever') }
+
+  context 'with a single flash notice' do
+    let(:notice) { i18n_html }
+
+    it 'renders with HTML unescaped' do
+      render
+      expect(rendered).not_to have_content '</span>'
+    end
+  end
+
+  context 'with multiple flash notices' do
+    let(:notice) do
+      [
+        i18n_html,
+        'Lorem ipsum!'
+      ]
+    end
+
+    it 'renders the notice joined with unescaped line break' do
+      render
+      expect(rendered).not_to have_content '<br/>'
+      expect(rendered).not_to have_content '</span>'
+    end
+  end
+end

data/spec/views/_user_util_links.html.erb_spec.rb

@@ -0,0 +1,44 @@
+RSpec.describe '/_user_util_links.html.erb', type: :view do
+  let(:join_date) { 5.days.ago }
+  let(:can_create_file) { true }
+
+  before do
+    allow(view).to receive(:user_signed_in?).and_return(true)
+    allow(view).to receive(:current_user).and_return(stub_model(User, user_key: 'userX'))
+    allow(view).to receive(:can?).with(:create, GenericWork).and_return(can_create_file)
+  end
+
+  it 'has dropdown list of links' do
+    render
+    page = Capybara::Node::Simple.new(rendered)
+    expect(page).to have_link 'userX', href: hyrax.dashboard_profile_path('userX')
+    expect(rendered).to have_link 'Dashboard', href: hyrax.dashboard_path
+  end
+
+  it 'shows the number of outstanding messages' do
+    render
+    expect(rendered).to have_selector "a[aria-label='You have no unread notifications'][href='#{hyrax.notifications_path}']"
+    expect(rendered).to have_selector 'a.notify-number span.label-default.invisible', text: '0'
+  end
+
+  describe 'translations' do
+    context 'with two languages' do
+      before do
+        allow(view).to receive(:available_translations) { { 'en' => 'English', 'es' => 'Español' } }
+        render
+      end
+      it 'displays the current language' do
+        expect(rendered).to have_link('English')
+      end
+    end
+    context 'with one language' do
+      before do
+        allow(view).to receive(:available_translations) { { 'en' => 'English' } }
+        render
+      end
+      it 'does not display the language picker' do
+        expect(rendered).not_to have_link('English')
+      end
+    end
+  end
+end

data/spec/views/catalog/_index_list_default.html.erb_spec.rb

@@ -0,0 +1,43 @@
+RSpec.describe 'catalog/_index_list_default', type: :view do
+  let(:attributes) do
+    { 'creator_tesim'        => [''],
+      'depositor_tesim'      => [''],
+      'proxy_depositor_ssim' => [''],
+      'description_tesim'    => [''],
+      'date_uploaded_dtsi'   => 'a date',
+      'date_modified_dtsi'   => 'a date',
+      'rights_statement_tesim' => [''],
+      'embargo_release_date_dtsi' => 'a date',
+      'lease_expiration_date_dtsi' => 'a date' }
+  end
+  let(:document) { SolrDocument.new(attributes) }
+  let(:presenter) { double }
+
+  before do
+    allow(view).to receive(:index_presenter).and_return(presenter)
+    allow(presenter).to receive(:field_value) { |field| "Test #{field}" }
+    render 'catalog/index_list_default', document: document
+  end
+
+  it "displays metadata" do
+    expect(rendered).not_to include 'Title:'
+    expect(rendered).to include 'Creator:'
+    expect(rendered).to include 'Test creator_tesim'
+    expect(rendered).to include 'Description:'
+    expect(rendered).to include 'Test description_tesim'
+    expect(rendered).to include 'Date Uploaded:'
+    expect(rendered).to include 'Test date_uploaded_dtsi'
+    expect(rendered).to include 'Date Modified:'
+    expect(rendered).to include 'Test date_modified_dtsi'
+    expect(rendered).to include 'Depositor:'
+    expect(rendered).to include 'Test proxy_depositor_ssim'
+    expect(rendered).to include 'Owner:'
+    expect(rendered).to include 'Test depositor_tesim'
+    expect(rendered).to include 'Rights Statement:'
+    expect(rendered).to include 'Test rights_statement_tesim'
+    expect(rendered).to include 'Embargo release date:'
+    expect(rendered).to include 'Test embargo_release_date_dtsi'
+    expect(rendered).to include 'Lease expiration date:'
+    expect(rendered).to include 'Test lease_expiration_date_dtsi'
+  end
+end

data/spec/views/catalog/_search_form.html.erb_spec.rb

@@ -0,0 +1,16 @@
+RSpec.describe 'catalog/_search_form.html.erb', type: :view do
+  before do
+    allow(view).to receive(:search_form_action).and_return("/catalog")
+    allow(view).to receive(:search_state).and_return(search_state)
+    allow(view).to receive(:current_search_parameters).and_return(nil)
+    allow(view).to receive(:current_user).and_return(nil)
+
+    render
+  end
+  let(:search_state) { double('SearchState', params_for_search: {}) }
+  let(:page) { Capybara::Node::Simple.new(rendered) }
+
+  it "has a hidden search_field input" do
+    expect(page).to have_selector("[name='search_field'][value='all_fields']", visible: false)
+  end
+end

data/spec/views/catalog/_thumbnail_list_collection.html.erb_spec.rb

@@ -0,0 +1,10 @@
+RSpec.describe 'catalog/_thumbnail_list_collection.html.erb', type: :view do
+  before do
+    stub_template 'catalog/_thumbnail_list_collection.html.erb' => '<div class="col-sm-3"><span class="fa fa-cubes collection-icon-search"></span></div>'
+    render
+  end
+
+  it 'displays the collection icon in the search results' do
+    expect(rendered).to match '<div class="col-sm-3"><span class="fa fa-cubes collection-icon-search"></span></div>'
+  end
+end

data/spec/views/catalog/index.html.erb_spec.rb

@@ -0,0 +1,50 @@
+RSpec.describe 'catalog/index.html.erb', type: :view do
+  let(:doc) do
+    SolrDocument.new(id: "abc123",
+                     has_model_ssim: ['Collection'],
+                     title_tesim: ['Collection Title 999'])
+  end
+
+  before do
+    view.extend Hyrax::CollectionsHelper
+    allow(view).to receive(:current_users_collections).and_return([])
+    stub_template 'catalog/_search_sidebar.html.erb' => ''
+    stub_template 'catalog/_search_header.html.erb' => ''
+    allow(view).to receive(:render_opensearch_response_metadata).and_return('')
+    allow(view).to receive(:render_grouped_response?).and_return(false)
+    allow(view).to receive(:search_session).and_return({})
+    allow(view).to receive(:current_search_session).and_return(nil)
+    allow(view).to receive(:document_counter_with_offset).and_return(5)
+    allow(controller).to receive(:render_bookmarks_control?).and_return(false)
+
+    params[:view] = 'gallery'
+
+    resp = []
+    assign(:response, resp)
+    allow(resp).to receive(:total_pages).and_return(1)
+    allow(resp).to receive(:current_page).and_return(1)
+    allow(resp).to receive(:limit_value).and_return(10)
+    allow(resp).to receive(:empty?).and_return(false)
+
+    assign(:document_list, [doc])
+  end
+
+  context "when user does not have permissions" do
+    before { allow(view).to receive(:can?).and_return(false) }
+    it 'appears on page without error' do
+      render
+      expect(rendered).to include('Collection Title 999')
+      page = Capybara::Node::Simple.new(rendered)
+      expect(page).to have_selector("span.fa.fa-cubes.collection-icon-search")
+    end
+  end
+  context "when user has all the permissions" do
+    before { allow(view).to receive(:can?).and_return(true) }
+    it 'appears on page without error' do
+      render
+      expect(rendered).to include('Collection Title 999')
+      page = Capybara::Node::Simple.new(rendered)
+      expect(page).to have_selector("span.fa.fa-cubes.collection-icon-search")
+    end
+  end
+end

data/spec/views/content_blocks/edit.html.erb_spec.rb

@@ -0,0 +1,21 @@
+RSpec.describe "hyrax/content_blocks/edit", type: :view do
+  before { render }
+
+  it "renders the announcement form" do
+    assert_select "form[action=?][method=?]", hyrax.content_block_path(ContentBlock.for(:announcement)), "post" do
+      assert_select "textarea#content_block_announcement[name=?]", "content_block[announcement]"
+    end
+  end
+
+  it "renders the marketing form" do
+    assert_select "form[action=?][method=?]", hyrax.content_block_path(ContentBlock.for(:marketing)), "post" do
+      assert_select "textarea#content_block_marketing[name=?]", "content_block[marketing]"
+    end
+  end
+
+  it "renders the researcher form" do
+    assert_select "form[action=?][method=?]", hyrax.content_block_path(ContentBlock.for(:researcher)), "post" do
+      assert_select "textarea#content_block_researcher[name=?]", "content_block[researcher]"
+    end
+  end
+end

data/spec/views/hyrax/admin/admin_sets/_form.html.erb_spec.rb

@@ -0,0 +1,29 @@
+RSpec.describe 'hyrax/admin/admin_sets/_form.html.erb', type: :view do
+  let(:admin_set) { stub_model(AdminSet) }
+  let(:form) { Hyrax::Forms::AdminSetForm.new(admin_set, double, double) }
+
+  before do
+    assign(:form, form)
+    stub_template('hyrax/admin/admin_sets/_form_participants.html.erb' => 'participant tab')
+    stub_template('hyrax/admin/admin_sets/_form_visibility.html.erb' => 'visibility tab')
+    stub_template('hyrax/admin/admin_sets/_form_workflow.html.erb' => 'workflow tab')
+    allow(form).to receive(:thumbnail_title).and_return("James Joyce")
+    allow(admin_set).to receive(:member_ids).and_return(['123', '456'])
+    render
+  end
+
+  it "has 4 tabs" do
+    expect(rendered).to have_selector('#description')
+    expect(rendered).to have_content('participant tab')
+    expect(rendered).to have_content('visibility tab')
+    expect(rendered).to have_content('workflow tab')
+
+    # metadata fields
+    expect(rendered).to have_selector('input[type=text][name="admin_set[title]"]')
+    expect(rendered).to have_selector('textarea[name="admin_set[description]"]')
+    expect(rendered).to have_selector('input[type=text][name="admin_set[thumbnail_id]"][data-text="James Joyce"]')
+
+    # hint text
+    expect(rendered).to have_content("A name to aid in identifying the Administrative Set and to distinguish it from other Administrative Sets in the repository.")
+  end
+end