hyrax 2.0.3 → 2.1.0.beta1

data/spec/views/_flash_msg.html.erb_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 RSpec.describe '/_flash_msg.html.erb', type: :view do
   before do
     allow(view).to receive(:flash).and_return(flash)

data/spec/views/_user_util_links.html.erb_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 RSpec.describe '/_user_util_links.html.erb', type: :view do
   let(:join_date) { 5.days.ago }
   let(:can_create_file) { true }

data/spec/views/catalog/_index_list_default.html.erb_spec.rb

@@ -21,23 +21,23 @@ RSpec.describe 'catalog/_index_list_default', type: :view do
 
   it "displays metadata" do
     expect(rendered).not_to include 'Title:'
-    expect(rendered).to include '<span class="attribute-label h4">Creator:</span>'
+    expect(rendered).to include 'Creator:'
     expect(rendered).to include 'Test creator_tesim'
-    expect(rendered).to include '<span class="attribute-label h4">Description:</span>'
+    expect(rendered).to include 'Description:'
     expect(rendered).to include 'Test description_tesim'
-    expect(rendered).to include '<span class="attribute-label h4">Date Uploaded:</span>'
+    expect(rendered).to include 'Date Uploaded:'
     expect(rendered).to include 'Test date_uploaded_dtsi'
-    expect(rendered).to include '<span class="attribute-label h4">Date Modified:</span>'
+    expect(rendered).to include 'Date Modified:'
     expect(rendered).to include 'Test date_modified_dtsi'
-    expect(rendered).to include '<span class="attribute-label h4">Depositor:</span>'
+    expect(rendered).to include 'Depositor:'
     expect(rendered).to include 'Test proxy_depositor_ssim'
-    expect(rendered).to include '<span class="attribute-label h4">Owner:</span>'
+    expect(rendered).to include 'Owner:'
     expect(rendered).to include 'Test depositor_tesim'
-    expect(rendered).to include '<span class="attribute-label h4">Rights Statement:</span>'
+    expect(rendered).to include 'Rights Statement:'
     expect(rendered).to include 'Test rights_statement_tesim'
-    expect(rendered).to include '<span class="attribute-label h4">Embargo release date:</span>'
+    expect(rendered).to include 'Embargo release date:'
     expect(rendered).to include 'Test embargo_release_date_dtsi'
-    expect(rendered).to include '<span class="attribute-label h4">Lease expiration date:</span>'
+    expect(rendered).to include 'Lease expiration date:'
     expect(rendered).to include 'Test lease_expiration_date_dtsi'
   end
 end

data/spec/views/hyrax/admin/admin_sets/_form_participant_table.html.erb_spec.rb

@@ -1,12 +1,13 @@
 RSpec.describe 'hyrax/admin/admin_sets/_form_participant_table.html.erb', type: :view do
   let(:template) { stub_model(Hyrax::PermissionTemplate) }
+  let(:admin) { create(:admin) }
   let(:user) { create(:user) }
-  let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+  let(:access_grants) { [stub_model(Hyrax::PermissionTemplateAccess)] }
   let(:pt_form) do
     instance_double(Hyrax::Forms::PermissionTemplateForm,
                     model_name: template.model_name,
                     to_key: template.to_key,
-                    access_grants: [access_grant])
+                    access_grants: access_grants)
   end
 
   before do
@@ -23,20 +24,27 @@ RSpec.describe 'hyrax/admin/admin_sets/_form_participant_table.html.erb', type:
     end
 
     context "managers exist" do
-      let(:access_grant) do
-        stub_model(Hyrax::PermissionTemplateAccess,
-                   agent_type: 'user',
-                   agent_id: user.user_key,
-                   access: 'manage')
+      let(:access_grants) do
+        [stub_model(Hyrax::PermissionTemplateAccess,
+                    agent_type: 'user',
+                    agent_id: user.user_key,
+                    access: 'manage'),
+         stub_model(Hyrax::PermissionTemplateAccess,
+                    agent_type: 'group',
+                    agent_id: Ability.admin_group_name,
+                    access: 'manage')]
       end
 
       it "lists the managers in the table" do
         expect(rendered).to have_selector("h3", text: "Managers")
         expect(rendered).to have_selector("table tbody", text: user.user_key)
+        expect(rendered).to have_selector("table tbody", text: 'Repository Administrators')
+        expect(rendered).to have_button(class: 'btn-danger', disabled: true,
+                                        title: 'The repository administrators group cannot be removed')
       end
     end
     context "no managers exist" do
-      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+      let(:access_grants) { [stub_model(Hyrax::PermissionTemplateAccess)] }
 
       it "displays a message and no table" do
         expect(rendered).to have_selector("h3", text: "Managers")
@@ -52,20 +60,27 @@ RSpec.describe 'hyrax/admin/admin_sets/_form_participant_table.html.erb', type:
     end
 
     context "viewers exist" do
-      let(:access_grant) do
-        stub_model(Hyrax::PermissionTemplateAccess,
-                   agent_type: 'user',
-                   agent_id: user.user_key,
-                   access: 'view')
+      let(:access_grants) do
+        [stub_model(Hyrax::PermissionTemplateAccess,
+                    agent_type: 'user',
+                    agent_id: user.user_key,
+                    access: 'view'),
+         stub_model(Hyrax::PermissionTemplateAccess,
+                    agent_type: 'group',
+                    agent_id: Ability.admin_group_name,
+                    access: 'view')]
       end
 
       it "lists the viewers in the table" do
         expect(rendered).to have_selector("h3", text: "Viewers")
         expect(rendered).to have_selector("table tbody", text: user.user_key)
+        expect(rendered).to have_selector("table tbody", text: 'Repository Administrators')
+        expect(rendered).not_to have_button(class: 'btn-danger', disabled: true,
+                                            title: 'The repository administrators group cannot be removed')
       end
     end
     context "no viewers exist" do
-      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+      let(:access_grants) { [stub_model(Hyrax::PermissionTemplateAccess)] }
 
       it "displays a message and no table" do
         expect(rendered).to have_selector("h3", text: "Viewers")
@@ -81,20 +96,27 @@ RSpec.describe 'hyrax/admin/admin_sets/_form_participant_table.html.erb', type:
     end
 
     context "depositors exist" do
-      let(:access_grant) do
-        stub_model(Hyrax::PermissionTemplateAccess,
-                   agent_type: 'user',
-                   agent_id: user.user_key,
-                   access: 'deposit')
+      let(:access_grants) do
+        [stub_model(Hyrax::PermissionTemplateAccess,
+                    agent_type: 'user',
+                    agent_id: user.user_key,
+                    access: 'deposit'),
+         stub_model(Hyrax::PermissionTemplateAccess,
+                    agent_type: 'group',
+                    agent_id: Ability.admin_group_name,
+                    access: 'deposit')]
       end
 
       it "lists the depositors in the table" do
         expect(rendered).to have_selector("h3", text: "Depositors")
         expect(rendered).to have_selector("table tbody", text: user.user_key)
+        expect(rendered).to have_selector("table tbody", text: 'Repository Administrators')
+        expect(rendered).not_to have_button(class: 'btn-danger', disabled: true,
+                                            title: 'The repository administrators group cannot be removed')
       end
     end
     context "no depositors exist" do
-      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+      let(:access_grants) { [stub_model(Hyrax::PermissionTemplateAccess)] }
 
       it "displays a message and no table" do
         expect(rendered).to have_selector("h3", text: "Depositors")

data/spec/views/hyrax/admin/collection_types/_form.html.erb_spec.rb

@@ -0,0 +1,43 @@
+RSpec.describe 'hyrax/admin/collection_types/_form.html.erb', type: :view do
+  let(:collection_type) { build(:collection_type) }
+  # let(:collection_type) { build(:collection_type, machine_id: "type_does_not_matter") }
+  let(:form) { Hyrax::Forms::Admin::CollectionTypeForm.new(collection_type: collection_type) }
+
+  before do
+    assign(:form, form)
+    assign(:collection_type, collection_type)
+  end
+
+  it "has 3 tabs" do
+    render
+    expect(rendered).to have_selector('#metadata')
+    expect(rendered).to have_selector('#settings')
+    expect(rendered).to have_selector('#participants')
+  end
+
+  context "when creating a new collection type" do
+    before do
+      allow(form).to receive(:persisted?).and_return(false)
+    end
+
+    it "only shows the metadata tab" do
+      render
+      expect(rendered).to have_link(I18n.t('hyrax.admin.collection_types.form.tab.metadata'))
+      expect(rendered).not_to have_link(I18n.t('hyrax.admin.collection_types.form.tab.settings'))
+      expect(rendered).not_to have_link(I18n.t('hyrax.admin.collection_types.form.tab.participants'))
+    end
+  end
+
+  context "when editing a collection type" do
+    before do
+      allow(form).to receive(:persisted?).and_return(true)
+    end
+
+    it "shows all three tabs" do
+      render
+      expect(rendered).to have_link(I18n.t('hyrax.admin.collection_types.form.tab.metadata'))
+      expect(rendered).to have_link(I18n.t('hyrax.admin.collection_types.form.tab.settings'))
+      expect(rendered).to have_link(I18n.t('hyrax.admin.collection_types.form.tab.participants'))
+    end
+  end
+end

data/spec/views/hyrax/admin/collection_types/_form_metadata.html.erb_spec.rb

@@ -0,0 +1,27 @@
+RSpec.describe 'hyrax/admin/collection_types/_form_metadata.html.erb', type: :view do
+  let(:collection_type) { create(:collection_type) }
+  let(:collection_type_form) { Hyrax::Forms::Admin::CollectionTypeForm.new }
+
+  let(:form) do
+    view.simple_form_for(collection_type, url: '/update') do |fs_form|
+      return fs_form
+    end
+  end
+
+  before do
+    assign(:form, collection_type_form)
+    allow(view).to receive(:f).and_return(form)
+    render
+  end
+
+  it "renders the name field" do
+    expect(rendered).to have_content(I18n.t("simple_form.labels.collection_type.title"))
+    expect(rendered).to have_selector("input#collection_type_title")
+    expect(rendered).not_to have_css("#collection_type_title[disabled]")
+  end
+
+  it "renders the description field" do
+    expect(rendered).to have_content(I18n.t("simple_form.labels.collection_type.description"))
+    expect(rendered).to have_selector("textarea#collection_type_description")
+  end
+end

data/spec/views/hyrax/admin/collection_types/_form_metadata_admin_set.html.erb_spec.rb

@@ -0,0 +1,27 @@
+RSpec.describe 'hyrax/admin/collection_types/_form_metadata_admin_set.html.erb', type: :view do
+  let(:collection_type) { create(:admin_set_collection_type) }
+  let(:collection_type_form) { Hyrax::Forms::Admin::CollectionTypeForm.new }
+
+  let(:form) do
+    view.simple_form_for(collection_type, url: '/update') do |fs_form|
+      return fs_form
+    end
+  end
+
+  before do
+    assign(:form, collection_type_form)
+    allow(view).to receive(:f).and_return(form)
+    render
+  end
+
+  it "renders the name field as readonly" do
+    expect(rendered).to have_content(I18n.t("simple_form.labels.collection_type.title"))
+    expect(rendered).to have_selector("input#collection_type_title")
+    expect(rendered).to have_css("#collection_type_title[disabled]")
+  end
+
+  it "renders the description field" do
+    expect(rendered).to have_content(I18n.t("simple_form.labels.collection_type.description"))
+    expect(rendered).to have_selector("textarea#collection_type_description")
+  end
+end

data/spec/views/hyrax/admin/collection_types/_form_participants.html.erb_spec.rb

@@ -0,0 +1,16 @@
+RSpec.describe 'hyrax/admin/collection_types/_form_participants.html.erb', type: :view do
+  let(:collection_type) { build(:collection_type) }
+  let(:form) { Hyrax::Forms::Admin::CollectionTypeForm.new(collection_type: collection_type) }
+  let(:collection_type_participant) { build(:collection_type_participant) }
+  let(:participant_form) { Hyrax::Forms::Admin::CollectionTypeParticipantForm.new(collection_type_participant: collection_type_participant) }
+
+  before do
+    assign(:collection_type_participant, participant_form)
+    assign(:form, form)
+    render
+  end
+  it 'has the required selectors' do
+    expect(rendered).to have_selector('#user-participants-form')
+    expect(rendered).to have_selector('#group-participants-form')
+  end
+end

data/spec/views/hyrax/admin/collection_types/_form_participants_table.html.erb_spec.rb

@@ -0,0 +1,73 @@
+RSpec.describe 'hyrax/admin/collection_types/_form_participant_table.html.erb', type: :view do
+  let(:user) { create(:user) }
+  let(:collection_type) { stub_model(Hyrax::CollectionType) }
+  let(:collection_type_participant) { stub_model(Hyrax::CollectionTypeParticipant) }
+  let(:form) do
+    instance_double(Hyrax::Forms::Admin::CollectionTypeForm,
+                    model_name: collection_type.model_name,
+                    collection_type_participants: [collection_type_participant])
+  end
+
+  before do
+    assign(:form, form)
+  end
+
+  describe 'Manager participants table' do
+    before do
+      render 'form_participant_table', access: 'managers', filter: :manager?
+    end
+
+    context 'managers exist' do
+      let(:collection_type_participant) do
+        stub_model(Hyrax::CollectionTypeParticipant,
+                   agent_type: 'user',
+                   agent_id: user.user_key,
+                   access: Hyrax::CollectionTypeParticipant::MANAGE_ACCESS)
+      end
+
+      it 'lists the managers in the table' do
+        expect(rendered).to have_selector('h3', text: 'Managers')
+        expect(rendered).to have_selector('table tbody', text: user.user_key)
+      end
+    end
+
+    context 'no managers exist' do
+      let(:collection_type_participant) { stub_model(Hyrax::CollectionTypeParticipant) }
+
+      it 'displays a message and no table' do
+        expect(rendered).to have_selector('h3', text: 'Managers')
+        expect(rendered).not_to have_selector('table')
+        expect(rendered).to have_content('No managers have been added to this collection type.')
+      end
+    end
+  end
+
+  describe 'Creator participants table' do
+    before do
+      render 'form_participant_table', access: 'creators', filter: :creator?
+    end
+
+    context 'creators exist' do
+      let(:collection_type_participant) do
+        stub_model(Hyrax::CollectionTypeParticipant,
+                   agent_type: 'user',
+                   agent_id: user.user_key,
+                   access: Hyrax::CollectionTypeParticipant::CREATE_ACCESS)
+      end
+
+      it 'lists the creators in the table' do
+        expect(rendered).to have_selector('h3', text: 'Creators')
+        expect(rendered).to have_selector('table tbody', text: user.user_key)
+      end
+    end
+    context 'no creators exist' do
+      let(:collection_type_participant) { stub_model(Hyrax::CollectionTypeParticipant) }
+
+      it 'displays a message and no table' do
+        expect(rendered).to have_selector('h3', text: 'Creators')
+        expect(rendered).not_to have_selector('table')
+        expect(rendered).to have_content('No creators have been added to this collection type.')
+      end
+    end
+  end
+end

data/spec/views/hyrax/admin/collection_types/_form_settings.html.erb_spec.rb

@@ -0,0 +1,106 @@
+RSpec.describe 'hyrax/admin/collection_types/_form_settings.html.erb', type: :view do
+  # TODO: add fields as they become available:
+  # collection_type_assigns_workflow
+  # collection_type_require_membership
+  # collection_type_assigns_visibility
+
+  INPUT_IDS = %w[
+    collection_type_nestable
+    collection_type_discoverable
+    collection_type_sharable
+    collection_type_share_applies_to_new_works
+    collection_type_allow_multiple_membership
+  ].freeze
+
+  let(:collection_type_form) { Hyrax::Forms::Admin::CollectionTypeForm.new }
+
+  let(:form) do
+    view.simple_form_for(collection_type, url: '/update') do |fs_form|
+      return fs_form
+    end
+  end
+
+  before do
+    allow(view).to receive(:f).and_return(form)
+    allow(form).to receive(:object).and_return(collection_type_form)
+  end
+
+  context 'for non-special collection types' do
+    let(:collection_type) { create(:collection_type) }
+
+    context "when collection_type.collections? is false" do
+      before do
+        collection_type_form.collection_type = collection_type
+        allow(collection_type).to receive(:collections?).and_return(false)
+        render
+      end
+
+      it "renders the intructions and warning" do
+        expect(rendered).to match(I18n.t("hyrax.admin.collection_types.form_settings.instructions"))
+        expect(rendered).to match(I18n.t("hyrax.admin.collection_types.form_settings.warning"))
+      end
+
+      INPUT_IDS.each do |id|
+        it "renders the #{id} checkbox to be enabled" do
+          match = rendered.match(/(<input.*id="#{id}".*)/)
+          expect(match).not_to be_nil
+          expect(match[1].index('disabled="disabled"')).to be_nil
+        end
+      end
+    end
+
+    context "when collection_type.collections? is true" do
+      before do
+        collection_type_form.collection_type = collection_type
+        allow(collection_type).to receive(:collections?).and_return(true)
+        assign(:form, collection_type_form)
+        allow(view).to receive(:f).and_return(form)
+        render
+      end
+
+      INPUT_IDS.each do |id|
+        it "renders the #{id} checkbox to be disabled" do
+          match = rendered.match(/(<input.*id="#{id}".*)/)
+          expect(match).not_to be_nil
+          expect(match[1].index('disabled="disabled"')).not_to be_nil
+        end
+      end
+    end
+  end
+
+  context 'for admin set collection type' do
+    let(:collection_type) { create(:admin_set_collection_type) }
+
+    before do
+      collection_type_form.collection_type = collection_type
+      allow(collection_type).to receive(:collections?).and_return(false)
+      render
+    end
+
+    INPUT_IDS.each do |id|
+      it "renders the #{id} checkbox to be disabled" do
+        match = rendered.match(/(<input.*id="#{id}".*)/)
+        expect(match).not_to be_nil
+        expect(match[1].index('disabled="disabled"')).not_to be_nil
+      end
+    end
+  end
+
+  context 'for user collection type' do
+    let(:collection_type) { create(:user_collection_type) }
+
+    before do
+      collection_type_form.collection_type = collection_type
+      allow(collection_type).to receive(:collections?).and_return(false)
+      render
+    end
+
+    INPUT_IDS.each do |id|
+      it "renders the #{id} checkbox to be disabled" do
+        match = rendered.match(/(<input.*id="#{id}".*)/)
+        expect(match).not_to be_nil
+        expect(match[1].index('disabled="disabled"')).not_to be_nil
+      end
+    end
+  end
+end