hyrax 2.0.3 → 2.1.0.beta1

data/spec/controllers/hyrax/admin/admin_sets_controller_spec.rb

@@ -148,9 +148,35 @@ RSpec.describe Hyrax::Admin::AdminSetsController do
 
       context "with empty admin set" do
         it "deletes the admin set" do
+          controller.request.set_header("HTTP_REFERER", "/admin/admin_sets")
           delete :destroy, params: { id: admin_set }
+
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(my_collections_path)
+          expect(flash[:notice]).to eq "Administrative set successfully deleted"
+          expect(AdminSet.exists?(admin_set.id)).to be false
+        end
+      end
+
+      context "with empty admin set and referrer from the my/collections dashboard" do
+        it "deletes the admin set" do
+          controller.request.set_header("HTTP_REFERER", "/my/collections")
+          delete :destroy, params: { id: admin_set }
+
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(my_collections_path)
+          expect(flash[:notice]).to eq "Administrative set successfully deleted"
+          expect(AdminSet.exists?(admin_set.id)).to be false
+        end
+      end
+
+      context "with empty admin set and referrer from the /collections dashboard" do
+        it "deletes the admin set" do
+          controller.request.set_header("HTTP_REFERER", "/collections")
+          delete :destroy, params: { id: admin_set }
+
           expect(response).to have_http_status(:found)
-          expect(response).to redirect_to(admin_admin_sets_path)
+          expect(response).to redirect_to(dashboard_collections_path)
           expect(flash[:notice]).to eq "Administrative set successfully deleted"
           expect(AdminSet.exists?(admin_set.id)).to be false
         end

data/spec/controllers/hyrax/admin/collection_type_participants_controller_spec.rb

@@ -0,0 +1,152 @@
+RSpec.describe Hyrax::Admin::CollectionTypeParticipantsController, type: :controller do
+  context 'anonymous user' do
+    let(:collection_type) { create(:collection_type) }
+    let(:valid_attributes) do
+      {
+        hyrax_collection_type_id: collection_type.id,
+        access: 'creator',
+        agent_id: 'example@example.com',
+        agent_type: 'user'
+      }
+    end
+
+    describe '#create' do
+      it 'does not create a pariticpant' do
+        post :create
+        expect do
+          post :create, params: { collection_type_participant: valid_attributes }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+
+      it "returns http redirect" do
+        post :create
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe '#destroy' do
+      let!(:collection_type_participant) { create(:collection_type_participant) }
+
+      it 'does not destroy a participant' do
+        expect do
+          delete :destroy, params: { id: collection_type_participant.to_param }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+
+      it "returns http redirect" do
+        delete :destroy, params: { id: collection_type_participant.to_param }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+  end
+
+  context "unauthorized user" do
+    let(:user) { create(:user) }
+    let(:collection_type) { create(:collection_type) }
+    let(:valid_attributes) do
+      {
+        hyrax_collection_type_id: collection_type.id,
+        access: 'creator',
+        agent_id: 'example@example.com',
+        agent_type: 'user'
+      }
+    end
+
+    before do
+      allow(controller.current_ability).to receive(:can?).with(any_args).and_return(false)
+      sign_in user
+    end
+
+    describe "#create" do
+      it 'does not create a pariticpant' do
+        post :create
+        expect do
+          post :create, params: { collection_type_participant: valid_attributes }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+
+      it "returns http redirect" do
+        post :create
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#destroy" do
+      let!(:collection_type_participant) { create(:collection_type_participant) }
+
+      it 'does not destroy a participants' do
+        expect do
+          delete :destroy, params: { id: collection_type_participant.to_param }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+      it "returns http redirect" do
+        delete :destroy, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+  end
+
+  context "authorized user" do
+    let(:collection_type) { create(:collection_type) }
+    let(:valid_attributes) do
+      {
+        hyrax_collection_type_id: collection_type.id,
+        access: Hyrax::CollectionTypeParticipant::CREATE_ACCESS,
+        agent_id: 'example@example.com',
+        agent_type: 'user'
+      }
+    end
+
+    let(:valid_session) { {} }
+    let(:collection_type_participant) { create(:collection_type_participant) }
+    let(:user) { create(:user) }
+
+    before do
+      allow(controller.current_ability).to receive(:can?).with(any_args).and_return(true)
+      sign_in user
+    end
+
+    describe "#create" do
+      context "with valid params" do
+        it "creates a new CollectionTypeParticipant" do
+          expect do
+            post :create, params: { collection_type_participant: valid_attributes }, session: valid_session
+          end.to change(Hyrax::CollectionTypeParticipant, :count).by(1)
+        end
+
+        it "redirects to the edit_admin_collection_type with participants panel active" do
+          post :create, params: { collection_type_participant: valid_attributes }, session: valid_session
+          expect(response).to redirect_to(edit_admin_collection_type_path(collection_type.id, anchor: 'participants'))
+        end
+
+        it "assigns all attributes" do
+          post :create, params: { collection_type_participant: valid_attributes }, session: valid_session
+          expect(assigns[:collection_type_participant].attributes.symbolize_keys).to include(valid_attributes)
+        end
+      end
+
+      context "with invalid params" do
+        it "does not create a new CollectionTypeParticipant" do
+          post :create, params: { collection_type_participant: { hyrax_collection_type_id: '1' } }, session: valid_session
+          expect do
+            post :create, params: { collection_type_participant: { hyrax_collection_type_id: '1' } }, session: valid_session
+          end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+        end
+      end
+    end
+
+    describe "#destroy" do
+      it "destroys the requested collection_type_participant" do
+        expect(collection_type_participant).to be_persisted
+        expect do
+          delete :destroy, params: { id: collection_type_participant.to_param }, session: valid_session
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(-1)
+      end
+
+      it "redirects to edit the collections participants list" do
+        delete :destroy, params: { id: collection_type_participant.to_param }, session: valid_session
+        expect(response).to redirect_to(edit_admin_collection_type_path(collection_type_participant.hyrax_collection_type_id, anchor: 'participants'))
+      end
+    end
+  end
+end

data/spec/controllers/hyrax/admin/collection_types_controller_spec.rb

@@ -0,0 +1,320 @@
+RSpec.describe Hyrax::Admin::CollectionTypesController, type: :controller, clean_repo: true do
+  context "anonymous user" do
+    describe "#index" do
+      it "returns http redirect" do
+        get :index
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#create" do
+      it "returns http redirect" do
+        post :create
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#new" do
+      it "returns http redirect" do
+        get :new
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#edit" do
+      it "returns http redirect" do
+        get :edit, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#update" do
+      it "returns http redirect" do
+        put :update, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#destroy" do
+      it "returns http redirect" do
+        delete :destroy, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+  end
+
+  context "unauthorized user" do
+    let(:user) { create(:user) }
+
+    before do
+      allow(controller.current_ability).to receive(:can?).with(any_args).and_return(false)
+      sign_in user
+    end
+
+    describe "#index" do
+      it "returns http redirect" do
+        get :index
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#create" do
+      it "returns http redirect" do
+        post :create
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#new" do
+      it "returns http redirect" do
+        get :new
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#edit" do
+      it "returns http redirect" do
+        get :edit, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#update" do
+      it "returns http redirect" do
+        put :update, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#destroy" do
+      it "returns http redirect" do
+        delete :destroy, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+  end
+
+  context "authorized user" do
+    let(:valid_attributes) do
+      {
+        title: 'Collection type title',
+        description: 'Description of collection type',
+        nestable: true,
+        discoverable: true,
+        sharable: true,
+        share_applies_to_new_works: true,
+        allow_multiple_membership: true,
+        require_membership: true,
+        assigns_workflow: true,
+        assigns_visibility: true
+      }
+    end
+
+    let(:valid_session) { {} }
+    let(:collection_type) { create(:collection_type) }
+    let(:user) { create(:user) }
+
+    before do
+      allow(controller.current_ability).to receive(:can?).with(any_args).and_return(true)
+      sign_in user
+    end
+
+    describe "#index" do
+      it "returns http success" do
+        get :index
+        expect(response).to have_http_status(:success)
+      end
+
+      it 'adds breadcrumbs' do
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.controls.home'), root_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.breadcrumbs.admin'), dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.sidebar.configuration'), '#')
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.index.breadcrumb'), admin_collection_types_path)
+        get :index
+        expect(response).to be_success
+        expect(response).to render_template "layouts/hyrax/dashboard"
+      end
+    end
+
+    describe "#create", :clean_repo do
+      context "with valid params" do
+        it "creates a new CollectionType" do
+          expect do
+            post :create, params: { collection_type: valid_attributes }, session: valid_session
+          end.to change(Hyrax::CollectionType, :count).by(1)
+        end
+
+        it "redirects to the created collection_type" do
+          post :create, params: { collection_type: valid_attributes }, session: valid_session
+          expect(response).to redirect_to(edit_admin_collection_type_path(Hyrax::CollectionType.last))
+        end
+
+        it "assigns all attributes" do
+          post :create, params: { collection_type: valid_attributes }, session: valid_session
+          expect(assigns[:collection_type].attributes.symbolize_keys).to include(valid_attributes)
+        end
+
+        it "assigns default participants" do
+          expect do
+            post :create, params: { collection_type: valid_attributes }, session: valid_session
+          end.to change(Hyrax::CollectionTypeParticipant, :count).by(2)
+        end
+      end
+
+      context "with invalid params" do
+        it "returns a success response (i.e. to display the 'new' template)" do
+          post :create, params: { collection_type: { title: collection_type.title } }, session: valid_session
+          expect(response).to be_success
+        end
+
+        it 'adds breadcrumbs' do
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.controls.home'), root_path)
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.breadcrumbs.admin'), dashboard_path)
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.sidebar.configuration'), '#')
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.index.breadcrumb'), admin_collection_types_path)
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.new.header'), new_admin_collection_type_path)
+          post :create, params: { collection_type: { title: collection_type.title } }, session: valid_session
+          expect(response).to be_success
+          expect(response).to render_template "layouts/hyrax/dashboard"
+        end
+
+        it 'defines a form' do
+          post :create, params: { collection_type: { title: collection_type.title } }, session: valid_session
+          expect(response).to be_success
+          expect(assigns[:form]).to be_kind_of Hyrax::Forms::Admin::CollectionTypeForm
+        end
+      end
+    end
+
+    describe "#new" do
+      it "returns http success" do
+        get :new
+        expect(response).to have_http_status(:success)
+      end
+
+      it 'adds breadcrumbs' do
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.controls.home'), root_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.breadcrumbs.admin'), dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.sidebar.configuration'), '#')
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.index.breadcrumb'), admin_collection_types_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.new.header'), new_admin_collection_type_path)
+        get :new
+        expect(response).to be_success
+        expect(response).to render_template "layouts/hyrax/dashboard"
+      end
+
+      it 'defines a form' do
+        get :new
+        expect(response).to be_success
+        expect(assigns[:form]).to be_kind_of Hyrax::Forms::Admin::CollectionTypeForm
+      end
+    end
+
+    describe "#edit" do
+      it "returns http success" do
+        get :edit, params: { id: collection_type.to_param }
+        expect(response).to have_http_status(:success)
+      end
+
+      it 'adds breadcrumbs' do
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.controls.home'), root_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.breadcrumbs.admin'), dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.sidebar.configuration'), '#')
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.index.breadcrumb'), admin_collection_types_path)
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.edit.header'), edit_admin_collection_type_path(collection_type.to_param))
+        get :edit, params: { id: collection_type.to_param }
+        expect(response).to be_success
+        expect(response).to render_template "layouts/hyrax/dashboard"
+      end
+
+      it 'defines a form' do
+        get :edit, params: { id: collection_type.to_param }
+        expect(response).to be_success
+        expect(assigns[:form]).to be_kind_of Hyrax::Forms::Admin::CollectionTypeForm
+      end
+    end
+
+    describe "#update", :clean_repo do
+      let(:new_attributes) do
+        {
+          title: 'Improved title',
+          nestable: false,
+          discoverable: false,
+          sharable: false,
+          share_applies_to_new_works: false,
+          allow_multiple_membership: false,
+          require_membership: true,
+          assigns_workflow: true,
+          assigns_visibility: true
+        }
+      end
+
+      context "with valid params" do
+        it 'updates a record' do
+          put :update, params: { id: collection_type.to_param, collection_type: new_attributes }, session: valid_session
+          collection_type.reload
+          expect(assigns[:collection_type].attributes.symbolize_keys).to include(new_attributes)
+        end
+
+        it "redirects to the collection_type" do
+          put :update, params: { id: collection_type.to_param, collection_type: valid_attributes }, session: valid_session
+          expect(response).to redirect_to(edit_admin_collection_type_path(collection_type))
+        end
+      end
+
+      context "with invalid params" do
+        let(:existing_collection_type) { create(:collection_type) }
+        let(:invalid_attributes) { { title: existing_collection_type.title } }
+
+        it "returns a success response (i.e. to display the 'edit' template)" do
+          put :update, params: { id: collection_type.to_param, collection_type: invalid_attributes }, session: valid_session
+          expect(response).to have_http_status(:success)
+        end
+
+        it 'adds breadcrumbs' do
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.controls.home'), root_path)
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.breadcrumbs.admin'), dashboard_path)
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.sidebar.configuration'), '#')
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.index.breadcrumb'), admin_collection_types_path)
+          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.admin.collection_types.edit.header'), edit_admin_collection_type_path(collection_type.to_param))
+          put :update, params: { id: collection_type.to_param, collection_type: invalid_attributes }, session: valid_session
+          expect(response).to be_success
+          expect(response).to render_template "layouts/hyrax/dashboard"
+        end
+
+        it 'defines a form' do
+          put :update, params: { id: collection_type.to_param, collection_type: invalid_attributes }, session: valid_session
+          expect(response).to be_success
+          expect(assigns[:form]).to be_kind_of Hyrax::Forms::Admin::CollectionTypeForm
+        end
+      end
+    end
+
+    describe "#destroy" do
+      let!(:collection_type_to_destroy) { create(:collection_type) }
+
+      context "when no collections of this type" do
+        it "deletes the collection_type" do
+          delete :destroy, params: { id: collection_type_to_destroy }
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(admin_collection_types_path)
+          expect(flash[:notice]).to eq "The collection type #{collection_type_to_destroy.title} has been deleted."
+          expect(Hyrax::CollectionType.exists?(collection_type_to_destroy.id)).to be false
+        end
+      end
+
+      context "when collections exist of this type" do
+        let!(:collection) { create(:collection, collection_type_gid: collection_type_to_destroy.gid) }
+
+        it "doesn't delete the collection type or collection" do
+          delete :destroy, params: { id: collection_type_to_destroy }
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(admin_collection_types_path)
+          expect(flash[:alert]).to eq "Collection type cannot be altered as it has collections"
+          expect(Hyrax::CollectionType.exists?(collection_type_to_destroy.id)).to be true
+          expect(Collection.exists?(collection.id)).to be true
+        end
+      end
+    end
+  end
+end