hyrax 2.0.3 → 2.1.0.beta1

data/spec/models/concerns/hyrax/collection_nesting_spec.rb

@@ -0,0 +1,64 @@
+RSpec.describe Hyrax::CollectionNesting do
+  describe 'including this module' do
+    let(:klass) do
+      Class.new do
+        extend ActiveModel::Callbacks
+        include ActiveModel::Validations::Callbacks
+        # Because we need these declared before we include the Hyrax::CollectionNesting
+        define_model_callbacks :destroy, only: :after
+
+        def destroy
+          true
+        end
+
+        def update_index
+          true
+        end
+
+        include Hyrax::CollectionNesting
+
+        attr_accessor :id
+      end
+    end
+
+    let(:user) { create(:user) }
+    let!(:collection) { create(:collection, collection_type_settings: [:nestable]) }
+    let!(:child_collection) { create(:collection, collection_type_settings: [:nestable]) }
+
+    before do
+      Hyrax::Collections::NestedCollectionPersistenceService.persist_nested_collection_for(parent: collection, child: child_collection)
+    end
+
+    subject { klass.new.tap { |obj| obj.id = collection.id } }
+
+    it { is_expected.to callback(:update_nested_collection_relationship_indices).after(:update_index) }
+    it { is_expected.to callback(:update_child_nested_collection_relationship_indices).after(:destroy) }
+    it { is_expected.to respond_to(:update_nested_collection_relationship_indices) }
+    it { is_expected.to respond_to(:update_child_nested_collection_relationship_indices) }
+    it { is_expected.to respond_to(:use_nested_reindexing?) }
+
+    context 'after_update_index callback' do
+      describe '#update_nested_collection_relationship_indices' do
+        it 'will call Hyrax.config.nested_relationship_reindexer' do
+          expect(Hyrax.config.nested_relationship_reindexer).to receive(:call).with(id: subject.id).and_call_original
+          subject.update_nested_collection_relationship_indices
+        end
+      end
+    end
+
+    context 'after_destroy callback' do
+      describe '#update_child_nested_collection_relationship_indices' do
+        it 'will call Hyrax.config.nested_relationship_reindexer' do
+          expect(Hyrax.config.nested_relationship_reindexer).to receive(:call).with(id: child_collection.id).and_call_original
+          subject.update_child_nested_collection_relationship_indices
+        end
+      end
+
+      describe '#find_children_of' do
+        it 'will return an array containing the child collection ids' do
+          expect(subject.find_children_of(destroyed_id: collection.id).first.id).to eq(child_collection.id)
+        end
+      end
+    end
+  end
+end

data/spec/models/file_set_spec.rb

@@ -213,7 +213,7 @@ RSpec.describe FileSet do
     end
 
     context 'when there are related files' do
-      let(:parent_work)   { FactoryBot.create(:work_with_files) }
+      let(:parent_work)   { create(:work_with_files) }
       let(:f1)            { parent_work.file_sets.first }
       let(:f2)            { parent_work.file_sets.last }
 
@@ -227,12 +227,12 @@ RSpec.describe FileSet do
   end
 
   describe 'noid integration', :clean_repo do
-    let(:service) { instance_double(ActiveFedora::Noid::Service, mint: noid) }
+    let(:service) { instance_double(::Noid::Rails::Service, mint: noid) }
     let(:noid) { 'wd3763094' }
     let!(:default) { Hyrax.config.enable_noids? }
 
     before do
-      allow(ActiveFedora::Noid::Service).to receive(:new).and_return(service)
+      allow(::Noid::Rails::Service).to receive(:new).and_return(service)
     end
 
     after { Hyrax.config.enable_noids = default }
@@ -658,7 +658,7 @@ RSpec.describe FileSet do
     end
   end
 
-  describe "#to_global_id" do
+  describe "#to_global_id", clean_repo: true do
     let(:file_set) { described_class.new(id: '123') }
 
     subject { file_set.to_global_id }

data/spec/models/generic_work_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe GenericWork do
   end
 
   describe "to_sipity_entity" do
-    let(:state) { FactoryBot.create(:workflow_state) }
+    let(:state) { create(:workflow_state) }
     let(:work) { create(:work) }
 
     before do

data/spec/models/hyrax/batch_create_operation_spec.rb

@@ -0,0 +1,59 @@
+RSpec.describe Hyrax::BatchCreateOperation do
+  subject { create(:batch_create_operation) }
+
+  describe 'callbacks' do
+    before do
+      allow(Hyrax.config.callback).to receive(:set?).with(callback).and_return(callback_set)
+    end
+
+    describe '#batch_success_message' do
+      let(:callback) { :after_batch_create_success }
+      let(:callback_set) { false }
+
+      it 'can be called' do
+        expect(subject).to respond_to(:batch_success_message)
+      end
+
+      context 'when callback not set' do
+        it 'returns nil' do
+          expect(Hyrax.config.callback).not_to receive(:run)
+          expect(subject.batch_success_message).to be_nil
+        end
+      end
+
+      context 'when callback is set' do
+        let(:callback_set) { true }
+
+        it 'runs the callback' do
+          expect(Hyrax.config.callback).to receive(:run).once
+          subject.batch_success_message
+        end
+      end
+    end
+
+    describe '#batch_failure_message' do
+      let(:callback) { :after_batch_create_failure }
+      let(:callback_set) { false }
+
+      it 'can be called' do
+        expect(subject).to respond_to(:batch_failure_message)
+      end
+
+      context 'when callback not set' do
+        it 'returns nil' do
+          expect(Hyrax.config.callback).not_to receive(:run)
+          expect(subject.batch_failure_message).to be_nil
+        end
+      end
+
+      context 'when callback is set' do
+        let(:callback_set) { true }
+
+        it 'runs the callback' do
+          expect(Hyrax.config.callback).to receive(:run).once
+          subject.batch_failure_message
+        end
+      end
+    end
+  end
+end

data/spec/models/hyrax/collection_type_participant_spec.rb

@@ -0,0 +1,43 @@
+RSpec.describe Hyrax::CollectionTypeParticipant, type: :model do
+  let(:collection_type_participant) { create(:collection_type_participant) }
+
+  it 'has basic metadata' do
+    expect(collection_type_participant).to respond_to(:agent_id)
+    expect(collection_type_participant.agent_id).not_to be_empty
+    expect(collection_type_participant).to respond_to(:agent_type)
+    expect(collection_type_participant.agent_type).not_to be_empty
+    expect(collection_type_participant).to respond_to(:access)
+    expect(collection_type_participant.access).not_to be_empty
+  end
+
+  describe "validations", :clean_repo do
+    describe '#agent_id' do
+      it { is_expected.to validate_presence_of(:agent_id) }
+    end
+    describe '#agent_type' do
+      it { is_expected.to validate_presence_of(:agent_type) }
+      it { is_expected.not_to allow_value('somethingelse').for(:agent_type) }
+      it { is_expected.to allow_value(Hyrax::CollectionTypeParticipant::USER_TYPE).for(:agent_type) }
+      it { is_expected.to allow_value(Hyrax::CollectionTypeParticipant::GROUP_TYPE).for(:agent_type) }
+      it "showd error message for wrong agent_type" do
+        collection_type_participant.agent_type = "BAD_TYPE"
+        collection_type_participant.valid?
+        expect(collection_type_participant.errors[:agent_type]).to include "BAD_TYPE is not a valid agent type.  Accepts: group, user"
+      end
+    end
+    describe '#access' do
+      it { is_expected.to validate_presence_of(:access) }
+      it { is_expected.not_to allow_value('somethingelse').for(:access) }
+      it { is_expected.to allow_value(Hyrax::CollectionTypeParticipant::MANAGE_ACCESS).for(:access) }
+      it { is_expected.to allow_value(Hyrax::CollectionTypeParticipant::CREATE_ACCESS).for(:access) }
+      it "showd error message for wrong access" do
+        collection_type_participant.access = "BAD_ACCESS"
+        collection_type_participant.valid?
+        expect(collection_type_participant.errors[:access]).to include "BAD_ACCESS is not a valid access.  Accepts: manage, create"
+      end
+    end
+    describe '#hyrax_collection_type_id' do
+      it { is_expected.to validate_presence_of(:hyrax_collection_type_id) }
+    end
+  end
+end

data/spec/models/hyrax/collection_type_spec.rb

@@ -0,0 +1,235 @@
+RSpec.describe Hyrax::CollectionType, type: :model do
+  let(:collection_type) { build(:collection_type) }
+
+  describe '.collection_type_settings_methods' do
+    subject { described_class.collection_type_settings_methods }
+
+    it { is_expected.to be_a(Array) }
+  end
+
+  describe '#collection_type_settings_methods' do
+    subject { described_class.new.collection_type_settings_methods }
+
+    it { is_expected.to be_a(Array) }
+  end
+
+  it "has basic metadata" do
+    expect(collection_type).to respond_to(:title)
+    expect(collection_type.title).not_to be_empty
+    expect(collection_type).to respond_to(:description)
+    expect(collection_type.description).not_to be_empty
+    expect(collection_type).to respond_to(:machine_id)
+  end
+
+  it "has configuration properties with defaults" do
+    expect(collection_type).to be_nestable
+    expect(collection_type).to be_discoverable
+    expect(collection_type).to be_sharable
+    expect(collection_type).to be_share_applies_to_new_works
+    expect(collection_type).to allow_multiple_membership
+    expect(collection_type).not_to require_membership
+    expect(collection_type).not_to assign_workflow
+    expect(collection_type).not_to assign_visibility
+  end
+
+  describe '#gid' do
+    it 'returns the gid when id exists' do
+      collection_type.id = 5
+      expect(collection_type.gid.to_s).to eq 'gid://internal/hyrax-collectiontype/5'
+    end
+
+    it 'returns nil when id is nil' do
+      collection_type.id = nil
+      expect(collection_type.gid).to be_nil
+    end
+  end
+
+  describe ".any_nestable?" do
+    context "when there is a nestable collection type" do
+      let!(:collection_type) { create(:collection_type, nestable: true) }
+
+      it 'returns true' do
+        expect(described_class.any_nestable?).to be true
+      end
+    end
+
+    context "when there are no nestable collection types" do
+      let!(:collection_type) { create(:collection_type, nestable: false) }
+
+      it 'returns false' do
+        expect(described_class.any_nestable?).to be false
+      end
+    end
+  end
+
+  describe ".find_or_create_default_collection_type" do
+    subject { described_class.find_or_create_default_collection_type }
+
+    it 'creates a default collection type' do
+      expect(Hyrax::CollectionTypes::CreateService).to receive(:create_collection_type)
+      subject
+    end
+  end
+
+  describe ".find_or_create_admin_set_type" do
+    subject { described_class.find_or_create_admin_set_type }
+
+    it 'creates admin set collection type' do
+      machine_id = described_class::ADMIN_SET_MACHINE_ID
+      title = described_class::ADMIN_SET_DEFAULT_TITLE
+      expect(Hyrax::CollectionTypes::CreateService).to receive(:create_collection_type).with(machine_id: machine_id, title: title, options: anything)
+      subject
+    end
+  end
+
+  describe "validations", :clean_repo do
+    let(:collection_type) { create(:collection_type) }
+
+    it "ensures the required fields have values" do
+      collection_type.title = nil
+      collection_type.machine_id = nil
+      expect(collection_type).not_to be_valid
+      expect(collection_type.errors.messages[:title]).not_to be_empty
+      expect(collection_type.errors.messages[:machine_id]).not_to be_empty
+    end
+    it "ensures uniqueness" do
+      is_expected.to validate_uniqueness_of(:title)
+      is_expected.to validate_uniqueness_of(:machine_id)
+    end
+  end
+
+  describe '.find_by_gid' do
+    let(:collection_type) { create(:collection_type) }
+    let(:nonexistent_gid) { 'gid://internal/hyrax-collectiontype/NO_EXIST' }
+
+    it 'returns instance of collection type when one with the gid exists' do
+      expect(Hyrax::CollectionType.find_by_gid(collection_type.gid)).to eq collection_type
+    end
+
+    it 'returns false if collection type with gid does NOT exist' do
+      expect(Hyrax::CollectionType.find_by_gid(nonexistent_gid)).to eq false
+    end
+
+    it 'returns false if gid is nil' do
+      expect(Hyrax::CollectionType.find_by_gid(nil)).to eq false
+    end
+  end
+
+  describe '.find_by_gid!' do
+    let(:collection_type) { create(:collection_type) }
+    let(:nonexistent_gid) { 'gid://internal/hyrax-collectiontype/NO_EXIST' }
+
+    it 'returns instance of collection type when one with the gid exists' do
+      expect(Hyrax::CollectionType.find_by_gid(collection_type.gid)).to eq collection_type
+    end
+
+    it 'raises error if collection type with gid does NOT exist' do
+      expect { Hyrax::CollectionType.find_by_gid!(nonexistent_gid) }.to raise_error(ActiveRecord::RecordNotFound, "Couldn't find Hyrax::CollectionType matching GID '#{nonexistent_gid}'")
+    end
+
+    it 'raises error if passed nil' do
+      expect { Hyrax::CollectionType.find_by_gid!(nil) }.to raise_error(ActiveRecord::RecordNotFound, "Couldn't find Hyrax::CollectionType matching GID ''")
+    end
+  end
+
+  describe "collections" do
+    let!(:collection) { create(:collection, collection_type_gid: collection_type.gid.to_s) }
+    let(:collection_type) { create(:collection_type) }
+
+    it 'returns collections of this collection type' do
+      expect(collection_type.collections.to_a).to include collection
+    end
+
+    it 'returns empty array if gid is nil' do
+      expect(Collection.count).not_to be_zero
+      expect(build(:collection_type).collections).to eq []
+    end
+  end
+
+  describe "collections?", :clean_repo do
+    let(:collection_type) { create(:collection_type) }
+
+    it 'returns true if there are any collections of this collection type' do
+      create(:collection, collection_type_gid: collection_type.gid.to_s)
+      expect(collection_type).to have_collections
+    end
+    it 'returns false if there are not any collections of this collection type' do
+      expect(collection_type).not_to have_collections
+    end
+  end
+
+  describe "machine_id" do
+    let(:collection_type) { described_class.new }
+
+    it 'assigns machine_id on title=' do
+      expect(collection_type.machine_id).to be_blank
+      collection_type.title = "New Collection Type"
+      expect(collection_type.machine_id).not_to be_blank
+    end
+  end
+
+  describe "destroy" do
+    before do
+      allow(collection_type).to receive(:collections?).and_return(true)
+    end
+
+    it "fails if collections exist of this type" do
+      expect(collection_type.destroy).to eq false
+      expect(collection_type.errors).not_to be_empty
+    end
+  end
+
+  describe "save (no settings changes)" do
+    before do
+      allow(collection_type).to receive(:collections?).and_return(true)
+    end
+
+    it "succeeds no changes to settings are being made" do
+      expect(collection_type.save).to be true
+      expect(collection_type.errors).to be_empty
+    end
+  end
+
+  describe "save" do
+    before do
+      allow(collection_type).to receive(:changes).and_return('nestable' => false)
+    end
+
+    context 'for non-special collection type' do
+      before do
+        allow(collection_type).to receive(:collections?).and_return(true)
+      end
+
+      it "fails if collections exist of this type and settings are changed" do
+        expect(collection_type.save).to be false
+        expect(collection_type.errors.messages[:base].first).to eq "Collection type settings cannot be altered for a type that has collections"
+      end
+    end
+
+    context 'for admin set collection type' do
+      let(:collection_type) { create(:admin_set_collection_type) }
+
+      before do
+        allow(collection_type).to receive(:collections?).and_return(false)
+      end
+
+      it 'fails if settings are changed' do
+        expect(collection_type.save).to be false
+        expect(collection_type.errors.messages[:base].first).to eq "Collection type settings cannot be altered for the Administrative Set type"
+      end
+    end
+
+    context 'for user collection type' do
+      let(:collection_type) { create(:user_collection_type) }
+
+      before do
+        allow(collection_type).to receive(:collections?).and_return(false)
+      end
+
+      it 'fails if settings are changed' do
+        expect(collection_type.save).to be false
+        expect(collection_type.errors.messages[:base].first).to eq "Collection type settings cannot be altered for the User Collection type"
+      end
+    end
+  end
+end