hyrax 2.0.3 → 2.1.0.beta1

data/spec/controllers/hyrax/dashboard/nest_collections_controller_spec.rb

@@ -0,0 +1,360 @@
+RSpec.describe Hyrax::Dashboard::NestCollectionsController do
+  routes { Hyrax::Engine.routes }
+  let(:child_id) { 'child1' }
+  let(:child) { instance_double(Collection, title: ["Awesome Child"]) }
+  let(:parent) { create(:collection, id: 'parent1', collection_type_settings: :nestable, title: ["Uncool Parent"]) }
+
+  describe '#blacklight_config' do
+    subject { controller.blacklight_config }
+
+    it { is_expected.to be_a(Blacklight::Configuration) }
+  end
+
+  describe '#repository' do
+    subject { controller.repository }
+
+    it { is_expected.to be_a(Blacklight::Solr::Repository) }
+  end
+
+  describe 'POST #create_relationship_within' do
+    subject { post 'create_relationship_within', params: { child_id: child_id, parent_id: parent.id, source: 'my' } }
+
+    before do
+      allow(Collection).to receive(:find).with(child_id).and_return(child)
+      allow(Collection).to receive(:find).with(parent.id).and_return(parent)
+    end
+
+    describe 'when save fails' do
+      let(:form_class_with_failed_save) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def save
+            false
+          end
+
+          def errors; end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_with_failed_save
+        allow(controller).to receive(:authorize!).with(:read, child).and_return(true)
+        allow(controller.form_class).to receive(:errors)
+        allow(controller.form_class.errors).to receive(:full_messages).and_return(['huge mistake'])
+      end
+
+      it 'authorizes then renders the form again' do
+        subject
+        expect(response).to redirect_to(my_collections_path)
+      end
+    end
+
+    describe 'when save succeeds' do
+      let(:form_class_with_successful_save) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def save
+            true
+          end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_with_successful_save
+        allow(controller).to receive(:authorize!).with(:read, child).and_return(true)
+      end
+
+      it 'authorizes, flashes a notice, and redirects' do
+        subject
+        expect(response).to redirect_to(my_collections_path)
+        expect(flash[:notice]).to be_a(String)
+      end
+    end
+  end
+
+  describe 'GET #create_collection_under' do
+    subject { get 'create_collection_under', params: { child_id: nil, parent_id: parent.id, source: 'show' } }
+
+    before do
+      allow(Collection).to receive(:find).with(parent.id).and_return(parent)
+    end
+
+    describe 'when validation fails' do
+      let(:form_class_with_failed_validation) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def validate_add
+            false
+          end
+
+          def errors; end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_with_failed_validation
+        allow(controller).to receive(:authorize!).with(:deposit, parent).and_return(true)
+        allow(controller.form_class).to receive(:errors)
+        allow(controller.form_class.errors).to receive(:full_messages).and_return(['huge mistake'])
+      end
+
+      it 'authorizes then renders the form again' do
+        subject
+        expect(response).to redirect_to(dashboard_collection_path(parent.id))
+      end
+    end
+
+    describe 'when validation succeeds' do
+      let(:form_class_with_successful_validation) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def validate_add
+            true
+          end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_with_successful_validation
+        allow(controller).to receive(:authorize!).with(:deposit, parent).and_return(true)
+      end
+
+      it 'authorizes, flashes a notice, and redirects' do
+        subject
+        expect(response).to redirect_to new_dashboard_collection_path(collection_type_id: parent.collection_type.id, parent_id: parent.id)
+      end
+    end
+  end
+
+  describe 'POST #create_relationship_under' do
+    subject { post 'create_relationship_under', params: { child_id: child_id, parent_id: parent.id, source: 'show' } }
+
+    before do
+      allow(Collection).to receive(:find).with(child_id).and_return(child)
+      allow(Collection).to receive(:find).with(parent.id).and_return(parent)
+    end
+
+    describe 'when save fails' do
+      let(:form_class_with_failed_save) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def save
+            false
+          end
+
+          def errors; end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_with_failed_save
+        allow(controller).to receive(:authorize!).with(:deposit, parent).and_return(true)
+        allow(controller.form_class).to receive(:errors)
+        allow(controller.form_class.errors).to receive(:full_messages).and_return(['huge mistake'])
+      end
+
+      it 'authorizes then renders the form again' do
+        subject
+        expect(response).to redirect_to(dashboard_collection_path(parent))
+      end
+    end
+
+    describe 'when save succeeds' do
+      let(:form_class_with_successful_save) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def save
+            true
+          end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_with_successful_save
+        allow(controller).to receive(:authorize!).with(:deposit, parent).and_return(true)
+      end
+
+      it 'authorizes, flashes a notice, and redirects' do
+        subject
+        expect(response).to redirect_to(dashboard_collection_path(parent))
+        expect(flash[:notice]).to be_a(String)
+      end
+    end
+  end
+
+  describe 'POST #remove_relationship_above' do
+    subject { post 'remove_relationship_above', params: { child_id: child_id, parent_id: parent.id } }
+
+    before do
+      allow(Collection).to receive(:find).with(child_id).and_return(child)
+      allow(Collection).to receive(:find).with(parent.id).and_return(parent)
+    end
+
+    describe 'when remove fails' do
+      let(:form_class_remove_fails) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def remove
+            false
+          end
+
+          def errors; end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_remove_fails
+        allow(controller).to receive(:authorize!).with(:edit, parent).and_return(false)
+        allow(controller.form_class).to receive(:errors)
+        allow(controller.form_class.errors).to receive(:full_messages).and_return(['unauthorized'])
+      end
+
+      it 'authorizes then renders the form again' do
+        subject
+        expect(response).to redirect_to(dashboard_collection_path(child))
+      end
+    end
+
+    describe 'when remove succeeds' do
+      let(:form_class_removed) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def remove
+            true
+          end
+
+          def errors; end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_removed
+        allow(controller).to receive(:authorize!).with(:edit, parent).and_return(true)
+      end
+
+      it 'authorizes, flashes a notice, and redirects' do
+        subject
+        expect(response).to redirect_to(dashboard_collection_path(child))
+        expect(flash[:notice]).to be_a(String)
+      end
+    end
+  end
+
+  describe 'POST #remove_relationship_under' do
+    subject { post 'remove_relationship_under', params: { child_id: child_id, parent_id: parent.id } }
+
+    before do
+      allow(Collection).to receive(:find).with(child_id).and_return(child)
+      allow(Collection).to receive(:find).with(parent.id).and_return(parent)
+    end
+
+    describe 'when remove fails' do
+      let(:form_class_remove_fails) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def remove
+            false
+          end
+
+          def errors; end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_remove_fails
+        allow(controller).to receive(:authorize!).with(:edit, parent).and_return(false)
+        allow(controller.form_class).to receive(:errors)
+        allow(controller.form_class.errors).to receive(:full_messages).and_return(['unauthorized'])
+      end
+
+      it 'authorizes then renders the form again' do
+        subject
+        expect(response).to redirect_to(dashboard_collection_path(parent))
+      end
+    end
+
+    describe 'when remove succeeds' do
+      let(:form_class_removed) do
+        Class.new do
+          attr_reader :child, :parent
+          def initialize(parent:, child:, context:)
+            @parent = parent
+            @child = child
+            @context = context
+          end
+
+          def remove
+            true
+          end
+
+          def errors; end
+        end
+      end
+
+      before do
+        controller.form_class = form_class_removed
+        allow(controller).to receive(:authorize!).with(:edit, parent).and_return(true)
+      end
+
+      it 'authorizes, flashes a notice, and redirects' do
+        subject
+        expect(response).to redirect_to(dashboard_collection_path(parent))
+        expect(flash[:notice]).to be_a(String)
+      end
+    end
+  end
+end

data/spec/controllers/hyrax/dashboard/profiles_controller_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe Hyrax::Dashboard::ProfilesController do
-  let(:user) { FactoryBot.create(:user) }
+  let(:user) { create(:user) }
 
   before do
     sign_in user
@@ -71,7 +71,7 @@ RSpec.describe Hyrax::Dashboard::ProfilesController do
 
   describe "#update" do
     context "the profile of another user" do
-      let(:another_user) { FactoryBot.create(:user) }
+      let(:another_user) { create(:user) }
 
       it "does not allow other users to update" do
         post :update, params: { id: another_user.user_key, user: { avatar: nil } }

data/spec/controllers/hyrax/dashboard/works_controller_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe Hyrax::Dashboard::WorksController, type: :controller do
   describe "#search_builder_class" do
     subject { controller.search_builder_class }
 
-    it { is_expected.to eq Hyrax::WorksSearchBuilder }
+    it { is_expected.to eq Hyrax::Dashboard::WorksSearchBuilder }
   end
 
   describe "#search_facet_path" do

data/spec/controllers/hyrax/downloads_controller_spec.rb

@@ -2,9 +2,9 @@ RSpec.describe Hyrax::DownloadsController do
   routes { Hyrax::Engine.routes }
 
   describe '#show' do
-    let(:user) { FactoryBot.create(:user) }
+    let(:user) { create(:user) }
     let(:file_set) do
-      FactoryBot.create(:file_with_work, user: user, content: File.open(fixture_path + '/image.png'))
+      create(:file_with_work, user: user, content: File.open(fixture_path + '/image.png'))
     end
     let(:default_image) { ActionController::Base.helpers.image_path 'default.png' }
 
@@ -15,7 +15,7 @@ RSpec.describe Hyrax::DownloadsController do
     end
 
     context "when user doesn't have access" do
-      let(:another_user) { FactoryBot.create(:user) }
+      let(:another_user) { create(:user) }
 
       before { sign_in another_user }
 

data/spec/controllers/hyrax/featured_work_lists_controller_spec.rb

@@ -4,8 +4,8 @@ RSpec.describe Hyrax::FeaturedWorkListsController, type: :controller do
       expect(controller).to receive(:authorize!).with(:update, FeaturedWork)
     end
 
-    let(:feature1) { FactoryBot.create(:featured_work) }
-    let(:feature2) { FactoryBot.create(:featured_work) }
+    let(:feature1) { create(:featured_work) }
+    let(:feature2) { create(:featured_work) }
 
     it "is successful" do
       post :create, params: {

data/spec/controllers/hyrax/file_sets_controller_spec.rb

@@ -12,105 +12,6 @@ RSpec.describe Hyrax::FileSetsController do
       allow(CreateDerivativesJob).to receive(:perform_later)
     end
 
-    describe '#create' do
-      let(:parent) do
-        create(:generic_work, :public, edit_users: [user.user_key])
-      end
-      let(:file) { fixture_file_upload('image.png', 'image/png') }
-      let(:file_path) { fixture_path + '/small_file.txt' }
-
-      context 'on the happy path' do
-        let(:expected_params) do
-          { files: [file],
-            title: ['test title'],
-            visibility: 'restricted' }
-        end
-
-        it 'calls the actor to create metadata and content' do
-          expect(actor).to receive(:create_metadata).with(ActionController::Parameters) do |ac_params|
-            expect(ac_params['files'].map(&:class)).to eq [ActionDispatch::Http::UploadedFile]
-            expect(ac_params['title']).to eq expected_params[:title]
-            expect(ac_params['visibility']).to eq expected_params[:visibility]
-          end
-          expect(actor).to receive(:attach_to_work).with(parent).and_return(true)
-          expect(actor).to receive(:create_content).with(ActionDispatch::Http::UploadedFile).and_return(true)
-
-          post :create, xhr: true, params: { parent_id: parent,
-                                             file_set: {
-                                               files: [file],
-                                               title: ['test title'],
-                                               visibility: 'restricted'
-                                             } }
-          expect(response).to be_success
-          expect(flash[:error]).to be_nil
-        end
-      end
-
-      context "on something that isn't a file" do
-        # Note: This is a duplicate of coverage in file_sets_controller_json_spec.rb
-        it 'renders error' do
-          post :create, xhr: true, params: { parent_id: parent,
-                                             file_set: { files: ['hello'] },
-                                             permission: { group: { 'public' => 'read' } },
-                                             terms_of_service: '1' }
-          expect(response.status).to eq 400
-          msg = JSON.parse(response.body)['message']
-          expect(msg).to match(/No file uploaded/i)
-        end
-      end
-
-      subject { create(:file_set) }
-
-      context 'when the file has a virus' do
-        before do
-          allow(subject).to receive(:warn) # suppress virus warnings
-          allow(Hydra::Works::VirusCheckerService).to receive(:file_has_virus?) { true }
-          of = subject.build_original_file
-          of.content = File.open(file_path)
-        end
-        it 'populates the errors hash during validation' do
-          expect(subject).not_to be_valid
-          expect(subject.errors.messages[:base].first).to eq "Failed to verify uploaded file is not a virus"
-        end
-      end
-
-      context 'when solr is down' do
-        before do
-          allow(actor).to receive(:create_metadata)
-          allow(actor).to receive(:attach_to_work)
-          allow(actor).to receive(:create_content).and_raise(RSolr::Error::Http.new({}, {}))
-        end
-
-        it 'errors out of create after on continuous rsolr error' do
-          post :create, xhr: true, params: {
-            parent_id: parent,
-            file_set: { files: [file] },
-            permission: { group: { 'public' => 'read' } },
-            terms_of_service: '1'
-          }
-          expect(response.body).to include('Error occurred while creating a FileSet.')
-        end
-      end
-
-      context 'when the file is not created' do
-        before do
-          allow(controller.send(:actor)).to receive(:create_metadata)
-          allow(controller.send(:actor)).to receive(:attach_to_work)
-          allow(controller.send(:actor)).to receive(:create_content).and_return(false)
-        end
-
-        it 'errors out of create after on continuous rsolr error' do
-          post :create, xhr: true, params: {
-            parent_id: parent,
-            file_set: { files: [file] },
-            permission: { group: { 'public' => 'read' } },
-            terms_of_service: '1'
-          }
-          expect(response.body).to include('Error creating file image.png')
-        end
-      end
-    end
-
     describe "#destroy" do
       context "file_set with a parent" do
         let(:file_set) do
@@ -138,8 +39,14 @@ RSpec.describe Hyrax::FileSetsController do
     end
 
     describe "#edit" do
+      let(:parent) do
+        create(:work, :public, user: user)
+      end
       let(:file_set) do
-        create(:file_set, user: user)
+        create(:file_set, user: user).tap do |file_set|
+          parent.ordered_members << file_set
+          parent.save!
+        end
       end
 
       before do
@@ -157,6 +64,7 @@ RSpec.describe Hyrax::FileSetsController do
         expect(response).to be_success
         expect(assigns[:file_set]).to eq file_set
         expect(assigns[:version_list]).to be_kind_of Hyrax::VersionListPresenter
+        expect(assigns[:parent]).to eq parent
         expect(response).to render_template(:edit)
       end
     end
@@ -405,41 +313,5 @@ RSpec.describe Hyrax::FileSetsController do
         expect(response).to be_success
       end
     end
-
-    describe '#new' do
-      let(:parent) do
-        create(:generic_work, :public)
-      end
-
-      it 'does not let the user submit' do
-        get :new, params: { parent_id: parent }
-        expect(response).to fail_redirect_and_flash(main_app.new_user_session_path, 'You need to sign in or sign up before continuing.')
-      end
-    end
-  end
-
-  context 'finds parents' do
-    let(:parent) do
-      create(:generic_work, :public, edit_users: [user.user_key])
-    end
-
-    let(:file_set) do
-      file_set = create(:file_set, user: user)
-      parent.ordered_members << file_set
-      parent.save
-      file_set
-    end
-
-    before do
-      allow(controller).to receive(:curation_concern).and_return(file_set)
-    end
-
-    it 'finds a parent' do
-      expect(controller.parent).to eq(parent)
-    end
-
-    it 'finds a parent id' do
-      expect(controller.parent_id).to eq(parent.id)
-    end
   end
 end