formtastic 2.1.0 → 4.0.0

data/spec/inputs/range_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'range input' do
+RSpec.describe 'range input' do
 
   include FormtasticSpecHelper
 
@@ -57,15 +57,15 @@ describe 'range input' do
     end
     
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
     
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name")
     end
     
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][name]']")
     end
     
   end
@@ -73,7 +73,7 @@ describe 'range input' do
 
   describe "when validations require a minimum value (:greater_than)" do
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :greater_than=>2})
       ])
     end
@@ -82,68 +82,68 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :min => 5 })
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
     
     it "should allow :input_html to override :min through :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :in => 5..102 })
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
     
     it "should allow options to override :min" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :min => 5)
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
     
     it "should allow options to override :min through :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :in => 5..102)
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
     
     describe "and the column is an integer" do
       before do
-        @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :integer))
+        allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => :integer))
       end
       
       it "should add a min attribute to the input one greater than the validation" do
         concat(semantic_form_for(@new_post) do |builder|
           builder.input(:title, :as => :range)
         end)
-        output_buffer.should have_tag('input[@min="3"]')
+        expect(output_buffer).to have_tag('input[@min="3"]')
       end
     end
     
     describe "and the column is a float" do
       before do
-        @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :float))
+        allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => :float))
       end
       
       it "should raise an error" do
-        lambda {
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             builder.input(:title, :as => :range)
           end)
-        }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMinimumAttributeError)
+        }.to raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMinimumAttributeError)
       end
     end
     
     describe "and the column is a big decimal" do
       before do
-        @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :decimal))
+        allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => :decimal))
       end
       
       it "should raise an error" do
-        lambda {
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             builder.input(:title, :as => :range)
           end)
-        }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMinimumAttributeError)
+        }.to raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMinimumAttributeError)
       end
     end
     
@@ -151,7 +151,7 @@ describe 'range input' do
   
   describe "when validations require a minimum value (:greater_than_or_equal_to)" do
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :greater_than_or_equal_to=>2})
       ])
     end
@@ -160,56 +160,56 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :min => 5 })
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
     
     it "should allow options to override :min" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :min => 5)
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
 
     it "should allow :input_html to override :min with :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :in => 5..102 })
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
     
     it "should allow options to override :min  with :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :in => 5..102)
       end)
-      output_buffer.should have_tag('input[@min="5"]')
+      expect(output_buffer).to have_tag('input[@min="5"]')
     end
     
 
     [:integer, :decimal, :float].each do |column_type|
       describe "and the column is a #{column_type}" do
         before do
-          @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => column_type))
+          allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => column_type))
         end
 
         it "should add a max attribute to the input equal to the validation" do
           concat(semantic_form_for(@new_post) do |builder|
             builder.input(:title, :as => :range)
           end)
-          output_buffer.should have_tag('input[@min="2"]')
+          expect(output_buffer).to have_tag('input[@min="2"]')
         end
       end
     end
 
     describe "and there is no column" do
       before do
-        @new_post.stub!(:column_for_attribute).with(:title).and_return(nil)
+        allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(nil)
       end
     
       it "should add a max attribute to the input equal to the validation" do
         concat(semantic_form_for(@new_post) do |builder|
           builder.input(:title, :as => :range)
         end)
-        output_buffer.should have_tag('input[@min="2"]')
+        expect(output_buffer).to have_tag('input[@min="2"]')
       end
     end
   end
@@ -220,14 +220,14 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range)
       end)
-      output_buffer.should have_tag('input[@min="1"]')
+      expect(output_buffer).to have_tag('input[@min="1"]')
     end
     
   end
 
   describe "when validations require a maximum value (:less_than)" do
    before do
-     @new_post.class.stub!(:validators_on).with(:title).and_return([
+     allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
        active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :less_than=>20})
      ])
    end
@@ -236,68 +236,68 @@ describe 'range input' do
      concat(semantic_form_for(@new_post) do |builder|
        builder.input(:title, :as => :range, :input_html => { :max => 102 })
      end)
-     output_buffer.should have_tag('input[@max="102"]')
+     expect(output_buffer).to have_tag('input[@max="102"]')
    end
    
    it "should allow option to override :max" do
      concat(semantic_form_for(@new_post) do |builder|
        builder.input(:title, :as => :range, :max => 102)
      end)
-     output_buffer.should have_tag('input[@max="102"]')
+     expect(output_buffer).to have_tag('input[@max="102"]')
    end
    
    it "should allow :input_html to override :max with :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :in => 1..102 })
       end)
-      output_buffer.should have_tag('input[@max="102"]')
+      expect(output_buffer).to have_tag('input[@max="102"]')
     end
 
     it "should allow option to override :max with :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :in => 1..102)
       end)
-      output_buffer.should have_tag('input[@max="102"]')
+      expect(output_buffer).to have_tag('input[@max="102"]')
     end
    
    describe "and the column is an integer" do
      before do
-       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :integer))
+       allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => :integer))
      end
      
      it "should add a max attribute to the input one greater than the validation" do
        concat(semantic_form_for(@new_post) do |builder|
          builder.input(:title, :as => :range)
        end)
-       output_buffer.should have_tag('input[@max="19"]')
+       expect(output_buffer).to have_tag('input[@max="19"]')
      end
    end
    
    describe "and the column is a float" do
      before do
-       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :float))
+       allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => :float))
      end
      
      it "should raise an error" do
-       lambda {
+       expect {
          concat(semantic_form_for(@new_post) do |builder|
            builder.input(:title, :as => :range)
          end)
-       }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMaximumAttributeError)
+       }.to raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMaximumAttributeError)
      end
    end
    
    describe "and the column is a big decimal" do
      before do
-       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :decimal))
+       allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => :decimal))
      end
      
      it "should raise an error" do
-       lambda {
+       expect {
          concat(semantic_form_for(@new_post) do |builder|
            builder.input(:title, :as => :range)
          end)
-       }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMaximumAttributeError)
+       }.to raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMaximumAttributeError)
      end
    end
    
@@ -305,7 +305,7 @@ describe 'range input' do
   
   describe "when validations require a maximum value (:less_than_or_equal_to)" do
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :less_than_or_equal_to=>20})
       ])
     end
@@ -314,55 +314,55 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :max => 102 })
       end)
-      output_buffer.should have_tag('input[@max="102"]')
+      expect(output_buffer).to have_tag('input[@max="102"]')
     end
     
     it "should allow options to override :max" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :max => 102)
       end)
-      output_buffer.should have_tag('input[@max="102"]')
+      expect(output_buffer).to have_tag('input[@max="102"]')
     end
     
     it "should allow :input_html to override :max with :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :in => 1..102 })
       end)
-      output_buffer.should have_tag('input[@max="102"]')
+      expect(output_buffer).to have_tag('input[@max="102"]')
     end
     
     it "should allow options to override :max with :in" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :in => 1..102)
       end)
-      output_buffer.should have_tag('input[@max="102"]')
+      expect(output_buffer).to have_tag('input[@max="102"]')
     end
 
     [:integer, :decimal, :float].each do |column_type|
       describe "and the column is a #{column_type}" do
         before do
-          @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => column_type))
+          allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(double('column', :type => column_type))
         end
 
         it "should add a max attribute to the input equal to the validation" do
           concat(semantic_form_for(@new_post) do |builder|
             builder.input(:title, :as => :range)
           end)
-          output_buffer.should have_tag('input[@max="20"]')
+          expect(output_buffer).to have_tag('input[@max="20"]')
         end
       end
     end
 
     describe "and there is no column" do
       before do
-        @new_post.stub!(:column_for_attribute).with(:title).and_return(nil)
+        allow(@new_post).to receive(:column_for_attribute).with(:title).and_return(nil)
       end
     
       it "should add a max attribute to the input equal to the validation" do
         concat(semantic_form_for(@new_post) do |builder|
           builder.input(:title, :as => :range)
         end)
-        output_buffer.should have_tag('input[@max="20"]')
+        expect(output_buffer).to have_tag('input[@max="20"]')
       end
     end
   end
@@ -373,14 +373,14 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range)
       end)
-      output_buffer.should have_tag('input[@max="100"]')
+      expect(output_buffer).to have_tag('input[@max="100"]')
     end
     
   end
   
   describe "when validations require conflicting minimum values (:greater_than, :greater_than_or_equal_to)" do
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :greater_than => 20, :greater_than_or_equal_to=>2})
       ])
     end
@@ -389,13 +389,13 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range)
       end)
-      output_buffer.should have_tag('input[@min="2"]')
+      expect(output_buffer).to have_tag('input[@min="2"]')
     end
   end
   
   describe "when validations require conflicting maximum values (:less_than, :less_than_or_equal_to)" do
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :less_than => 20, :less_than_or_equal_to=>2})
       ])
     end
@@ -404,14 +404,14 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range)
       end)
-      output_buffer.should have_tag('input[@max="2"]')
+      expect(output_buffer).to have_tag('input[@max="2"]')
     end
   end
   
   describe "when validations require only an integer (:only_integer)" do
     
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:allow_nil=>false, :only_integer=>true})
       ])
     end
@@ -420,21 +420,21 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range)
       end)
-      output_buffer.should have_tag('input[@step="1"]')
+      expect(output_buffer).to have_tag('input[@step="1"]')
     end
     
     it "should let input_html override :step" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :step => 3 })
       end)
-      output_buffer.should have_tag('input[@step="3"]')
+      expect(output_buffer).to have_tag('input[@step="3"]')
     end
     
     it "should let options override :step" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :step => 3)
       end)
-      output_buffer.should have_tag('input[@step="3"]')
+      expect(output_buffer).to have_tag('input[@step="3"]')
     end
     
   end
@@ -442,7 +442,7 @@ describe 'range input' do
   describe "when validations require a :step (non standard)" do
     
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:allow_nil=>false, :only_integer=>true, :step=>2})
       ])
     end
@@ -451,21 +451,21 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range)
       end)
-      output_buffer.should have_tag('input[@step="2"]')
+      expect(output_buffer).to have_tag('input[@step="2"]')
     end
     
     it "should let input_html override :step" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :step => 3 })
       end)
-      output_buffer.should have_tag('input[@step="3"]')
+      expect(output_buffer).to have_tag('input[@step="3"]')
     end
     
     it "should let options override :step" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :step => 3)
       end)
-      output_buffer.should have_tag('input[@step="3"]')
+      expect(output_buffer).to have_tag('input[@step="3"]')
     end
     
   end
@@ -473,7 +473,7 @@ describe 'range input' do
   describe "when validations do not specify :step (non standard) or :only_integer" do
     
     before do
-      @new_post.class.stub!(:validators_on).with(:title).and_return([
+      allow(@new_post.class).to receive(:validators_on).with(:title).and_return([
         active_model_numericality_validator([:title], {:allow_nil=>false})
       ])
     end
@@ -482,21 +482,21 @@ describe 'range input' do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range)
       end)
-      output_buffer.should have_tag('input[@step="1"]')
+      expect(output_buffer).to have_tag('input[@step="1"]')
     end
     
     it "should let input_html set :step" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :input_html => { :step => 3 })
       end)
-      output_buffer.should have_tag('input[@step="3"]')
+      expect(output_buffer).to have_tag('input[@step="3"]')
     end
     
     it "should let options set :step" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :range, :step => 3)
       end)
-      output_buffer.should have_tag('input[@step="3"]')
+      expect(output_buffer).to have_tag('input[@step="3"]')
     end
     
   end

data/spec/inputs/readonly_spec.rb

@@ -0,0 +1,50 @@
+# encoding: utf-8
+require 'spec_helper'
+
+RSpec.describe 'readonly option' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
+  describe "placeholder text" do
+    [:email, :number, :password, :phone, :search, :string, :url, :text, :date_picker, :time_picker, :datetime_picker].each do |type|
+
+      describe "for #{type} inputs" do
+
+        describe "when readonly is found in input_html" do
+          it "sets readonly attribute" do
+            concat(semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:title, :as => type, input_html: {readonly: true}))
+            end)
+              expect(output_buffer).to have_tag((type == :text ? 'textarea' : 'input') + '[@readonly]')
+          end
+        end
+
+        describe "when readonly not found in input_html" do
+          describe "when column is not readonly attribute" do
+            it "doesn't set readonly attribute" do
+              concat(semantic_form_for(@new_post) do |builder|
+                concat(builder.input(:title, :as => type))
+              end)
+                expect(output_buffer).not_to have_tag((type == :text ? 'textarea' : 'input') + '[@readonly]')
+            end
+          end
+          describe "when column is readonly attribute" do
+            it "sets readonly attribute" do
+              input_class = "Formtastic::Inputs::#{type.to_s.camelize}Input".constantize
+              expect_any_instance_of(input_class).to receive(:readonly_attribute?).at_least(1).and_return(true)
+              concat(semantic_form_for(@new_post) do |builder|
+                concat(builder.input(:title, :as => type))
+              end)
+                expect(output_buffer).to have_tag((type == :text ? 'textarea' : 'input') + '[@readonly]')
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/inputs/search_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'search input' do
+RSpec.describe 'search input' do
 
   include FormtasticSpecHelper
 
@@ -56,15 +56,15 @@ describe 'search input' do
     end
     
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
     
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name")
     end
     
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][name]']")
     end
     
   end
@@ -75,7 +75,7 @@ describe 'search input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :search, :required => true))
         end)
-        output_buffer.should have_tag("input[@required]")
+        expect(output_buffer).to have_tag("input[@required]")
       end
     end
   end