formtastic 2.1.0 → 4.0.0

data/spec/inputs/password_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'password input' do
+RSpec.describe 'password input' do
 
   include FormtasticSpecHelper
 
@@ -71,15 +71,15 @@ describe 'password input' do
     end
     
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
     
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name")
     end
     
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][name]']")
     end
     
   end
@@ -91,7 +91,7 @@ describe 'password input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :password, :required => true))
         end)
-        output_buffer.should have_tag("input[@required]")
+        expect(output_buffer).to have_tag("input[@required]")
       end
     end
   end

data/spec/inputs/phone_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'phone input' do
+RSpec.describe 'phone input' do
 
   include FormtasticSpecHelper
 
@@ -56,15 +56,15 @@ describe 'phone input' do
     end
     
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
     
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name")
     end
     
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][name]']")
     end
     
   end
@@ -76,7 +76,7 @@ describe 'phone input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :phone, :required => true))
         end)
-        output_buffer.should have_tag("input[@required]")
+        expect(output_buffer).to have_tag("input[@required]")
       end
     end
   end

data/spec/inputs/placeholder_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'string input' do
+RSpec.describe 'string input' do
 
   include FormtasticSpecHelper
 
@@ -16,7 +16,7 @@ describe 'string input' do
   
   describe "placeholder text" do
     
-    [:email, :number, :password, :phone, :search, :string, :url, :text].each do |type|
+    [:email, :number, :password, :phone, :search, :string, :url, :text, :date_picker, :time_picker, :datetime_picker].each do |type|
       
       describe "for #{type} inputs" do
         
@@ -27,7 +27,7 @@ describe 'string input' do
               concat(semantic_form_for(@new_post) do |builder|
                 concat(builder.input(:title, :as => type))
               end)
-              output_buffer.should have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder="War and Peace"]')
+              expect(output_buffer).to have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder="War and Peace"]')
             end
           end
         end
@@ -37,7 +37,7 @@ describe 'string input' do
             concat(semantic_form_for(@new_post) do |builder|
               concat(builder.input(:title, :as => type))
             end)
-            output_buffer.should_not have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder]')
+            expect(output_buffer).not_to have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder]')
           end
         end
         
@@ -48,7 +48,7 @@ describe 'string input' do
               concat(semantic_form_for(@new_post) do |builder|
                 concat(builder.input(:title, :as => type, :input_html => { :placeholder => "Foo" }))
               end)
-              output_buffer.should have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder="Foo"]')
+              expect(output_buffer).to have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder="Foo"]')
             end
           end
         end
@@ -58,7 +58,7 @@ describe 'string input' do
             concat(semantic_form_for(@new_post) do |builder|
               concat(builder.input(:title, :as => type, :input_html => { :placeholder => "Untitled" }))
             end)
-            output_buffer.should have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder="Untitled"]')
+            expect(output_buffer).to have_tag((type == :text ? 'textarea' : 'input') + '[@placeholder="Untitled"]')
           end
         end
         

data/spec/inputs/radio_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'radio input' do
+RSpec.describe 'radio input' do
 
   include FormtasticSpecHelper
 
@@ -27,66 +27,66 @@ describe 'radio input' do
     it_should_use_the_collection_when_provided(:radio, 'input')
 
     it 'should generate a legend containing a label with text for the input' do
-      output_buffer.should have_tag('form li fieldset legend.label label')
-      output_buffer.should have_tag('form li fieldset legend.label label', /Author/)
+      expect(output_buffer).to have_tag('form li fieldset legend.label label')
+      expect(output_buffer).to have_tag('form li fieldset legend.label label', :text => /Author/)
     end
 
     it 'should not link the label within the legend to any input' do
-      output_buffer.should_not have_tag('form li fieldset legend label[@for]')
+      expect(output_buffer).not_to have_tag('form li fieldset legend label[@for]')
     end
 
     it 'should generate an ordered list with a list item for each choice' do
-      output_buffer.should have_tag('form li fieldset ol')
-      output_buffer.should have_tag('form li fieldset ol li.choice', :count => ::Author.all.size)
+      expect(output_buffer).to have_tag('form li fieldset ol')
+      expect(output_buffer).to have_tag('form li fieldset ol li.choice', :count => ::Author.all.size)
     end
 
     it 'should have one option with a "checked" attribute' do
-      output_buffer.should have_tag('form li input[@checked]', :count => 1)
+      expect(output_buffer).to have_tag('form li input[@checked]', :count => 1)
     end
 
     describe "each choice" do
 
       it 'should not give the choice label the .label class' do
-        output_buffer.should_not have_tag('li.choice label.label')
+        expect(output_buffer).not_to have_tag('li.choice label.label')
       end
 
       it 'should not add the required attribute to each input' do
-        output_buffer.should_not have_tag('li.choice input[@required]')
+        expect(output_buffer).not_to have_tag('li.choice input[@required]')
       end
 
 
       it 'should contain a label for the radio input with a nested input and label text' do
         ::Author.all.each do |author|
-          output_buffer.should have_tag('form li fieldset ol li label', /#{author.to_label}/)
-          output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_id_#{author.id}']")
+          expect(output_buffer).to have_tag('form li fieldset ol li label', /#{author.to_label}/)
+          expect(output_buffer).to have_tag("form li fieldset ol li label[@for='post_author_id_#{author.id}']")
         end
       end
 
       it 'should use values as li.class when value_as_class is true' do
         ::Author.all.each do |author|
-          output_buffer.should have_tag("form li fieldset ol li.author_#{author.id} label")
+          expect(output_buffer).to have_tag("form li fieldset ol li.author_#{author.id} label")
         end
       end
 
       it "should have a radio input" do
         ::Author.all.each do |author|
-          output_buffer.should have_tag("form li fieldset ol li label input#post_author_id_#{author.id}")
-          output_buffer.should have_tag("form li fieldset ol li label input[@type='radio']")
-          output_buffer.should have_tag("form li fieldset ol li label input[@value='#{author.id}']")
-          output_buffer.should have_tag("form li fieldset ol li label input[@name='post[author_id]']")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input#post_author_id_#{author.id}")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input[@type='radio']")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input[@value='#{author.id}']")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input[@name='post[author_id]']")
         end
       end
 
       it "should mark input as checked if it's the the existing choice" do
-        @new_post.author_id.should == @bob.id
-        @new_post.author.id.should == @bob.id
-        @new_post.author.should == @bob
+        expect(@new_post.author_id).to eq(@bob.id)
+        expect(@new_post.author.id).to eq(@bob.id)
+        expect(@new_post.author).to eq(@bob)
 
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:author, :as => :radio))
         end)
 
-        output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked']")
+        expect(output_buffer).to have_tag("form li fieldset ol li label input[@checked='checked']")
       end
 
       it "should mark the input as disabled if options attached for disabling" do
@@ -94,8 +94,8 @@ describe 'radio input' do
           concat(builder.input(:author, :as => :radio, :collection => [["Test", 'test'], ["Try", "try", {:disabled => true}]]))
         end)
 
-        output_buffer.should_not have_tag("form li fieldset ol li label input[@value='test'][@disabled='disabled']")
-        output_buffer.should have_tag("form li fieldset ol li label input[@value='try'][@disabled='disabled']")
+        expect(output_buffer).not_to have_tag("form li fieldset ol li label input[@value='test'][@disabled='disabled']")
+        expect(output_buffer).to have_tag("form li fieldset ol li label input[@value='try'][@disabled='disabled']")
       end
 
       it "should not contain invalid HTML attributes" do
@@ -104,13 +104,13 @@ describe 'radio input' do
           concat(builder.input(:author, :as => :radio))
         end)
 
-        output_buffer.should_not have_tag("form li fieldset ol li input[@find_options]")
+        expect(output_buffer).not_to have_tag("form li fieldset ol li input[@find_options]")
       end
 
     end
 
     describe 'and no object is given' do
-      before(:each) do
+      before(:example) do
         output_buffer.replace ''
         concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
           concat(builder.input(:author_id, :as => :radio, :collection => ::Author.all))
@@ -118,17 +118,17 @@ describe 'radio input' do
       end
 
       it 'should generate a fieldset with legend' do
-        output_buffer.should have_tag('form li fieldset legend', /Author/)
+        expect(output_buffer).to have_tag('form li fieldset legend', :text => /Author/)
       end
 
       it 'should generate an li tag for each item in the collection' do
-        output_buffer.should have_tag('form li fieldset ol li', :count => ::Author.all.size)
+        expect(output_buffer).to have_tag('form li fieldset ol li', :count => ::Author.all.size)
       end
 
       it 'should generate labels for each item' do
         ::Author.all.each do |author|
-          output_buffer.should have_tag('form li fieldset ol li label', /#{author.to_label}/)
-          output_buffer.should have_tag("form li fieldset ol li label[@for='project_author_id_#{author.id}']")
+          expect(output_buffer).to have_tag('form li fieldset ol li label', :text => /#{author.to_label}/)
+          expect(output_buffer).to have_tag("form li fieldset ol li label[@for='project_author_id_#{author.id}']")
         end
       end
 
@@ -136,29 +136,55 @@ describe 'radio input' do
         concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
           concat(builder.input(:author_id, :as => :radio, :collection => [["<b>Item 1</b>", 1], ["<b>Item 2</b>", 2]]))
         end)
-        output_buffer.should have_tag('form li fieldset ol li label') do |label|
-          label.body.should match /&lt;b&gt;Item [12]&lt;\/b&gt;$/
-        end
+        expect(output_buffer).to have_tag('form li fieldset ol li label', text: %r{<b>Item [12]</b>}, count: 2)
       end
 
       it 'should generate inputs for each item' do
         ::Author.all.each do |author|
-          output_buffer.should have_tag("form li fieldset ol li label input#project_author_id_#{author.id}")
-          output_buffer.should have_tag("form li fieldset ol li label input[@type='radio']")
-          output_buffer.should have_tag("form li fieldset ol li label input[@value='#{author.id}']")
-          output_buffer.should have_tag("form li fieldset ol li label input[@name='project[author_id]']")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input#project_author_id_#{author.id}")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input[@type='radio']")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input[@value='#{author.id}']")
+          expect(output_buffer).to have_tag("form li fieldset ol li label input[@name='project[author_id]']")
         end
       end
     end
   end
 
+  describe 'for a enum column' do
+    before do
+      allow(@new_post).to receive(:status) { 'inactive' }
+      statuses = ActiveSupport::HashWithIndifferentAccess.new("active"=>0, "inactive"=>1)
+      allow(@new_post.class).to receive(:statuses) { statuses }
+      allow(@new_post).to receive(:defined_enums) { { "status" => statuses } }
+    end
+
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.input(:status, :as => :radio))
+      end)
+    end
+
+    it 'should have a radio input for each defined enum status' do
+      expect(output_buffer).to have_tag("form li input[@name='post[status]'][@type='radio']", :count => @new_post.class.statuses.count)
+      @new_post.class.statuses.each do |label, value|
+        expect(output_buffer).to have_tag("form li input[@value='#{label}']")
+        expect(output_buffer).to have_tag("form li label", :text => /#{label.humanize}/)
+      end
+    end
+
+    it 'should have one radio input with a "checked" attribute' do
+      expect(output_buffer).to have_tag("form li input[@name='post[status]'][@checked]", :count => 1)
+    end
+  end
+
+
   describe "with i18n of the legend label" do
 
     before do
       ::I18n.backend.store_translations :en, :formtastic => { :labels => { :post => { :authors => "Translated!" }}}
 
       with_config :i18n_lookups_by_default, true do
-        @new_post.stub!(:author_ids).and_return(nil)
+        allow(@new_post).to receive(:author_ids).and_return(nil)
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:authors, :as => :radio))
         end)
@@ -170,66 +196,66 @@ describe 'radio input' do
     end
 
     it "should do foo" do
-      output_buffer.should have_tag("legend.label label", /Translated/)
+      expect(output_buffer).to have_tag("legend.label label", :text => /Translated/)
     end
 
   end
 
   describe "when :label option is set" do
     before do
-      @new_post.stub!(:author_ids).and_return(nil)
+      allow(@new_post).to receive(:author_ids).and_return(nil)
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.input(:authors, :as => :radio, :label => 'The authors'))
       end)
     end
 
     it "should output the correct label title" do
-      output_buffer.should have_tag("legend.label label", /The authors/)
+      expect(output_buffer).to have_tag("legend.label label", :text => /The authors/)
     end
   end
 
   describe "when :label option is false" do
     before do
       @output_buffer = ''
-      @new_post.stub!(:author_ids).and_return(nil)
+      allow(@new_post).to receive(:author_ids).and_return(nil)
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.input(:authors, :as => :radio, :label => false))
       end)
     end
 
     it "should not output the legend" do
-      output_buffer.should_not have_tag("legend.label")
-      output_buffer.should_not include("&gt;")
+      expect(output_buffer).not_to have_tag("legend.label")
+      expect(output_buffer).not_to include("&gt;")
     end
 
     it "should not cause escaped HTML" do
-      output_buffer.should_not include("&gt;")
+      expect(output_buffer).not_to include("&gt;")
     end
   end
 
   describe "when :required option is true" do
     before do
-      @new_post.stub!(:author_ids).and_return(nil)
+      allow(@new_post).to receive(:author_ids).and_return(nil)
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.input(:authors, :as => :radio, :required => true))
       end)
     end
 
     it "should output the correct label title" do
-      output_buffer.should have_tag("legend.label label abbr")
+      expect(output_buffer).to have_tag("legend.label label abbr")
     end
   end
 
   describe "when :namespace is given on form" do
     before do
       @output_buffer = ''
-      @new_post.stub!(:author_ids).and_return(nil)
+      allow(@new_post).to receive(:author_ids).and_return(nil)
       concat(semantic_form_for(@new_post, :namespace => "custom_prefix") do |builder|
         concat(builder.input(:authors, :as => :radio, :label => ''))
       end)
 
-      output_buffer.should match(/for="custom_prefix_post_author_ids_(\d+)"/)
-      output_buffer.should match(/id="custom_prefix_post_author_ids_(\d+)"/)
+      expect(output_buffer).to match(/for="custom_prefix_post_author_ids_(\d+)"/)
+      expect(output_buffer).to match(/id="custom_prefix_post_author_ids_(\d+)"/)
     end
     it_should_have_input_wrapper_with_id("custom_prefix_post_authors_input")
   end
@@ -248,16 +274,16 @@ describe 'radio input' do
     end
 
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
 
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name_true")
-      output_buffer.should have_tag("input#post_author_attributes_3_name_false")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name_true")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name_false")
     end
 
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][name]']")
     end
 
   end
@@ -273,10 +299,28 @@ describe 'radio input' do
     end
 
     it 'should output the correct labels' do
-      output_buffer.should have_tag("li.choice label", /1/)
-      output_buffer.should have_tag("li.choice label", /2/)
-      output_buffer.should have_tag("li.choice label", /3/)
+      expect(output_buffer).to have_tag("li.choice label", :text => /1/)
+      expect(output_buffer).to have_tag("li.choice label", :text => /2/)
+      expect(output_buffer).to have_tag("li.choice label", :text => /3/)
+    end
+  end
+
+  describe "when collection contains symbols" do
+    before do
+      @output_buffer = ''
+      mock_everything
+
+      concat(semantic_form_for(:project) do |builder|
+        concat(builder.input(:author_id, :as => :radio, :collection => Set.new([["A", :a], ["B", :b], ["C", :c]])))
+      end)
+    end
+
+    it 'should output the correct labels' do
+      expect(output_buffer).to have_tag("li.choice label", :text => /A/)
+      expect(output_buffer).to have_tag("li.choice label", :text => /B/)
+      expect(output_buffer).to have_tag("li.choice label", :text => /C/)
     end
   end
 
+
 end