formtastic 2.1.0 → 4.0.0

data/spec/inputs/country_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'country input' do
+RSpec.describe 'country input' do
 
   include FormtasticSpecHelper
 
@@ -13,11 +13,11 @@ describe 'country input' do
   describe "when country_select is not available as a helper from a plugin" do
 
     it "should raise an error, sugesting the author installs a plugin" do
-      lambda {
+      expect {
         semantic_form_for(@new_post) do |builder|
           concat(builder.input(:country, :as => :country))
         end
-      }.should raise_error
+      }.to raise_error(Formtastic::Inputs::CountryInput::CountrySelectPluginMissing)
     end
 
   end
@@ -26,7 +26,7 @@ describe 'country input' do
 
     before do
       concat(semantic_form_for(@new_post) do |builder|
-        builder.stub!(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+        allow(builder).to receive(:country_select).and_return("<select><option>...</option></select>".html_safe)
         concat(builder.input(:country, :as => :country))
       end)
     end
@@ -39,13 +39,13 @@ describe 'country input' do
     #it_should_apply_error_logic_for_input_type(:country)
 
     it 'should generate a label for the input' do
-      output_buffer.should have_tag('form li label')
-      output_buffer.should have_tag('form li label[@for="post_country"]')
-      output_buffer.should have_tag('form li label', /Country/)
+      expect(output_buffer).to have_tag('form li label')
+      expect(output_buffer).to have_tag('form li label[@for="post_country"]')
+      expect(output_buffer).to have_tag('form li label', :text => /Country/)
     end
 
     it "should generate a select" do
-      output_buffer.should have_tag("form li select")
+      expect(output_buffer).to have_tag("form li select")
     end
 
   end
@@ -55,8 +55,8 @@ describe 'country input' do
     it "should be passed down to the country_select helper when provided" do
       priority_countries = ["Foo", "Bah"]
       semantic_form_for(@new_post) do |builder|
-        builder.stub!(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
-        builder.should_receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+        allow(builder).to receive(:country_select).and_return("<select><option>...</option></select>".html_safe)
+        expect(builder).to receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false, :readonly => false}).and_return("<select><option>...</option></select>".html_safe)
 
         concat(builder.input(:country, :as => :country, :priority_countries => priority_countries))
       end
@@ -64,12 +64,12 @@ describe 'country input' do
 
     it "should default to the @@priority_countries config when absent" do
       priority_countries = Formtastic::FormBuilder.priority_countries
-      priority_countries.should_not be_empty
-      priority_countries.should_not be_nil
+      expect(priority_countries).not_to be_empty
+      expect(priority_countries).not_to be_nil
 
       semantic_form_for(@new_post) do |builder|
-        builder.stub!(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
-        builder.should_receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+        allow(builder).to receive(:country_select).and_return("<select><option>...</option></select>".html_safe)
+        expect(builder).to receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false, :readonly => false}).and_return("<select><option>...</option></select>".html_safe)
 
         concat(builder.input(:country, :as => :country))
       end
@@ -84,8 +84,8 @@ describe 'country input' do
       mock_everything
 
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
-        builder.stub!(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
-        builder.should_receive(:country_select).with(:country, [], {}, {:id => "context2_post_country", :required => false, :autofocus => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+        allow(builder).to receive(:country_select).and_return("<select><option>...</option></select>".html_safe)
+        expect(builder).to receive(:country_select).with(:country, [], {}, {:id => "context2_post_country", :required => false, :autofocus => false, :readonly => false}).and_return("<select><option>...</option></select>".html_safe)
         concat(builder.input(:country, :priority_countries => []))
       end)
     end
@@ -101,13 +101,13 @@ describe 'country input' do
 
       before do
         concat(semantic_form_for(@new_post) do |builder|
-          builder.stub!(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+          allow(builder).to receive(:country_select).and_return("<select><option>...</option></select>".html_safe)
           concat(builder.input(:country))
         end)
       end
 
       it "should render a country input" do
-        output_buffer.should have_tag "form li.country"
+        expect(output_buffer).to have_tag "form li.country"
       end
     end
 
@@ -121,8 +121,8 @@ describe 'country input' do
       end
 
       it "should render a country input" do
-        output_buffer.should_not have_tag "form li.country"
-        output_buffer.should have_tag "form li.string", :count => 2
+        expect(output_buffer).not_to have_tag "form li.country"
+        expect(output_buffer).to have_tag "form li.string", :count => 2
       end
 
     end

data/spec/inputs/custom_input_spec.rb

@@ -11,8 +11,7 @@ module TestInputs
     @method = :title
     @options = {}
     @proc = Proc.new {}
-    @builder = Formtastic::FormBuilder.new(@object_name, @object, @template, @options, @proc)
-    
+    @builder = Formtastic::FormBuilder.new(@object_name, @object, @template, @options)
     [@builder, @template, @object, @object_name, @method, @options]
   end
   
@@ -28,7 +27,7 @@ module TestInputs
   
 end
 
-describe 'AnyCustomInput' do
+RSpec.describe 'AnyCustomInput' do
   
   include TestInputs
   
@@ -42,7 +41,7 @@ describe 'AnyCustomInput' do
 
     describe 'with an implementation' do
       it "should raise a NotImplementedError exception" do
-        expect { ::ImplementedInput.new(*input_args).to_html }.to_not raise_error(NotImplementedError)
+        expect { ::ImplementedInput.new(*input_args).to_html }.to_not raise_error
       end
     end
     

data/spec/inputs/datalist_input_spec.rb

@@ -0,0 +1,61 @@
+# encoding: utf-8
+require 'spec_helper'
+
+RSpec.describe "datalist inputs" do
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
+  describe "renders correctly" do
+    lists_without_values =[
+      %w(a b c),
+      ["a", "b", "c"],
+      ("a".."c")
+    ]
+    lists_with_values = [
+      {a: 1, b: 2, c:3},
+      {"a" => 1, "b" => 2, "c" =>3},
+      [["a",1], ["b",2], ["c", 3]]
+    ]
+
+    def self.common_tests(list)
+      it_should_have_label_with_text(/Document/)
+      it_should_have_label_for("post_document")
+      it_should_have_input_wrapper_with_class(:datalist)
+      it_should_have_input_with(id: "post_document", type: :text, list:"post_document_datalist")
+      it_should_have_tag_with(:datalist, id: "post_document_datalist" )
+      it_should_have_many_tags(:option, list.count)
+    end
+
+    context "Rendering list of simple items" do
+      lists_without_values.each do |list|
+        describe "renders #{list.to_s} correctly" do
+          before do
+            concat(semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:document, as: :datalist, collection: list))
+            end)
+          end
+          common_tests list
+          it_should_have_tag_with :option, value: list.first
+        end
+      end
+    end
+
+    context "Rendering list of complex items, key-value pairs and such" do
+      lists_with_values.each do |list|
+        describe "renders #{list.to_s} correctly" do
+          before do
+            concat(semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:document, as: :datalist, collection: list))
+            end)
+          end
+          common_tests list
+          it_should_have_tag_with :option, value: list.first.last
+        end
+      end
+    end
+  end
+end

data/spec/inputs/date_picker_input_spec.rb

@@ -0,0 +1,449 @@
+# encoding: utf-8
+require 'spec_helper'
+
+RSpec.describe 'date_picker input' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  context "with an object" do
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.input(:publish_at, :as => :date_picker))
+      end)
+    end
+    
+    it_should_have_input_wrapper_with_class(:date_picker)
+    it_should_have_input_wrapper_with_class(:input)
+    it_should_have_input_wrapper_with_class(:stringish)
+    it_should_have_input_wrapper_with_id("post_publish_at_input")
+    it_should_have_label_with_text(/Publish at/)
+    it_should_have_label_for("post_publish_at")
+    it_should_have_input_with_id("post_publish_at")
+    it_should_have_input_with_type(:date)
+    it_should_have_input_with_name("post[publish_at]")
+    it_should_apply_custom_input_attributes_when_input_html_provided(:date_picker)
+    it_should_apply_custom_for_to_label_when_input_html_id_provided(:date_picker)
+    # TODO why does this blow-up it_should_apply_error_logic_for_input_type(:date_picker)
+    
+  end
+  
+  describe "size attribute" do
+    
+    it "defaults to 10 chars (YYYY-YY-YY)" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker))
+        end
+      )
+      expect(output_buffer).to have_tag "input[size='10']"
+    end
+    
+    it "can be set from :input_html options" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :input_html => { :size => "11" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[size='11']"
+    end
+    
+    it "can be set from options (ignoring input_html)" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :size => '12', :input_html => { :size => "11" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[size='12']"
+    end
+
+  end
+
+  describe "maxlength attribute" do
+
+    it "defaults to 10 chars (YYYY-YY-YY)" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker))
+        end
+      )
+      expect(output_buffer).to have_tag "input[maxlength='10']"
+    end
+
+    it "can be set from :input_html options" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :input_html => { :maxlength => "11" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[maxlength='11']"
+    end
+    
+    it "can be set from options (ignoring input_html)" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :maxlength => 12, :input_html => { :maxlength => "11" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[maxlength='12']"
+    end
+    
+  end
+  
+  describe "value attribute" do
+  
+    context "when method returns nil" do
+      
+      it "has no value" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker ))
+          end
+        )
+        expect(output_buffer).not_to have_tag "li input[value]"
+      end
+      
+      it "can be set from :input_html options" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker, :input_html => { :value => "1111-11-11" }))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='1111-11-11']"
+      end
+      
+    end
+  
+    context "when method returns a Date" do
+      
+      before do
+        @date = Date.new(2000, 11, 11)
+        allow(@new_post).to receive(:publish_at).and_return(@date)
+      end
+      
+      it "renders the date as YYYY-MM-DD" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker ))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='#{@date.to_s}']"
+      end
+
+      it "can be set from :input_html options" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker, :input_html => { :value => "1111-11-11" }))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='1111-11-11']"
+      end
+      
+    end
+  
+    context "when method returns a Time" do
+    
+      before do
+        @time = Time.utc(2000,11,11,11,11,11)
+        allow(@new_post).to receive(:publish_at).and_return(@time)
+      end
+      
+      it "renders the time as a YYYY-MM-DD" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker ))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='2000-11-11']"
+      end
+    
+      it "can be set from :input_html options" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker, :input_html => { :value => "1111-11-11" }))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='1111-11-11']"
+      end
+      
+    end
+  
+    context "when method returns an empty String" do
+      
+      before do
+        allow(@new_post).to receive(:publish_at).and_return("")
+      end
+      
+      it "will be empty" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker ))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='']"
+      end
+      
+      it "can be set from :input_html options" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker, :input_html => { :value => "1111-11-11" }))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='1111-11-11']"
+      end
+      
+    end
+  
+    context "when method returns a String" do
+      
+      before do
+        allow(@new_post).to receive(:publish_at).and_return("yeah")
+      end
+      
+      it "will be the string" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker ))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='yeah']"
+      end
+    
+      it "can be set from :input_html options" do
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker, :input_html => { :value => "1111-11-11" }))
+          end
+        )
+        expect(output_buffer).to have_tag "input[value='1111-11-11']"
+      end
+      
+    end
+
+  end
+  
+  describe "min attribute" do
+    
+    it "will be omitted by default" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker))
+        end
+      )
+      expect(output_buffer).not_to have_tag "input[min]"
+    end
+    
+    it "can be set from :input_html options" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :input_html => { :min => "1970-01-01" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[min='1970-01-01']"
+    end
+    
+  end
+  
+  describe "max attribute" do
+
+    it "will be omitted by default" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker))
+        end
+      )
+      expect(output_buffer).not_to have_tag "input[max]"
+    end
+    
+    it "can be set from :input_html options" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :input_html => { :max => "1970-01-01" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[max='1970-01-01']"
+    end
+    
+  end
+  
+  describe "step attribute" do
+    
+    it "defaults to 1" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker))
+        end
+      )
+      expect(output_buffer).to have_tag "input[step='1']"
+    end
+
+    it "can be set from :input_html options" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :input_html => { :step => "5" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[step='5']"
+    end
+    
+    describe "macros" do
+      
+      before do 
+        concat(
+          semantic_form_for(@new_post) do |f|
+            concat(f.input(:publish_at, :as => :date_picker, :input_html => { :step => step }))
+          end
+        )
+      end
+      
+      context ":day" do
+        let(:step) { :day }
+        it "uses 1" do
+          expect(output_buffer).to have_tag "input[step='1']"
+        end
+      end
+      
+      context ":seven_days" do
+        let(:step) { :seven_days }
+        it "uses 7" do
+          expect(output_buffer).to have_tag "input[step='7']"
+        end
+      end
+      
+      context ":week" do
+        let(:step) { :week }
+        it "uses 7" do
+          expect(output_buffer).to have_tag "input[step='7']"
+        end
+      end
+      
+      context ":fortnight" do
+        let(:step) { :fortnight }
+        it "uses 14" do
+          expect(output_buffer).to have_tag "input[step='14']"
+        end
+      end
+      
+      context ":two_weeks" do
+        let(:step) { :two_weeks }
+        it "uses 14" do
+          expect(output_buffer).to have_tag "input[step='14']"
+        end
+      end
+      
+      context ":four_weeks" do
+        let(:step) { :four_weeks }
+        it "uses 28" do
+          expect(output_buffer).to have_tag "input[step='28']"
+        end
+      end
+      
+      context ":thirty_days" do
+        let(:step) { :thirty_days }
+        it "uses 30" do
+          expect(output_buffer).to have_tag "input[step='30']"
+        end
+      end
+      
+    end
+    
+  end
+  
+  describe "placeholder attribute" do
+    
+    it "will be omitted" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker))
+        end
+      )
+      expect(output_buffer).not_to have_tag "input[placeholder]"
+    end
+    
+    it "can be set from :input_html options" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:publish_at, :as => :date_picker, :input_html => { :placeholder => "1970-01-01" }))
+        end
+      )
+      expect(output_buffer).to have_tag "input[placeholder='1970-01-01']"
+    end
+    
+    context "with i18n set" do
+      before do
+        ::I18n.backend.store_translations :en, :formtastic => { :placeholders => { :publish_at => 'YYYY-MM-DD' }}
+      end
+      
+      it "can be set with i18n" do
+        with_config :i18n_lookups_by_default, true do
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.input(:publish_at, :as => :date_picker))
+          end)
+          expect(output_buffer).to have_tag('input[@placeholder="YYYY-MM-DD"]')
+        end
+      end
+      
+      it "can be set with input_html, trumping i18n" do
+        with_config :i18n_lookups_by_default, true do
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.input(:publish_at, :as => :date_picker, :input_html => { :placeholder => "Something" }))
+          end)
+          expect(output_buffer).to have_tag('input[@placeholder="Something"]')
+        end
+      end
+    end
+    
+  end
+  
+  describe "when namespace is provided" do
+    before do
+      concat(semantic_form_for(@new_post, :namespace => "context2") do |builder|
+        concat(builder.input(:publish_at, :as => :date_picker))
+      end)
+    end
+
+    it_should_have_input_wrapper_with_id("context2_post_publish_at_input")
+    it_should_have_label_and_input_with_id("context2_post_publish_at")
+  end
+  
+  describe "when index is provided" do
+    before do
+      @output_buffer = ''
+      mock_everything
+
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.fields_for(:author, :index => 3) do |author|
+          concat(author.input(:created_at, :as => :date_picker))
+        end)
+      end)
+    end
+    
+    it 'should index the id of the wrapper' do
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_created_at_input")
+    end
+    
+    it 'should index the id of the select tag' do
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_created_at")
+    end
+    
+    it 'should index the name of the select tag' do
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][created_at]']")
+    end
+  end
+  
+  describe "when required" do
+    it "should add the required attribute to the input's html options" do
+      with_config :use_required_attribute, true do 
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:publish_at, :as => :date_picker, :required => true))
+        end)
+        expect(output_buffer).to have_tag("input[@required]")
+      end
+    end
+  end
+  
+end