formtastic 2.1.0 → 4.0.0

data/spec/helpers/action_helper_spec.rb

@@ -1,72 +1,61 @@
-# encoding: utf-8
 require 'spec_helper'
 
-describe 'Formtastic::FormBuilder#action' do
-
-  include FormtasticSpecHelper
-
-  before do
-    @output_buffer = ''
-    mock_everything
-  end
-
-  after do
-    ::I18n.backend.reload!
-  end
+RSpec.describe 'with action class finder' do
+  include_context 'form builder'
 
   describe 'arguments and options' do
 
     it 'should require the first argument (the action method)' do
-      lambda {
+      expect {
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.action()) # no args passed in at all
         end)
-      }.should raise_error(ArgumentError)
+      }.to raise_error(ArgumentError)
     end
 
     describe ':as option' do
-    
+
       describe 'when not provided' do
-    
+
         it 'should default to a commit for commit' do
           concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
             concat(builder.action(:submit))
           end)
-          output_buffer.should have_tag('form li.action.input_action', :count => 1)
+          expect(output_buffer).to have_tag('form li.action.input_action', :count => 1)
         end
-    
+
         it 'should default to a button for reset' do
           concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
             concat(builder.action(:reset))
           end)
-          output_buffer.should have_tag('form li.action.input_action', :count => 1)
+          expect(output_buffer).to have_tag('form li.action.input_action', :count => 1)
         end
 
         it 'should default to a link for cancel' do
           concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
             concat(builder.action(:cancel))
           end)
-          output_buffer.should have_tag('form li.action.link_action', :count => 1)
+          expect(output_buffer).to have_tag('form li.action.link_action', :count => 1)
         end
       end
-    
+
       it 'should call the corresponding action class with .to_html' do
         [:input, :button, :link].each do |action_style|
           semantic_form_for(:project, :url => "http://test.host") do |builder|
-            action_instance = mock('Action instance')
+            action_instance = double('Action instance')
             action_class = "#{action_style.to_s}_action".classify
             action_constant = "Formtastic::Actions::#{action_class}".constantize
-    
-            action_constant.should_receive(:new).and_return(action_instance)
-            action_instance.should_receive(:to_html).and_return("some HTML")
-    
+
+            expect(action_constant).to receive(:new).and_return(action_instance)
+            expect(action_instance).to receive(:to_html).and_return("some HTML")
+
             concat(builder.action(:submit, :as => action_style))
           end
         end
       end
-    
+
     end
-    
+
     #describe ':label option' do
     #
     #  describe 'when provided' do
@@ -99,7 +88,7 @@ describe 'Formtastic::FormBuilder#action' do
     #          it 'should render a label with localized text and not apply the label_str_method' do
     #            with_config :label_str_method, :reverse do
     #              @localized_label_text = 'Localized title'
-    #              @new_post.stub!(:meta_description)
+    #              @new_post.stub(:meta_description)
     #              ::I18n.backend.store_translations :en,
     #                :formtastic => {
     #                  :labels => {
@@ -132,7 +121,7 @@ describe 'Formtastic::FormBuilder#action' do
     #
     #      describe 'and object is given' do
     #        it 'should delegate the label logic to class human attribute name and pass it down to the label tag' do
-    #          @new_post.stub!(:meta_description) # a two word method name
+    #          @new_post.stub(:meta_description) # a two word method name
     #          @new_post.class.should_receive(:human_attribute_name).with('meta_description').and_return('meta_description'.humanize)
     #
     #          concat(semantic_form_for(@new_post) do |builder|
@@ -145,7 +134,7 @@ describe 'Formtastic::FormBuilder#action' do
     #      describe 'and object is given with label_str_method set to :capitalize' do
     #        it 'should capitalize method name, passing it down to the label tag' do
     #          with_config :label_str_method, :capitalize do
-    #            @new_post.stub!(:meta_description)
+    #            @new_post.stub(:meta_description)
     #
     #            concat(semantic_form_for(@new_post) do |builder|
     #              concat(builder.input(:meta_description))
@@ -207,159 +196,142 @@ describe 'Formtastic::FormBuilder#action' do
     #end
     #
     describe ':wrapper_html option' do
-    
+
       describe 'when provided' do
         it 'should be passed down to the li tag' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :wrapper_html => {:id => :another_id}))
           end)
-          output_buffer.should have_tag("form li#another_id")
+          expect(output_buffer).to have_tag("form li#another_id")
         end
-    
+
         it 'should append given classes to li default classes' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :wrapper_html => {:class => :another_class}))
           end)
-          output_buffer.should have_tag("form li.action")
-          output_buffer.should have_tag("form li.input_action")
-          output_buffer.should have_tag("form li.another_class")
+          expect(output_buffer).to have_tag("form li.action")
+          expect(output_buffer).to have_tag("form li.input_action")
+          expect(output_buffer).to have_tag("form li.another_class")
         end
-    
+
         it 'should allow classes to be an array' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :wrapper_html => {:class => [ :my_class, :another_class ]}))
           end)
-          output_buffer.should have_tag("form li.action")
-          output_buffer.should have_tag("form li.input_action")
-          output_buffer.should have_tag("form li.my_class")
-          output_buffer.should have_tag("form li.another_class")
+          expect(output_buffer).to have_tag("form li.action")
+          expect(output_buffer).to have_tag("form li.input_action")
+          expect(output_buffer).to have_tag("form li.my_class")
+          expect(output_buffer).to have_tag("form li.another_class")
         end
       end
-    
+
       describe 'when not provided' do
         it 'should use default id and class' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit))
           end)
-          output_buffer.should have_tag("form li#post_submit_action")
-          output_buffer.should have_tag("form li.action")
-          output_buffer.should have_tag("form li.input_action")
+          expect(output_buffer).to have_tag("form li#post_submit_action")
+          expect(output_buffer).to have_tag("form li.action")
+          expect(output_buffer).to have_tag("form li.input_action")
         end
       end
-    
+
     end
-    
+
   end
 
   describe 'instantiating an action class' do
-  
     context 'when a class does not exist' do
       it "should raise an error" do
-        lambda {
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             builder.action(:submit, :as => :non_existant)
           end)
-        }.should raise_error(Formtastic::UnknownActionError)
+        }.to raise_error(Formtastic::UnknownActionError)
       end
     end
-  
+
     context 'when a customized top-level class does not exist' do
-  
       it 'should instantiate the Formtastic action' do
-        action = mock('action', :to_html => 'some HTML')
-        Formtastic::Actions::ButtonAction.should_receive(:new).and_return(action)
+        action = double('action', :to_html => 'some HTML')
+        expect(Formtastic::Actions::ButtonAction).to receive(:new).and_return(action)
         concat(semantic_form_for(@new_post) do |builder|
           builder.action(:commit, :as => :button)
         end)
       end
-  
     end
-  
+
     describe 'when a top-level (custom) action class exists' do
       it "should instantiate the top-level action instead of the Formtastic one" do
         class ::ButtonAction < Formtastic::Actions::ButtonAction
         end
-  
-        action = mock('action', :to_html => 'some HTML')
-        Formtastic::Actions::ButtonAction.should_not_receive(:new).and_return(action)
-        ::ButtonAction.should_receive(:new).and_return(action)
-  
+
+        action = double('action', :to_html => 'some HTML')
+        expect(Formtastic::Actions::ButtonAction).not_to receive(:new)
+        expect(::ButtonAction).to receive(:new).and_return(action)
+
         concat(semantic_form_for(@new_post) do |builder|
           builder.action(:commit, :as => :button)
         end)
       end
     end
-  
-    describe 'when instantiated multiple times with the same action type' do
-  
-      it "should be cached (not calling the internal methods)" do
-        # TODO this is really tied to the underlying implementation
-        concat(semantic_form_for(@new_post) do |builder|
-          builder.should_receive(:custom_action_class_name).with(:button).once.and_return(::Formtastic::Actions::ButtonAction)
-          builder.action(:submit, :as => :button)
-          builder.action(:submit, :as => :button)
-        end)
-      end
-  
-    end
-    
+
     describe 'support for :as on each action' do
-      
+
       it "should raise an error when the action does not support the :as" do
-        lambda {
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :as => :link))
           end)
-        }.should raise_error(Formtastic::UnsupportedMethodForAction)
-        
-        lambda {
+        }.to raise_error(Formtastic::UnsupportedMethodForAction)
+
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:cancel, :as => :input))
           end)
-        }.should raise_error(Formtastic::UnsupportedMethodForAction)
-        
-        lambda {
+        }.to raise_error(Formtastic::UnsupportedMethodForAction)
+
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:cancel, :as => :button))
           end)
-        }.should raise_error(Formtastic::UnsupportedMethodForAction)
+        }.to raise_error(Formtastic::UnsupportedMethodForAction)
       end
-      
+
       it "should not raise an error when the action does not support the :as" do
-        lambda {
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:cancel, :as => :link))
           end)
-        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
-        
-        lambda {
+        }.not_to raise_error
+
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :as => :input))
           end)
-        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
+        }.not_to raise_error
 
-        lambda {
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :as => :button))
           end)
-        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
-        
-        lambda {
+        }.not_to raise_error
+
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:reset, :as => :input))
           end)
-        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
-        
-        lambda {
+        }.not_to raise_error
+
+        expect {
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:reset, :as => :button))
           end)
-        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
+        }.not_to raise_error
       end
-      
+
     end
-    
+
   end
 
 end
-

data/spec/helpers/actions_helper_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'Formtastic::FormBuilder#actions' do
+RSpec.describe 'Formtastic::FormBuilder#actions' do
 
   include FormtasticSpecHelper
 
@@ -21,19 +21,19 @@ describe 'Formtastic::FormBuilder#actions' do
       end
 
       it 'should render a fieldset inside the form, with a class of "actions"' do
-        output_buffer.should have_tag("form fieldset.actions")
+        expect(output_buffer).to have_tag("form fieldset.actions")
       end
 
       it 'should render an ol inside the fieldset' do
-        output_buffer.should have_tag("form fieldset.actions ol")
+        expect(output_buffer).to have_tag("form fieldset.actions ol")
       end
 
       it 'should render the contents of the block inside the ol' do
-        output_buffer.should have_tag("form fieldset.actions ol", /hello/)
+        expect(output_buffer).to have_tag("form fieldset.actions ol", :text => /hello/)
       end
 
       it 'should not render a legend inside the fieldset' do
-        output_buffer.should_not have_tag("form fieldset.actions legend")
+        expect(output_buffer).not_to have_tag("form fieldset.actions legend")
       end
     end
 
@@ -47,7 +47,7 @@ describe 'Formtastic::FormBuilder#actions' do
         end)
       end
       it 'should render a fieldset inside the form' do
-        output_buffer.should have_tag("form fieldset.actions legend", /#{@legend_text}/)
+        expect(output_buffer).to have_tag("form fieldset.actions legend", :text => /#{@legend_text}/)
       end
     end
     
@@ -62,8 +62,8 @@ describe 'Formtastic::FormBuilder#actions' do
         end)
       end
       it 'should pass the options into the fieldset tag as attributes' do
-        output_buffer.should have_tag("form fieldset##{@id_option}")
-        output_buffer.should have_tag("form fieldset.#{@class_option}")
+        expect(output_buffer).to have_tag("form fieldset##{@id_option}")
+        expect(output_buffer).to have_tag("form fieldset.#{@class_option}")
       end
     end
     
@@ -80,23 +80,23 @@ describe 'Formtastic::FormBuilder#actions' do
       end
   
       it 'should render a form' do
-        output_buffer.should have_tag('form')
+        expect(output_buffer).to have_tag('form')
       end
   
       it 'should render an actions fieldset inside the form' do
-        output_buffer.should have_tag('form fieldset.actions')
+        expect(output_buffer).to have_tag('form fieldset.actions')
       end
   
       it 'should not render a legend in the fieldset' do
-        output_buffer.should_not have_tag('form fieldset.actions legend')
+        expect(output_buffer).not_to have_tag('form fieldset.actions legend')
       end
   
       it 'should render an ol in the fieldset' do
-        output_buffer.should have_tag('form fieldset.actions ol')
+        expect(output_buffer).to have_tag('form fieldset.actions ol')
       end
   
       it 'should render a list item in the ol for each default action' do
-        output_buffer.should have_tag('form fieldset.actions ol li.action.input_action', :count => 1)
+        expect(output_buffer).to have_tag('form fieldset.actions ol li.action.input_action', :count => 1)
       end
   
     end
@@ -110,7 +110,7 @@ describe 'Formtastic::FormBuilder#actions' do
       end
     
       it 'should render a form with a fieldset containing a list item for each button arg' do
-        output_buffer.should have_tag('form > fieldset.actions > ol > li.action', :count => 3)
+        expect(output_buffer).to have_tag('form > fieldset.actions > ol > li.action', :count => 3)
       end
     
     end
@@ -124,15 +124,15 @@ describe 'Formtastic::FormBuilder#actions' do
      end
     
      it 'should render a form with a fieldset containing a list item for each button arg' do
-       output_buffer.should have_tag('form > fieldset.actions > ol > li.action', :count => 3)
+       expect(output_buffer).to have_tag('form > fieldset.actions > ol > li.action', :count => 3)
      end
     
      it 'should pass the options down to the fieldset' do
-       output_buffer.should have_tag('form > fieldset#my-id.actions')
+       expect(output_buffer).to have_tag('form > fieldset#my-id.actions')
      end
     
      it 'should use the special :name option as a text for the legend tag' do
-       output_buffer.should have_tag('form > fieldset#my-id.actions > legend', /Now click a button/)
+       expect(output_buffer).to have_tag('form > fieldset#my-id.actions > legend', :text => /Now click a button/)
      end
     
     end