formtastic 2.1.0 → 4.0.0

data/spec/builder/semantic_fields_for_spec.rb

@@ -1,44 +1,44 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'Formtastic::FormBuilder#fields_for' do
+RSpec.describe 'Formtastic::FormBuilder#fields_for' do
 
   include FormtasticSpecHelper
 
   before do
     @output_buffer = ''
     mock_everything
-    @new_post.stub!(:author).and_return(::Author.new)
+    allow(@new_post).to receive(:author).and_return(::Author.new)
   end
 
   context 'outside a form_for block' do
     it 'yields an instance of FormHelper.builder' do
       semantic_fields_for(@new_post) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
       semantic_fields_for(@new_post.author) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
       semantic_fields_for(:author, @new_post.author) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
       semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
     end
     
     it 'should respond to input' do
       semantic_fields_for(@new_post) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
       semantic_fields_for(@new_post.author) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
       semantic_fields_for(:author, @new_post.author) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
       semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
     end
   end
@@ -47,7 +47,7 @@ describe 'Formtastic::FormBuilder#fields_for' do
     it 'yields an instance of FormHelper.builder' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(:author) do |nested_builder|
-          nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+          expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
         end
       end
     end
@@ -55,7 +55,7 @@ describe 'Formtastic::FormBuilder#fields_for' do
     it 'yields an instance of FormHelper.builder with hash-like model' do
       semantic_form_for(:user) do |builder|
         builder.semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
-          nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+          expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
         end
       end
     end
@@ -63,7 +63,7 @@ describe 'Formtastic::FormBuilder#fields_for' do
     it 'nests the object name' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(@bob) do |nested_builder|
-          nested_builder.object_name.should == 'post[author]'
+          expect(nested_builder.object_name).to eq('post[author]')
         end
       end
     end
@@ -71,45 +71,45 @@ describe 'Formtastic::FormBuilder#fields_for' do
     it 'supports passing collection as second parameter' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(:author, [@fred,@bob]) do |nested_builder|
-          nested_builder.object_name.should =~ /post\[author_attributes\]\[\d+\]/
+          expect(nested_builder.object_name).to match(/post\[author_attributes\]\[\d+\]/)
         end
       end
     end
     
     it 'should sanitize html id for li tag' do
-      @bob.stub!(:column_for_attribute).and_return(mock('column', :type => :string, :limit => 255))
+      allow(@bob).to receive(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.semantic_fields_for(@bob, :index => 1) do |nested_builder|
           concat(nested_builder.inputs(:login))
         end)
       end)
-      output_buffer.should have_tag('form fieldset.inputs #post_author_1_login_input')
+      expect(output_buffer).to have_tag('form fieldset.inputs #post_author_1_login_input')
       # Not valid selector, so using good ol' regex
-      output_buffer.should_not =~ /id="post\[author\]_1_login_input"/
+      expect(output_buffer).not_to match(/id="post\[author\]_1_login_input"/)
       # <=> output_buffer.should_not have_tag('form fieldset.inputs #post[author]_1_login_input')
     end
     
     it 'should use namespace provided in nested fields' do
-      @bob.stub!(:column_for_attribute).and_return(mock('column', :type => :string, :limit => 255))
+      allow(@bob).to receive(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
         concat(builder.semantic_fields_for(@bob, :index => 1) do |nested_builder|
           concat(nested_builder.inputs(:login))
         end)
       end)
-      output_buffer.should have_tag('form fieldset.inputs #context2_post_author_1_login_input')
+      expect(output_buffer).to have_tag('form fieldset.inputs #context2_post_author_1_login_input')
     end
     
     it 'should render errors on the nested inputs' do
-      @errors = mock('errors')
-      @errors.stub!(:[]).with(:login).and_return(['oh noes'])
-      @bob.stub!(:errors).and_return(@errors)
+      @errors = double('errors')
+      allow(@errors).to receive(:[]).with(errors_matcher(:login)).and_return(['oh noes'])      
+      allow(@bob).to receive(:errors).and_return(@errors)
       
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
         concat(builder.semantic_fields_for(@bob) do |nested_builder|
           concat(nested_builder.inputs(:login))
         end)
       end)
-      output_buffer.should =~ /oh noes/
+      expect(output_buffer).to match(/oh noes/)
     end
     
   end
@@ -119,10 +119,9 @@ describe 'Formtastic::FormBuilder#fields_for' do
     before do
       output_buffer.replace ''
       
-      @fred.posts.size.should == 1
-      @fred.posts.first.stub!(:persisted?).and_return(true)
-      @fred.stub!(:posts_attributes=)
-
+      expect(@fred.posts.size).to eq(1)
+      allow(@fred.posts.first).to receive(:persisted?).and_return(true)
+      allow(@fred).to receive(:posts_attributes=)
       concat(semantic_form_for(@fred) do |builder|
         concat(builder.semantic_fields_for(:posts) do |nested_builder|
           concat(nested_builder.input(:id, :as => :hidden))
@@ -132,11 +131,11 @@ describe 'Formtastic::FormBuilder#fields_for' do
     end
   
     it "should only render one hidden input (my one)" do
-      output_buffer.should have_tag 'input#author_posts_attributes_0_id', :count => 1
+      expect(output_buffer).to have_tag 'input#author_posts_attributes_0_id', :count => 1
     end
     
     it "should render the hidden input inside an li.hidden" do
-      output_buffer.should have_tag 'li.hidden input#author_posts_attributes_0_id'
+      expect(output_buffer).to have_tag 'li.hidden input#author_posts_attributes_0_id'
     end
   end
 

data/spec/fast_spec_helper.rb

@@ -0,0 +1,12 @@
+# encoding: utf-8
+$LOAD_PATH << 'lib/formtastic'
+require 'active_support/all'
+require 'localized_string'
+require 'inputs'
+require 'helpers'
+
+class MyInput
+  include Formtastic::Inputs::Base
+end
+
+I18n.enforce_available_locales = false if I18n.respond_to?(:enforce_available_locales)

data/spec/generators/formtastic/form/form_generator_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 # Generators are not automatically loaded by Rails
 require 'generators/formtastic/form/form_generator'
 
-describe Formtastic::FormGenerator do
+RSpec.describe Formtastic::FormGenerator do
 
   include FormtasticSpecHelper
 
@@ -14,23 +14,27 @@ describe Formtastic::FormGenerator do
     @output_buffer = ''
     prepare_destination
     mock_everything
-    ::Post.stub!(:reflect_on_all_associations).with(:belongs_to).and_return([
-      mock('reflection', :name => :author, :options => {}, :klass => ::Author, :macro => :belongs_to),
-      mock('reflection', :name => :reviewer, :options => {:class_name => 'Author'}, :klass => ::Author, :macro => :belongs_to),
-      mock('reflection', :name => :main_post, :options => {}, :klass => ::Post, :macro => :belongs_to),
-      mock('reflection', :name => :attachment, :options => {:polymorphic => true}, :macro => :belongs_to),
+    allow(::Post).to receive(:reflect_on_all_associations).with(:belongs_to).and_return([
+      double('reflection', :name => :author, :options => {}, :klass => ::Author, :macro => :belongs_to),
+      double('reflection', :name => :reviewer, :options => {:class_name => 'Author'}, :klass => ::Author, :macro => :belongs_to),
+      double('reflection', :name => :main_post, :options => {}, :klass => ::Post, :macro => :belongs_to),
+      double('reflection', :name => :attachment, :options => {:polymorphic => true}, :macro => :belongs_to),
     ])
   end
+  
+  after do
+    FileUtils.rm_rf(File.expand_path("../../../../../tmp", __FILE__))
+  end
 
   describe 'without model' do
     it 'should raise Thor::RequiredArgumentMissingError' do
-      lambda { run_generator }.should raise_error(Thor::RequiredArgumentMissingError)
+      expect { run_generator }.to raise_error(Thor::RequiredArgumentMissingError)
     end
   end
 
   describe 'with existing model' do
     it 'should not raise an exception' do
-      lambda { run_generator %w(Post) }.should_not raise_error(Thor::RequiredArgumentMissingError)
+      expect { run_generator %w(Post) }.not_to raise_error
     end
   end
 
@@ -39,10 +43,10 @@ describe Formtastic::FormGenerator do
 
     describe 'render only the specified attributes' do
       subject { file('app/views/posts/_form.html.erb') }
-      it { should exist }
-      it { should contain "<%= f.input :title %>" }
-      it { should contain "<%= f.input :author %>" }
-      it { should_not contain "<%= f.input :main_post %>" }
+      it { is_expected.to exist }
+      it { is_expected.to contain "<%= f.input :title %>" }
+      it { is_expected.to contain "<%= f.input :author %>" }
+      it { is_expected.not_to contain "<%= f.input :main_post %>" }
     end
   end
 
@@ -52,17 +56,17 @@ describe Formtastic::FormGenerator do
     subject { file('app/views/posts/_form.html.erb') }
 
     describe 'content_columns' do
-      it { should contain "<%= f.input :title %>" }
-      it { should contain "<%= f.input :body %>" }
-      it { should_not contain "<%= f.input :created_at %>" }
-      it { should_not contain "<%= f.input :updated_at %>" }
+      it { is_expected.to contain "<%= f.input :title %>" }
+      it { is_expected.to contain "<%= f.input :body %>" }
+      it { is_expected.not_to contain "<%= f.input :created_at %>" }
+      it { is_expected.not_to contain "<%= f.input :updated_at %>" }
     end
 
     describe 'reflection_on_association' do
-      it { should contain "<%= f.input :author %>" }
-      it { should contain "<%= f.input :reviewer %>" }
-      it { should contain "<%= f.input :main_post %>" }
-      it { should_not contain "<%= f.input :attachment %>" }
+      it { is_expected.to contain "<%= f.input :author %>" }
+      it { is_expected.to contain "<%= f.input :reviewer %>" }
+      it { is_expected.to contain "<%= f.input :main_post %>" }
+      it { is_expected.not_to contain "<%= f.input :attachment %>" }
     end
   end
 
@@ -72,19 +76,28 @@ describe Formtastic::FormGenerator do
 
       describe 'app/views/posts/_form.html.erb' do
         subject { file('app/views/posts/_form.html.erb') }
-        it { should exist }
-        it { should contain "<%= semantic_form_for @post do |f| %>" }
+        it { is_expected.to exist }
+        it { is_expected.to contain "<%= semantic_form_for @post do |f| %>" }
       end
     end
 
     describe 'haml' do
-      before { run_generator %w(Post --template-engine haml) }
-
+      
       describe 'app/views/posts/_form.html.haml' do
+        before { run_generator %w(Post --template-engine haml) }
         subject { file('app/views/posts/_form.html.haml') }
-        it { should exist }
-        it { should contain "= semantic_form_for @post do |f|" }
+        it { is_expected.to exist }
+        it { is_expected.to contain "= semantic_form_for @post do |f|" }
+      end
+      
+      context 'with copy option' do
+        describe 'app/views/posts/_form.html.haml' do
+          before { run_generator %w(Post --copy --template-engine haml) }
+          subject { file('app/views/posts/_form.html.haml') }
+          it { is_expected.not_to exist }
+        end
       end
+      
     end
 
     describe 'slim' do
@@ -92,18 +105,18 @@ describe Formtastic::FormGenerator do
 
       describe 'app/views/posts/_form.html.slim' do
         subject { file('app/views/posts/_form.html.slim') }
-        it { should exist }
-        it { should contain "= semantic_form_for @post do |f|" }
+        it { is_expected.to exist }
+        it { is_expected.to contain "= semantic_form_for @post do |f|" }
       end
     end
   end
-
+  
   describe 'with copy option' do
     before { run_generator %w(Post --copy) }
-
+  
     describe 'app/views/posts/_form.html.erb' do
       subject { file('app/views/posts/_form.html.erb') }
-      it { should_not exist }
+      it { is_expected.not_to exist }
     end
   end
 
@@ -112,7 +125,7 @@ describe Formtastic::FormGenerator do
 
     describe 'app/views/admin/posts/_form.html.erb' do
       subject { file('app/views/admin/posts/_form.html.erb') }
-      it { should exist }
+      it { is_expected.to exist }
     end
   end
 end

data/spec/generators/formtastic/input/input_generator_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+
+require 'generators/formtastic/input/input_generator'
+
+RSpec.describe Formtastic::InputGenerator do
+  include FormtasticSpecHelper
+
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before do
+    prepare_destination
+  end
+
+  after do
+    FileUtils.rm_rf(File.expand_path("../../../../../tmp", __FILE__))
+  end
+
+  describe 'without file name' do
+    it 'should raise Thor::RequiredArgumentMissingError' do
+      expect { run_generator }.to raise_error(Thor::RequiredArgumentMissingError)
+    end
+  end
+
+  describe "input generator with underscore definition" do
+    before { run_generator %w(hat_size)}
+
+    describe 'generate an input in its respective folder' do
+      subject{ file('app/inputs/hat_size_input.rb')}
+      it { is_expected.to exist}
+      it { is_expected.to contain "class HatSizeInput"}
+      it { is_expected.to contain "def to_html"}
+      it { is_expected.to contain "include Formtastic::Inputs::Base"}
+      it { is_expected.not_to contain "super"}
+    end
+  end
+
+  describe "input generator with camelcase definition" do
+    before { run_generator %w(HatSize)}
+
+    describe 'generate an input in its respective folder' do
+      subject{ file('app/inputs/hat_size_input.rb')}
+      it { is_expected.to exist}
+      it { is_expected.to contain "class HatSizeInput"}
+    end
+  end
+
+  describe "input generator with camelcase Input name sufixed" do
+    before { run_generator %w(HatSizeInput)}
+
+    describe 'generate an input in its respective folder' do
+      subject{ file('app/inputs/hat_size_input.rb')}
+      it { is_expected.to exist}
+      it { is_expected.to contain "class HatSizeInput"}
+    end
+  end
+
+  describe "input generator with underscore _input name sufixed" do
+    before { run_generator %w(hat_size_input)}
+
+    describe 'generate an input in its respective folder' do
+      subject{ file('app/inputs/hat_size_input.rb')}
+      it { is_expected.to exist}
+      it { is_expected.to contain "class HatSizeInput"}
+    end
+  end
+
+  describe "input generator with underscore input name sufixed" do
+    before { run_generator %w(hat_sizeinput)}
+
+    describe 'generate an input in its respective folder' do
+      subject{ file('app/inputs/hat_size_input.rb')}
+      it { is_expected.to exist}
+      it { is_expected.to contain "class HatSizeInput"}
+    end
+  end
+
+  describe "override an existing input using extend" do
+    before { run_generator %w(string --extend)}
+
+    describe 'app/inputs/string_input.rb' do
+      subject{ file('app/inputs/string_input.rb')}
+      it { is_expected.to exist }
+      it { is_expected.to contain "class StringInput < Formtastic::Inputs::StringInput" }
+      it { is_expected.to contain "def to_html" }
+      it { is_expected.not_to contain "include Formtastic::Inputs::Base" }
+      it { is_expected.to contain "super" }
+      it { is_expected.not_to contain "def input_html_options" }
+    end
+  end
+
+  describe "extend an existing input" do
+    before { run_generator %w(FlexibleText --extend string)}
+
+    describe 'app/inputs/flexible_text_input.rb' do
+      subject{ file('app/inputs/flexible_text_input.rb')}
+      it { is_expected.to contain "class FlexibleTextInput < Formtastic::Inputs::StringInput" }
+      it { is_expected.to contain "def input_html_options" }
+      it { is_expected.not_to contain "include Formtastic::Inputs::Base" }
+      it { is_expected.not_to contain "def to_html" }
+    end
+  end
+
+  describe "provide a slashed namespace" do
+    before { run_generator %w(stuff/foo)}
+
+    describe 'app/inputs/stuff/foo_input.rb' do
+      subject{ file('app/inputs/stuff/foo_input.rb')}
+      it {is_expected.to exist}
+      it { is_expected.to contain "class Stuff::FooInput" }
+      it { is_expected.to contain "include Formtastic::Inputs::Base" }
+    end
+  end
+
+  describe "provide a camelized namespace" do
+    before { run_generator %w(Stuff::Foo)}
+
+    describe 'app/inputs/stuff/foo_input.rb' do
+      subject{ file('app/inputs/stuff/foo_input.rb')}
+      it {is_expected.to exist}
+      it { is_expected.to contain "class Stuff::FooInput" }
+      it { is_expected.to contain "include Formtastic::Inputs::Base" }
+    end
+  end
+end

data/spec/generators/formtastic/install/install_generator_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 # Generators are not automatically loaded by Rails
 require 'generators/formtastic/install/install_generator'
 
-describe Formtastic::InstallGenerator do
+RSpec.describe Formtastic::InstallGenerator do
   # Tell the generator where to put its output (what it thinks of as Rails.root)
   destination File.expand_path("../../../../../tmp", __FILE__)
 
@@ -14,14 +14,14 @@ describe Formtastic::InstallGenerator do
 
     describe 'config/initializers/formtastic.rb' do
       subject { file('config/initializers/formtastic.rb') }
-      it { should exist }
-      it { should contain "# Please note: If you're subclassing Formtastic::FormBuilder" }
+      it { is_expected.to exist }
+      it { is_expected.to contain "#" }
     end
 
     describe 'lib/templates/erb/scaffold/_form.html.erb' do
       subject { file('lib/templates/erb/scaffold/_form.html.erb') }
-      it { should exist }
-      it { should contain "<%%= semantic_form_for @<%= singular_name %> do |f| %>" }
+      it { is_expected.to exist }
+      it { is_expected.to contain "<%%= semantic_form_for @<%= singular_name %> do |f| %>" }
     end
   end
 
@@ -30,8 +30,8 @@ describe Formtastic::InstallGenerator do
 
     describe 'lib/templates/erb/scaffold/_form.html.haml' do
       subject { file('lib/templates/haml/scaffold/_form.html.haml') }
-      it { should exist }
-      it { should contain "= semantic_form_for @<%= singular_name %> do |f|" }
+      it { is_expected.to exist }
+      it { is_expected.to contain "= semantic_form_for @<%= singular_name %> do |f|" }
     end
   end
 
@@ -40,8 +40,8 @@ describe Formtastic::InstallGenerator do
 
     describe 'lib/templates/erb/scaffold/_form.html.slim' do
       subject { file('lib/templates/slim/scaffold/_form.html.slim') }
-      it { should exist }
-      it { should contain "= semantic_form_for @<%= singular_name %> do |f|" }
+      it { is_expected.to exist }
+      it { is_expected.to contain "= semantic_form_for @<%= singular_name %> do |f|" }
     end
   end
 end