formtastic 2.1.0 → 4.0.0

data/spec/inputs/boolean_input_spec.rb

@@ -1,53 +1,61 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'boolean input' do
+RSpec.describe 'boolean input' do
 
   include FormtasticSpecHelper
 
   before do
     @output_buffer = ''
     mock_everything
-
-    concat(semantic_form_for(@new_post) do |builder|
-      concat(builder.input(:allow_comments, :as => :boolean))
-    end)
-  end
-
-  it_should_have_input_wrapper_with_class("boolean")
-  it_should_have_input_wrapper_with_class(:input)
-  it_should_have_input_wrapper_with_id("post_allow_comments_input")
-  it_should_apply_error_logic_for_input_type(:boolean)
-
-  it 'should generate a label containing the input' do
-    output_buffer.should_not have_tag('label.label')
-    output_buffer.should have_tag('form li label', :count => 1)
-    output_buffer.should have_tag('form li label[@for="post_allow_comments"]')
-    output_buffer.should have_tag('form li label', /Allow comments/)
-    output_buffer.should have_tag('form li label input[@type="checkbox"]', :count => 1)
-    output_buffer.should have_tag('form li input[@type="hidden"]', :count => 1)
-    output_buffer.should_not have_tag('form li label input[@type="hidden"]', :count => 1) # invalid HTML5
   end
 
-  it 'should generate a checkbox input' do
-    output_buffer.should have_tag('form li label input')
-    output_buffer.should have_tag('form li label input#post_allow_comments')
-    output_buffer.should have_tag('form li label input[@type="checkbox"]')
-    output_buffer.should have_tag('form li label input[@name="post[allow_comments]"]')
-    output_buffer.should have_tag('form li label input[@type="checkbox"][@value="1"]')
-  end
-
-  it 'should generate a checked input if object.method returns true' do
-    output_buffer.should have_tag('form li label input[@checked="checked"]')
-    output_buffer.should have_tag('form li input[@name="post[allow_comments]"]', :count => 2)
-    output_buffer.should have_tag('form li input#post_allow_comments', :count => 1)
+  describe 'generic' do
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.input(:allow_comments, :as => :boolean))
+      end)
+    end
+    
+    it_should_have_input_wrapper_with_class("boolean")
+    it_should_have_input_wrapper_with_class(:input)
+    it_should_have_input_wrapper_with_id("post_allow_comments_input")
+    it_should_apply_error_logic_for_input_type(:boolean)
+  
+    it 'should generate a label containing the input' do
+    expect(output_buffer).not_to have_tag('label.label')
+    expect(output_buffer).to have_tag('form li label', :count => 1)
+    expect(output_buffer).to have_tag('form li label[@for="post_allow_comments"]')
+    expect(output_buffer).to have_tag('form li label', :text => /Allow comments/)
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"]', :count => 1)
+    expect(output_buffer).to have_tag('form li input[@type="hidden"]', :count => 1)
+    expect(output_buffer).not_to have_tag('form li label input[@type="hidden"]', :count => 1) # invalid HTML5
+    end
+  
+    it 'should not add a "name" attribute to the label' do
+      expect(output_buffer).not_to have_tag('form li label[@name]')
+    end
+  
+    it 'should generate a checkbox input' do
+      expect(output_buffer).to have_tag('form li label input')
+      expect(output_buffer).to have_tag('form li label input#post_allow_comments')
+      expect(output_buffer).to have_tag('form li label input[@type="checkbox"]')
+      expect(output_buffer).to have_tag('form li label input[@name="post[allow_comments]"]')
+      expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="1"]')
+    end
+  
+    it 'should generate a checked input if object.method returns true' do
+      expect(output_buffer).to have_tag('form li label input[@checked="checked"]')
+      expect(output_buffer).to have_tag('form li input[@name="post[allow_comments]"]', :count => 2)
+      expect(output_buffer).to have_tag('form li input#post_allow_comments', :count => 1)
+    end
   end
 
   it 'should generate a checked input if :input_html is passed :checked => checked' do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:answer_comments, :as => :boolean, :input_html => {:checked => 'checked'}))
     end)
-    output_buffer.should have_tag('form li label input[@checked="checked"]')
+    expect(output_buffer).to have_tag('form li label input[@checked="checked"]')
   end
 
   it 'should name the hidden input with the :name html_option' do
@@ -55,8 +63,8 @@ describe 'boolean input' do
       concat(builder.input(:answer_comments, :as => :boolean, :input_html => { :name => "foo" }))
     end)
 
-    output_buffer.should have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
-    output_buffer.should have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
+    expect(output_buffer).to have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
+    expect(output_buffer).to have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
   end
 
   it 'should name the hidden input with the :name html_option' do
@@ -64,73 +72,93 @@ describe 'boolean input' do
       concat(builder.input(:answer_comments, :as => :boolean, :input_html => { :name => "foo" }))
     end)
 
-    output_buffer.should have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
-    output_buffer.should have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
+    expect(output_buffer).to have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
+    expect(output_buffer).to have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
   end
 
   it "should generate a disabled input and hidden input if :input_html is passed :disabled => 'disabled' " do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :input_html => {:disabled => 'disabled'}))
     end)
-    output_buffer.should have_tag('form li label input[@disabled="disabled"]', :count => 1)
-    output_buffer.should have_tag('form li input[@type="hidden"][@disabled="disabled"]', :count => 1)
+    expect(output_buffer).to have_tag('form li label input[@disabled="disabled"]', :count => 1)
+    expect(output_buffer).to have_tag('form li input[@type="hidden"][@disabled="disabled"]', :count => 1)
   end
 
   it 'should generate an input[id] with matching label[for] when id passed in :input_html' do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :input_html => {:id => 'custom_id'}))
     end)
-    output_buffer.should have_tag('form li label input[@id="custom_id"]')
-    output_buffer.should have_tag('form li label[@for="custom_id"]')
+    expect(output_buffer).to have_tag('form li label input[@id="custom_id"]')
+    expect(output_buffer).to have_tag('form li label[@for="custom_id"]')
   end
 
   it 'should allow checked and unchecked values to be sent' do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'checked', :unchecked_value => 'unchecked'))
     end)
-    output_buffer.should have_tag('form li label input[@type="checkbox"][@value="checked"]:not([@unchecked_value][@checked_value])')
-    output_buffer.should have_tag('form li input[@type="hidden"][@value="unchecked"]')
-    output_buffer.should_not have_tag('form li label input[@type="hidden"]') # invalid HTML5
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="checked"]:not([@unchecked_value][@checked_value])')
+    expect(output_buffer).to have_tag('form li input[@type="hidden"][@value="unchecked"]')
+    expect(output_buffer).not_to have_tag('form li label input[@type="hidden"]') # invalid HTML5
   end
 
   it 'should generate a checked input if object.method returns checked value' do
-    @new_post.stub!(:allow_comments).and_return('yes')
+    allow(@new_post).to receive(:allow_comments).and_return('yes')
 
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    output_buffer.should have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
   end
 
   it 'should not generate a checked input if object.method returns unchecked value' do
-    @new_post.stub!(:allow_comments).and_return('no')
+    allow(@new_post).to receive(:allow_comments).and_return('no')
 
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    output_buffer.should have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
   end
 
   it 'should generate a checked input if object.method returns checked value' do
-    @new_post.stub!(:allow_comments).and_return('yes')
+    allow(@new_post).to receive(:allow_comments).and_return('yes')
 
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    output_buffer.should have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
+  end
+
+  it 'should generate a checked input for boolean database values compared to string checked values' do
+    allow(@new_post).to receive(:foo).and_return(1)
+
+    concat(semantic_form_for(@new_post) do |builder|
+      concat(builder.input(:foo, :as => :boolean))
+    end)
+
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="1"][@checked="checked"]')
+  end
+
+  it 'should generate a checked input if object.method returns checked value when inverted' do
+    allow(@new_post).to receive(:allow_comments).and_return(0)
+
+    concat(semantic_form_for(@new_post) do |builder|
+      concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 0, :unchecked_value => 1))
+    end)
+
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="0"][@checked="checked"]')
   end
 
   it 'should not generate a checked input if object.method returns unchecked value' do
-    @new_post.stub!(:allow_comments).and_return('no')
+    allow(@new_post).to receive(:allow_comments).and_return('no')
 
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    output_buffer.should have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
   end
 
   it 'should generate a label and a checkbox even if no object is given' do
@@ -138,13 +166,21 @@ describe 'boolean input' do
       concat(builder.input(:allow_comments, :as => :boolean))
     end)
 
-    output_buffer.should have_tag('form li label[@for="project_allow_comments"]')
-    output_buffer.should have_tag('form li label', /Allow comments/)
-    output_buffer.should have_tag('form li label input[@type="checkbox"]')
+    expect(output_buffer).to have_tag('form li label[@for="project_allow_comments"]')
+    expect(output_buffer).to have_tag('form li label', :text => /Allow comments/)
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"]')
 
-    output_buffer.should have_tag('form li label input#project_allow_comments')
-    output_buffer.should have_tag('form li label input[@type="checkbox"]')
-    output_buffer.should have_tag('form li label input[@name="project[allow_comments]"]')
+    expect(output_buffer).to have_tag('form li label input#project_allow_comments')
+    expect(output_buffer).to have_tag('form li label input[@type="checkbox"]')
+    expect(output_buffer).to have_tag('form li label input[@name="project[allow_comments]"]')
+  end
+  
+  it 'should not pass input_html options down to the label html' do
+    concat(semantic_form_for(@new_post) do |builder|
+      builder.input(:title, :as => :boolean, :input_html => { :tabindex => 2, :x => "X" })
+    end)
+    expect(output_buffer).not_to have_tag('label[tabindex]')
+    expect(output_buffer).not_to have_tag('label[x]')
   end
 
   context "when required" do
@@ -154,7 +190,7 @@ describe 'boolean input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :boolean, :required => true))
         end)
-        output_buffer.should have_tag("input[@required]")
+        expect(output_buffer).to have_tag("input[@required]")
       end
     end
       
@@ -163,7 +199,7 @@ describe 'boolean input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :boolean))
         end)
-        output_buffer.should_not have_tag("input[@required]")
+        expect(output_buffer).not_to have_tag("input[@required]")
       end
     end
     
@@ -199,21 +235,20 @@ describe 'boolean input' do
     end
     
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
     
     it 'should index the id of the input tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name")
     end
     
     it 'should index the name of the hidden input' do
-      output_buffer.should have_tag("input[@type='hidden'][@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@type='hidden'][@name='post[author_attributes][3][name]']")
     end
 
     it 'should index the name of the checkbox input' do
-      output_buffer.should have_tag("input[@type='checkbox'][@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@type='checkbox'][@name='post[author_attributes][3][name]']")
     end
     
   end
-
 end