foreman_discovery 5.0.2 → 6.0.0

data/test/unit/discovery_attribute_set_test.rb

@@ -15,7 +15,7 @@ class DiscoveryAttributeSetTest < ActiveSupport::TestCase
 
   test "can search discovered hosts by cpu" do
     raw = parse_json_fixture('/facts.json')
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     results = Host::Discovered.search_for("cpu_count = #{host.facts_hash['physicalprocessorcount'].to_i}")
     assert_equal 1, results.count
     results = Host::Discovered.search_for("cpu_count > #{host.facts_hash['physicalprocessorcount'].to_i}")
@@ -24,7 +24,7 @@ class DiscoveryAttributeSetTest < ActiveSupport::TestCase
 
   test "can search discovered hosts by memory" do
     raw = parse_json_fixture('/facts.json')
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     results = Host::Discovered.search_for("memory = #{host.facts_hash['memorysize_mb'].to_f.ceil}")
     assert_equal 1, results.count
     results = Host::Discovered.search_for("memory > #{host.facts_hash['memorysize_mb'].to_f.ceil}")
@@ -33,7 +33,7 @@ class DiscoveryAttributeSetTest < ActiveSupport::TestCase
 
   test "can search discovered hosts by disk_count" do
     raw = parse_json_fixture('/facts.json')
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     results = Host::Discovered.search_for("disk_count = 1")
     assert_equal 1, results.count
     results = Host::Discovered.search_for("disk_count = 3")
@@ -42,7 +42,7 @@ class DiscoveryAttributeSetTest < ActiveSupport::TestCase
 
   test "can search discovered hosts by disks_size" do
     raw = parse_json_fixture('/facts.json')
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     disks_size = (host.facts_hash['blockdevice_sda_size'].to_f / 1024 / 1024).ceil
     results = Host::Discovered.search_for("disks_size = #{disks_size}")
     assert_equal 1, results.count

data/test/unit/discovery_taxonomy_extensions_test.rb

@@ -0,0 +1,31 @@
+require 'test_helper'
+
+class DiscoveryTaxonomyExtensionsTest < ActiveSupport::TestCase
+  setup do
+    FactoryGirl.create(:setting,
+                       :name => 'discovery_hostname',
+                       :value => 'discovery_bootif',
+                       :category => 'Setting::Discovered')
+    FactoryGirl.create(:setting,
+                       :name => 'discovery_prefix',
+                       :value => 'mac',
+                       :category => 'Setting::Discovered')
+  end
+
+  test 'deleting location does not hard fail if there is associated discovered host' do
+    location = FactoryGirl.create(:location)
+
+    raw = parse_json_fixture('/facts.json')
+    assert (host = Host::Discovered.import_host(raw['facts']))
+    host.location = location
+    assert host.save
+
+    assert_nothing_raised do
+      refute location.destroy, 'Location was destroyed but it should not be allowed'
+    end
+  end
+
+  def parse_json_fixture(relative_path)
+    return JSON.parse(File.read(File.expand_path(File.dirname(__FILE__) + relative_path)))
+  end
+end

data/test/unit/host_discovered_test.rb

@@ -14,6 +14,18 @@ class HostDiscoveredTest < ActiveSupport::TestCase
                        :name => 'discovery_prefix',
                        :value => 'mac',
                        :category => 'Setting::Discovered')
+    FactoryGirl.create(:setting,
+                       :name => 'discovery_lock',
+                       :value => 'false',
+                       :category => 'Setting::Discovered')
+    FactoryGirl.create(:setting,
+                       :name => 'discovery_lock_template',
+                       :value => 'pxelinux_discovery',
+                       :category => 'Setting::Discovered')
+    FactoryGirl.create(:setting,
+                       :name => 'discovery_clean_facts',
+                       :value => false,
+                       :category => 'Setting::Discovered')
   end
 
   test "should be able to create Host::Discovered objects" do
@@ -23,15 +35,15 @@ class HostDiscoveredTest < ActiveSupport::TestCase
 
   test "should import facts from yaml as Host::Discovered" do
     raw = parse_json_fixture('/facts.json')
-    assert Host::Discovered.import_host_and_facts(raw['facts'])
+    assert Host::Discovered.import_host(raw['facts'])
     assert Host::Discovered.find_by_name('mace41f13cc3658')
   end
 
   test "should setup subnet" do
     raw = parse_json_fixture('/facts.json')
-    subnet = FactoryGirl.create(:subnet, :organizations => [Organization.first], :locations => [Location.first])
+    subnet = FactoryGirl.create(:subnet_ipv4, :name => 'Subnet99', :network => '192.168.99.0', :organizations => [Organization.first], :locations => [Location.first])
     Subnet.expects(:subnet_for).with('10.35.27.3').returns(subnet)
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     assert_equal subnet, host.primary_interface.subnet
   end
 
@@ -47,17 +59,38 @@ class HostDiscoveredTest < ActiveSupport::TestCase
                        :value => loc.name,
                        :category => 'Setting::Discovered')
     raw = parse_json_fixture('/facts.json')
-    subnet = FactoryGirl.create(:subnet, :organizations => [org], :locations => [loc])
+    subnet = FactoryGirl.create(:subnet_ipv4, :name => 'Subnet99', :network => '192.168.99.0', :organizations => [org], :locations => [loc])
     Subnet.expects(:subnet_for).with('10.35.27.3').returns(subnet)
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     assert_equal subnet, host.primary_interface.subnet
   end
 
+  test "should set nested org and loc" do
+    org_parent = FactoryGirl.create(:organization, :name => "org")
+    org = FactoryGirl.create(:organization, :name => "suborg", :parent_id => org_parent.id)
+    loc_parent = FactoryGirl.create(:location, :name => "loc")
+    loc = FactoryGirl.create(:location, :name => "subloc", :parent_id => loc_parent.id)
+    FactoryGirl.create(:setting,
+                       :name => 'discovery_organization',
+                       :value => org.name,
+                       :category => 'Setting::Discovered')
+    FactoryGirl.create(:setting,
+                       :name => 'discovery_location',
+                       :value => loc.name,
+                       :category => 'Setting::Discovered')
+    raw = parse_json_fixture('/facts.json')
+    subnet = FactoryGirl.create(:subnet_ipv4, :name => 'Subnet99', :network => '192.168.99.0', :organizations => [org], :locations => [loc])
+    Subnet.expects(:subnet_for).with('10.35.27.3').returns(subnet)
+    host = Host::Discovered.import_host(raw['facts'])
+    assert_equal org, host.organization
+    assert_equal loc, host.location
+  end
+
   test "should raise when fact_name setting isn't present" do
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_fact] = 'macaddress_foo'
     exception = assert_raises(::Foreman::Exception) do
-      Host::Discovered.import_host_and_facts(raw['facts'])
+      Host::Discovered.import_host(raw['facts'])
     end
     assert_match(/Expected discovery_fact '\w+' is missing/, exception.message)
   end
@@ -73,17 +106,42 @@ class HostDiscoveredTest < ActiveSupport::TestCase
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_hostname] = 'somefact'
     facts = raw['facts'].merge({"somefact" => "somename"})
-    host = Host::Discovered.import_host_and_facts(facts).first
+    host = Host::Discovered.import_host(facts)
     assert_equal 'macsomename', host.name
     refute_equal 'e4:1f:13:cc:36:5a', host.mac
   end
 
+  test "should lock host into discovery via PXE configuration" do
+    Host::Discovered.delete('mace41f13cc3658')
+    Setting[:discovery_lock] = "true"
+    Setting[:discovery_lock_template] = 'discovery_lock_template'
+    raw = parse_json_fixture('/facts.json')
+    subnet = FactoryGirl.create(:subnet,
+                                :tftp,
+                                :network => '10.35.27.0',
+                                :cidr    => '24',
+                                :mask    => '255.255.255.0',
+                                :organizations => [Organization.first],
+                                :locations => [Location.first]
+    )
+    Subnet.expects(:subnet_for).with('10.35.27.3').returns(subnet)
+    ProxyAPI::TFTP.any_instance.expects(:set).with('e4:1f:13:cc:36:58', anything).returns(true)
+    ProvisioningTemplate.where(:name => 'discovery_lock_template').first_or_create(
+        :template_kind_id => template_kinds(:ipxe),
+        :snippet => true,
+        :template => "test"
+    )
+    assert Host::Discovered.import_host(raw['facts'])
+    assert Host::Discovered.find_by_name('mace41f13cc3658')
+    refute Host::Managed.find_by_name('mace41f13cc3658')
+  end
+
   test "should create discovered host with fact_name as a name if it is a valid mac" do
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_fact] = 'somefact'
     Setting[:discovery_hostname] = 'somefact'
     facts = raw['facts'].merge({"somefact" => "E4:1F:13:CC:36:5A"})
-    host = Host::Discovered.import_host_and_facts(facts).first
+    host = Host::Discovered.import_host(facts)
     assert_equal 'mace41f13cc365a', host.name
     assert_equal 'e4:1f:13:cc:36:5a', host.mac
   end
@@ -92,7 +150,7 @@ class HostDiscoveredTest < ActiveSupport::TestCase
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_fact] = 'lsbdistcodename'
     exception = assert_raises(::Foreman::Exception) do
-      Host::Discovered.import_host_and_facts(raw['facts'])
+      Host::Discovered.import_host(raw['facts'])
     end
     assert_match(/Unable to detect primary interface using MAC/, exception.message)
   end
@@ -100,22 +158,31 @@ class HostDiscoveredTest < ActiveSupport::TestCase
   test "should create discovered host with prefix" do
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_prefix] = 'test'
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     assert_equal 'teste41f13cc3658', host.name
   end
 
   test "should create discovered host without prefix" do
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_prefix] = ''
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     assert_equal 'e41f13cc3658',host.name
   end
 
+  test "should refresh existing discovered" do
+    raw = parse_json_fixture('/facts.json')
+    interface = mock()
+    interface.stubs(:host).returns(Host.create(:name => "xyz", :type => "Host::Discovered"))
+    ::Nic::Managed.stubs(:where).with(:mac => raw['facts']['discovery_bootif'].downcase, :primary => true).returns([interface])
+    host = Host::Discovered.import_host(raw['facts'])
+    assert_equal 'xyz', host.name
+  end
+
   test "should raise when hostname fact cannot be found" do
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_hostname] = 'macaddress_foo'
     exception = assert_raises(::Foreman::Exception) do
-      Host::Discovered.import_host_and_facts(raw['facts'])
+      Host::Discovered.import_host(raw['facts'])
     end
     assert_match(/Invalid facts: hash does not contain a valid value for any of the facts in the discovery_hostname setting:/, exception.message)
   end
@@ -126,7 +193,7 @@ class HostDiscoveredTest < ActiveSupport::TestCase
     Setting[:discovery_hostname] = 'invalidhostnamefact'
     Setting[:discovery_prefix] = ''
     exception = assert_raises(::Foreman::Exception) do
-      Host::Discovered.import_host_and_facts(raw['facts'])
+      Host::Discovered.import_host(raw['facts'])
     end
     assert_match(/Invalid hostname: Could not normalize the hostname/, exception.message)
   end
@@ -161,13 +228,42 @@ class HostDiscoveredTest < ActiveSupport::TestCase
     Setting[:token_duration] = 30 #enable tokens so that we only test the CR
     raw = parse_json_fixture('/facts.json')
     Setting[:discovery_prefix] = '123'
-    host = Host::Discovered.import_host_and_facts(raw['facts']).first
+    host = Host::Discovered.import_host(raw['facts'])
     host.save
     h = ::ForemanDiscovery::HostConverter.to_managed(host)
     refute_valid h
     assert Token.where(:host_id => h.id).empty?
   end
 
+  test "all non-discovery facts are deleted after provisioning" do
+    Setting[:discovery_clean_facts] = true
+    raw = parse_json_fixture('/facts.json')['facts']
+    raw.merge!({
+      'delete_me' => "content",
+      'discovery_keep_me' => "content",
+      })
+    host = Host::Discovered.import_host(raw)
+    host.save
+    managed = ::ForemanDiscovery::HostConverter.to_managed(host)
+    managed.clear_facts
+    assert_nil managed.facts_hash['delete_me']
+    assert_equal "content", managed.facts_hash['discovery_keep_me']
+  end
+
+  test "all facts are preserved after provisioning" do
+    raw = parse_json_fixture('/facts.json')['facts']
+    raw.merge!({
+      'keep_me' => "content",
+      'discovery_keep_me' => "content",
+      })
+    host = Host::Discovered.import_host(raw)
+    host.save
+    managed = ::ForemanDiscovery::HostConverter.to_managed(host)
+    managed.clear_facts
+    assert_equal "content", managed.facts_hash['keep_me']
+    assert_equal "content", managed.facts_hash['discovery_keep_me']
+  end
+
   test "normalization of MAC into a discovered host hostname" do
     assert_equal Host::Discovered.normalize_string_for_hostname("90:B1:1C:54:D5:82"),"90b11c54d582"
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_discovery
 version: !ruby/object:Gem::Version
-  version: 5.0.2
+  version: 6.0.0
 platform: ruby
 authors:
 - Amos Benari
@@ -32,7 +32,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-11 00:00:00.000000000 Z
+date: 2016-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -56,152 +56,162 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
-- app/mailers/discovered_mailer.rb
-- app/controllers/discovery_rules_controller.rb
-- app/controllers/discovered_hosts_controller.rb
-- app/controllers/concerns/foreman/controller/discovered_extensions.rb
-- app/controllers/api/v2/discovery_rules_controller.rb
+- LICENSE
+- README.md
 - app/controllers/api/v2/discovered_hosts_controller.rb
-- app/lib/facter_utils.rb
-- app/services/foreman_discovery/node_api/power_service.rb
-- app/services/foreman_discovery/node_api/power_legacy_direct_service.rb
-- app/services/foreman_discovery/node_api/node_resource.rb
-- app/services/foreman_discovery/node_api/power_legacy_proxied_service.rb
-- app/services/foreman_discovery/node_api/power.rb
-- app/services/foreman_discovery/node_api/inventory.rb
-- app/services/foreman_discovery/fact_parser.rb
-- app/services/foreman_discovery/host_converter.rb
-- app/helpers/discovery_rules_helper.rb
-- app/helpers/concerns/foreman_discovery/settings_helper_extensions.rb
+- app/controllers/api/v2/discovery_rules_controller.rb
+- app/controllers/api/v2/fact_values_controller_extensions.rb
+- app/controllers/concerns/foreman/controller/discovered_extensions.rb
+- app/controllers/discovered_hosts_controller.rb
+- app/controllers/discovery_rules_controller.rb
 - app/helpers/discovered_hosts_helper.rb
-- app/overrides/subnet_form_with_discovery_proxy.rb
-- app/models/setting/discovered.rb
-- app/models/hostgroup_extensions.rb
-- app/models/host/discovered.rb
-- app/models/host/managed_extensions.rb
-- app/models/discovery_rule.rb
+- app/helpers/discovery_rules_helper.rb
+- app/lib/facter_utils.rb
+- app/mailers/discovered_mailer.rb
 - app/models/concerns/discovery_subnet.rb
+- app/models/concerns/discovery_taxonomy_extensions.rb
+- app/models/concerns/fact_value_extensions.rb
 - app/models/discovery_attribute_set.rb
-- app/views/dashboard/_discovery_widget_host_list.html.erb
+- app/models/discovery_rule.rb
+- app/models/host/discovered.rb
+- app/models/host/managed_extensions.rb
+- app/models/hostgroup_extensions.rb
+- app/models/setting/discovered.rb
+- app/overrides/subnet_form_with_discovery_proxy.rb
+- app/services/foreman_discovery/fact_parser.rb
+- app/services/foreman_discovery/host_converter.rb
+- app/services/foreman_discovery/node_api/inventory.rb
+- app/services/foreman_discovery/node_api/node_resource.rb
+- app/services/foreman_discovery/node_api/power.rb
+- app/services/foreman_discovery/node_api/power_legacy_direct_service.rb
+- app/services/foreman_discovery/node_api/power_legacy_proxied_service.rb
+- app/services/foreman_discovery/node_api/power_service.rb
+- app/views/api/v2/discovered_hosts/base.json.rabl
+- app/views/api/v2/discovered_hosts/index.json.rabl
+- app/views/api/v2/discovered_hosts/main.json.rabl
+- app/views/api/v2/discovered_hosts/show.json.rabl
+- app/views/api/v2/discovered_hosts/update.json.rabl
+- app/views/api/v2/discovery_rules/base.json.rabl
+- app/views/api/v2/discovery_rules/index.json.rabl
+- app/views/api/v2/discovery_rules/main.json.rabl
+- app/views/api/v2/discovery_rules/show.json.rabl
 - app/views/dashboard/_discovery_widget.html.erb
 - app/views/dashboard/_discovery_widget_host.html.erb
-- app/views/discovery_rules/new.html.erb
-- app/views/discovery_rules/edit.html.erb
-- app/views/discovery_rules/index.html.erb
-- app/views/discovery_rules/_form.html.erb
-- app/views/discovered_mailer/_discovered_host.html.erb
-- app/views/discovered_mailer/discovered_summary.text.erb
-- app/views/discovered_mailer/discovered_summary.html.erb
+- app/views/dashboard/_discovery_widget_host_list.html.erb
 - app/views/discovered_hosts/_discovered_host.html.erb
+- app/views/discovered_hosts/_discovered_hosts_list.html.erb
 - app/views/discovered_hosts/_selected_hosts.html.erb
-- app/views/discovered_hosts/multiple_destroy.html.erb
 - app/views/discovered_hosts/index.html.erb
+- app/views/discovered_hosts/multiple_destroy.html.erb
+- app/views/discovered_hosts/select_multiple_location.html.erb
 - app/views/discovered_hosts/select_multiple_organization.html.erb
-- app/views/discovered_hosts/_discovered_hosts_list.html.erb
 - app/views/discovered_hosts/show.html.erb
-- app/views/discovered_hosts/select_multiple_location.html.erb
-- app/views/api/v2/discovery_rules/index.json.rabl
-- app/views/api/v2/discovery_rules/base.json.rabl
-- app/views/api/v2/discovery_rules/main.json.rabl
-- app/views/api/v2/discovery_rules/show.json.rabl
-- app/views/api/v2/discovered_hosts/index.json.rabl
-- app/views/api/v2/discovered_hosts/update.json.rabl
-- app/views/api/v2/discovered_hosts/base.json.rabl
-- app/views/api/v2/discovered_hosts/main.json.rabl
-- app/views/api/v2/discovered_hosts/show.json.rabl
+- app/views/discovered_mailer/_discovered_host.html.erb
+- app/views/discovered_mailer/discovered_summary.html.erb
+- app/views/discovered_mailer/discovered_summary.text.erb
+- app/views/discovery_rules/_form.html.erb
+- app/views/discovery_rules/_template_inline.erb
+- app/views/discovery_rules/edit.html.erb
+- app/views/discovery_rules/index.html.erb
+- app/views/discovery_rules/new.html.erb
+- app/views/foreman_discovery/debian_kexec.erb
 - app/views/foreman_discovery/redhat_kexec.erb
-- extra/build_iso.sh
-- extra/wait_for_network.sh
-- extra/disk_facts.rb
-- extra/generate-authors-file
-- extra/discover_host
-- extra/foreman_startup.rb
-- extra/discovery_init.sh.example
-- extra/ovirt-node-build/build_image.sh
-- extra/ovirt-node-build/Vagrantfile
-- config/routes.rb
 - config/initializers/discovery_setup.rb
-- db/migrate/20150310153859_remove_discovery_attribute_sets_from_managed_hosts.rb
+- config/routes.rb
 - db/migrate/20141107091416_create_discovery_rules.rb
-- db/migrate/20150505111345_remove_leftover_tokens.rb
 - db/migrate/20141107091417_add_discovery_rule_to_host.rb
-- db/migrate/20150302112545_remove_duplicate_tokens_from_hosts.rb
-- db/migrate/20151023144501_regenerate_red_hat_kexec.rb
-- db/migrate/20150331132115_remove_old_permissions.rb
 - db/migrate/20141126165451_add_discovery_id_to_subnet.rb
 - db/migrate/20141223101707_create_discovery_attribute_sets.rb
 - db/migrate/20141223142759_fill_discovery_attribute_sets_for_existing_hosts.rb
+- db/migrate/20150302112545_remove_duplicate_tokens_from_hosts.rb
+- db/migrate/20150310153859_remove_discovery_attribute_sets_from_managed_hosts.rb
+- db/migrate/20150331132115_remove_old_permissions.rb
+- db/migrate/20150505111345_remove_leftover_tokens.rb
 - db/migrate/20150512150432_remove_old_discovery_reader_permissions.rb
 - db/migrate/20150714144500_review_discovery_permissions.rb
-- db/seeds.d/70_discovery_mail_notification.rb
+- db/migrate/20151023144501_regenerate_red_hat_kexec.rb
+- db/migrate/20160719124942_add_missing_view_permissions.rb
 - db/seeds.d/50_discovery_templates.rb
 - db/seeds.d/60_discovery_proxy_feature.rb
+- db/seeds.d/70_discovery_mail_notification.rb
+- extra/build_iso.sh
+- extra/discover_host
+- extra/discovery_init.sh.example
+- extra/disk_facts.rb
+- extra/foreman_startup.rb
+- extra/generate-authors-file
+- extra/ovirt-node-build/Vagrantfile
+- extra/ovirt-node-build/build_image.sh
+- extra/wait_for_network.sh
 - lib/discovery.rake
 - lib/foreman_discovery.rb
-- lib/foreman_discovery/version.rb
 - lib/foreman_discovery/engine.rb
-- locale/ru/foreman_discovery.po
-- locale/ru/foreman_discovery.edit.po
-- locale/de/foreman_discovery.po
-- locale/de/foreman_discovery.edit.po
-- locale/pt_BR/foreman_discovery.po
-- locale/pt_BR/foreman_discovery.edit.po
-- locale/en_GB/foreman_discovery.po
-- locale/en_GB/foreman_discovery.edit.po
-- locale/zh_TW/foreman_discovery.po
-- locale/zh_TW/foreman_discovery.edit.po
-- locale/es/foreman_discovery.po
-- locale/es/foreman_discovery.edit.po
-- locale/fr/foreman_discovery.po
-- locale/fr/foreman_discovery.edit.po
-- locale/it/foreman_discovery.po
-- locale/it/foreman_discovery.edit.po
-- locale/ca/foreman_discovery.po
+- lib/foreman_discovery/version.rb
+- locale/ca/LC_MESSAGES/foreman_discovery.mo
 - locale/ca/foreman_discovery.edit.po
-- locale/ja/foreman_discovery.po
-- locale/ja/foreman_discovery.edit.po
-- locale/ko/foreman_discovery.po
-- locale/ko/foreman_discovery.edit.po
-- locale/zh_CN/foreman_discovery.po
-- locale/zh_CN/foreman_discovery.edit.po
-- locale/gl/foreman_discovery.po
-- locale/gl/foreman_discovery.edit.po
-- locale/sv_SE/foreman_discovery.po
-- locale/sv_SE/foreman_discovery.edit.po
-- locale/foreman_discovery.pot
-- locale/ru/LC_MESSAGES/foreman_discovery.mo
+- locale/ca/foreman_discovery.po
 - locale/de/LC_MESSAGES/foreman_discovery.mo
-- locale/pt_BR/LC_MESSAGES/foreman_discovery.mo
+- locale/de/foreman_discovery.edit.po
+- locale/de/foreman_discovery.po
+- locale/en/LC_MESSAGES/foreman_discovery.mo
+- locale/en/foreman_discovery.edit.po
+- locale/en/foreman_discovery.po
 - locale/en_GB/LC_MESSAGES/foreman_discovery.mo
-- locale/zh_TW/LC_MESSAGES/foreman_discovery.mo
+- locale/en_GB/foreman_discovery.edit.po
+- locale/en_GB/foreman_discovery.po
 - locale/es/LC_MESSAGES/foreman_discovery.mo
+- locale/es/foreman_discovery.edit.po
+- locale/es/foreman_discovery.po
+- locale/foreman_discovery.pot
 - locale/fr/LC_MESSAGES/foreman_discovery.mo
+- locale/fr/foreman_discovery.edit.po
+- locale/fr/foreman_discovery.po
+- locale/gl/LC_MESSAGES/foreman_discovery.mo
+- locale/gl/foreman_discovery.edit.po
+- locale/gl/foreman_discovery.po
 - locale/it/LC_MESSAGES/foreman_discovery.mo
-- locale/messages.mo
-- locale/ca/LC_MESSAGES/foreman_discovery.mo
+- locale/it/foreman_discovery.edit.po
+- locale/it/foreman_discovery.po
 - locale/ja/LC_MESSAGES/foreman_discovery.mo
+- locale/ja/foreman_discovery.edit.po
+- locale/ja/foreman_discovery.po
 - locale/ko/LC_MESSAGES/foreman_discovery.mo
-- locale/zh_CN/LC_MESSAGES/foreman_discovery.mo
-- locale/gl/LC_MESSAGES/foreman_discovery.mo
+- locale/ko/foreman_discovery.edit.po
+- locale/ko/foreman_discovery.po
+- locale/messages.mo
+- locale/pt_BR/LC_MESSAGES/foreman_discovery.mo
+- locale/pt_BR/foreman_discovery.edit.po
+- locale/pt_BR/foreman_discovery.po
+- locale/ru/LC_MESSAGES/foreman_discovery.mo
+- locale/ru/foreman_discovery.edit.po
+- locale/ru/foreman_discovery.po
 - locale/sv_SE/LC_MESSAGES/foreman_discovery.mo
-- LICENSE
-- README.md
-- test/functional/discovery_rules_controller_test.rb
-- test/functional/api/v2/discovery_rules_controller_test.rb
+- locale/sv_SE/foreman_discovery.edit.po
+- locale/sv_SE/foreman_discovery.po
+- locale/zh_CN/LC_MESSAGES/foreman_discovery.mo
+- locale/zh_CN/foreman_discovery.edit.po
+- locale/zh_CN/foreman_discovery.po
+- locale/zh_TW/LC_MESSAGES/foreman_discovery.mo
+- locale/zh_TW/foreman_discovery.edit.po
+- locale/zh_TW/foreman_discovery.po
+- test/factories/discovery_rule_related.rb
 - test/functional/api/v2/discovered_hosts_controller_test.rb
+- test/functional/api/v2/discovery_rules_controller_test.rb
+- test/functional/api/v2/fact_value_extensions_test.rb
 - test/functional/discovered_hosts_controller_test.rb
-- test/factories/discovery_rule_related.rb
+- test/functional/discovery_rules_controller_test.rb
+- test/test_helper.rb
+- test/test_helper_discovery.rb
+- test/test_plugin_helper.rb
 - test/unit/discovered_extensions_test.rb
-- test/unit/fact_parser_test.rb
-- test/unit/discovery_attribute_set_test.rb
-- test/unit/setting_discovered_test.rb
-- test/unit/facts.json
 - test/unit/discovered_mailer_test.rb
+- test/unit/discovery_attribute_set_test.rb
 - test/unit/discovery_rule_test.rb
+- test/unit/discovery_taxonomy_extensions_test.rb
+- test/unit/fact_parser_test.rb
+- test/unit/facts.json
 - test/unit/host_discovered_test.rb
-- test/test_helper_discovery.rb
-- test/test_plugin_helper.rb
-- test/test_helper.rb
+- test/unit/setting_discovered_test.rb
 homepage: http://github.com/theforeman/foreman_discovery
 licenses:
 - GPL-3
@@ -222,13 +232,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: MaaS Discovery Plugin for Foreman
 test_files:
 - test/functional/discovery_rules_controller_test.rb
 - test/functional/api/v2/discovery_rules_controller_test.rb
+- test/functional/api/v2/fact_value_extensions_test.rb
 - test/functional/api/v2/discovered_hosts_controller_test.rb
 - test/functional/discovered_hosts_controller_test.rb
 - test/factories/discovery_rule_related.rb
@@ -238,9 +249,9 @@ test_files:
 - test/unit/setting_discovered_test.rb
 - test/unit/facts.json
 - test/unit/discovered_mailer_test.rb
+- test/unit/discovery_taxonomy_extensions_test.rb
 - test/unit/discovery_rule_test.rb
 - test/unit/host_discovered_test.rb
 - test/test_helper_discovery.rb
 - test/test_plugin_helper.rb
 - test/test_helper.rb
-has_rdoc: