foodcritic 10.2.2 → 10.3.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 10.2.2
+  version: 10.3.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-31 00:00:00.000000000 Z
+date: 2017-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -114,6 +114,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
+- !ruby/object:Gem::Dependency
+  name: fuubar
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-command
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 description: Lint tool for Chef cookbooks.
 email: 
 executables:
@@ -141,21 +183,16 @@ files:
 - chef_dsl_metadata/chef_12.7.2.json
 - chef_dsl_metadata/chef_12.8.1.json
 - chef_dsl_metadata/chef_12.9.38.json
-- features/001_check_node_access.feature
 - features/002_check_string_interpolation.feature
 - features/004_check_service_resource_used.feature
 - features/005_check_for_resource_repetition.feature
 - features/006_check_file_mode.feature
 - features/007_check_for_undeclared_recipe_dependencies.feature
-- features/008_check_for_boilerplate_metadata.feature
 - features/009_check_for_unrecognised_resource_attributes.feature
 - features/010_check_search_syntax.feature
-- features/011_check_for_markdown_readme.feature
-- features/012_check_for_deprecated_readme_format.feature
 - features/013_check_for_hardcoded_tmpdir.feature
 - features/014_check_for_long_ruby_blocks.feature
 - features/015_check_for_definitions.feature
-- features/016_check_for_no_lwrp_default_action.feature
 - features/017_check_for_no_lwrp_notifications.feature
 - features/018_check_for_old_lwrp_notification_syntax.feature
 - features/019_check_for_consistent_node_access.feature
@@ -165,10 +202,7 @@ files:
 - features/025_check_for_deprecated_gem_install.feature
 - features/026_check_for_conditional_block_string.feature
 - features/027_check_for_internal_attribute_use.feature
-- features/028_check_for_incorrect_platform_method.feature
-- features/029_check_for_no_leading_cookbook_name.feature
 - features/030_check_for_debugger_breakpoints.feature
-- features/031_check_for_metadata_existence.feature
 - features/032_check_for_invalid_notification_timing.feature
 - features/033_check_for_missing_template.feature
 - features/034_check_for_unused_template_variables.feature
@@ -177,32 +211,18 @@ files:
 - features/039_check_for_key_access_to_node_methods.feature
 - features/040_check_raw_git_usage.feature
 - features/041_check_raw_download.feature
-- features/042_check_for_deprecated_require_recipe.feature
 - features/043_check_for_old_notification_style.feature
 - features/044_check_for_bare_attribute_keys.feature
-- features/045_check_for_cookbook_name_in_metadata.feature
 - features/046_check_for_assign_unless_nil_attributes.feature
 - features/047_check_for_attribute_assignment_without_precedence.feature
 - features/048_check_for_shellout.feature
 - features/049_check_for_role_name_mismatch_with_file_name.feature
 - features/050_check_for_invalid_name.feature
 - features/051_check_for_template_partial_loops.feature
-- features/052_check_for_metadata_using_suggests_keyword.feature
-- features/053_check_for_metadata_using_recommends_keyword.feature
-- features/055_check_for_no_maintainer.feature
-- features/056_check_for_no_maintainer_email.feature
 - features/057_check_for_library_provider_without_use_inline_resources.feature
 - features/058_check_for_library_provider_bad_action_methods.feature
 - features/059_check_for_lwrp_provider_without_use_inline_resources.feature
 - features/060_check_for_lwrp_provider_bad_action_methods.feature
-- features/061_valid_cookbook_version_should_be_defined.feature
-- features/062_cookbook_should_have_cookbook_version.feature
-- features/063_cookbook_incorrectly_depends_on_itself.feature
-- features/064_check_for_no_issues_url.feature
-- features/065_check_for_no_source_url.feature
-- features/066_check_for_no_chef_version_metadata.feature
-- features/067_check_for_no_supports_metadata.feature
-- features/068_check_for_no_license_metadata.feature
 - features/build_framework_support.feature
 - features/checking_all_types_of_file.feature
 - features/choose_rules_to_apply.feature
@@ -296,15 +316,19 @@ files:
 - lib/foodcritic/rules/fc066.rb
 - lib/foodcritic/rules/fc067.rb
 - lib/foodcritic/rules/fc068.rb
+- lib/foodcritic/rules/fc069.rb
+- lib/foodcritic/rules/fc070.rb
+- lib/foodcritic/rules/fc071.rb
+- lib/foodcritic/rules/fc072.rb
+- lib/foodcritic/rules/fc073.rb
+- lib/foodcritic/rules/fc074.rb
+- lib/foodcritic/rules/fc075.rb
 - lib/foodcritic/template.rb
 - lib/foodcritic/version.rb
 - lib/foodcritic/xml.rb
 - man/foodcritic.1
 - man/foodcritic.1.ronn
 - misc/lucene.treetop
-- spec/foodcritic/api_spec.rb
-- spec/foodcritic/chef_spec.rb
-- spec/foodcritic/command_line_spec.rb
 - spec/foodcritic/coverage/assets/0.10.0/application.css
 - spec/foodcritic/coverage/assets/0.10.0/application.js
 - spec/foodcritic/coverage/assets/0.10.0/colorbox/border.png
@@ -330,14 +354,118 @@ files:
 - spec/foodcritic/coverage/assets/0.10.0/smoothness/images/ui-icons_888888_256x240.png
 - spec/foodcritic/coverage/assets/0.10.0/smoothness/images/ui-icons_cd0a0a_256x240.png
 - spec/foodcritic/coverage/index.html
-- spec/foodcritic/domain_spec.rb
-- spec/foodcritic/linter_spec.rb
-- spec/foodcritic/template_spec.rb
+- spec/functional/fc001_spec.rb
+- spec/functional/fc008_spec.rb
+- spec/functional/fc011_spec.rb
+- spec/functional/fc012_spec.rb
+- spec/functional/fc016_spec.rb
+- spec/functional/fc028_spec.rb
+- spec/functional/fc029_spec.rb
+- spec/functional/fc031_spec.rb
+- spec/functional/fc042_spec.rb
+- spec/functional/fc045_spec.rb
+- spec/functional/fc052_spec.rb
+- spec/functional/fc053_spec.rb
+- spec/functional/fc055_spec.rb
+- spec/functional/fc056_spec.rb
+- spec/functional/fc061_spec.rb
+- spec/functional/fc062_spec.rb
+- spec/functional/fc063_spec.rb
+- spec/functional/fc064_spec.rb
+- spec/functional/fc065_spec.rb
+- spec/functional/fc066_spec.rb
+- spec/functional/fc067_spec.rb
+- spec/functional/fc068_spec.rb
+- spec/functional/fc069_spec.rb
+- spec/functional/fc070_spec.rb
+- spec/functional/fc071_spec.rb
+- spec/functional/fc072_spec.rb
+- spec/functional/fc073_spec.rb
+- spec/functional/fc074_spec.rb
+- spec/functional/fc075_spec.rb
+- spec/functional/root_aliases_spec.rb
 - spec/regression/cookbooks.txt
-- spec/regression/expected-output.txt
+- spec/regression/expected/activemq.txt
+- spec/regression/expected/apparmor.txt
+- spec/regression/expected/apt.txt
+- spec/regression/expected/aws.txt
+- spec/regression/expected/bluepill.txt
+- spec/regression/expected/boost.txt
+- spec/regression/expected/build-essential.txt
+- spec/regression/expected/chef-client.txt
+- spec/regression/expected/chef-server.txt
+- spec/regression/expected/chef.txt
+- spec/regression/expected/chef_handler.txt
+- spec/regression/expected/cron.txt
+- spec/regression/expected/database.txt
+- spec/regression/expected/dmg.txt
+- spec/regression/expected/drbd.txt
+- spec/regression/expected/dynect.txt
+- spec/regression/expected/erlang.txt
+- spec/regression/expected/fail2ban.txt
+- spec/regression/expected/firewall.txt
+- spec/regression/expected/gecode.txt
+- spec/regression/expected/gems.txt
+- spec/regression/expected/gunicorn.txt
+- spec/regression/expected/heartbeat.txt
+- spec/regression/expected/homebrew.txt
+- spec/regression/expected/iis.txt
+- spec/regression/expected/iptables.txt
+- spec/regression/expected/jetty.txt
+- spec/regression/expected/jpackage.txt
+- spec/regression/expected/keepalived.txt
+- spec/regression/expected/kickstart.txt
+- spec/regression/expected/logwatch.txt
+- spec/regression/expected/lvm.txt
+- spec/regression/expected/maradns.txt
+- spec/regression/expected/maven.txt
+- spec/regression/expected/memcached.txt
+- spec/regression/expected/motd-tail.txt
+- spec/regression/expected/mysql.txt
+- spec/regression/expected/ohai.txt
+- spec/regression/expected/openldap.txt
+- spec/regression/expected/openssh.txt
+- spec/regression/expected/openssl.txt
+- spec/regression/expected/partial_search.txt
+- spec/regression/expected/passenger_apache2.txt
+- spec/regression/expected/perl.txt
+- spec/regression/expected/php.txt
+- spec/regression/expected/postfix.txt
+- spec/regression/expected/powershell.txt
+- spec/regression/expected/resolver.txt
+- spec/regression/expected/rsync.txt
+- spec/regression/expected/rsyslog.txt
+- spec/regression/expected/sql_server.txt
+- spec/regression/expected/sqlite.txt
+- spec/regression/expected/ssh_known_hosts.txt
+- spec/regression/expected/stompserver.txt
+- spec/regression/expected/subversion.txt
+- spec/regression/expected/sudo.txt
+- spec/regression/expected/tftp.txt
+- spec/regression/expected/tomcat.txt
+- spec/regression/expected/transmission.txt
+- spec/regression/expected/ubuntu.txt
+- spec/regression/expected/ufw.txt
+- spec/regression/expected/unicorn.txt
+- spec/regression/expected/users.txt
+- spec/regression/expected/vim.txt
+- spec/regression/expected/webpi.txt
+- spec/regression/expected/whitelist-node-attrs.txt
+- spec/regression/expected/windows.txt
+- spec/regression/expected/wix.txt
+- spec/regression/expected/xfs.txt
+- spec/regression/expected/xml.txt
+- spec/regression/expected/yum.txt
+- spec/regression/expected/zlib.txt
+- spec/regression/expected/zsh.txt
 - spec/regression/regression_spec.rb
-- spec/regression_helpers.rb
 - spec/spec_helper.rb
+- spec/unit/api_spec.rb
+- spec/unit/chef_spec.rb
+- spec/unit/command_line_spec.rb
+- spec/unit/domain_spec.rb
+- spec/unit/linter_spec.rb
+- spec/unit/template_spec.rb
 homepage: http://foodcritic.io
 licenses:
 - MIT
@@ -361,5 +489,5 @@ rubyforge_project:
 rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: foodcritic-10.2.2
+summary: foodcritic-10.3.0
 test_files: []

data/features/001_check_node_access.feature

@@ -1,60 +0,0 @@
-Feature: Check Node Access
-
-  In order to be consistent in the way I access node attributes and to avoid confusing people new to Ruby
-  As a developer
-  I want to identify if the cookbooks access node attributes with symbols rather than strings
-
-  Scenario: Cookbook recipe accesses attributes via symbols
-    Given a cookbook with a single recipe that reads node attributes via symbols
-    When I check the cookbook
-    Then the node access warning 001 should be displayed
-
-  Scenario: Cookbook recipe accesses multiple attributes via symbols
-    Given a cookbook with a single recipe that accesses multiple node attributes via symbols
-    When I check the cookbook
-    Then the node access warning 001 should be displayed for each match
-
-  Scenario: Assignment of node attributes accessed via symbols
-    Given a cookbook with a single recipe that assigns node attributes accessed via symbols to a local variable
-    When I check the cookbook
-    Then the node access warning 001 should be displayed
-
-  Scenario: Cookbook recipe accesses nested attributes via symbols
-    Given a cookbook with a single recipe that accesses nested node attributes via symbols
-    When I check the cookbook
-    Then the node access warning 001 should be displayed twice for the same line
-
-  Scenario: Cookbook recipe accesses attributes via strings
-    Given a cookbook with a single recipe that reads node attributes via strings
-    When I check the cookbook
-    Then the node access warning 001 should not be displayed
-
-  Scenario: Cookbook recipe access attributes via strings and searches
-    Given a cookbook with a single recipe that searches based on a node attribute accessed via strings
-    When I check the cookbook
-    Then the node access warning 001 should not be displayed
-
-  Scenario: Cookbook recipe access attributes via symbols for template
-    Given a cookbook with a single recipe that passes node attributes accessed via symbols to a template
-    When I check the cookbook
-    Then the node access warning 001 should be displayed against the variables
-
-  Scenario: Cookbook recipe sets default attributes via symbols
-    Given a cookbook that declares default attributes via symbols
-    When I check the cookbook
-    Then the node access warning 001 should be displayed against the attributes file
-
-  Scenario: Cookbook recipe overrides attributes via symbols
-    Given a cookbook that declares override attributes via symbols
-    When I check the cookbook
-    Then the node access warning 001 should be displayed against the attributes file
-
-  Scenario: Cookbook recipe sets attributes via symbols
-    Given a cookbook that declares set attributes via symbols
-    When I check the cookbook
-    Then the node access warning 001 should be displayed against the attributes file
-
-  Scenario: Cookbook recipe sets normal attributes via symbols
-    Given a cookbook that declares normal attributes via symbols
-    When I check the cookbook
-    Then the node access warning 001 should be displayed against the attributes file

data/features/008_check_for_boilerplate_metadata.feature

@@ -1,25 +0,0 @@
-Feature: Check for boilerplate metadata
-
-  In order to ensure that recipe metadata is accurate
-  As a developer
-  I want to identify metadata that has not been changed from the generated defaults
-
-  Scenario: Unmodified knife generated metadata
-    Given a cookbook that has the default boilerplate metadata generated by knife
-    When I check the cookbook
-    Then the boilerplate metadata warning 008 should be displayed against the metadata file
-
-  Scenario Outline: Boilerplate maintainer metadata
-    Given a cookbook that has maintainer metadata set to <maintainer> and <maintainer_email>
-    When I check the cookbook
-    Then the boilerplate metadata warning 008 should warn on lines <lines>
-
-    Examples:
-      | maintainer        | maintainer_email | lines         |
-      | unspecified       | unspecified      |               |
-      | YOUR_COMPANY_NAME | unspecified      | 1             |
-      | unspecified       | YOUR_EMAIL       | 1             |
-      | YOUR_COMPANY_NAME | foo@example.com  | 1             |
-      | Example Ltd       | YOUR_EMAIL       | 2             |
-      | YOUR_COMPANY_NAME | YOUR_EMAIL       | 1,2           |
-      | Example Ltd       | foo@example.com  |               |

data/features/011_check_for_markdown_readme.feature

@@ -1,20 +0,0 @@
-Feature: Check for markdown readme
-
-  In order to ensure that my cookbook README renders nicely on Supermarket
-  As a developer
-  I want to identify if my cookbook does not have a markdown formatted README
-
-  Scenario: Cookbook missing markdown formatted README
-    Given a cookbook that does not have a README at all
-    When I check the cookbook
-    Then the missing readme warning 011 should be displayed against the README.md file
-
-  Scenario: Cookbook has markdown formatted README
-    Given a cookbook that has a README in markdown format
-    When I check the cookbook
-    Then the missing readme warning 011 should not be displayed against the README.md file
-
-  Scenario: Cookbook has an alternatively formatted README
-    Given a cookbook that has a README in RDoc format
-    When I check the cookbook
-    Then the missing readme warning 011 should be displayed against the README.md file

data/features/012_check_for_deprecated_readme_format.feature

@@ -1,20 +0,0 @@
-Feature: Check for deprecated README format
-
-  In order to ensure that my cookbook README renders nicely on Supermarket
-  As a developer
-  I want to identify if my cookbook is using an older-style RDoc format that needs converting
-
-  Scenario: Cookbook missing RDoc formatted README
-    Given a cookbook that does not have a README at all
-    When I check the cookbook
-    Then the deprecated format warning 012 should not be displayed against the README.rdoc file
-
-  Scenario: Cookbook has RDoc formatted README
-    Given a cookbook that has a README in RDoc format
-    When I check the cookbook
-    Then the deprecated format warning 012 should be displayed against the README.rdoc file
-
-  Scenario: Cookbook has an alternatively formatted README
-    Given a cookbook that has a README in markdown format
-    When I check the cookbook
-    Then the deprecated format warning 012 should not be displayed against the README.rdoc file

data/features/016_check_for_no_lwrp_default_action.feature

@@ -1,25 +0,0 @@
-Feature: Check for no LWRP default action
-
-  In order to avoid wondering why a LWRP is not taking action
-  As a developer
-  I want to identify when a LWRP does not declare a default action
-
-  Scenario: LWRP with no default action
-    Given a cookbook that contains a LWRP with no default action
-    When I check the cookbook
-    Then the LWRP has no default action warning 016 should be displayed against the resource file
-
-  Scenario: LWRP with a default action
-    Given a cookbook that contains a LWRP with a default action
-    When I check the cookbook
-    Then the LWRP has no default action warning 016 should not be displayed against the resource file
-
-  Scenario: LWRP with a default action (pre-DSL)
-    Given a cookbook that contains a LWRP with a default action defined via a constructor
-    When I check the cookbook
-    Then the LWRP has no default action warning 016 should not be displayed against the resource file
-
-  Scenario: Custom resource with no default action
-    Given a cookbook that contains a custom resource with no default action
-    When I check the cookbook
-    Then the LWRP has no default action warning 016 should not be displayed against the resource file

data/features/028_check_for_incorrect_platform_method.feature

@@ -1,20 +0,0 @@
-Feature: Check for incorrect platform method usage
-
-  In order to avoid running code intended for another platform
-  As a developer
-  I want to identify conditionals that wrongly use node.platform?
-
-  Scenario Outline: Platform conditionals
-    Given a cookbook recipe that wraps a platform-specific resource in a <conditional> conditional
-    When I check the cookbook
-    Then the incorrect platform usage warning 028 should be <show_warning>
-
-  Examples:
-    | conditional                         | show_warning |
-    | platform? 'linux'                   | not shown    |
-    | platform?('linux')                  | not shown    |
-    | platform?('linux', 'mac_os_x')      | not shown    |
-    | node.platform? 'linux'              | shown        |
-    | node.platform?('linux')             | shown        |
-    | node.platform?('linux', 'mac_os_x') | shown        |
-    | node.platform == 'linux'            | not shown    |