foodcritic 10.2.2 → 10.3.0

data/spec/regression/expected-output.txt

@@ -1,355 +0,0 @@
-FC001: Use strings in preference to symbols to access node attributes: ./apparmor/attributes/apparmor.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./apparmor/recipes/default.rb:21
-FC001: Use strings in preference to symbols to access node attributes: ./apparmor/recipes/default.rb:23
-FC001: Use strings in preference to symbols to access node attributes: ./chef-server/libraries/omnitruck_client.rb:76
-FC001: Use strings in preference to symbols to access node attributes: ./chef-server/libraries/omnitruck_client.rb:77
-FC001: Use strings in preference to symbols to access node attributes: ./chef-server/libraries/omnitruck_client.rb:78
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:20
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:21
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:22
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:26
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:27
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:28
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:29
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:31
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:32
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:33
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:34
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:35
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:38
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:39
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:40
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:41
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:42
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:43
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:44
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:45
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:46
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:47
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:49
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:50
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:23
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:25
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:28
-FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:29
-FC001: Use strings in preference to symbols to access node attributes: ./database/libraries/provider_database_postgresql.rb:113
-FC001: Use strings in preference to symbols to access node attributes: ./database/recipes/ebs_backup.rb:31
-FC001: Use strings in preference to symbols to access node attributes: ./database/recipes/ebs_volume.rb:22
-FC001: Use strings in preference to symbols to access node attributes: ./database/recipes/ebs_volume.rb:86
-FC001: Use strings in preference to symbols to access node attributes: ./dmg/attributes/default.rb:19
-FC001: Use strings in preference to symbols to access node attributes: ./dmg/attributes/default.rb:20
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:2
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:3
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:4
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:5
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:6
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:7
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:8
-FC001: Use strings in preference to symbols to access node attributes: ./drbd/templates/default/res.erb:1
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:22
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:25
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:26
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:27
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:28
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:29
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:23
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:25
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:26
-FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:40
-FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/mirror.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/mirror.rb:2
-FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/mirror.rb:3
-FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/server.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/server.rb:2
-FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/server.rb:3
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:23
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:29
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:36
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:41
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:44
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:45
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:46
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:26
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:29
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:30
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:31
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:40
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:44
-FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:50
-FC001: Use strings in preference to symbols to access node attributes: ./gems/templates/default/gem_server.conf.erb:6
-FC001: Use strings in preference to symbols to access node attributes: ./gems/templates/default/gem_server.conf.erb:29
-FC001: Use strings in preference to symbols to access node attributes: ./gems/templates/default/gem_server.conf.erb:35
-FC001: Use strings in preference to symbols to access node attributes: ./iptables/recipes/default.rb:37
-FC001: Use strings in preference to symbols to access node attributes: ./jpackage/attributes/default.rb:20
-FC001: Use strings in preference to symbols to access node attributes: ./jpackage/recipes/default.rb:22
-FC001: Use strings in preference to symbols to access node attributes: ./jpackage/recipes/default.rb:33
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/attributes/default.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/attributes/default.rb:2
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/attributes/default.rb:3
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/recipes/server.rb:38
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/recipes/server.rb:41
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/kickstart.conf.erb:14
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/kickstart.conf.erb:15
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/ks.cfg.erb:6
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/ks.cfg.erb:9
-FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/ks.cfg.erb:10
-FC001: Use strings in preference to symbols to access node attributes: ./maradns/attributes/default.rb:17
-FC001: Use strings in preference to symbols to access node attributes: ./maradns/recipes/default.rb:46
-FC001: Use strings in preference to symbols to access node attributes: ./maradns/recipes/default.rb:47
-FC001: Use strings in preference to symbols to access node attributes: ./maradns/templates/default/mararc.erb:8
-FC001: Use strings in preference to symbols to access node attributes: ./maradns/templates/default/mararc.erb:9
-FC001: Use strings in preference to symbols to access node attributes: ./maradns/templates/default/mararc.erb:31
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:2
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:3
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:4
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:5
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/definitions/memcached_instance.rb:29
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/definitions/memcached_instance.rb:30
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/definitions/memcached_instance.rb:31
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:25
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:39
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:47
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:48
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:49
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:50
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:51
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:62
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:63
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:64
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:65
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:66
-FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:72
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:2
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:3
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:4
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:5
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/default.rb:28
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/default.rb:54
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/default.rb:59
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/mod_rails.rb:28
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/mod_rails.rb:37
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/mod_rails.rb:46
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.conf.erb:1
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.conf.erb:2
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.conf.erb:3
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.load.erb:1
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:17
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:18
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:21
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/web_app.conf.erb:17
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/web_app.conf.erb:18
-FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/web_app.conf.erb:21
-FC001: Use strings in preference to symbols to access node attributes: ./perl/definitions/cpan_module.rb:27
-FC001: Use strings in preference to symbols to access node attributes: ./perl/recipes/default.rb:26
-FC001: Use strings in preference to symbols to access node attributes: ./rsyslog/recipes/client.rb:26
-FC001: Use strings in preference to symbols to access node attributes: ./stompserver/templates/default/sv-stompserver-run.erb:2
-FC001: Use strings in preference to symbols to access node attributes: ./ufw/attributes/default.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./ufw/attributes/default.rb:2
-FC001: Use strings in preference to symbols to access node attributes: ./vim/attributes/default.rb:20
-FC001: Use strings in preference to symbols to access node attributes: ./vim/recipes/default.rb:33
-FC001: Use strings in preference to symbols to access node attributes: ./whitelist-node-attrs/attributes/default.rb:20
-FC001: Use strings in preference to symbols to access node attributes: ./windows/providers/reboot.rb:22
-FC001: Use strings in preference to symbols to access node attributes: ./windows/providers/reboot.rb:23
-FC001: Use strings in preference to symbols to access node attributes: ./windows/providers/reboot.rb:24
-FC002: Avoid string interpolation where not required: ./chef-client/recipes/cron.rb:103
-FC002: Avoid string interpolation where not required: ./dynect/recipes/ec2.rb:70
-FC002: Avoid string interpolation where not required: ./gems/recipes/mirror.rb:23
-FC002: Avoid string interpolation where not required: ./gems/recipes/server.rb:44
-FC002: Avoid string interpolation where not required: ./iis/providers/site.rb:36
-FC002: Avoid string interpolation where not required: ./mysql/attributes/server.rb:205
-FC002: Avoid string interpolation where not required: ./mysql/attributes/server.rb:206
-FC002: Avoid string interpolation where not required: ./mysql/attributes/server.rb:207
-FC002: Avoid string interpolation where not required: ./mysql/attributes/server.rb:208
-FC002: Avoid string interpolation where not required: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:3
-FC002: Avoid string interpolation where not required: ./passenger_apache2/templates/default/web_app.conf.erb:3
-FC002: Avoid string interpolation where not required: ./perl/recipes/default.rb:37
-FC002: Avoid string interpolation where not required: ./perl/recipes/default.rb:43
-FC002: Avoid string interpolation where not required: ./rsyslog/recipes/default.rb:24
-FC002: Avoid string interpolation where not required: ./rsyslog/recipes/default.rb:63
-FC002: Avoid string interpolation where not required: ./windows/libraries/registry_helper.rb:99
-FC002: Avoid string interpolation where not required: ./windows/libraries/registry_helper.rb:173
-FC002: Avoid string interpolation where not required: ./windows/libraries/windows_privileged.rb:42
-FC002: Avoid string interpolation where not required: ./windows/libraries/windows_privileged.rb:56
-FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./boost/recipes/source.rb:1
-FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./build-essential/recipes/default.rb:65
-FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./chef-client/recipes/service.rb:197
-FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./chef-client/recipes/service.rb:209
-FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./chef-client/recipes/service.rb:223
-FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./chef-server/recipes/dev.rb:16
-FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./mysql/recipes/client.rb:42
-FC009: Resource attribute not recognised: ./chef-server/recipes/default.rb:46
-FC014: Consider extracting long ruby_block to library: ./lvm/providers/logical_volume.rb:18
-FC015: Consider converting definition to a Custom Resource: iptables/definitions/iptables_rule.rb:1
-FC015: Consider converting definition to a Custom Resource: memcached/definitions/memcached_instance.rb:1
-FC015: Consider converting definition to a Custom Resource: perl/definitions/cpan_module.rb:1
-FC015: Consider converting definition to a Custom Resource: unicorn/definitions/unicorn_config.rb:1
-FC016: LWRP does not declare a default action: ./dynect/resources/rr.rb:1
-FC016: LWRP does not declare a default action: ./heartbeat/resources/ipaddr.rb:1
-FC016: LWRP does not declare a default action: ./transmission/resources/torrent_file.rb:1
-FC017: LWRP does not notify when updated: ./apt/providers/repository.rb:124
-FC017: LWRP does not notify when updated: ./cron/providers/d.rb:1
-FC017: LWRP does not notify when updated: ./dmg/providers/package.rb:27
-FC017: LWRP does not notify when updated: ./firewall/providers/rule_ufw.rb:23
-FC017: LWRP does not notify when updated: ./firewall/providers/rule_ufw.rb:27
-FC017: LWRP does not notify when updated: ./firewall/providers/rule_ufw.rb:31
-FC017: LWRP does not notify when updated: ./heartbeat/providers/default.rb:20
-FC017: LWRP does not notify when updated: ./homebrew/providers/tap.rb:13
-FC017: LWRP does not notify when updated: ./homebrew/providers/tap.rb:21
-FC017: LWRP does not notify when updated: ./iis/providers/app.rb:26
-FC017: LWRP does not notify when updated: ./iis/providers/app.rb:40
-FC017: LWRP does not notify when updated: ./iis/providers/app.rb:57
-FC017: LWRP does not notify when updated: ./iis/providers/config.rb:27
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:27
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:41
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:68
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:78
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:88
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:98
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:106
-FC017: LWRP does not notify when updated: ./iis/providers/site.rb:26
-FC017: LWRP does not notify when updated: ./iis/providers/site.rb:50
-FC017: LWRP does not notify when updated: ./iis/providers/site.rb:84
-FC017: LWRP does not notify when updated: ./iis/providers/site.rb:94
-FC017: LWRP does not notify when updated: ./iis/providers/site.rb:104
-FC017: LWRP does not notify when updated: ./iis/providers/site.rb:114
-FC017: LWRP does not notify when updated: ./lvm/providers/physical_volume.rb:6
-FC017: LWRP does not notify when updated: ./maven/providers/default.rb:61
-FC017: LWRP does not notify when updated: ./maven/providers/default.rb:65
-FC017: LWRP does not notify when updated: ./php/providers/pear_channel.rb:31
-FC017: LWRP does not notify when updated: ./php/providers/pear_channel.rb:40
-FC017: LWRP does not notify when updated: ./php/providers/pear_channel.rb:69
-FC017: LWRP does not notify when updated: ./powershell/providers/default.rb:19
-FC017: LWRP does not notify when updated: ./rsync/providers/serve.rb:65
-FC017: LWRP does not notify when updated: ./rsync/providers/serve.rb:69
-FC017: LWRP does not notify when updated: ./sudo/providers/default.rb:102
-FC017: LWRP does not notify when updated: ./webpi/providers/product.rb:26
-FC017: LWRP does not notify when updated: ./windows/providers/auto_run.rb:21
-FC017: LWRP does not notify when updated: ./windows/providers/auto_run.rb:27
-FC017: LWRP does not notify when updated: ./windows/providers/batch.rb:24
-FC017: LWRP does not notify when updated: ./windows/providers/package.rb:35
-FC017: LWRP does not notify when updated: ./windows/providers/package.rb:53
-FC017: LWRP does not notify when updated: ./windows/providers/package.rb:64
-FC017: LWRP does not notify when updated: ./windows/providers/pagefile.rb:24
-FC017: LWRP does not notify when updated: ./windows/providers/pagefile.rb:66
-FC017: LWRP does not notify when updated: ./windows/providers/path.rb:21
-FC017: LWRP does not notify when updated: ./windows/providers/path.rb:29
-FC017: LWRP does not notify when updated: ./windows/providers/reboot.rb:21
-FC017: LWRP does not notify when updated: ./windows/providers/reboot.rb:27
-FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:27
-FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:31
-FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:35
-FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:61
-FC017: LWRP does not notify when updated: ./windows/providers/task.rb:24
-FC017: LWRP does not notify when updated: ./windows/providers/task.rb:43
-FC017: LWRP does not notify when updated: ./windows/providers/task.rb:58
-FC017: LWRP does not notify when updated: ./windows/providers/task.rb:75
-FC017: LWRP does not notify when updated: ./windows/providers/zipfile.rb:27
-FC017: LWRP does not notify when updated: ./windows/providers/zipfile.rb:44
-FC017: LWRP does not notify when updated: ./yum/providers/key.rb:25
-FC017: LWRP does not notify when updated: ./yum/providers/repository.rb:28
-FC017: LWRP does not notify when updated: ./yum/providers/repository.rb:45
-FC018: LWRP uses deprecated notification syntax: ./windows/providers/shortcut.rb:54
-FC019: Access node attributes in a consistent manner: chef-server/libraries/omnitruck_client.rb:76
-FC019: Access node attributes in a consistent manner: chef-server/libraries/omnitruck_client.rb:77
-FC019: Access node attributes in a consistent manner: chef-server/libraries/omnitruck_client.rb:78
-FC019: Access node attributes in a consistent manner: chef/attributes/default.rb:38
-FC019: Access node attributes in a consistent manner: chef/attributes/default.rb:39
-FC019: Access node attributes in a consistent manner: chef/attributes/default.rb:50
-FC019: Access node attributes in a consistent manner: chef/attributes/server_proxy.rb:26
-FC019: Access node attributes in a consistent manner: database/libraries/provider_database_postgresql.rb:113
-FC019: Access node attributes in a consistent manner: database/recipes/ebs_backup.rb:31
-FC019: Access node attributes in a consistent manner: database/recipes/ebs_volume.rb:22
-FC019: Access node attributes in a consistent manner: database/recipes/ebs_volume.rb:86
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:1
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:2
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:3
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:4
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:5
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:6
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:7
-FC019: Access node attributes in a consistent manner: drbd/attributes/default.rb:8
-FC019: Access node attributes in a consistent manner: dynect/recipes/a_record.rb:22
-FC019: Access node attributes in a consistent manner: dynect/recipes/a_record.rb:25
-FC019: Access node attributes in a consistent manner: dynect/recipes/a_record.rb:26
-FC019: Access node attributes in a consistent manner: dynect/recipes/a_record.rb:27
-FC019: Access node attributes in a consistent manner: dynect/recipes/a_record.rb:28
-FC019: Access node attributes in a consistent manner: dynect/recipes/a_record.rb:29
-FC019: Access node attributes in a consistent manner: dynect/recipes/ec2.rb:23
-FC019: Access node attributes in a consistent manner: dynect/recipes/ec2.rb:25
-FC019: Access node attributes in a consistent manner: dynect/recipes/ec2.rb:26
-FC019: Access node attributes in a consistent manner: dynect/recipes/ec2.rb:40
-FC019: Access node attributes in a consistent manner: gecode/recipes/package.rb:29
-FC019: Access node attributes in a consistent manner: gecode/recipes/package.rb:30
-FC019: Access node attributes in a consistent manner: gecode/recipes/package.rb:51
-FC019: Access node attributes in a consistent manner: gecode/recipes/package.rb:56
-FC019: Access node attributes in a consistent manner: passenger_apache2/recipes/default.rb:33
-FC019: Access node attributes in a consistent manner: passenger_apache2/recipes/default.rb:41
-FC019: Access node attributes in a consistent manner: perl/definitions/cpan_module.rb:27
-FC019: Access node attributes in a consistent manner: perl/recipes/default.rb:26
-FC019: Access node attributes in a consistent manner: powershell/recipes/default.rb:69
-FC019: Access node attributes in a consistent manner: ufw/attributes/default.rb:1
-FC019: Access node attributes in a consistent manner: ufw/attributes/default.rb:2
-FC024: Consider adding platform equivalents: ./mysql/recipes/server.rb:130
-FC024: Consider adding platform equivalents: ./mysql/recipes/server.rb:132
-FC024: Consider adding platform equivalents: ./transmission/recipes/default.rb:42
-FC025: Prefer chef_gem to compile-time gem install: ./transmission/recipes/default.rb:25
-FC025: Prefer chef_gem to compile-time gem install: ./transmission/recipes/default.rb:31
-FC029: No leading cookbook name in recipe metadata: ./apparmor/metadata.rb:8
-FC034: Unused template variables: ./activemq/templates/default/wrapper.conf.erb:1
-FC042: Prefer include_recipe to require_recipe: ./postfix/recipes/aliases.rb:17
-FC043: Prefer new notification syntax: ./apt/providers/repository.rb:112
-FC043: Prefer new notification syntax: ./apt/recipes/default.rb:48
-FC043: Prefer new notification syntax: ./database/recipes/ebs_volume.rb:104
-FC043: Prefer new notification syntax: ./drbd/recipes/pair.rb:45
-FC043: Prefer new notification syntax: ./drbd/recipes/pair.rb:58
-FC043: Prefer new notification syntax: ./drbd/recipes/pair.rb:65
-FC043: Prefer new notification syntax: ./drbd/recipes/pair.rb:85
-FC043: Prefer new notification syntax: ./dynect/recipes/ec2.rb:69
-FC043: Prefer new notification syntax: ./gems/recipes/server.rb:50
-FC043: Prefer new notification syntax: ./iptables/definitions/iptables_rule.rb:20
-FC043: Prefer new notification syntax: ./iptables/definitions/iptables_rule.rb:23
-FC043: Prefer new notification syntax: ./jetty/recipes/cargo.rb:41
-FC043: Prefer new notification syntax: ./jetty/recipes/cargo.rb:56
-FC043: Prefer new notification syntax: ./jetty/recipes/cargo.rb:65
-FC043: Prefer new notification syntax: ./jetty/recipes/cargo.rb:80
-FC043: Prefer new notification syntax: ./jetty/recipes/default.rb:53
-FC043: Prefer new notification syntax: ./jetty/recipes/default.rb:61
-FC043: Prefer new notification syntax: ./jpackage/recipes/default.rb:33
-FC043: Prefer new notification syntax: ./maradns/recipes/default.rb:37
-FC043: Prefer new notification syntax: ./maradns/recipes/default.rb:46
-FC043: Prefer new notification syntax: ./memcached/recipes/default.rb:41
-FC043: Prefer new notification syntax: ./memcached/recipes/default.rb:56
-FC043: Prefer new notification syntax: ./memcached/recipes/default.rb:74
-FC043: Prefer new notification syntax: ./openldap/recipes/auth.rb:46
-FC043: Prefer new notification syntax: ./openldap/recipes/auth.rb:56
-FC043: Prefer new notification syntax: ./openldap/recipes/server.rb:71
-FC043: Prefer new notification syntax: ./openldap/recipes/server.rb:78
-FC043: Prefer new notification syntax: ./openldap/recipes/server.rb:97
-FC043: Prefer new notification syntax: ./subversion/recipes/server.rb:30
-FC043: Prefer new notification syntax: ./tomcat/recipes/default.rb:50
-FC043: Prefer new notification syntax: ./tomcat/recipes/default.rb:58
-FC043: Prefer new notification syntax: ./tomcat/recipes/default.rb:67
-FC043: Prefer new notification syntax: ./tomcat/recipes/users.rb:22
-FC043: Prefer new notification syntax: ./yum/providers/key.rb:60
-FC043: Prefer new notification syntax: ./yum/providers/repository.rb:94
-FC044: Avoid bare attribute keys: ./resolver/attributes/default.rb:20
-FC045: Metadata does not contain cookbook name: ./maven/metadata.rb:1
-FC047: Attribute assignment does not specify precedence: ./jetty/recipes/cargo.rb:35
-FC047: Attribute assignment does not specify precedence: ./users/providers/manage.rb:55
-FC048: Prefer Mixlib::ShellOut: ./apt/providers/repository.rb:26
-FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/cron.rb:38
-FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/delete_validation.rb:20
-FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/service.rb:52
-FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/task.rb:42
-FC048: Prefer Mixlib::ShellOut: ./dmg/providers/package.rb:44
-FC048: Prefer Mixlib::ShellOut: ./dmg/providers/package.rb:47
-FC048: Prefer Mixlib::ShellOut: ./dmg/providers/package.rb:76
-FC048: Prefer Mixlib::ShellOut: ./windows/providers/task.rb:106
-FC052: Metadata uses the unimplemented "suggests" keyword: ./build-essential/metadata.rb:14
-FC052: Metadata uses the unimplemented "suggests" keyword: ./mysql/metadata.rb:19
-FC052: Metadata uses the unimplemented "suggests" keyword: ./mysql/metadata.rb:20
-FC052: Metadata uses the unimplemented "suggests" keyword: ./nscd/metadata.rb:7
-FC053: Metadata uses the unimplemented "recommends" keyword: ./boost/metadata.rb:12

data/spec/regression_helpers.rb

@@ -1,37 +0,0 @@
-require_relative "spec_helper"
-require "fileutils"
-require "pathname"
-
-def lint_regression_cookbooks
-  working_dir = Pathname.new("tmp/regression")
-  FileUtils.mkdir_p(working_dir)
-
-  pinned_cookbooks("spec/regression/cookbooks.txt").each do |cbk|
-    clone_cookbook(working_dir, cbk)
-  end
-
-  lint_cookbooks(working_dir)
-end
-
-def pinned_cookbooks(path)
-  File.read(path).lines.map do |line|
-    name, ref = line.strip.split(":")
-    { :name => name, :ref => ref }
-  end
-end
-
-def clone_cookbook(clone_path, cbk)
-  target_path = clone_path + cbk[:name]
-  unless Dir.exist?(target_path)
-    `git clone -q git://github.com/chef-cookbooks/#{cbk[:name]}.git #{target_path}`
-    raise "Unable to clone git://github.com/chef-cookbooks/#{cbk[:name]}.git" unless $?.success?
-  end
-  `cd #{target_path} && git checkout -q #{cbk[:ref]}`
-  raise "Unable to checkout revision for #{cbk[:name]}" unless $?.success?
-end
-
-def lint_cookbooks(cookbook_path)
-  result = `cd #{cookbook_path} && foodcritic .`
-  raise "Unable to lint #{cookbook_path}" unless $?.success?
-  result
-end