foodcritic 10.2.2 → 10.3.0

data/features/029_check_for_no_leading_cookbook_name.feature

@@ -1,18 +0,0 @@
-Feature: Check for no leading cookbook name
-
-  In order to ensure cookbook recipes are correctly listed
-  As a developer
-  I want to identify recipes defined in metadata that do not include the leading cookbook name
-
-  Scenario Outline: Recipe declaration in metadata
-    Given a cookbook with metadata that declares a recipe with <declaration>
-    When I check the cookbook
-    Then the no leading cookbook name warning 029 should be <show_warning>
-
-  Examples:
-    | declaration                                     | show_warning |
-    | recipe "example", "Installs Example"            | not shown    |
-    | recipe "example::default", "Installs Example"   | not shown    |
-    | recipe "default", "Installs Example"            | shown        |
-    | recipe my_var, "Installs Example"               | not shown    |
-    | recipe "#{my_var}::default", "Installs Example" | not shown    |

data/features/031_check_for_metadata_existence.feature

@@ -1,15 +0,0 @@
-Feature: Check for metadata existence
-
-  In order to ensure that cookbook has the minimum
-  As a developer
-  I want to verify that the metadata file exist
-
-  Scenario: Cookbook without metadata.rb file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the non existing metadata warning 031 should be displayed against the metadata file
-
-  Scenario: Cookbook with metadata.rb file
-    Given a cookbook that has the default boilerplate metadata generated by knife
-    When I check the cookbook
-    Then the non existing metadata warning 031 should not be displayed against the metadata file

data/features/042_check_for_deprecated_require_recipe.feature

@@ -1,15 +0,0 @@
-Feature: Check for deprecated require recipe
-
-  In order to prevent failure of my cookbooks in future versions of Chef
-  As a developer
-  I want to use include_recipe in preference to require_recipe
-
-  Scenario: Recipe uses require_recipe
-    Given a recipe that uses require_recipe
-    When I check the cookbook
-    Then the require_recipe deprecated warning 042 should be displayed
-
-  Scenario: Recipe does not use require_recipe
-    Given a recipe that uses include_recipe
-    When I check the cookbook
-    Then the require_recipe deprecated warning 042 should not be displayed

data/features/045_check_for_cookbook_name_in_metadata.feature

@@ -1,20 +0,0 @@
-Feature: Check for cookbook name in metadata
-
-  In order to avoid complications where a cookbook repository name differs from the cookbook name
-  As a developer
-  I want to set the cookbook name within the metadata
-
-  Scenario: Name specified in metadata
-    Given a cookbook with metadata that specifies the cookbook name
-     When I check the cookbook
-     Then the consider setting cookbook name warning 045 should not be displayed against the metadata file
-
-  Scenario: Name not specified in metadata
-    Given a cookbook with metadata that does not specify the cookbook name
-     When I check the cookbook
-     Then the consider setting cookbook name warning 045 should be displayed against the metadata file
-
-  Scenario: No cookbook metadata
-    Given a cookbook that does not have defined metadata
-     When I check the cookbook
-     Then the consider setting cookbook name warning 045 should be displayed against the metadata file

data/features/052_check_for_metadata_using_suggests_keyword.feature

@@ -1,15 +0,0 @@
-Feature: Check for metadata using suggests keyword
-
-  In order to ensure that recipe metadata is stable
-  As a developer
-  I want to identify metadata that is using unimplemented features whose definitions may change in the future
-
-  Scenario: Metadata with the suggests keyword
-    Given a cookbook with metadata that includes a suggests keyword
-     When I check the cookbook
-     Then the metadata using suggests warning 052 should be shown against the metadata file
-
-  Scenario: Metadata without the suggests keyword
-    Given a cookbook with metadata that does not include a suggests keyword
-     When I check the cookbook
-     Then the metadata using suggests warning 052 should be not shown against the metadata file

data/features/053_check_for_metadata_using_recommends_keyword.feature

@@ -1,15 +0,0 @@
-Feature: Check for metadata using recommends keyword
-
-  In order to ensure that recipe metadata is stable
-  As a developer
-  I want to identify metadata that is using unimplemented features whose definitions may change in the future
-
-  Scenario: Metadata with the recommends keyword
-    Given a cookbook with metadata that includes a recommends keyword
-     When I check the cookbook
-     Then the metadata using recommends warning 053 should be shown against the metadata file
-
-  Scenario: Metadata without the recommends keyword
-    Given a cookbook with metadata that does not include a recommends keyword
-     When I check the cookbook
-     Then the metadata using recommends warning 053 should be not shown against the metadata file

data/features/055_check_for_no_maintainer.feature

@@ -1,25 +0,0 @@
-Feature: Check for no maintainer
-
-  In order to be able to upload my cookbook
-  As a developer
-  I want to be notified when my cookbook metadata does not specify the maintainer
-
-  Scenario: Metadata without a maintainer
-    Given a cookbook with metadata that does not include a maintainer keyword
-     When I check the cookbook
-     Then the metadata missing maintainer warning 055 should be shown against the metadata file
-
-  Scenario: Metadata with a maintainer
-    Given a cookbook with metadata that includes a maintainer keyword
-     When I check the cookbook
-     Then the metadata missing maintainer warning 055 should be not shown against the metadata file
-
-  Scenario: Metadata with a maintainer that is an expression
-    Given a cookbook with metadata that includes a maintainer expression
-     When I check the cookbook
-     Then the metadata missing maintainer warning 055 should be not shown against the metadata file
-
-  Scenario: Cookbook without metadata file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the metadata missing maintainer warning 055 should be not shown against the metadata file

data/features/056_check_for_no_maintainer_email.feature

@@ -1,25 +0,0 @@
-Feature: Check for no maintainer email
-
-  In order to be able to upload my cookbook
-  As a developer
-  I want to be notified when my cookbook metadata does not specify the maintainer email
-
-  Scenario: Metadata without a maintainer email
-    Given a cookbook with metadata that does not include a maintainer email
-     When I check the cookbook
-     Then the metadata missing maintainer email warning 056 should be shown against the metadata file
-
-  Scenario: Metadata with a maintainer email
-    Given a cookbook with metadata that includes a maintainer email
-     When I check the cookbook
-     Then the metadata missing maintainer email warning 056 should be not shown against the metadata file
-
-  Scenario: Metadata with a maintainer email that is an expression
-    Given a cookbook with metadata that includes a maintainer email expression
-     When I check the cookbook
-     Then the metadata missing maintainer email warning 056 should be not shown against the metadata file
-
-  Scenario: Cookbook without metadata file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the metadata missing maintainer email warning 056 should be not shown against the metadata file

data/features/061_valid_cookbook_version_should_be_defined.feature

@@ -1,55 +0,0 @@
-Feature: Defined cookbook version should be valid
-
-  In order to ensure that recipe metadata is stable
-  As a developer
-  I want to identify metadata that does not define a valid version for the cookbook
-
-  Scenario: Metadata with the version keyword and a valid version
-    Given a cookbook with metadata that includes the version keyword and a valid version string
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should not be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and a valid version with double quotes
-    Given a cookbook with metadata that includes the version keyword and a valid version string with double quotes
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should not be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and a valid x.y version
-    Given a cookbook with metadata that includes the version keyword and a valid x.y version string
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should not be displayed against the metadata file
-
-  Scenario: Metadata without the version keyword
-    Given a cookbook with metadata that does not include a version keyword
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should not be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and an invalid version
-    Given a cookbook with metadata that includes the version keyword and an invalid version string
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and an invalid single digit version
-    Given a cookbook with metadata that includes the version keyword and an invalid single digit version string
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and an invalid 4 digit version
-    Given a cookbook with metadata that includes the version keyword and an invalid 4 digit version string
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should be displayed against the metadata file
-
-  Scenario: Metadata version that uses string interpolation
-    Given a cookbook with a metadata version that uses string interpolation
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should not be displayed against the metadata file
-
-  Scenario: Metadata version that is not a string literal
-    Given a cookbook with a metadata version that is not a string literal
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should not be displayed against the metadata file
-
-  Scenario: Metadata version that is a method call
-    Given a cookbook with a metadata version that is a method call
-     When I check the cookbook
-     Then the metadata defines valid version warning 061 should not be displayed against the metadata file

data/features/062_cookbook_should_have_cookbook_version.feature

@@ -1,50 +0,0 @@
-Feature: Cookbook version should be defined
-
-  In order to ensure that recipe metadata is stable
-  As a developer
-  I want to identify metadata that does not define any version for a cookbook
-
-  Scenario: Metadata with the version keyword and a valid version
-    Given a cookbook with metadata that includes the version keyword and a valid version string
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and a valid version with double quotes
-    Given a cookbook with metadata that includes the version keyword and a valid version string with double quotes
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and a valid x.y version
-    Given a cookbook with metadata that includes the version keyword and a valid x.y version string
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file
-
-  Scenario: Metadata without the version keyword
-    Given a cookbook with metadata that does not include a version keyword
-     When I check the cookbook
-     Then the metadata without version warning 062 should be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and an invalid version
-    Given a cookbook with metadata that includes the version keyword and an invalid version string
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and an invalid single digit version
-    Given a cookbook with metadata that includes the version keyword and an invalid single digit version string
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file
-
-  Scenario: Metadata with the version keyword and an invalid 4 digit version
-    Given a cookbook with metadata that includes the version keyword and an invalid 4 digit version string
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file
-
-  Scenario: Metadata version that uses string interpolation' do
-    Given a cookbook with a metadata version that uses string interpolation
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file
-
-  Scenario: Metadata version that is not a string literal' do
-    Given a cookbook with a metadata version that is not a string literal
-     When I check the cookbook
-     Then the metadata without version warning 062 should not be displayed against the metadata file

data/features/063_cookbook_incorrectly_depends_on_itself.feature

@@ -1,15 +0,0 @@
-Feature: Check for metadata using suggests keyword
-
-  In order to avoid pathological depsolving issues
-  As a developer
-  I want to identify cookbooks that depend on themselves and remove that (unnecessary) dependency
-
-  Scenario: Metadata with self dependency
-    Given a cookbook with metadata that includes a self dependency
-     When I check the cookbook
-     Then the metadata with self dependency warning 063 should be shown against the metadata file
-
-  Scenario: Metadata without self dependency
-    Given a cookbook with metadata that does not include a self dependency
-     When I check the cookbook
-     Then the metadata with self dependency warning 063 should be not shown against the metadata file

data/features/064_check_for_no_issues_url.feature

@@ -1,25 +0,0 @@
-Feature: Check for no issues_url
-
-  In order to be able to share my cookbook on the Supermarket
-  As a developer
-  I want to be notified when my cookbook metadata does not specify the issues_url
-
-  Scenario: Metadata without a issues_url
-    Given a cookbook with metadata that does not include a issues_url keyword
-     When I check the cookbook
-     Then the metadata missing issues_url warning 064 should be shown against the metadata file
-
-  Scenario: Metadata with a issues_url
-    Given a cookbook with metadata that includes a issues_url keyword
-     When I check the cookbook
-     Then the metadata missing issues_url warning 064 should be not shown against the metadata file
-
-  Scenario: Metadata with a issues_url that is an expression
-    Given a cookbook with metadata that includes a issues_url expression
-     When I check the cookbook
-     Then the metadata missing issues_url warning 064 should be not shown against the metadata file
-
-  Scenario: Cookbook without metadata file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the metadata missing issues_url warning 064 should be not shown against the metadata file

data/features/065_check_for_no_source_url.feature

@@ -1,25 +0,0 @@
-Feature: Check for no source_url
-
-  In order to be able to share my cookbook on the Supermarket
-  As a developer
-  I want to be notified when my cookbook metadata does not specify the source_url
-
-  Scenario: Metadata without a source_url
-    Given a cookbook with metadata that does not include a source_url keyword
-     When I check the cookbook
-     Then the metadata missing source_url warning 065 should be shown against the metadata file
-
-  Scenario: Metadata with a source_url
-    Given a cookbook with metadata that includes a source_url keyword
-     When I check the cookbook
-     Then the metadata missing source_url warning 065 should be not shown against the metadata file
-
-  Scenario: Metadata with a source_url that is an expression
-    Given a cookbook with metadata that includes a source_url expression
-     When I check the cookbook
-     Then the metadata missing source_url warning 065 should be not shown against the metadata file
-
-  Scenario: Cookbook without metadata file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the metadata missing source_url warning 065 should be not shown against the metadata file

data/features/066_check_for_no_chef_version_metadata.feature

@@ -1,20 +0,0 @@
-Feature: Check for no chef_version metadata
-
-  In order to clearly specify chef version compatibility to users
-  As a developer
-  I want to be notified when my cookbook metadata does not specify the chef_version
-
-  Scenario: Metadata without a chef_version
-    Given a cookbook with metadata that does not include a chef_version keyword
-     When I check the cookbook
-     Then the metadata missing chef_version warning 066 should be shown against the metadata file
-
-  Scenario: Metadata with a chef_version
-    Given a cookbook with metadata that includes a chef_version keyword
-     When I check the cookbook
-     Then the metadata missing chef_version warning 066 should be not shown against the metadata file
-
-  Scenario: Cookbook without metadata file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the metadata missing chef_version warning 066 should be not shown against the metadata file

data/features/067_check_for_no_supports_metadata.feature

@@ -1,20 +0,0 @@
-Feature: Check for no supports metadata
-
-  In order to clearly specify platform support to users
-  As a developer
-  I want to be notified when my cookbook metadata does not specify the platform supports
-
-  Scenario: Metadata without a supports metadata
-    Given a cookbook with metadata that does not include a supports keyword
-     When I check the cookbook
-     Then the metadata missing supports warning 067 should be shown against the metadata file
-
-  Scenario: Metadata with a supports metadata
-    Given a cookbook with metadata that includes a supports keyword
-     When I check the cookbook
-     Then the metadata missing supports warning 067 should be not shown against the metadata file
-
-  Scenario: Cookbook without metadata file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the metadata missing supports warning 067 should be not shown against the metadata file

data/features/068_check_for_no_license_metadata.feature

@@ -1,20 +0,0 @@
-Feature: Check for no license metadata
-
-  In order to clearly specify cookbook licensing to consumers
-  As a developer
-  I want to be notified when my cookbook metadata does not specify the license
-
-  Scenario: Metadata without a license
-    Given a cookbook with metadata that does not include a license keyword
-     When I check the cookbook
-     Then the metadata missing license warning 068 should be shown against the metadata file
-
-  Scenario: Metadata with a license
-    Given a cookbook with metadata that includes a license keyword
-     When I check the cookbook
-     Then the metadata missing license warning 068 should be not shown against the metadata file
-
-  Scenario: Cookbook without metadata file
-    Given a cookbook that does not have defined metadata
-    When I check the cookbook
-    Then the metadata missing license warning 068 should be not shown against the metadata file

data/spec/foodcritic/command_line_spec.rb

@@ -1,74 +0,0 @@
-require_relative "../spec_helper"
-
-describe FoodCritic::CommandLine do
-  it "is instantiable" do
-    FoodCritic::CommandLine.new([]).wont_be_nil
-  end
-
-  describe "#cookbook_paths" do
-    it "returns an empty array if no paths are specified" do
-      FoodCritic::CommandLine.new([]).cookbook_paths.must_be_empty
-    end
-
-    it "returns a single item array for a specified directory" do
-      FoodCritic::CommandLine.new(["example"]).cookbook_paths.must_equal ["example"]
-    end
-
-    it "returns multiple items for multiple specified directories" do
-      FoodCritic::CommandLine.new(%w{example another_example}).cookbook_paths.must_equal %w{example another_example}
-    end
-
-    it "ignores known arguments" do
-      FoodCritic::CommandLine.new(["example", "--context"]).cookbook_paths.must_equal ["example"]
-    end
-  end
-
-  describe "#role_paths" do
-    it "returns an empty if no role paths are specified" do
-      FoodCritic::CommandLine.new([]).role_paths.must_be_empty
-    end
-    it "returns the provided role path" do
-      FoodCritic::CommandLine.new(["-R", "roles"]).role_paths.must_equal(%w{roles})
-    end
-    it "returns the provided role paths when there are multiple" do
-      FoodCritic::CommandLine.new(["-R", "roles1",
-        "-R", "roles2"]).role_paths.must_equal(%w{roles1 roles2})
-    end
-  end
-
-  describe "#valid_paths?" do
-    it "returns false if no paths are specified" do
-      refute FoodCritic::CommandLine.new([]).valid_paths?
-    end
-
-    it "returns true if the specified directory exists" do
-      assert FoodCritic::CommandLine.new(["lib"]).valid_paths?
-    end
-
-    it "returns false if the specified directory does not exist" do
-      refute FoodCritic::CommandLine.new(["lib2"]).valid_paths?
-    end
-
-    it "returns true if the specified file exists" do
-      assert FoodCritic::CommandLine.new(["lib/foodcritic.rb"]).valid_paths?
-    end
-
-    it "returns true if both specified paths exist" do
-      assert FoodCritic::CommandLine.new(["lib", "lib/foodcritic.rb"]).valid_paths?
-    end
-
-    it "returns false if any on the specified paths do not exist" do
-      refute FoodCritic::CommandLine.new(%w{lib lib2}).valid_paths?
-    end
-  end
-
-  describe "#list_rules?" do
-    it "returns false if ---list is not specified" do
-      refute FoodCritic::CommandLine.new([]).list_rules?
-    end
-
-    it "returns true if --list is specified" do
-      assert FoodCritic::CommandLine.new(["--list"]).list_rules?
-    end
-  end
-end