foodcritic 10.2.2 → 10.3.0

data/spec/regression/expected/wix.txt

@@ -0,0 +1,4 @@
+FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
+FC065: Ensure source_url is set in metadata: ./metadata.rb:1
+FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/xfs.txt

@@ -0,0 +1,4 @@
+FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
+FC065: Ensure source_url is set in metadata: ./metadata.rb:1
+FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/xml.txt

@@ -0,0 +1,4 @@
+FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
+FC065: Ensure source_url is set in metadata: ./metadata.rb:1
+FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/yum.txt

@@ -0,0 +1,17 @@
+FC009: Resource attribute not recognised: ./recipes/epel.rb:27
+FC017: LWRP does not notify when updated: ./providers/key.rb:25
+FC017: LWRP does not notify when updated: ./providers/repository.rb:28
+FC017: LWRP does not notify when updated: ./providers/repository.rb:45
+FC038: Invalid resource action: ./recipes/epel.rb:27
+FC043: Prefer new notification syntax: ./providers/key.rb:60
+FC043: Prefer new notification syntax: ./providers/repository.rb:94
+FC059: LWRP provider does not declare use_inline_resources: ./providers/key.rb:1
+FC059: LWRP provider does not declare use_inline_resources: ./providers/repository.rb:1
+FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
+FC065: Ensure source_url is set in metadata: ./metadata.rb:1
+FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1
+FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
+FC074: LWRP should use DSL to define resource's default action: ./resources/key.rb:1
+FC074: LWRP should use DSL to define resource's default action: ./resources/repository.rb:1

data/spec/regression/expected/zlib.txt

@@ -0,0 +1,4 @@
+FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
+FC065: Ensure source_url is set in metadata: ./metadata.rb:1
+FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/zsh.txt

@@ -0,0 +1,4 @@
+FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
+FC065: Ensure source_url is set in metadata: ./metadata.rb:1
+FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/regression_spec.rb

@@ -1,17 +1,23 @@
-require_relative "../regression_helpers"
+require "spec_helper"
 
 describe "regression test" do
+  command("#{File.expand_path("../../../bin/foodcritic", __FILE__)} .", allow_error: true)
 
-  let(:expected_lint_output) do
-    File.read("spec/regression/expected-output.txt")
-  end
+  IO.readlines(File.expand_path("../cookbooks.txt", __FILE__)).each do |line|
+    name, ref = line.strip.split(":")
 
-  let(:actual_lint_output) do
-    lint_regression_cookbooks
-  end
+    context "with cookbook #{name}" do
+      before do
+        command("git clone -q https://github.com/chef-cookbooks/#{name}.git .")
+        command("git checkout -q #{ref}")
+      end
 
-  it "should result in the expected matches against a pinned set of cookbooks" do
-    actual_lint_output.must_equal expected_lint_output
+      it "should match expected output" do
+        expected_output = IO.readlines(File.expand_path("../expected/#{name}.txt", __FILE__))
+        expected_output.each do |expected_line|
+          expect(subject.stdout).to include expected_line
+        end
+      end
+    end
   end
-
 end

data/spec/spec_helper.rb

@@ -1,15 +1,120 @@
-begin
-  require "simplecov"
-  SimpleCov.start do
-    add_filter "/spec/"
+require "shellwords"
+
+require "rspec_command"
+require "simplecov"
+
+SimpleCov.start do
+  add_filter "/spec/"
+end
+
+module FunctionalHelpers
+  extend RSpec::Matchers::DSL
+
+  matcher :violate_rule do |rule_id = nil|
+    match do |cmd|
+      if location
+        cmd.stdout =~ /^#{expected}:.*: \.\/#{location}/
+      else
+        cmd.stdout =~ /^#{expected}:/
+      end
+    end
+    chain :in, :location
+    failure_message do |cmd|
+      "expected a violation of rule #{expected}#{location && " in #{location}"}, output was:\n#{cmd.stdout}"
+    end
+    failure_message_when_negated do |cmd|
+      "expected no violation of rule #{expected}#{location && " in #{location}"}, output was:\n#{cmd.stdout}"
+    end
+    # Override the default behavior from RSpec for the expected value, use
+    # define_method insetad of def so we can see the _rule_id variable in closure.
+    define_method(:expected) do
+      # Fill in the top-level example group description as the rule ID if not specified.
+      rule_id || method_missing(:class).parent_groups.last.description
+    end
+  end
+
+  def foodcritic_command(*args)
+    output = StringIO.new
+    error = StringIO.new
+    begin
+      # Don't use the block form of chdir because for some reason it can't be
+      # nested.
+      cwd = Dir.pwd
+      Dir.chdir(temp_path)
+      $stderr = error
+      exitstatus = FoodCritic::CommandLine.main(args, output)
+    ensure
+      $stderr = STDERR
+      Dir.chdir(cwd)
+    end
+    RSpecCommand::OutputString.new(output.string, error.string).tap do |out|
+      out.define_singleton_method(:exitstatus) { exitstatus }
+    end
   end
-rescue LoadError
-  warn "warning: simplecov gem not found; skipping coverage"
+
+  module ClassMethods
+    def foodcritic_command(*args)
+      metadata[:foodcritic_command] = true
+      subject do |example|
+        foodcritic_command(*args)
+      end
+    end
+
+    def attributes_file(*args, &block)
+      file("attributes/default.rb", *args, &block)
+    end
+
+    def resource_file(*args, &block)
+      file("resources/my_resource.rb", *args, &block)
+    end
+
+    def library_file(*args, &block)
+      file("libraries/helper.rb", *args, &block)
+    end
+
+    def recipe_file(*args, &block)
+      file("recipes/default.rb", *args, &block)
+    end
+
+    def metadata_file(*args, &block)
+      file("metadata.rb", *args, &block)
+    end
+
+    def included(klass)
+      super
+      klass.extend ClassMethods
+      # Set a default subject command, can be overridden if needed.
+      klass.foodcritic_command("--no-progress", ".")
+    end
+  end
+
+  extend ClassMethods
 end
 
-require "minitest/spec"
-require "minitest/autorun"
-require "minitest/reporters"
-MiniTest::Reporters.use!
+RSpec.configure do |config|
+  # Basic configuraiton
+  config.run_all_when_everything_filtered = true
+  config.filter_run(:focus) unless ENV["CI"]
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = "random"
+
+  # Set some metadata based on test folders.
+  config.define_derived_metadata(file_path: %r{spec/unit}) do |metadata|
+    metadata[:unit] = true
+  end
+  config.define_derived_metadata(file_path: %r{spec/functional}) do |metadata|
+    metadata[:functional] = true
+  end
+  config.define_derived_metadata(file_path: %r{spec/regression}) do |metadata|
+    metadata[:regression] = true
+  end
+
+  config.include RSpecCommand
+  config.include FunctionalHelpers, functional: true
+end
 
 require_relative "../lib/foodcritic"

data/spec/{foodcritic → unit}/api_spec.rb

@@ -1,4 +1,4 @@
-require_relative "../spec_helper"
+require "spec_helper"
 
 describe FoodCritic::Api do
 
@@ -13,7 +13,7 @@ describe FoodCritic::Api do
       api.class.ancestors.map { |a| a.public_methods }.flatten.sort.uniq
     end
     it "exposes the expected api to rule authors" do
-      (api.public_methods.sort - ignorable_methods).must_equal([
+      expect(api.public_methods.sort - ignorable_methods).to eq [
         :attribute_access,
         :checks_for_chef_solo?,
         :chef_dsl_methods,
@@ -24,6 +24,7 @@ describe FoodCritic::Api do
         :cookbook_maintainer_email,
         :cookbook_name,
         :declared_dependencies,
+        :ensure_file_exists,
         :field,
         :field_value,
         :file_match,
@@ -51,295 +52,271 @@ describe FoodCritic::Api do
         :template_paths,
         :templates_included,
         :valid_query?,
-      ])
+      ]
     end
   end
 
   describe "#attribute_access" do
-    let(:ast) { MiniTest::Mock.new }
+    let(:ast) { double() }
     it "returns empty if the provided ast does not support XPath" do
-      api.attribute_access(nil, :type => :vivified).must_be_empty
+      expect(api.attribute_access(nil, :type => :vivified)).to be_empty
     end
     it "returns empty if the provided ast has no matches" do
-      ast.expect :xpath, [], [String]
+      expect(ast).to receive(:xpath).with(kind_of(String), kind_of(FoodCritic::Api::AttFilter)).and_return([]).exactly(3).times
       [:vivified, :string, :symbol].each do |access_type|
-        api.attribute_access([], :type => :vivified).must_be_empty
+        expect(api.attribute_access(ast, :type => access_type)).to be_empty
       end
     end
     it "raises if the specified node type is not recognised" do
-      ast.expect :xpath, [], [String]
-      lambda do
-        api.attribute_access(ast, :type => :cymbals)
-      end.must_raise(ArgumentError)
+      allow(ast).to receive(:xpath)
+      expect { api.attribute_access(ast, :type => :cymbals) }.to raise_error ArgumentError
     end
     it "does not raise if the specified node type is valid" do
-      ast.expect :xpath, [], [/field/, FoodCritic::Api::AttFilter]
-      ast.expect :xpath, [], [/symbol/, FoodCritic::Api::AttFilter]
-      ast.expect :xpath, [], [/tstring_content/, FoodCritic::Api::AttFilter]
+      expect(ast).to receive(:xpath).with(/field/, FoodCritic::Api::AttFilter).and_return([])
+      expect(ast).to receive(:xpath).with(/symbol/, FoodCritic::Api::AttFilter).and_return([])
+      expect(ast).to receive(:xpath).with(/tstring_content/, FoodCritic::Api::AttFilter).and_return([])
       [:vivified, :symbol, :string].each do |access_type|
         api.attribute_access(ast, :type => access_type)
       end
     end
     it "returns vivified attributes access" do
-      call = MiniTest::Mock.new
-      call.expect :xpath, [], [/args_add_block/]
-      call.expect :xpath, %w{node bar}, [/ident/]
-      call.expect :xpath, ["foo"], [/@value/]
-      ast.expect :xpath, [call], [String, FoodCritic::Api::AttFilter]
-      api.attribute_access(ast, :type => :vivified).must_equal([call])
-      ast.verify
-      call.verify
+      call = double()
+      expect(call).to receive(:xpath).with(/args_add_block/).and_return([])
+      expect(call).to receive(:xpath).with(/ident/).and_return(%w{node bar})
+      expect(call).to receive(:xpath).with(/@value/).and_return("foo")
+      expect(ast).to receive(:xpath).with(kind_of(String), kind_of(FoodCritic::Api::AttFilter)).and_return([call])
+      expect(api.attribute_access(ast, :type => :vivified)).to eq [call]
     end
     it "doesn't flag searching for a node by name as symbol access" do
       ast = parse_ast(%q{baz = search(:node, "name:#{node['foo']['bar']}")[0]})
-      api.attribute_access(ast, :type => :symbol).must_be_empty
+      expect(api.attribute_access(ast, :type => :symbol)).to be_empty
     end
     describe :ignoring_attributes do
       it "doesn't ignore run_state by default for backwards compatibility" do
         ast = parse_ast("node.run_state['bar'] = 'baz'")
-        api.attribute_access(ast).wont_be_empty
+        expect(api.attribute_access(ast)).to_not be_empty
       end
       it "allows run_state to be ignored" do
         ast = parse_ast("node.run_state['bar'] = 'baz'")
-        api.attribute_access(ast, :ignore => ["run_state"]).must_be_empty
+        expect(api.attribute_access(ast, :ignore => ["run_state"])).to be_empty
       end
       it "allows run_state to be ignored (symbols access)" do
         ast = parse_ast("node.run_state[:bar] = 'baz'")
-        api.attribute_access(ast, :ignore => ["run_state"]).must_be_empty
+        expect(api.attribute_access(ast, :ignore => ["run_state"])).to be_empty
       end
       it "allows any attribute to be ignored" do
         ast = parse_ast("node['bar'] = 'baz'")
-        api.attribute_access(ast, :ignore => ["bar"]).must_be_empty
+        expect(api.attribute_access(ast, :ignore => ["bar"])).to be_empty
       end
       it "allows any attribute to be ignored (symbols access)" do
         ast = parse_ast("node[:bar] = 'baz'")
-        api.attribute_access(ast, :ignore => ["bar"]).must_be_empty
+        expect(api.attribute_access(ast, :ignore => ["bar"])).to be_empty
       end
       it "allows any attribute to be ignored (dot access)" do
         ast = parse_ast("node.bar = 'baz'")
-        api.attribute_access(ast, :ignore => ["bar"]).must_be_empty
+        expect(api.attribute_access(ast, :ignore => ["bar"])).to be_empty
       end
       it "includes the children of attributes" do
         ast = parse_ast("node['foo']['bar'] = 'baz'")
-        api.attribute_access(ast).map { |a| a["value"] }.must_equal(%w{foo bar})
+        expect(api.attribute_access(ast).map { |a| a["value"] }).to eq %w{foo bar}
       end
       it "does not include children of removed attributes" do
         ast = parse_ast("node['foo']['bar'] = 'baz'")
-        api.attribute_access(ast, :ignore => ["foo"]).must_be_empty
+        expect(api.attribute_access(ast, :ignore => ["foo"])).to be_empty
       end
       it "coerces ignore values to enumerate them" do
         ast = parse_ast("node.run_state['bar'] = 'baz'")
-        api.attribute_access(ast, :ignore => "run_state").must_be_empty
+        expect(api.attribute_access(ast, :ignore => "run_state")).to be_empty
       end
       it "can ignore multiple attributes" do
         ast = parse_ast(%q{
           node['bar'] = 'baz'
           node.foo = 'baz'
         })
-        api.attribute_access(ast, :ignore => %w{foo bar}).must_be_empty
+        expect(api.attribute_access(ast, :ignore => %w{foo bar})).to be_empty
       end
     end
   end
 
   describe "#checks_for_chef_solo?" do
-    let(:ast) { MiniTest::Mock.new }
+    let(:ast) { double() }
+    around do |ex|
+      begin
+        $stderr = StringIO.new
+        ex.run
+      ensure
+        $stderr = STDERR
+      end
+    end
     it "raises if the provided ast does not support XPath" do
-      lambda { api.checks_for_chef_solo?(nil) }.must_raise(ArgumentError)
+      expect { api.checks_for_chef_solo?(nil) }.to raise_error ArgumentError
     end
     it "returns false if there is no reference to chef solo" do
-      ast.expect :xpath, [], [String]
-      ast.expect :xpath, [], [String]
-      refute api.checks_for_chef_solo?(ast)
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([]).twice
+      expect(api.checks_for_chef_solo?(ast)).to be_falsey
     end
     it "returns true if there is one reference to chef solo" do
-      ast.expect :xpath, ["aref"], [String]
-      assert api.checks_for_chef_solo?(ast)
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(["aref"])
+      expect(api.checks_for_chef_solo?(ast)).to be_truthy
     end
     it "returns true if there are multiple references to chef solo" do
-      ast.expect :xpath, %w{aref aref}, [String]
-      assert api.checks_for_chef_solo?(ast)
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(%w{aref aref})
+      expect(api.checks_for_chef_solo?(ast)).to be_truthy
     end
   end
 
   describe "#chef_solo_search_supported?" do
+    around do |ex|
+      begin
+        $stderr = StringIO.new
+        ex.run
+      ensure
+        $stderr = STDERR
+      end
+    end
     it "returns false if the recipe path is nil" do
-      refute api.chef_solo_search_supported?(nil)
+      expect(api.chef_solo_search_supported?(nil)).to be_falsey
     end
     it "returns false if the recipe path does not exist" do
-      refute api.chef_solo_search_supported?("/tmp/non-existent-path")
+      expect(api.chef_solo_search_supported?("/tmp/non-existent-path")).to be_falsey
     end
   end
 
   describe "#metadata_field" do
-    # TODO we should do this with a double instead
-    # but this is the accepted pattern so far so...
-    def mock_cookbook(metadata_path)
-      dir = File.dirname(metadata_path)
-      unless File.directory?(dir)
-        FileUtils.mkdir_p(dir)
-      end
-      File.open(metadata_path, "w") { |file| file.write('name "YOUR_COOKBOOK_NAME"') }
-      FileUtils.mkdir_p(File.join(dir, "templates/defaults"))
-      File.open(File.join(dir, "templates", "defaults", "test.erb"), "w") { |file| file.write("Some erb") }
-    end
+    file "metadata.rb", 'name "YOUR_COOKBOOK_NAME"'
 
     it "returns the 'name' value when passed a metadata file and the name field" do
-      mock_cookbook("/tmp/fc/mock/cb/metadata.rb")
-      api.metadata_field("/tmp/fc/mock/cb/", "name").must_equal "YOUR_COOKBOOK_NAME"
+      expect(api.metadata_field(temp_path, "name")).to eq "YOUR_COOKBOOK_NAME"
     end
 
     it "it raises if a invalid field is requested" do
-      lambda { api.metadata_field("/tmp/fc/mock/cb/", "bogus_field") }.must_raise RuntimeError
+      expect { api.metadata_field(temp_path, "bogus_field") }.to raise_error RuntimeError
     end
 
     it "it raises if a invalid file is requested" do
-      lambda { api.metadata_field("/tmp/some/bogus/cookbook/path", "name") }.must_raise RuntimeError
+      expect { api.metadata_field("/invalid", "name") }.to raise_error RuntimeError
     end
   end
 
   describe "#cookbook_base_path" do
-    # TODO we should do this with a mock instead
-    # but this is the accepted pattern so far so...
-    def mock_cookbook(metadata_path)
-      dir = File.dirname(metadata_path)
-      unless File.directory?(dir)
-        FileUtils.mkdir_p(dir)
+    file "templates/defaults/test.erb"
+
+    context "with a metadata.rb" do
+      file "metadata.rb"
+
+      it "returns the cookbook dir when passed the path itself" do
+        expect(api.cookbook_base_path(temp_path)).to eq temp_path
       end
-      File.open(metadata_path, "w") { |file| file.write('name "YOUR_COOKBOOK_NAME"') }
-      FileUtils.mkdir_p(File.join(dir, "templates/defaults"))
-      File.open(File.join(dir, "templates", "defaults", "test.erb"), "w") { |file| file.write("Some erb") }
-    end
 
-    it "returns the cookbook dir when passed the path itself" do
-      mock_cookbook("/tmp/fc/mock/cb/metadata.rb")
-      api.cookbook_base_path("/tmp/fc/mock/cb/").must_equal "/tmp/fc/mock/cb"
+      it "returns the cookbook dir when passed a nested directory" do
+        expect(api.cookbook_base_path("#{temp_path}/templates/defaults/test.erb")).to eq temp_path
+      end
     end
 
-    it "returns the cookbook dir when passed a nested directory" do
-      mock_cookbook("/tmp/fc/mock/cb/metadata.rb")
-      api.cookbook_base_path("/tmp/fc/mock/cb/templates/defaults/test.erb").must_equal "/tmp/fc/mock/cb"
-    end
+    context "with a metadata.json" do
+      file "metadata.json"
 
-    it "returns the cookbook dir when path contains cookbook like names" do
-      mock_cookbook("/tmp/fc/mock/resources/cb/metadata.rb")
-      api.cookbook_base_path("/tmp/fc/mock/resources/cb/templates/defaults/test.erb").must_equal "/tmp/fc/mock/resources/cb"
-    end
+      it "returns the cookbook dir when passed the path itself" do
+        expect(api.cookbook_base_path(temp_path)).to eq temp_path
+      end
 
-    it "returns the cookbook dir when path has a metadata.json not metadata.rb" do
-      mock_cookbook("/tmp/fc/mock/cb/metadata.json")
-      api.cookbook_base_path("/tmp/fc/mock/cb/templates/defaults/test.erb").must_equal "/tmp/fc/mock/cb"
+      it "returns the cookbook dir when passed a nested directory" do
+        expect(api.cookbook_base_path("#{temp_path}/templates/defaults/test.erb")).to eq temp_path
+      end
     end
-  end
 
-  describe "#cookbook_name" do
-    def mock_cookbook_metadata(f)
-      dir = File.dirname(f)
-      unless File.directory?(dir)
-        FileUtils.mkdir_p(dir)
+    context "with complex nested folders with metadata.rb" do
+      file "metadata.rb"
+      file "templates/metadata.rb"
+
+      it "returns the cookbook dir when path contains cookbook like names" do
+        expect(api.cookbook_base_path("#{temp_path}/templates/defaults/test.erb")).to eq "#{temp_path}/templates"
       end
-      File.open(f, "w") { |file| file.write('name "YOUR_COOKBOOK_NAME"') }
     end
+  end
 
-    metadata_path = "/tmp/fc/mock/cb/metadata.rb"
+  describe "#cookbook_name" do
     it "raises if passed a nil" do
-      lambda { api.cookbook_name(nil) }.must_raise ArgumentError
+      expect { api.cookbook_name(nil) }.to raise_error ArgumentError
     end
     it "raises if passed an empty string" do
-      lambda { api.cookbook_name("") }.must_raise ArgumentError
+      expect { api.cookbook_name("") }.to raise_error ArgumentError
     end
     it "returns the cookbook name when passed a recipe" do
       recipe_path = "cookbooks/apache2/recipes/default.rb"
-      api.cookbook_name(recipe_path).must_equal "apache2"
+      expect(api.cookbook_name(recipe_path)).to eq "apache2"
     end
     it "returns the cookbook name when passed the cookbook metadata" do
-      api.cookbook_name("cookbooks/apache2/metadata.rb").must_equal "apache2"
+      expect(api.cookbook_name("cookbooks/apache2/metadata.rb")).to eq "apache2"
     end
     it "returns the cookbook name when passed a template" do
       erb_path = "cookbooks/apache2/templates/default/a2ensite.erb"
-      api.cookbook_name(erb_path).must_equal "apache2"
+      expect(api.cookbook_name(erb_path)).to eq "apache2"
     end
-    it "returns the cookbook name when passed the cookbook metadata with a name field" do
-      mock_cookbook_metadata(metadata_path)
-      api.cookbook_name(metadata_path).must_equal "YOUR_COOKBOOK_NAME"
+    context "with a metadata.rb" do
+      file "metadata.rb", 'name "YOUR_COOKBOOK_NAME"'
+      it "returns the cookbook name when passed the cookbook metadata with a name field" do
+        expect(api.cookbook_name(temp_path)).to eq "YOUR_COOKBOOK_NAME"
+      end
     end
   end
 
   describe "#cookbook_maintainer" do
-    def mock_cookbook_metadata(f)
-      dir = File.dirname(f)
-      unless File.directory?(dir)
-        FileUtils.mkdir_p(dir)
-      end
-      File.open(f, "w") { |file| file.write('maintainer "YOUR_COMPANY_NAME"') }
-    end
-
-    metadata_path = "/tmp/fc/mock/cb/metadata.rb"
     it "raises if passed a nil" do
-      lambda { api.cookbook_maintainer(nil) }.must_raise ArgumentError
+      expect { api.cookbook_maintainer(nil) }.to raise_error ArgumentError
     end
     it "raises if passed an empty string" do
-      lambda { api.cookbook_maintainer("") }.must_raise ArgumentError
+      expect { api.cookbook_maintainer("") }.to raise_error ArgumentError
     end
     it "raises if the path does not exist" do
-      lambda { api.cookbook_maintainer("/tmp/non-existent-path") }.must_raise RuntimeError
+      expect { api.cookbook_maintainer("/invalid") }.to raise_error RuntimeError
     end
-    it "returns the cookbook maintainer when passed the cookbook metadata" do
-      mock_cookbook_metadata(metadata_path)
-      api.cookbook_maintainer(metadata_path).must_equal "YOUR_COMPANY_NAME"
-    end
-    it "returns the cookbook maintainer when passed a recipe" do
-      mock_cookbook_metadata(metadata_path)
-      api.cookbook_maintainer("/tmp/fc/mock/cb/recipes/default.rb").must_equal "YOUR_COMPANY_NAME"
-    end
-    it "returns the cookbook maintainer when passed a template" do
-      mock_cookbook_metadata(metadata_path)
-      api.cookbook_maintainer("/tmp/fc/mock/cb/templates/default/mock.erb").must_equal "YOUR_COMPANY_NAME"
+    context "with a metadata.rb" do
+      file "metadata.rb", 'maintainer "YOUR_COMPANY_NAME"'
+      it "returns the cookbook maintainer when passed the cookbook metadata" do
+        expect(api.cookbook_maintainer(temp_path)).to eq "YOUR_COMPANY_NAME"
+      end
+      it "returns the cookbook maintainer when passed a recipe" do
+        expect(api.cookbook_maintainer("#{temp_path}/recipes/default.rb")).to eq "YOUR_COMPANY_NAME"
+      end
+      it "returns the cookbook maintainer when passed a template" do
+        expect(api.cookbook_maintainer("#{temp_path}/templates/default/mock.erb")).to eq "YOUR_COMPANY_NAME"
+      end
     end
   end
 
   describe "#cookbook_maintainer_email" do
-    def mock_cookbook_metadata(f)
-      dir = File.dirname(f)
-      unless File.directory?(dir)
-        FileUtils.mkdir_p(dir)
-      end
-      File.open(f, "w") { |file| file.write('maintainer_email "YOUR_EMAIL"') }
-    end
-
-    metadata_path = "/tmp/fc/mock/cb/metadata.rb"
     it "raises if passed a nil" do
-      lambda { api.cookbook_maintainer_email(nil) }.must_raise ArgumentError
+      expect { api.cookbook_maintainer_email(nil) }.to raise_error ArgumentError
     end
     it "raises if passed an empty string" do
-      lambda { api.cookbook_maintainer_email("") }.must_raise ArgumentError
+      expect { api.cookbook_maintainer_email("") }.to raise_error ArgumentError
     end
     it "raises if the path does not exist" do
-      lambda { api.cookbook_maintainer_email("/tmp/non-existent-path") }.must_raise RuntimeError
+      expect { api.cookbook_maintainer_email("/invalid") }.to raise_error RuntimeError
     end
-    it "returns the cookbook maintainer_email when passed the cookbook metadata" do
-      mock_cookbook_metadata(metadata_path)
-      api.cookbook_maintainer_email(metadata_path).must_equal "YOUR_EMAIL"
-    end
-    it "returns the cookbook maintainer_email when passed a recipe" do
-      mock_cookbook_metadata(metadata_path)
-      api.cookbook_maintainer_email("/tmp/fc/mock/cb/recipes/default.rb").must_equal "YOUR_EMAIL"
-    end
-    it "returns the cookbook maintainer_email when passed a template" do
-      mock_cookbook_metadata(metadata_path)
-      api.cookbook_maintainer_email("/tmp/fc/mock/cb/templates/default/mock.erb").must_equal "YOUR_EMAIL"
+    context "with a metadata.rb" do
+      file "metadata.rb", 'maintainer_email "YOUR_EMAIL"'
+      it "returns the cookbook maintainer_email when passed the cookbook metadata" do
+        expect(api.cookbook_maintainer_email(temp_path)).to eq "YOUR_EMAIL"
+      end
+      it "returns the cookbook maintainer_email when passed a recipe" do
+        expect(api.cookbook_maintainer_email("#{temp_path}/recipes/default.rb")).to eq "YOUR_EMAIL"
+      end
+      it "returns the cookbook maintainer_email when passed a template" do
+        expect(api.cookbook_maintainer_email("#{temp_path}/templates/default/mock.erb")).to eq "YOUR_EMAIL"
+      end
     end
   end
 
   describe "#declared_dependencies" do
     it "raises if the ast does not support XPath" do
-      lambda { api.declared_dependencies(nil) }.must_raise ArgumentError
+      expect { api.declared_dependencies(nil) }.to raise_error ArgumentError
     end
     it "returns an empty if there are no declared dependencies" do
-      ast = MiniTest::Mock.new
-      3.times do
-        ast.expect :xpath, [], [String]
-      end
-      api.declared_dependencies(ast).must_be_empty
+      ast = double
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([]).twice
+      expect(api.declared_dependencies(ast)).to be_empty
     end
     it "includes only cookbook names in the returned array" do
       ast = Nokogiri::XML(%q{
@@ -372,7 +349,7 @@ describe FoodCritic::Api do
               </args_add_block>
             </command>
       })
-      api.declared_dependencies(ast).must_equal ["mysql"]
+      expect(api.declared_dependencies(ast)).to eq ["mysql"]
     end
   end
 
@@ -380,39 +357,39 @@ describe FoodCritic::Api do
     describe :simple_ast do
       let(:ast) { parse_ast('name "webserver"') }
       it "raises if the field name is nil" do
-        lambda { api.field(ast, nil) }.must_raise ArgumentError
+        expect { api.field(ast, nil) }.to raise_error ArgumentError
       end
       it "raises if the field name is empty" do
-        lambda { api.field(ast, "") }.must_raise ArgumentError
+        expect { api.field(ast, "") }.to raise_error ArgumentError
       end
       it "returns empty if the field is not present" do
-        api.field(ast, :common_name).must_be_empty
+        expect(api.field(ast, :common_name)).to be_empty
       end
       it "accepts a string for the field name" do
-        api.field(ast, "name").wont_be_empty
+        expect(api.field(ast, "name")).to_not be_empty
       end
       it "accepts a symbol for the field name" do
-        api.field(ast, :name).wont_be_empty
+        expect(api.field(ast, :name)).to_not be_empty
       end
     end
     it "returns fields when the value is an embedded string expression" do
       ast = parse_ast(%q{
         name "#{foo}_#{bar}"
       }.strip)
-      api.field(ast, :name).size.must_equal 1
+      expect(api.field(ast, :name).size).to eq 1
     end
     it "returns fields when the value is a method call" do
       ast = parse_ast(%q{
         name generate_name
       }.strip)
-      api.field(ast, :name).size.must_equal 1
+      expect(api.field(ast, :name).size).to eq 1
     end
     it "returns both fields if the field is specified twice" do
       ast = parse_ast(%q{
         name "webserver"
         name "database"
       }.strip)
-      api.field(ast, :name).size.must_equal 2
+      expect(api.field(ast, :name).size).to eq 2
     end
   end
 
@@ -420,113 +397,104 @@ describe FoodCritic::Api do
     describe :simple_ast do
       let(:ast) { parse_ast('name "webserver"') }
       it "raises if the field name is nil" do
-        lambda { api.field_value(ast, nil) }.must_raise ArgumentError
+        expect { api.field_value(ast, nil) }.to raise_error ArgumentError
       end
       it "raises if the field name is empty" do
-        lambda { api.field_value(ast, "") }.must_raise ArgumentError
+        expect { api.field_value(ast, "") }.to raise_error ArgumentError
       end
       it "is falsy if the field is not present" do
-        refute api.field_value(ast, :common_name)
+        expect(api.field_value(ast, :common_name)).to be_falsey
       end
       it "accepts a string for the field name" do
-        api.field_value(ast, "name").must_equal "webserver"
+        expect(api.field_value(ast, "name")).to eq "webserver"
       end
       it "accepts a symbol for the field name" do
-        api.field_value(ast, :name).must_equal "webserver"
+        expect(api.field_value(ast, :name)).to eq "webserver"
       end
     end
     it "is falsy when the value is an embedded string expression" do
       ast = parse_ast(%q{
         name "#{foo}_#{bar}"
       }.strip)
-      refute api.field_value(ast, :name)
+      expect(api.field_value(ast, :name)).to be_falsey
     end
     it "is falsy when the value is a method call" do
       ast = parse_ast(%q{
         name generate_name('foo')
       }.strip)
-      refute api.field_value(ast, :name)
+      expect(api.field_value(ast, :name)).to be_falsey
     end
     it "returns the last value if the field is specified twice" do
       ast = parse_ast(%q{
         name "webserver"
         name "database"
       }.strip)
-      api.field_value(ast, :name).must_equal "database"
+      expect(api.field_value(ast, :name)).to eq "database"
     end
   end
 
   describe "#file_match" do
     it "includes the provided filename in the match" do
-      api.file_match("foo.rb")[:filename].must_equal "foo.rb"
+      expect(api.file_match("foo.rb")[:filename]).to eq "foo.rb"
     end
     it "retains the full provided filename path in the match" do
-      api.file_match("foo/bar/foo.rb")[:filename].must_equal "foo/bar/foo.rb"
+      expect(api.file_match("foo/bar/foo.rb")[:filename]).to eq "foo/bar/foo.rb"
     end
     it "raises an error if the provided filename is nil" do
-      lambda { api.file_match(nil) }.must_raise(ArgumentError)
+      expect { api.file_match(nil) }.to raise_error ArgumentError
     end
     it "sets the line and column to the beginning of the file" do
       match = api.file_match("bar.rb")
-      match[:line].must_equal 1
-      match[:column].must_equal 1
+      expect(match[:line]).to eq 1
+      expect(match[:column]).to eq 1
     end
   end
 
   describe "#find_resources" do
-    let(:ast) { MiniTest::Mock.new }
+    let(:ast) { double() }
     it "returns empty unless the ast supports XPath" do
-      api.find_resources(nil).must_be_empty
+      expect(api.find_resources(nil)).to be_empty
     end
     it "restricts by resource type when provided" do
-      ast.expect :xpath, ["method_add_block"],
-        ["//method_add_block[command/ident[@value='file']]" +
-          "[command/ident/@value != 'action']"]
+      expect(ast).to receive(:xpath).with("//method_add_block[command/ident[@value='file']][command/ident/@value != 'action']").and_return(["method_add_block"])
       api.find_resources(ast, :type => "file")
-      ast.verify
     end
     it "does not restrict by resource type when not provided" do
-      ast.expect :xpath, ["method_add_block"],
-                         ["//method_add_block[command/ident]" +
-                           "[command/ident/@value != 'action']"]
+      expect(ast).to receive(:xpath).with("//method_add_block[command/ident][command/ident/@value != 'action']").and_return(["method_add_block"])
       api.find_resources(ast)
-      ast.verify
     end
     it "allows resource type to be specified as :any" do
-      ast.expect :xpath, ["method_add_block"],
-                         ["//method_add_block[command/ident]" +
-                           "[command/ident/@value != 'action']"]
+      expect(ast).to receive(:xpath).with("//method_add_block[command/ident][command/ident/@value != 'action']").and_return(["method_add_block"])
       api.find_resources(ast, :type => :any)
-      ast.verify
     end
     it "returns any matches" do
-      ast.expect :xpath, ["method_add_block"], [String]
-      api.find_resources(ast).must_equal ["method_add_block"]
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(["method_add_block"])
+      expect(api.find_resources(ast)).to eq ["method_add_block"]
     end
   end
 
   describe "#included_recipes" do
+    let(:ast) { double() }
     it "raises if the ast does not support XPath" do
-      lambda { api.included_recipes(nil) }.must_raise ArgumentError
+      expect { api.included_recipes(nil) }.to raise_error ArgumentError
     end
     it "returns an empty hash if there are no included recipes" do
-      ast = MiniTest::Mock.new.expect :xpath, [], [String]
-      api.included_recipes(ast).keys.must_be_empty
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
+      expect(api.included_recipes(ast).keys).to be_empty
     end
     it "returns a hash keyed by recipe name" do
-      ast = MiniTest::Mock.new.expect :xpath, [{ "value" => "foo::bar" }],
-        [String]
-      api.included_recipes(ast).keys.must_equal ["foo::bar"]
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([{ "value" => "foo::bar" }])
+      expect(api.included_recipes(ast).keys).to eq ["foo::bar"]
     end
     it "returns a hash where the values are the matching nodes" do
-      ast = MiniTest::Mock.new.expect :xpath, [{ "value" => "foo::bar" }],
-        [String]
-      api.included_recipes(ast).values.must_equal [[{ "value" => "foo::bar" }]]
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([{ "value" => "foo::bar" }])
+      expect(api.included_recipes(ast).values).to eq [[{ "value" => "foo::bar" }]]
     end
     it "correctly keys an included recipe specified as a string literal" do
-      api.included_recipes(parse_ast(%q{
+      ast = parse_ast(%q{
         include_recipe "foo::default"
-      })).keys.must_equal ["foo::default"]
+      })
+      expect(api.included_recipes(ast).keys).to eq ["foo::default"]
     end
     describe "embedded expression - recipe name" do
       let(:ast) do
@@ -535,16 +503,16 @@ describe FoodCritic::Api do
         })
       end
       it "returns the literal string component by default" do
-        api.included_recipes(ast).keys.must_equal ["foo::"]
+        expect(api.included_recipes(ast).keys).to eq ["foo::"]
       end
       it "returns the literal string part of the AST" do
-        api.included_recipes(ast)["foo::"].first.must_respond_to(:xpath)
+        expect(api.included_recipes(ast)["foo::"].first).to respond_to :xpath
       end
       it "returns empty if asked to exclude statements with embedded expressions" do
-        api.included_recipes(ast, :with_partial_names => false).must_be_empty
+        expect(api.included_recipes(ast, :with_partial_names => false)).to be_empty
       end
       it "returns the literals if asked to include statements with embedded expressions" do
-        api.included_recipes(ast, :with_partial_names => true).keys.must_equal ["foo::"]
+        expect(api.included_recipes(ast, :with_partial_names => true).keys).to eq ["foo::"]
       end
     end
     describe "embedded expression - cookbook name" do
@@ -554,13 +522,13 @@ describe FoodCritic::Api do
         })
       end
       it "returns the literal string component by default" do
-        api.included_recipes(ast).keys.must_equal ["::bar"]
+        expect(api.included_recipes(ast).keys).to eq ["::bar"]
       end
       it "returns the literal string part of the AST" do
-        api.included_recipes(ast)["::bar"].first.must_respond_to(:xpath)
+        expect(api.included_recipes(ast)["::bar"].first).to respond_to :xpath
       end
       it "returns empty if asked to exclude statements with embedded expressions" do
-        api.included_recipes(ast, :with_partial_names => false).must_be_empty
+        expect(api.included_recipes(ast, :with_partial_names => false)).to be_empty
       end
     end
     describe "embedded expression - partial cookbook name" do
@@ -570,13 +538,13 @@ describe FoodCritic::Api do
         })
       end
       it "returns the literal string component by default" do
-        api.included_recipes(ast).keys.must_equal ["_foo::bar"]
+        expect(api.included_recipes(ast).keys).to eq ["_foo::bar"]
       end
       it "returns the literal string part of the AST" do
-        api.included_recipes(ast)["_foo::bar"].first.must_respond_to(:xpath)
+        expect(api.included_recipes(ast)["_foo::bar"].first).to respond_to :xpath
       end
       it "returns empty if asked to exclude statements with embedded expressions" do
-        api.included_recipes(ast, :with_partial_names => false).must_be_empty
+        expect(api.included_recipes(ast, :with_partial_names => false)).to be_empty
       end
     end
   end
@@ -585,289 +553,306 @@ describe FoodCritic::Api do
     describe "#is_att_type" do
       let(:filter) { FoodCritic::Api::AttFilter.new }
       it "returns empty if the argument is not enumerable" do
-        filter.is_att_type(nil).must_be_empty
+        expect(filter.is_att_type(nil)).to be_empty
       end
       it "filters out values that are not Chef node attribute types" do
         nodes = %w{node node badger default override ostrich set normal}
-        filter.is_att_type(nodes).uniq.size.must_equal 5
+        expect(filter.is_att_type(nodes).uniq.size).to eq 5
       end
       it "returns all filtered nodes" do
         nodes = %w{node node override default normal set set override}
-        filter.is_att_type(nodes).must_equal nodes
+        expect(filter.is_att_type(nodes)).to eq nodes
       end
       it "returns empty if there are no Chef node attribute types" do
         nodes = %w{squirrel badger pooh tigger}
-        filter.is_att_type(nodes).must_be_empty
+        expect(filter.is_att_type(nodes)).to be_empty
       end
     end
   end
 
   describe "#literal_searches" do
-    let(:ast) { MiniTest::Mock.new }
+    let(:ast) { double() }
     it "returns empty if the AST does not support XPath expressions" do
-      api.literal_searches(nil).must_be_empty
+      expect(api.literal_searches(nil)).to be_empty
     end
     it "returns empty if the AST has no elements" do
-      ast.expect :xpath, [], [String]
-      api.literal_searches(ast).must_be_empty
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
+      expect(api.literal_searches(ast)).to be_empty
     end
     it "returns the AST elements for each literal search" do
-      ast.expect :xpath, ["tstring_content"], [String]
-      api.literal_searches(ast).must_equal ["tstring_content"]
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(["tstring_content"])
+      expect(api.literal_searches(ast)).to eq ["tstring_content"]
     end
   end
 
   describe "#match" do
     it "raises if the provided node is nil" do
-      lambda { api.match(nil) }.must_raise(ArgumentError)
+      expect { api.match(nil) }.to raise_error ArgumentError
     end
     it "raises if the provided node does not support XPath" do
-      lambda { api.match(Object.new) }.must_raise(ArgumentError)
+      expect { api.match(Object.new) }.to raise_error ArgumentError
     end
     it "returns nil if there is no nested position node" do
-      node = MiniTest::Mock.new
-      node.expect :xpath, [], ["descendant::pos"]
-      api.match(node).must_be_nil
+      node = double()
+      expect(node).to receive(:xpath).with("descendant::pos").and_return([])
+      expect(api.match(node)).to be nil
     end
     it "uses the position of the first position node if there are multiple" do
-      node = MiniTest::Mock.new
-      node.expect(:xpath,
-        [{ "name" => "pos", "line" => "1", "column" => "10" },
-         { "name" => "pos", "line" => "3", "column" => "16" }],
-           ["descendant::pos"])
+      node = double()
+      expect(node).to receive(:xpath).with("descendant::pos").and_return([
+        { "name" => "pos", "line" => "1", "column" => "10" },
+        { "name" => "pos", "line" => "3", "column" => "16" }])
       match = api.match(node)
-      match[:line].must_equal(1)
-      match[:column].must_equal(10)
+      expect(match[:line]).to eq 1
+      expect(match[:column]).to eq 10
     end
     describe :matched_node_name do
       let(:node) do
-        node = MiniTest::Mock.new
-        node.expect :xpath, [{ "name" => "pos", "line" => "1",
-                               "column" => "10" }], ["descendant::pos"]
+        node = double()
+        expect(node).to receive(:xpath).with("descendant::pos").and_return([{ "name" => "pos", "line" => "1", "column" => "10" }])
         node
       end
       it "includes the name of the node in the match" do
-        node.expect :name, "command"
-        api.match(node).must_equal({ :matched => "command", :line => 1,
-                                     :column => 10 })
+        expect(node).to receive(:name).and_return("command")
+        expect(api.match(node)).to eq({ :matched => "command", :line => 1,
+                                        :column => 10 })
       end
       it "sets the matched name to empty if the element does not have a name" do
-        api.match(node).must_equal({ :matched => "", :line => 1, :column => 10 })
+        expect(api.match(node)).to eq({ :matched => "", :line => 1, :column => 10 })
       end
     end
   end
 
   describe "#notifications" do
     it "returns empty if the provided AST does not support XPath" do
-      api.notifications(nil).must_be_empty
+      expect(api.notifications(nil)).to be_empty
     end
     it "returns empty if there are no notifications" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
             group "root"
           end
-      })).must_be_empty
+      })
+      expect(api.notifications(ast)).to be_empty
     end
     describe "malformed syntax" do
       it "returns empty if no notifies value is provided" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
             group "root"
             notifies
           end
-        })).must_be_empty
+        })
+        expect(api.notifications(ast)).to be_empty
       end
       it "returns empty if no subscribes value is provided" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
             group "root"
             subscribes
           end
-        })).must_be_empty
+        })
+        expect(api.notifications(ast)).to be_empty
       end
       it "returns empty if only the notifies action is provided" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
             group "root"
             notifies :restart
           end
-        })).must_be_empty
+        })
+        expect(api.notifications(ast)).to be_empty
       end
       it "returns empty if only the subscribes action is provided" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
             group "root"
             subscribes :restart
           end
-        })).must_be_empty
+        })
+        expect(api.notifications(ast)).to be_empty
       end
       describe "returns empty if the service name is missing" do
         it "old-style notifications" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               notifies :restart, resources(:service)
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "old-style subscriptions" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               subscribes:restart, resources(:service)
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "new-style notifications" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               notifies :restart, "service"
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "new-style subscriptions" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               subscribes:restart, "service"
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
       end
       describe "returns empty if the resource type is missing" do
         it "old-style notifications" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               notifies :restart, resources("nscd")
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "old-style subscriptions" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               subscribes :restart, resources("nscd")
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "new-style notifications" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               notifies :restart, "nscd"
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "new-style subscriptions" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               subscribes :restart, "nscd"
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
       end
       describe "returns empty if the resource name is missing" do
         it "old-style notifications" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               notifies :restart, resources(:service)
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "old-style subscriptions" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               subscribes :restart, resources(:service)
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "new-style notifications" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               notifies :restart, "service[]"
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
         it "new-style subscriptions" do
-          api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/nscd.conf" do
               source "nscd.conf"
               owner "root"
               group "root"
               subscribes :restart, "service[]"
             end
-          })).must_be_empty
+          })
+          expect(api.notifications(ast)).to be_empty
         end
       end
       it "returns empty if the left square bracket is missing" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
             group "root"
             subscribes :restart, "servicefoo]"
           end
-        })).must_be_empty
+        })
+        expect(api.notifications(ast)).to be_empty
       end
       it "returns empty if the right square bracket is missing" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
             group "root"
             subscribes :restart, "service[foo"
           end
-        })).must_be_empty
+        })
+        expect(api.notifications(ast)).to be_empty
       end
     end
     it "understands the old-style notifications" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies :restart, resources(:service => "nscd")
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :restart,
           :resource_type => :service,
@@ -875,18 +860,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :old,
         }]
-      )
     end
     it "understands old-style notifications with :'symbol' literals as action" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies :'soft-restart', resources(:service => "nscd")
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :'soft-restart',
           :resource_type => :service,
@@ -894,18 +878,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :old,
         }]
-      )
     end
     it "understands old-style notifications with added parentheses" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies(:restart, resources(:service => "nscd"))
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :restart,
           :resource_type => :service,
@@ -913,18 +896,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :old,
         }]
-      )
     end
     it "understands old-style notifications with ruby 1.9 hash syntax" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies :restart, resources(service: "nscd")
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :restart,
           :resource_type => :service,
@@ -932,18 +914,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :old,
         }]
-      )
     end
     it "understands the old-style subscriptions" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           subscribes :restart, resources(:service => "nscd")
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :subscribes,
           :action => :restart,
           :resource_type => :service,
@@ -951,18 +932,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :old,
         }]
-      )
     end
     it "understands old-style subscriptions with added parentheses" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           subscribes(:restart, resources(:service => "nscd"))
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :subscribes,
           :action => :restart,
           :resource_type => :service,
@@ -970,18 +950,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :old,
         }]
-      )
     end
     it "understands the new-style notifications" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies :restart, "service[nscd]"
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :restart,
           :resource_type => :service,
@@ -989,18 +968,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :new,
         }]
-      )
     end
     it "understands new-style notifications with :'symbol' literals as action" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies :'soft-restart', "service[nscd]"
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :'soft-restart',
           :resource_type => :service,
@@ -1008,18 +986,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :new,
         }]
-      )
     end
     it "understands new-style notifications with added parentheses" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies(:restart, "service[nscd]")
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :restart,
           :resource_type => :service,
@@ -1027,18 +1004,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :new,
         }]
-      )
     end
     it "understands the new-style subscriptions" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           subscribes :restart, "service[nscd]"
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :subscribes,
           :action => :restart,
           :resource_type => :service,
@@ -1046,18 +1022,17 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :new,
         }]
-      )
     end
     it "understands new-style subscriptions with added parentheses" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           subscribes(:restart, "service[nscd]")
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :subscribes,
           :action => :restart,
           :resource_type => :service,
@@ -1065,11 +1040,10 @@ describe FoodCritic::Api do
           :timing => :delayed,
           :style => :new,
         }]
-      )
     end
     describe "supports a resource both notifying and subscribing" do
       it "old-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
@@ -1077,7 +1051,8 @@ describe FoodCritic::Api do
             notifies :restart, resources(:service => "nscd")
             subscribes :create, resources(:template => "/etc/nscd.conf")
           end
-        })).must_equal([
+        })
+        expect(api.notifications(ast)).to eq [
           {
             :type => :notifies,
             :action => :restart,
@@ -1094,10 +1069,10 @@ describe FoodCritic::Api do
             :timing => :delayed,
             :style => :old,
           },
-        ])
+        ]
       end
       it "new-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
@@ -1105,7 +1080,8 @@ describe FoodCritic::Api do
             notifies :restart, "service[nscd]"
             subscribes :create, "template[/etc/nscd.conf]"
           end
-        })).must_equal([
+        })
+        expect(api.notifications(ast)).to eq [
           {
             :type => :notifies,
             :action => :restart,
@@ -1122,19 +1098,19 @@ describe FoodCritic::Api do
             :timing => :delayed,
             :style => :new,
           },
-        ])
+        ]
       end
     end
     it "understands the old-style notifications with timing" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies :restart, resources(:service => "nscd"), :immediately
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :restart,
           :resource_type => :service,
@@ -1142,18 +1118,17 @@ describe FoodCritic::Api do
           :timing => :immediate,
           :style => :old,
         }]
-      )
     end
     it "understands the old-style subscriptions with timing" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           subscribes :restart, resources(:service => "nscd"), :immediately
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :subscribes,
           :action => :restart,
           :resource_type => :service,
@@ -1161,18 +1136,17 @@ describe FoodCritic::Api do
           :timing => :immediate,
           :style => :old,
         }]
-      )
     end
     it "understands the new-style notifications with timing" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           notifies :restart, "service[nscd]", :immediately
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :notifies,
           :action => :restart,
           :resource_type => :service,
@@ -1180,18 +1154,17 @@ describe FoodCritic::Api do
           :timing => :immediate,
           :style => :new,
         }]
-      )
     end
     it "understands the new-style subscriptions with timing" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/nscd.conf" do
           source "nscd.conf"
           owner "root"
           group "root"
           subscribes :restart, "service[nscd]", :immediately
         end
-      })).must_equal(
-        [{
+      })
+      expect(api.notifications(ast)).to eq [{
           :type => :subscribes,
           :action => :restart,
           :resource_type => :service,
@@ -1199,11 +1172,10 @@ describe FoodCritic::Api do
           :timing => :immediate,
           :style => :new,
         }]
-      )
     end
     describe "can be passed an individual resource" do
       it "old-style notifications" do
-        api.notifications(api.find_resources(parse_ast(%q{
+        ast = parse_ast(%q{
           service "nscd" do
             action :start
           end
@@ -1213,14 +1185,15 @@ describe FoodCritic::Api do
             group "root"
             notifies :restart, resources(:service => "nscd")
           end
-        }), :type => :template).first).must_equal([
+        })
+        expect(api.notifications(api.find_resources(ast, :type => :template).first)).to eq [
           { :type => :notifies, :action => :restart, :resource_type => :service,
             :resource_name => "nscd", :timing => :delayed,
             :style => :old },
-        ])
+        ]
       end
       it "old-style subscriptions" do
-        api.notifications(api.find_resources(parse_ast(%q{
+        ast = parse_ast(%q{
           service "nscd" do
             action :start
           end
@@ -1230,14 +1203,15 @@ describe FoodCritic::Api do
             group "root"
             subscribes :restart, resources(:service => "nscd")
           end
-        }), :type => :template).first).must_equal([
+        })
+        expect(api.notifications(api.find_resources(ast, :type => :template).first)).to eq [
           { :type => :subscribes, :action => :restart, :resource_type => :service,
             :resource_name => "nscd", :timing => :delayed,
             :style => :old },
-        ])
+        ]
       end
       it "new-style notifications" do
-        api.notifications(api.find_resources(parse_ast(%q{
+        ast = parse_ast(%q{
           service "nscd" do
             action :start
           end
@@ -1247,14 +1221,15 @@ describe FoodCritic::Api do
             group "root"
             notifies :restart, "service[nscd]"
           end
-        }), :type => :template).first).must_equal([
+        })
+        expect(api.notifications(api.find_resources(ast, :type => :template).first)).to eq [
           { :type => :notifies, :action => :restart, :resource_type => :service,
             :resource_name => "nscd", :timing => :delayed,
             :style => :new },
-        ])
+        ]
       end
       it "new-style subscriptions" do
-        api.notifications(api.find_resources(parse_ast(%q{
+        ast = parse_ast(%q{
           service "nscd" do
             action :start
           end
@@ -1264,16 +1239,17 @@ describe FoodCritic::Api do
             group "root"
             subscribes :restart, "service[nscd]"
           end
-        }), :type => :template).first).must_equal([
+        })
+        expect(api.notifications(api.find_resources(ast, :type => :template).first)).to eq [
           { :type => :subscribes, :action => :restart, :resource_type => :service,
             :resource_name => "nscd", :timing => :delayed,
             :style => :new },
-        ])
+        ]
       end
     end
     describe "supports multiple notifications on a single resource" do
       it "old-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
@@ -1281,8 +1257,8 @@ describe FoodCritic::Api do
             notifies :stop, resources(:service => "nscd")
             notifies :start, resources(:service => "nscd")
           end
-        })).must_equal(
-          [
+        })
+        expect(api.notifications(ast)).to eq [
             { :type => :notifies, :action => :stop, :resource_type => :service,
               :resource_name => "nscd", :timing => :delayed,
               :style => :old },
@@ -1290,10 +1266,9 @@ describe FoodCritic::Api do
               :resource_name => "nscd", :timing => :delayed,
               :style => :old },
           ]
-        )
       end
       it "old-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
@@ -1301,8 +1276,8 @@ describe FoodCritic::Api do
             subscribes :stop, resources(:service => "nscd")
             subscribes :start, resources(:service => "nscd")
           end
-        })).must_equal(
-          [
+        })
+        expect(api.notifications(ast)).to eq [
             { :type => :subscribes, :action => :stop, :resource_type => :service,
               :resource_name => "nscd", :timing => :delayed,
               :style => :old },
@@ -1310,10 +1285,9 @@ describe FoodCritic::Api do
               :resource_name => "nscd", :timing => :delayed,
               :style => :old },
           ]
-        )
       end
       it "new-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
@@ -1321,8 +1295,8 @@ describe FoodCritic::Api do
             notifies :stop, "service[nscd]"
             notifies :start, "service[nscd]"
           end
-        })).must_equal(
-          [
+        })
+        expect(api.notifications(ast)).to eq [
             { :type => :notifies, :action => :stop, :resource_type => :service,
               :resource_name => "nscd", :timing => :delayed,
               :style => :new },
@@ -1330,10 +1304,9 @@ describe FoodCritic::Api do
               :resource_name => "nscd", :timing => :delayed,
               :style => :new },
           ]
-        )
       end
       it "new-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/nscd.conf" do
             source "nscd.conf"
             owner "root"
@@ -1341,8 +1314,8 @@ describe FoodCritic::Api do
             subscribes :stop, "service[nscd]"
             subscribes :start, "service[nscd]"
           end
-        })).must_equal(
-          [
+        })
+        expect(api.notifications(ast)).to eq [
             { :type => :subscribes, :action => :stop, :resource_type => :service,
               :resource_name => "nscd", :timing => :delayed,
               :style => :new },
@@ -1350,242 +1323,260 @@ describe FoodCritic::Api do
               :resource_name => "nscd", :timing => :delayed,
               :style => :new },
           ]
-        )
       end
     end
     describe "understands notifications for an execute resource" do
       it "old-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/tmp/foo.bar" do
             source "foo.bar.erb"
             notifies :run, resources(:execute => "foo")
           end
-        })).must_equal(
-          [{ :type => :notifies, :action => :run, :resource_type => :execute,
+        })
+        expect(api.notifications(ast)).to eq [
+           { :type => :notifies, :action => :run, :resource_type => :execute,
              :resource_name => "foo", :timing => :delayed,
-             :style => :old }]
-        )
+             :style => :old },
+          ]
       end
       it "old-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/tmp/foo.bar" do
             source "foo.bar.erb"
             subscribes :run, resources(:execute => "foo")
           end
-        })).must_equal(
-          [{ :type => :subscribes, :action => :run, :resource_type => :execute,
+        })
+        expect(api.notifications(ast)).to eq [
+           { :type => :subscribes, :action => :run, :resource_type => :execute,
              :resource_name => "foo", :timing => :delayed,
-             :style => :old }]
-        )
+             :style => :old },
+          ]
       end
       it "old-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/tmp/foo.bar" do
             source "foo.bar.erb"
             notifies :run, "execute[foo]"
           end
-        })).must_equal(
-          [{ :type => :notifies, :action => :run, :resource_type => :execute,
+        })
+        expect(api.notifications(ast)).to eq [
+           { :type => :notifies, :action => :run, :resource_type => :execute,
              :resource_name => "foo", :timing => :delayed,
-             :style => :new }]
-        )
+             :style => :new },
+          ]
       end
       it "old-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/tmp/foo.bar" do
             source "foo.bar.erb"
             subscribes :run, "execute[foo]"
           end
-        })).must_equal(
-          [{ :type => :subscribes, :action => :run, :resource_type => :execute,
+        })
+        expect(api.notifications(ast)).to eq [
+           { :type => :subscribes, :action => :run, :resource_type => :execute,
              :resource_name => "foo", :timing => :delayed,
-             :style => :new }]
-        )
+             :style => :new },
+          ]
       end
     end
     describe "sets the notification timing to delayed if specified" do
       it "old-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :run, resources(execute => "robespierre"), :delayed
           end
-        })).first[:timing].must_equal(:delayed)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :delayed
       end
       it "old-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             subscribes :run, resources(execute => "robespierre"), :delayed
           end
-        })).first[:timing].must_equal(:delayed)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :delayed
       end
       it "new-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :run, "execute[robespierre]", :delayed
           end
-        })).first[:timing].must_equal(:delayed)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :delayed
       end
       it "new-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             subscribes :run, "execute[robespierre]", :delayed
           end
-        })).first[:timing].must_equal(:delayed)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :delayed
       end
     end
     describe "sets the notification timing to immediate if specified as immediate" do
       it "old-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :run, resources(execute => "robespierre"), :immediate
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
       it "old-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             subscribes :run, resources(execute => "robespierre"), :immediate
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
       it "new-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :run, "execute[robespierre]", :immediate
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
       it "new-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             subscribes :run, "execute[robespierre]", :immediate
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
-
     end
+
     describe "sets the notification timing to immediate if specified as immediately" do
       it "old-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :run, resources(execute => "robespierre"), :immediately
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
       it "old-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             subscribes :run, resources(execute => "robespierre"), :immediately
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
       it "new-style notifications" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :run, "execute[robespierre]", :immediately
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
       it "new-style subscriptions" do
-        api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             subscribes :run, "execute[robespierre]", :immediately
           end
-        })).first[:timing].must_equal(:immediate)
+        })
+        expect(api.notifications(ast).first[:timing]).to eq :immediate
       end
     end
     it "passes unrecognised notification timings through unchanged" do
-      api.notifications(parse_ast(%q{
+      ast = parse_ast(%q{
         template "/etc/foo.conf" do
           notifies :run, resources(execute => "robespierre"), :forthwith
         end
-      })).first[:timing].must_equal(:forthwith)
+      })
+      expect(api.notifications(ast).first[:timing]).to eq :forthwith
     end
     describe "resource names as expressions" do
       describe "returns the AST for an embedded string" do
         it "old-style notifications" do
-          assert api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/foo.conf" do
               notifies :create, resources(:template => "/etc/bar/#{resource}.bar")
             end
-          })).first[:resource_name].respond_to?(:xpath),
-            "Expected resource_name with string expression to respond to #xpath"
+          })
+          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
         end
         it "new-style notifications" do
-          assert api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/foo.conf" do
               notifies :create, "template[/etc/bar/#{resource}.bar]"
             end
-          })).first[:resource_name].respond_to?(:xpath),
-            "Expected resource_name with string expression to respond to #xpath"
+          })
+          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
         end
         it "new-style notifications - complete resource_name" do
-          assert api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/foo.conf" do
               notifies :create, "template[#{template_path}]"
             end
-          })).first[:resource_name].respond_to?(:xpath),
-            "Expected resource_name with string expression to respond to #xpath"
+          })
+          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
         end
       end
       describe "returns the AST for node attribute" do
         it "old-style notifications" do
-          assert api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/foo.conf" do
               notifies :restart, resources(:service => node['foo']['service'])
             end
-          })).first[:resource_name].respond_to?(:xpath),
-            "Expected resource_name with node attribute to respond to #xpath"
+          })
+          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
         end
         it "new-style notifications" do
-          assert api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/foo.conf" do
               notifies :restart, "service[#{node['foo']['service']}]"
             end
-          })).first[:resource_name].respond_to?(:xpath),
-            "Expected resource_name with node attribute to respond to #xpath"
+          })
+          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
         end
       end
       describe "returns the AST for variable reference" do
         it "old-style notifications" do
-          assert api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/foo.conf" do
               notifies :restart, resources(:service => my_service)
             end
-          })).first[:resource_name].respond_to?(:xpath),
-            "Expected resource_name with var ref to respond to #xpath"
+          })
+          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
         end
         it "new-style notifications" do
-          assert api.notifications(parse_ast(%q{
+          ast = parse_ast(%q{
             template "/etc/foo.conf" do
               notifies :restart, "service[#{my_service}]"
             end
-          })).first[:resource_name].respond_to?(:xpath),
-            "Expected resource_name with var ref to respond to #xpath"
+          })
+          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
         end
       end
     end
     describe "mark style of notification" do
       it "specifies that the notification was in the old style" do
-        assert api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :restart, resources(:service => 'foo')
           end
-        })).first[:style].must_equal :old
+        })
+        expect(api.notifications(ast).first[:style]).to eq :old
       end
       it "specifies that the notification was in the new style" do
-        assert api.notifications(parse_ast(%q{
+        ast = parse_ast(%q{
           template "/etc/foo.conf" do
             notifies :restart, "service[foo]"
           end
-        })).first[:style].must_equal :new
+        })
+        expect(api.notifications(ast).first[:style]).to eq :new
       end
     end
   end
 
   describe "#read_ast" do
     it "raises if the file cannot be read" do
-      lambda { api.read_ast(nil) }.must_raise(TypeError)
+      expect { api.read_ast(nil) }.to raise_error TypeError
     end
   end
 
@@ -1598,10 +1589,10 @@ describe FoodCritic::Api do
       end.new
     end
     it "raises if the resource does not support XPath" do
-      lambda { api.resource_attribute(nil, "mode") }.must_raise ArgumentError
+      expect { api.resource_attribute(nil, "mode") }.to raise_error ArgumentError
     end
     it "raises if the attribute name is empty" do
-      lambda { api.resource_attribute(resource, "") }.must_raise ArgumentError
+      expect { api.resource_attribute(resource, "") }.to raise_error ArgumentError
     end
   end
 
@@ -1610,7 +1601,7 @@ describe FoodCritic::Api do
       api.resource_attributes(api.find_resources(parse_ast(str)).first)
     end
     it "raises if the resource does not support XPath" do
-      lambda { api.resource_attributes(nil) }.must_raise ArgumentError
+      expect { api.resource_attributes(nil) }.to raise_error ArgumentError
     end
     it "returns a string value for a literal string" do
       atts = str_to_atts(%q{
@@ -1618,8 +1609,7 @@ describe FoodCritic::Api do
           owner "root"
         end
       })
-      atts["owner"].wont_be_nil
-      atts["owner"].must_equal "root"
+      expect(atts["owner"]).to eq "root"
     end
     it "returns a truthy value for a literal true" do
       atts = str_to_atts(%q{
@@ -1627,8 +1617,7 @@ describe FoodCritic::Api do
           recursive true
         end
       })
-      atts["recursive"].wont_be_nil
-      atts["recursive"].must_equal true
+      expect(atts["recursive"]).to be true
     end
     it "returns a truthy value for a literal false" do
       atts = str_to_atts(%q{
@@ -1636,8 +1625,7 @@ describe FoodCritic::Api do
           recursive false
         end
       })
-      atts["recursive"].wont_be_nil
-      atts["recursive"].must_equal false
+      expect(atts["recursive"]).to be false
     end
     it "decodes numeric attributes correctly" do
       atts = str_to_atts(%q{
@@ -1646,8 +1634,7 @@ describe FoodCritic::Api do
           mode 0755
         end
       })
-      atts["mode"].wont_be_nil
-      atts["mode"].must_equal "0755"
+      expect(atts["mode"]).to eq "0755"
     end
     describe "block attributes" do
       it "includes attributes with brace block values in the result" do
@@ -1658,9 +1645,8 @@ describe FoodCritic::Api do
             only_if { File.exists?("/etc/bar") }
           end
         })
-        atts["only_if"].wont_be_nil
-        atts["only_if"].must_respond_to :xpath
-        atts["only_if"].name.must_equal "brace_block"
+        expect(atts["only_if"]).to respond_to :xpath
+        expect(atts["only_if"].name).to eq "brace_block"
       end
       it "includes attributes with do block values in the result" do
         atts = str_to_atts(%q{
@@ -1673,9 +1659,8 @@ describe FoodCritic::Api do
             end
           end
         })
-        atts["only_if"].wont_be_nil
-        atts["only_if"].must_respond_to :xpath
-        atts["only_if"].name.must_equal "do_block"
+        expect(atts["only_if"]).to respond_to :xpath
+        expect(atts["only_if"].name).to eq "do_block"
       end
       it "supports multiple block attributes" do
         atts = str_to_atts(%q{
@@ -1686,12 +1671,10 @@ describe FoodCritic::Api do
             not_if { true }
           end
         })
-        atts["only_if"].wont_be_nil
-        atts["only_if"].must_respond_to :xpath
-        atts["only_if"].name.must_equal "brace_block"
-        atts["not_if"].wont_be_nil
-        atts["not_if"].must_respond_to :xpath
-        atts["not_if"].name.must_equal "brace_block"
+        expect(atts["only_if"]).to respond_to :xpath
+        expect(atts["only_if"].name).to eq "brace_block"
+        expect(atts["not_if"]).to respond_to :xpath
+        expect(atts["not_if"].name).to eq "brace_block"
       end
       it "doesn't include method calls in ruby blocks" do
         atts = str_to_atts(%q{
@@ -1705,16 +1688,13 @@ describe FoodCritic::Api do
             not_if { false }
           end
         })
-        atts.keys.wont_include "foo"
-        atts["block"].wont_be_nil
-        atts["block"].must_respond_to :xpath
-        atts["block"].name.must_equal "do_block"
-        atts["only_if"].wont_be_nil
-        atts["only_if"].must_respond_to :xpath
-        atts["only_if"].name.must_equal "brace_block"
-        atts["not_if"].wont_be_nil
-        atts["not_if"].must_respond_to :xpath
-        atts["not_if"].name.must_equal "brace_block"
+        expect(atts.keys).to_not include "foo"
+        expect(atts["block"]).to respond_to :xpath
+        expect(atts["block"].name).to eq "do_block"
+        expect(atts["only_if"]).to respond_to :xpath
+        expect(atts["only_if"].name).to eq "brace_block"
+        expect(atts["not_if"]).to respond_to :xpath
+        expect(atts["not_if"].name).to eq "brace_block"
       end
       it "includes notifications in the result" do
         atts = str_to_atts(%q{
@@ -1722,9 +1702,8 @@ describe FoodCritic::Api do
             notifies :restart, "service[apache]"
           end
         })
-        atts["notifies"].wont_be_nil
-        atts["notifies"].must_respond_to :xpath
-        atts["notifies"].name.must_equal "args_add_block"
+        expect(atts["notifies"]).to respond_to :xpath
+        expect(atts["notifies"].name).to eq "args_add_block"
       end
       it "includes old-style notifications in the result" do
         atts = str_to_atts(%q{
@@ -1732,90 +1711,91 @@ describe FoodCritic::Api do
             notifies :restart, resources(:service => "apache")
           end
         })
-        atts["notifies"].wont_be_nil
-        atts["notifies"].must_respond_to :xpath
-        atts["notifies"].name.must_equal "args_add_block"
+        expect(atts["notifies"]).to respond_to :xpath
+        expect(atts["notifies"].name).to eq "args_add_block"
       end
     end
   end
 
   describe "#resource_attributes_by_type" do
     it "raises if the ast does not support XPath" do
-      lambda { api.resource_attributes_by_type(nil) }.must_raise ArgumentError
+      expect { api.resource_attributes_by_type(nil) }.to raise_error ArgumentError
     end
     it "returns an empty hash if there are no resources" do
-      ast = MiniTest::Mock.new.expect :xpath, [], [String]
-      api.resource_attributes_by_type(ast).keys.must_be_empty
+      ast = double()
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
+      expect(api.resource_attributes_by_type(ast)).to be_empty
     end
   end
 
   describe "#resource_name" do
     it "raises if the resource does not support XPath" do
-      lambda { api.resource_name("foo") }.must_raise ArgumentError
+      expect { api.resource_name("foo") }.to raise_error ArgumentError
     end
     it "returns the resource name for a resource" do
-      ast = MiniTest::Mock.new
-      ast.expect :xpath, "bob", [String]
-      api.resource_name(ast).must_equal "bob"
+      ast = double()
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return("bob")
+      expect(api.resource_name(ast)).to eq "bob"
     end
   end
 
   describe "#resources_by_type" do
     it "raises if the ast does not support XPath" do
-      lambda { api.resources_by_type(nil) }.must_raise ArgumentError
+      expect { api.resources_by_type(nil) }.to raise_error ArgumentError
     end
     it "returns an empty hash if there are no resources" do
-      ast = MiniTest::Mock.new.expect :xpath, [], [String]
-      api.resources_by_type(ast).keys.must_be_empty
+      ast = double()
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
+      expect(api.resources_by_type(ast)).to be_empty
     end
   end
 
   describe "#resource_type" do
     it "raises if the resource does not support XPath" do
-      lambda { api.resource_type(nil) }.must_raise ArgumentError
+      expect { api.resource_type(nil) }.to raise_error ArgumentError
     end
     it "raises if the resource type cannot be determined" do
-      ast = MiniTest::Mock.new
-      ast.expect :xpath, "", [String]
-      lambda { api.resource_type(ast) }.must_raise ArgumentError
+      ast = double()
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return("")
+      expect { api.resource_type(ast) }.to raise_error ArgumentError
     end
     it "returns the resource type for a resource" do
-      ast = MiniTest::Mock.new
-      ast.expect :xpath, "directory", [String]
-      api.resource_type(ast).must_equal "directory"
+      ast = double()
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return("directory")
+      expect(api.resource_type(ast)).to eq "directory"
     end
   end
 
   describe "#ruby_code?" do
     it "says a nil is not ruby code" do
-      refute api.ruby_code?(nil)
+      expect(api.ruby_code?(nil)).to be_falsey
     end
     it "says an empty string is not ruby code" do
-      refute api.ruby_code?("")
+      expect(api.ruby_code?("")).to be_falsey
     end
     it "coerces arguments to a string" do
-      assert api.ruby_code?(%w{foo bar})
+      expect(api.ruby_code?(%w{foo bar})).to be_truthy
     end
     it "returns true for a snippet of ruby code" do
-      assert api.ruby_code?("assert api.ruby_code?(nil)")
+      expect(api.ruby_code?("assert api.ruby_code?(nil)")).to be_truthy
     end
     it "returns false for a unix command" do
-      refute api.ruby_code?("find -type f -print")
+      expect(api.ruby_code?("find -type f -print")).to be_falsey
     end
   end
 
   describe "#searches" do
-    let(:ast) { MiniTest::Mock.new }
+    let(:ast) { double() }
     it "returns empty if the AST does not support XPath expressions" do
-      api.searches("not-an-ast").must_be_empty
+      expect(api.searches("not-an-ast")).to be_empty
     end
     it "returns empty if the AST has no elements" do
-      ast.expect :xpath, [], [String]
-      api.searches(ast).must_be_empty
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
+      expect(api.searches(ast)).to be_empty
     end
     it "returns the AST elements for each use of search" do
-      ast.expect :xpath, ["ident"], [String]
-      api.searches(ast).must_equal ["ident"]
+      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(["ident"])
+      expect(api.searches(ast)).to eq ["ident"]
     end
   end
 
@@ -1824,20 +1804,19 @@ describe FoodCritic::Api do
       api.standard_cookbook_subdirs.each { |s| s }
     end
     it "is sorted in alphabetical order" do
-      api.standard_cookbook_subdirs.must_equal(
-        api.standard_cookbook_subdirs.sort)
+      expect(api.standard_cookbook_subdirs).to eq api.standard_cookbook_subdirs.sort
     end
     it "includes the directories generated by knife create cookbook" do
       %w{attributes definitions files libraries providers recipes resources
          templates}.each do |dir|
-        api.standard_cookbook_subdirs.must_include dir
+        expect(api.standard_cookbook_subdirs).to include dir
       end
     end
     it "does not include the spec directory" do
-      api.standard_cookbook_subdirs.wont_include "spec"
+      expect(api.standard_cookbook_subdirs).to_not include "spec"
     end
     it "does not include a subdirectory of a subdirectory" do
-      api.standard_cookbook_subdirs.wont_include "default"
+      expect(api.standard_cookbook_subdirs).to_not include "default"
     end
   end
 
@@ -1846,60 +1825,60 @@ describe FoodCritic::Api do
       api.supported_platforms(parse_ast(str))
     end
     it "returns an empty if no platforms are specified as supported" do
-      supports("name 'example'").must_be_empty
+      expect(supports("name 'example'")).to be_empty
     end
     describe :ignored_support_declarations do
       it "should ignore supports without any arguments" do
-        supports("supports").must_be_empty
+        expect(supports("supports")).to be_empty
       end
       it "should ignore supports where an embedded string expression is used" do
-        supports('supports "red#{hat}"').must_be_empty
+        expect(supports('supports "red#{hat}"')).to be_empty
       end
     end
     it "returns the supported platform names if multiple are given" do
-      supports(%q{
+      expect(supports(%q{
         supports "redhat"
         supports "scientific"
-      }).must_equal([{ :platform => "redhat", :versions => [] },
-               { :platform => "scientific", :versions => [] }])
+      })).to eq [{ :platform => "redhat", :versions => [] },
+                 { :platform => "scientific", :versions => [] }]
     end
     it "sorts the platform names in alphabetical order" do
-      supports(%q{
+      expect(supports(%q{
         supports "scientific"
         supports "redhat"
-      }).must_equal([{ :platform => "redhat", :versions => [] },
-               { :platform => "scientific", :versions => [] }])
+      })).to eq [{ :platform => "redhat", :versions => [] },
+                 { :platform => "scientific", :versions => [] }]
     end
     it "handles support declarations that include version constraints" do
-      supports(%q{
+      expect(supports(%q{
         supports "redhat", '>= 6'
-      }).must_equal([{ :platform => "redhat", :versions => [">= 6"] }])
+      })).to eq [{ :platform => "redhat", :versions => [">= 6"] }]
     end
     it "handles support declarations that include obsoleted version constraints" do
-      supports(%q{
+      expect(supports(%q{
         supports 'redhat', '> 5.0', '< 7.0'
         supports 'scientific', '> 5.0', '< 6.0'
-      }).must_equal([{ :platform => "redhat", :versions => ["> 5.0", "< 7.0"] },
-                     { :platform => "scientific", :versions => ["> 5.0", "< 6.0"] }])
+      })).to eq [{ :platform => "redhat", :versions => ["> 5.0", "< 7.0"] },
+                 { :platform => "scientific", :versions => ["> 5.0", "< 6.0"] }]
     end
     it "normalises platform symbol references to strings" do
-      supports(%q{
+      expect(supports(%q{
         supports :ubuntu
-      }).must_equal([{ :platform => "ubuntu", :versions => [] }])
+      })).to eq [{ :platform => "ubuntu", :versions => [] }]
     end
     it "handles support declarations as symbols that include version constraints" do
-      supports(%q{
+      expect(supports(%q{
         supports :redhat, '>= 6'
-      }).must_equal([{ :platform => "redhat", :versions => [">= 6"] }])
+      })).to eq [{ :platform => "redhat", :versions => [">= 6"] }]
     end
     it "understands support declarations that use word lists" do
-      supports(%q{
+      expect(supports(%q{
         %w{redhat centos fedora}.each do |os|
-	  supports os
-	end
-      }).must_equal([{ :platform => "centos", :versions => [] },
-                     { :platform => "fedora", :versions => [] },
-               { :platform => "redhat", :versions => [] }])
+          supports os
+        end
+      })).to eq [{ :platform => "centos", :versions => [] },
+                 { :platform => "fedora", :versions => [] },
+                 { :platform => "redhat", :versions => [] }]
     end
   end
 
@@ -1920,67 +1899,44 @@ describe FoodCritic::Api do
 
     it "returns the path of the containing template when there are no partials" do
       ast = parse_ast("<%= foo.erb %>")
-      api.stub :read_ast, ast do
-        api.templates_included(["foo.erb"], "foo.erb").must_equal ["foo.erb"]
-      end
+      expect(api).to receive(:read_ast).with("foo.erb").and_return(ast)
+      expect(api.templates_included(["foo.erb"], "foo.erb")).to eq ["foo.erb"]
     end
 
     it "returns the path of the containing template and any partials" do
-      api.instance_variable_set(:@asts, {
-        :main =>  template_ast('<%= render "included_1.erb" %>
-                                <%= render "included_2.erb" %>'),
-        :ok => template_ast("<%= @foo %>"),
-      })
-      def api.read_ast(path)
-        case path
-          when /main/ then @asts[:main]
-          else @asts[:ok]
-        end
-      end
-      api.templates_included(all_templates,
-        "templates/default/main.erb").must_equal(
-          ["templates/default/main.erb",
-           "templates/default/included_1.erb",
-           "templates/default/included_2.erb"]
-      )
+      main_ast = template_ast('<%= render "included_1.erb" %>
+                                <%= render "included_2.erb" %>')
+      inner_ast = template_ast("<%= @foo %>")
+      expect(api).to receive(:read_ast).with(/main/).and_return(main_ast)
+      expect(api).to receive(:read_ast).and_return(inner_ast).twice
+      expect(api.templates_included(all_templates, "templates/default/main.erb")).to eq [
+        "templates/default/main.erb",
+        "templates/default/included_1.erb",
+        "templates/default/included_2.erb",
+      ]
     end
 
     it "doesn't mistake render options for partial template names" do
-      api.instance_variable_set(:@asts, {
-        :main => template_ast('<%= render "included_1.erb",
-                               :variables => {:foo => "included_2.erb"} %>'),
-        :ok => template_ast("<%= @foo %>"),
-      })
-      def api.read_ast(path)
-        case path
-          when /main/ then @asts[:main]
-          else @asts[:ok]
-        end
-      end
-      api.templates_included(all_templates,
-        "templates/default/main.erb").must_equal(
-          ["templates/default/main.erb", "templates/default/included_1.erb"]
-      )
+      main_ast = template_ast('<%= render "included_1.erb",
+                               :variables => {:foo => "included_2.erb"} %>')
+      inner_ast = template_ast("<%= @foo %>")
+      expect(api).to receive(:read_ast).with(/main/).and_return(main_ast)
+      expect(api).to receive(:read_ast).and_return(inner_ast)
+      expect(api.templates_included(all_templates, "templates/default/main.erb")).to eq [
+        "templates/default/main.erb",
+        "templates/default/included_1.erb",
+      ]
     end
 
     it "raises if included partials have cycles" do
-      api.instance_variable_set(:@asts, {
-        :main => template_ast('<%= render "included_1.erb" %>
-                                <%= render "included_2.erb" %>'),
-        :loop => template_ast('<%= render "main.erb" %>'),
-        :ok => template_ast("<%= foo %>"),
-      })
-      def api.read_ast(path)
-        case path
-          when /main/ then @asts[:main]
-          when /included_2/ then @asts[:loop]
-          else @asts[:ok]
-        end
-      end
-      err = lambda do
-        api.templates_included(all_templates, "templates/default/main.erb")
-      end.must_raise(FoodCritic::Api::RecursedTooFarError)
-      err.message.must_equal "templates/default/main.erb"
+      main_ast = template_ast('<%= render "included_1.erb" %>
+                                <%= render "included_2.erb" %>')
+      loop_ast = template_ast('<%= render "main.erb" %>')
+      inner_ast = template_ast("<%= foo %>")
+      expect(api).to receive(:read_ast).with(/main/).and_return(main_ast).at_least(:once)
+      expect(api).to receive(:read_ast).with(/included_2/).and_return(loop_ast).at_least(:once)
+      expect(api).to receive(:read_ast).and_return(inner_ast).at_least(:once)
+      expect { api.templates_included(all_templates, "templates/default/main.erb") }.to raise_error(FoodCritic::Api::RecursedTooFarError, "templates/default/main.erb")
     end
   end