foodcritic 10.2.2 → 10.3.0

data/spec/functional/fc052_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC052" do
+  context "with a cookbook with a metadata file that does contain the suggests keyword" do
+    metadata_file "suggests 'runit'"
+    it { is_expected.to violate_rule("FC052") }
+  end
+
+  context "with a cookbook with a metadata file that does not contain the suggests keyword" do
+    metadata_file
+    it { is_expected.to_not violate_rule("FC052") }
+  end
+end

data/spec/functional/fc053_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC053" do
+  context "with a cookbook with a metadata file that does contain the recommends keyword" do
+    metadata_file "recommends 'runit'"
+    it { is_expected.to violate_rule("FC053") }
+  end
+
+  context "with a cookbook with a metadata file that does not contain the recommends keyword" do
+    metadata_file
+    it { is_expected.to_not violate_rule("FC053") }
+  end
+end

data/spec/functional/fc055_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+
+describe "FC055" do
+  context "with a cookbook with a metadata file that does not specify a maintainer" do
+    metadata_file "name 'my_cookbook'"
+    it { is_expected.to violate_rule("FC055") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a maintainer" do
+    metadata_file "maintainer 'Some Person'"
+    it { is_expected.to_not violate_rule("FC055") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a maintainer as an expression" do
+    metadata_file("maintainer an(expression)")
+    it { is_expected.to_not violate_rule("FC055") }
+  end
+end

data/spec/functional/fc056_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+
+describe "FC056" do
+  context "with a cookbook with a metadata file that does not specify a maintainer_email" do
+    metadata_file
+    it { is_expected.to violate_rule("FC056") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a maintainer_email" do
+    metadata_file "maintainer_email 'foo@example.com'"
+    it { is_expected.to_not violate_rule("FC056") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a maintainer_email as an expression" do
+    metadata_file("maintainer_email an(expression)")
+    it { is_expected.to_not violate_rule("FC056") }
+  end
+end

data/spec/functional/fc061_spec.rb

@@ -0,0 +1,48 @@
+require "spec_helper"
+
+describe "FC061" do
+  context "with a cookbook with metadata that includes the version keyword and a valid version string" do
+    metadata_file("version '1.2.3'")
+    it { is_expected.not_to violate_rule("FC061") }
+  end
+
+  context "with a cookbook with metadata that includes the version keyword and a valid version string with double quotes" do
+    metadata_file('version "1.2.3"')
+    it { is_expected.not_to violate_rule("FC061") }
+  end
+
+  context "with a cookbook with metadata that includes the version keyword and a valid x.y version string" do
+    metadata_file("version '1.2'")
+    it { is_expected.not_to violate_rule("FC061") }
+  end
+
+  context "with a cookbook with metadata that does not include a version keyword" do
+    metadata_file("name 'something'")
+    it { is_expected.not_to violate_rule("FC061") }
+  end
+
+  context "with a cookbook with metadata that includes the version keyword and an invalid version string" do
+    metadata_file("version 'one'")
+    it { is_expected.to violate_rule("FC061") }
+  end
+
+  context "with a cookbook metadata that includes the version keyword and an invalid single digit version string" do
+    metadata_file("version '1'")
+    it { is_expected.to violate_rule("FC061") }
+  end
+
+  context "with a cookbook metadata that includes the version keyword and an invalid four digit version string" do
+    metadata_file("version '1.2.3.4'")
+    it { is_expected.to violate_rule("FC061") }
+  end
+
+  context "with a cookbook metadata that includes the version keyword that uses string interpolation" do
+    metadata_file('patch = 3\nversion "1.2.#{patch}"')
+    it { is_expected.not_to violate_rule("FC061") }
+  end
+
+  context "with a cookbook metadata that includes the version keyword that is not a string literal" do
+    metadata_file('v = "1.2.3"\nversion v')
+    it { is_expected.not_to violate_rule("FC061") }
+  end
+end

data/spec/functional/fc062_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC062" do
+  context "with a cookbook with metadata that includes the version keyword and a valid version string" do
+    metadata_file("version '1.2.3'")
+    it { is_expected.not_to violate_rule("FC062") }
+  end
+
+  context "with a cookbook with metadata that does not include a version keyword" do
+    metadata_file
+    it { is_expected.to violate_rule("FC062") }
+  end
+end

data/spec/functional/fc063_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+
+describe "FC063" do
+  context "with a cookbook with a metadata file that depends on itself" do
+    metadata_file "name 'something'\ndepends 'something'"
+    it { is_expected.to violate_rule("FC063") }
+  end
+
+  context "with a cookbook with a metadata file that depends on a cookbook, but not itself" do
+    metadata_file "name 'something'\ndepends 'another_thing'"
+    it { is_expected.to_not violate_rule("FC063") }
+  end
+
+  context "with a cookbook with a metadata file that doesn't depend on any cookbooks" do
+    metadata_file "name 'something'"
+    it { is_expected.to_not violate_rule("FC063") }
+  end
+end

data/spec/functional/fc064_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC064" do
+  context "with a cookbook with a metadata file that does not specify issues_url" do
+    metadata_file
+    it { is_expected.to violate_rule("FC064") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a issues_url" do
+    metadata_file "issues_url 'http://wwww.something.com/'"
+    it { is_expected.to_not violate_rule("FC064") }
+  end
+end

data/spec/functional/fc065_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC065" do
+  context "with a cookbook with a metadata file that does not specify source_url" do
+    metadata_file
+    it { is_expected.to violate_rule("FC065") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a source_url" do
+    metadata_file "source_url 'http://wwww.something.com/'"
+    it { is_expected.to_not violate_rule("FC065") }
+  end
+end

data/spec/functional/fc066_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC066" do
+  context "with a cookbook with a metadata file that does not specify chef_version" do
+    metadata_file "name 'my_cookbook'"
+    it { is_expected.to violate_rule("FC066") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a chef_version" do
+    metadata_file "chef_version '>= 12.1'"
+    it { is_expected.to_not violate_rule("FC066") }
+  end
+end

data/spec/functional/fc067_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC067" do
+  context "with a cookbook with a metadata file that does not specify supports" do
+    metadata_file "name 'my_cookbook'"
+    it { is_expected.to violate_rule("FC067") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a supported platform (anything)" do
+    metadata_file "supports 'some_os'"
+    it { is_expected.to_not violate_rule("FC067") }
+  end
+end

data/spec/functional/fc068_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC068" do
+  context "with a cookbook with a metadata file that does not specify the license" do
+    metadata_file "name 'my_cookbook'"
+    it { is_expected.to violate_rule("FC068") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a license (anything)" do
+    metadata_file "license 'My Super Cool License'"
+    it { is_expected.to_not violate_rule("FC068") }
+  end
+end

data/spec/functional/fc069_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe "FC069" do
+  context "with a cookbook with a metadata file that specifies a license generated by knife cookbook create" do
+    metadata_file "license 'Apache 2.0'"
+    it { is_expected.to violate_rule("FC069") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a license generated by chef generate cookbook" do
+    metadata_file "license 'apache_2'"
+    it { is_expected.to violate_rule("FC069") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a valid SPDX license" do
+    metadata_file "license 'Apache-2.0'"
+    it { is_expected.to_not violate_rule("FC069") }
+  end
+
+  context "with a cookbook with a metadata file that specifies ChefDK's non-SPDX all rights reserved string" do
+    metadata_file "license 'All Rights Reserved'"
+    it { is_expected.to_not violate_rule("FC069") }
+  end
+end

data/spec/functional/fc070_spec.rb

@@ -0,0 +1,38 @@
+require "spec_helper"
+
+describe "FC070" do
+  context "with a cookbook with a metadata file specifying a single valid supports statement" do
+    metadata_file "supports 'ubuntu'"
+    it { is_expected.to_not violate_rule("FC070") }
+  end
+
+  context "with a cookbook with a metadata file specifying multiple valid supports statements" do
+    metadata_file "%w(ubuntu debian fedora).each do |plat|\nsupports plat\nend"
+    it { is_expected.to_not violate_rule("FC070") }
+  end
+
+  context "with a cookbook with a metadata file specifying a single invalid supports statement" do
+    metadata_file "supports 'aws'"
+    it { is_expected.to violate_rule("FC070") }
+  end
+
+  context "with a cookbook with a metadata file specifying multiple invalid supports statements" do
+    metadata_file "%w(aws oel rhel).each do |plat|\nsupports plat\nend"
+    it { is_expected.to violate_rule("FC070") }
+  end
+
+  context "with a cookbook with a metadata file specifying a mix of valid and invalid supports statements" do
+    metadata_file "%w(aws oracle scientific).each do |plat|\nsupports plat\nend"
+    it { is_expected.to violate_rule("FC070") }
+  end
+
+  context "with a cookbook with a metadata file specifying a valid supports platform, but uppercase" do
+    metadata_file "supports 'UBUNTU'"
+    it { is_expected.to violate_rule("FC070") }
+  end
+
+  context "with a cookbook with a metadata file specifying a valid supports platform, but with a version string" do
+    metadata_file "supports 'ubuntu >= 16.04'"
+    it { is_expected.to violate_rule("FC070") }
+  end
+end

data/spec/functional/fc071_spec.rb

@@ -0,0 +1,14 @@
+require "spec_helper"
+
+describe "FC071" do
+  context "with a cookbook with a LICENSE file" do
+    metadata_file "name 'mycookbook'"
+    file("LICENSE")
+    it { is_expected.not_to violate_rule("FC071") }
+  end
+
+  context "with a cookbook without a LICENSE file" do
+    metadata_file "name 'mycookbook'"
+    it { is_expected.to violate_rule("FC071") }
+  end
+end

data/spec/functional/fc072_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC072" do
+  context "with a cookbook with a metadata file that contains an attribute keyword" do
+    metadata_file "attribute 'something/something',\n    display_name: 'something tuneable',\n    description: 'This tunes something',\n    default: 'none'"
+    it { is_expected.to violate_rule("FC072") }
+  end
+
+  context "with a cookbook with a metadata file that doesn't contain an attribute keyword" do
+    metadata_file
+    it { is_expected.not_to violate_rule("FC072") }
+  end
+end

data/spec/functional/fc073_spec.rb

@@ -0,0 +1,56 @@
+require "spec_helper"
+
+describe "FC073" do
+  context "with an empty cookbook" do
+    metadata_file
+    it { is_expected.to_not violate_rule("FC073") }
+  end
+
+  context "with only attributes/default.rb" do
+    metadata_file
+    attributes_file
+    it { is_expected.to_not violate_rule("FC073") }
+  end
+
+  context "with only attributes.rb" do
+    metadata_file
+    file "attributes.rb"
+    it { is_expected.to_not violate_rule("FC073") }
+  end
+
+  context "with both attributes.rb and attributes/default.rb" do
+    metadata_file
+    file "attributes.rb"
+    attributes_file
+    it { is_expected.to violate_rule("FC073").in("attributes/default.rb") }
+  end
+
+  context "with only recipes/default.rb" do
+    metadata_file
+    recipe_file
+    it { is_expected.to_not violate_rule("FC073") }
+  end
+
+  context "with only recipe.rb" do
+    metadata_file
+    file "recipe.rb"
+    it { is_expected.to_not violate_rule("FC073") }
+  end
+
+  context "with both recipe.rb and recipes/default.rb" do
+    metadata_file
+    file "recipe.rb"
+    recipe_file
+    it { is_expected.to violate_rule("FC073").in("recipes/default.rb") }
+  end
+
+  context "with all four" do
+    metadata_file
+    file "attributes.rb"
+    file "recipe.rb"
+    attributes_file
+    recipe_file
+    it { is_expected.to violate_rule("FC073").in("attributes/default.rb") }
+    it { is_expected.to violate_rule("FC073").in("recipes/default.rb") }
+  end
+end

data/spec/functional/fc074_spec.rb

@@ -0,0 +1,39 @@
+require "spec_helper"
+
+describe "FC074" do
+
+  context "with a cookbook with a LWRP that includes a default_action" do
+    resource_file <<-EOH
+      actions :create, :remove
+      default_action :create
+
+      attribute :name, String, name_attribute: true
+    EOH
+    it { is_expected.to_not violate_rule("FC074") }
+  end
+
+  context "with a cookbook with a LWRP that includes a non-DSL default_action" do
+    resource_file <<-EOH
+      actions :create, :remove,
+
+      def initialize(*args)
+        super
+        @action = :create
+      end
+
+      attribute :name, String, name_attribute: true
+    EOH
+    it { is_expected.to violate_rule("FC074") }
+  end
+
+  context "with a custom resource" do
+    resource_file <<-EOH
+      property :name, String, name_property: true
+
+      action :create do
+        cookbook_file "/etc/something"
+      end
+    EOH
+    it { is_expected.to_not violate_rule("FC074") }
+  end
+end

data/spec/functional/fc075_spec.rb

@@ -0,0 +1,41 @@
+require "spec_helper"
+
+describe "FC075" do
+
+  context "with a cookbook with recipe that uses node.save" do
+    recipe_file "node.save"
+    it { is_expected.to violate_rule("FC075") }
+  end
+
+  context "with a cookbook with recipe that doesn't use node.save" do
+    recipe_file
+    it { is_expected.not_to violate_rule("FC075") }
+  end
+
+  context "with a cookbook with recipe that includes node['save']" do
+    recipe_file("node['save']")
+    it { is_expected.not_to violate_rule("FC075") }
+  end
+
+  context "with a cookbook with a library that uses node.save" do
+    library_file <<-EOH
+      module CookbookHelper
+        def some_method
+          node.save
+        end
+      end
+    EOH
+    it { is_expected.to violate_rule("FC075") }
+  end
+
+  context "with a cookbook with a custom resource that uses node.save" do
+    resource_file <<-EOH
+      property :name, String, name_property: true
+
+      action :create do
+        node.save
+      end
+    EOH
+    it { is_expected.to violate_rule("FC075") }
+  end
+end