foodcritic 10.2.2 → 10.3.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (165) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +24 -2
  3. data/Gemfile +2 -1
  4. data/README.md +7 -1
  5. data/Rakefile +55 -35
  6. data/bin/foodcritic +1 -7
  7. data/features/024_check_for_missing_platforms.feature +3 -4
  8. data/features/continuous_integration_support.feature +2 -2
  9. data/features/step_definitions/cookbook_steps.rb +24 -285
  10. data/features/support/command_helpers.rb +3 -0
  11. data/foodcritic.gemspec +12 -6
  12. data/lib/foodcritic/api.rb +14 -2
  13. data/lib/foodcritic/command_line.rb +8 -0
  14. data/lib/foodcritic/linter.rb +1 -1
  15. data/lib/foodcritic/output.rb +17 -3
  16. data/lib/foodcritic/rules/fc008.rb +8 -6
  17. data/lib/foodcritic/rules/fc024.rb +1 -1
  18. data/lib/foodcritic/rules/fc045.rb +1 -8
  19. data/lib/foodcritic/rules/fc068.rb +1 -1
  20. data/lib/foodcritic/rules/fc069.rb +365 -0
  21. data/lib/foodcritic/rules/fc070.rb +63 -0
  22. data/lib/foodcritic/rules/fc071.rb +6 -0
  23. data/lib/foodcritic/rules/fc072.rb +6 -0
  24. data/lib/foodcritic/rules/fc073.rb +17 -0
  25. data/lib/foodcritic/rules/fc074.rb +10 -0
  26. data/lib/foodcritic/rules/fc075.rb +9 -0
  27. data/lib/foodcritic/version.rb +1 -1
  28. data/spec/functional/fc001_spec.rb +67 -0
  29. data/spec/functional/fc008_spec.rb +33 -0
  30. data/spec/functional/fc011_spec.rb +20 -0
  31. data/spec/functional/fc012_spec.rb +20 -0
  32. data/spec/functional/fc016_spec.rb +48 -0
  33. data/spec/functional/fc028_spec.rb +48 -0
  34. data/spec/functional/fc029_spec.rb +33 -0
  35. data/spec/functional/fc031_spec.rb +14 -0
  36. data/spec/functional/fc042_spec.rb +13 -0
  37. data/spec/functional/fc045_spec.rb +18 -0
  38. data/spec/functional/fc052_spec.rb +13 -0
  39. data/spec/functional/fc053_spec.rb +13 -0
  40. data/spec/functional/fc055_spec.rb +18 -0
  41. data/spec/functional/fc056_spec.rb +18 -0
  42. data/spec/functional/fc061_spec.rb +48 -0
  43. data/spec/functional/fc062_spec.rb +13 -0
  44. data/spec/functional/fc063_spec.rb +18 -0
  45. data/spec/functional/fc064_spec.rb +13 -0
  46. data/spec/functional/fc065_spec.rb +13 -0
  47. data/spec/functional/fc066_spec.rb +13 -0
  48. data/spec/functional/fc067_spec.rb +13 -0
  49. data/spec/functional/fc068_spec.rb +13 -0
  50. data/spec/functional/fc069_spec.rb +23 -0
  51. data/spec/functional/fc070_spec.rb +38 -0
  52. data/spec/functional/fc071_spec.rb +14 -0
  53. data/spec/functional/fc072_spec.rb +13 -0
  54. data/spec/functional/fc073_spec.rb +56 -0
  55. data/spec/functional/fc074_spec.rb +39 -0
  56. data/spec/functional/fc075_spec.rb +41 -0
  57. data/spec/functional/root_aliases_spec.rb +13 -0
  58. data/spec/regression/cookbooks.txt +0 -2
  59. data/spec/regression/expected/activemq.txt +5 -0
  60. data/spec/regression/expected/apparmor.txt +8 -0
  61. data/spec/regression/expected/apt.txt +12 -0
  62. data/spec/regression/expected/aws.txt +13 -0
  63. data/spec/regression/expected/bluepill.txt +6 -0
  64. data/spec/regression/expected/boost.txt +6 -0
  65. data/spec/regression/expected/build-essential.txt +6 -0
  66. data/spec/regression/expected/chef-client.txt +13 -0
  67. data/spec/regression/expected/chef-server.txt +12 -0
  68. data/spec/regression/expected/chef.txt +36 -0
  69. data/spec/regression/expected/chef_handler.txt +7 -0
  70. data/spec/regression/expected/cron.txt +7 -0
  71. data/spec/regression/expected/database.txt +13 -0
  72. data/spec/regression/expected/dmg.txt +12 -0
  73. data/spec/regression/expected/drbd.txt +25 -0
  74. data/spec/regression/expected/dynect.txt +29 -0
  75. data/spec/regression/expected/erlang.txt +4 -0
  76. data/spec/regression/expected/fail2ban.txt +4 -0
  77. data/spec/regression/expected/firewall.txt +12 -0
  78. data/spec/regression/expected/gecode.txt +8 -0
  79. data/spec/regression/expected/gems.txt +31 -0
  80. data/spec/regression/expected/gunicorn.txt +9 -0
  81. data/spec/regression/expected/heartbeat.txt +8 -0
  82. data/spec/regression/expected/homebrew.txt +8 -0
  83. data/spec/regression/expected/iis.txt +30 -0
  84. data/spec/regression/expected/iptables.txt +8 -0
  85. data/spec/regression/expected/jetty.txt +11 -0
  86. data/spec/regression/expected/jpackage.txt +8 -0
  87. data/spec/regression/expected/keepalived.txt +4 -0
  88. data/spec/regression/expected/kickstart.txt +14 -0
  89. data/spec/regression/expected/logwatch.txt +4 -0
  90. data/spec/regression/expected/lvm.txt +12 -0
  91. data/spec/regression/expected/maradns.txt +13 -0
  92. data/spec/regression/expected/maven.txt +9 -0
  93. data/spec/regression/expected/memcached.txt +30 -0
  94. data/spec/regression/expected/motd-tail.txt +4 -0
  95. data/spec/regression/expected/mysql.txt +12 -0
  96. data/spec/regression/expected/ohai.txt +6 -0
  97. data/spec/regression/expected/openldap.txt +10 -0
  98. data/spec/regression/expected/openssh.txt +4 -0
  99. data/spec/regression/expected/openssl.txt +5 -0
  100. data/spec/regression/expected/partial_search.txt +5 -0
  101. data/spec/regression/expected/passenger_apache2.txt +29 -0
  102. data/spec/regression/expected/perl.txt +11 -0
  103. data/spec/regression/expected/php.txt +9 -0
  104. data/spec/regression/expected/postfix.txt +6 -0
  105. data/spec/regression/expected/powershell.txt +8 -0
  106. data/spec/regression/expected/resolver.txt +6 -0
  107. data/spec/regression/expected/rsync.txt +10 -0
  108. data/spec/regression/expected/rsyslog.txt +8 -0
  109. data/spec/regression/expected/sql_server.txt +4 -0
  110. data/spec/regression/expected/sqlite.txt +4 -0
  111. data/spec/regression/expected/ssh_known_hosts.txt +5 -0
  112. data/spec/regression/expected/stompserver.txt +5 -0
  113. data/spec/regression/expected/subversion.txt +5 -0
  114. data/spec/regression/expected/sudo.txt +8 -0
  115. data/spec/regression/expected/tftp.txt +5 -0
  116. data/spec/regression/expected/tomcat.txt +8 -0
  117. data/spec/regression/expected/transmission.txt +10 -0
  118. data/spec/regression/expected/ubuntu.txt +4 -0
  119. data/spec/regression/expected/ufw.txt +9 -0
  120. data/spec/regression/expected/unicorn.txt +6 -0
  121. data/spec/regression/expected/users.txt +7 -0
  122. data/spec/regression/expected/vim.txt +6 -0
  123. data/spec/regression/expected/webpi.txt +7 -0
  124. data/spec/regression/expected/whitelist-node-attrs.txt +6 -0
  125. data/spec/regression/expected/windows.txt +57 -0
  126. data/spec/regression/expected/wix.txt +4 -0
  127. data/spec/regression/expected/xfs.txt +4 -0
  128. data/spec/regression/expected/xml.txt +4 -0
  129. data/spec/regression/expected/yum.txt +17 -0
  130. data/spec/regression/expected/zlib.txt +4 -0
  131. data/spec/regression/expected/zsh.txt +4 -0
  132. data/spec/regression/regression_spec.rb +16 -10
  133. data/spec/spec_helper.rb +115 -10
  134. data/spec/{foodcritic → unit}/api_spec.rb +549 -593
  135. data/spec/{foodcritic → unit}/chef_spec.rb +15 -15
  136. data/spec/unit/command_line_spec.rb +122 -0
  137. data/spec/{foodcritic → unit}/domain_spec.rb +12 -12
  138. data/spec/{foodcritic → unit}/linter_spec.rb +20 -35
  139. data/spec/{foodcritic → unit}/template_spec.rb +13 -13
  140. metadata +161 -33
  141. data/features/001_check_node_access.feature +0 -60
  142. data/features/008_check_for_boilerplate_metadata.feature +0 -25
  143. data/features/011_check_for_markdown_readme.feature +0 -20
  144. data/features/012_check_for_deprecated_readme_format.feature +0 -20
  145. data/features/016_check_for_no_lwrp_default_action.feature +0 -25
  146. data/features/028_check_for_incorrect_platform_method.feature +0 -20
  147. data/features/029_check_for_no_leading_cookbook_name.feature +0 -18
  148. data/features/031_check_for_metadata_existence.feature +0 -15
  149. data/features/042_check_for_deprecated_require_recipe.feature +0 -15
  150. data/features/045_check_for_cookbook_name_in_metadata.feature +0 -20
  151. data/features/052_check_for_metadata_using_suggests_keyword.feature +0 -15
  152. data/features/053_check_for_metadata_using_recommends_keyword.feature +0 -15
  153. data/features/055_check_for_no_maintainer.feature +0 -25
  154. data/features/056_check_for_no_maintainer_email.feature +0 -25
  155. data/features/061_valid_cookbook_version_should_be_defined.feature +0 -55
  156. data/features/062_cookbook_should_have_cookbook_version.feature +0 -50
  157. data/features/063_cookbook_incorrectly_depends_on_itself.feature +0 -15
  158. data/features/064_check_for_no_issues_url.feature +0 -25
  159. data/features/065_check_for_no_source_url.feature +0 -25
  160. data/features/066_check_for_no_chef_version_metadata.feature +0 -20
  161. data/features/067_check_for_no_supports_metadata.feature +0 -20
  162. data/features/068_check_for_no_license_metadata.feature +0 -20
  163. data/spec/foodcritic/command_line_spec.rb +0 -74
  164. data/spec/regression/expected-output.txt +0 -355
  165. data/spec/regression_helpers.rb +0 -37
@@ -0,0 +1,14 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:1
2
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:2
3
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:3
4
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/server.rb:38
5
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/server.rb:41
6
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/kickstart.conf.erb:14
7
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/kickstart.conf.erb:15
8
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/ks.cfg.erb:6
9
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/ks.cfg.erb:9
10
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/ks.cfg.erb:10
11
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
12
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
13
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
14
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,4 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,12 @@
1
+ FC014: Consider extracting long ruby_block to library: ./providers/logical_volume.rb:18
2
+ FC017: LWRP does not notify when updated: ./providers/physical_volume.rb:6
3
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/logical_volume.rb:1
4
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/physical_volume.rb:1
5
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/volume_group.rb:1
6
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
7
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
8
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
9
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
10
+ FC074: LWRP should use DSL to define resource's default action: ./resources/logical_volume.rb:1
11
+ FC074: LWRP should use DSL to define resource's default action: ./resources/physical_volume.rb:1
12
+ FC074: LWRP should use DSL to define resource's default action: ./resources/volume_group.rb:1
@@ -0,0 +1,13 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:17
2
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:46
3
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:47
4
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/mararc.erb:8
5
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/mararc.erb:9
6
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/mararc.erb:31
7
+ FC043: Prefer new notification syntax: ./recipes/default.rb:37
8
+ FC043: Prefer new notification syntax: ./recipes/default.rb:46
9
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
10
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
11
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
12
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
13
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,9 @@
1
+ FC017: LWRP does not notify when updated: ./providers/default.rb:61
2
+ FC017: LWRP does not notify when updated: ./providers/default.rb:65
3
+ FC045: Metadata does not contain cookbook name: ./metadata.rb:1
4
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
5
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
6
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
7
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
8
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
9
+ FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
@@ -0,0 +1,30 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:1
2
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:2
3
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:3
4
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:4
5
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:5
6
+ FC001: Use strings in preference to symbols to access node attributes: ./definitions/memcached_instance.rb:29
7
+ FC001: Use strings in preference to symbols to access node attributes: ./definitions/memcached_instance.rb:30
8
+ FC001: Use strings in preference to symbols to access node attributes: ./definitions/memcached_instance.rb:31
9
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:25
10
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:39
11
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:47
12
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:48
13
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:49
14
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:50
15
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:51
16
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:62
17
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:63
18
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:64
19
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:65
20
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:66
21
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:72
22
+ FC015: Consider converting definition to a Custom Resource: ./definitions/memcached_instance.rb:1
23
+ FC043: Prefer new notification syntax: ./recipes/default.rb:41
24
+ FC043: Prefer new notification syntax: ./recipes/default.rb:56
25
+ FC043: Prefer new notification syntax: ./recipes/default.rb:74
26
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
27
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
28
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
29
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
30
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,4 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,12 @@
1
+ FC002: Avoid string interpolation where not required: ./attributes/server.rb:205
2
+ FC002: Avoid string interpolation where not required: ./attributes/server.rb:206
3
+ FC002: Avoid string interpolation where not required: ./attributes/server.rb:207
4
+ FC002: Avoid string interpolation where not required: ./attributes/server.rb:208
5
+ FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./recipes/client.rb:42
6
+ FC052: Metadata uses the unimplemented "suggests" keyword: ./metadata.rb:19
7
+ FC052: Metadata uses the unimplemented "suggests" keyword: ./metadata.rb:20
8
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
9
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
10
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
11
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
12
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,6 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
6
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,10 @@
1
+ FC043: Prefer new notification syntax: ./recipes/auth.rb:46
2
+ FC043: Prefer new notification syntax: ./recipes/auth.rb:56
3
+ FC043: Prefer new notification syntax: ./recipes/server.rb:71
4
+ FC043: Prefer new notification syntax: ./recipes/server.rb:78
5
+ FC043: Prefer new notification syntax: ./recipes/server.rb:97
6
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
7
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
8
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
9
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
10
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,4 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,5 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,5 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,29 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:1
2
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:2
3
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:3
4
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:4
5
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:5
6
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:28
7
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:54
8
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:59
9
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/mod_rails.rb:28
10
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/mod_rails.rb:37
11
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/mod_rails.rb:46
12
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/passenger.conf.erb:1
13
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/passenger.conf.erb:2
14
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/passenger.conf.erb:3
15
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/passenger.load.erb:1
16
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/passenger_web_app.conf.erb:17
17
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/passenger_web_app.conf.erb:18
18
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/passenger_web_app.conf.erb:21
19
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/web_app.conf.erb:17
20
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/web_app.conf.erb:18
21
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/web_app.conf.erb:21
22
+ FC002: Avoid string interpolation where not required: ./templates/default/passenger_web_app.conf.erb:3
23
+ FC002: Avoid string interpolation where not required: ./templates/default/web_app.conf.erb:3
24
+ FC019: Access node attributes in a consistent manner: ./recipes/default.rb:33
25
+ FC019: Access node attributes in a consistent manner: ./recipes/default.rb:41
26
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
27
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
28
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
29
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,11 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./definitions/cpan_module.rb:27
2
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:26
3
+ FC002: Avoid string interpolation where not required: ./recipes/default.rb:37
4
+ FC002: Avoid string interpolation where not required: ./recipes/default.rb:43
5
+ FC015: Consider converting definition to a Custom Resource: ./definitions/cpan_module.rb:1
6
+ FC019: Access node attributes in a consistent manner: ./definitions/cpan_module.rb:27
7
+ FC019: Access node attributes in a consistent manner: ./recipes/default.rb:26
8
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
9
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
10
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
11
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,9 @@
1
+ FC017: LWRP does not notify when updated: ./providers/pear_channel.rb:31
2
+ FC017: LWRP does not notify when updated: ./providers/pear_channel.rb:40
3
+ FC017: LWRP does not notify when updated: ./providers/pear_channel.rb:69
4
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/pear.rb:1
5
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/pear_channel.rb:1
6
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
7
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
8
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
9
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,6 @@
1
+ FC042: Prefer include_recipe to require_recipe: ./recipes/aliases.rb:17
2
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
3
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
4
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
6
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,8 @@
1
+ FC017: LWRP does not notify when updated: ./providers/default.rb:19
2
+ FC019: Access node attributes in a consistent manner: ./recipes/default.rb:69
3
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
4
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
5
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
6
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
7
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
8
+ FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
@@ -0,0 +1,6 @@
1
+ FC044: Avoid bare attribute keys: ./attributes/default.rb:20
2
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
3
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
4
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
6
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,10 @@
1
+ FC011: Missing README in markdown format: examples/README.md:1
2
+ FC017: LWRP does not notify when updated: ./providers/serve.rb:65
3
+ FC017: LWRP does not notify when updated: ./providers/serve.rb:69
4
+ FC031: Cookbook without metadata.rb file: examples/metadata.rb:1
5
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/serve.rb:1
6
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
7
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
8
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
9
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
10
+ FC071: Missing LICENSE file: examples/LICENSE:1
@@ -0,0 +1,8 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/client.rb:26
2
+ FC002: Avoid string interpolation where not required: ./recipes/default.rb:24
3
+ FC002: Avoid string interpolation where not required: ./recipes/default.rb:63
4
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
5
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
6
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
7
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
8
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,4 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,4 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,5 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,5 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./templates/default/sv-stompserver-run.erb:2
2
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
3
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
4
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,5 @@
1
+ FC043: Prefer new notification syntax: ./recipes/server.rb:30
2
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
3
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
4
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
5
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,8 @@
1
+ FC017: LWRP does not notify when updated: ./providers/default.rb:102
2
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
3
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
4
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
5
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
6
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
7
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
8
+ FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
@@ -0,0 +1,5 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
5
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,8 @@
1
+ FC043: Prefer new notification syntax: ./recipes/default.rb:50
2
+ FC043: Prefer new notification syntax: ./recipes/default.rb:58
3
+ FC043: Prefer new notification syntax: ./recipes/default.rb:67
4
+ FC043: Prefer new notification syntax: ./recipes/users.rb:22
5
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
6
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
7
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
8
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,10 @@
1
+ FC016: LWRP does not declare a default action: ./resources/torrent_file.rb:1
2
+ FC024: Consider adding platform equivalents: ./recipes/default.rb:42
3
+ FC025: Prefer chef_gem to compile-time gem install: ./recipes/default.rb:25
4
+ FC025: Prefer chef_gem to compile-time gem install: ./recipes/default.rb:31
5
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/torrent_file.rb:1
6
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
7
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
8
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
9
+ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
10
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,4 @@
1
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
2
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
3
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
4
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,9 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:1
2
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:2
3
+ FC019: Access node attributes in a consistent manner: ./attributes/default.rb:1
4
+ FC019: Access node attributes in a consistent manner: ./attributes/default.rb:2
5
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
6
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
7
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
8
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
9
+ FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
@@ -0,0 +1,6 @@
1
+ FC015: Consider converting definition to a Custom Resource: ./definitions/unicorn_config.rb:1
2
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
3
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
4
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
5
+ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
6
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,7 @@
1
+ FC047: Attribute assignment does not specify precedence: ./providers/manage.rb:55
2
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/manage.rb:1
3
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
4
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
5
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
6
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
7
+ FC074: LWRP should use DSL to define resource's default action: ./resources/manage.rb:1
@@ -0,0 +1,6 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:20
2
+ FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:33
3
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
4
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
5
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
6
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,7 @@
1
+ FC017: LWRP does not notify when updated: ./providers/product.rb:26
2
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/product.rb:1
3
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
4
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
5
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
6
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
7
+ FC074: LWRP should use DSL to define resource's default action: ./resources/product.rb:1
@@ -0,0 +1,6 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:20
2
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
3
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
4
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
5
+ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
6
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
@@ -0,0 +1,57 @@
1
+ FC001: Use strings in preference to symbols to access node attributes: ./providers/reboot.rb:22
2
+ FC001: Use strings in preference to symbols to access node attributes: ./providers/reboot.rb:23
3
+ FC001: Use strings in preference to symbols to access node attributes: ./providers/reboot.rb:24
4
+ FC002: Avoid string interpolation where not required: ./libraries/registry_helper.rb:99
5
+ FC002: Avoid string interpolation where not required: ./libraries/registry_helper.rb:173
6
+ FC002: Avoid string interpolation where not required: ./libraries/windows_privileged.rb:42
7
+ FC002: Avoid string interpolation where not required: ./libraries/windows_privileged.rb:56
8
+ FC017: LWRP does not notify when updated: ./providers/auto_run.rb:21
9
+ FC017: LWRP does not notify when updated: ./providers/auto_run.rb:27
10
+ FC017: LWRP does not notify when updated: ./providers/batch.rb:24
11
+ FC017: LWRP does not notify when updated: ./providers/package.rb:35
12
+ FC017: LWRP does not notify when updated: ./providers/package.rb:53
13
+ FC017: LWRP does not notify when updated: ./providers/package.rb:64
14
+ FC017: LWRP does not notify when updated: ./providers/pagefile.rb:24
15
+ FC017: LWRP does not notify when updated: ./providers/pagefile.rb:66
16
+ FC017: LWRP does not notify when updated: ./providers/path.rb:21
17
+ FC017: LWRP does not notify when updated: ./providers/path.rb:29
18
+ FC017: LWRP does not notify when updated: ./providers/reboot.rb:21
19
+ FC017: LWRP does not notify when updated: ./providers/reboot.rb:27
20
+ FC017: LWRP does not notify when updated: ./providers/registry.rb:27
21
+ FC017: LWRP does not notify when updated: ./providers/registry.rb:31
22
+ FC017: LWRP does not notify when updated: ./providers/registry.rb:35
23
+ FC017: LWRP does not notify when updated: ./providers/registry.rb:61
24
+ FC017: LWRP does not notify when updated: ./providers/task.rb:24
25
+ FC017: LWRP does not notify when updated: ./providers/task.rb:43
26
+ FC017: LWRP does not notify when updated: ./providers/task.rb:58
27
+ FC017: LWRP does not notify when updated: ./providers/task.rb:75
28
+ FC017: LWRP does not notify when updated: ./providers/zipfile.rb:27
29
+ FC017: LWRP does not notify when updated: ./providers/zipfile.rb:44
30
+ FC018: LWRP uses deprecated notification syntax: ./providers/shortcut.rb:54
31
+ FC048: Prefer Mixlib::ShellOut: ./providers/task.rb:106
32
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/auto_run.rb:1
33
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/batch.rb:1
34
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/feature_dism.rb:1
35
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/feature_servermanagercmd.rb:1
36
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/package.rb:1
37
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/pagefile.rb:1
38
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/path.rb:1
39
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/reboot.rb:1
40
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/registry.rb:1
41
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/shortcut.rb:1
42
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/task.rb:1
43
+ FC059: LWRP provider does not declare use_inline_resources: ./providers/zipfile.rb:1
44
+ FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
45
+ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
46
+ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
47
+ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
48
+ FC074: LWRP should use DSL to define resource's default action: ./resources/auto_run.rb:1
49
+ FC074: LWRP should use DSL to define resource's default action: ./resources/batch.rb:1
50
+ FC074: LWRP should use DSL to define resource's default action: ./resources/feature.rb:1
51
+ FC074: LWRP should use DSL to define resource's default action: ./resources/package.rb:1
52
+ FC074: LWRP should use DSL to define resource's default action: ./resources/path.rb:1
53
+ FC074: LWRP should use DSL to define resource's default action: ./resources/reboot.rb:1
54
+ FC074: LWRP should use DSL to define resource's default action: ./resources/registry.rb:1
55
+ FC074: LWRP should use DSL to define resource's default action: ./resources/shortcut.rb:1
56
+ FC074: LWRP should use DSL to define resource's default action: ./resources/task.rb:1
57
+ FC074: LWRP should use DSL to define resource's default action: ./resources/zipfile.rb:1