decidim-core 0.29.1 → 0.30.0.rc1

data/lib/decidim/core/test/shared_examples/download_your_data_shared_examples.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+shared_examples_for "a download your data entity" do
+  let(:data) { subject.send(:readme) }
+
+  before do
+    subject.send(:data_and_attachments_for_user) # to create the data and get the help definitions
+  end
+
+  it "does not have any missing translation" do
+    expect(data).not_to include("Translation missing"), data
+  end
+
+  it "has the correct help definition" do
+    expect(data).to include(help_definition_string)
+  end
+end

data/lib/decidim/core/test/shared_examples/etiquette_validator_examples.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+shared_examples "etiquette validator" do |options|
+  options[:fields].map(&:to_sym).each do |field|
+    let!(field) { options[:i18n] ? { en: string } : string }
+
+    context "when #{field} contains too many caps" do
+      let(:string) { "#{"A" * 50}#{"a" * 49}" }
+
+      it { is_expected.to be_invalid }
+    end
+
+    context "when #{field} not starting with caps" do
+      let(:string) { "aa#{"A" * 50}#{"a" * 49}" }
+
+      it { is_expected.to be_invalid }
+    end
+
+    context "when #{field} containing too many marks" do
+      let(:string) { "#{"A" * 5}#{"a" * 49}!!??" }
+
+      it { is_expected.to be_invalid }
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/follows_examples.rb

@@ -14,6 +14,8 @@ shared_examples "followable content for users" do
     context "when user clicks the Follow button" do
       it "makes the user follow the followable" do
         visit followable_path
+        find("#dropdown-trigger-resource-#{followable.id}").click
+
         expect do
           click_on "Follow"
           expect(page).to have_content "Stop following"
@@ -30,6 +32,45 @@ shared_examples "followable content for users" do
     context "when user clicks the Follow button" do
       it "makes the user follow the followable" do
         visit followable_path
+        find("#dropdown-trigger-resource-#{followable.id}").click
+
+        expect do
+          click_on "Stop following"
+          expect(page).to have_content "Follow"
+        end.to change(Decidim::Follow, :count).by(-1)
+      end
+    end
+  end
+end
+
+shared_examples "followable space content for users" do
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+  end
+
+  context "when not following the followable" do
+    context "when user clicks the Follow button" do
+      it "makes the user follow the followable" do
+        visit followable_path
+
+        expect do
+          click_on "Follow"
+          expect(page).to have_content "Stop following"
+        end.to change(Decidim::Follow, :count).by(1)
+      end
+    end
+  end
+
+  context "when the user is following the followable" do
+    before do
+      create(:follow, followable:, user:)
+    end
+
+    context "when user clicks the Follow button" do
+      it "makes the user follow the followable" do
+        visit followable_path
+
         expect do
           click_on "Stop following"
           expect(page).to have_content "Follow"
@@ -51,6 +92,8 @@ shared_examples "followable content for users with a component" do
     context "when user clicks the Follow button" do
       it "makes the user follow the followable" do
         visit followable_path
+        find("#dropdown-trigger-resource-#{followable.id}").click
+
         expect do
           click_on "Follow"
           expect(page).to have_content "Stop following"

data/lib/decidim/core/test/shared_examples/has_taxonomies.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+shared_examples_for "has taxonomies" do
+  describe "taxonomies" do
+    context "when valid taxonomies are assigned" do
+      let(:taxonomy) { create(:taxonomy, :with_parent, organization: subject.organization) }
+      before do
+        subject.taxonomies = [taxonomy]
+      end
+
+      it { is_expected.to be_valid }
+    end
+
+    context "when a root taxonomy is assigned" do
+      let!(:taxonomy) { create(:taxonomy, organization: subject.organization) }
+
+      it "is not valid" do
+        expect { subject.taxonomies = [taxonomy] }.to raise_error(ActiveRecord::RecordInvalid).or change { subject.valid? }.to(false)
+      end
+    end
+
+    context "when a taxonomy from another organization is assigned" do
+      let(:taxonomy) { create(:taxonomy, :with_parent) }
+      before do
+        subject.taxonomies = [taxonomy]
+      end
+
+      it { is_expected.to be_invalid }
+    end
+  end
+
+  describe "scopes" do
+    let(:root_taxonomy) { create(:taxonomy, organization: subject.organization) }
+    let(:taxonomy) { create(:taxonomy, parent: root_taxonomy, organization: subject.organization) }
+
+    let(:another_taxonomy) { create(:taxonomy, parent: root_taxonomy, organization: subject.organization) }
+    let!(:taxonomization) { create(:taxonomization, taxonomizable: subject, taxonomy:) }
+    let!(:another_taxonomization) { create(:taxonomization, taxonomy: another_taxonomy) }
+
+    describe ".with_taxonomy" do
+      it "returns the taxonomizable" do
+        expect(described_class.with_taxonomy(taxonomy.id)).to eq([subject])
+        expect(described_class.with_taxonomy(root_taxonomy.id)).to eq([subject])
+      end
+
+      it "returns empty if not in the taxonomy" do
+        expect(described_class.with_taxonomy(another_taxonomy.id)).to be_empty
+      end
+    end
+
+    describe ".with_taxonomies" do
+      it "returns the taxonomizable" do
+        expect(described_class.with_taxonomies(taxonomy.id, another_taxonomization.id)).to eq([subject])
+        expect(described_class.with_taxonomies(root_taxonomy.id, another_taxonomization.id)).to eq([subject])
+      end
+
+      it "returns empty if not in the taxonomy" do
+        expect(described_class.with_taxonomies(another_taxonomy.id)).to be_empty
+      end
+    end
+
+    describe ".with_any_taxonomies" do
+      let!(:missing_taxonomy) { create(:taxonomy, parent: root_taxonomy, organization: subject.organization) }
+      let(:second_root_taxonomy) { create(:taxonomy, organization: subject.organization) }
+      let(:second_taxonomy) { create(:taxonomy, parent: second_root_taxonomy, organization: subject.organization) }
+      let!(:second_taxonomization) { create(:taxonomization, taxonomizable: subject, taxonomy: second_taxonomy) }
+      let(:third_root_taxonomy) { create(:taxonomy, organization: subject.organization) }
+      let(:third_taxonomy) { create(:taxonomy, parent: third_root_taxonomy, organization: subject.organization) }
+      let!(:third_taxonomization) { create(:taxonomization, taxonomizable: subject, taxonomy: third_taxonomy) }
+
+      it "returns the taxonomizable matching all subsets" do
+        subset1 = [root_taxonomy.id, [taxonomy.id, another_taxonomy.id]]
+        subset2 = [second_root_taxonomy.id, [second_taxonomy.id]]
+        subset3 = [third_root_taxonomy.id, [third_taxonomy.id]]
+        expect(described_class.with_any_taxonomies(subset1, subset2, subset3)).to eq([subject])
+      end
+
+      it "returns empty if one subset is missing" do
+        subset1 = [root_taxonomy.id, [missing_taxonomy.id]]
+        subset2 = [second_root_taxonomy.id, [second_taxonomy.id]]
+        subset3 = [third_root_taxonomy.id, [third_taxonomy.id]]
+        expect(described_class.with_any_taxonomies(subset1, subset2, subset3)).to be_empty
+      end
+
+      it "returns the taxonomizable if all taxonomies are present in the missing subset" do
+        subset1 = [root_taxonomy.id, [missing_taxonomy.id, "all"]]
+        subset2 = [second_root_taxonomy.id, [second_taxonomy.id]]
+        subset3 = [third_root_taxonomy.id, [third_taxonomy.id]]
+
+        expect(described_class.with_any_taxonomies(subset1, subset2, subset3)).to eq([subject])
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/manage_share_tokens_examples.rb

@@ -0,0 +1,237 @@
+# frozen_string_literal: true
+
+shared_examples "manage resource share tokens" do
+  context "when there are no tokens" do
+    let(:last_token) { Decidim::ShareToken.last }
+    before do
+      visit_share_tokens_page
+    end
+
+    it "displays empty message" do
+      expect(page).to have_content "There are no active access links"
+    end
+
+    it "can create a new token with default options" do
+      click_on "New access link"
+
+      click_on "Create"
+
+      expect(page).to have_content("Access link created successfully")
+      expect(page).to have_css("tbody tr", count: 1)
+      within "tbody tr:last-child td", text: last_token.token do
+        expect(page).to have_content(last_token.token)
+      end
+      within "tbody tr:last-child td:nth-child(2)" do
+        expect(page).to have_content("Never")
+      end
+      within "tbody tr:last-child td:nth-child(3)" do
+        expect(page).to have_content("No")
+      end
+    end
+
+    it "can create a new token with custom options" do
+      click_on "New access link"
+
+      find_by_id("share_token_automatic_token_false").click
+      find_by_id("share_token_no_expiration_false").click
+      find_by_id("share_token_registered_only_true").click
+      click_on "Create"
+      expect(page).to have_content("cannot be blank", count: 2)
+
+      fill_in "share_token_token", with: " custom token "
+      fill_in_datepicker :share_token_expires_at_date, with: 1.day.from_now.strftime("%d/%m/%Y")
+      fill_in_timepicker :share_token_expires_at_time, with: "00:00"
+      click_on "Create"
+
+      expect(page).to have_content("Access link created successfully")
+      expect(page).to have_css("tbody tr", count: 1)
+      within "tbody tr:last-child td", text: last_token.token do
+        expect(page).to have_content("CUSTOM-TOKEN")
+      end
+      within "tbody tr:last-child td:nth-child(2)" do
+        expect(page).to have_content(1.day.from_now.strftime("%d/%m/%Y 00:00"))
+      end
+      within "tbody tr:last-child td:nth-child(3)" do
+        expect(page).to have_content("Yes")
+      end
+    end
+  end
+
+  context "when there are tokens" do
+    let!(:share_tokens) { create_list(:share_token, 3, :with_token, token_for: resource, organization:, registered_only: true) }
+    let(:last_token) { share_tokens.last }
+
+    before do
+      visit_share_tokens_page
+    end
+
+    it "displays all tokens" do
+      within ".share_tokens" do
+        expect(page).to have_css("tbody tr", count: 3)
+      end
+    end
+
+    it "displays relevant attributes for each token" do
+      share_tokens.each do |share_token|
+        within ".share_tokens tbody" do
+          expect(page).to have_content share_token.token
+          expect(page).to have_content share_token.expires_at.to_s
+        end
+      end
+    end
+
+    context "when ordering" do
+      let(:share_tokens) do
+        [
+          create(:share_token, :with_token, token_for: resource, organization:, token: "b", expires_at: 1.day.from_now, registered_only: true, times_used: 3),
+          create(:share_token, :with_token, token_for: resource, organization:, token: "a", expires_at: 3.days.from_now, registered_only: true, times_used: 2),
+          create(:share_token, :with_token, token_for: resource, organization:, token: "c", expires_at: 2.days.from_now, registered_only: false, times_used: 1)
+        ]
+      end
+
+      it "can be ordered by token and other attributes" do
+        within ".share_tokens" do
+          click_on "Access link" # order by token
+          expect(page).to have_css("tbody tr:first-child", text: "c")
+          click_on "Access link" # order by token
+          expect(page).to have_css("tbody tr:first-child", text: "a")
+          click_on "Expires at" # order by expires_at
+          expect(page).to have_css("tbody tr:first-child", text: share_tokens.second.expires_at.strftime("%d/%m/%Y %H:%M"))
+          click_on "Expires at" # order by expires_at
+          expect(page).to have_css("tbody tr:first-child", text: share_tokens.first.expires_at.strftime("%d/%m/%Y %H:%M"))
+          click_on "Registered only" # order by registered_only
+          expect(page).to have_css("tbody tr:first-child", text: "Yes")
+          click_on "Registered only" # order by registered_only
+          expect(page).to have_css("tbody tr:first-child", text: "No")
+          click_on "Times used" # order by times_used
+          expect(page).to have_css("tbody tr:first-child", text: "3")
+          click_on "Times used" # order by times_used
+          expect(page).to have_css("tbody tr:first-child", text: "1")
+        end
+      end
+    end
+
+    it "can edit a share token" do
+      within "tbody tr", text: last_token.token do
+        expect(page).to have_content("Yes")
+      end
+      within ".share_tokens tbody tr", text: last_token.token do
+        click_on "Edit"
+      end
+
+      expect(page).to have_content("Edit access links for: #{resource_name}")
+      find_by_id("share_token_no_expiration_false").click
+      find_by_id("share_token_registered_only_false").click
+      click_on "Update"
+      expect(page).to have_content("cannot be blank", count: 1)
+
+      fill_in_datepicker :share_token_expires_at_date, with: 1.day.from_now.strftime("%d/%m/%Y")
+      fill_in_timepicker :share_token_expires_at_time, with: "00:00"
+
+      click_on "Update"
+
+      expect(page).to have_content("Access link updated successfully")
+      expect(page).to have_css("tbody tr", count: 3)
+      within "tbody tr", text: last_token.token do
+        expect(page).to have_content(1.day.from_now.strftime("%d/%m/%Y 00:00"))
+      end
+      within "tbody tr", text: last_token.token do
+        expect(page).to have_content("No")
+      end
+    end
+
+    it "allows copying the share link from the share token" do
+      within ".share_tokens tbody tr", text: last_token.token do
+        click_on "Copy link"
+        expect(page).to have_content("copied!")
+        expect(page).to have_css("[data-clipboard-copy-label]")
+        expect(page).to have_css("[data-clipboard-copy-message]")
+        expect(page).to have_css("[data-clipboard-content]")
+      end
+    end
+
+    it "has a share link for each token" do
+      urls = share_tokens.map(&:url)
+      within ".share_tokens tbody tr", text: last_token.token do
+        share_window = window_opened_by { click_on "Preview" }
+
+        within_window share_window do
+          expect(urls).to include(page.current_url)
+        end
+      end
+    end
+
+    it "has a share button that opens the share url for the resource" do
+      within ".share_tokens tbody tr", text: last_token.token do
+        share_window = window_opened_by { click_on "Preview", wait: 2 }
+
+        within_window share_window do
+          expect(current_url).to include(last_token.url)
+        end
+      end
+    end
+
+    it "can delete tokens" do
+      within ".share_tokens tbody tr", text: last_token.token do
+        accept_confirm { click_on "Delete" }
+      end
+
+      expect(page).to have_admin_callout("Access link successfully destroyed")
+      expect(page).to have_css("tbody tr", count: 2)
+    end
+  end
+
+  context "when there are many pages" do
+    let!(:share_tokens) { create_list(:share_token, 26, :with_token, token_for: resource, organization:) }
+
+    before do
+      visit_share_tokens_page
+    end
+
+    it "displays pagination" do
+      expect(page).to have_css("tbody tr", count: 25)
+      within '[aria-label="Pagination"]' do
+        click_on "Next"
+      end
+      expect(page).to have_css("tbody tr", count: 1)
+    end
+  end
+end
+
+shared_examples "manage component share tokens" do
+  let!(:components_path) { participatory_space_engine.components_path(participatory_space) }
+  let!(:component) { create(:component, participatory_space:, published_at: nil) }
+  let(:resource) { component }
+  let(:resource_name) { translated(component.name) }
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+  end
+
+  def visit_share_tokens_page
+    visit components_path
+    within ".table-list" do
+      click_on "Access links"
+    end
+  end
+
+  it_behaves_like "manage resource share tokens"
+end
+
+shared_examples "manage participatory space share tokens" do
+  let(:resource) { participatory_space }
+  let(:resource_name) { translated(resource.title) }
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+  end
+
+  def visit_share_tokens_page
+    visit participatory_spaces_path
+    click_on "Access links"
+  end
+
+  it_behaves_like "manage resource share tokens"
+end

data/lib/decidim/core/test/shared_examples/map_examples.rb

@@ -14,6 +14,8 @@ shared_context "with frontend map builder" do
 
   let(:template_class) do
     Class.new(ActionView::Base) do
+      include Decidim::LayoutHelper
+
       def protect_against_forgery?
         false
       end

data/lib/decidim/core/test/shared_examples/open_data_exporter_examples.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+shared_examples_for "default open data exporter" do
+  let(:organization) { create(:organization) }
+  let(:path) { "/tmp/test-open-data-#{resource_file_name}.zip" }
+  let(:zip_contents) { Zip::File.open(path) }
+
+  let(:file_name) { "*open-data-#{resource_file_name}.csv" }
+  let(:file) { zip_contents.glob(file_name).first }
+  let(:data) { file.get_input_stream.read }
+
+  before do
+    subject.export
+  end
+
+  it "includes a CSV" do
+    expect(file).not_to be_nil
+  end
+
+  describe "README content" do
+    let(:file_name) { "README.md" }
+
+    it "includes the resource help description" do
+      expect(data).to include(resource_title)
+      help_lines.each do |line|
+        expect(data).to include(line)
+      end
+    end
+
+    it "does not have any missing translation" do
+      expect(data).not_to include("Translation missing")
+    end
+  end
+end
+
+shared_examples_for "open users data exporter" do
+  include_examples "default open data exporter"
+
+  it "includes the resource data" do
+    expect(data).to include(resource.nickname.gsub("\"", "\"\""))
+  end
+
+  context "with unpublished components" do
+    it "does not include the resource data" do
+      expect(data).not_to include(unpublished_resource.nickname.gsub("\"", "\"\""))
+    end
+  end
+end
+
+shared_examples_for "open moderation data exporter" do
+  include_examples "default open data exporter"
+
+  it "includes the resource data" do
+    if resource.respond_to?(:reportable)
+      expect(data).to include(resource.reportable.reported_content_url.gsub("\"", "\"\""))
+    elsif resource.respond_to?(:reported?)
+      expect(data).to include(resource.id.to_s)
+    else
+      raise "Failed to understand the model"
+    end
+  end
+
+  context "with unpublished components" do
+    it "does not include the resource data" do
+      if unpublished_resource.respond_to?(:reportable)
+        expect(data).not_to include(unpublished_resource.reportable.reported_content_url.gsub("\"", "\"\""))
+      elsif unpublished_resource.respond_to?(:reported?)
+        expect(data).not_to include(unpublished_resource.id.to_s)
+      else
+        raise "Failed to understand the model"
+      end
+    end
+  end
+end
+
+shared_examples_for "open data exporter" do
+  include_examples "default open data exporter"
+
+  it "includes the resource data" do
+    if resource.respond_to?(:title)
+      expect(data).to include(translated(resource.title).gsub("\"", "\"\""))
+    elsif resource.respond_to?(:body)
+      # Seems like the comments are always taking the first alphabetical language for the export
+      # We should fix it in the future
+      expect(data).to include(resource.body.min.second)
+    else
+      raise "Failed to understand the model"
+    end
+  end
+
+  context "with unpublished components" do
+    it "does not include the resource data" do
+      if unpublished_resource.respond_to?(:title)
+        expect(data).not_to include(translated(unpublished_resource.title).gsub("\"", "\"\""))
+      elsif unpublished_resource.respond_to?(:body)
+        expect(data).not_to include(translated(unpublished_resource.body).gsub("\"", "\"\""))
+      else
+        raise "Failed to understand the model"
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/participatory_space_members_page_examples.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+shared_examples "participatory space members page examples" do
+  let(:user1) { create(:user, organization: privatable_to.organization) }
+  let(:user2) { create(:user, organization: privatable_to.organization) }
+  let(:user3) { create(:user, organization: privatable_to.organization) }
+
+  before do
+    request.env["decidim.current_organization"] = organization
+  end
+
+  describe "GET index" do
+    context "when participatory space has no members" do
+      it "redirects to 404" do
+        expect { get :index, params: { slug_param => slug } }
+          .to raise_error(ActionController::RoutingError)
+      end
+    end
+
+    context "when participatory space has members" do
+      let!(:member1) { create(:participatory_space_private_user, privatable_to:, user: user1, published: true) }
+      let!(:member2) { create(:participatory_space_private_user, privatable_to:, user: user2, published: true) }
+      let!(:non_published) { create(:participatory_space_private_user, privatable_to:, user: user3, published: false) }
+
+      context "when user has permissions" do
+        it "displays list of members" do
+          get :index, params: { slug_param => slug }
+
+          expect(controller.helpers.collection).to contain_exactly(member1, member2)
+        end
+      end
+
+      context "when user does not have permissions" do
+        before do
+          allow(controller).to receive(:current_user_can_visit_space?).and_return(false)
+        end
+
+        it "redirects to participatory space path" do
+          get :index, params: { slug_param => slug }
+
+          expect(response).to redirect_to(privatable_to)
+        end
+      end
+    end
+  end
+end