decidim-core 0.29.1 → 0.30.0.rc1

data/lib/decidim/api/types/attachment_type.rb

@@ -5,11 +5,11 @@ module Decidim
     class AttachmentType < Decidim::Api::Types::BaseObject
       description "A file attachment"
 
-      field :title, Decidim::Core::TranslatedFieldType, "The title of this attachment.", null: false
       field :description, Decidim::Core::TranslatedFieldType, "The description of this attachment.", null: false
-      field :url, GraphQL::Types::String, "The url of this attachment", null: false
-      field :type, GraphQL::Types::String, "The type of this attachment", method: :file_type, null: false
       field :thumbnail, GraphQL::Types::String, "A thumbnail of this attachment, if it is an image.", method: :thumbnail_url, null: true
+      field :title, Decidim::Core::TranslatedFieldType, "The title of this attachment.", null: false
+      field :type, GraphQL::Types::String, "The type of this attachment", method: :file_type, null: false
+      field :url, GraphQL::Types::String, "The url of this attachment", null: false
     end
   end
 end

data/lib/decidim/api/types/category_type.rb

@@ -5,10 +5,10 @@ module Decidim
     class CategoryType < Decidim::Api::Types::BaseObject
       description "A category that can be applied to other resources."
 
-      field :id, GraphQL::Types::ID, null: false
+      field :id, GraphQL::Types::ID, "The id for this category", null: false
       field :name, Decidim::Core::TranslatedFieldType, "The name of this category.", null: false
-      field :subcategories, [Decidim::Core::CategoryType, { null: true }], "Subcategories of this category.", null: false
       field :parent, Decidim::Core::CategoryType, "This category's parent category.", null: true
+      field :subcategories, [Decidim::Core::CategoryType, { null: true }], "Subcategories of this category.", null: false
     end
   end
 end

data/lib/decidim/api/types/component_type.rb

@@ -5,6 +5,13 @@ module Decidim
     class ComponentType < Decidim::Api::Types::BaseObject
       implements Decidim::Core::ComponentInterface
       description "A base component with no particular specificities."
+
+      def self.authorized?(object, context)
+        context[:component] = object
+        context[:current_component] = object
+
+        super && allowed_to?(:read, :component, object, context)
+      end
     end
   end
 end

data/lib/decidim/api/types/decidim_type.rb

@@ -6,8 +6,12 @@ module Decidim
     class DecidimType < Decidim::Api::Types::BaseObject
       description "Decidim's framework-related properties."
 
-      field :version, GraphQL::Types::String, "The current decidim's version of this deployment.", null: false
       field :application_name, GraphQL::Types::String, "The current installation's name.", null: false
+      field :version, GraphQL::Types::String, "The current decidim's version of this deployment.", null: true
+
+      def version
+        object.version if Decidim::Api.disclose_system_version
+      end
     end
   end
 end

data/lib/decidim/api/types/fingerprint_type.rb

@@ -5,8 +5,8 @@ module Decidim
     class FingerprintType < Decidim::Api::Types::BaseObject
       description "A fingerprint object"
 
-      field :value, GraphQL::Types::String, "The the hash value for the fingerprint", null: false
       field :source, GraphQL::Types::String, description: "Returns the source String (usually a json) from which the fingerprint is generated.", null: false
+      field :value, GraphQL::Types::String, "The the hash value for the fingerprint", null: false
     end
   end
 end

data/lib/decidim/api/types/localized_string_type.rb

@@ -7,8 +7,8 @@ module Decidim
       description "Represents a particular translation of a LocalizedStringType"
 
       field :locale, GraphQL::Types::String, "The standard locale of this translation.", null: false
-      field :text, GraphQL::Types::String, "The content of this translation.", null: true
       field :machine_translated, GraphQL::Types::Boolean, "Whether this string is machine translated or not.", null: false
+      field :text, GraphQL::Types::String, "The content of this translation.", null: true
 
       def machine_translated
         if object.respond_to?(:machine_translated)

data/lib/decidim/api/types/metric_history_type.rb

@@ -3,6 +3,8 @@
 module Decidim
   module Core
     class MetricHistoryType < Decidim::Api::Types::BaseObject
+      description "A metric history"
+
       field :key, GraphQL::Types::String, "The key value", null: false
       field :value, GraphQL::Types::Int, "The value for each key", null: false
 

data/lib/decidim/api/types/metric_type.rb

@@ -5,9 +5,9 @@ module Decidim
     class MetricType < Decidim::Api::Types::BaseObject
       description "Metric data"
 
-      field :name, GraphQL::Types::String, "The graphql_name of the metric", null: false
       field :count, GraphQL::Types::Int, "The last value of the metric", null: false
       field :history, [MetricHistoryType, { null: true }], "The historic values for this metric", null: false
+      field :name, GraphQL::Types::String, "The graphql_name of the metric", null: false
     end
   end
 end

data/lib/decidim/api/types/organization_type.rb

@@ -6,12 +6,17 @@ module Decidim
       description "The current organization"
 
       field :name, Decidim::Core::TranslatedFieldType, "The name of the current organization", null: true
+      field :taxonomies, [Decidim::Core::TaxonomyType, { null: true }], "The taxonomies associated to this organization", null: true
 
       field :stats, [Core::StatisticType, { null: true }], description: "The statistics associated to this object", null: true
 
       def stats
         Decidim.stats.with_context(object)
       end
+
+      def taxonomies
+        object.taxonomies.roots
+      end
     end
   end
 end

data/lib/decidim/api/types/participatory_space_link_type.rb

@@ -5,11 +5,11 @@ module Decidim
     class ParticipatorySpaceLinkType < Decidim::Api::Types::BaseObject
       description "A link representation between participatory spaces"
 
-      field :id, GraphQL::Types::ID, "The id of this participatory space link", null: false
       field :from_type, GraphQL::Types::String, "The origin participatory space type for this participatory space link", null: false
-      field :to_type, GraphQL::Types::String, "The destination participatory space type for this participatory space link", null: false
+      field :id, GraphQL::Types::ID, "The id of this participatory space link", null: false
       field :name, GraphQL::Types::String, "The name (purpose) of this participatory space link", null: false
       field :participatory_space, ParticipatorySpaceInterface, description: "The linked participatory space (polymorphic)", null: false
+      field :to_type, GraphQL::Types::String, "The destination participatory space type for this participatory space link", null: false
 
       def participatory_space
         manifest_name = object.name.partition("included_").last

data/lib/decidim/api/types/participatory_space_manifest_type.rb

@@ -5,8 +5,8 @@ module Decidim
     class ParticipatorySpaceManifestType < Decidim::Api::Types::BaseObject
       description "A participatory manifest"
 
-      field :name, GraphQL::Types::String, "The name of the manifest", null: false
       field :human_name, Decidim::Core::QuantifiableTranslatedFieldType, "The human readable name for the manifest", null: false
+      field :name, GraphQL::Types::String, "The name of the manifest", null: false
 
       def human_name
         {

data/lib/decidim/api/types/quantifiable_translated_field_type.rb

@@ -5,8 +5,8 @@ module Decidim
     class QuantifiableTranslatedFieldType < Decidim::Api::Types::BaseObject
       description "A quantifiable translated field with singular and plural formats"
 
-      field :single, Decidim::Core::TranslatedFieldType, "The singular format.", null: false
       field :plural, Decidim::Core::TranslatedFieldType, "The plural format.", null: false
+      field :single, Decidim::Core::TranslatedFieldType, "The singular format.", null: false
     end
   end
 end

data/lib/decidim/api/types/scope_api_type.rb

@@ -6,10 +6,9 @@ module Decidim
       graphql_name "Scope"
       description "A scope"
 
-      field :id, GraphQL::Types::ID, null: false
-      field :name, Decidim::Core::TranslatedFieldType, "The graphql_name of this scope.", null: false
-
       field :children, [Decidim::Core::ScopeApiType, { null: true }], "Descendants of this scope", null: false
+      field :id, GraphQL::Types::ID, "The Id for this scope", null: false
+      field :name, Decidim::Core::TranslatedFieldType, "The graphql_name of this scope.", null: false
       field :parent, Decidim::Core::ScopeApiType, "This scope's parent scope.", null: true
     end
   end

data/lib/decidim/api/types/session_type.rb

@@ -7,13 +7,12 @@ module Decidim
       description "The current session"
 
       field :user, UserType, "The current user", null: true
+      field :verified_user_groups, [UserGroupType], "The current user verified user groups", null: false
 
       def user
         object
       end
 
-      field :verified_user_groups, [UserGroupType], "The current user verified user groups", null: false
-
       def verified_user_groups
         Decidim::UserGroups::ManageableUserGroups.for(object).verified
       end

data/lib/decidim/api/types/taxonomy_type.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Core
+    class TaxonomyType < Decidim::Api::Types::BaseObject
+      description "A taxonomy that can be applied to other resources."
+
+      field :children, [Decidim::Core::TaxonomyType], "The children of this taxonomy.", null: false
+      field :id, GraphQL::Types::ID, "The id of this taxonomy.", null: false
+      field :is_root, Boolean, "Whether this taxonomy is a root taxonomy (root taxonomies have no parents).", null: false, method: :root?
+      field :name, Decidim::Core::TranslatedFieldType, "The name of this taxonomy.", null: false
+      field :parent, Decidim::Core::TaxonomyType, "The parent of this taxonomy.", null: true
+    end
+  end
+end

data/lib/decidim/api/types/trace_version_type.rb

@@ -5,15 +5,15 @@ module Decidim
     class TraceVersionType < Decidim::Api::Types::BaseObject
       description "A trace version type"
 
-      field :id, GraphQL::Types::ID, "The ID of the version", null: false
+      field :changeset, GraphQL::Types::JSON, description: "Object with the changes in this version", null: true
       field :created_at, Decidim::Core::DateTimeType, description: "The date and time this version was created", null: true
       field :editor, Decidim::Core::AuthorInterface, description: "The editor/author of this version", null: true
+      field :id, GraphQL::Types::ID, "The ID of the version", null: false
 
       def editor
         author = Decidim.traceability.version_editor(object)
         author if author.is_a?(Decidim::User) || author.is_a?(Decidim::UserGroup)
       end
-      field :changeset, GraphQL::Types::JSON, description: "Object with the changes in this version", null: true
 
       delegate :changeset, to: :object
     end

data/lib/decidim/api/types/translated_field_type.rb

@@ -7,14 +7,12 @@ module Decidim
       description "A translated field"
 
       field :locales, [GraphQL::Types::String, { null: true }], description: "Lists all the locales in which this translation is available", null: true
-
-      field :translations, [LocalizedStringType, { null: true }], description: "All the localized strings for this translation.", null: false do
-        argument :locales, [GraphQL::Types::String], description: "A list of locales to scope the translations to.", required: false
-      end
-
       field :translation, GraphQL::Types::String, description: "Returns a single translation given a locale.", null: true do
         argument :locale, GraphQL::Types::String, "A locale to search for", required: true
       end
+      field :translations, [LocalizedStringType, { null: true }], description: "All the localized strings for this translation.", null: false do
+        argument :locales, [GraphQL::Types::String], description: "A list of locales to scope the translations to.", required: false
+      end
 
       def locales
         (defined_translations.keys + machine_translations.keys).uniq

data/lib/decidim/api/types/user_group_type.rb

@@ -8,57 +8,48 @@ module Decidim
 
       implements Decidim::Core::AuthorInterface
 
+      field :avatar_url, GraphQL::Types::String, "The user's avatar url", null: false
+      field :badge, GraphQL::Types::String, "A badge for the user group", null: false
+      field :deleted, GraphQL::Types::Boolean, "Whether the user group's has been deleted or not", null: false
       field :id, GraphQL::Types::ID, "The user group's id", null: false
-
+      field :members, [Decidim::Core::UserType, { null: true }], "Members of this group", null: false, method: :accepted_users
+      field :members_count, GraphQL::Types::Int, "Number of members in this group", null: false
       field :name, GraphQL::Types::String, "The user group's name", null: false
-
       field :nickname, GraphQL::Types::String, "The user group nickname", null: false
+      field :organization_name, Decidim::Core::TranslatedFieldType, "The user group's organization name", null: false
+      field :profile_path, GraphQL::Types::String, "The user group's profile url", null: false
 
       def nickname
         object.presenter.nickname
       end
 
-      field :avatar_url, GraphQL::Types::String, "The user's avatar url", null: false
-
       def avatar_url
         object.presenter.avatar_url
       end
 
-      field :profile_path, GraphQL::Types::String, "The user group's profile url", null: false
-
       def profile_path
         object.presenter.profile_path
       end
 
-      field :organization_name, Decidim::Core::TranslatedFieldType, "The user group's organization name", null: false
-
       def organization_name
         object.organization.name
       end
 
-      field :deleted, GraphQL::Types::Boolean, "Whether the user group's has been deleted or not", null: false
-
       def deleted
         object.presenter.deleted?
       end
 
-      field :badge, GraphQL::Types::String, "A badge for the user group", null: false
-
       def badge
         object.presenter.badge
       end
 
-      field :members, [Decidim::Core::UserType, { null: true }], "Members of this group", null: false
-
-      def members
-        object.accepted_users
-      end
-
-      field :members_count, GraphQL::Types::Int, "Number of members in this group", null: false
-
       def members_count
         object.accepted_memberships.count
       end
+
+      def self.authorized?(object, context)
+        super && !object.blocked?
+      end
     end
   end
 end

data/lib/decidim/api/types/user_type.rb

@@ -8,28 +8,19 @@ module Decidim
 
       implements Decidim::Core::AuthorInterface
 
-      field :id, GraphQL::Types::ID, "The user's id", null: false
-
-      field :name, GraphQL::Types::String, "The user's name", null: false
-
-      field :nickname, GraphQL::Types::String, "The user's nickname", null: false
-
       field :avatar_url, GraphQL::Types::String, "The user's avatar url", null: false
-
-      field :profile_path, GraphQL::Types::String, "The user's profile url", null: false
-
+      field :badge, GraphQL::Types::String, "A badge for the user group", null: false
+      field :deleted, GraphQL::Types::Boolean, "Whether the user's account has been deleted or not", null: false
       field :direct_messages_enabled, GraphQL::Types::String,
             null: false,
             description: ["If the user making the request is logged in, it will return whether this recipient accepts a conversation or not.",
                           " It will return false for non-logged requests."].join
-
+      field :groups, [Decidim::Core::UserGroupType, { null: true }], "Groups where this user belongs", null: false, method: :accepted_user_groups
+      field :id, GraphQL::Types::ID, "The user's id", null: false
+      field :name, GraphQL::Types::String, "The user's name", null: false
+      field :nickname, GraphQL::Types::String, "The user's nickname", null: false
       field :organization_name, Decidim::Core::TranslatedFieldType, "The user's organization name", null: false
-
-      field :deleted, GraphQL::Types::Boolean, "Whether the user's account has been deleted or not", null: false
-
-      field :badge, GraphQL::Types::String, "A badge for the user group", null: false
-
-      field :groups, [Decidim::Core::UserGroupType, { null: true }], "Groups where this user belongs", null: false
+      field :profile_path, GraphQL::Types::String, "The user's profile url", null: false
 
       def nickname
         object.presenter.nickname
@@ -59,8 +50,8 @@ module Decidim
         object.presenter.badge
       end
 
-      def groups
-        object.accepted_user_groups
+      def self.authorized?(object, context)
+        super && object.confirmed? && !object.blocked? && !object.deleted?
       end
     end
   end

data/lib/decidim/asset_router/storage.rb

@@ -159,7 +159,7 @@ module Decidim
         return unless blob
 
         if options[:only_path] || remote? || !asset_url_available?
-          routes.rails_blob_url(blob, **default_options.merge(options))
+          routes.rails_blob_url(blob, **default_options, **options)
         else
           blob.url(**options)
         end
@@ -184,7 +184,7 @@ module Decidim
         if options[:host]
           rails_representation_url(**options)
         else
-          representation_url(**options.merge(only_path: true))
+          representation_url(**options, only_path: true)
         end
       end
 
@@ -207,10 +207,10 @@ module Decidim
       # @param options The options for building the URL
       # @return [String, nil] The converted representation URL or `nil` if the
       #   asset is not defined.
-      def rails_representation_url(**options)
+      def rails_representation_url(**)
         return unless asset
 
-        representation_url = routes.rails_representation_url(asset, **default_options.merge(options))
+        representation_url = routes.rails_representation_url(asset, **default_options, **)
 
         variation = asset.try(:variation)
         return representation_url unless variation

data/lib/decidim/assets/tailwind/tailwind.config.js.erb

@@ -51,7 +51,8 @@ module.exports = {
         DEFAULT: "#F3F4F7",
         2: "#FAFBFC",
         3: "#EFEFEF",
-        4: "#E4EEFF99" // 60% opacity
+        4: "#E4EEFF99", // 60% opacity
+        5: "#E9E9E9"
       }
     },
     container: {

data/lib/decidim/attachment_attributes.rb

@@ -28,7 +28,7 @@ module Decidim
       # Returns nothing.
       def attachments_attribute(name)
         attribute name, Array[Integer]
-        attribute "add_#{name}".to_sym, Array
+        attribute :"add_#{name}", Array
 
         # Define the getter method that fetches the attachment records based on
         # their types. For Strings and Integers, assumes they are IDs and will

data/lib/decidim/attribute_encryptor.rb

@@ -21,7 +21,7 @@ module Decidim
     def self.cryptor
       @cryptor ||= begin
         key = ActiveSupport::KeyGenerator.new("attribute").generate_key(
-          Rails.application.secrets.secret_key_base, ActiveSupport::MessageEncryptor.key_len
+          Rails.application.secret_key_base, ActiveSupport::MessageEncryptor.key_len
         )
         ActiveSupport::MessageEncryptor.new(key)
       end

data/lib/decidim/attribute_object/nested_validator.rb

@@ -7,7 +7,7 @@ module Decidim
         value = value.values if value.is_a?(Hash)
         return unless Array(value).reject { |r| valid_object?(r) }.any?
 
-        record.errors.add(attribute, :invalid, **options.merge(value:))
+        record.errors.add(attribute, :invalid, **options, value:)
       end
 
       private

data/lib/decidim/attributes/integer_with_units.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Attributes
+    # Custom attributes value to represent an Integer with units.
+    class IntegerWithUnits < ActiveModel::Type::Value
+      def type
+        :"decidim/attributes/integer_with_units"
+      end
+
+      def cast(value)
+        return nil if value.nil?
+
+        case value
+        when ::Hash
+          [value["0"].to_i.abs, value["1"].to_s]
+        when ::Array
+          return value if value.size != 2
+
+          [value[0].to_i.abs, value[1].to_s]
+        else
+          value
+        end
+      end
+    end
+  end
+end

data/lib/decidim/attributes/rich_text.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Attributes
+    # Custom attributes value to convert rich text strings in the database, i.e.
+    # strings that originate from the editor.
+    class RichText < Decidim::Attributes::CleanString
+      def type
+        :"decidim/attributes/rich_text"
+      end
+
+      # Serializes the value to the database.
+      def serialize(value)
+        serialize_value(value)
+      end
+
+      private
+
+      # From form to database
+      def serialize_value(value)
+        return value unless value.is_a?(String)
+
+        context = {}
+        parsed = Decidim::ContentProcessor.parse_with_processor(:blob, value, context)
+        parsed.rewrite
+      end
+
+      # From database to form
+      def cast_value(value)
+        clean_string = super
+        return clean_string unless clean_string.is_a?(String)
+
+        renderer = Decidim::ContentProcessor.renderer_klass(:blob).constantize.new(clean_string)
+        renderer.render
+      end
+    end
+  end
+end

data/lib/decidim/attributes/time_with_zone.rb

@@ -5,6 +5,15 @@ module Decidim
     # Custom attributes value to parse a String representing a Time using
     # the app TimeZone.
     class TimeWithZone < ActiveModel::Type::DateTime
+      # Date format: 2020-06-20T, 2020-06-20, 20/06/2020T or 20/06/2020
+      # Time format: 10:20, 10:20:30 or 10:20:30.123456
+      ISO_DATETIME_WITHOUT_TIMEZONE = %r{
+        \A
+        ((\d{4})-(\d\d)-(\d\d)|(\d\d)/(\d\d)/(\d{4}))(?:T|\s)
+        (\d\d):(\d\d)(:(\d\d)(?:\.(\d{1,6})\d*)?)?
+        \z
+      }x
+
       def type
         :"decidim/attributes/time_with_zone"
       end
@@ -18,8 +27,9 @@ module Decidim
       rescue ArgumentError
         fallback = super
         return fallback unless fallback.is_a?(Time)
+        return Time.zone.parse(fallback.strftime("%F %T")) if ISO_DATETIME_WITHOUT_TIMEZONE.match?(value)
 
-        Time.zone.parse(fallback.strftime("%F %T"))
+        ActiveSupport::TimeWithZone.new(fallback, Time.zone)
       end
     end
   end

data/lib/decidim/attributes.rb

@@ -5,6 +5,7 @@ module Decidim
     autoload :TimeWithZone, "decidim/attributes/time_with_zone"
     autoload :LocalizedDate, "decidim/attributes/localized_date"
     autoload :CleanString, "decidim/attributes/clean_string"
+    autoload :RichText, "decidim/attributes/rich_text"
     autoload :Blob, "decidim/attributes/blob"
     autoload :Array, "decidim/attributes/array"
     autoload :Hash, "decidim/attributes/hash"
@@ -12,6 +13,7 @@ module Decidim
     autoload :Model, "decidim/attributes/model"
     autoload :Symbol, "decidim/attributes/symbol"
     autoload :Integer, "decidim/attributes/integer"
+    autoload :IntegerWithUnits, "decidim/attributes/integer_with_units"
 
     # Base types
     ActiveModel::Type.register(:array, Decidim::Attributes::Array)
@@ -27,7 +29,9 @@ module Decidim
     ActiveModel::Type.register(:"decidim/attributes/time_with_zone", Decidim::Attributes::TimeWithZone)
     ActiveModel::Type.register(:"decidim/attributes/localized_date", Decidim::Attributes::LocalizedDate)
     ActiveModel::Type.register(:"decidim/attributes/clean_string", Decidim::Attributes::CleanString)
+    ActiveModel::Type.register(:"decidim/attributes/rich_text", Decidim::Attributes::RichText)
     ActiveModel::Type.register(:"decidim/attributes/blob", Decidim::Attributes::Blob)
+    ActiveModel::Type.register(:"decidim/attributes/integer_with_units", Decidim::Attributes::IntegerWithUnits)
 
     ActiveModel::Type.register(:integer, Decidim::Attributes::Integer)
   end

data/lib/decidim/authorization_form_builder.rb

@@ -37,7 +37,6 @@ module Decidim
 
     def input_field(name, type)
       return hidden_field(name) if name.to_s == "handler_name"
-      return scopes_selector if name.to_s == "scope_id"
 
       case type
       when :date, :datetime, :time, :"decidim/attributes/localized_date"
@@ -47,12 +46,6 @@ module Decidim
       end
     end
 
-    def scopes_selector
-      return if object.user.blank?
-
-      collection_select :scope_id, object.user.organization.scopes, :id, ->(scope) { translated_attribute(scope.name) }
-    end
-
     def find_input_type(name)
       value_type = object.class.attribute_types[name]
 

data/lib/decidim/coauthorable.rb

@@ -70,7 +70,7 @@ module Decidim
       def reload(options = nil)
         remove_instance_variable(:@authors) if defined?(@authors)
         remove_instance_variable(:@notifiable_identities) if defined?(@notifiable_identities)
-        super(options)
+        super
       end
 
       # Returns all the authors of a coauthorable.

data/lib/decidim/command.rb

@@ -22,7 +22,7 @@ module Decidim
     end
 
     def evaluate(&block)
-      @caller = eval("self", block.binding, __FILE__, __LINE__)
+      @caller = block.binding.receiver
       instance_eval(&block)
     end
 
@@ -42,10 +42,10 @@ module Decidim
       @caller.respond_to?(method_name, include_private)
     end
 
-    def with_events(with_transaction: false, &block)
+    def with_events(with_transaction: false, &)
       ActiveSupport::Notifications.publish("#{event_namespace}:before", **event_arguments)
 
-      with_transaction ? transaction(&block) : yield
+      with_transaction ? transaction(&) : yield
 
       ActiveSupport::Notifications.publish("#{event_namespace}:after", **event_arguments)
     end

data/lib/decidim/commands/destroy_resource.rb

@@ -40,7 +40,11 @@ module Decidim
           current_user,
           **extra_params
         ) do
-          resource.destroy!
+          if resource.respond_to?(:really_destroy!)
+            resource.really_destroy!
+          else
+            resource.destroy!
+          end
         end
       end
 

data/lib/decidim/commands/resource_handler.rb

@@ -22,7 +22,7 @@ module Decidim
         end
 
         def form_attribute_values
-          raise "You need to define the list of attributes to be fetched from form object fetch_form_attributes" unless defined?(:form_attributes)
+          raise "You need to define the list of attributes to be fetched from form object fetch_form_attributes" if form_attributes.empty?
 
           form_attributes.index_with do |field|
             form.send(field)
@@ -30,7 +30,7 @@ module Decidim
         end
 
         def file_attribute_values
-          return {} unless defined?(:file_attributes)
+          return {} if file_attributes.empty?
 
           attachment_attributes(*file_attributes)
         end