decidim-core 0.28.3 → 0.29.0.rc1

data/lib/decidim/translatable_attributes.rb

@@ -17,7 +17,7 @@ module Decidim
       # type - The attribute's type
       # options - Options to send to the form class when defining the attribute.
       # block - An optional block to be called for each attribute name and
-      # locale. The block will receive two arguments, one with the attriubte
+      # locale. The block will receive two arguments, one with the attribute
       # name and another with the locale.
       #
       #
@@ -34,12 +34,12 @@ module Decidim
       #   end
       #
       # Returns nothing.
-      def translatable_attribute(name, type, **options)
+      def translatable_attribute(name, type, **)
         attribute(name, { String => Object }, default: {})
 
         locales.each do |locale|
           attribute_name = "#{name}_#{locale}".gsub("-", "__")
-          attribute attribute_name, type, **options
+          attribute(attribute_name, type, **)
 
           define_method attribute_name do
             field = public_send(name) || {}

data/lib/decidim/translatable_resource.rb

@@ -19,7 +19,7 @@ module Decidim
           method_name = "#{field}="
 
           # We are overriding the attribute setter method so that we can reuse the
-          # machine translations. This is to fix a bug encoutered when updating
+          # machine translations. This is to fix a bug encountered when updating
           # the resource from a FormObject. The FormObject on the `#create`
           # action in the controller does not have the machine translations loaded,
           # so they are effectively lost whenever a resource is updated.

data/lib/decidim/view_hooks.rb

@@ -87,7 +87,7 @@ module Decidim
     # Internal class to encapsulate each view registered on a view hook.
     class ViewHook
       # priority - a Number (Integer|Float) to sort the block.
-      # block - a block that will bbe rendered in a view context.
+      # block - a block that will be rendered in a view context.
       def initialize(priority, block)
         @priority = priority
         @block = block

data/lib/decidim/view_model.rb

@@ -17,8 +17,12 @@ module Decidim
     include Decidim::MarkupHelper
     include Decidim::LayoutHelper
     include Decidim::SanitizeHelper
+    include Decidim::ApplicationHelper
+    include Decidim::IconHelper
 
+    delegate :helper_method, to: :controller
     delegate :current_organization, to: :controller
+    delegate_missing_to :view_context
 
     cache :show, if: :perform_caching?, expires_in: :cache_expiry_time do
       cache_hash

data/lib/decidim/webpacker/esbuild.config.js

@@ -0,0 +1,14 @@
+// eslint-disable-next-line no-undef
+module.exports = {
+  options: {
+    tsconfigRaw: JSON.stringify({}),
+    target: "es2015"
+  },
+  bundle: true,
+  sourcemap: true,
+  minify: true,
+  outdir: "public",
+  outExtension: {
+    ".css": ".scss"
+  }
+};

data/lib/decidim/webpacker/shakapacker.yml

@@ -22,12 +22,12 @@ default: &default
   cache_manifest: false
 
   # Select loader to use, available options are 'babel' (default), 'swc' or 'esbuild'
-  webpack_loader: 'babel'
+  webpack_loader: 'esbuild'
 
   # Set to true to enable check for matching versions of shakapacker gem and NPM package - will raise an error if there is a mismatch or wildcard versioning is used
   ensure_consistent_versioning: true
 
-  # Select whether the compiler will use SHA digest ('digest' option) or most most recent modified timestamp ('mtime') to determine freshness
+  # Select whether the compiler will use SHA digest ('digest' option) or most recent modified timestamp ('mtime') to determine freshness
   compiler_strategy: digest
 
   # Select whether the compiler will always use a content hash and not just in production

data/lib/decidim/webpacker/tsconfig.json

@@ -0,0 +1,11 @@
+{
+  "compilerOptions": {
+    "strict": true,                                      /* Enable all strict type-checking options. */
+    "removeComments": true,                              /* Disable emitting comments. */
+    "allowJs": true,                                     /* Allow JavaScript files to be a part of your program. Use the `checkJS` option to get errors from these files. */
+    "module": "commonjs",                                /* Specify what module code is generated. */
+    "incremental": true,                                 /* Enable incremental compilation */
+    "target": "es6",                                     /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "skipLibCheck": true,                                /* Skip type checking all .d.ts files. */
+  }
+}

data/lib/decidim/webpacker/webpack/custom.js

@@ -1,7 +1,7 @@
 /* eslint-disable */
 const { config } = require("shakapacker");
 const { InjectManifest } = require("workbox-webpack-plugin");
-const TerserPlugin = require('terser-webpack-plugin')
+const { EsbuildPlugin } = require("esbuild-loader");
 
 module.exports = {
   module: {
@@ -15,8 +15,8 @@ module.exports = {
       },
       {
         test: /\.(js|jsx)$/,
-        exclude: /node_modules\/(?!tributejs)/,
-        loader: "babel-loader"
+        exclude: /node_modules\//,
+        loader: "esbuild-loader"
       },
       {
         test: /\.(graphql|gql)$/,
@@ -37,14 +37,11 @@ module.exports = {
         }
       },
       {
-        test: [
-          /\.md$/,
-          /\.odt$/,
-        ],
+        test: [/\.md$/, /\.odt$/],
         exclude: [/\.(js|mjs|jsx|ts|tsx)$/],
-        type: 'asset/resource',
+        type: "asset/resource",
         generator: {
-          filename: 'media/documents/[hash][ext][query]'
+          filename: "media/documents/[hash][ext][query]"
         }
       },
       // Overwrite webpacker files rule to amend the filename output
@@ -68,9 +65,9 @@ module.exports = {
           /\.svg$/
         ],
         exclude: [/\.(js|mjs|jsx|ts|tsx)$/],
-        type: 'asset/resource',
+        type: "asset/resource",
         generator: {
-          filename: 'media/images/[name]-[hash][ext][query]'
+          filename: "media/images/[name]-[hash][ext][query]"
         }
       }
     ]
@@ -81,32 +78,13 @@ module.exports = {
       crypto: false
     }
   },
-  // https://github.com/rails/webpacker/issues/2932
-  // As Decidim uses multiple packs, we need to enforce a single runtime, to prevent duplication
   optimization: {
     minimizer: [
-      new TerserPlugin({
-        parallel: Number.parseInt(process.env.SHAKAPACKER_PARALLEL, 10) || true,
-        terserOptions: {
-          parse: {
-            // Let terser parse ecma 8 code but always output
-            // ES5 compliant code for older browsers
-            ecma: 8
-          },
-          compress: {
-            ecma: 5,
-            warnings: false,
-            comparisons: false
-          },
-          mangle: { safari10: true },
-          output: {
-            ecma: 5,
-            comments: false,
-            ascii_only: true
-          }
-        }
+      new EsbuildPlugin({
+        target: "es2015",
+        css: true
       })
-    ].filter(Boolean)
+    ]
   },
   entry: config.entrypoints,
   plugins: [
@@ -122,4 +100,4 @@ module.exports = {
       swDest: "../sw.js"
     })
   ]
-}
+};

data/lib/devise/models/decidim_newsletterable.rb

@@ -2,7 +2,7 @@
 
 module Devise
   module Models
-    # Newsletterable adds all needed validations to acomplish GDPR standards
+    # Newsletterable adds all needed validations to accomplish GDPR standards
     # in newsletter notification mailing
     #
     # Validates that all users with notifications activated have Opt-in in

data/lib/tasks/decidim_download_your_data_tasks.rake

@@ -32,7 +32,7 @@ namespace :decidim do
           else
             puts " #{index}/#{users_count} !! [#{user_id}] DELETING USER"
             log.info " #{index}/#{users_count} !! [#{user_id}] DELETING USER"
-            Decidim::DestroyAccount.call(user, Decidim::DeleteAccountForm.from_params({})) # Delete user!
+            Decidim::DestroyAccount.call(Decidim::DeleteAccountForm.from_params({}).with_context({ current_user: user })) # Delete user!
           end
         else
           puts " #{index}/#{users_count} - [#{user_id}] User not found"
@@ -55,7 +55,7 @@ namespace :decidim do
     end
   end
 
-  desc "Check and notify users to update their newsletter notifications settings"
+  desc "Checks and notifies users to update their newsletter notifications settings"
   task check_users_newsletter_opt_in: :environment do
     print %(
 > This will send an email to all the users that have marked the newsletter by default. This should only be run if you were using Decidim before v0.11

data/lib/tasks/decidim_locales_tasks.rake

@@ -21,7 +21,7 @@ namespace :decidim do
       end
     end
 
-    desc "Rebuild the search index"
+    desc "Rebuilds the search index"
     task rebuild_search: :environment do
       Decidim::SearchableResource.destroy_all
       total = Decidim::Searchable.searchable_resources.count

data/lib/tasks/decidim_mailers_tasks.rake

@@ -2,12 +2,12 @@
 
 namespace :decidim do
   namespace :mailers do
-    desc "Task to send the notification digest email with the daily report"
+    desc "Sends the notification digest email with the daily report"
     task notifications_digest_daily: :environment do
       notifications_digest(:daily)
     end
 
-    desc "Task to send the notification digest email with the weekly report"
+    desc "Sends the notification digest email with the weekly report"
     task notifications_digest_weekly: :environment do
       notifications_digest(:weekly)
     end

data/lib/tasks/decidim_metrics_tasks.rake

@@ -7,7 +7,7 @@ namespace :decidim do
     # Get all metrics entities and execute its own rake task.
     # It admits a date-string parameter, in a 'YYYY-MM-DD' format from
     # today to all past dates
-    desc "Execute all metrics calculation methods"
+    desc "Calculates all metrics"
     task :all, [:day] => :environment do |_task, args|
       Decidim::Organization.find_each do |organization|
         Decidim.metrics_registry.all.each do |metric_manifest|
@@ -21,7 +21,7 @@ namespace :decidim do
     # Execute metric calculations for just one metric
     # It need a metric name and permits a date-string parameter, in a 'YYYY-MM-DD' format from
     # today to all past dates
-    desc "Execute one metric calculation method"
+    desc "Calculates one metric"
     task :one, [:metric, :day] => :environment do |_task, args|
       next if args.metric.blank?
 
@@ -31,7 +31,7 @@ namespace :decidim do
       end
     end
 
-    desc "Rebuild calculations from specific day"
+    desc "Rebuilds calculations from specific day"
     task :rebuild, [:metric, :day] => :environment do |_task, args|
       metric = args.metric
       day = args.day
@@ -47,10 +47,10 @@ namespace :decidim do
           Decidim::Organization.find_each do |organization|
             if metric
               m_manifest = Decidim.metrics_registry.for(metric)
-              log_info "[#{organization.name}]: rebuilding metric [#{metric}] for day [#{current_day}]"
+              log_info "[#{organization.name[organization.default_locale.to_s]}]: rebuilding metric [#{metric}] for day [#{current_day}]"
               call_metric_job(m_manifest, organization, current_day)
             else
-              log_info "[#{organization.name}]: rebuilding all metrics for day [#{current_day}]"
+              log_info "[#{organization.name[organization.default_locale.to_s]}]: rebuilding all metrics for day [#{current_day}]"
               Decidim.metrics_registry.all.each do |metric_manifest|
                 call_metric_job(metric_manifest, organization, current_day)
               end
@@ -63,7 +63,7 @@ namespace :decidim do
       end
     end
 
-    desc "Show available metrics"
+    desc "Shows the available metrics"
     task list: :environment do
       puts Decidim.metrics_registry.all.pluck :metric_name
     end

data/lib/tasks/decidim_procfile.rake

@@ -4,7 +4,7 @@ require "thor"
 
 namespace :decidim do
   namespace :procfile do
-    desc "Generates a dummy app for testing in external installations"
+    desc "Generates a script for starting the development app server"
     task :install do
       actions :create_file, "Procfile.dev", <<~RUBY
         web: bin/rails server -b 0.0.0.0 -p 3000
@@ -13,6 +13,12 @@ namespace :decidim do
 
       actions :create_file, "bin/dev", %(#!/usr/bin/env sh
 
+set -e
+
+bundle check || bundle install --jobs 20 --retry 5
+
+bin/rails decidim:upgrade db:migrate
+
 if ! gem list foreman -i --silent; then
   echo "Installing foreman..."
   gem install foreman
@@ -29,8 +35,8 @@ exec foreman start -f Procfile.dev "$@")
       include Thor::Actions
     end
 
-    def actions(*args)
-      Actions.new.send(*args)
+    def actions(*)
+      Actions.new.send(*)
     end
   end
 end

data/lib/tasks/decidim_tasks.rake

@@ -1,16 +1,18 @@
 # frozen_string_literal: true
 
 namespace :decidim do
-  desc "Install migrations from Decidim to the app."
+  desc "Performs upgrade tasks (migrations, node, docs )."
   task upgrade: [
     :choose_target_plugins,
     :"decidim:upgrade_app",
     :"railties:install:migrations",
-    :"decidim:webpacker:upgrade",
+    :"decidim:upgrade:webpacker",
     :"decidim_api:generate_docs"
   ]
 
-  desc "Setup environment so that only decidim migrations are installed."
+  task update: [:upgrade]
+
+  desc "Sets up environment so that only decidim migrations are installed."
   task :choose_target_plugins do
     ENV["FROM"] = %w(
       decidim
@@ -22,7 +24,6 @@ namespace :decidim do
       decidim_comments
       decidim_conferences
       decidim_debates
-      decidim_elections
       decidim_forms
       decidim_initiatives
       decidim_meetings