decidim-core 0.28.3 → 0.29.0.rc1

data/lib/decidim/core/test/shared_examples/attachable_interface_examples.rb

@@ -10,7 +10,7 @@ shared_examples_for "attachable interface" do
 
     it "includes the attachment urls" do
       attachment_urls = response["attachments"].map { |attachment| attachment["url"] }
-      expect(attachment_urls).to include_blob_urls(*attachments.map(&:file).map(&:blob))
+      expect(attachment_urls).to include(*attachments.map(&:url))
     end
   end
 end

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -16,8 +16,8 @@ shared_examples "comments" do
   it "shows the list of comments for the resource" do
     visit resource_path
 
-    expect(page).to have_selector("#comments")
-    expect(page).to have_selector(".comment", count: comments.length)
+    expect(page).to have_css("#comments")
+    expect(page).to have_css(".comment", count: comments.length)
 
     within "#comments" do
       comments.each do |comment|
@@ -33,12 +33,12 @@ shared_examples "comments" do
 
     visit resource_path
 
-    expect(page).not_to have_content("Comments are disabled at this time")
+    expect(page).to have_no_content("Comments are disabled at this time")
 
     expect(page).to have_css(".comment", minimum: 1)
 
     within ".comment-order-by" do
-      click_link "Best rated"
+      click_on "Best rated"
     end
 
     expect(page).to have_css(".comments > div:nth-child(2)", text: "Most Rated Comment")
@@ -50,7 +50,7 @@ shared_examples "comments" do
 
     it "displays the show replies link on comment with reply" do
       visit resource_path
-      expect(page).not_to have_content("Comments are disabled at this time")
+      expect(page).to have_no_content("Comments are disabled at this time")
       expect(page).to have_css(".comment", minimum: 1)
 
       within("#accordion-#{single_comment.id}") do
@@ -66,11 +66,11 @@ shared_examples "comments" do
 
       it "displays the show replies link on comment with reply" do
         visit resource_path
-        expect(page).not_to have_content("Comments are disabled at this time")
+        expect(page).to have_no_content("Comments are disabled at this time")
         expect(page).to have_css(".comment", minimum: 1)
 
         within("#accordion-#{single_comment.id}") do
-          expect(page).not_to have_content "Hide reply"
+          expect(page).to have_no_content "Hide reply"
         end
       end
     end
@@ -85,18 +85,18 @@ shared_examples "comments" do
     end
 
     it "shows only a deletion message for deleted comments" do
-      expect(page).to have_selector("#comment_#{deleted_comment.id}")
+      expect(page).to have_css("#comment_#{deleted_comment.id}")
 
-      expect(page).not_to have_content(deleted_comment.author.name)
-      expect(page).not_to have_content(translated(deleted_comment.body))
+      expect(page).to have_no_content(deleted_comment.author.name)
+      expect(page).to have_no_content(translated(deleted_comment.body))
       within "#comment_#{deleted_comment.id}" do
         expect(page).to have_content("Comment deleted on")
-        expect(page).not_to have_selector("comment__footer")
+        expect(page).to have_no_css(".comment__header")
       end
     end
 
     it "counts only not deleted comments" do
-      expect(page).to have_selector("span.comments-count", text: "#{comments.length - 1} comments")
+      expect(page).to have_css("span.comments-count", text: "#{comments.length - 1} comments")
     end
 
     context "when deleted comment has replies, they are shown" do
@@ -106,7 +106,7 @@ shared_examples "comments" do
         visit resource_path
 
         within "#comment_#{deleted_comment.id}" do
-          expect(page).to have_selector("#comment-#{deleted_comment.id}-replies")
+          expect(page).to have_css("#comment-#{deleted_comment.id}-replies")
           expect(page).to have_content(reply.author.name)
           expect(page).to have_content(reply.body.values.first)
         end
@@ -117,7 +117,7 @@ shared_examples "comments" do
   context "when not authenticated" do
     it "does not show form to add comments to user" do
       visit resource_path
-      expect(page).not_to have_css(".add-comment form")
+      expect(page).to have_no_css(".add-comment form")
       expect(page).to have_css(".comment-thread")
     end
   end
@@ -129,7 +129,7 @@ shared_examples "comments" do
     end
 
     it "shows form to add comments to user" do
-      expect(page).to have_selector(".add-comment form")
+      expect(page).to have_css(".add-comment form")
     end
 
     context "when user is not authorized to comment" do
@@ -153,7 +153,7 @@ shared_examples "comments" do
 
       it "shows a message indicating that comments are restricted" do
         visit resource_path
-        expect(page).not_to have_content("Comments are disabled at this time")
+        expect(page).to have_no_content("Comments are disabled at this time")
         expect(page).to have_content("You need to be verified to comment at this moment")
       end
     end
@@ -161,27 +161,33 @@ shared_examples "comments" do
     describe "when using emojis" do
       before do
         within_language_menu do
-          click_link "Castellano"
+          click_on "Castellano"
         end
       end
       shared_examples_for "allowing to select emojis" do
         it "allows selecting emojis" do
           within_language_menu do
-            click_link locale
+            click_on locale
           end
 
           within ".add-comment form" do
-            expect(page).to have_selector(".emoji__container")
-            expect(page).to have_selector(".emoji__trigger .emoji__button")
+            expect(page).to have_css(".emoji__container")
+            expect(page).to have_css(".emoji__trigger .emoji__button")
             find(".emoji__trigger .emoji__button").click
           end
 
-          within ".picmo__popupContainer .picmo__picker .picmo__content" do
+          within ".emoji__decidim" do
             expect(page).to have_content(phrase)
-            categories = page.all(".picmo__emojiCategory")
-            within categories[1] do
-              click_button "😀"
-            end
+            # Since emoji-mart is a React component, we need to use JS to click on an emoji icon
+            # as the emoji picker is a shadow DOM element.
+            # The script below is trying to find the first emoji in the "Smileys & People" category and simulate
+            # a click from the user on it.
+            script = <<~JS
+              var emoji_picker = document.getElementsByTagName("em-emoji-picker")[0];
+              var category = emoji_picker.shadowRoot.querySelectorAll("div.category")[1]
+              category.querySelectorAll("button")[0].click();
+            JS
+            execute_script(script)
           end
 
           within ".add-comment form" do
@@ -192,14 +198,14 @@ shared_examples "comments" do
 
       context "when the locale is supported" do
         let(:locale) { "English" }
-        let(:phrase) { "SMILEYS & EMOTION" }
+        let(:phrase) { I18n.t("emojis.categories.people") }
 
         it_behaves_like "allowing to select emojis"
       end
 
       context "when the locale is not supported" do
         let(:locale) { "Català" }
-        let(:phrase) { "SOMRIURES I EMOCIONS" }
+        let(:phrase) { I18n.with_locale(:ca) { I18n.t("emojis.categories.people") } }
 
         it_behaves_like "allowing to select emojis"
       end
@@ -452,11 +458,11 @@ shared_examples "comments" do
               field.native.send_keys "toto"
             end
 
-            expect(page).not_to have_selector(".picmo__picker.picmo__picker")
+            expect(page).to have_no_css(".emoji__decidim")
             within "form#new_comment_for_#{commentable.commentable_type.demodulize}_#{commentable.id}" do
               find(".emoji__button").click
             end
-            expect(page).to have_selector(".picmo__picker.picmo__picker")
+            expect(page).to have_css(".emoji__decidim")
           end
         end
 
@@ -471,7 +477,7 @@ shared_examples "comments" do
               field.native.send_keys("0123456789012345678901234567")
               find(".emoji__button").click
             end
-            expect(page).not_to have_selector(".picmo__picker.picmo__picker")
+            expect(page).to have_no_css(".emoji-picker__picker.emoji-picker__picker")
           end
         end
       end
@@ -485,13 +491,13 @@ shared_examples "comments" do
           field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
           field.set " "
           field.native.send_keys content
-          click_button "Publish comment"
+          click_on "Publish comment"
         end
       end
 
       it "shows comment to the user, updates the comments counter and clears the comment textarea" do
         expect(page).to have_comment_from(user, content, wait: 20)
-        expect(page).to have_selector("span.comments-count", text: "#{commentable.comments.count} comments")
+        expect(page).to have_css("span.comments-count", text: "#{commentable.comments.count} comments")
         expect(page.find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}").value).to be_empty
       end
     end
@@ -504,7 +510,7 @@ shared_examples "comments" do
           field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
           field.set " "
           field.native.send_keys content
-          click_button "Publish comment"
+          click_on "Publish comment"
         end
       end
 
@@ -555,9 +561,9 @@ shared_examples "comments" do
         it "displays the show button" do
           visit current_path
           within "#comment_#{thread.id}" do
-            click_button "Hide reply"
+            click_on "Hide reply"
             expect(page).to have_content("Show reply")
-            expect(page).not_to have_content(new_reply_body)
+            expect(page).to have_no_content(new_reply_body)
           end
         end
 
@@ -567,9 +573,9 @@ shared_examples "comments" do
           it "displays the show button" do
             visit current_path
             within "#comment_#{thread.id}" do
-              click_button "Hide 3 replies"
+              click_on "Hide 3 replies"
               expect(page).to have_content("Show 3 replies")
-              expect(page).not_to have_content(new_reply_body)
+              expect(page).to have_no_content(new_reply_body)
             end
           end
         end
@@ -618,7 +624,7 @@ shared_examples "comments" do
           field.set " "
           field.native.send_keys content
           select user_group.name, from: "Comment as"
-          click_button "Publish comment"
+          click_on "Publish comment"
         end
 
         expect(page).to have_comment_from(user_group, content, wait: 20)
@@ -639,7 +645,7 @@ shared_examples "comments" do
         it "the context menu of the comment does not show a delete link" do
           within "#comment_#{comment.id}" do
             page.find("[id^='dropdown-trigger']").click
-            expect(page).not_to have_link("Delete")
+            expect(page).to have_no_link("Delete")
           end
         end
       end
@@ -659,18 +665,18 @@ shared_examples "comments" do
 
           within "#comment_#{comment.id}" do
             page.find("[id^='dropdown-trigger']").click
-            click_link "Delete"
+            click_on "Delete"
           end
 
           accept_confirm
 
-          expect(page).to have_selector("#comment_#{comment.id}")
+          expect(page).to have_css("#comment_#{comment.id}")
           within "#comment_#{comment.id}" do
             expect(page).to have_content("Comment deleted on")
-            expect(page).not_to have_content comment_author.name
-            expect(page).not_to have_selector("comment__footer")
+            expect(page).to have_no_content comment_author.name
+            expect(page).to have_no_css(".comment__header")
           end
-          expect(page).to have_selector("span.comments-count", text: "3 comments")
+          expect(page).to have_css("span.comments-count", text: "3 comments")
 
           expect(Decidim::Comments::Comment.not_deleted.count).to eq(3)
         end
@@ -692,7 +698,7 @@ shared_examples "comments" do
           within "#comment_#{comment.id}" do
             # Toolbar
             page.find("[id^='dropdown-trigger']").click
-            expect(page).not_to have_button("Edit")
+            expect(page).to have_no_button("Edit")
           end
         end
       end
@@ -713,16 +719,16 @@ shared_examples "comments" do
             within "#comment_#{comment.id}" do
               # Toolbar
               page.find("[id^='dropdown-trigger']").click
-              click_button "Edit"
+              click_on "Edit"
             end
             fill_in "edit_comment_#{comment.id}", with: " This comment has been fixed"
-            click_button "Send"
+            click_on "Send"
           end
 
           it "the comment body changes" do
             within "#comment_#{comment.id}" do
               expect(page).to have_content("This comment has been fixed")
-              expect(page).not_to have_content(comment_body)
+              expect(page).to have_no_content(comment_body)
             end
           end
 
@@ -744,20 +750,20 @@ shared_examples "comments" do
         visit resource_path
 
         within "#comments #comment_#{comment.id}" do
-          click_button "Reply"
+          click_on "Reply"
         end
 
-        expect(page).to have_selector("#comment_#{comment.id} .add-comment")
+        expect(page).to have_css("#comment_#{comment.id} .add-comment")
 
         within "form#new_comment_for_#{comment.commentable_type.demodulize}_#{comment.id}" do
           field = find("#add-comment-#{comment.commentable_type.demodulize}-#{comment.id}")
           field.set " "
           field.native.send_keys content
-          click_button "Publish reply"
+          click_on "Publish reply"
         end
 
         expect(page).to have_reply_to(comment, content)
-        expect(page).to have_selector("span.comments-count", text: "#{commentable.comments.count} comments")
+        expect(page).to have_css("span.comments-count", text: "#{commentable.comments.count} comments")
         expect(page).to have_reply_to(comment, "This is a reply")
       end
     end
@@ -772,7 +778,7 @@ shared_examples "comments" do
         visit current_path
 
         within "#comments #comment_#{parent.id}" do
-          expect(page).to have_selector("#comment-#{parent.id}-replies")
+          expect(page).to have_css("#comment-#{parent.id}-replies")
           expect(page.find("#comment-#{parent.id}-replies").text).to be_blank
         end
       end
@@ -783,29 +789,29 @@ shared_examples "comments" do
         before do
           visit resource_path
 
-          expect(page).to have_selector(".add-comment form")
+          expect(page).to have_css(".add-comment form")
         end
 
         it "works according to the setting in the commentable" do
           if commentable.comments_have_alignment?
-            page.find(".opinion-toggle--ok").click
-            expect(page.find(".opinion-toggle--ok")["aria-pressed"]).to eq("true")
-            expect(page.find(".opinion-toggle--meh")["aria-pressed"]).to eq("false")
-            expect(page.find(".opinion-toggle--ko")["aria-pressed"]).to eq("false")
-            expect(page.find(".opinion-toggle .selected-state", visible: false)).to have_content("Your opinion about this topic is positive")
+            page.find("[data-toggle-ok=true]").click
+            expect(page.find("[data-toggle-ok=true]")["aria-pressed"]).to eq("true")
+            expect(page.find("[data-toggle-meh=true]")["aria-pressed"]).to eq("false")
+            expect(page.find("[data-toggle-ko=true]")["aria-pressed"]).to eq("false")
+            expect(page.find("div[data-opinion-toggle] .selected-state", visible: false)).to have_content("Your opinion about this topic is positive")
 
             within "form#new_comment_for_#{commentable.commentable_type.demodulize}_#{commentable.id}" do
               field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
               field.set " "
               field.native.send_keys "I am in favor about this!"
-              click_button "Publish comment"
+              click_on "Publish comment"
             end
 
             within "#comments" do
-              expect(page).to have_selector "span.success.label", text: "In favor", wait: 20
+              expect(page).to have_css "span.success.label", text: "In favor", wait: 20
             end
           else
-            expect(page).not_to have_selector(".opinion-toggle--ok")
+            expect(page).to have_no_css("[data-toggle-ok=true]")
           end
         end
       end
@@ -820,11 +826,11 @@ shared_examples "comments" do
         it "works according to the setting in the commentable" do
           within "#comment_#{comments[0].id}" do
             if commentable.comments_have_votes?
-              expect(page).to have_selector(".js-comment__votes--up", text: /0/)
+              expect(page).to have_css(".js-comment__votes--up", text: /0/)
               page.find(".js-comment__votes--up").click
-              expect(page).to have_selector(".js-comment__votes--up", text: /1/)
+              expect(page).to have_css(".js-comment__votes--up", text: /1/)
             else
-              expect(page).not_to have_selector(".js-comment__votes--up", text: /0/)
+              expect(page).to have_no_css(".js-comment__votes--up", text: /0/)
             end
           end
         end
@@ -836,10 +842,10 @@ shared_examples "comments" do
             skip "Commentable comments has no votes" unless commentable.comments_have_votes?
 
             visit current_path
-            expect(page).to have_selector("#comment_#{comments[0].id} > .comment__footer > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/)
-            page.find("#comment_#{comments[0].id} > .comment__footer > .comment__footer-grid .comment__votes .js-comment__votes--up").click
-            expect(page).to have_selector("#comment_#{comments[0].id} > .comment__footer > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /1/)
-            expect(page).to have_selector("#comment_#{comment_on_comment.id} > .comment__footer > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/)
+            expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/)
+            page.find("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up").click
+            expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /1/)
+            expect(page).to have_css("#comment_#{comment_on_comment.id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/)
           end
         end
       end
@@ -848,11 +854,11 @@ shared_examples "comments" do
         it "works according to the setting in the commentable" do
           within "#comment_#{comments[0].id}" do
             if commentable.comments_have_votes?
-              expect(page).to have_selector(".js-comment__votes--down", text: /0/)
+              expect(page).to have_css(".js-comment__votes--down", text: /0/)
               page.find(".js-comment__votes--down").click
-              expect(page).to have_selector(".js-comment__votes--down", text: /1/)
+              expect(page).to have_css(".js-comment__votes--down", text: /1/)
             else
-              expect(page).not_to have_selector(".js-comment__votes--down", text: /0/)
+              expect(page).to have_no_css(".js-comment__votes--down", text: /0/)
             end
           end
         end
@@ -876,7 +882,7 @@ shared_examples "comments" do
 
         context "when text finish with a mention" do
           it "shows the tribute container" do
-            expect(page).to have_selector(".tribute-container", text: mentioned_user.name, wait: 10)
+            expect(page).to have_css(".tribute-container", text: mentioned_user.name, wait: 10)
           end
         end
 
@@ -884,7 +890,7 @@ shared_examples "comments" do
           let(:content) { "A valid user mention: @#{mentioned_user.nickname}." }
 
           it "shows the tribute container" do
-            expect(page).not_to have_selector(".tribute-container", text: mentioned_user.name)
+            expect(page).to have_no_css(".tribute-container", text: mentioned_user.name)
           end
         end
       end
@@ -894,7 +900,7 @@ shared_examples "comments" do
         let(:content) { "A unconfirmed user mention: @#{mentioned_user.nickname}" }
 
         it "do not show the tribute container" do
-          expect(page).not_to have_selector(".tribute-container", text: mentioned_user.name)
+          expect(page).to have_no_css(".tribute-container", text: mentioned_user.name)
         end
       end
 
@@ -903,7 +909,7 @@ shared_examples "comments" do
         let(:content) { "A confirmed user group mention: @#{mentioned_group.nickname}" }
 
         it "shows the tribute container" do
-          expect(page).to have_selector(".tribute-container", text: mentioned_group.nickname, wait: 10)
+          expect(page).to have_css(".tribute-container", text: mentioned_group.nickname, wait: 10)
         end
       end
     end
@@ -916,7 +922,7 @@ shared_examples "comments" do
           field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
           field.set " "
           field.native.send_keys content
-          click_button "Publish comment"
+          click_on "Publish comment"
         end
       end
 
@@ -937,7 +943,7 @@ shared_examples "comments" do
 
         it "ignores the mention" do
           expect(page).to have_comment_from(user, "This text mentions a user outside current organization: @#{mentioned_user.nickname}", wait: 20)
-          expect(page).not_to have_link "@#{mentioned_user.nickname}"
+          expect(page).to have_no_link "@#{mentioned_user.nickname}"
         end
       end
 
@@ -946,7 +952,7 @@ shared_examples "comments" do
 
         it "ignores the mention" do
           expect(page).to have_comment_from(user, "This text mentions a @nonexistent user", wait: 20)
-          expect(page).not_to have_link "@nonexistent"
+          expect(page).to have_no_link "@nonexistent"
         end
       end
     end
@@ -961,7 +967,7 @@ shared_examples "comments" do
           field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
           field.set " "
           field.native.send_keys content
-          click_button "Publish comment"
+          click_on "Publish comment"
         end
       end
 
@@ -1009,7 +1015,7 @@ shared_examples "comments blocked" do
       it "shows a message indicating that comments are disabled" do
         visit resource_path
         expect(page).to have_content("Comments are disabled at this time")
-        expect(page).not_to have_content("You need to be verified to comment at this moment")
+        expect(page).to have_no_content("You need to be verified to comment at this moment")
       end
     end
   end
@@ -1034,7 +1040,7 @@ shared_examples "comments blocked" do
       it "shows a message indicating that comments are disabled" do
         visit resource_path
         expect(page).to have_content("Comments are disabled at this time")
-        expect(page).not_to have_content("You need to be verified to comment at this moment")
+        expect(page).to have_no_content("You need to be verified to comment at this moment")
       end
     end
   end

data/lib/decidim/core/test/shared_examples/comments_reports_examples.rb

@@ -7,7 +7,7 @@ shared_examples "comments_reports" do
 
       # Open toolbar
       page.find("[id^='dropdown-trigger']").click
-      click_button "Report"
+      click_on "Report"
 
       expect(page).to have_css("#loginModal", visible: :visible)
     end
@@ -24,12 +24,12 @@ shared_examples "comments_reports" do
 
         # Open toolbar
         page.find("[id^='dropdown-trigger']").click
-        click_button "Report"
+        click_on "Report"
 
         expect(page).to have_css(".flag-modal", visible: :visible)
 
         within ".flag-modal" do
-          click_button "Report"
+          click_on "Report"
         end
 
         expect(page).to have_content "report has been created"
@@ -47,7 +47,7 @@ shared_examples "comments_reports" do
 
         # Open toolbar
         page.find("[id^='dropdown-trigger']").click
-        click_button "Report"
+        click_on "Report"
 
         expect(page).to have_css(".flag-modal", visible: :visible)
 

data/lib/decidim/core/test/shared_examples/digest_mail_examples.rb

@@ -15,7 +15,7 @@ shared_context "when sends the notification digest" do
 end
 
 shared_examples_for "notification digest mail" do
-  context "when a notificable event takes place" do
+  context "when a notifiable event takes place" do
     let!(:organization) { create(:organization) }
     let!(:participatory_space) { create(:participatory_process, organization:) }
 

data/lib/decidim/core/test/shared_examples/edit_link_shared_examples.rb

@@ -27,7 +27,7 @@ shared_examples "editable content for admins" do
       let(:user) { create(:user, :confirmed, organization:) }
 
       it "does not have a link to edit the content at the admin" do
-        expect(page).not_to have_css(header_selector)
+        expect(page).to have_no_css(header_selector)
       end
     end
   end

data/lib/decidim/core/test/shared_examples/editor_shared_examples.rb

@@ -18,25 +18,25 @@ shared_examples_for "has embedded video in description" do |description_attribut
 
   context "when cookies are rejected" do
     before do
-      click_link "Cookie settings"
-      click_button "Accept only essential"
+      click_on "Cookie settings"
+      click_on "Accept only essential"
     end
 
     it "disables iframe" do
       expect(page).to have_content(cookie_warning)
-      expect(page).not_to have_selector("iframe")
+      expect(page).to have_no_css("iframe")
     end
   end
 
   context "when cookies are accepted" do
     before do
-      click_link "Cookie settings"
-      click_button "Accept all"
+      click_on "Cookie settings"
+      click_on "Accept all"
     end
 
     it "shows iframe" do
-      expect(page).not_to have_content(cookie_warning)
-      expect(page).to have_selector("iframe", count:)
+      expect(page).to have_no_content(cookie_warning)
+      expect(page).to have_css("iframe", count:)
     end
   end
 end

data/lib/decidim/core/test/shared_examples/fingerprint_examples.rb

@@ -5,7 +5,7 @@ shared_examples "fingerprint" do
 
   it "shows a fingerprint" do
     visit(resource_locator(fingerprintable).path)
-    click_button("Check fingerprint")
+    click_on("Check fingerprint")
 
     within ".fingerprint-modal" do
       expect(page).to(have_content(fingerprintable.fingerprint.value))