decidim-core 0.28.3 → 0.29.0.rc1

data/lib/decidim/component_manifest.rb

@@ -136,7 +136,9 @@ module Decidim
     #
     # Returns nothing.
     def seed!(participatory_space)
+      # rubocop:disable Rails/Output
       print "-- Creating #{name} component seeds for the participatory space with ID: #{participatory_space.id}...\n" unless Rails.env.test?
+      # rubocop:enable Rails/Output
       @seeds&.call(participatory_space)
     end
 
@@ -259,7 +261,7 @@ module Decidim
     end
 
     # Public: Finds the specific data importer class from its name, using the
-    # `specific_data_importerer_class_name` attribute. If the class does not exist,
+    # `specific_data_importer_class_name` attribute. If the class does not exist,
     # it raises an exception. If the class name is not set, it returns nil.
     #
     # Returns a Decidim::Importers::Importer subclass or nil.

data/lib/decidim/component_validator.rb

@@ -4,7 +4,7 @@
 #
 # Adds a presence validation and checks that the manifest is the correct one.
 class ComponentValidator < ActiveModel::EachValidator
-  # Validates the arguiments passed to the validator.
+  # Validates the arguments passed to the validator.
   def check_validity!
     raise ArgumentError, "You must include a `manifest` option with the name of the manifest to validate when validating a component" if options[:manifest].blank?
   end

data/lib/decidim/content_blocks/has_related_components.rb

@@ -6,7 +6,7 @@ module Decidim
       extend ActiveSupport::Concern
 
       included do
-        # This method allows us to detect the components related whith a
+        # This method allows us to detect the components related with a
         # content block. The content block can have different components
         # associated depending on the scope_name. The scope names and their
         # associated models are configured in Decidim::ContentBlocks::BaseCell

data/lib/decidim/content_parsers/resource_parser.rb

@@ -19,8 +19,8 @@ module Decidim
       #
       # @return [String] the content with the valid mentions replaced by a global id.
       def rewrite
-        rewrited_content = parse_for_urls(content)
-        parse_for_ids(rewrited_content)
+        rewritten_content = parse_for_urls(content)
+        parse_for_ids(rewritten_content)
       end
 
       private

data/lib/decidim/content_processor.rb

@@ -127,7 +127,7 @@ module Decidim
     #
     # @return [String] sanitized content.
     def self.sanitize(text, options = {})
-      Rails::Html::WhiteListSanitizer.new.sanitize(
+      Rails::Html::SafeListSanitizer.new.sanitize(
         text,
         { scrubber: Decidim::UserInputScrubber.new }.merge(options)
       ).try(:html_safe)

data/lib/decidim/content_security_policy.rb

@@ -122,7 +122,7 @@ module Decidim
         "style-src" => %w('self' 'unsafe-inline'),
         "img-src" => %w('self' *.hereapi.com data:),
         "font-src" => %w('self'),
-        "connect-src" => %w('self' *.hereapi.com *.jsdelivr.net data:),
+        "connect-src" => %w('self' *.hereapi.com data:),
         "frame-src" => %w('self' www.youtube-nocookie.com player.vimeo.com),
         "media-src" => %w('self')
       }

data/lib/decidim/core/engine.rb

@@ -13,7 +13,6 @@ require "devise-i18n"
 require "devise_invitable"
 require "foundation_rails_helper"
 require "active_link_to"
-require "carrierwave"
 require "rails-i18n"
 require "date_validator"
 require "file_validators"
@@ -40,15 +39,13 @@ require "ransack"
 require "wisper"
 require "shakapacker"
 
-# Needed for the assets:precompile task, for configuring webpacker instance
-require "decidim/webpacker"
-
 require "decidim/api"
 require "decidim/core/content_blocks/registry_manager"
 require "decidim/core/menu"
 require "decidim/middleware/strip_x_forwarded_host"
 require "decidim/middleware/static_dispatcher"
 require "decidim/middleware/current_organization"
+require "decidim/webpacker"
 
 module Decidim
   module Core
@@ -159,6 +156,7 @@ module Decidim
 
         # Attachments
         Decidim.icons.register(name: "file-text-line", icon: "file-text-line", category: "system", description: "", engine: :core)
+        Decidim.icons.register(name: "file-upload-line", icon: "file-upload-line", category: "documents", description: "File upload", engine: :core)
         Decidim.icons.register(name: "scales-2-line", icon: "scales-2-line", category: "system", description: "", engine: :core)
         Decidim.icons.register(name: "image-line", icon: "image-line", category: "system", description: "", engine: :core)
         Decidim.icons.register(name: "error-warning-line", icon: "error-warning-line", category: "system", description: "", engine: :core)
@@ -225,6 +223,10 @@ module Decidim
         ENV["SHAKAPACKER_CONFIG"] = Decidim::Webpacker.configuration.configuration_file
       end
 
+      initializer "decidim_core.active_storage_variant_processor" do |app|
+        app.config.active_storage.variant_processor = :mini_magick
+      end
+
       initializer "decidim_core.action_controller" do |_app|
         config.to_prepare do
           ActiveSupport.on_load :action_controller do
@@ -237,14 +239,6 @@ module Decidim
         app.config.action_mailer.deliver_later_queue_name = :mailers
       end
 
-      initializer "decidim_core.signed_global_id", after: "global_id" do |app|
-        next if app.config.global_id.fetch(:expires_in, nil).present?
-
-        config.after_initialize do
-          SignedGlobalID.expires_in = nil
-        end
-      end
-
       initializer "decidim_core.middleware" do |app|
         if app.config.public_file_server.enabled
           headers = app.config.public_file_server.headers || {}
@@ -290,7 +284,7 @@ module Decidim
         Ransack.configure do |config|
           # Avoid turning parameter values such as user_id[]=1&user_id[]=2 into
           # { user_id: [true, "2"] }. This option allows us to handle the type
-          # convertions manually instead for each case.
+          # conversions manually instead for each case.
           # See: https://github.com/activerecord-hackery/ransack/issues/593
           # See: https://github.com/activerecord-hackery/ransack/pull/742
           config.sanitize_custom_scope_booleans = false
@@ -306,8 +300,8 @@ module Decidim
         end
       end
 
-      initializer "decidim_core.i18n_exceptions" do
-        ActionView::Base.raise_on_missing_translations = true unless Rails.env.production?
+      initializer "decidim_core.i18n_exceptions" do |app|
+        app.config.i18n.raise_on_missing_translations = true unless Rails.env.production?
       end
 
       initializer "decidim_core.geocoding", after: :load_config_initializers do
@@ -387,18 +381,13 @@ module Decidim
 
       initializer "decidim_core.menu" do
         Decidim::Core::Menu.register_menu!
+        Decidim::Core::Menu.register_mobile_menu!
         Decidim::Core::Menu.register_user_menu!
       end
 
       initializer "decidim_core.notifications" do
-        if Rails.autoloaders.zeitwerk_enabled?
-          config.after_initialize do
-            Decidim::EventsManager.subscribe_events!
-          end
-        else
-          config.to_prepare do
-            Decidim::EventsManager.subscribe_events!
-          end
+        config.after_initialize do
+          Decidim::EventsManager.subscribe_events!
         end
       end
 

data/lib/decidim/core/menu.rb

@@ -10,12 +10,22 @@ module Decidim
                         decidim.root_path,
                         position: 1,
                         active: :exclusive
+        end
+      end
 
-          menu.add_item :pages,
+      def self.register_mobile_menu!
+        Decidim.menu :mobile_menu do |menu|
+          menu.add_item :root,
+                        I18n.t("menu.home", scope: "decidim"),
+                        decidim.root_path,
+                        position: 1,
+                        active: :exclusive
+
+          menu.add_item :help,
                         I18n.t("menu.help", scope: "decidim"),
                         decidim.pages_path,
-                        position: 7,
-                        active: :inclusive
+                        position: 10,
+                        active: :exclusive
         end
       end
 

data/lib/decidim/core/seeds.rb

@@ -8,164 +8,53 @@ require "decidim/faker/internet"
 module Decidim
   module Core
     class Seeds < Decidim::Seeds
-      # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Rails/Output
       def call
-        print "Creating seeds for decidim-core...\n" unless Rails.env.test?
+        print "Creating seeds for decidim-core...\n" unless Rails.env.test? # rubocop:disable Rails/Output
 
-        # Since we usually migrate and seed in the same process, make sure
-        # that we do not have invalid or cached information after a migration.
-        decidim_tables = ActiveRecord::Base.connection.tables.select do |table|
-          table.starts_with?("decidim_")
-        end
-        decidim_tables.map do |table|
-          table.tr("_", "/").classify.safe_constantize
-        end.compact.each(&:reset_column_information)
+        Rails.application.reloader.reload! if Rails.application.reloader.check!
+        reset_column_information
 
-        smtp_label = ENV.fetch("SMTP_FROM_LABEL", ::Faker::Twitter.unique.screen_name)
-        smtp_email = ENV.fetch("SMTP_FROM_EMAIL", ::Faker::Internet.email)
+        ActiveJob::Base.queue_adapter = :inline
 
-        primary_color, secondary_color, tertiary_color = [
-          ["#bf4044", "#09780e", "#3584e4"],
-          ["#09780e", "#4448bb", "#da565b"],
-          ["#bf4086", "#487511", "#5384ac"],
-          ["#086263", "#811380", "#abac53"],
-          ["#5340bf", "#a82c2c", "#40bf53"]
-        ].sample
-
-        colors = {
-          alert: "#e7131a",
-          primary: primary_color,
-          secondary: secondary_color,
-          tertiary: tertiary_color,
-          success: "#28a745",
-          warning: "#ffb703"
-        }
-
-        organization = Decidim::Organization.first || Decidim::Organization.create!(
-          name: ::Faker::Company.name,
-          twitter_handler: ::Faker::Hipster.word,
-          facebook_handler: ::Faker::Hipster.word,
-          instagram_handler: ::Faker::Hipster.word,
-          youtube_handler: ::Faker::Hipster.word,
-          github_handler: ::Faker::Hipster.word,
-          smtp_settings: {
-            from: "#{smtp_label} <#{smtp_email}>",
-            from_email: smtp_email,
-            from_label: smtp_label,
-            user_name: ENV.fetch("SMTP_USERNAME", ::Faker::Twitter.unique.screen_name),
-            encrypted_password: Decidim::AttributeEncryptor.encrypt(ENV.fetch("SMTP_PASSWORD", ::Faker::Internet.password(min_length: 8))),
-            address: ENV.fetch("SMTP_ADDRESS", nil) || ENV.fetch("DECIDIM_HOST", "localhost"),
-            port: ENV.fetch("SMTP_PORT", nil) || ENV.fetch("DECIDIM_SMTP_PORT", "25")
-          },
-          host: ENV.fetch("DECIDIM_HOST", "localhost"),
-          secondary_hosts: ENV.fetch("DECIDIM_HOST", "localhost") == "localhost" ? ["0.0.0.0", "127.0.0.1"] : nil,
-          external_domain_whitelist: ["decidim.org", "github.com"],
-          description: Decidim::Faker::Localized.wrapped("<p>", "</p>") do
-            Decidim::Faker::Localized.sentence(word_count: 15)
-          end,
-          default_locale: Decidim.default_locale,
-          available_locales: Decidim.available_locales,
-          reference_prefix: ::Faker::Name.suffix,
-          available_authorizations: Decidim.authorization_workflows.map(&:name),
-          users_registration_mode: :enabled,
-          tos_version: Time.current,
-          badges_enabled: true,
-          user_groups_enabled: true,
-          send_welcome_notification: true,
-          file_upload_settings: Decidim::OrganizationSettings.default(:upload),
-          colors:
-        )
+        organization = create_organization!
 
         if organization.top_scopes.none?
           province = create_scope_type!(name: "province", plural: "provinces")
           municipality = create_scope_type!(name: "municipality", plural: "municipalities")
+
           3.times do
             parent = create_scope!(scope_type: province, parent: nil)
+
             5.times do
               create_scope!(scope_type: municipality, parent:)
             end
           end
         end
 
-        territorial = Decidim::AreaType.create!(
-          name: Decidim::Faker::Localized.literal("territorial"),
-          plural: Decidim::Faker::Localized.literal("territorials"),
-          organization:
-        )
-
-        sectorial = Decidim::AreaType.create!(
-          name: Decidim::Faker::Localized.literal("sectorials"),
-          plural: Decidim::Faker::Localized.literal("sectorials"),
-          organization:
-        )
+        territorial = create_area_type!(name: "territorial", plural: "territorials")
+        sectorial = create_area_type!(name: "sectorials", plural: "sectorials")
 
         3.times do
-          Decidim::Area.create!(
-            name: Decidim::Faker::Localized.word,
-            area_type: territorial,
-            organization:
-          )
+          create_area!(area_type: territorial)
         end
 
         5.times do
-          Decidim::Area.create!(
-            name: Decidim::Faker::Localized.word,
-            area_type: sectorial,
-            organization:
-          )
+          create_area!(area_type: sectorial)
         end
 
-        admin = Decidim::User.find_or_initialize_by(email: "admin@example.org")
-        admin_hash = {
-          name: ::Faker::Name.name,
-          nickname: ::Faker::Twitter.unique.screen_name,
-          organization:,
-          confirmed_at: Time.current,
-          locale: I18n.default_locale,
+        admin = find_or_initialize_user_by(email: "admin@example.org")
+        admin.update!(
           admin: true,
-          tos_agreement: true,
-          personal_url: ::Faker::Internet.url,
-          about: ::Faker::Lorem.paragraph(sentence_count: 2),
-          accepted_tos_version: organization.tos_version + 1.hour,
-          newsletter_notifications_at: Time.current,
-          password_updated_at: Time.current,
           admin_terms_accepted_at: Time.current
-        }
-        admin_hash.merge!(password: "decidim123456789") if admin.encrypted_password.blank?
-        admin.update!(admin_hash)
+        )
 
         ["user@example.org", "user2@example.org"].each do |email|
-          Decidim::User.find_or_initialize_by(email:).update!(
-            name: ::Faker::Name.name,
-            nickname: ::Faker::Twitter.unique.screen_name,
-            password: "decidim123456789",
-            confirmed_at: Time.current,
-            locale: I18n.default_locale,
-            organization:,
-            tos_agreement: true,
-            personal_url: ::Faker::Internet.url,
-            about: ::Faker::Lorem.paragraph(sentence_count: 2),
-            accepted_tos_version: organization.tos_version + 1.hour,
-            newsletter_notifications_at: Time.current
-          )
+          find_or_initialize_user_by(email:)
         end
 
         regular_user = Decidim::User.find_or_initialize_by(email: "user@example.org")
 
-        locked_user = Decidim::User.find_or_initialize_by(email: "locked_user@example.org")
-
-        locked_user.update!(
-          name: ::Faker::Name.name,
-          nickname: ::Faker::Twitter.unique.screen_name,
-          password: "decidim123456789",
-          confirmed_at: Time.current,
-          locale: I18n.default_locale,
-          organization:,
-          tos_agreement: true,
-          personal_url: ::Faker::Internet.url,
-          about: ::Faker::Lorem.paragraph(sentence_count: 2),
-          accepted_tos_version: organization.tos_version + 1.hour
-        )
+        locked_user = find_or_initialize_user_by(email: "locked_user@example.org")
 
         locked_user.lock_access!
 
@@ -177,24 +66,7 @@ module Decidim
 
         Decidim::User.find_each do |user|
           [nil, Time.current].each do |verified_at|
-            user_group = Decidim::UserGroup.create!(
-              name: ::Faker::Company.unique.name,
-              nickname: ::Faker::Twitter.unique.screen_name,
-              email: ::Faker::Internet.email,
-              confirmed_at: Time.current,
-              extended_data: {
-                document_number: ::Faker::Number.number(digits: 10).to_s,
-                phone: ::Faker::PhoneNumber.phone_number,
-                verified_at:
-              },
-              decidim_organization_id: user.organization.id
-            )
-
-            Decidim::UserGroupMembership.create!(
-              user:,
-              role: "creator",
-              user_group:
-            )
+            create_user_group!(user:, verified_at:)
           end
         end
 
@@ -218,10 +90,74 @@ module Decidim
         settings = welcome_text.inject(settings) { |acc, (k, v)| acc.update("welcome_text_#{k}" => v) }
         hero_content_block.settings = settings
         hero_content_block.save!
+
+        create_user_report!(reportable: Decidim::User.take, current_user: Decidim::User.take)
+      end
+
+      def reset_column_information
+        # Since we usually migrate and seed in the same process, make sure
+        # that we do not have invalid or cached information after a migration.
+        decidim_tables = ActiveRecord::Base.connection.tables.select do |table|
+          table.starts_with?("decidim_")
+        end
+        decidim_tables.map do |table|
+          table.tr("_", "/").classify.safe_constantize
+        end.compact.each(&:reset_column_information)
       end
-      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Rails/Output
 
-      private
+      def create_organization!
+        smtp_label = ENV.fetch("SMTP_FROM_LABEL", ::Faker::Twitter.unique.screen_name)
+        smtp_email = ENV.fetch("SMTP_FROM_EMAIL", ::Faker::Internet.email)
+
+        primary_color, secondary_color, tertiary_color = [
+          ["#bf4044", "#09780e", "#3584e4"],
+          ["#09780e", "#4448bb", "#da565b"],
+          ["#bf4086", "#487511", "#5384ac"],
+          ["#086263", "#811380", "#abac53"],
+          ["#5340bf", "#a82c2c", "#40bf53"]
+        ].sample
+
+        colors = {
+          primary: primary_color,
+          secondary: secondary_color,
+          tertiary: tertiary_color
+        }
+
+        Decidim::Organization.first || Decidim::Organization.create!(
+          name: Decidim::Faker::Localized.company,
+          twitter_handler: ::Faker::Hipster.word,
+          facebook_handler: ::Faker::Hipster.word,
+          instagram_handler: ::Faker::Hipster.word,
+          youtube_handler: ::Faker::Hipster.word,
+          github_handler: ::Faker::Hipster.word,
+          smtp_settings: {
+            from: "#{smtp_label} <#{smtp_email}>",
+            from_email: smtp_email,
+            from_label: smtp_label,
+            user_name: ENV.fetch("SMTP_USERNAME", ::Faker::Twitter.unique.screen_name),
+            encrypted_password: Decidim::AttributeEncryptor.encrypt(ENV.fetch("SMTP_PASSWORD", ::Faker::Internet.password(min_length: 8))),
+            address: ENV.fetch("SMTP_ADDRESS", nil) || ENV.fetch("DECIDIM_HOST", "localhost"),
+            port: ENV.fetch("SMTP_PORT", nil) || ENV.fetch("DECIDIM_SMTP_PORT", "25")
+          },
+          host: ENV.fetch("DECIDIM_HOST", "localhost"),
+          secondary_hosts: ENV.fetch("DECIDIM_HOST", "localhost") == "localhost" ? ["0.0.0.0", "127.0.0.1"] : nil,
+          external_domain_allowlist: ["decidim.org", "github.com"],
+          description: Decidim::Faker::Localized.wrapped("<p>", "</p>") do
+            Decidim::Faker::Localized.sentence(word_count: 15)
+          end,
+          default_locale: Decidim.default_locale,
+          available_locales: Decidim.available_locales,
+          reference_prefix: ::Faker::Name.suffix,
+          available_authorizations: Decidim.authorization_workflows.map(&:name),
+          users_registration_mode: :enabled,
+          tos_version: Time.current,
+          badges_enabled: true,
+          user_groups_enabled: true,
+          send_welcome_notification: true,
+          file_upload_settings: Decidim::OrganizationSettings.default(:upload),
+          colors:
+        )
+      end
 
       def create_scope_type!(name:, plural:)
         Decidim::ScopeType.create!(
@@ -246,6 +182,43 @@ module Decidim
       rescue ActiveRecord::RecordInvalid
         retry
       end
+
+      def create_area_type!(name:, plural:)
+        Decidim::AreaType.create!(
+          name: Decidim::Faker::Localized.literal(name),
+          plural: Decidim::Faker::Localized.literal(plural),
+          organization:
+        )
+      end
+
+      def create_area!(area_type:)
+        Decidim::Area.create!(
+          name: Decidim::Faker::Localized.word,
+          area_type:,
+          organization:
+        )
+      end
+
+      def create_user_group!(user:, verified_at:)
+        user_group = Decidim::UserGroup.create!(
+          name: ::Faker::Company.unique.name,
+          nickname: ::Faker::Twitter.unique.screen_name,
+          email: ::Faker::Internet.email,
+          confirmed_at: Time.current,
+          extended_data: {
+            document_number: ::Faker::Number.number(digits: 10).to_s,
+            phone: ::Faker::PhoneNumber.phone_number,
+            verified_at:
+          },
+          decidim_organization_id: user.organization.id
+        )
+
+        Decidim::UserGroupMembership.create!(
+          user:,
+          role: "creator",
+          user_group:
+        )
+      end
     end
   end
 end

data/lib/decidim/core/test/factories.rb

@@ -112,7 +112,11 @@ FactoryBot.define do
       create_static_pages { true }
     end
 
-    name { Faker::Company.unique.name }
+    # we do not want machine translation here
+    name do
+      Decidim.available_locales.index_with { |_locale| Faker::Company.unique.name }
+    end
+
     reference_prefix { Faker::Name.suffix }
     time_zone { "UTC" }
     twitter_handler { Faker::Hipster.word }
@@ -137,7 +141,7 @@ FactoryBot.define do
     admin_terms_of_service_body { generate_localized_description(:admin_terms_of_service_body, skip_injection:) }
     force_users_to_authenticate_before_access_organization { false }
     machine_translation_display_priority { "original" }
-    external_domain_whitelist { ["example.org", "twitter.com", "facebook.com", "youtube.com", "github.com", "mytesturl.me"] }
+    external_domain_allowlist { ["example.org", "twitter.com", "facebook.com", "youtube.com", "github.com", "mytesturl.me"] }
     smtp_settings do
       {
         "from" => "test@example.org",
@@ -149,7 +153,18 @@ FactoryBot.define do
     end
     file_upload_settings { Decidim::OrganizationSettings.default(:upload) }
     enable_participatory_space_filters { true }
-    content_security_policy { {} }
+    content_security_policy do
+      {
+        "default-src" => "localhost:* #{host}:*",
+        "script-src" => "localhost:* #{host}:*",
+        "style-src" => "localhost:* #{host}:*",
+        "img-src" => "localhost:* #{host}:*",
+        "font-src" => "localhost:* #{host}:*",
+        "connect-src" => "localhost:* #{host}:*",
+        "frame-src" => "localhost:* #{host}:* www.example.org",
+        "media-src" => "localhost:* #{host}:*"
+      }
+    end
     colors do
       {
         primary: "#e02d2d",
@@ -422,6 +437,7 @@ FactoryBot.define do
     end
     title { generate_localized_title(:static_page_topic_title, skip_injection:) }
     description { generate_localized_description(:static_page_topic_description, skip_injection:) }
+    show_in_footer { true }
     organization
   end
 
@@ -457,6 +473,11 @@ FactoryBot.define do
       content_type { "application/pdf" }
       file_size { 17_525 }
     end
+
+    trait :with_link do
+      file { nil }
+      link { Faker::Internet.url }
+    end
   end
 
   factory :component, class: "Decidim::Component" do

data/lib/decidim/core/test/shared_examples/acts_as_author_examples.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-# users of this test should delare the `subject` variable.
+# users of this test should declare the `subject` variable.
 shared_examples "acts as author" do
   describe "presenter" do
     it "returns an instance of the presenter for this author" do

data/lib/decidim/core/test/shared_examples/amendable/withdraw_amendment_examples.rb

@@ -4,7 +4,7 @@ shared_examples "withdraw amendment" do
   context "when current user is the author of the amendment" do
     let(:current_user) { amendment.amender }
 
-    context "and the amendment has no supports" do
+    context "and the amendment has no votes" do
       it "withdraws the amendment" do
         expect { command.call }.to broadcast(:ok)
         expect(amendment.state).to eq("withdrawn")
@@ -12,7 +12,7 @@ shared_examples "withdraw amendment" do
       end
     end
 
-    context "and the amendment has some supports" do
+    context "and the amendment has some votes" do
       before do
         emendation.votes.create!(author: other_user)
       end

data/lib/decidim/core/test/shared_examples/announcements_examples.rb

@@ -12,7 +12,7 @@ shared_examples "manage announcements" do
       ca: "Un avís molt important"
     )
 
-    click_button "Update"
+    click_on "Update"
 
     visit main_component_path(current_component)
 
@@ -46,12 +46,12 @@ shared_examples "manage announcements" do
         ca: "Un avís per a aquesta fase"
       )
 
-      click_button "Update"
+      click_on "Update"
 
       visit main_component_path(current_component)
 
       within page.find("[data-announcement]", match: :first) do
-        expect(page).not_to have_content("An important announcement")
+        expect(page).to have_no_content("An important announcement")
         expect(page).to have_content("An announcement for this step")
       end
     end

data/lib/decidim/core/test/shared_examples/assembly_announcements_examples.rb

@@ -2,7 +2,7 @@
 
 shared_examples "manage assemblies announcements" do
   it "can customize a general announcement for the assembly" do
-    click_link "Configure"
+    click_on "Configure"
 
     fill_in_i18n_editor(
       :assembly_announcement,
@@ -20,14 +20,14 @@ shared_examples "manage assemblies announcements" do
     visit decidim_admin_assemblies.assemblies_path
 
     if defined?(parent_assembly) && !parent_assembly.nil?
-      within find("tr", text: translated(parent_assembly.title)) do
-        click_link "Assemblies"
+      within "tr", text: translated(parent_assembly.title) do
+        click_on "Assemblies"
       end
     end
 
     new_window = window_opened_by do
       within "tr", text: translated(assembly.title) do
-        click_link "Preview"
+        click_on "Preview"
       end
     end