decidim-core 0.28.3 → 0.29.0.rc1

data/lib/decidim/core/test/shared_examples/follows_examples.rb

@@ -1,12 +1,7 @@
 # frozen_string_literal: true
 
-# When using these shared examples, make sure there are no prior requests within
-# the same group of examples where this is included. Otherwise you may end up
-# in race conditions that cause these to fail as explained at:
-# https://github.com/decidim/decidim/pull/6161
-shared_examples "followable content for users" do
+shared_examples "follows" do
   before do
-    switch_to_host(organization.host)
     login_as user, scope: :user
   end
 
@@ -15,7 +10,7 @@ shared_examples "followable content for users" do
       it "makes the user follow the followable" do
         visit followable_path
         expect do
-          click_link "Follow"
+          click_on "Follow"
           expect(page).to have_content "Stop following"
         end.to change(Decidim::Follow, :count).by(1)
       end
@@ -31,7 +26,7 @@ shared_examples "followable content for users" do
       it "makes the user follow the followable" do
         visit followable_path
         expect do
-          click_link "Stop following"
+          click_on "Stop following"
           expect(page).to have_content "Follow"
         end.to change(Decidim::Follow, :count).by(-1)
       end
@@ -39,9 +34,9 @@ shared_examples "followable content for users" do
   end
 end
 
-shared_examples "followable content for users with a component" do
+shared_examples "follows with a component" do
   include_context "with a component"
-  include_examples "followable content for users"
+  include_examples "follows"
 
   context "when the user is following the followable's participatory space" do
     before do
@@ -52,7 +47,7 @@ shared_examples "followable content for users with a component" do
       it "makes the user follow the followable" do
         visit followable_path
         expect do
-          click_link "Follow"
+          click_on "Follow"
           expect(page).to have_content "Stop following"
         end.to change(Decidim::Follow, :count).by(1)
       end

data/lib/decidim/core/test/shared_examples/has_attachment_collections.rb

@@ -6,6 +6,7 @@ shared_examples_for "has attachment collections" do
   context "when it has attachment collections" do
     let(:attachment_collection) { create(:attachment_collection, collection_for:) }
     let!(:document) { create(:attachment, :with_pdf, attached_to:, attachment_collection:) }
+    let!(:link) { create(:attachment, :with_link, attached_to:, attachment_collection:) }
     let!(:other_document) { create(:attachment, :with_pdf, attached_to:, attachment_collection: nil) }
 
     before do
@@ -19,7 +20,8 @@ shared_examples_for "has attachment collections" do
     it "show their documents" do
       within "[id*=documents-#{attachment_collection.id}]", visible: false do
         expect(page).to have_content(:all, translated(document.title))
-        expect(page).not_to have_content(:all, translated(other_document.title))
+        expect(page).to have_content(:all, translated(link.title))
+        expect(page).to have_no_content(:all, translated(other_document.title))
       end
     end
   end
@@ -53,7 +55,7 @@ shared_examples_for "has attachment collections" do
 
     it "is not present" do
       expect(page).to have_content(translated(attachment_collection.name))
-      expect(page).not_to have_content(translated(empty_attachment_collection.name))
+      expect(page).to have_no_content(translated(empty_attachment_collection.name))
     end
   end
 end

data/lib/decidim/core/test/shared_examples/has_attachments.rb

@@ -48,7 +48,7 @@ end
 shared_examples_for "has attachments tabs" do
   context "when it has attachments" do
     let!(:document) { create(:attachment, :with_pdf, attached_to:) }
-
+    let!(:link) { create(:attachment, :with_link, attached_to:) }
     let!(:image) { create(:attachment, attached_to:) }
 
     before do
@@ -59,6 +59,7 @@ shared_examples_for "has attachments tabs" do
       find("li [data-controls='panel-documents']").click
       within "#panel-documents" do
         expect(page).to have_content(translated(document.title))
+        expect(page).to have_content(translated(link.title))
       end
 
       find("li [data-controls='panel-images']").click
@@ -69,7 +70,7 @@ shared_examples_for "has attachments tabs" do
   end
 
   context "when are ordered by weight" do
-    let!(:last_document) { create(:attachment, :with_pdf, attached_to:, weight: 2) }
+    let!(:last_document) { create(:attachment, :with_link, attached_to:, weight: 2) }
     let!(:first_document) { create(:attachment, :with_pdf, attached_to:, weight: 1) }
     let!(:last_image) { create(:attachment, attached_to:, weight: 2) }
     let!(:first_image) { create(:attachment, attached_to:, weight: 1) }

data/lib/decidim/core/test/shared_examples/has_contextual_help.rb

@@ -13,20 +13,20 @@ shared_examples "shows contextual help" do
     visit index_path
 
     within "#floating-helper-tip" do
-      click_button
+      click_on
     end
 
     within "#floating-helper-block" do
       expect(page).to have_content("Some relevant help")
-      click_button
+      click_on
     end
 
     visit current_path
 
-    expect(page).not_to have_content("Some relevant help")
+    expect(page).to have_no_content("Some relevant help")
 
     within "#floating-helper-tip" do
-      click_button
+      click_on
     end
 
     within "#floating-helper-block" do

data/lib/decidim/core/test/shared_examples/has_reference.rb

@@ -28,7 +28,7 @@ shared_examples_for "has reference" do
       subject[:reference] = "ARBITRARYREF"
     end
 
-    it "keeps the pre-existing reference" do
+    it "keeps the preexisting reference" do
       expect(subject.reference).to eq("ARBITRARYREF")
     end
   end

data/lib/decidim/core/test/shared_examples/logo_email.rb

@@ -5,7 +5,7 @@ require "spec_helper"
 shared_examples "email with logo" do
   context "when organization has a logo" do
     let(:organization_logo) { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
-    let(:organization) { create(:organization, name: "O'Higgins", logo: organization_logo) }
+    let(:organization) { create(:organization, name: { en: "O'Higgins" }, logo: organization_logo) }
     let(:mail) { described_class.event_received(event, event_class_name, resource, user, :follower, extra) }
     let(:logo_path) { Rails.application.routes.url_helpers.rails_representation_path(organization.logo.variant(resize_to_fit: [600, 160]), only_path: true) }
 

data/lib/decidim/core/test/shared_examples/manage_component_share_tokens.rb

@@ -9,7 +9,7 @@ RSpec.shared_examples "manage component share tokens" do
     end
 
     it "has a share button that opens the share url for the component" do
-      share_window = window_opened_by { click_link "Share", wait: 2 }
+      share_window = window_opened_by { click_on "Share", wait: 2 }
 
       within_window share_window do
         expect(current_url).to include(component.share_tokens.reload.last.url)
@@ -25,14 +25,14 @@ RSpec.shared_examples "manage component share tokens" do
       before do
         visit components_path
 
-        within find("tr", text: component.name["en"]) do
-          click_link "Configure"
+        within "tr", text: component.name["en"] do
+          click_on "Configure"
         end
       end
 
       it "displays all tokens" do
         within ".share_tokens" do
-          expect(page).to have_selector("tbody tr", count: 3)
+          expect(page).to have_css("tbody tr", count: 3)
         end
       end
 
@@ -48,7 +48,7 @@ RSpec.shared_examples "manage component share tokens" do
       it "has a share link for each token" do
         urls = share_tokens.map(&:url).map { |url| url.split("?").first }
         within ".share_tokens tbody tr:first-child" do
-          share_window = window_opened_by { click_link "Share" }
+          share_window = window_opened_by { click_on "Share" }
 
           within_window share_window do
             expect(urls).to include(page.current_path)
@@ -58,11 +58,11 @@ RSpec.shared_examples "manage component share tokens" do
 
       it "has a link to delete tokens" do
         within ".share_tokens tbody tr:first-child" do
-          accept_confirm { click_link "Delete" }
+          accept_confirm { click_on "Delete" }
         end
 
         expect(page).to have_admin_callout("successfully")
-        expect(page).to have_selector("tbody tr", count: 2)
+        expect(page).to have_css("tbody tr", count: 2)
       end
     end
 
@@ -70,8 +70,8 @@ RSpec.shared_examples "manage component share tokens" do
       before do
         visit components_path
 
-        within find("tr", text: component.name["en"]) do
-          click_link "Configure"
+        within "tr", text: component.name["en"] do
+          click_on "Configure"
         end
       end
 

data/lib/decidim/core/test/shared_examples/map_examples.rb

@@ -115,7 +115,7 @@ shared_context "with frontend map elements" do
   end
 
   after do
-    expect(page).to have_selector("#ready_indicator", text: "Document ready")
+    expect(page).to have_css("#ready_indicator", text: "Document ready")
 
     expect_no_js_errors
 
@@ -148,10 +148,10 @@ shared_examples "a page with dynamic map" do
   it_behaves_like "accessible page"
 
   it "displays the maps" do
-    expect(page).to have_selector("#map1", visible: :all)
-    expect(page).to have_selector("#map1_inner", visible: :all)
-    expect(page).to have_selector("#map2", visible: :all)
-    expect(page).to have_selector("#map2_inner", visible: :all)
+    expect(page).to have_css("#map1", visible: :all)
+    expect(page).to have_css("#map1_inner", visible: :all)
+    expect(page).to have_css("#map2", visible: :all)
+    expect(page).to have_css("#map2_inner", visible: :all)
   end
 end
 

data/lib/decidim/core/test/shared_examples/paginated_resource_examples.rb

@@ -1,27 +1,27 @@
 # frozen_string_literal: true
 
 shared_examples "a paginated resource" do
-  let(:collection_size) { 50 }
+  let(:collection_size) { 30 }
 
   before do
     visit_component
   end
 
-  it "lists 25 resources per page by default" do
-    expect(page).to have_css(resource_selector, count: 25)
-    expect(page).to have_css("[data-pages] [data-page]", count: 2)
+  it "lists 10 resources per page by default" do
+    expect(page).to have_css(resource_selector, count: 10)
+    expect(page).to have_css("[data-pages] [data-page]", count: 3)
   end
 
   it "results per page can be changed from the selector" do
     expect(page).to have_css("[data-pagination]")
 
     within "[data-pagination]" do
-      page.find("summary", text: "25").click
-      click_link "50"
+      page.find("summary", text: "10").click
+      click_on "50"
     end
 
     sleep 2
     expect(page).to have_css(resource_selector, count: collection_size)
-    expect(page).not_to have_css("[data-pagination]")
+    expect(page).to have_no_css("[data-pagination]")
   end
 end

data/lib/decidim/core/test/shared_examples/participatory_space_dropdown_metadata_cell_examples.rb

@@ -38,7 +38,7 @@ shared_examples_for "participatory space dropdown metadata cell" do
 
     context "when there are no activities" do
       it "does not render an activities block" do
-        expect(subject).not_to have_css("div.activity__container")
+        expect(subject).to have_no_css("div.activity__container")
       end
     end
 
@@ -64,7 +64,7 @@ shared_examples_for "participatory space dropdown metadata cell" do
       end
 
       it "does not render an activities block" do
-        expect(subject).not_to have_css("div.activity__container")
+        expect(subject).to have_no_css("div.activity__container")
       end
     end
 
@@ -85,7 +85,7 @@ shared_examples_for "participatory space dropdown metadata cell hashtag" do
     let(:hashtag) { nil }
 
     it "does not render the hashtag symbol" do
-      expect(subject).not_to have_content("#")
+      expect(subject).to have_no_content("#")
     end
   end
 

data/lib/decidim/core/test/shared_examples/preview_component_with_share_token_examples.rb

@@ -15,7 +15,7 @@ shared_examples_for "preview component with share_token" do
 
       it "does not allow visiting component" do
         expect(page).to have_content "You are not authorized"
-        expect(page).not_to have_current_path(main_component_path(component), ignore_query: true)
+        expect(page).to have_no_current_path(main_component_path(component), ignore_query: true)
       end
     end
 
@@ -31,7 +31,7 @@ shared_examples_for "preview component with share_token" do
 
       context "when a valid share_token is provided" do
         it "allows visiting component" do
-          expect(page).not_to have_content "You are not authorized"
+          expect(page).to have_no_content "You are not authorized"
           expect(page).to have_current_path(main_component_path(component), ignore_query: true)
         end
       end
@@ -41,7 +41,7 @@ shared_examples_for "preview component with share_token" do
 
         it "does not allow visiting component" do
           expect(page).to have_content "You are not authorized"
-          expect(page).not_to have_current_path(main_component_path(component), ignore_query: true)
+          expect(page).to have_no_current_path(main_component_path(component), ignore_query: true)
         end
       end
     end

data/lib/decidim/core/test/shared_examples/process_announcements_examples.rb

@@ -4,12 +4,12 @@ shared_examples "manage processes announcements" do
   let!(:participatory_process) { create(:participatory_process, :with_content_blocks, organization:, blocks_manifests: [:announcement]) }
 
   it "can customize a general announcement for the process" do
-    within find("tr", text: translated(participatory_process.title)) do
-      click_link translated(participatory_process.title)
+    within "tr", text: translated(participatory_process.title) do
+      click_on translated(participatory_process.title)
     end
 
     within_admin_sidebar_menu do
-      click_link "About this process"
+      click_on "About this process"
     end
 
     fill_in_i18n_editor(
@@ -28,7 +28,7 @@ shared_examples "manage processes announcements" do
 
     visit decidim_admin_participatory_processes.participatory_processes_path
 
-    new_window = window_opened_by { page.find("tr", text: translated(participatory_process.title)).click_link("Preview") }
+    new_window = window_opened_by { page.find("tr", text: translated(participatory_process.title)).click_on("Preview") }
 
     page.within_window(new_window) do
       expect(page).to have_content("An important announcement")

data/lib/decidim/core/test/shared_examples/reports_examples.rb

@@ -15,7 +15,7 @@ shared_examples "logged in user reports content" do
         expect(page).to have_css(".flag-modal", visible: :visible)
 
         within ".flag-modal" do
-          click_button "Report"
+          click_on "Report"
         end
 
         expect(page).to have_content "report has been created"
@@ -50,7 +50,7 @@ shared_examples "higher user role hides" do
 
       within ".flag-modal" do
         find(:css, "input[name='report[hide]']").set(true)
-        click_button "Hide"
+        click_on "Hide"
       end
 
       expect(reportable.reload).to be_hidden
@@ -72,7 +72,7 @@ shared_examples "higher user role does not have hide" do
       expect(page).to have_css(".flag-modal", visible: :visible)
 
       within ".flag-modal" do
-        expect(page).not_to have_field(name: "report[hide]")
+        expect(page).to have_no_field(name: "report[hide]")
       end
     end
   end
@@ -83,9 +83,9 @@ shared_examples "reports" do
     it "gives the option to sign in" do
       visit reportable_path
 
-      expect(page).not_to have_css("html.is-disabled")
+      expect(page).to have_no_css("html.is-disabled")
 
-      click_button "Report"
+      click_on "Report"
 
       expect(page).to have_css("html.is-disabled")
     end

data/lib/decidim/core/test/shared_examples/rich_text_editor_examples.rb

@@ -3,7 +3,7 @@
 shared_examples "having a rich text editor for field" do |selector, toolbar|
   it "has a rich text editor" do
     within selector do
-      expect(page).to have_selector("div.editor-container[data-toolbar='#{toolbar}']", visible: :all)
+      expect(page).to have_css("div.editor-container[data-toolbar='#{toolbar}']", visible: :all)
     end
   end
 end
@@ -26,15 +26,15 @@ shared_examples "rendering safe content" do |css|
 
   it "renders potentially safe HTML tags unescaped" do
     within css do
-      expect(page).to have_selector("em", text: "em")
-      expect(page).to have_selector("u", text: "u")
-      expect(page).to have_selector("strong", text: "strong")
+      expect(page).to have_css("em", text: "em")
+      expect(page).to have_css("u", text: "u")
+      expect(page).to have_css("strong", text: "strong")
     end
   end
 
   it "sanitizes potentially malicious HTML tags" do
     within css do
-      expect(page).not_to have_selector("script", visible: :all)
+      expect(page).to have_no_css("script", visible: :all)
       expect(page).to have_content("alert('SCRIPT')")
     end
   end
@@ -45,19 +45,19 @@ shared_examples "rendering unsafe content" do |css|
 
   it "sanitizes potentially safe HTML tags" do
     within css do
-      expect(page).not_to have_selector("em")
+      expect(page).to have_no_css("em")
       expect(page).to have_content("em")
-      expect(page).not_to have_selector("u")
+      expect(page).to have_no_css("u")
       expect(page).to have_content("u")
-      expect(page).not_to have_selector("strong")
+      expect(page).to have_no_css("strong")
       expect(page).to have_content("strong")
     end
   end
 
   it "strips potentially malicious HTML tags" do
     within css do
-      expect(page).not_to have_selector("script", visible: :all)
-      expect(page).not_to have_content("alert('SCRIPT')")
+      expect(page).to have_no_css("script", visible: :all)
+      expect(page).to have_no_content("alert('SCRIPT')")
     end
   end
 end

data/lib/decidim/core/test/shared_examples/searchable_participatory_space_examples.rb

@@ -125,7 +125,7 @@ shared_examples "global search of participatory spaces" do
     attrs.delete("id")
     attrs.delete("created_at")
     attrs.delete("updated_at")
-    expect(attrs.delete("datetime").to_s(:short)).to eq(space.published_at.to_s(:short))
+    expect(attrs.delete("datetime").to_fs(:short)).to eq(space.published_at.to_fs(:short))
     expect(attrs).to eq(expected_searchable_resource_attrs(space, locale))
   end
 

data/lib/decidim/core/test/shared_examples/searchable_results_examples.rb

@@ -21,7 +21,7 @@ shared_examples "searchable results" do
 
       expect(page).to have_current_path decidim.search_path, ignore_query: true
       expect(page).to have_content(%(Results for the search: "#{term}"))
-      expect(page).to have_selector(".filter-search.filter-container")
+      expect(page).to have_css(".filter-search.filter-container")
       expect(page.find("#search-count h1").text.to_i).to be_positive
     end
 
@@ -48,7 +48,7 @@ shared_examples "searchable results" do
 
         expect(page).to have_current_path decidim.search_path, ignore_query: true
         expect(page).to have_content(%(Results for the search: "#{term}"))
-        expect(page).to have_selector(".filter-search.filter-container")
+        expect(page).to have_css(".filter-search.filter-container")
         expect(page.find("#search-count h1").text.to_i).to be_positive
 
         searchables.each do |searchable|
@@ -67,13 +67,13 @@ shared_examples "searchable results" do
 
         expect(page).to have_current_path decidim.search_path, ignore_query: true
         expect(page).to have_content(%(Results for the search: "#{term}"))
-        expect(page).to have_selector(".filter-search.filter-container")
+        expect(page).to have_css(".filter-search.filter-container")
         expect(page.find("#search-count h1").text.to_i).not_to be_positive
       end
     end
 
     context "when participatory space is not visible" do
-      shared_examples_for "no searchs found" do
+      shared_examples_for "no searches found" do
         it "not contains these searchables" do
           expect(searchables).not_to be_empty
           expect(term).not_to be_empty
@@ -83,7 +83,7 @@ shared_examples "searchable results" do
 
           expect(page).to have_current_path decidim.search_path, ignore_query: true
           expect(page).to have_content(%(Results for the search: "#{term}"))
-          expect(page).to have_selector(".filter-search.filter-container")
+          expect(page).to have_css(".filter-search.filter-container")
           expect(page.find("#search-count h1").text.to_i).not_to be_positive
         end
 
@@ -95,7 +95,7 @@ shared_examples "searchable results" do
             expect(page.find("#search-count h1").text.to_i).not_to be_positive
 
             within "#results" do
-              expect(page).not_to have_content(hashtag)
+              expect(page).to have_no_content(hashtag)
             end
           end
         end
@@ -106,7 +106,7 @@ shared_examples "searchable results" do
           perform_enqueued_jobs { participatory_space.update!(published_at: nil) }
         end
 
-        it_behaves_like "no searchs found"
+        it_behaves_like "no searches found"
       end
 
       context "when participatory space is private" do
@@ -114,7 +114,7 @@ shared_examples "searchable results" do
           perform_enqueued_jobs { participatory_space.update!(private_space: true) }
         end
 
-        it_behaves_like "no searchs found"
+        it_behaves_like "no searches found"
       end
     end
   end

data/lib/decidim/core/test/shared_examples/share_link_examples.rb

@@ -2,7 +2,7 @@
 
 shared_examples "share link" do
   it "allows copying the share link from the share modal" do
-    click_button("Share")
+    click_on("Share")
 
     # This overrides document.execCommand in order to ensure it was called.
     page.execute_script(
@@ -29,7 +29,7 @@ shared_examples "share link" do
       expect(page).to have_content("Share")
       expect(page).to have_content("Copy")
 
-      input = find("#urlShareLink")
+      input = find_by_id("urlShareLink")
 
       find("[data-clipboard-copy]").click
 

data/lib/decidim/core/test/shared_examples/simple_event.rb

@@ -29,7 +29,7 @@ shared_context "when a simple event" do
   let(:resource_path) { resource_locator(resource).path }
   let(:resource_url) { resource_locator(resource).url }
   let(:resource_title) { decidim_sanitize_translated(resource.title) }
-  # to be used when resource is a component resource, not a participatory space, in which case should be overriden
+  # to be used when resource is a component resource, not a participatory space, in which case should be overridden
   let(:participatory_space) { resource.participatory_space }
   let(:participatory_space_title) { decidim_sanitize_translated(participatory_space.title) }
   let(:participatory_space_path) { Decidim::ResourceLocatorPresenter.new(participatory_space).path }

data/lib/decidim/core/test/shared_examples/space_cell_changes_button_text_cta.rb

@@ -6,7 +6,7 @@ shared_examples_for "space cell changes button text CTA" do
   describe "within the card footer" do
     context "when it has no components" do
       it "renders 'More info' in the CTA button text" do
-        expect(subject).to have_selector(".card__footer--spaces .card__button", text: "More info")
+        expect(subject).to have_css(".card__footer--spaces .card__button", text: "More info")
       end
     end
 
@@ -15,7 +15,7 @@ shared_examples_for "space cell changes button text CTA" do
         let!(:component) { create(:component, :unpublished, manifest_name: "dummy", participatory_space: model) }
 
         it "renders 'More info' in the CTA button text" do
-          expect(subject).to have_selector(".card__footer--spaces .card__button", text: "More info")
+          expect(subject).to have_css(".card__footer--spaces .card__button", text: "More info")
         end
       end
 
@@ -23,7 +23,7 @@ shared_examples_for "space cell changes button text CTA" do
         let!(:component) { create(:component, :published, manifest_name: "dummy", participatory_space: model) }
 
         it "renders 'Take part' in the CTA button text" do
-          expect(subject).to have_selector(".card__footer--spaces .card__button", text: "Take part")
+          expect(subject).to have_css(".card__footer--spaces .card__button", text: "Take part")
         end
       end
     end