decidim-admin 0.26.10 → 0.27.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e85c20306c0f886f3e8974225afb8b31eb5d327c5382c9417e292d36c804749
-  data.tar.gz: ecbc6365f49dd1dee538a33313c9df4eb1fc2a003b542bf3dfaa336a32855083
+  metadata.gz: bd57dbd303809b47c0bbf9c466c4ed731f6e3d4c8b6604d1adb478114f5ef0cb
+  data.tar.gz: e77d08a54416dbff1d3481d3ddf32de28828d475143ff5cb4b5c536114106c45
 SHA512:
-  metadata.gz: 977123e6ce2165f7d970212f99fdaef4a0843dc7b5d53d6f285560efdd451d63ce50d7750ec671b5cdd70ec896ddc0ee2e249688ecfe166e54b1ead08cb1abb8
-  data.tar.gz: 2ca41de8edff6ca18de3038aeaf51991ab95863f86503a674bb9ffbd075cfa111495343c777177cc7636afa96d347a6e1d2d75987af036cb2fcce2c0af12d5ac
+  metadata.gz: b97e7a0cdb53e8c909c42e7fc6b2cd345f66f61c67648a3c086ad2db8ba9e9dc936e60d51cfaf7689d086d4c9a1f347b2432f22f9e7590743bec4897c278cf17
+  data.tar.gz: 96cb283bb59d1026e5de9d917db4dbf185ef5384442a9166f1211077c757554d6680dec253d1408da3924ae381b9dfcbb590f50c1cd73bd80b5120c4cd1cba78

data/app/cells/decidim/admin/attachments_privacy_warning/show.erb

@@ -0,0 +1,3 @@
+<% if private_space? && !(transparent_space?) %>
+  <div class="callout warning"><%= t("decidim.admin.attachments_privacy_warning.message") %></div>
+<% end %>

data/app/cells/decidim/admin/attachments_privacy_warning_cell.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    class AttachmentsPrivacyWarningCell < Decidim::ViewModel
+      delegate :current_participatory_space, to: :controller
+
+      private
+
+      def private_space?
+        current_participatory_space.private_space if current_participatory_space.respond_to?(:private_space)
+      end
+
+      def transparent_space?
+        current_participatory_space.is_transparent if current_participatory_space.respond_to?(:is_transparent)
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/block_user.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module Admin
-    class BlockUser < Rectify::Command
+    class BlockUser < Decidim::Command
       # Public: Initializes the command.
       #
       # form - BlockUserForm
@@ -20,9 +20,8 @@ module Decidim
         return broadcast(:invalid) unless form.valid?
 
         transaction do
-          find_or_create_moderation!
-          register_justification!
           block!
+          register_justification!
           notify_user!
         end
 
@@ -33,10 +32,6 @@ module Decidim
 
       attr_reader :form
 
-      def find_or_create_moderation!
-        Decidim::UserModeration.create_or_find_by!(user: form.user)
-      end
-
       def register_justification!
         @current_blocking = UserBlock.create!(
           justification: form.justification,
@@ -70,7 +65,7 @@ module Decidim
         ) do
           form.user.blocked = true
           form.user.blocked_at = Time.current
-          form.user.block_id = @current_blocking.id
+          form.user.blocking = @current_blocking
           form.user.extended_data["user_name"] = form.user.name
           form.user.name = "Blocked user"
           form.user.save!

data/app/commands/decidim/admin/close_session_managed_user.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic to close a current impersonation session.
-    class CloseSessionManagedUser < Rectify::Command
+    class CloseSessionManagedUser < Decidim::Command
       # Public: Initializes the command.
       #
       # user         - The user impersonated.

data/app/commands/decidim/admin/create_area.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic when creating an area
-    class CreateArea < Rectify::Command
+    class CreateArea < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.

data/app/commands/decidim/admin/create_area_type.rb

@@ -3,12 +3,13 @@
 module Decidim
   module Admin
     # A command with all the business logic when creating an area type.
-    class CreateAreaType < Rectify::Command
+    class CreateAreaType < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.
-      def initialize(form)
+      def initialize(form, user)
         @form = form
+        @user = user
       end
 
       # Executes the command. Broadcasts these events:
@@ -29,7 +30,9 @@ module Decidim
       attr_reader :form
 
       def create_area_type
-        AreaType.create!(
+        Decidim.traceability.create!(
+          AreaType,
+          @user,
           name: form.name,
           organization: form.organization,
           plural: form.plural

data/app/commands/decidim/admin/create_attachment.rb

@@ -4,14 +4,15 @@ module Decidim
   module Admin
     # A command with all the business logic to add an attachment to a
     # participatory process.
-    class CreateAttachment < Rectify::Command
+    class CreateAttachment < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.
       # attached_to - The ActiveRecord::Base that will hold the attachment
-      def initialize(form, attached_to)
+      def initialize(form, attached_to, user)
         @form = form
         @attached_to = attached_to
+        @user = user
       end
 
       # Executes the command. Broadcasts these events:
@@ -26,9 +27,12 @@ module Decidim
         build_attachment
 
         if @attachment.valid?
-          @attachment.save!
-          notify_followers
-          broadcast(:ok)
+          Decidim.traceability.perform_action!(:create, Decidim::Attachment, @user) do
+            @attachment.save!
+            notify_followers
+            broadcast(:ok)
+            @attachment
+          end
         else
           @form.errors.add :file, @attachment.errors[:file] if @attachment.errors.has_key? :file
           broadcast(:invalid)
@@ -47,7 +51,7 @@ module Decidim
           weight: form.weight,
           attachment_collection: form.attachment_collection,
           file: form.file, # Define attached_to before this
-          content_type: form.file.content_type
+          content_type: blob(form.file).content_type
         )
       end
 
@@ -61,6 +65,10 @@ module Decidim
           followers: @attachment.attached_to.followers
         )
       end
+
+      def blob(signed_id)
+        ActiveStorage::Blob.find_signed(signed_id)
+      end
     end
   end
 end

data/app/commands/decidim/admin/create_attachment_collection.rb

@@ -4,14 +4,15 @@ module Decidim
   module Admin
     # A command with all the business logic to add an attachment collection
     # to a participatory space.
-    class CreateAttachmentCollection < Rectify::Command
+    class CreateAttachmentCollection < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.
       # collection_for - The ActiveRecord::Base that will hold the collection
-      def initialize(form, collection_for)
+      def initialize(form, collection_for, user)
         @form = form
         @collection_for = collection_for
+        @user = user
       end
 
       # Executes the command. Broadcasts these events:
@@ -32,12 +33,20 @@ module Decidim
       attr_reader :form
 
       def create_attachment_collection
-        AttachmentCollection.create!(
+        Decidim.traceability.create!(
+          AttachmentCollection,
+          @user,
+          attributes
+        )
+      end
+
+      def attributes
+        {
           name: form.name,
           weight: form.weight,
           description: form.description,
           collection_for: @collection_for
-        )
+        }
       end
     end
   end

data/app/commands/decidim/admin/create_category.rb

@@ -4,15 +4,16 @@ module Decidim
   module Admin
     # A command with all the business logic to create a new category in the
     # system.
-    class CreateCategory < Rectify::Command
+    class CreateCategory < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.
       # participatory_space - The participatory space that will hold the
       #   category
-      def initialize(form, participatory_space)
+      def initialize(form, participatory_space, user)
         @form = form
         @participatory_space = participatory_space
+        @user = user
       end
 
       # Executes the command. Broadcasts these events:
@@ -33,10 +34,11 @@ module Decidim
       attr_reader :form
 
       def create_category
-        Category.create!(
+        Decidim.traceability.create!(
+          Category,
+          @user,
           name: form.name,
           weight: form.weight,
-          description: form.description,
           parent_id: form.parent_id,
           participatory_space: @participatory_space
         )

data/app/commands/decidim/admin/create_component.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # This command gets called when a component is created from the admin panel.
-    class CreateComponent < Rectify::Command
+    class CreateComponent < Decidim::Command
       attr_reader :form, :manifest, :participatory_space
 
       # Public: Initializes the command.

data/app/commands/decidim/admin/create_import.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module Admin
-    class CreateImport < Rectify::Command
+    class CreateImport < Decidim::Command
       def initialize(form)
         @form = form
       end
@@ -14,13 +14,12 @@ module Decidim
         transaction do
           form.importer.import!
 
-          return broadcast(:ok, imported_data)
+          broadcast(:ok, imported_data)
         rescue StandardError
+          # Something went wrong with import/finish
+          broadcast(:invalid)
           raise ActiveRecord::Rollback
         end
-
-        # Something went wrong with import/finish
-        broadcast(:invalid)
       end
 
       attr_reader :form

data/app/commands/decidim/admin/create_import_example.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module Admin
-    class CreateImportExample < Rectify::Command
+    class CreateImportExample < Decidim::Command
       def initialize(form)
         @form = form
       end

data/app/commands/decidim/admin/create_newsletter.rb

@@ -4,7 +4,7 @@ module Decidim
   module Admin
     # Creates a newsletter and assigns the right author and
     # organization.
-    class CreateNewsletter < Rectify::Command
+    class CreateNewsletter < Decidim::Command
       # Initializes the command.
       #
       # form - The source fo data for this newsletter.

data/app/commands/decidim/admin/create_participatory_space_private_user.rb

@@ -4,7 +4,7 @@ module Decidim
   module Admin
     # A command with all the business logic when creating a new participatory space
     # private user in the system.
-    class CreateParticipatorySpacePrivateUser < Rectify::Command
+    class CreateParticipatorySpacePrivateUser < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.

data/app/commands/decidim/admin/create_scope.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic when creating a static scope.
-    class CreateScope < Rectify::Command
+    class CreateScope < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.

data/app/commands/decidim/admin/create_scope_type.rb

@@ -3,12 +3,13 @@
 module Decidim
   module Admin
     # A command with all the business logic when creating a scope type.
-    class CreateScopeType < Rectify::Command
+    class CreateScopeType < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.
-      def initialize(form)
+      def initialize(form, user)
         @form = form
+        @user = user
       end
 
       # Executes the command. Broadcasts these events:
@@ -29,7 +30,9 @@ module Decidim
       attr_reader :form
 
       def create_scope_type
-        ScopeType.create!(
+        Decidim.traceability.create!(
+          ScopeType,
+          @user,
           name: form.name,
           organization: form.organization,
           plural: form.plural

data/app/commands/decidim/admin/create_static_page.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic when creating a static page.
-    class CreateStaticPage < Rectify::Command
+    class CreateStaticPage < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.

data/app/commands/decidim/admin/create_static_page_topic.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic when creating a static page topic.
-    class CreateStaticPageTopic < Rectify::Command
+    class CreateStaticPageTopic < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.

data/app/commands/decidim/admin/deliver_newsletter.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # Delivers the newsletter to its recipients.
-    class DeliverNewsletter < Rectify::Command
+    class DeliverNewsletter < Decidim::Command
       # Initializes the command.
       #
       # newsletter - The newsletter to deliver.
@@ -16,12 +16,12 @@ module Decidim
       end
 
       def call
-        @newsletter.with_lock do
-          return broadcast(:invalid) if @form.send_to_all_users && !@user.admin?
-          return broadcast(:invalid) unless @form.valid?
-          return broadcast(:invalid) if @newsletter.sent?
-          return broadcast(:no_recipients) if recipients.blank?
+        return broadcast(:invalid) if @form.send_to_all_users && !@user.admin?
+        return broadcast(:invalid) unless @form.valid?
+        return broadcast(:invalid) if @newsletter.sent?
+        return broadcast(:no_recipients) if recipients.blank?
 
+        @newsletter.with_lock do
           send_newsletter!
         end
 

data/app/commands/decidim/admin/destroy_area.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic to destroy an area.
-    class DestroyArea < Rectify::Command
+    class DestroyArea < Decidim::Command
       # Public: Initializes the command.
       #
       # area - The area to destroy

data/app/commands/decidim/admin/destroy_category.rb

@@ -4,12 +4,13 @@ module Decidim
   module Admin
     # A command with all the business logic to destroy a category in the
     # system.
-    class DestroyCategory < Rectify::Command
+    class DestroyCategory < Decidim::Command
       # Public: Initializes the command.
       #
       # category - A Category that will be destroyed
-      def initialize(category)
+      def initialize(category, user)
         @category = category
+        @user = user
       end
 
       # Executes the command. Broadcasts these events:
@@ -30,7 +31,9 @@ module Decidim
       attr_reader :category
 
       def destroy_category
-        category.destroy!
+        Decidim.traceability.perform_action!(:delete, category, @user) do
+          category.destroy!
+        end
       end
     end
   end

data/app/commands/decidim/admin/destroy_component.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # This command deals with destroying a Component from the admin panel.
-    class DestroyComponent < Rectify::Command
+    class DestroyComponent < Decidim::Command
       # Public: Initializes the command.
       #
       # component - The Component to be destroyed.

data/app/commands/decidim/admin/destroy_newsletter.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # This command deals with destroying a newsletter from the admin panel.
-    class DestroyNewsletter < Rectify::Command
+    class DestroyNewsletter < Decidim::Command
       # Public: Initializes the command.
       #
       # newsletter - The Newsletter to be destroyed.

data/app/commands/decidim/admin/destroy_participatory_space_private_user.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic to destroy a participatory space private user.
-    class DestroyParticipatorySpacePrivateUser < Rectify::Command
+    class DestroyParticipatorySpacePrivateUser < Decidim::Command
       # Public: Initializes the command.
       #
       # participatory_space_private_user - The participatory space private user to destroy

data/app/commands/decidim/admin/destroy_scope.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic to destroy a scope.
-    class DestroyScope < Rectify::Command
+    class DestroyScope < Decidim::Command
       # Public: Initializes the command.
       #
       # scope - The Scope to destroy

data/app/commands/decidim/admin/destroy_share_token.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic to destroy a share token.
-    class DestroyShareToken < Rectify::Command
+    class DestroyShareToken < Decidim::Command
       # Public: Initializes the command.
       #
       # share_token - The share_token to destroy

data/app/commands/decidim/admin/destroy_static_page.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # This command deals with destroying a StaticPage from the admin panel.
-    class DestroyStaticPage < Rectify::Command
+    class DestroyStaticPage < Decidim::Command
       # Public: Initializes the command.
       #
       # page - The StaticPage to be destroyed.

data/app/commands/decidim/admin/destroy_static_page_topic.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # This command deals with destroying a StaticPageTopic from the admin panel.
-    class DestroyStaticPageTopic < Rectify::Command
+    class DestroyStaticPageTopic < Decidim::Command
       # Public: Initializes the command.
       #
       # page - The StaticPageTopic to be destroyed.

data/app/commands/decidim/admin/hide_resource.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic when a user hides a resource.
-    class HideResource < Rectify::Command
+    class HideResource < Decidim::Command
       # Public: Initializes the command.
       #
       # reportable - A Decidim::Reportable
@@ -60,7 +60,7 @@ module Decidim
           affected_users: @reportable.try(:authors) || [@reportable.try(:normalized_author)]
         }
 
-        Decidim::EventsManager.publish(data)
+        Decidim::EventsManager.publish(**data)
       end
 
       def report_reasons

data/app/commands/decidim/admin/impersonate_user.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic to impersonate a managed user.
-    class ImpersonateUser < Rectify::Command
+    class ImpersonateUser < Decidim::Command
       # Public: Initializes the command.
       #
       # form         - The form with the authorization info

data/app/commands/decidim/admin/invite_admin.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command to invite an admin.
-    class InviteAdmin < Rectify::Command
+    class InviteAdmin < Decidim::Command
       # Public: Initializes the command.
       #
       # form - A form object with the params.

data/app/commands/decidim/admin/officialize_user.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic when officializing a user.
-    class OfficializeUser < Rectify::Command
+    class OfficializeUser < Decidim::Command
       # Public: Initializes the command.
       #
       # form - The officialization form.

data/app/commands/decidim/admin/process_participatory_space_private_user_import_csv.rb

@@ -4,7 +4,9 @@ require "csv"
 
 module Decidim
   module Admin
-    class ProcessParticipatorySpacePrivateUserImportCsv < Rectify::Command
+    class ProcessParticipatorySpacePrivateUserImportCsv < Decidim::Command
+      include Decidim::ProcessesFileLocally
+
       # Public: Initializes the command.
       #
       # form - the form object containing the uploaded file
@@ -32,8 +34,10 @@ module Decidim
       private
 
       def process_csv
-        CSV.foreach(@form.file.path, encoding: "BOM|UTF-8") do |email, user_name|
-          ImportParticipatorySpacePrivateUserCsvJob.perform_later(email, user_name, @private_users_to, @current_user) if email.present? && user_name.present?
+        process_file_locally(@form.file) do |file_path|
+          CSV.foreach(file_path, encoding: "BOM|UTF-8") do |email, user_name|
+            ImportParticipatorySpacePrivateUserCsvJob.perform_later(email, user_name, @private_users_to, @current_user) if email.present? && user_name.present?
+          end
         end
       end
     end

data/app/commands/decidim/admin/process_user_group_verification_csv.rb

@@ -6,7 +6,9 @@ module Decidim
   module Admin
     # A command with all the business logic when processing the CSV to verify
     # user groups.
-    class ProcessUserGroupVerificationCsv < Rectify::Command
+    class ProcessUserGroupVerificationCsv < Decidim::Command
+      include Decidim::ProcessesFileLocally
+
       # Public: Initializes the command.
       #
       # form - the form object containing the uploaded file
@@ -33,9 +35,11 @@ module Decidim
         verifier = @form.current_user
         organization = @form.current_organization
 
-        CSV.foreach(@form.file.path) do |row|
-          email = row[0]
-          VerifyUserGroupFromCsvJob.perform_later(email, verifier, organization) if email.present?
+        process_file_locally(@form.file) do |file_path|
+          CSV.foreach(file_path) do |row|
+            email = row[0]
+            VerifyUserGroupFromCsvJob.perform_later(email, verifier, organization) if email.present?
+          end
         end
       end
     end

data/app/commands/decidim/admin/promote_managed_user.rb

@@ -7,7 +7,7 @@ module Decidim
     # Managed users can be promoted to standard users. It means they
     # will be invited to the application and will lose the managed flag
     # so the user cannot be impersonated anymore.
-    class PromoteManagedUser < Rectify::Command
+    class PromoteManagedUser < Decidim::Command
       # Public: Initializes the command.
       #
       # form         - A form object with the params.

data/app/commands/decidim/admin/publish_component.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # This command gets called when a component is published from the admin panel.
-    class PublishComponent < Rectify::Command
+    class PublishComponent < Decidim::Command
       # Public: Initializes the command.
       #
       # component - The component to publish.
@@ -18,7 +18,7 @@ module Decidim
       # Broadcasts :ok if published, :invalid otherwise.
       def call
         publish_component
-        publish_event unless component.previously_published?
+        publish_event
 
         broadcast(:ok)
       end

data/app/commands/decidim/admin/reject_user_group.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # A command with all the business logic when rejecting a user_group.
-    class RejectUserGroup < Rectify::Command
+    class RejectUserGroup < Decidim::Command
       # Public: Initializes the command.
       #
       # user_group - The user_group to reject