chef 14.1.12 → 14.2.0

data/spec/unit/resource/gem_package_spec.rb

@@ -33,8 +33,35 @@ end
 describe Chef::Resource::GemPackage, "gem_binary" do
   let(:resource) { Chef::Resource::GemPackage.new("foo") }
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "sets the gem_binary variable to whatever is passed in" do
     resource.gem_binary("/opt/local/bin/gem")
     expect(resource.gem_binary).to eql("/opt/local/bin/gem")
   end
 end
+
+describe Chef::Resource::GemPackage, "clear_gem_sources" do
+  let(:resource) { Chef::Resource::GemPackage.new("foo") }
+
+  it "is false by default" do
+    expect(resource.clear_sources).to be false
+  end
+
+  it "sets the default of clear_sources to the config value" do
+    Chef::Config[:clear_gem_sources] = true
+    expect(resource.clear_sources).to be true
+  end
+end

data/spec/unit/resource/git_spec.rb

@@ -17,7 +17,6 @@
 #
 
 require "spec_helper"
-require "support/shared/unit/resource/static_provider_resolution"
 
 describe Chef::Resource::Git do
 
@@ -28,7 +27,7 @@ describe Chef::Resource::Git do
     action: :sync
   )
 
-  let(:resource) { Chef::Resource::Git.new("my awesome webapp") }
+  let(:resource) { Chef::Resource::Git.new("fakey_fakerton") }
 
   it "is a subclass of Chef::Resource::Scm" do
     expect(resource).to be_a_kind_of(Chef::Resource::Scm)
@@ -44,4 +43,20 @@ describe Chef::Resource::Git do
     expect(resource.revision).to eql("v1.0 tag")
   end
 
+  it "the destination property is the name_property" do
+    expect(resource.destination).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :sync" do
+    expect(resource.action).to eql([:sync])
+  end
+
+  it "supports :checkout, :diff, :export, :log, :sync actions" do
+    expect { resource.action :checkout }.not_to raise_error
+    expect { resource.action :diff }.not_to raise_error
+    expect { resource.action :export }.not_to raise_error
+    expect { resource.action :log }.not_to raise_error
+    expect { resource.action :sync }.not_to raise_error
+  end
+
 end

data/spec/unit/resource/group_spec.rb

@@ -20,14 +20,25 @@
 require "spec_helper"
 
 describe Chef::Resource::Group, "initialize" do
-  let(:resource) { Chef::Resource::Group.new("admin") }
+  let(:resource) { Chef::Resource::Group.new("fakey_fakerton") }
 
   it "sets the resource_name to :group" do
     expect(resource.resource_name).to eql(:group)
   end
 
-  it "sets the group_name equal to the argument to initialize" do
-    expect(resource.group_name).to eql("admin")
+  it "the group_name property is the name_property" do
+    expect(resource.group_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create, :manage, :modify, :remove actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :manage }.not_to raise_error
+    expect { resource.action :modify }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
 
   it "defaults gid to nil" do
@@ -42,16 +53,6 @@ describe Chef::Resource::Group, "initialize" do
     expect(resource.users).to eql([])
   end
 
-  it "sets action to :create" do
-    expect(resource.action).to eql([:create])
-  end
-
-  %w{create remove modify manage}.each do |action|
-    it "allows action #{action}" do
-      expect(resource.allowed_actions.detect { |a| a == action.to_sym }).to eql(action.to_sym)
-    end
-  end
-
   it "accepts domain groups (@ or \ separator) on non-windows" do
     expect { resource.group_name "domain\@group" }.not_to raise_error
     expect(resource.group_name).to eq("domain\@group")
@@ -63,7 +64,7 @@ describe Chef::Resource::Group, "initialize" do
 end
 
 describe Chef::Resource::Group, "group_name" do
-  let(:resource) { Chef::Resource::Group.new("admin") }
+  let(:resource) { Chef::Resource::Group.new("fakey_fakerton") }
 
   it "allows a string" do
     resource.group_name "pirates"
@@ -76,7 +77,7 @@ describe Chef::Resource::Group, "group_name" do
 end
 
 describe Chef::Resource::Group, "gid" do
-  let(:resource) { Chef::Resource::Group.new("admin") }
+  let(:resource) { Chef::Resource::Group.new("fakey_fakerton") }
 
   it "allows an integer" do
     resource.gid 100
@@ -89,7 +90,7 @@ describe Chef::Resource::Group, "gid" do
 end
 
 describe Chef::Resource::Group, "members" do
-  let(:resource) { Chef::Resource::Group.new("admin") }
+  let(:resource) { Chef::Resource::Group.new("fakey_fakerton") }
 
   [ :users, :members].each do |method|
     it "(#{method}) allows and convert a string" do
@@ -114,7 +115,7 @@ describe Chef::Resource::Group, "members" do
 end
 
 describe Chef::Resource::Group, "append" do
-  let(:resource) { Chef::Resource::Group.new("admin") }
+  let(:resource) { Chef::Resource::Group.new("fakey_fakerton") }
 
   it "defaults to false" do
     expect(resource.append).to eql(false)

data/spec/unit/resource/homebrew_cask_spec.rb

@@ -19,17 +19,22 @@ require "spec_helper"
 
 describe Chef::Resource::HomebrewCask do
 
-  let(:resource) { Chef::Resource::HomebrewCask.new("myapp") }
+  let(:resource) { Chef::Resource::HomebrewCask.new("fakey_fakerton") }
 
   it "has a resource name of :homebrew_cask" do
     expect(resource.resource_name).to eql(:homebrew_cask)
   end
 
-  it "has a default action of install" do
+  it "the cask_name property is the name_property" do
+    expect(resource.cask_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :install" do
     expect(resource.action).to eql([:install])
   end
 
-  it "the cask_name property is the name property" do
-    expect(resource.cask_name).to eql("myapp")
+  it "supports :install, :remove actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
 end

data/spec/unit/resource/homebrew_package_spec.rb

@@ -34,6 +34,20 @@ describe Chef::Resource::HomebrewPackage, "initialize" do
     expect(resource).to be_a_kind_of(Chef::Resource::Package)
   end
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   shared_examples "home_brew user set and returned" do
     it "returns the configured homebrew_user" do
       resource.homebrew_user user

data/spec/unit/resource/homebrew_tap_spec.rb

@@ -25,12 +25,17 @@ describe Chef::Resource::HomebrewTap do
     expect(resource.resource_name).to eql(:homebrew_tap)
   end
 
-  it "has a default action of tap" do
+  it "the tap_name property is the name_property" do
+    expect(resource.tap_name).to eql("user/mytap")
+  end
+
+  it "sets the default action as :tap" do
     expect(resource.action).to eql([:tap])
   end
 
-  it "the tap_name property is the name property" do
-    expect(resource.tap_name).to eql("user/mytap")
+  it "supports :tap, :untap actions" do
+    expect { resource.action :tap }.not_to raise_error
+    expect { resource.action :untap }.not_to raise_error
   end
 
   it "fails if tap_name isn't in the USER/TAP format" do

data/spec/unit/resource/hostname_spec.rb

@@ -19,16 +19,24 @@ require "spec_helper"
 
 describe Chef::Resource::Hostname do
 
-  let(:resource) { Chef::Resource::Hostname.new("foo") }
+  let(:resource) { Chef::Resource::Hostname.new("fakey_fakerton") }
 
   it "has a resource name of :hostname" do
     expect(resource.resource_name).to eql(:hostname)
   end
 
-  it "has a default action of set" do
+  it "the hostname property is the name_property" do
+    expect(resource.hostname).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :set" do
     expect(resource.action).to eql([:set])
   end
 
+  it "supports :set action" do
+    expect { resource.action :set }.not_to raise_error
+  end
+
   it "runs at compile_time by default" do
     expect(resource.compile_time).to eql(true)
   end
@@ -36,8 +44,4 @@ describe Chef::Resource::Hostname do
   it "reboots windows nodes by default" do
     expect(resource.windows_reboot).to eql(true)
   end
-
-  it "the hostname property is the name property" do
-    expect(resource.hostname).to eql("foo")
-  end
 end

data/spec/unit/resource/http_request_spec.rb

@@ -22,6 +22,20 @@ require "spec_helper"
 describe Chef::Resource::HttpRequest do
   let(:resource) { Chef::Resource::HttpRequest.new("fakey_fakerton") }
 
+  it "sets the default action as :get" do
+    expect(resource.action).to eql([:get])
+  end
+
+  it "supports :delete, :get, :head, :options, :patch, :post, :put actions" do
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :get }.not_to raise_error
+    expect { resource.action :head }.not_to raise_error
+    expect { resource.action :options }.not_to raise_error
+    expect { resource.action :patch }.not_to raise_error
+    expect { resource.action :post }.not_to raise_error
+    expect { resource.action :put }.not_to raise_error
+  end
+
   it "sets url to a string" do
     resource.url "http://slashdot.org"
     expect(resource.url).to eql("http://slashdot.org")

data/spec/unit/resource/ips_package_spec.rb

@@ -17,10 +17,8 @@
 #
 
 require "spec_helper"
-require "support/shared/unit/resource/static_provider_resolution"
-
-describe Chef::Resource::IpsPackage, "initialize" do
 
+describe Chef::Resource::IpsPackage do
   static_provider_resolution(
     resource: Chef::Resource::IpsPackage,
     provider: Chef::Provider::Package::Ips,
@@ -39,4 +37,18 @@ describe Chef::Resource::IpsPackage, "initialize" do
     resource.accept_license(true)
     expect(resource.accept_license).to eql(true)
   end
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
 end

data/spec/unit/resource/ksh_spec.rb

@@ -30,6 +30,14 @@ describe Chef::Resource::Ksh do
     expect(resource.resource_name).to eql(:ksh)
   end
 
+  it "sets the default action as :run" do
+    expect(resource.action).to eql([:run])
+  end
+
+  it "supports :run action" do
+    expect { resource.action :run }.not_to raise_error
+  end
+
   it "has an interpreter of ksh" do
     expect(resource.interpreter).to eql("ksh")
   end

data/spec/unit/resource/launchd_spec.rb

@@ -15,20 +15,26 @@
 require "spec_helper"
 
 describe Chef::Resource::Launchd do
-  let(:resource) { Chef::Resource::Launchd.new("io.chef.chef-client" ) }
+  let(:resource) { Chef::Resource::Launchd.new("fakey_fakerton" ) }
 
   it "has a resource name of Launchd" do
     expect(resource.resource_name).to eql(:launchd)
   end
 
-  it "has a default action of create" do
+  it "the label property is the name_property" do
+    expect(resource.label).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "accepts enable, disable, create, and delete as actions" do
-    expect { resource.action :enable }.not_to raise_error
-    expect { resource.action :disable }.not_to raise_error
+  it "supports :create, :create_if_missing, :delete, :disable, :enable, :restart actions" do
     expect { resource.action :create }.not_to raise_error
+    expect { resource.action :create_if_missing }.not_to raise_error
     expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :disable }.not_to raise_error
+    expect { resource.action :enable }.not_to raise_error
+    expect { resource.action :restart }.not_to raise_error
   end
 end

data/spec/unit/resource/link_spec.rb

@@ -26,22 +26,17 @@ describe Chef::Resource::Link do
     expect_any_instance_of(Chef::Resource::Link).to receive(:verify_links_supported!).and_return(true)
   end
 
-  it "has a name property" do
-    expect(resource.name).to eql("fakey_fakerton")
+  it "the target_file property is the name_property" do
+    expect(resource.target_file).to eql("fakey_fakerton")
   end
 
-  it "has a default action of 'create'" do
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  { :create => false, :delete => false, :blues => true }.each do |action, bad_value|
-    it "should #{bad_value ? 'not' : ''} accept #{action}" do
-      if bad_value
-        expect { resource.action action }.to raise_error(ArgumentError)
-      else
-        expect { resource.action action }.not_to raise_error
-      end
-    end
+  it "supports :create, :delete actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
   end
 
   it "uses the object name as the target_file by default" do

data/spec/unit/resource/log_spec.rb

@@ -24,20 +24,20 @@ describe Chef::Resource::Log do
   let(:log_str) { "this is my string to log" }
   let(:resource) { Chef::Resource::Log.new(log_str) }
 
-  it "supports the :write actions" do
-    expect(resource.allowed_actions).to include(:write)
-  end
-
   it "has a name of log" do
     expect(resource.resource_name).to eq(:log)
   end
 
-  it "allows you to set a log string" do
-    expect(resource.name).to eq(log_str)
+  it "the message property is the name_property" do
+    expect(resource.message).to eql("this is my string to log")
+  end
+
+  it "sets the default action as :write" do
+    expect(resource.action).to eql([:write])
   end
 
-  it "sets the message to the first argument to new" do
-    expect(resource.message).to eq(log_str)
+  it "supports :write action" do
+    expect { resource.action :write }.not_to raise_error
   end
 
   it "accepts a string for the log message" do

data/spec/unit/resource/macos_user_defaults_spec.rb

@@ -25,7 +25,11 @@ describe Chef::Resource::MacosUserDefaults do
     expect(resource.resource_name).to eql(:macos_userdefaults)
   end
 
-  it "has a default action of install" do
+  it "sets the default action as :write" do
     expect(resource.action).to eql([:write])
   end
+
+  it "supports :write action" do
+    expect { resource.action :write }.not_to raise_error
+  end
 end

data/spec/unit/resource/macports_package_spec.rb

@@ -30,3 +30,22 @@ describe Chef::Resource::MacportsPackage, "initialize" do
   )
 
 end
+
+describe Chef::Resource::MacportsPackage, "defaults" do
+  let(:resource) { Chef::Resource::MacportsPackage.new("foo") }
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
+end