chef 14.1.12 → 14.2.0

data/spec/unit/resource/windows_feature_powershell.rb

@@ -28,7 +28,13 @@ describe Chef::Resource::WindowsFeaturePowershell do
     expect(resource.action).to eql([:install])
   end
 
-  it "sets the feature_name property as its name property" do
+  it "supports :delete, :install, :remove actions" do
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+  end
+
+  it "sets the feature_name property as its name_property" do
     expect(resource.feature_name).to eql(%w{SNMP DHCP})
   end
 
@@ -42,10 +48,4 @@ describe Chef::Resource::WindowsFeaturePowershell do
     expect(resource.feature_name).to eql(["SNMP"])
   end
 
-  it "supports :install, :remove, and :delete actions" do
-    expect { resource.action :install }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :update }.to raise_error(ArgumentError)
-  end
 end

data/spec/unit/resource/windows_font_spec.rb

@@ -18,14 +18,14 @@
 require "spec_helper"
 
 describe Chef::Resource::WindowsFont do
-  let(:resource) { Chef::Resource::WindowsFont.new("some_font") }
+  let(:resource) { Chef::Resource::WindowsFont.new("fakey_fakerton") }
 
   it "sets resource name as :windows_font" do
     expect(resource.resource_name).to eql(:windows_font)
   end
 
-  it "sets the font_name as its name" do
-    expect(resource.font_name).to eql("some_font")
+  it "the font_name property is the name_property" do
+    expect(resource.font_name).to eql("fakey_fakerton")
   end
 
   it "sets the default action as :install" do
@@ -34,7 +34,6 @@ describe Chef::Resource::WindowsFont do
 
   it "supports :install action" do
     expect { resource.action :install }.not_to raise_error
-    expect { resource.action :remove }.to raise_error(ArgumentError)
   end
 
   it "coerces backslashes in the source property to forward slashes" do

data/spec/unit/resource/windows_package_spec.rb

@@ -37,8 +37,18 @@ describe Chef::Resource::WindowsPackage, "initialize" do
     expect(resource).to be_a_kind_of(Chef::Resource::Package)
   end
 
-  it "sets the resource_name to :windows_package" do
-    expect(resource.resource_name).to eql(:windows_package)
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
   end
 
   it "supports setting installer_type as a symbol" do

data/spec/unit/resource/windows_pagefile_spec.rb

@@ -24,22 +24,26 @@ describe Chef::Resource::WindowsPagefile do
     expect(resource.resource_name).to eql(:windows_pagefile)
   end
 
-  it "sets the path as its name" do
+  it "the path property is the name_property" do
     expect(resource.path).to eql("C:\\pagefile.sys")
   end
 
+  it "sets the default action as :set" do
+    expect(resource.action).to eql([:set])
+  end
+
+  it "supports :delete, :set actions" do
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :set }.not_to raise_error
+  end
+
   it "coerces forward slashes in the path property to back slashes" do
     resource.path "C:/pagefile.sys"
     expect(resource.path).to eql("C:\\pagefile.sys")
   end
 
-  it "sets the default action as :set" do
-    expect(resource.action).to eql([:set])
+  it "automatic_managed property defaults to false" do
+    expect(resource.automatic_managed).to eql(false)
   end
 
-  it "supports :set and :delete actions" do
-    expect { resource.action :set }.not_to raise_error
-    expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :create }.to raise_error(ArgumentError)
-  end
 end

data/spec/unit/resource/windows_path_spec.rb

@@ -19,23 +19,22 @@
 require "spec_helper"
 
 describe Chef::Resource::WindowsPath do
-  let(:resource) { Chef::Resource::WindowsPath.new("some_path") }
+  let(:resource) { Chef::Resource::WindowsPath.new("fakey_fakerton") }
 
   it "sets resource name as :windows_path" do
     expect(resource.resource_name).to eql(:windows_path)
   end
 
-  it "sets the path as its name" do
-    expect(resource.path).to eql("some_path")
+  it "the path property is the name_property" do
+    expect(resource.path).to eql("fakey_fakerton")
   end
 
   it "sets the default action as :add" do
     expect(resource.action).to eql([:add])
   end
 
-  it "supports :add and :remove actions" do
+  it "supports :add, :remove actions" do
     expect { resource.action :add }.not_to raise_error
     expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :delete }.to raise_error(ArgumentError)
   end
 end

data/spec/unit/resource/windows_printer_port_spec.rb

@@ -24,7 +24,7 @@ describe Chef::Resource::WindowsPrinterPort do
     expect(resource.resource_name).to eql(:windows_printer_port)
   end
 
-  it "sets the ipv4_address as its name" do
+  it "the ipv4_address property is the name_property" do
     expect(resource.ipv4_address).to eql("63.192.209.236")
   end
 
@@ -32,10 +32,27 @@ describe Chef::Resource::WindowsPrinterPort do
     expect(resource.action).to eql([:create])
   end
 
-  it "supports :create and :delete actions" do
+  it "supports :create, :delete actions" do
     expect { resource.action :create }.not_to raise_error
     expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :remove }.to raise_error(ArgumentError)
+  end
+
+  it "port_number property defaults to 9100" do
+    expect(resource.port_number).to eql(9100)
+  end
+
+  it "snmp_enabled property defaults to false" do
+    expect(resource.snmp_enabled).to eql(false)
+  end
+
+  it "port_protocol property defaults to 1" do
+    expect(resource.port_protocol).to eql(1)
+  end
+
+  it "raises an error if port_protocol isn't in 1 or 2" do
+    expect { resource.port_protocol 1 }.not_to raise_error
+    expect { resource.port_protocol 2 }.not_to raise_error
+    expect { resource.port_protocol 3 }.to raise_error(ArgumentError)
   end
 
   it "raises an error if ipv4_address isn't in X.X.X.X format" do

data/spec/unit/resource/windows_printer_spec.rb

@@ -18,24 +18,31 @@
 require "spec_helper"
 
 describe Chef::Resource::WindowsPrinter do
-  let(:resource) { Chef::Resource::WindowsPrinter.new("some_printer") }
+  let(:resource) { Chef::Resource::WindowsPrinter.new("fakey_fakerton") }
 
   it "sets resource name as :windows_printer" do
     expect(resource.resource_name).to eql(:windows_printer)
   end
 
-  it "sets the device_id as its name" do
-    expect(resource.device_id).to eql("some_printer")
+  it "the device_id property is the name_property" do
+    expect(resource.device_id).to eql("fakey_fakerton")
   end
 
   it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "supports :create and :delete actions" do
+  it "supports :create, :delete actions" do
     expect { resource.action :create }.not_to raise_error
     expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :remove }.to raise_error(ArgumentError)
+  end
+
+  it "default property defaults to false" do
+    expect(resource.default).to eql(false)
+  end
+
+  it "shared property defaults to false" do
+    expect(resource.shared).to eql(false)
   end
 
   it "raises an error if ipv4_address isn't in X.X.X.X format" do

data/spec/unit/resource/windows_service_spec.rb

@@ -27,12 +27,35 @@ describe Chef::Resource::WindowsService, "initialize" do
     action: :start
   )
 
-  let(:resource) { Chef::Resource::WindowsService.new("BITS") }
+  let(:resource) { Chef::Resource::WindowsService.new("fakey_fakerton") }
 
   it "sets the resource_name to :windows_service" do
     expect(resource.resource_name).to eql(:windows_service)
   end
 
+  it "the service_name property is the name_property" do
+    expect(resource.service_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :nothing" do
+    expect(resource.action).to eql([:nothing])
+  end
+
+  it "supports :configure, :configure_startup, :create, :delete, :disable, :enable, :mask, :reload, :restart, :start, :stop, :unmask actions" do
+    expect { resource.action :configure }.not_to raise_error
+    expect { resource.action :configure_startup }.not_to raise_error
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :disable }.not_to raise_error
+    expect { resource.action :enable }.not_to raise_error
+    expect { resource.action :mask }.not_to raise_error
+    expect { resource.action :reload }.not_to raise_error
+    expect { resource.action :restart }.not_to raise_error
+    expect { resource.action :start }.not_to raise_error
+    expect { resource.action :stop }.not_to raise_error
+    expect { resource.action :unmask }.not_to raise_error
+  end
+
   it "supports setting startup_type" do
     resource.startup_type(:manual)
     expect(resource.startup_type).to eql(:manual)

data/spec/unit/resource/windows_shortcut_spec.rb

@@ -18,22 +18,21 @@
 require "spec_helper"
 
 describe Chef::Resource::WindowsShortcut do
-  let(:resource) { Chef::Resource::WindowsShortcut.new("some_path") }
+  let(:resource) { Chef::Resource::WindowsShortcut.new("fakey_fakerton") }
 
   it "sets resource name as :windows_shortcut" do
     expect(resource.resource_name).to eql(:windows_shortcut)
   end
 
-  it "sets the shortcut_name property as its name" do
-    expect(resource.shortcut_name).to eql("some_path")
+  it "the shortcut_name property is the name_property" do
+    expect(resource.shortcut_name).to eql("fakey_fakerton")
   end
 
   it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "supports :create action only" do
+  it "supports :create action" do
     expect { resource.action :create }.not_to raise_error
-    expect { resource.action :delete }.to raise_error(ArgumentError)
   end
 end

data/spec/unit/resource/yum_repository_spec.rb

@@ -22,20 +22,56 @@ describe Chef::Resource::YumRepository do
   let(:node) { Chef::Node.new }
   let(:events) { Chef::EventDispatch::Dispatcher.new }
   let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::YumRepository.new("multiverse", run_context) }
+  let(:resource) { Chef::Resource::YumRepository.new("fakey_fakerton", run_context) }
 
   it "has a resource_name of :yum_repository" do
     expect(resource.resource_name).to eq(:yum_repository)
   end
 
   it "the repositoryid property is the name_property" do
-    expect(resource.repositoryid).to eq("multiverse")
+    expect(resource.repositoryid).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :add, :create, :delete, :makecache, :remove actions" do
+    expect { resource.action :add }.not_to raise_error
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :makecache }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
 
   it "fails if the user provides a repositoryid with a forward slash" do
     expect { resource.repositoryid "foo/bar" }.to raise_error(ArgumentError)
   end
 
+  it "clean_headers property defaults to false" do
+    expect(resource.clean_headers).to eql(false)
+  end
+
+  it "clean_metadata property defaults to true" do
+    expect(resource.clean_metadata).to eql(true)
+  end
+
+  it "description property defaults to 'Yum Repository'" do
+    expect(resource.description).to eql("Yum Repository")
+  end
+
+  it "enabled property defaults to true" do
+    expect(resource.enabled).to eql(true)
+  end
+
+  it "make_cache property defaults to true" do
+    expect(resource.make_cache).to eql(true)
+  end
+
+  it "mode property defaults to '0644'" do
+    expect(resource.mode).to eql("0644")
+  end
+
   it "the timeout property expects numeric Strings" do
     expect { resource.timeout "123" }.not_to raise_error(ArgumentError)
     expect { resource.timeout "123foo" }.to raise_error(ArgumentError)
@@ -86,6 +122,16 @@ describe Chef::Resource::YumRepository do
     expect { resource.mirrorlist_expire "never" }.to raise_error(ArgumentError)
   end
 
+  it "accepts the legacy 'url' property" do
+    resource.url "foo"
+    expect(resource.baseurl).to eql("foo")
+  end
+
+  it "accepts the legacy 'keyurl' property" do
+    resource.keyurl "foo"
+    expect(resource.gpgkey).to eql("foo")
+  end
+
   context "on linux", :linux_only do
     it "resolves to a Noop class when yum is not found" do
       expect(Chef::Provider::YumRepository).to receive(:which).with("yum").and_return(false)

data/spec/unit/resource/zypper_package_spec.rb

@@ -0,0 +1,51 @@
+#
+# Author:: Tim Smith (<tsmith@chef.io>)
+# Copyright:: Copyright 2018 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "support/shared/unit/resource/static_provider_resolution"
+
+describe Chef::Resource::ZypperPackage, "initialize" do
+
+  static_provider_resolution(
+    resource: Chef::Resource::ZypperPackage,
+    provider: Chef::Provider::Package::Zypper,
+    name: :zypper_package,
+    action: :install,
+    os: "linux",
+    platform_family: "suse"
+  )
+
+end
+
+describe Chef::Resource::ZypperPackage, "defaults" do
+  let(:resource) { Chef::Resource::ZypperPackage.new("fakey_fakerton") }
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+end

data/spec/unit/resource/zypper_repository_spec.rb

@@ -22,30 +22,75 @@ describe Chef::Resource::ZypperRepository do
   let(:node) { Chef::Node.new }
   let(:events) { Chef::EventDispatch::Dispatcher.new }
   let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::ZypperRepository.new("repo-source", run_context) }
+  let(:resource) { Chef::Resource::ZypperRepository.new("fakey_fakerton", run_context) }
 
   it "has a resource_name of :zypper_repository" do
     expect(resource.resource_name).to eq(:zypper_repository)
   end
 
-  it "repo_name is the name_property" do
-    expect(resource.repo_name).to eql("repo-source")
+  it "the repo_name property is the name_property" do
+    expect(resource.repo_name).to eql("fakey_fakerton")
   end
 
-  it "fails if the user provides a repo_name with a forward slash" do
-    expect { resource.repo_name "foo/bar" }.to raise_error(ArgumentError)
-  end
-
-  it "has a default action of create" do
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "supports all valid actions" do
+  it "supports :add, :create, :refresh, :remove actions" do
     expect { resource.action :add }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
     expect { resource.action :create }.not_to raise_error
     expect { resource.action :refresh }.not_to raise_error
-    expect { resource.action :delete }.to raise_error(ArgumentError)
+    expect { resource.action :remove }.not_to raise_error
+  end
+
+  it "fails if the user provides a repo_name with a forward slash" do
+    expect { resource.repo_name "foo/bar" }.to raise_error(ArgumentError)
+  end
+
+  it "type property defaults to 'NONE'" do
+    expect(resource.type).to eql("NONE")
+  end
+
+  it "enabled property defaults to true" do
+    expect(resource.enabled).to eql(true)
+  end
+
+  it "autorefresh property defaults to true" do
+    expect(resource.autorefresh).to eql(true)
+  end
+
+  it "gpgcheck property defaults to true" do
+    expect(resource.gpgcheck).to eql(true)
+  end
+
+  it "keeppackages property defaults to false" do
+    expect(resource.keeppackages).to eql(false)
+  end
+
+  it "priority property defaults to 99" do
+    expect(resource.priority).to eql(99)
+  end
+
+  it "mode property defaults to '0644'" do
+    expect(resource.mode).to eql("0644")
+  end
+
+  it "refresh_cache property defaults to true" do
+    expect(resource.refresh_cache).to eql(true)
+  end
+
+  it "gpgautoimportkeys property defaults to true" do
+    expect(resource.gpgautoimportkeys).to eql(true)
+  end
+
+  it "accepts the legacy 'key' property" do
+    resource.key "foo"
+    expect(resource.gpgkey).to eql("foo")
+  end
+
+  it "accepts the legacy 'uri' property" do
+    resource.uri "foo"
+    expect(resource.baseurl).to eql("foo")
   end
 
   context "on linux", :linux_only do