chef 14.1.12 → 14.2.0

data/spec/unit/resource/powershell_package_spec.rb

@@ -31,6 +31,20 @@ describe Chef::Resource::PowershellPackage do
     expect(resource.resource_name).to eql(:powershell_package)
   end
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "coerces its name to a package_name array" do
     expect(resource.package_name).to eql(["test_package"])
   end

data/spec/unit/resource/python_spec.rb

@@ -29,4 +29,12 @@ describe Chef::Resource::Python do
   it "has an interpreter of python" do
     expect(resource.interpreter).to eql("python")
   end
+
+  it "sets the default action as :run" do
+    expect(resource.action).to eql([:run])
+  end
+
+  it "supports :run action" do
+    expect { resource.action :run }.not_to raise_error
+  end
 end

data/spec/unit/resource/reboot_spec.rb

@@ -21,12 +21,14 @@ describe Chef::Resource::Reboot do
 
   let(:resource) { Chef::Resource::Reboot.new("reboot me!") }
 
-  it "has a default action of :nothing" do
+  it "sets the default action as :nothing" do
     expect(resource.action).to eql([:nothing])
   end
 
-  it "supports the :nothing, :request_reboot, :reboot_now, and :cancel actions" do
-    expect(resource.allowed_actions).to include(:nothing, :request_reboot, :reboot_now, :cancel)
+  it "supports :cancel, :reboot_now, :request_reboot actions" do
+    expect { resource.action :cancel }.not_to raise_error
+    expect { resource.action :reboot_now }.not_to raise_error
+    expect { resource.action :request_reboot }.not_to raise_error
   end
 
   it "has a resource_name of :reboot" do

data/spec/unit/resource/registry_key_spec.rb

@@ -25,10 +25,21 @@ describe Chef::Resource::RegistryKey, "initialize" do
     expect(resource.resource_name).to eql(:registry_key)
   end
 
-  it "sets the key property to the resource name" do
+  it "the key property is the name_property" do
     expect(resource.key).to eql('HKCU\Software\Raxicoricofallapatorius')
   end
 
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create, :create_if_missing, :delete, :delete_key actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :create_if_missing }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :delete_key }.not_to raise_error
+  end
+
   it "defaults recursive to false" do
     expect(resource.recursive).to eql(false)
   end

data/spec/unit/resource/remote_directory_spec.rb

@@ -22,10 +22,20 @@ describe Chef::Resource::RemoteDirectory do
 
   let(:resource) { Chef::Resource::RemoteDirectory.new("/etc/dunk") }
 
-  it "path is the name property" do
+  it "the path property is the name_property" do
     expect(resource.path).to eql("/etc/dunk")
   end
 
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create, :create_if_missing, :delete actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :create_if_missing }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+  end
+
   it "accepts a string for the remote directory source" do
     resource.source "foo"
     expect(resource.source).to eql("foo")

data/spec/unit/resource/remote_file_spec.rb

@@ -23,6 +23,25 @@ describe Chef::Resource::RemoteFile do
 
   let(:resource) { Chef::Resource::RemoteFile.new("fakey_fakerton") }
 
+  describe "name_property" do
+    it "the path property is the name_property" do
+      expect(resource.path).to eql("fakey_fakerton")
+    end
+  end
+
+  describe "Actions" do
+    it "sets the default action as :create" do
+      expect(resource.action).to eql([:create])
+    end
+
+    it "supports :create, :create_if_missing, :delete, :touch actions" do
+      expect { resource.action :create }.not_to raise_error
+      expect { resource.action :create_if_missing }.not_to raise_error
+      expect { resource.action :delete }.not_to raise_error
+      expect { resource.action :touch }.not_to raise_error
+    end
+  end
+
   describe "initialize" do
     it "is a subclass of Chef::Resource::File" do
       expect(resource).to be_a_kind_of(Chef::Resource::File)

data/spec/unit/resource/rhsm_errata_level_spec.rb

@@ -25,12 +25,16 @@ describe Chef::Resource::RhsmErrataLevel do
     expect(resource.resource_name).to eql(:rhsm_errata_level)
   end
 
-  it "has a default action of install" do
+  it "the errata_level property is the name_property" do
+    expect(resource.errata_level).to eql("moderate")
+  end
+
+  it "sets the default action as :install" do
     expect(resource.action).to eql([:install])
   end
 
-  it "the errata_level property is the name property" do
-    expect(resource.errata_level).to eql("moderate")
+  it "supports :install action" do
+    expect { resource.action :install }.not_to raise_error
   end
 
   it "coerces the errata_level to be lowercase" do

data/spec/unit/resource/rhsm_errata_spec.rb

@@ -19,17 +19,21 @@ require "spec_helper"
 
 describe Chef::Resource::RhsmErrata do
 
-  let(:resource) { Chef::Resource::RhsmErrata.new("foo") }
+  let(:resource) { Chef::Resource::RhsmErrata.new("fakey_fakerton") }
 
   it "has a resource name of :rhsm_errata" do
     expect(resource.resource_name).to eql(:rhsm_errata)
   end
 
-  it "has a default action of install" do
+  it "the errata_id property is the name_property" do
+    expect(resource.errata_id).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :install" do
     expect(resource.action).to eql([:install])
   end
 
-  it "the errata_id property is the name property" do
-    expect(resource.errata_id).to eql("foo")
+  it "supports :install action" do
+    expect { resource.action :install }.not_to raise_error
   end
 end

data/spec/unit/resource/rhsm_register_spec.rb

@@ -26,10 +26,15 @@ describe Chef::Resource::RhsmRegister do
     expect(resource.resource_name).to eql(:rhsm_register)
   end
 
-  it "has a default action of register" do
+  it "sets the default action as :register" do
     expect(resource.action).to eql([:register])
   end
 
+  it "supports :register, :unregister actions" do
+    expect { resource.action :register }.not_to raise_error
+    expect { resource.action :unregister }.not_to raise_error
+  end
+
   it "coerces activation_key to an array" do
     resource.activation_key "foo"
     expect(resource.activation_key).to eql(["foo"])

data/spec/unit/resource/rhsm_repo_spec.rb

@@ -19,19 +19,24 @@ require "spec_helper"
 
 describe Chef::Resource::RhsmRepo do
 
-  let(:resource) { Chef::Resource::RhsmRepo.new("foo") }
+  let(:resource) { Chef::Resource::RhsmRepo.new("fakey_fakerton") }
   let(:provider) { resource.provider_for_action(:enable) }
 
   it "has a resource name of :rhsm_repo" do
     expect(resource.resource_name).to eql(:rhsm_repo)
   end
 
-  it "has a default action of enable" do
+  it "the repo_name property is the name_property" do
+    expect(resource.repo_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :enable" do
     expect(resource.action).to eql([:enable])
   end
 
-  it "the repo_name property is the name property" do
-    expect(resource.repo_name).to eql("foo")
+  it "supports :disable, :enable actions" do
+    expect { resource.action :disable }.not_to raise_error
+    expect { resource.action :enable }.not_to raise_error
   end
 
   describe "#repo_enabled?" do

data/spec/unit/resource/rhsm_subscription_spec.rb

@@ -18,19 +18,24 @@
 require "spec_helper"
 
 describe Chef::Resource::RhsmSubscription do
-  let(:resource) { Chef::Resource::RhsmSubscription.new("foo") }
+  let(:resource) { Chef::Resource::RhsmSubscription.new("fakey_fakerton") }
   let(:provider) { resource.provider_for_action(:attach) }
 
   it "has a resource name of :rhsm_subscription" do
     expect(resource.resource_name).to eql(:rhsm_subscription)
   end
 
-  it "has a default action of attach" do
+  it "the pool_id property is the name_property" do
+    expect(resource.pool_id).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :attach" do
     expect(resource.action).to eql([:attach])
   end
 
-  it "the pool_id property is the name property" do
-    expect(resource.pool_id).to eql("foo")
+  it "supports :attach, :remove actions" do
+    expect { resource.action :attach }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
 
   describe "#subscription_attached?" do

data/spec/unit/resource/route_spec.rb

@@ -23,22 +23,17 @@ describe Chef::Resource::Route do
 
   let(:resource) { Chef::Resource::Route.new("10.0.0.10") }
 
-  it "has a name property" do
-    expect(resource.name).to eql("10.0.0.10")
+  it "the target property is the name_property" do
+    expect(resource.target).to eql("10.0.0.10")
   end
 
-  it "has a default action of 'add'" do
+  it "sets the default action as :add" do
     expect(resource.action).to eql([:add])
   end
 
-  it "accepts add or delete for action" do
+  it "supports :add, :delete actions" do
     expect { resource.action :add }.not_to raise_error
     expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :lolcat }.to raise_error(ArgumentError)
-  end
-
-  it "uses the object name as the target by default" do
-    expect(resource.target).to eql("10.0.0.10")
   end
 
   it "allows you to specify the netmask" do

data/spec/unit/resource/rpm_package_spec.rb

@@ -40,6 +40,20 @@ describe Chef::Resource::RpmPackage, "allow_downgrade" do
     expect(resource).to be_a_kind_of(Chef::Resource::Package)
   end
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "allows you to specify whether allow_downgrade is true or false" do
     expect { resource.allow_downgrade true }.not_to raise_error
     expect { resource.allow_downgrade false }.not_to raise_error

data/spec/unit/resource/ruby_block_spec.rb

@@ -23,12 +23,21 @@ describe Chef::Resource::RubyBlock do
 
   let(:resource) { Chef::Resource::RubyBlock.new("fakey_fakerton") }
 
-  it "has a default action of 'run'" do
+  it "has a resource name of :ruby_block" do
+    expect(resource.resource_name).to eql(:ruby_block)
+  end
+
+  it "the block_name property is the name_property" do
+    expect(resource.block_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :run" do
     expect(resource.action).to eql([:run])
   end
 
-  it "has a resource name of :ruby_block" do
-    expect(resource.resource_name).to eql(:ruby_block)
+  it "supports :create, :run actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :run }.not_to raise_error
   end
 
   it "accepts a ruby block/proc/.. for the 'block' parameter" do
@@ -37,11 +46,6 @@ describe Chef::Resource::RubyBlock do
     end.call).to eql("foo")
   end
 
-  it "allows the action to be 'create'" do
-    resource.action :create
-    expect(resource.action).to eq([:create])
-  end
-
   describe "when it has been initialized with block code" do
     before do
       resource.block_name("puts 'harrrr'")

data/spec/unit/resource/ruby_spec.rb

@@ -25,6 +25,14 @@ describe Chef::Resource::Ruby do
     expect(resource.resource_name).to eql(:ruby)
   end
 
+  it "sets the default action as :run" do
+    expect(resource.action).to eql([:run])
+  end
+
+  it "supports :run action" do
+    expect { resource.action :run }.not_to raise_error
+  end
+
   it "has an interpreter of ruby" do
     expect(resource.interpreter).to eql("ruby")
   end

data/spec/unit/resource/scm_spec.rb

@@ -20,14 +20,22 @@
 require "spec_helper"
 
 describe Chef::Resource::Scm do
-  let(:resource) { Chef::Resource::Scm.new("my awesome app") }
-
-  it "supports :checkout, :export, :sync, :diff, and :log actions" do
-    expect(resource.allowed_actions).to include(:checkout)
-    expect(resource.allowed_actions).to include(:export)
-    expect(resource.allowed_actions).to include(:sync)
-    expect(resource.allowed_actions).to include(:diff)
-    expect(resource.allowed_actions).to include(:log)
+  let(:resource) { Chef::Resource::Scm.new("fakey_fakerton") }
+
+  it "the destination property is the name_property" do
+    expect(resource.destination).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :sync" do
+    expect(resource.action).to eql([:sync])
+  end
+
+  it "supports :checkout, :diff, :export, :log, :sync actions" do
+    expect { resource.action :checkout }.not_to raise_error
+    expect { resource.action :diff }.not_to raise_error
+    expect { resource.action :export }.not_to raise_error
+    expect { resource.action :log }.not_to raise_error
+    expect { resource.action :sync }.not_to raise_error
   end
 
   it "takes the destination path as a string" do

data/spec/unit/resource/script_spec.rb

@@ -24,6 +24,14 @@ describe Chef::Resource::Script do
   let(:script_resource) { Chef::Resource::Script.new(resource_instance_name) }
   let(:resource_name) { :script }
 
+  it "sets the default action as :run" do
+    expect(script_resource.action).to eql([:run])
+  end
+
+  it "supports :run action" do
+    expect { script_resource.action :run }.not_to raise_error
+  end
+
   it "accepts a string for the interpreter" do
     script_resource.interpreter "naaaaNaNaNaaNaaNaaNaa"
     expect(script_resource.interpreter).to eql("naaaaNaNaNaaNaaNaaNaa")

data/spec/unit/resource/service_spec.rb

@@ -30,6 +30,21 @@ describe Chef::Resource::Service do
     expect(resource.service_name).to eql("chef")
   end
 
+  it "sets the default action as :nothing" do
+    expect(resource.action).to eql([:nothing])
+  end
+
+  it "supports :disable, :enable, :mask, :reload, :restart, :start, :stop, :unmask actions" do
+    expect { resource.action :disable }.not_to raise_error
+    expect { resource.action :enable }.not_to raise_error
+    expect { resource.action :mask }.not_to raise_error
+    expect { resource.action :reload }.not_to raise_error
+    expect { resource.action :restart }.not_to raise_error
+    expect { resource.action :start }.not_to raise_error
+    expect { resource.action :stop }.not_to raise_error
+    expect { resource.action :unmask }.not_to raise_error
+  end
+
   it "sets the pattern to be the service name by default" do
     expect(resource.pattern).to eql("chef")
   end

data/spec/unit/resource/smartos_package_spec.rb

@@ -1,6 +1,7 @@
 #
 # Author:: Thomas Bishop (<bishop.thomas@gmail.com>)
 # Copyright:: Copyright 2010-2016, Thomas Bishop
+# Copyright:: Copyright 2018, Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,9 +18,8 @@
 #
 
 require "spec_helper"
-require "support/shared/unit/resource/static_provider_resolution"
 
-describe Chef::Resource::SmartosPackage, "initialize" do
+describe Chef::Resource::SmartosPackage do
 
   static_provider_resolution(
     resource: Chef::Resource::SmartosPackage,
@@ -30,9 +30,23 @@ describe Chef::Resource::SmartosPackage, "initialize" do
     platform_family: "smartos"
   )
 
-  let(:resource) { Chef::Resource::SmartosPackage.new("foo") }
+  let(:resource) { Chef::Resource::SmartosPackage.new("fakey_fakerton") }
 
   it "sets the package_name to the name provided" do
-    expect(resource.package_name).to eql("foo")
+    expect(resource.package_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
   end
 end