chef 14.1.12 → 14.2.0

data/spec/unit/resource/solaris_package_spec.rb

@@ -37,4 +37,18 @@ describe Chef::Resource::SolarisPackage, "initialize" do
   it "sets the package_name to the name provided" do
     expect(resource.package_name).to eql("foo")
   end
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
 end

data/spec/unit/resource/subversion_spec.rb

@@ -17,10 +17,8 @@
 #
 
 require "spec_helper"
-require "support/shared/unit/resource/static_provider_resolution"
 
 describe Chef::Resource::Subversion do
-
   static_provider_resolution(
     resource: Chef::Resource::Subversion,
     provider: Chef::Provider::Subversion,
@@ -28,19 +26,27 @@ describe Chef::Resource::Subversion do
     action: :install
   )
 
-  let(:resource) { Chef::Resource::Subversion.new("ohai, svn project!") }
+  let(:resource) { Chef::Resource::Subversion.new("fakey_fakerton") }
 
   it "is a subclass of Resource::Scm" do
-    expect(resource).to be_an_instance_of(Chef::Resource::Subversion)
     expect(resource).to be_a_kind_of(Chef::Resource::Scm)
   end
 
-  it "set destination property to the name_property" do
-    expect(resource.destination).to eq("ohai, svn project!")
+  it "the destination property is the name_property" do
+    expect(resource.destination).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :sync" do
+    expect(resource.action).to eql([:sync])
   end
 
-  it "allows the force_export action" do
-    expect(resource.allowed_actions).to include(:force_export)
+  it "supports :checkout, :diff, :export, :force_export, :log, :sync actions" do
+    expect { resource.action :checkout }.not_to raise_error
+    expect { resource.action :diff }.not_to raise_error
+    expect { resource.action :export }.not_to raise_error
+    expect { resource.action :force_export }.not_to raise_error
+    expect { resource.action :log }.not_to raise_error
+    expect { resource.action :sync }.not_to raise_error
   end
 
   it "sets svn info arguments to --no-auth-cache by default" do

data/spec/unit/resource/sudo_spec.rb

@@ -22,18 +22,25 @@ describe Chef::Resource::Sudo do
   let(:node) { Chef::Node.new }
   let(:events) { Chef::EventDispatch::Dispatcher.new }
   let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::Sudo.new("someone", run_context) }
+  let(:resource) { Chef::Resource::Sudo.new("fakey_fakerton", run_context) }
 
   it "has a resource name of :sudo" do
     expect(resource.resource_name).to eql(:sudo)
   end
 
-  it "has a default action of create" do
+  it "the filename property is the name_property" do
+    expect(resource.filename).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "the filename property is the name property" do
-    expect(resource.filename).to eql("someone")
+  it "supports :create, :delete, :install, :remove actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
 
   it "coerces filename property values . & ~ to __" do

data/spec/unit/resource/swap_file_spec.rb

@@ -18,23 +18,22 @@
 require "spec_helper"
 
 describe Chef::Resource::SwapFile do
-  let(:resource) { Chef::Resource::SwapFile.new("swapfile") }
+  let(:resource) { Chef::Resource::SwapFile.new("fakey_fakerton") }
 
   it "sets resource name as :swap_file" do
     expect(resource.resource_name).to eql(:swap_file)
   end
 
-  it "sets the path as its name" do
-    expect(resource.path).to eql("swapfile")
+  it "the path property is the name_property" do
+    expect(resource.path).to eql("fakey_fakerton")
   end
 
   it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "supports :create and :remove actions" do
+  it "supports :create, :remove actions" do
     expect { resource.action :create }.not_to raise_error
     expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :delete }.to raise_error(ArgumentError)
   end
 end

data/spec/unit/resource/sysctl_spec.rb

@@ -18,18 +18,23 @@
 require "spec_helper"
 
 describe Chef::Resource::Sysctl do
-  let(:resource) { Chef::Resource::Sysctl.new("something.something") }
+  let(:resource) { Chef::Resource::Sysctl.new("fakey_fakerton") }
 
   it "sets resource name as :sysctl" do
     expect(resource.resource_name).to eql(:sysctl)
   end
 
+  it "the key property is the name_property" do
+    expect(resource.key).to eql("fakey_fakerton")
+  end
+
   it "sets the default action as :apply" do
     expect(resource.action).to eql([:apply])
   end
 
-  it "sets the key property as its name property" do
-    expect(resource.key).to eql("something.something")
+  it "supports :apply, :remove actions" do
+    expect { resource.action :apply }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
 
   it "coerces Arrays in the value property to space delimited Strings" do
@@ -46,11 +51,4 @@ describe Chef::Resource::Sysctl do
     resource.value 1.1
     expect(resource.value).to eql("1.1")
   end
-
-  it "supports :apply and :remove actions" do
-    expect { resource.action :apply }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :delete }.to raise_error(ArgumentError)
-    expect { resource.action :install }.to raise_error(ArgumentError)
-  end
 end

data/spec/unit/resource/systemd_unit_spec.rb

@@ -35,29 +35,31 @@ describe Chef::Resource::SystemdUnit do
     }
   end
 
-  it "has a name property" do
-    expect(resource.name).to eql("sysstat-collect.timer")
+  it "the unit_name property is the name_property" do
+    expect(resource.unit_name).to eql("sysstat-collect.timer")
   end
 
-  it "has a default action of nothing" do
+  it "sets the default action as :nothing" do
     expect(resource.action).to eql([:nothing])
   end
 
-  it "supports appropriate unit actions" do
+  it "supports :create, :delete, :disable, :enable, :mask, :preset, :reenable, :reload, :reload_or_restart, :reload_or_try_restart, :restart, :revert, :start, :stop, :try_restart, :unmask actions" do
     expect { resource.action :create }.not_to raise_error
     expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :preset }.not_to raise_error
-    expect { resource.action :revert }.not_to raise_error
-    expect { resource.action :enable }.not_to raise_error
     expect { resource.action :disable }.not_to raise_error
-    expect { resource.action :reenable }.not_to raise_error
+    expect { resource.action :enable }.not_to raise_error
     expect { resource.action :mask }.not_to raise_error
-    expect { resource.action :unmask }.not_to raise_error
+    expect { resource.action :preset }.not_to raise_error
+    expect { resource.action :reenable }.not_to raise_error
+    expect { resource.action :reload }.not_to raise_error
+    expect { resource.action :reload_or_restart }.not_to raise_error
+    expect { resource.action :reload_or_try_restart }.not_to raise_error
+    expect { resource.action :restart }.not_to raise_error
+    expect { resource.action :revert }.not_to raise_error
     expect { resource.action :start }.not_to raise_error
     expect { resource.action :stop }.not_to raise_error
-    expect { resource.action :restart }.not_to raise_error
-    expect { resource.action :reload }.not_to raise_error
-    expect { resource.action :wrong }.to raise_error(ArgumentError)
+    expect { resource.action :try_restart }.not_to raise_error
+    expect { resource.action :unmask }.not_to raise_error
   end
 
   it "accepts boolean state properties" do

data/spec/unit/resource/template_spec.rb

@@ -27,6 +27,25 @@ describe Chef::Resource::Template do
     end
   end
 
+  describe "name" do
+    it "the path property is the name_property" do
+      expect(resource.path).to eql("fakey_fakerton")
+    end
+  end
+
+  describe "Actions" do
+    it "sets the default action as :create" do
+      expect(resource.action).to eql([:create])
+    end
+
+    it "supports :create, :create_if_missing, :delete, :touch actions" do
+      expect { resource.action :create }.not_to raise_error
+      expect { resource.action :create_if_missing }.not_to raise_error
+      expect { resource.action :delete }.not_to raise_error
+      expect { resource.action :touch }.not_to raise_error
+    end
+  end
+
   describe "source" do
     it "accepts a string for the template source" do
       resource.source "something"

data/spec/unit/resource/{windows_ad_join.rb → windows_ad_join_spec.rb}

@@ -24,21 +24,27 @@ describe Chef::Resource::WindowsAdJoin do
     expect(resource.resource_name).to eql(:windows_ad_join)
   end
 
-  it "sets the domain_name as its name" do
+  it "the domain_name property is the name_property" do
     expect(resource.domain_name).to eql("example.com")
   end
 
-  it "only accepts FQDNs for the domain_name property" do
-    expect { resource.domain_name "example" }.to raise_error(ArgumentError)
-  end
-
   it "sets the default action as :join" do
     expect(resource.action).to eql([:join])
   end
 
-  it "accepts :immediate, :delayed, or :never values for 'reboot' property" do
+  it "supports :join action" do
+    expect { resource.action :join }.not_to raise_error
+  end
+
+  it "only accepts FQDNs for the domain_name property" do
+    expect { resource.domain_name "example" }.to raise_error(ArgumentError)
+  end
+
+  it "accepts :immediate, :reboot_now, :request_reboot, :delayed, or :never values for 'reboot' property" do
     expect { resource.reboot :immediate }.not_to raise_error
     expect { resource.reboot :delayed }.not_to raise_error
+    expect { resource.reboot :reboot_now }.not_to raise_error
+    expect { resource.reboot :request_reboot }.not_to raise_error
     expect { resource.reboot :never }.not_to raise_error
     expect { resource.reboot :nopenope }.to raise_error(ArgumentError)
   end

data/spec/unit/resource/windows_auto_run_spec.rb

@@ -18,31 +18,31 @@
 require "spec_helper"
 
 describe Chef::Resource::WindowsAutorun do
-  let(:resource) { Chef::Resource::WindowsAutorun.new("some_path") }
+  let(:resource) { Chef::Resource::WindowsAutorun.new("fakey_fakerton") }
 
   it "sets resource name as :windows_auto_run" do
     expect(resource.resource_name).to eql(:windows_auto_run)
   end
 
+  it "the program_name property is the name_property" do
+    expect(resource.program_name).to eql("fakey_fakerton")
+  end
+
   it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "sets the program_name property as its name" do
-    expect(resource.program_name).to eql("some_path")
+  it "supports :create, :remove actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
+
   it "supports :machine and :user in the root property" do
     expect { resource.root :user }.not_to raise_error
     expect { resource.root :machine }.not_to raise_error
     expect { resource.root "user" }.to raise_error(ArgumentError)
   end
 
-  it "supports :create and :remove actions" do
-    expect { resource.action :create }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :delete }.to raise_error(ArgumentError)
-  end
-
   it "coerces forward slashes to backslashes for the path" do
     resource.path "C:/something.exe"
     expect(resource.path).to eql('C:\\something.exe')

data/spec/unit/resource/windows_env_spec.rb

@@ -21,33 +21,25 @@ require "spec_helper"
 
 describe Chef::Resource::WindowsEnv do
 
-  let(:resource) { Chef::Resource::WindowsEnv.new("FOO") }
+  let(:resource) { Chef::Resource::WindowsEnv.new("fakey_fakerton") }
 
   it "creates a new Chef::Resource::WindowsEnv" do
     expect(resource).to be_a_kind_of(Chef::Resource)
     expect(resource).to be_a_kind_of(Chef::Resource::WindowsEnv)
   end
 
-  it "has a name" do
-    expect(resource.name).to eql("FOO")
+  it "the key_name property is the name_property" do
+    expect(resource.key_name).to eql("fakey_fakerton")
   end
 
-  it "has a default action of 'create'" do
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  { :create => false, :delete => false, :modify => false, :flibber => true }.each do |action, bad_value|
-    it "should #{bad_value ? 'not' : ''} accept #{action}" do
-      if bad_value
-        expect { resource.action action }.to raise_error(ArgumentError)
-      else
-        expect { resource.action action }.not_to raise_error
-      end
-    end
-  end
-
-  it "uses the object name as the key_name by default" do
-    expect(resource.key_name).to eql("FOO")
+  it "supports :create, :delete, :modify actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :modify }.not_to raise_error
   end
 
   it "accepts a string as the env value via 'value'" do

data/spec/unit/resource/windows_feature.rb

@@ -18,24 +18,43 @@
 require "spec_helper"
 
 describe Chef::Resource::WindowsFeature do
-  let(:resource) { Chef::Resource::WindowsFeature.new("SNMP") }
+  let(:resource) { Chef::Resource::WindowsFeature.new("fakey_fakerton") }
 
   it "sets resource name as :windows_feature" do
     expect(resource.resource_name).to eql(:windows_feature)
   end
 
-  it "sets the default action as :install" do
-    expect(resource.action).to eql([:install])
+  it "the feature_name property is the name_property" do
+    expect(resource.feature_name).to eql("fakey_fakerton")
   end
 
-  it "sets the feature_name property as its name" do
-    expect(resource.feature_name).to eql("SNMP")
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
   end
 
-  it "supports :install, :remove, and :delete actions" do
+  it "supports :delete, :install, :remove actions" do
+    expect { resource.action :delete }.not_to raise_error
     expect { resource.action :install }.not_to raise_error
     expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :update }.to raise_error(ArgumentError)
   end
+
+  it "all property defaults to false" do
+    expect(resource.all).to eql(false)
+  end
+
+  it "management_tools property defaults to false" do
+    expect(resource.management_tools).to eql(false)
+  end
+
+  it "timeout property defaults to 600" do
+    expect(resource.timeout).to eql(600)
+  end
+
+  it "install_method accepts :windows_feature_dism, :windows_feature_powershell, and :windows_feature_servermanagercmd" do
+    expect { resource.install_method :windows_feature_dism }.not_to raise_error
+    expect { resource.install_method :windows_feature_powershell }.not_to raise_error
+    expect { resource.install_method :windows_feature_servermanagercmd }.not_to raise_error
+    expect { resource.install_method "windows_feature_servermanagercmd" }.to raise_error(ArgumentError)
+  end
+
 end

data/spec/unit/resource/windows_feature_dism.rb

@@ -18,7 +18,10 @@
 require "spec_helper"
 
 describe Chef::Resource::WindowsFeatureDism do
-  let(:resource) { Chef::Resource::WindowsFeatureDism.new(%w{SNMP DHCP}) }
+  let(:node) { Chef::Node.new }
+  let(:events) { Chef::EventDispatch::Dispatcher.new }
+  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:resource) { Chef::Resource::WindowsFeatureDism.new(%w{SNMP DHCP}, run_context) }
 
   it "sets resource name as :windows_feature_dism" do
     expect(resource.resource_name).to eql(:windows_feature_dism)
@@ -28,24 +31,42 @@ describe Chef::Resource::WindowsFeatureDism do
     expect(resource.action).to eql([:install])
   end
 
-  it "sets the feature_name property as its name property" do
+  it "the feature_name property is the name_property" do
+    node.automatic[:platform_version] = "6.2"
     expect(resource.feature_name).to eql(%w{snmp dhcp})
   end
 
-  it "coerces comma separated lists of features to a lowercase array" do
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :delete, :install, :remove actions" do
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+  end
+
+  it "coerces comma separated lists of features to a lowercase array on 2012+" do
+    node.automatic[:platform_version] = "6.2"
     resource.feature_name "SNMP, DHCP"
     expect(resource.feature_name).to eql(%w{snmp dhcp})
   end
 
-  it "coerces a single feature as a String to a lowercase array" do
+  it "coerces a single feature as a String to a lowercase array on 2012+" do
+    node.automatic[:platform_version] = "6.2"
     resource.feature_name "SNMP"
     expect(resource.feature_name).to eql(["snmp"])
   end
 
-  it "supports :install, :remove, and :delete actions" do
-    expect { resource.action :install }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :update }.to raise_error(ArgumentError)
+  it "coerces comma separated lists of features to an array, but preserves case on < 2012" do
+    node.automatic[:platform_version] = "6.1"
+    resource.feature_name "SNMP, DHCP"
+    expect(resource.feature_name).to eql(%w{SNMP DHCP})
+  end
+
+  it "coerces a single feature as a String to an array, but preserves case on < 2012" do
+    node.automatic[:platform_version] = "6.1"
+    resource.feature_name "SNMP"
+    expect(resource.feature_name).to eql(["SNMP"])
   end
 end