chef 14.1.12 → 14.2.0

data/spec/unit/provider/user/dscl_spec.rb

@@ -283,15 +283,8 @@ ea18e18b720e358e7fbe3cfbeaa561456f6ba008937a30"
       provider.dscl_set_home
     end
 
-    it "should raise an exception when the systems user template dir (skel) cannot be found" do
-      allow(::File).to receive(:exist?).and_return(false, false, false)
-      expect { provider.dscl_set_home }.to raise_error(Chef::Exceptions::User)
-    end
-
-    it "should run ditto to copy any missing files from skel to the new home dir" do
-      expect(::File).to receive(:exist?).with("/System/Library/User\ Template/English.lproj").and_return(true)
-      expect(FileUtils).to receive(:chown_R).with("toor", "", "/Users/toor")
-      expect(provider).to receive(:shell_out!).with("ditto", "/System/Library/User Template/English.lproj", "/Users/toor")
+    it "should run createhomedir to create the user's new home folder" do
+      expect(provider).to receive(:shell_out!).with("/usr/sbin/createhomedir", "-c", "-u", "toor")
       provider.ditto_home
     end
 

data/spec/unit/provider/user/solaris_spec.rb

@@ -2,7 +2,7 @@
 # Author:: Adam Jacob (<adam@chef.io>)
 # Author:: Daniel DeLeo (<dan@chef.io>)
 # Author:: Dave Eddy (<dave@daveeddy.com>)
-# Copyright:: Copyright 2008-2016, Chef Software Inc.
+# Copyright:: Copyright 2008-2018, Chef Software Inc.
 # Copyright:: Copyright 2015-2016, Dave Eddy
 #
 # License:: Apache License, Version 2.0
@@ -68,7 +68,7 @@ describe Chef::Provider::User::Solaris do
       password_file = Tempfile.new("shadow")
       password_file.puts "adam:existingpassword:15441::::::"
       password_file.close
-      provider.password_file = password_file.path
+      stub_const("Chef::Provider::User::Solaris::PASSWORD_FILE", password_file.path)
       allow(provider).to receive(:shell_out!).and_return(true)
       # may not be able to write to /etc for tests...
       temp_file = Tempfile.new("shadow")

data/spec/unit/provider/zypper_repository_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Tim Smith (<tsmith@chef.io>)
-# Copyright:: 2017, Chef Software, Inc.
+# Copyright:: 2017-2018, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -45,11 +45,11 @@ describe Chef::Provider::ZypperRepository do
   end
 
   let(:rpm_key_finger) do
-    double("shell_out_with_systems_locale", stdout: RPM_KEYS, exitstatus: 0, error?: false)
+    double("shell_out", stdout: RPM_KEYS, exitstatus: 0, error?: false)
   end
 
   let(:gpg_finger) do
-    double("shell_out_with_systems_locale", stdout: GPG_FINGER, exitstatus: 0, error?: false)
+    double("shell_out", stdout: GPG_FINGER, exitstatus: 0, error?: false)
   end
 
   it "responds to load_current_resource" do

data/spec/unit/provider_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Adam Jacob (<adam@chef.io>)
-# Copyright:: Copyright 2008-2017, Chef Software Inc.
+# Copyright:: Copyright 2008-2018, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -75,10 +75,6 @@ describe Chef::Provider do
     expect(@provider.respond_to?(:shell_out!)).to be true
   end
 
-  it "should mixin shell_out_with_systems_locale" do
-    expect(@provider.respond_to?(:shell_out_with_systems_locale)).to be true
-  end
-
   it "should store the resource passed to new as new_resource" do
     expect(@provider.new_resource).to eql(@resource)
   end

data/spec/unit/resource/apt_package_spec.rb

@@ -31,6 +31,20 @@ describe Chef::Resource::AptPackage, "initialize" do
 
   let(:resource) { Chef::Resource::AptPackage.new("foo") }
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "supports default_release" do
     resource.default_release("lenny-backports")
     expect(resource.default_release).to eql("lenny-backports")

data/spec/unit/resource/apt_preference_spec.rb

@@ -22,7 +22,20 @@ describe Chef::Resource::AptPreference do
   let(:node) { Chef::Node.new }
   let(:events) { Chef::EventDispatch::Dispatcher.new }
   let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::AptPreference.new("libmysqlclient16", run_context) }
+  let(:resource) { Chef::Resource::AptPreference.new("fakey_fakerton", run_context) }
+
+  it "the package_name property is the name_property" do
+    expect(resource.package_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :add" do
+    expect(resource.action).to eql([:add])
+  end
+
+  it "supports :add, :remove actions" do
+    expect { resource.action :add }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+  end
 
   it "resolves to a Noop class when on non-linux OS" do
     node.automatic[:os] = "windows"

data/spec/unit/resource/apt_repository_spec.rb

@@ -25,14 +25,23 @@ describe Chef::Resource::AptRepository do
     empty_events = Chef::EventDispatch::Dispatcher.new
     Chef::RunContext.new(node, {}, empty_events)
   end
-  let(:resource) { Chef::Resource::AptRepository.new("multiverse", run_context) }
+  let(:resource) { Chef::Resource::AptRepository.new("fakey_fakerton", run_context) }
 
   it "keyserver defaults to keyserver.ubuntu.com" do
     expect(resource.keyserver).to eql("keyserver.ubuntu.com")
   end
 
-  it "repo_name is the name property" do
-    expect(resource.repo_name).to eql("multiverse")
+  it "the repo_name property is the name_property" do
+    expect(resource.repo_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :add" do
+    expect(resource.action).to eql([:add])
+  end
+
+  it "supports :add, :remove actions" do
+    expect { resource.action :add }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
   end
 
   it "distribution defaults to the distro codename" do

data/spec/unit/resource/apt_update_spec.rb

@@ -24,6 +24,15 @@ describe Chef::Resource::AptUpdate do
   let(:run_context) { Chef::RunContext.new(node, {}, events) }
   let(:resource) { Chef::Resource::AptUpdate.new("update", run_context) }
 
+  it "sets the default action as :periodic" do
+    expect(resource.action).to eql([:periodic])
+  end
+
+  it "supports :periodic, :update actions" do
+    expect { resource.action :periodic }.not_to raise_error
+    expect { resource.action :update }.not_to raise_error
+  end
+
   it "default frequency is set to be 1 day" do
     expect(resource.frequency).to eql(86_400)
   end

data/spec/unit/resource/bash_spec.rb

@@ -34,4 +34,12 @@ describe Chef::Resource::Bash do
     expect(resource.interpreter).to eql("bash")
   end
 
+  it "sets the default action as :run" do
+    expect(resource.action).to eql([:run])
+  end
+
+  it "supports :run action" do
+    expect { resource.action :run }.not_to raise_error
+  end
+
 end

data/spec/unit/resource/bff_package_spec.rb

@@ -0,0 +1,51 @@
+#
+# Author:: Tim Smith (<tsmith@chef.io>)
+# Copyright:: Copyright 2018 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "support/shared/unit/resource/static_provider_resolution"
+
+describe Chef::Resource::BffPackage, "initialize" do
+
+  static_provider_resolution(
+    resource: Chef::Resource::BffPackage,
+    provider: Chef::Provider::Package::Bff,
+    name: :bff_package,
+    action: :install,
+    os: "linux",
+    platform_family: "aix"
+  )
+
+end
+
+describe Chef::Resource::BffPackage, "defaults" do
+  let(:resource) { Chef::Resource::BffPackage.new("fakey_fakerton") }
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+end

data/spec/unit/resource/breakpoint_spec.rb

@@ -48,12 +48,12 @@ describe Chef::Resource::Breakpoint do
     provider.action_break
   end
 
-  it "allows the action :break" do
-    expect(resource.allowed_actions).to include(:break)
+  it "sets the default action as :break" do
+    expect(resource.action).to eql([:break])
   end
 
-  it "defaults to the break action" do
-    expect(resource.action).to eq([:break])
+  it "supports :break action" do
+    expect { resource.action :break }.not_to raise_error
   end
 
   it "names itself after the line number of the file where it's created" do

data/spec/unit/resource/build_essential_spec.rb

@@ -25,10 +25,14 @@ describe Chef::Resource::BuildEssential do
     expect(resource.resource_name).to eql(:build_essential)
   end
 
-  it "has a default action of install" do
+  it "sets the default action as :install" do
     expect(resource.action).to eql([:install])
   end
 
+  it "supports :install action" do
+    expect { resource.action :install }.not_to raise_error
+  end
+
   context "when not settting a resource name" do
     let(:resource) { Chef::Resource::BuildEssential.new(nil) }
 

data/spec/unit/resource/cab_package_spec.rb

@@ -34,6 +34,16 @@ describe Chef::Resource::CabPackage do
     expect(resource.action).to eql([:install])
   end
 
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "coerces name property to package_name property" do
     expect(resource.package_name).to eql("test_pkg")
   end

data/spec/unit/resource/chef_gem_spec.rb

@@ -34,6 +34,20 @@ end
 describe Chef::Resource::ChefGem, "gem_binary" do
   let(:resource) { Chef::Resource::ChefGem.new("foo") }
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "raises an exception when gem_binary is set" do
     expect { resource.gem_binary("/lol/cats/gem") }.to raise_error(ArgumentError)
   end

data/spec/unit/resource/chef_handler_spec.rb

@@ -19,17 +19,22 @@ require "spec_helper"
 
 describe Chef::Resource::ChefHandler do
 
-  let(:resource) { Chef::Resource::ChefHandler.new("foo") }
+  let(:resource) { Chef::Resource::ChefHandler.new("fakey_fakerton") }
 
   it "has a resource name of :chef_handler" do
     expect(resource.resource_name).to eql(:chef_handler)
   end
 
-  it "has a default action of enable" do
+  it "the class_name property is the name_property" do
+    expect(resource.class_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :enable" do
     expect(resource.action).to eql([:enable])
   end
 
-  it "the class_name property is the name property" do
-    expect(resource.class_name).to eql("foo")
+  it "supports :disable, :enable actions" do
+    expect { resource.action :disable }.not_to raise_error
+    expect { resource.action :enable }.not_to raise_error
   end
 end

data/spec/unit/resource/chocolatey_package_spec.rb

@@ -26,10 +26,24 @@ describe Chef::Resource::ChocolateyPackage do
     expect(resource).to be_a_kind_of(Chef::Resource::Package)
   end
 
-  it "has a resource name of :python" do
+  it "has a resource name of :chocolatey_package" do
     expect(resource.resource_name).to eql(:chocolatey_package)
   end
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "coerces its name to a package_name array" do
     expect(resource.package_name).to eql(["fakey_fakerton"])
   end

data/spec/unit/resource/conditional_spec.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright 2011-2017, Chef Software Inc.
+# Copyright:: Copyright 2011-2018, Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -92,7 +92,7 @@ describe Chef::Resource::Conditional do
     describe "after running a command which timed out" do
       before do
         @conditional = Chef::Resource::Conditional.only_if(@parent_resource, "false")
-        allow_any_instance_of(Chef::GuardInterpreter::DefaultGuardInterpreter).to receive(:shell_out_with_systems_locale).and_raise(Chef::Exceptions::CommandTimeout)
+        allow_any_instance_of(Chef::GuardInterpreter::DefaultGuardInterpreter).to receive(:shell_out).and_raise(Chef::Exceptions::CommandTimeout)
       end
 
       it "indicates that resource convergence should not continue" do
@@ -195,7 +195,7 @@ describe Chef::Resource::Conditional do
     describe "after running a command which timed out" do
       before do
         @conditional = Chef::Resource::Conditional.not_if(@parent_resource, "false")
-        allow_any_instance_of(Chef::GuardInterpreter::DefaultGuardInterpreter).to receive(:shell_out_with_systems_locale).and_raise(Chef::Exceptions::CommandTimeout)
+        allow_any_instance_of(Chef::GuardInterpreter::DefaultGuardInterpreter).to receive(:shell_out).and_raise(Chef::Exceptions::CommandTimeout)
       end
 
       it "indicates that resource convergence should continue" do

data/spec/unit/resource/cookbook_file_spec.rb

@@ -22,12 +22,23 @@ require "spec_helper"
 describe Chef::Resource::CookbookFile do
   let(:resource) { Chef::Resource::CookbookFile.new("/foo/bar/sourcecode_tarball.tgz") }
 
-  it "uses the basepath of the resourc ename for the source property" do
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create, :create_if_missing, :delete, :touch actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :create_if_missing }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
+    expect { resource.action :touch }.not_to raise_error
+  end
+
+  it "uses the basepath of the resource name for the source property" do
     expect(resource.source).to eq("sourcecode_tarball.tgz")
   end
 
   it "source property accepts Strings" do
-    resource.name("config_file.conf")
+    resource.source("config_file.conf")
     expect(resource.source).to eq("config_file.conf")
   end
 

data/spec/unit/resource/cron_spec.rb

@@ -22,18 +22,13 @@ require "spec_helper"
 describe Chef::Resource::Cron do
   let(:resource) { Chef::Resource::Cron.new("cronify") }
 
-  it "has a name property" do
-    expect(resource.name).to eql("cronify")
-  end
-
-  it "has a default action of [:create]" do
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "accepts create or delete for action" do
+  it "supports :create, :delete actions" do
     expect { resource.action :create }.not_to raise_error
     expect { resource.action :delete }.not_to raise_error
-    expect { resource.action :lolcat }.to raise_error(ArgumentError)
   end
 
   it "allows you to set a command" do

data/spec/unit/resource/csh_spec.rb

@@ -30,6 +30,14 @@ describe Chef::Resource::Csh do
     expect(resource.resource_name).to eql(:csh)
   end
 
+  it "sets the default action as :run" do
+    expect(resource.action).to eql([:run])
+  end
+
+  it "supports :run action" do
+    expect { resource.action :run }.not_to raise_error
+  end
+
   it "has an interpreter of csh" do
     expect(resource.interpreter).to eql("csh")
   end