chef 14.1.12 → 14.2.0

data/spec/unit/resource/mdadm_spec.rb

@@ -27,13 +27,17 @@ describe Chef::Resource::Mdadm do
     expect(resource.resource_name).to eql(:mdadm)
   end
 
-  it "has a default action of create" do
+  it "the raid_device property is the name_property" do
+    expect(resource.raid_device).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "accepts create, assemble, stop as actions" do
-    expect { resource.action :create }.not_to raise_error
+  it "supports :assemble, :create, :stop actions" do
     expect { resource.action :assemble }.not_to raise_error
+    expect { resource.action :create }.not_to raise_error
     expect { resource.action :stop }.not_to raise_error
   end
 

data/spec/unit/resource/mount_spec.rb

@@ -20,29 +20,26 @@
 require "spec_helper"
 
 describe Chef::Resource::Mount do
-  let(:resource) { Chef::Resource::Mount.new("filesystem") }
+  let(:resource) { Chef::Resource::Mount.new("fakey_fakerton") }
 
-  it "has a name property" do
-    expect(resource.name).to eql("filesystem")
+  it "the mount_point property is the name_property" do
+    expect(resource.mount_point).to eql("fakey_fakerton")
   end
 
-  it "sets mount_point to the name" do
-    expect(resource.mount_point).to eql("filesystem")
-  end
-
-  it "has a default action of mount" do
+  it "sets the default action as :mount" do
     expect(resource.action).to eql([:mount])
   end
 
-  it "accepts mount, umount, unmount and remount as actions" do
+  it "supports :disable, :enable, :mount, :remount, :umount, :unmount actions" do
+    expect { resource.action :disable }.not_to raise_error
+    expect { resource.action :enable }.not_to raise_error
     expect { resource.action :mount }.not_to raise_error
+    expect { resource.action :remount }.not_to raise_error
     expect { resource.action :umount }.not_to raise_error
     expect { resource.action :unmount }.not_to raise_error
-    expect { resource.action :remount }.not_to raise_error
-    expect { resource.action :brooklyn }.to raise_error(ArgumentError)
   end
 
-  it "allows you to set the device attribute" do
+  it "allows you to set the device property" do
     resource.device "/dev/sdb3"
     expect(resource.device).to eql("/dev/sdb3")
   end
@@ -51,12 +48,12 @@ describe Chef::Resource::Mount do
     expect(resource.fsck_device).to eql("-")
   end
 
-  it "allows you to set the fsck_device attribute" do
+  it "allows you to set the fsck_device property" do
     resource.fsck_device "/dev/rdsk/sdb3"
     expect(resource.fsck_device).to eql("/dev/rdsk/sdb3")
   end
 
-  it "allows you to set the fstype attribute" do
+  it "allows you to set the fstype property" do
     resource.fstype "nfs"
     expect(resource.fstype).to eql("nfs")
   end
@@ -65,17 +62,17 @@ describe Chef::Resource::Mount do
     expect(resource.fstype).to eql("auto")
   end
 
-  it "allows you to set the dump attribute" do
+  it "allows you to set the dump property" do
     resource.dump 1
     expect(resource.dump).to eql(1)
   end
 
-  it "allows you to set the pass attribute" do
+  it "allows you to set the pass property" do
     resource.pass 1
     expect(resource.pass).to eql(1)
   end
 
-  it "sets the options attribute to defaults" do
+  it "sets the options property to defaults" do
     expect(resource.options).to eql(["defaults"])
   end
 
@@ -84,7 +81,7 @@ describe Chef::Resource::Mount do
     expect(resource.options).to be_a_kind_of(Array)
   end
 
-  it "allows options attribute as an array" do
+  it "allows options property as an array" do
     resource.options %w{ro nosuid}
     expect(resource.options).to be_a_kind_of(Array)
   end

data/spec/unit/resource/msu_package_spec.rb

@@ -33,6 +33,16 @@ describe Chef::Resource::MsuPackage do
     expect(resource.action).to eql([:install])
   end
 
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "coerces name property to package_name property" do
     expect(resource.package_name).to eql("test_pkg")
   end

data/spec/unit/resource/ohai_hint_spec.rb

@@ -19,25 +19,26 @@ require "spec_helper"
 
 describe Chef::Resource::OhaiHint do
 
-  let(:resource) { Chef::Resource::OhaiHint.new("foo") }
+  let(:resource) { Chef::Resource::OhaiHint.new("fakey_fakerton") }
 
   it "has a resource name of :ohai_hint" do
     expect(resource.resource_name).to eql(:ohai_hint)
   end
 
-  it "has a default action of create" do
+  it "the hint_name property is the name_property" do
+    expect(resource.hint_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "supports the :nothing, :create and :delete actions" do
-    expect(resource.allowed_actions).to include(:nothing, :create, :delete)
+  it "supports :create, :delete actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :delete }.not_to raise_error
   end
 
   it "runs at compile_time by default" do
     expect(resource.compile_time).to eql(true)
   end
-
-  it "the hint_name property is the name property" do
-    expect(resource.hint_name).to eql("foo")
-  end
 end

data/spec/unit/resource/ohai_spec.rb

@@ -20,17 +20,25 @@ require "spec_helper"
 
 describe Chef::Resource::Ohai do
 
-  let(:resource) { Chef::Resource::Ohai.new("ohai_reload") }
+  let(:resource) { Chef::Resource::Ohai.new("fakey_fakerton") }
 
   it "has a resource name of :ohai" do
     expect(resource.resource_name).to eql(:ohai)
   end
 
-  it "has a default action of reload" do
+  it "the ohai_name property is the name_property" do
+    expect(resource.ohai_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :reload" do
     expect(resource.action).to eql([:reload])
   end
 
-  it "allows you to set the plugin attribute" do
+  it "supports :reload action" do
+    expect { resource.action :reload }.not_to raise_error
+  end
+
+  it "allows you to set the plugin property" do
     resource.plugin "passwd"
     expect(resource.plugin).to eql("passwd")
   end

data/spec/unit/resource/openbsd_package_spec.rb

@@ -36,6 +36,20 @@ describe Chef::Resource::OpenbsdPackage do
       expect(resource.resource_name).to eql(:openbsd_package)
     end
 
+    it "sets the default action as :install" do
+      expect(resource.action).to eql([:install])
+    end
+
+    it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+      expect { resource.action :install }.not_to raise_error
+      expect { resource.action :lock }.not_to raise_error
+      expect { resource.action :purge }.not_to raise_error
+      expect { resource.action :reconfig }.not_to raise_error
+      expect { resource.action :remove }.not_to raise_error
+      expect { resource.action :unlock }.not_to raise_error
+      expect { resource.action :upgrade }.not_to raise_error
+    end
+
     it "does not set the provider" do
       expect(resource.provider).to be_nil
     end

data/spec/unit/resource/openssl_dhparam.rb

@@ -19,16 +19,24 @@ require "spec_helper"
 
 describe Chef::Resource::OpensslDhparam do
 
-  let(:resource) { Chef::Resource::OpensslDhparam.new("dhparam") }
+  let(:resource) { Chef::Resource::OpensslDhparam.new("fakey_fakerton") }
 
   it "has a resource name of :openssl_dhparam" do
     expect(resource.resource_name).to eql(:openssl_dhparam)
   end
 
-  it "has a default action of create" do
+  it "the path property is the name_property" do
+    expect(resource.path).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
+  it "supports :create action" do
+    expect { resource.action :create }.not_to raise_error
+  end
+
   it "has a default mode of '0640'" do
     expect(resource.mode).to eql("0640")
   end
@@ -45,7 +53,4 @@ describe Chef::Resource::OpensslDhparam do
     expect { resource.key_length 1234 }.to raise_error(ArgumentError)
   end
 
-  it "the path property is the name property" do
-    expect(resource.path).to eql("dhparam")
-  end
 end

data/spec/unit/resource/openssl_rsa_private_key_spec.rb

@@ -19,16 +19,24 @@ require "spec_helper"
 
 describe Chef::Resource::OpensslRsaPrivateKey do
 
-  let(:resource) { Chef::Resource::OpensslRsaPrivateKey.new("key") }
+  let(:resource) { Chef::Resource::OpensslRsaPrivateKey.new("fakey_fakerton") }
 
   it "has a resource name of :openssl_rsa_private_key" do
     expect(resource.resource_name).to eql(:openssl_rsa_private_key)
   end
 
-  it "has a default action of create" do
+  it "the path property is the name_property" do
+    expect(resource.path).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
+  it "supports :create action" do
+    expect { resource.action :create }.not_to raise_error
+  end
+
   it "has a default mode of '0600'" do
     expect(resource.mode).to eql("0600")
   end
@@ -53,7 +61,4 @@ describe Chef::Resource::OpensslRsaPrivateKey do
     expect(resource.force).to eql(false)
   end
 
-  it "the path property is the name property" do
-    expect(resource.path).to eql("key")
-  end
 end

data/spec/unit/resource/openssl_rsa_public_key_spec.rb

@@ -25,15 +25,19 @@ describe Chef::Resource::OpensslRsaPublicKey do
     expect(resource.resource_name).to eql(:openssl_rsa_public_key)
   end
 
-  it "has a default action of create" do
+  it "the path property is the name_property" do
+    expect(resource.path).to eql("key")
+  end
+
+  it "sets the default action as :create" do
     expect(resource.action).to eql([:create])
   end
 
-  it "has a default mode of '0640'" do
-    expect(resource.mode).to eql("0640")
+  it "supports :create action" do
+    expect { resource.action :create }.not_to raise_error
   end
 
-  it "the path property is the name property" do
-    expect(resource.path).to eql("key")
+  it "has a default mode of '0640'" do
+    expect(resource.mode).to eql("0640")
   end
 end

data/spec/unit/resource/osx_profile_spec.rb

@@ -21,19 +21,22 @@ require "spec_helper"
 describe Chef::Resource::OsxProfile do
   let(:resource) do
     Chef::Resource::OsxProfile.new(
-    "Test Profile Resource",
-    run_context)
+    "fakey_fakerton")
   end
 
   it "has a resource name of profile" do
     expect(resource.resource_name).to eql(:osx_profile)
   end
 
-  it "has a default action of install" do
+  it "the profile_name property is the name_property" do
+    expect(resource.profile_name).to eql("fakey_fakerton")
+  end
+
+  it "sets the default action as :install" do
     expect(resource.action).to eql([:install])
   end
 
-  it "accepts install and remove as actions" do
+  it "supports :install, :remove actions" do
     expect { resource.action :install }.not_to raise_error
     expect { resource.action :remove }.not_to raise_error
   end

data/spec/unit/resource/package_spec.rb

@@ -26,6 +26,20 @@ describe Chef::Resource::Package do
     expect(resource.package_name).to eql("emacs")
   end
 
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+
   it "accepts a string for the package name" do
     resource.package_name "something"
     expect(resource.package_name).to eql("something")

data/spec/unit/resource/pacman_package_spec.rb

@@ -1,6 +1,7 @@
 #
 # Author:: Jan Zimmek (<jan.zimmek@web.de>)
 # Copyright:: Copyright 2010-2016, Jan Zimmek
+# Copyright:: 2018, Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,10 +18,8 @@
 #
 
 require "spec_helper"
-require "support/shared/unit/resource/static_provider_resolution"
-
-describe Chef::Resource::PacmanPackage, "initialize" do
 
+describe Chef::Resource::PacmanPackage do
   static_provider_resolution(
     resource: Chef::Resource::PacmanPackage,
     provider: Chef::Provider::Package::Pacman,
@@ -29,4 +28,19 @@ describe Chef::Resource::PacmanPackage, "initialize" do
     os: "linux"
   )
 
+  let(:resource) { Chef::Resource::PacmanPackage.new("fakey_fakerton") }
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
 end

data/spec/unit/resource/paludis_package_spec.rb

@@ -0,0 +1,36 @@
+#
+# Copyright:: Copyright 2018, Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::PaludisPackage do
+  let(:resource) { Chef::Resource::PaludisPackage.new("fakey_fakerton") }
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
+end

data/spec/unit/resource/perl_spec.rb

@@ -33,4 +33,12 @@ describe Chef::Resource::Perl do
   it "has an interpreter of perl" do
     expect(resource.interpreter).to eql("perl")
   end
+
+  it "sets the default action as :run" do
+    expect(resource.action).to eql([:run])
+  end
+
+  it "supports :run action" do
+    expect { resource.action :run }.not_to raise_error
+  end
 end

data/spec/unit/resource/portage_package_spec.rb

@@ -29,4 +29,18 @@ describe Chef::Resource::PortagePackage, "initialize" do
   it "sets the resource_name to :portage_package" do
     expect(resource.resource_name).to eql(:portage_package)
   end
+
+  it "sets the default action as :install" do
+    expect(resource.action).to eql([:install])
+  end
+
+  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
+    expect { resource.action :install }.not_to raise_error
+    expect { resource.action :lock }.not_to raise_error
+    expect { resource.action :purge }.not_to raise_error
+    expect { resource.action :reconfig }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+    expect { resource.action :unlock }.not_to raise_error
+    expect { resource.action :upgrade }.not_to raise_error
+  end
 end