capybara 2.7.0 → 3.35.3

data/spec/rspec/views_spec.rb

@@ -1,8 +1,14 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.describe "capybara/rspec", type: :view do
-  it "allows matchers to be used on strings" do
-    expect(%{<h1>Test header</h1>}).to have_css("h1", text: "Test header")
+RSpec.describe 'capybara/rspec', type: :view do
+  it 'allows matchers to be used on strings' do
+    html = %(<h1>Test header</h1>)
+    expect(html).to have_css('h1', text: 'Test header')
+  end
+
+  it "doesn't include RSpecMatcherProxies" do
+    expect(self.class.ancestors).not_to include(Capybara::RSpecMatcherProxies)
   end
 end

data/spec/rspec_matchers_spec.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Capybara RSpec Matchers', type: :feature do
+  context 'after called on session' do
+    it 'HaveSelector should allow getting a description of the matcher' do
+      visit('/with_html')
+      matcher = have_selector(:css, 'h2.head', minimum: 3)
+      expect(page).to matcher
+      expect { matcher.description }.not_to raise_error
+    end
+
+    it 'HaveText should allow getting a description' do
+      visit('/with_html')
+      matcher = have_text('Lorem')
+      expect(page).to matcher
+      expect { matcher.description }.not_to raise_error
+    end
+
+    it 'should produce the same error for .to have_no_xxx and .not_to have_xxx' do
+      visit('/with_html')
+      not_to_msg = error_msg_for { expect(page).not_to have_selector(:css, '#referrer') }
+      have_no_msg = error_msg_for { expect(page).to have_no_selector(:css, '#referrer') }
+      expect(not_to_msg).to eq have_no_msg
+
+      not_to_msg = error_msg_for { expect(page).not_to have_text('This is a test') }
+      have_no_msg = error_msg_for { expect(page).to have_no_text('This is a test') }
+      expect(not_to_msg).to eq have_no_msg
+    end
+  end
+
+  context 'after called on element' do
+    it 'HaveSelector should allow getting a description' do
+      visit('/with_html')
+      el = find(:css, '#first')
+      matcher = have_selector(:css, 'a#foo')
+      expect(el).to matcher
+      expect { matcher.description }.not_to raise_error
+    end
+
+    it 'MatchSelector should allow getting a description' do
+      visit('/with_html')
+      el = find(:css, '#first')
+      matcher = match_selector(:css, '#first')
+      expect(el).to matcher
+      expect { matcher.description }.not_to raise_error
+    end
+
+    it 'HaveText should allow getting a description' do
+      visit('/with_html')
+      el = find(:css, '#first')
+      matcher = have_text('Lorem')
+      expect(el).to matcher
+      expect { matcher.description }.not_to raise_error
+    end
+  end
+
+  def error_msg_for(&block)
+    expect(&block).to(raise_error { |e| return e.message })
+  end
+end

data/spec/rspec_spec.rb

@@ -1,52 +1,149 @@
 # frozen_string_literal: true
+
+# rubocop:disable RSpec/MultipleDescribes
+
 require 'spec_helper'
 
-RSpec.describe 'capybara/rspec', :type => :feature do
-  it "should include Capybara in rspec" do
-    visit('/foo')
-    expect(page.body).to include('Another World')
-  end
+RSpec.describe 'capybara/rspec' do
+  context 'Feature', type: :feature do
+    it 'should include Capybara in rspec' do
+      visit('/foo')
+      expect(page.body).to include('Another World')
+    end
+
+    it 'should include RSpec matcher proxies' do
+      expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
+    end
+
+    context 'resetting session' do
+      it 'sets a cookie in one example...' do
+        visit('/set_cookie')
+        expect(page.body).to include('Cookie set to test_cookie')
+      end
 
-  context "resetting session" do
-    it "sets a cookie in one example..." do
-      visit('/set_cookie')
-      expect(page.body).to include('Cookie set to test_cookie')
+      it '...then it is not available in the next' do
+        visit('/get_cookie')
+        expect(page.body).not_to include('test_cookie')
+      end
     end
 
-    it "...then it is not available in the next" do
-      visit('/get_cookie')
-      expect(page.body).not_to include('test_cookie')
+    context 'setting the current driver' do
+      it 'sets the current driver in one example...' do
+        Capybara.current_driver = :selenium
+      end
+
+      it '...then it has returned to the default in the next example' do
+        expect(Capybara.current_driver).to eq(:rack_test)
+      end
     end
-  end
 
-  context "setting the current driver" do
-    it "sets the current driver in one example..." do
-      Capybara.current_driver = :selenium
+    it 'switches to the javascript driver when giving it as metadata', js: true do
+      expect(Capybara.current_driver).to eq(Capybara.javascript_driver)
     end
 
-    it "...then it has returned to the default in the next example" do
-      expect(Capybara.current_driver).to eq(:rack_test)
+    it 'switches to the given driver when giving it as metadata', driver: :culerity do
+      expect(Capybara.current_driver).to eq(:culerity)
     end
-  end
 
-  it "switches to the javascript driver when giving it as metadata", :js => true do
-    expect(Capybara.current_driver).to eq(Capybara.javascript_driver)
-  end
+    describe '#all' do
+      it 'allows access to the Capybara finder' do
+        visit('/with_html')
+        found = all(:css, 'h2') { |element| element[:class] == 'head' }
+        expect(found.size).to eq(5)
+      end
+
+      it 'allows access to the RSpec matcher' do
+        visit('/with_html')
+        strings = %w[test1 test2]
+        expect(strings).to all(be_a(String))
+      end
+    end
+
+    describe '#within' do
+      it 'allows access to the Capybara scoper' do
+        visit('/with_html')
+        expect do
+          within(:css, '#does_not_exist') { click_link 'Go to simple' }
+        end.to raise_error(Capybara::ElementNotFound)
+      end
 
-  it "switches to the given driver when giving it as metadata", :driver => :culerity do
-    expect(Capybara.current_driver).to eq(:culerity)
+      it 'allows access to the RSpec matcher' do
+        visit('/with_html')
+        # This reads terribly, but must call #within
+        expect(find(:css, 'span.number').text.to_i).to within(1).of(41)
+      end
+    end
   end
-end
 
-RSpec.describe 'capybara/rspec', :type => :other do
-  it "should not include Capybara" do
-    expect { visit('/') }.to raise_error(NoMethodError)
+  context 'Type: Other', type: :other do
+    context 'when RSpec::Matchers is included after Capybara::DSL' do
+      let(:test_class_instance) do
+        Class.new do
+          include Capybara::DSL
+          include RSpec::Matchers
+        end.new
+      end
+
+      describe '#all' do
+        it 'allows access to the Capybara finder' do
+          test_class_instance.visit('/with_html')
+          expect(test_class_instance.all(:css, 'h2.head').size).to eq(5)
+        end
+
+        it 'allows access to the RSpec matcher' do
+          test_class_instance.visit('/with_html')
+          strings = %w[test1 test2]
+          expect(strings).to test_class_instance.all(be_a(String))
+        end
+      end
+
+      describe '#within' do
+        it 'allows access to the Capybara scoper' do
+          test_class_instance.visit('/with_html')
+          expect do
+            test_class_instance.within(:css, '#does_not_exist') { test_class_instance.click_link 'Go to simple' }
+          end.to raise_error(Capybara::ElementNotFound)
+        end
+
+        it 'allows access to the RSpec matcher' do
+          test_class_instance.visit('/with_html')
+          # This reads terribly, but must call #within
+          expect(test_class_instance.find(:css, 'span.number').text.to_i).to test_class_instance.within(1).of(41)
+        end
+      end
+
+      context 'when `match_when_negated` is not defined in a matcher' do
+        before do
+          RSpec::Matchers.define :only_match_matcher do |expected|
+            match do |actual|
+              !(actual ^ expected)
+            end
+          end
+        end
+
+        it 'can be called with `not_to`' do
+          # This test is for a bug in jruby where `super` isn't defined correctly - https://github.com/jruby/jruby/issues/4678
+          # Reported in https://github.com/teamcapybara/capybara/issues/2115
+          test_class_instance.instance_eval do
+            expect do
+              expect(true).not_to only_match_matcher(false) # rubocop:disable RSpec/ExpectActual
+            end.not_to raise_error
+          end
+        end
+      end
+    end
+
+    it 'should not include Capybara' do
+      expect { visit('/') }.to raise_error(NoMethodError)
+    end
   end
 end
 
-feature "Feature DSL" do
-  scenario "is pulled in" do
+feature 'Feature DSL' do
+  scenario 'is pulled in' do
     visit('/foo')
     expect(page.body).to include('Another World')
   end
 end
+
+# rubocop:enable RSpec/MultipleDescribes

data/spec/sauce_spec_chrome.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'selenium-webdriver'
+
+require 'sauce_whisk'
+# require 'shared_selenium_session'
+# require 'shared_selenium_node'
+# require 'rspec/shared_spec_matchers'
+
+Capybara.register_driver :sauce_chrome do |app|
+  options = {
+    selenium_version: '3.141.59',
+    platform: 'macOS 10.12',
+    browser_name: 'chrome',
+    version: '65.0',
+    name: 'Capybara test',
+    build: ENV['TRAVIS_REPO_SLUG'] || "Ruby-RSpec-Selenium: Local-#{Time.now.to_i}",
+    username: ENV['SAUCE_USERNAME'],
+    access_key: ENV['SAUCE_ACCESS_KEY']
+  }
+
+  options.delete(:browser_name)
+
+  capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(options)
+  url = 'https://ondemand.saucelabs.com:443/wd/hub'
+
+  Capybara::Selenium::Driver.new(app,
+                                 browser: :remote, url: url,
+                                 desired_capabilities: capabilities,
+                                 options: Selenium::WebDriver::Chrome::Options.new(args: ['']))
+end
+
+CHROME_REMOTE_DRIVER = :sauce_chrome
+
+module TestSessions
+  Chrome = Capybara::Session.new(CHROME_REMOTE_DRIVER, TestApp)
+end
+
+skipped_tests = %i[response_headers status_code trigger download]
+
+Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_REMOTE_DRIVER.to_s, capybara_skip: skipped_tests do |example|
+end

data/spec/selector_spec.rb

@@ -1,107 +1,528 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Capybara do
+  include Capybara::RSpecMatchers
   describe 'Selectors' do
     let :string do
-      Capybara.string <<-STRING
+      described_class.string <<-STRING
         <html>
           <head>
             <title>selectors</title>
           </head>
           <body>
-            <div class="a" id="page">
-              <div class="b" id="content">
-                <h1 class="a">Totally awesome</h1>
+            <div class="aa" id="page">
+              <div class="bb" id="content">
+                <h1 class="aa">Totally awesome</h1>
                 <p>Yes it is</p>
               </div>
-              <p class="b">Some Content</p>
-              <p class="b"></p>
+              <p class="bb cc">Some Content</p>
+              <p class="bb dd !mine"></p>
+            </div>
+            <div id="#special">
+            </div>
+            <div class="some random words" id="random_words">
+              Something
             </div>
-            <input type="checkbox"/>
+            <input id="2checkbox" class="2checkbox" type="checkbox"/>
             <input type="radio"/>
-            <input type="text"/>
-            <input type="file"/>
+            <label for="my_text_input">My Text Input</label>
+            <input type="text" name="form[my_text_input]" placeholder="my text" id="my_text_input"/>
+            <input type="file" id="file" class=".special file"/>
+            <input type="hidden" id="hidden_field" value="this is hidden"/>
+            <input type="submit" value="click me" title="submit button"/>
+            <input type="button" value="don't click me" title="Other button 1" style="line-height: 30px;"/>
             <a href="#">link</a>
             <fieldset></fieldset>
-            <select>
+            <select id="select">
               <option value="a">A</option>
               <option value="b" disabled>B</option>
               <option value="c" selected>C</option>
             </select>
             <table>
               <tr><td></td></tr>
-            </table
+            </table>
+            <table id="rows">
+              <tr>
+                <td>A</td><td>B</td><td>C</td>
+              </tr>
+              <tr>
+                <td>D</td><td>E</td><td>F</td>
+              </tr>
+            </table>
+            <table id="cols">
+            <tbody>
+              <tr>
+                <td>A</td><td>D</td>
+              </tr>
+              <tr>
+                <td>B</td><td>E</td>
+              </tr>
+              <tr>
+                <td>C</td><td>F</td>
+              </tr>
+              </tbody>
+            </table>
           </body>
         </html>
       STRING
     end
 
     before do
-      Capybara.add_selector :custom_selector do
+      described_class.add_selector :custom_selector do
         css { |css_class| "div.#{css_class}" }
-        filter(:not_empty, boolean: true, default: true, skip_if: :all) { |node, value| value ^ (node.text == '') }
+        node_filter(:not_empty, boolean: true, default: true, skip_if: :all) { |node, value| value ^ (node.text == '') }
       end
+
+      described_class.add_selector :custom_css_selector do
+        css(:name, :other_name) do |selector, name: nil, **|
+          selector ||= ''
+          selector += "[name='#{name}']" if name
+          selector
+        end
+
+        expression_filter(:placeholder) do |expr, val|
+          expr + "[placeholder='#{val}']"
+        end
+
+        expression_filter(:value) do |expr, val|
+          expr + "[value='#{val}']"
+        end
+
+        expression_filter(:title) do |expr, val|
+          expr + "[title='#{val}']"
+        end
+      end
+
+      described_class.add_selector :custom_xpath_selector do
+        xpath(:valid1, :valid2) { |selector| selector }
+        match { |value| value == 'match_me' }
+      end
+    end
+
+    it 'supports `filter` as an alias for `node_filter`' do
+      expect do
+        described_class.add_selector :filter_alias_selector do
+          css { |_unused| 'div' }
+          filter(:something) { |_node, _value| true }
+        end
+      end.not_to raise_error
     end
 
-    describe "modify_selector" do
-      it "allows modifying a selector" do
-        el = string.find(:custom_selector, 'a')
+    describe 'adding a selector' do
+      it 'can set default visiblity' do
+        described_class.add_selector :hidden_field do
+          visible :hidden
+          css { |_sel| 'input[type="hidden"]' }
+        end
+
+        expect(string).to have_no_css('input[type="hidden"]')
+        expect(string).to have_selector(:hidden_field)
+      end
+    end
+
+    describe 'modify_selector' do
+      it 'allows modifying a selector' do
+        el = string.find(:custom_selector, 'aa')
         expect(el.tag_name).to eq 'div'
-        Capybara.modify_selector :custom_selector do
+        described_class.modify_selector :custom_selector do
           css { |css_class| "h1.#{css_class}" }
         end
-        el = string.find(:custom_selector, 'a')
+        el = string.find(:custom_selector, 'aa')
         expect(el.tag_name).to eq 'h1'
       end
 
       it "doesn't change existing filters" do
-        Capybara.modify_selector :custom_selector do
-          css { |css_class| "p.#{css_class}"}
+        described_class.modify_selector :custom_selector do
+          css { |css_class| "p.#{css_class}" }
+        end
+        expect(string).to have_selector(:custom_selector, 'bb', count: 1)
+        expect(string).to have_selector(:custom_selector, 'bb', not_empty: false, count: 1)
+        expect(string).to have_selector(:custom_selector, 'bb', not_empty: :all, count: 2)
+      end
+    end
+
+    describe '::[]' do
+      it 'can find a selector' do
+        expect(Capybara::Selector[:field]).not_to be_nil
+      end
+
+      it 'raises if no selector found' do
+        expect { Capybara::Selector[:no_exist] }.to raise_error(ArgumentError, /Unknown selector type/)
+      end
+    end
+
+    describe '::for' do
+      it 'finds selector that matches the locator' do
+        expect(Capybara::Selector.for('match_me').name).to eq :custom_xpath_selector
+      end
+
+      it 'returns nil if no match' do
+        expect(Capybara::Selector.for('nothing')).to be nil
+      end
+    end
+
+    describe 'xpath' do
+      it 'uses filter names passed in' do
+        described_class.add_selector :test do
+          xpath(:something, :other) { |_locator| XPath.descendant }
+        end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
+
+        expect(selector.expression_filters.keys).to include(:something, :other)
+      end
+
+      it 'gets filter names from block if none passed to xpath method' do
+        described_class.add_selector :test do
+          xpath { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
+        end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
+
+        expect(selector.expression_filters.keys).to include(:valid3, :valid4)
+      end
+
+      it 'ignores block parameters if names passed in' do
+        described_class.add_selector :test do
+          xpath(:valid1) { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
         end
-        expect(string).to have_selector(:custom_selector, 'b', count: 1)
-        expect(string).to have_selector(:custom_selector, 'b', not_empty: false, count: 1)
-        expect(string).to have_selector(:custom_selector, 'b', not_empty: :all, count: 2)
+        selector = Capybara::Selector.new :test, config: nil, format: nil
+
+        expect(selector.expression_filters.keys).to include(:valid1)
+        expect(selector.expression_filters.keys).not_to include(:valid3, :valid4)
+      end
+    end
+
+    describe 'css' do
+      it "supports filters specified in 'css' definition" do
+        expect(string).to have_selector(:custom_css_selector, 'input', name: 'form[my_text_input]')
+        expect(string).to have_no_selector(:custom_css_selector, 'input', name: 'form[not_my_text_input]')
+      end
+
+      it 'supports explicitly defined expression filters' do
+        expect(string).to have_selector(:custom_css_selector, placeholder: 'my text')
+        expect(string).to have_no_selector(:custom_css_selector, placeholder: 'not my text')
+        expect(string).to have_selector(:custom_css_selector, value: 'click me', title: 'submit button')
+      end
+
+      it 'uses filter names passed in' do
+        described_class.add_selector :test do
+          css(:name, :other_name) { |_locator| '' }
+        end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
+
+        expect(selector.expression_filters.keys).to include(:name, :other_name)
+      end
+
+      it 'gets filter names from block if none passed to css method' do
+        described_class.add_selector :test do
+          css { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
+        end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
+
+        expect(selector.expression_filters.keys).to include(:valid3, :valid4)
+      end
+
+      it 'ignores block parameters if names passed in' do
+        described_class.add_selector :test do
+          css(:valid1) { |_locator, valid3:, valid4: nil| "#{valid3} #{valid4}" }
+        end
+        selector = Capybara::Selector.new :test, config: nil, format: nil
+
+        expect(selector.expression_filters.keys).to include(:valid1)
+        expect(selector.expression_filters.keys).not_to include(:valid3, :valid4)
       end
     end
 
-    describe "builtin selectors" do
-      context "when locator is nil" do
-        it "devolves to just finding element types" do
+    describe 'builtin selectors' do
+      context 'when locator is nil' do
+        it 'devolves to just finding element types' do
           selectors = {
             field: ".//*[self::input | self::textarea | self::select][not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]",
-            fieldset: ".//fieldset",
-            link: ".//a[./@href]",
-            link_or_button: ".//a[./@href] | .//input[./@type = 'submit' or ./@type = 'reset' or ./@type = 'image' or ./@type = 'button'] | .//button" ,
+            fieldset: './/fieldset',
+            link: './/a[./@href]',
+            link_or_button: ".//a[./@href] | .//input[./@type = 'submit' or ./@type = 'reset' or ./@type = 'image' or ./@type = 'button'] | .//button",
             fillable_field: ".//*[self::input | self::textarea][not(./@type = 'submit' or ./@type = 'image' or ./@type = 'radio' or ./@type = 'checkbox' or ./@type = 'hidden' or ./@type = 'file')]",
             radio_button: ".//input[./@type = 'radio']",
             checkbox: ".//input[./@type = 'checkbox']",
-            select: ".//select",
-            option: ".//option",
+            select: './/select',
+            option: './/option',
             file_field: ".//input[./@type = 'file']",
-            table: ".//table"
+            table: './/table'
           }
           selectors.each do |selector, xpath|
-            results = string.all(selector,nil).to_a.map &:native
+            results = string.all(selector, nil).to_a.map(&:native)
             expect(results.size).to be > 0
             expect(results).to eq string.all(:xpath, xpath).to_a.map(&:native)
           end
         end
       end
 
-      describe ":option selector" do
-        it "finds disabled options" do
+      context 'with :id option' do
+        it 'works with compound css selectors' do
+          expect(string.all(:custom_css_selector, 'div, h1', id: 'page').size).to eq 1
+          expect(string.all(:custom_css_selector, 'h1, div', id: 'page').size).to eq 1
+        end
+
+        it "works with 'special' characters" do
+          expect(string.find(:custom_css_selector, 'div', id: '#special')[:id]).to eq '#special'
+          expect(string.find(:custom_css_selector, 'input', id: '2checkbox')[:id]).to eq '2checkbox'
+        end
+
+        it 'accepts XPath expression for xpath based selectors' do
+          expect(string.find(:custom_xpath_selector, './/div', id: XPath.contains('peci'))[:id]).to eq '#special'
+          expect(string.find(:custom_xpath_selector, './/input', id: XPath.ends_with('box'))[:id]).to eq '2checkbox'
+        end
+
+        it 'errors XPath expression for CSS based selectors' do
+          expect { string.find(:custom_css_selector, 'div', id: XPath.contains('peci')) }
+            .to raise_error(ArgumentError, /not supported/)
+        end
+
+        it 'accepts Regexp for xpath based selectors' do
+          expect(string.find(:custom_xpath_selector, './/div', id: /peci/)[:id]).to eq '#special'
+          expect(string.find(:custom_xpath_selector, './/div', id: /pEcI/i)[:id]).to eq '#special'
+        end
+
+        it 'accepts Regexp for css based selectors' do
+          expect(string.find(:custom_css_selector, 'div', id: /sp.*al/)[:id]).to eq '#special'
+        end
+      end
+
+      context 'with :class option' do
+        it 'works with compound css selectors' do
+          expect(string.all(:custom_css_selector, 'div, h1', class: 'aa').size).to eq 2
+          expect(string.all(:custom_css_selector, 'h1, div', class: 'aa').size).to eq 2
+        end
+
+        it 'handles negated classes' do
+          expect(string.all(:custom_css_selector, 'div, p', class: ['bb', '!cc']).size).to eq 2
+          expect(string.all(:custom_css_selector, 'div, p', class: ['!cc', '!dd', 'bb']).size).to eq 1
+          expect(string.all(:custom_xpath_selector, XPath.descendant(:div, :p), class: ['bb', '!cc']).size).to eq 2
+          expect(string.all(:custom_xpath_selector, XPath.descendant(:div, :p), class: ['!cc', '!dd', 'bb']).size).to eq 1
+        end
+
+        it 'handles classes starting with ! by requiring negated negated first' do
+          expect(string.all(:custom_css_selector, 'div, p', class: ['!!!mine']).size).to eq 1
+          expect(string.all(:custom_xpath_selector, XPath.descendant(:div, :p), class: ['!!!mine']).size).to eq 1
+        end
+
+        it "works with 'special' characters" do
+          expect(string.find(:custom_css_selector, 'input', class: '.special')[:id]).to eq 'file'
+          expect(string.find(:custom_css_selector, 'input', class: '2checkbox')[:id]).to eq '2checkbox'
+        end
+
+        it 'accepts XPath expression for xpath based selectors' do
+          expect(string.find(:custom_xpath_selector, './/div', class: XPath.contains('dom wor'))[:id]).to eq 'random_words'
+          expect(string.find(:custom_xpath_selector, './/div', class: XPath.ends_with('words'))[:id]).to eq 'random_words'
+        end
+
+        it 'errors XPath expression for CSS based selectors' do
+          expect { string.find(:custom_css_selector, 'div', class: XPath.contains('random')) }
+            .to raise_error(ArgumentError, /not supported/)
+        end
+
+        it 'accepts Regexp for XPath based selectors' do
+          expect(string.find(:custom_xpath_selector, './/div', class: /dom wor/)[:id]).to eq 'random_words'
+          expect(string.find(:custom_xpath_selector, './/div', class: /dOm WoR/i)[:id]).to eq 'random_words'
+        end
+
+        it 'accepts Regexp for CSS based selectors' do
+          expect(string.find(:custom_css_selector, 'div', class: /random/)[:id]).to eq 'random_words'
+        end
+
+        it 'accepts Regexp for individual class names for XPath based selectors' do
+          expect(string.find(:custom_xpath_selector, './/div', class: [/random/, 'some'])[:id]).to eq 'random_words'
+          expect(string.find(:custom_xpath_selector, './/div', class: [/om/, /wor/])[:id]).to eq 'random_words'
+          expect { string.find(:custom_xpath_selector, './/div', class: [/not/, /wor/]) }.to raise_error(Capybara::ElementNotFound)
+          expect { string.find(:custom_xpath_selector, './/div', class: [/dom wor/]) }.to raise_error(Capybara::ElementNotFound)
+        end
+
+        it 'accepts Regexp for individual class names for CSS based selectors' do
+          expect(string.find(:custom_css_selector, 'div', class: [/random/])[:id]).to eq 'random_words'
+          expect(string.find(:custom_css_selector, 'div', class: [/om/, /wor/, 'some'])[:id]).to eq 'random_words'
+          expect { string.find(:custom_css_selector, 'div', class: [/not/, /wor/]) }.to raise_error(Capybara::ElementNotFound)
+          expect { string.find(:custom_css_selector, 'div', class: [/dom wor/]) }.to raise_error(Capybara::ElementNotFound)
+        end
+      end
+
+      context 'with :style option' do
+        it 'accepts string for CSS based selectors' do
+          expect(string.find(:custom_css_selector, 'input', style: 'line-height: 30px;')[:title]).to eq 'Other button 1'
+        end
+
+        it 'accepts Regexp for CSS base selectors' do
+          expect(string.find(:custom_css_selector, 'input', style: /30px/)[:title]).to eq 'Other button 1'
+        end
+      end
+
+      # :css, :xpath, :id, :field, :fieldset, :link, :button, :link_or_button, :fillable_field, :radio_button, :checkbox, :select,
+      # :option, :file_field, :label, :table, :frame
+
+      describe ':css selector' do
+        it 'finds by CSS locator' do
+          expect(string.find(:css, 'input#my_text_input')[:name]).to eq 'form[my_text_input]'
+        end
+      end
+
+      describe ':xpath selector' do
+        it 'finds by XPath locator' do
+          expect(string.find(:xpath, './/input[@id="my_text_input"]')[:name]).to eq 'form[my_text_input]'
+        end
+      end
+
+      describe ':id selector' do
+        it 'finds by locator' do
+          expect(string.find(:id, 'my_text_input')[:name]).to eq 'form[my_text_input]'
+          expect(string.find(:id, /my_text_input/)[:name]).to eq 'form[my_text_input]'
+          expect(string.find(:id, /_text_/)[:name]).to eq 'form[my_text_input]'
+          expect(string.find(:id, /i[nmo]/)[:name]).to eq 'form[my_text_input]'
+        end
+      end
+
+      describe ':field selector' do
+        it 'finds by locator' do
+          expect(string.find(:field, 'My Text Input')[:id]).to eq 'my_text_input'
+          expect(string.find(:field, 'my_text_input')[:id]).to eq 'my_text_input'
+          expect(string.find(:field, 'form[my_text_input]')[:id]).to eq 'my_text_input'
+        end
+
+        it 'finds by id string' do
+          expect(string.find(:field, id: 'my_text_input')[:name]).to eq 'form[my_text_input]'
+        end
+
+        it 'finds by id regexp' do
+          expect(string.find(:field, id: /my_text_inp/)[:name]).to eq 'form[my_text_input]'
+        end
+
+        it 'finds by name' do
+          expect(string.find(:field, name: 'form[my_text_input]')[:id]).to eq 'my_text_input'
+        end
+
+        it 'finds by placeholder' do
+          expect(string.find(:field, placeholder: 'my text')[:id]).to eq 'my_text_input'
+        end
+
+        it 'finds by type' do
+          expect(string.find(:field, type: 'file')[:id]).to eq 'file'
+          expect(string.find(:field, type: 'select')[:id]).to eq 'select'
+        end
+      end
+
+      describe ':option selector' do
+        it 'finds disabled options' do
           expect(string.find(:option, disabled: true).value).to eq 'b'
         end
 
-        it "finds selected options" do
+        it 'finds selected options' do
           expect(string.find(:option, selected: true).value).to eq 'c'
         end
 
-        it "finds not selected and not disabled options" do
+        it 'finds not selected and not disabled options' do
           expect(string.find(:option, disabled: false, selected: false).value).to eq 'a'
         end
       end
+
+      describe ':button selector' do
+        it 'finds by value' do
+          expect(string.find(:button, 'click me').value).to eq 'click me'
+        end
+
+        it 'finds by title' do
+          expect(string.find(:button, 'submit button').value).to eq 'click me'
+        end
+
+        it 'includes non-matching parameters in failure message' do
+          expect { string.find(:button, 'click me', title: 'click me') }.to raise_error(/with title click me/)
+        end
+      end
+
+      describe ':element selector' do
+        it 'finds by any attributes' do
+          expect(string.find(:element, 'input', type: 'submit').value).to eq 'click me'
+        end
+
+        it 'supports regexp matching' do
+          expect(string.find(:element, 'input', type: /sub/).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /sub\w.*button/).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /sub.* b.*ton/).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /sub.*mit.*/).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /^submit button$/).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /^(?:submit|other) button$/).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /SuB.*mIt/i).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /^Su.*Bm.*It/i).value).to eq 'click me'
+          expect(string.find(:element, 'input', title: /^Ot.*he.*r b.*\d/i).value).to eq "don't click me"
+        end
+
+        it 'still works with system keys' do
+          expect { string.all(:element, 'input', type: 'submit', count: 1) }.not_to raise_error
+        end
+
+        it 'works without element type' do
+          expect(string.find(:element, type: 'submit').value).to eq 'click me'
+        end
+
+        it 'validates attribute presence when true' do
+          expect(string.find(:element, name: true)[:id]).to eq 'my_text_input'
+        end
+
+        it 'validates attribute absence when false' do
+          expect(string.find(:element, 'option', disabled: false, selected: false).value).to eq 'a'
+        end
+
+        it 'includes wildcarded keys in description' do
+          expect { string.find(:element, 'input', not_there: 'bad', presence: true, absence: false, count: 1) }
+            .to(raise_error do |e|
+              expect(e).to be_a(Capybara::ElementNotFound)
+              expect(e.message).to include 'not_there => bad'
+              expect(e.message).to include 'with presence attribute'
+              expect(e.message).to include 'without absence attribute'
+              expect(e.message).not_to include 'count 1'
+            end)
+        end
+
+        it 'accepts XPath::Expression' do
+          expect(string.find(:element, 'input', type: XPath.starts_with('subm')).value).to eq 'click me'
+          expect(string.find(:element, 'input', type: XPath.ends_with('ext'))[:type]).to eq 'text'
+          expect(string.find(:element, 'input', type: XPath.contains('ckb'))[:type]).to eq 'checkbox'
+          expect(string.find(:element, 'input', title: XPath.contains_word('submit'))[:type]).to eq 'submit'
+          expect(string.find(:element, 'input', title: XPath.contains_word('button 1'))[:type]).to eq 'button'
+        end
+      end
+
+      describe ':link_or_button selector' do
+        around do |example|
+          described_class.modify_selector(:link_or_button) do
+            expression_filter(:random) { |xpath, _| xpath } # do nothing filter
+          end
+          example.run
+          Capybara::Selector[:link_or_button].expression_filters.delete(:random)
+        end
+
+        it 'should not find links when disabled == true' do
+          expect(string.all(:link_or_button, disabled: true).size).to eq 0
+        end
+
+        context 'when modified' do
+          it 'should still work' do
+            filter = Capybara::Selector[:link_or_button].expression_filters[:random]
+            allow(filter).to receive(:apply_filter).and_call_original
+
+            expect(string.find(:link_or_button, 'click me', random: 'blah').value).to eq 'click me'
+            expect(filter).to have_received(:apply_filter).with(anything, :random, 'blah', anything)
+          end
+        end
+      end
+
+      describe ':table selector' do
+        it 'finds by rows' do
+          expect(string.find(:table, with_rows: [%w[D E F]])[:id]).to eq 'rows'
+        end
+
+        it 'finds by columns' do
+          expect(string.find(:table, with_cols: [%w[A B C]])[:id]).to eq 'cols'
+        end
+      end
     end
   end
 end