capybara 2.7.0 → 3.35.3

data/lib/capybara/spec/session/visit_spec.rb

@@ -1,13 +1,14 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#visit' do
-  it "should fetch a response from the driver with a relative url" do
+  it 'should fetch a response from the driver with a relative url' do
     @session.visit('/')
     expect(@session).to have_content('Hello world!')
     @session.visit('/foo')
     expect(@session).to have_content('Another World')
   end
 
-  it "should fetch a response from the driver with an absolute url with a port" do
+  it 'should fetch a response from the driver with an absolute url with a port' do
     # Preparation
     @session.visit('/')
     root_uri = URI.parse(@session.current_url)
@@ -27,34 +28,40 @@ Capybara::SpecHelper.spec '#visit' do
     expect(@session).to have_content('Hello world!')
   end
 
-  it "raises any errors caught inside the server", :requires => [:server] do
-    quietly { @session.visit("/error") }
+  it 'should fetch a response when sequentially visiting same destination with a target' do
+    @session.visit('/form')
+    expect(@session).to have_css('#form_title')
+    @session.visit('/form#form_title')
+    expect(@session).to have_css('#form_title')
+  end
+
+  it 'raises any errors caught inside the server', requires: [:server] do
+    quietly { @session.visit('/error') }
     expect do
-      @session.visit("/")
+      @session.visit('/')
     end.to raise_error(TestApp::TestAppError)
   end
 
-  it "should be able to open non-http url", requires: [:about_scheme] do
-    @session.visit("about:blank")
-    @session.assert_no_selector :xpath, "/html/body/*"
+  it 'should be able to open non-http url', requires: [:about_scheme] do
+    @session.visit('about:blank')
+    @session.assert_no_selector :xpath, '/html/body/*'
   end
 
-  context "when Capybara.always_include_port is true" do
-
+  context 'when Capybara.always_include_port is true' do
     let(:root_uri) do
       @session.visit('/')
       URI.parse(@session.current_url)
     end
 
-    before(:each) do
+    before do
       Capybara.always_include_port = true
     end
 
-    after(:each) do
+    after do
       Capybara.always_include_port = false
     end
 
-    it "should fetch a response from the driver with an absolute url without a port" do
+    it 'should fetch a response from the driver with an absolute url without a port' do
       @session.visit("http://#{root_uri.host}/")
       expect(URI.parse(@session.current_url).port).to eq(root_uri.port)
       expect(@session).to have_content('Hello world!')
@@ -63,75 +70,135 @@ Capybara::SpecHelper.spec '#visit' do
       expect(URI.parse(@session.current_url).port).to eq(root_uri.port)
       expect(@session).to have_content('Another World')
     end
+
+    it 'should add the server port to a visited url if no port specified', requires: [:server] do
+      allow(@session.driver).to receive(:visit)
+      @session.visit('http://www.example.com')
+      expect(@session.driver).to have_received(:visit).with("http://www.example.com:#{@session.server.port}")
+    end
+
+    it 'should not override the visit specified port even if default for scheme', requires: [:server] do
+      allow(@session.driver).to receive(:visit)
+      @session.visit('http://www.example.com:80')
+      expect(@session.driver).to have_received(:visit).with('http://www.example.com:80')
+    end
+
+    it 'should give preference to app_host port if specified', requires: [:server] do
+      allow(@session.driver).to receive(:visit)
+      Capybara.app_host = 'http://www.example.com:6666'
+      @session.visit('/random')
+      expect(@session.driver).to have_received(:visit).with('http://www.example.com:6666/random')
+    end
+
+    it "shouldn't override port if no server", requires: [:server] do
+      session = Capybara::Session.new(@session.mode, nil)
+      allow(session.driver).to receive(:visit)
+      session.visit('http://www.google.com')
+      expect(session.driver).to have_received(:visit).with('http://www.google.com')
+    end
+
+    it "shouldn't override port if no server but app_host is set", requires: [:server] do
+      session = Capybara::Session.new(@session.mode, nil)
+      Capybara.app_host = 'http://www.example.com:6666'
+      allow(session.driver).to receive(:visit)
+      session.visit('http://www.google.com')
+      expect(session.driver).to have_received(:visit).with('http://www.google.com')
+    end
   end
 
-  context "without a server", :requires => [:server] do
-    it "should respect `app_host`" do
+  context 'when Capybara.always_include_port is false' do
+    before do
+      Capybara.always_include_port = false
+    end
+
+    it "shouldn't overwrite port if app_host is set", requires: [:server] do
+      session = Capybara::Session.new(@session.mode, nil)
+      Capybara.app_host = 'http://www.example.com:6666'
+      allow(session.driver).to receive(:visit)
+      session.visit('http://www.google.com')
+      expect(session.driver).to have_received(:visit).with('http://www.google.com')
+    end
+
+    it "shouldn't overwrite port if port specfified", requires: [:server] do
+      session = Capybara::Session.new(@session.mode, nil)
+      Capybara.app_host = 'http://www.example.com:6666'
+      allow(session.driver).to receive(:visit)
+      session.visit('http://www.google.com:99')
+      expect(session.driver).to have_received(:visit).with('http://www.google.com:99')
+    end
+  end
+
+  context 'without a server', requires: [:server] do
+    it 'should respect `app_host`' do
       serverless_session = Capybara::Session.new(@session.mode, nil)
       Capybara.app_host = "http://#{@session.server.host}:#{@session.server.port}"
-      serverless_session.visit("/foo")
-      expect(serverless_session).to have_content("Another World")
+      serverless_session.visit('/foo')
+      expect(serverless_session).to have_content('Another World')
     end
 
-    it "should visit a fully qualified URL" do
+    it 'should visit a fully qualified URL' do
       serverless_session = Capybara::Session.new(@session.mode, nil)
       serverless_session.visit("http://#{@session.server.host}:#{@session.server.port}/foo")
-      expect(serverless_session).to have_content("Another World")
+      expect(serverless_session).to have_content('Another World')
     end
   end
 
-  context "with Capybara.app_host set" do
-    it "should override server", requires: [:server] do
+  context 'with Capybara.app_host set' do
+    it 'should override server', requires: [:server] do
       another_session = Capybara::Session.new(@session.mode, @session.app.dup)
       Capybara.app_host = "http://#{@session.server.host}:#{@session.server.port}"
       another_session.visit('/foo')
-      expect(another_session).to have_content("Another World")
+      expect(another_session).to have_content('Another World')
       expect(another_session.current_url).to start_with(Capybara.app_host)
       expect(URI.parse(another_session.current_url).port).not_to eq another_session.server.port
       expect(URI.parse(another_session.current_url).port).to eq @session.server.port
     end
 
-    it "should append relative path", requires: [:server] do
+    it 'should append relative path', requires: [:server] do
       Capybara.app_host = "http://#{@session.server.host}:#{@session.server.port}/redirect/0"
       @session.visit('/times')
       expect(@session).to have_content('redirection complete')
     end
-  end
 
+    it 'should work if `app_host` has a trailing /', requires: [:server] do
+      Capybara.app_host = "http://#{@session.server.host}:#{@session.server.port}/"
+      @session.visit('/')
+      expect(@session).to have_content('Hello world!')
+    end
+  end
 
-  it "should send no referer when visiting a page" do
+  it 'should send no referer when visiting a page' do
     @session.visit '/get_referer'
     expect(@session).to have_content 'No referer'
   end
 
-  it "should send no referer when visiting a second page" do
+  it 'should send no referer when visiting a second page' do
     @session.visit '/get_referer'
     @session.visit '/get_referer'
     expect(@session).to have_content 'No referer'
   end
 
-  it "should send a referer when following a link" do
+  it 'should send a referer when following a link' do
     @session.visit '/referer_base'
     @session.find('//a[@href="/get_referer"]').click
     expect(@session).to have_content %r{http://.*/referer_base}
   end
 
-  it "should preserve the original referer URL when following a redirect" do
+  it 'should preserve the original referer URL when following a redirect' do
     @session.visit('/referer_base')
     @session.find('//a[@href="/redirect_to_get_referer"]').click
     expect(@session).to have_content %r{http://.*/referer_base}
   end
 
-  it "should send a referer when submitting a form" do
+  it 'should send a referer when submitting a form' do
     @session.visit '/referer_base'
     @session.find('//input').click
     expect(@session).to have_content %r{http://.*/referer_base}
   end
 
-  it "can set cookie if a blank path is specified" do
-    @session.visit("")
+  it 'can set cookie if a blank path is specified' do
+    @session.visit('')
     @session.visit('/get_cookie')
     expect(@session).to have_content('root cookie')
   end
-
 end

data/lib/capybara/spec/session/window/become_closed_spec.rb

@@ -1,84 +1,88 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec '#become_closed', requires: [:windows, :js] do
-  before(:each) do
-    @window = @session.current_window
-    @session.visit('/with_windows')
-    @other_window = @session.window_opened_by do
+
+Capybara::SpecHelper.spec '#become_closed', requires: %i[windows js] do
+  let!(:window) { @session.current_window }
+  let(:other_window) do
+    @session.window_opened_by do
       @session.find(:css, '#openWindow').click
     end
   end
 
-  after(:each) do
+  before do
+    @session.visit('/with_windows')
+  end
+
+  after do
     @session.document.synchronize(5, errors: [Capybara::CapybaraError]) do
       raise Capybara::CapybaraError if @session.windows.size != 1
     end
-    @session.switch_to_window(@window)
+    @session.switch_to_window(window)
   end
 
   context 'with :wait option' do
     it 'should wait if value of :wait is more than timeout' do
-      @session.within_window @other_window do
+      @session.within_window other_window do
         @session.execute_script('setTimeout(function(){ window.close(); }, 500);')
       end
       Capybara.using_wait_time 0.1 do
-        expect(@other_window).to become_closed(wait: 2)
+        expect(other_window).to become_closed(wait: 5)
       end
     end
 
     it 'should raise error if value of :wait is less than timeout' do
-      @session.within_window @other_window do
-        @session.execute_script('setTimeout(function(){ window.close(); }, 700);')
+      @session.within_window other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 1000);')
       end
       Capybara.using_wait_time 2 do
         expect do
-          expect(@other_window).to become_closed(wait: 0.4)
-        end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> to become closed after 0.4 seconds\Z/)
+          expect(other_window).to become_closed(wait: 0.2)
+        end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> to become closed after 0.2 seconds\Z/)
       end
     end
   end
 
   context 'without :wait option' do
     it 'should wait if value of default_max_wait_time is more than timeout' do
-      @session.within_window @other_window do
+      @session.within_window other_window do
         @session.execute_script('setTimeout(function(){ window.close(); }, 500);')
       end
-      Capybara.using_wait_time 1.5 do
-        expect(@other_window).to become_closed
+      Capybara.using_wait_time 5 do
+        expect(other_window).to become_closed
       end
     end
 
     it 'should raise error if value of default_max_wait_time is less than timeout' do
-      @session.within_window @other_window do
+      @session.within_window other_window do
         @session.execute_script('setTimeout(function(){ window.close(); }, 900);')
       end
       Capybara.using_wait_time 0.4 do
         expect do
-          expect(@other_window).to become_closed
+          expect(other_window).to become_closed
         end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> to become closed after 0.4 seconds\Z/)
       end
     end
   end
 
   context 'with not_to' do
-    it 'should raise error if default_max_wait_time is more than timeout' do
-      @session.within_window @other_window do
-        @session.execute_script('setTimeout(function(){ window.close(); }, 700);')
+    it "should not raise error if window doesn't close before default_max_wait_time" do
+      @session.within_window other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 1000);')
       end
-      Capybara.using_wait_time 0.4 do
+      Capybara.using_wait_time 0.3 do
         expect do
-          expect(@other_window).not_to become_closed
-        end
+          expect(other_window).not_to become_closed
+        end.not_to raise_error
       end
     end
 
-    it 'should raise error if default_max_wait_time is more than timeout' do
-      @session.within_window @other_window do
+    it 'should raise error if window closes before default_max_wait_time' do
+      @session.within_window other_window do
         @session.execute_script('setTimeout(function(){ window.close(); }, 700);')
       end
-      Capybara.using_wait_time 1.1 do
+      Capybara.using_wait_time 3.1 do
         expect do
-          expect(@other_window).not_to become_closed
-        end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> not to become closed after 1.1 seconds\Z/)
+          expect(other_window).not_to become_closed
+        end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> not to become closed after 3.1 seconds\Z/)
       end
     end
   end

data/lib/capybara/spec/session/window/current_window_spec.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#current_window', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
   end
-  after(:each) do
+
+  after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
       w.close
@@ -16,7 +18,7 @@ Capybara::SpecHelper.spec '#current_window', requires: [:windows] do
     expect(@session.current_window).to be_instance_of(Capybara::Window)
   end
 
-  it "should be modified by switching to another window" do
+  it 'should be modified by switching to another window' do
     window = @session.window_opened_by { @session.find(:css, '#openWindow').click }
 
     expect do

data/lib/capybara/spec/session/window/open_new_window_spec.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#open_new_window', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
   end
-  after(:each) do
+
+  after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
       w.close
@@ -15,7 +17,7 @@ Capybara::SpecHelper.spec '#open_new_window', requires: [:windows] do
   it 'should open new window with blank url and title' do
     window = @session.open_new_window
     @session.switch_to_window(window)
-    expect(['', 'about:blank']).to include(@session.title)
+    expect(@session.title).to satisfy('be a blank title') { |title| ['', 'about:blank'].include? title }
     expect(@session.current_url).to eq('about:blank')
   end
 

data/lib/capybara/spec/session/window/switch_to_window_spec.rb

@@ -1,10 +1,17 @@
 # frozen_string_literal: true
+
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
+    @session.assert_selector(:css, 'body.loaded')
   end
-  after(:each) do
+
+  after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
       w.close
@@ -12,27 +19,27 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
     @session.switch_to_window(@window)
   end
 
-  it "should raise error when invoked without args" do
+  it 'should raise error when invoked without args' do
     expect do
       @session.switch_to_window
-    end.to raise_error(ArgumentError, "`switch_to_window`: either window or block should be provided")
+    end.to raise_error(ArgumentError, '`switch_to_window`: either window or block should be provided')
   end
 
-  it "should raise error when invoked with window and block" do
+  it 'should raise error when invoked with window and block' do
     expect do
       @session.switch_to_window(@window) { @session.title == 'Title of the first popup' }
-    end.to raise_error(ArgumentError, "`switch_to_window` can take either a block or a window, not both")
+    end.to raise_error(ArgumentError, '`switch_to_window` can take either a block or a window, not both')
   end
 
-  context "with an instance of Capybara::Window" do
-    it "should be able to switch to window" do
+  context 'with an instance of Capybara::Window' do
+    it 'should be able to switch to window' do
       window = @session.open_new_window
       expect(@session.title).to eq('With Windows')
       @session.switch_to_window(window)
-      expect(['', 'about:blank']).to include(@session.title)
+      expect(@session.title).to satisfy('be a blank title') { |title| ['', 'about:blank'].include? title }
     end
 
-    it "should raise error when closed window is passed" do
+    it 'should raise error when closed window is passed' do
       original_window = @session.current_window
       new_window = @session.open_new_window
       @session.switch_to_window(new_window)
@@ -44,30 +51,30 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
     end
   end
 
-  context "with block" do
-    before(:each) do
+  context 'with block' do
+    before do
       @session.find(:css, '#openTwoWindows').click
-      sleep(0.2) # wait for the windows to open
+      sleep(1) # wait for the windows to open
     end
 
-    it "should be able to switch to current window" do
+    it 'should be able to switch to current window' do
       @session.switch_to_window { @session.title == 'With Windows' }
       expect(@session).to have_css('#openTwoWindows')
     end
 
-    it "should find the div in another window" do
+    it 'should find the div in another window' do
       @session.switch_to_window { @session.title == 'Title of popup two' }
       expect(@session).to have_css('#divInPopupTwo')
     end
 
-    it "should be able to switch multiple times" do
+    it 'should be able to switch multiple times' do
       @session.switch_to_window { @session.title == 'Title of the first popup' }
       expect(@session).to have_css('#divInPopupOne')
       @session.switch_to_window { @session.title == 'Title of popup two' }
       expect(@session).to have_css('#divInPopupTwo')
     end
 
-    it "should return window" do
+    it 'should return window' do
       window = @session.switch_to_window { @session.title == 'Title of popup two' }
       expect((@session.windows - [@window])).to include(window)
     end
@@ -77,7 +84,7 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
         @session.within(:css, '#doesNotOpenWindows') do
           @session.switch_to_window { @session.title == 'With Windows' }
         end
-      end.to raise_error(Capybara::ScopeError, "`switch_to_window` is not supposed to be invoked from `within`'s, `within_frame`'s' or `within_window`'s' block.")
+      end.to raise_error(Capybara::ScopeError, /`switch_to_window` is not supposed to be invoked/)
     end
 
     it "should raise error when invoked inside `within_frame` as it's nonsense" do
@@ -85,27 +92,29 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
         @session.within_frame('frameOne') do
           @session.switch_to_window { @session.title == 'With Windows' }
         end
-      end.to raise_error(Capybara::ScopeError, "`switch_to_window` is not supposed to be invoked from `within`'s, `within_frame`'s' or `within_window`'s' block.")
+      end.to raise_error(Capybara::ScopeError, /`switch_to_window` is not supposed to be invoked from/)
     end
 
-    it "should raise error when invoked inside `within_window` as it's nonsense" do
-      window = (@session.windows - [@window]).first
-      expect do
-        @session.within_window window do
-          @session.switch_to_window { @session.title == 'With Windows' }
-        end
-      end.to raise_error(Capybara::ScopeError, "`switch_to_window` is not supposed to be invoked from `within`'s, `within_frame`'s' or `within_window`'s' block.")
+    it 'should allow to be called inside within_window and within_window will still return to original' do
+      other_windows = (@session.windows - [@window])
+      expect(@session.current_window).to eq(@window)
+      @session.within_window other_windows[0] do
+        expect(@session.current_window).to eq(other_windows[0])
+        @session.switch_to_window other_windows[1]
+        expect(@session.current_window).to eq(other_windows[1])
+      end
+      expect(@session.current_window).to eq(@window)
     end
 
     it "should raise error if window matching block wasn't found" do
       original = @session.current_window
       expect do
         @session.switch_to_window { @session.title == 'A title' }
-      end.to raise_error(Capybara::WindowError, "Could not find a window matching block/lambda")
+      end.to raise_error(Capybara::WindowError, 'Could not find a window matching block/lambda')
       expect(@session.current_window).to eq(original)
     end
 
-    it "should switch to original window if error is raised inside block" do
+    it 'should switch to original window if error is raised inside block' do
       original = @session.switch_to_window(@session.windows[1])
       expect do
         @session.switch_to_window { raise 'error' }
@@ -114,10 +123,10 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
     end
   end
 
-  it "should wait for window to appear" do
+  it 'should wait for window to appear' do
     @session.find(:css, '#openWindowWithTimeout').click
     expect do
-      @session.switch_to_window { @session.title == 'Title of the first popup'}
+      @session.switch_to_window(wait: 5) { @session.title == 'Title of the first popup' }
     end.not_to raise_error
   end
 end