capybara 2.7.0 → 3.35.3

data/lib/capybara/spec/session/current_scope_spec.rb

@@ -1,25 +1,26 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#current_scope' do
   before do
     @session.visit('/with_scope')
   end
-  
-  context "when not in a #within block" do
-    it "should return the document" do
+
+  context 'when not in a #within block' do
+    it 'should return the document' do
       expect(@session.current_scope).to be_kind_of Capybara::Node::Document
     end
   end
-  
-  context "when in a #within block" do
-    it "should return the element in scope" do
-      @session.within(:css, "#simple_first_name") do
+
+  context 'when in a #within block' do
+    it 'should return the element in scope' do
+      @session.within(:css, '#simple_first_name') do
         expect(@session.current_scope[:name]).to eq 'first_name'
       end
     end
   end
-  
-  context "when in a nested #within block" do
-    it "should return the element in scope" do
+
+  context 'when in a nested #within block' do
+    it 'should return the element in scope' do
       @session.within("//div[@id='for_bar']") do
         @session.within(".//input[@value='Peter']") do
           expect(@session.current_scope[:name]).to eq 'form[first_name]'

data/lib/capybara/spec/session/current_url_spec.rb

@@ -1,43 +1,42 @@
 # frozen_string_literal: true
-require "capybara/spec/test_app"
+
+require 'capybara/spec/test_app'
 
 Capybara::SpecHelper.spec '#current_url, #current_path, #current_host' do
-  before :all do
-    @servers = 2.times.map { Capybara::Server.new(TestApp.clone).boot }
+  before :all do # rubocop:disable RSpec/BeforeAfterAll
+    @servers = Array.new(2) { Capybara::Server.new(TestApp.new).boot }
     # sanity check
-    expect(@servers[0].port).not_to eq(@servers[1].port)
-    expect(@servers.map { |s| s.port }).not_to include 80
+    expect(@servers[0].port).not_to eq(@servers[1].port) # rubocop:disable RSpec/ExpectInHook
+    expect(@servers.map(&:port)).not_to include 80 # rubocop:disable RSpec/ExpectInHook
   end
 
   def bases
     @servers.map { |s| "http://#{s.host}:#{s.port}" }
   end
 
-  def should_be_on server_index, path="/host", scheme="http"
-    #This delay is to give fully async drivers (selenium w/chromedriver) time for the browser
-    #to get to its destination - should be removed when we have a waiting current_url matcher
-    sleep 0.1  # remove and adjust tests when a waiting current_url/path matcher is implemented
+  def should_be_on(server_index, path = '/host', scheme = 'http')
     # Check that we are on /host on the given server
     s = @servers[server_index]
+
+    expect(@session).to have_current_path("#{scheme}://#{s.host}:#{s.port}#{path}", url: true)
+
     expect(@session.current_url.chomp('?')).to eq("#{scheme}://#{s.host}:#{s.port}#{path}")
     expect(@session.current_host).to eq("#{scheme}://#{s.host}") # no port
-    expect(@session.current_path).to eq(path)
-    if path == '/host'
-      # Server should agree with us
-      expect(@session).to have_content("Current host is #{scheme}://#{s.host}:#{s.port}")
-    end
+    expect(@session.current_path).to eq(path.split('#')[0])
+    # Server should agree with us
+    expect(@session).to have_content("Current host is #{scheme}://#{s.host}:#{s.port}") if path == '/host'
   end
 
   def visit_host_links
     @session.visit("#{bases[0]}/host_links?absolute_host=#{bases[1]}")
   end
 
-  it "is affected by visiting a page directly" do
+  it 'is affected by visiting a page directly' do
     @session.visit("#{bases[0]}/host")
     should_be_on 0
   end
 
-  it "returns to the app host when visiting a relative url" do
+  it 'returns to the app host when visiting a relative url' do
     Capybara.app_host = bases[1]
     @session.visit("#{bases[0]}/host")
     should_be_on 0
@@ -46,54 +45,81 @@ Capybara::SpecHelper.spec '#current_url, #current_path, #current_host' do
     Capybara.app_host = nil
   end
 
-  it "is affected by setting Capybara.app_host" do
+  it 'is affected by setting Capybara.app_host' do
     Capybara.app_host = bases[0]
-    @session.visit("/host")
+    @session.visit('/host')
     should_be_on 0
     Capybara.app_host = bases[1]
-    @session.visit("/host")
+    @session.visit('/host')
     should_be_on 1
     Capybara.app_host = nil
   end
 
-  it "is unaffected by following a relative link" do
+  it 'is unaffected by following a relative link' do
     visit_host_links
-    @session.click_link("Relative Host")
+    @session.click_link('Relative Host')
     should_be_on 0
   end
 
-  it "is affected by following an absolute link" do
+  it 'is affected by following an absolute link' do
     visit_host_links
-    @session.click_link("Absolute Host")
+    @session.click_link('Absolute Host')
     should_be_on 1
   end
 
-  it "is unaffected by posting through a relative form" do
+  it 'is unaffected by posting through a relative form' do
     visit_host_links
-    @session.click_button("Relative Host")
+    @session.click_button('Relative Host')
     should_be_on 0
   end
 
-  it "is affected by posting through an absolute form" do
+  it 'is affected by posting through an absolute form' do
     visit_host_links
-    @session.click_button("Absolute Host")
+    @session.click_button('Absolute Host')
     should_be_on 1
   end
 
-  it "is affected by following a redirect" do
+  it 'is affected by following a redirect' do
     @session.visit("#{bases[0]}/redirect")
-    should_be_on 0, "/landed"
+    should_be_on 0, '/landed'
+  end
+
+  it 'maintains fragment' do
+    @session.visit("#{bases[0]}/redirect#fragment")
+    should_be_on 0, '/landed#fragment'
   end
 
-  it "is affected by pushState", :requires => [:js] do
-    @session.visit("/with_js")
+  it 'redirects to a fragment' do
+    @session.visit("#{bases[0]}/redirect_with_fragment")
+    should_be_on 0, '/landed#with_fragment'
+  end
+
+  it 'is affected by pushState', requires: [:js] do
+    @session.visit('/with_js')
     @session.execute_script("window.history.pushState({}, '', '/pushed')")
-    expect(@session.current_path).to eq("/pushed")
+    expect(@session.current_path).to eq('/pushed')
   end
 
-  it "is affected by replaceState", :requires => [:js] do
-    @session.visit("/with_js")
+  it 'is affected by replaceState', requires: [:js] do
+    @session.visit('/with_js')
     @session.execute_script("window.history.replaceState({}, '', '/replaced')")
-    expect(@session.current_path).to eq("/replaced")
+    expect(@session.current_path).to eq('/replaced')
+  end
+
+  it "doesn't raise exception on a nil current_url", requires: [:driver] do
+    allow(@session.driver).to receive(:current_url).and_return(nil)
+    @session.visit('/')
+    expect { @session.current_url }.not_to raise_exception
+    expect { @session.current_path }.not_to raise_exception
+  end
+
+  context 'within iframe', requires: [:frames] do
+    it 'should get the url of the top level browsing context' do
+      @session.visit('/within_frames')
+      expect(@session.current_url).to match(/within_frames\z/)
+      @session.within_frame('frameOne') do
+        expect(@session.current_url).to match(/within_frames\z/)
+      end
+    end
   end
 end

data/lib/capybara/spec/session/dismiss_confirm_spec.rb

@@ -1,23 +1,24 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec '#dismiss_confirm', :requires => [:modals] do
+
+Capybara::SpecHelper.spec '#dismiss_confirm', requires: [:modals] do
   before do
     @session.visit('/with_js')
   end
 
-  it "should dismiss the confirm" do
+  it 'should dismiss the confirm' do
     @session.dismiss_confirm do
       @session.click_link('Open confirm')
     end
     expect(@session).to have_xpath("//a[@id='open-confirm' and @confirmed='false']")
   end
-  
-  it "should dismiss the confirm if the message matches" do
+
+  it 'should dismiss the confirm if the message matches' do
     @session.dismiss_confirm 'Confirm opened' do
       @session.click_link('Open confirm')
     end
     expect(@session).to have_xpath("//a[@id='open-confirm' and @confirmed='false']")
   end
-  
+
   it "should not dismiss the confirm if the message doesn't match" do
     expect do
       @session.dismiss_confirm 'Incorrect Text' do
@@ -25,9 +26,8 @@ Capybara::SpecHelper.spec '#dismiss_confirm', :requires => [:modals] do
       end
     end.to raise_error(Capybara::ModalNotFound)
   end
-    
 
-  it "should return the message presented" do
+  it 'should return the message presented' do
     message = @session.dismiss_confirm do
       @session.click_link('Open confirm')
     end

data/lib/capybara/spec/session/dismiss_prompt_spec.rb

@@ -1,17 +1,18 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec '#dismiss_prompt', :requires => [:modals] do
+
+Capybara::SpecHelper.spec '#dismiss_prompt', requires: [:modals] do
   before do
     @session.visit('/with_js')
   end
 
-  it "should dismiss the prompt" do
+  it 'should dismiss the prompt' do
     @session.dismiss_prompt do
       @session.click_link('Open prompt')
     end
     expect(@session).to have_xpath("//a[@id='open-prompt' and @response='dismissed']")
   end
-  
-  it "should return the message presented" do
+
+  it 'should return the message presented' do
     message = @session.dismiss_prompt do
       @session.click_link('Open prompt')
     end

data/lib/capybara/spec/session/element/{assert_match_selector.rb → assert_match_selector_spec.rb}

@@ -1,22 +1,24 @@
+# frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#assert_matches_selector' do
   before do
     @session.visit('/with_html')
     @element = @session.find(:css, 'span', text: '42')
   end
 
-  it "should be true if the given selector matches the element" do
+  it 'should be true if the given selector matches the element' do
     expect(@element.assert_matches_selector(:css, '.number')).to be true
   end
 
-  it "should be false if the given selector does not match the element" do
+  it 'should be false if the given selector does not match the element' do
     expect { @element.assert_matches_selector(:css, '.not_number') }.to raise_error(Capybara::ElementNotFound)
   end
 
-  it "should not be callable on the session" do
+  it 'should not be callable on the session' do
     expect { @session.assert_matches_selector(:css, '.number') }.to raise_error(NoMethodError)
   end
 
-  it "should wait for match to occur", requires: [:js] do
+  it 'should wait for match to occur', requires: [:js] do
     @session.visit('/with_js')
     input = @session.find(:css, '#disable-on-click')
 
@@ -25,7 +27,12 @@ Capybara::SpecHelper.spec '#assert_matches_selector' do
     expect(input.assert_matches_selector(:css, 'input:disabled')).to be true
   end
 
-  it "should not accept count options" do
-    expect { @element.assert_matches_selector(:css, '.number', count: 1) }.to raise_error(ArgumentError)
+  it 'should not accept count options' do
+    expect { @element.assert_matches_selector(:css, '.number', count: 1) }.to raise_error(ArgumentError, /count/)
+  end
+
+  it 'should accept a filter block' do
+    @element.assert_matches_selector(:css, 'span') { |el| el[:class] == 'number' }
+    @element.assert_not_matches_selector(:css, 'span') { |el| el[:class] == 'not_number' }
   end
 end

data/lib/capybara/spec/session/element/match_css_spec.rb

@@ -1,17 +1,31 @@
+# frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#match_css?' do
   before do
     @session.visit('/with_html')
     @element = @session.find(:css, 'span', text: '42')
   end
 
-  it "should be true if the given selector matches the element" do
-    expect(@element).to match_css("span")
-    expect(@element).to match_css("span.number")
+  it 'should be true if the given selector matches the element' do
+    expect(@element).to match_css('span')
+    expect(@element).to match_css('span.number')
+  end
+
+  it 'should be false if the given selector does not match' do
+    expect(@element).not_to match_css('div')
+    expect(@element).not_to match_css('p a#doesnotexist')
+    expect(@element).not_to match_css('p.nosuchclass')
+  end
+
+  it 'should accept an optional filter block' do
+    # This would be better done with
+    expect(@element).to match_css('span') { |el| el[:class] == 'number' }
+    expect(@element).not_to match_css('span') { |el| el[:class] == 'not_number' }
   end
 
-  it "should be false if the given selector does not match" do
-    expect(@element).not_to match_css("div")
-    expect(@element).not_to match_css("p a#doesnotexist")
-    expect(@element).not_to match_css("p.nosuchclass")
+  it 'should work with root element found via ancestor' do
+    el = @session.find(:css, 'body').find(:xpath, '..')
+    expect(el).to match_css('html')
+    expect { expect(el).to not_match_css('html') }.to raise_exception(RSpec::Expectations::ExpectationNotMetError)
   end
 end

data/lib/capybara/spec/session/element/match_xpath_spec.rb

@@ -1,23 +1,25 @@
+# frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#match_xpath?' do
   before do
     @session.visit('/with_html')
     @element = @session.find(:css, 'span.number')
   end
 
-  it "should be true if the given selector is on the page" do
-    expect(@element).to match_xpath("//span")
+  it 'should be true if the given selector is on the page' do
+    expect(@element).to match_xpath('//span')
     expect(@element).to match_xpath("//span[@class='number']")
   end
 
-  it "should be false if the given selector is not on the page" do
-    expect(@element).not_to match_xpath("//abbr")
-    expect(@element).not_to match_xpath("//div")
+  it 'should be false if the given selector is not on the page' do
+    expect(@element).not_to match_xpath('//abbr')
+    expect(@element).not_to match_xpath('//div')
     expect(@element).not_to match_xpath("//span[@class='not_a_number']")
   end
 
-  it "should use xpath even if default selector is CSS" do
+  it 'should use xpath even if default selector is CSS' do
     Capybara.default_selector = :css
     expect(@element).not_to have_xpath("//span[@class='not_a_number']")
     expect(@element).not_to have_xpath("//div[@class='number']")
   end
-end
+end

data/lib/capybara/spec/session/element/matches_selector_spec.rb

@@ -1,63 +1,120 @@
-Capybara::SpecHelper.spec '#match_xpath?' do
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#match_selector?' do
+  let(:element) { @session.find(:xpath, '//span', text: '42') }
+
   before do
     @session.visit('/with_html')
-    @element = @session.find('//span', text: '42')
   end
 
-  it "should be true if the element matches the given selector" do
-    expect(@element).to match_selector(:xpath, "//span")
-    expect(@element).to match_selector(:css, 'span.number')
-    expect(@element.matches_selector?(:css, 'span.number')).to be true
+  it 'should be true if the element matches the given selector' do
+    expect(element).to match_selector(:xpath, '//span')
+    expect(element).to match_selector(:css, 'span.number')
+    expect(element.matches_selector?(:css, 'span.number')).to be true
   end
 
-  it "should be false if the element does not match the given selector" do
-    expect(@element).not_to match_selector(:xpath, "//div")
-    expect(@element).not_to match_selector(:css, "span.not_a_number")
-    expect(@element.matches_selector?(:css, "span.not_a_number")).to be false
+  it 'should be false if the element does not match the given selector' do
+    expect(element).not_to match_selector(:xpath, '//div')
+    expect(element).not_to match_selector(:css, 'span.not_a_number')
+    expect(element.matches_selector?(:css, 'span.not_a_number')).to be false
   end
 
-  it "should use default selector" do
+  it 'should use default selector' do
     Capybara.default_selector = :css
-    expect(@element).not_to match_selector("span.not_a_number")
-    expect(@element).to match_selector("span.number")
+    expect(element).not_to match_selector('span.not_a_number')
+    expect(element).to match_selector('span.number')
+  end
+
+  it 'should work with elements located via a sibling selector' do
+    sibling = element.sibling(:css, 'span', text: 'Other span')
+    expect(sibling).to match_selector(:xpath, '//span')
+    expect(sibling).to match_selector(:css, 'span')
+  end
+
+  it 'should work with the html element' do
+    html = @session.find('/html')
+    expect(html).to match_selector(:css, 'html')
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is not contained" do
-      expect(@element).to match_selector("//span", :text => "42")
-      expect(@element).not_to match_selector("//span", :text => "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is not contained' do
+      expect(element).to match_selector('//span', text: '42')
+      expect(element).not_to match_selector('//span', text: 'Doesnotexist')
     end
   end
+
+  it 'should have css sugar' do
+    expect(element.matches_css?('span.number')).to be true
+    expect(element.matches_css?('span.not_a_number')).to be false
+    expect(element.matches_css?('span.number', text: '42')).to be true
+    expect(element.matches_css?('span.number', text: 'Nope')).to be false
+  end
+
+  it 'should have xpath sugar' do
+    expect(element.matches_xpath?('//span')).to be true
+    expect(element.matches_xpath?('//div')).to be false
+    expect(element.matches_xpath?('//span', text: '42')).to be true
+    expect(element.matches_xpath?('//span', text: 'Nope')).to be false
+  end
+
+  it 'should accept selector filters' do
+    @session.visit('/form')
+    cbox = @session.find(:css, '#form_pets_dog')
+    expect(cbox.matches_selector?(:checkbox, id: 'form_pets_dog', option: 'dog', name: 'form[pets][]', checked: true)).to be true
+  end
+
+  it 'should accept a custom filter block' do
+    @session.visit('/form')
+    cbox = @session.find(:css, '#form_pets_dog')
+    expect(cbox).to match_selector(:checkbox) { |node| node[:id] == 'form_pets_dog' }
+    expect(cbox).not_to match_selector(:checkbox) { |node| node[:id] != 'form_pets_dog' }
+    expect(cbox.matches_selector?(:checkbox) { |node| node[:id] == 'form_pets_dog' }).to be true
+    expect(cbox.matches_selector?(:checkbox) { |node| node[:id] != 'form_pets_dog' }).to be false
+  end
 end
 
 Capybara::SpecHelper.spec '#not_matches_selector?' do
+  let(:element) { @session.find(:css, 'span', text: 42) }
   before do
     @session.visit('/with_html')
-    @element = @session.find(:css, "span", text: 42)
   end
 
-  it "should be false if the given selector matches the element" do
-    expect(@element).not_to not_match_selector(:xpath, "//span")
-    expect(@element).not_to not_match_selector(:css, "span.number")
-    expect(@element.not_matches_selector?(:css, "span.number")).to be false
+  it 'should be false if the given selector matches the element' do
+    expect(element).not_to not_match_selector(:xpath, '//span')
+    expect(element).not_to not_match_selector(:css, 'span.number')
+    expect(element.not_matches_selector?(:css, 'span.number')).to be false
   end
 
-  it "should be true if the given selector does not match the element" do
-    expect(@element).to not_match_selector(:xpath, "//abbr")
-    expect(@element).to not_match_selector(:css, "p a#doesnotexist")
-    expect(@element.not_matches_selector?(:css, "p a#doesnotexist")).to be true
+  it 'should be true if the given selector does not match the element' do
+    expect(element).to not_match_selector(:xpath, '//abbr')
+    expect(element).to not_match_selector(:css, 'p a#doesnotexist')
+    expect(element.not_matches_selector?(:css, 'p a#doesnotexist')).to be true
   end
 
-  it "should use default selector" do
+  it 'should use default selector' do
     Capybara.default_selector = :css
-    expect(@element).to not_match_selector("p a#doesnotexist")
-    expect(@element).not_to not_match_selector("span.number")
+    expect(element).to not_match_selector('p a#doesnotexist')
+    expect(element).not_to not_match_selector('span.number')
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is contained" do
-      expect(@element).not_to not_match_selector(:css, "span.number", :text => "42")
-      expect(@element).to not_match_selector(:css, "span.number", :text => "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is contained' do
+      expect(element).not_to not_match_selector(:css, 'span.number', text: '42')
+      expect(element).to not_match_selector(:css, 'span.number', text: 'Doesnotexist')
     end
   end
-end if Gem::Version.new(RSpec::Expectations::Version::STRING) >= Gem::Version.new('3.1')
+
+  it 'should have CSS sugar' do
+    expect(element.not_matches_css?('span.number')).to be false
+    expect(element.not_matches_css?('p a#doesnotexist')).to be true
+    expect(element.not_matches_css?('span.number', text: '42')).to be false
+    expect(element.not_matches_css?('span.number', text: 'Doesnotexist')).to be true
+  end
+
+  it 'should have xpath sugar' do
+    expect(element.not_matches_xpath?('//span')).to be false
+    expect(element.not_matches_xpath?('//div')).to be true
+    expect(element.not_matches_xpath?('//span', text: '42')).to be false
+    expect(element.not_matches_xpath?('//span', text: 'Doesnotexist')).to be true
+  end
+end