capybara 2.7.0 → 3.35.3

data/lib/capybara/spec/session/window/window_opened_by_spec.rb

@@ -1,10 +1,17 @@
 # frozen_string_literal: true
+
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
+    @session.assert_selector(:css, 'body.loaded')
   end
-  after(:each) do
+
+  after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
       w.close
@@ -12,21 +19,21 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
     @session.switch_to_window(@window)
   end
 
-  let(:zero_windows_message) { "block passed to #window_opened_by opened 0 windows instead of 1" }
-  let(:two_windows_message) { "block passed to #window_opened_by opened 2 windows instead of 1" }
+  let(:zero_windows_message) { 'block passed to #window_opened_by opened 0 windows instead of 1' }
+  let(:two_windows_message) { 'block passed to #window_opened_by opened 2 windows instead of 1' }
 
   context 'with :wait option' do
     it 'should raise error if value of :wait is less than timeout' do
       # So large value is used as `driver.window_handles` takes up to 800 ms on Travis
       Capybara.using_wait_time 2 do
-        button=@session.find(:css, '#openWindowWithLongerTimeout')
+        button = @session.find(:css, '#openWindowWithLongerTimeout')
         expect do
-          @session.window_opened_by(wait: 0.8) do
+          @session.window_opened_by(wait: 0.3) do
             button.click
           end
         end.to raise_error(Capybara::WindowError, zero_windows_message)
       end
-      @session.document.synchronize(2, errors: [Capybara::CapybaraError]) do
+      @session.document.synchronize(5, errors: [Capybara::CapybaraError]) do
         raise Capybara::CapybaraError if @session.windows.size != 2
       end
     end
@@ -45,7 +52,7 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
   context 'without :wait option' do
     it 'should raise error if default_max_wait_time is less than timeout' do
       button = @session.find(:css, '#openWindowWithTimeout')
-      Capybara.using_wait_time 0.4 do
+      Capybara.using_wait_time 0.1 do
         expect do
           @session.window_opened_by do
             button.click
@@ -59,7 +66,7 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
 
     it 'should find window if default_max_wait_time is more than timeout' do
       button = @session.find(:css, '#openWindowWithTimeout')
-      Capybara.using_wait_time 1.5 do
+      Capybara.using_wait_time 5 do
         window = @session.window_opened_by do
           button.click
         end
@@ -73,7 +80,7 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
     expect do
       @session.window_opened_by do
         button.click
-        sleep 0.1 # It's possible for window_opened_by to be fullfilled before the second window opens
+        sleep 1 # It's possible for window_opened_by to be fullfilled before the second window opens
       end
     end.to raise_error(Capybara::WindowError, two_windows_message)
     @session.document.synchronize(2, errors: [Capybara::CapybaraError]) do

data/lib/capybara/spec/session/window/window_spec.rb

@@ -1,155 +1,203 @@
 # frozen_string_literal: true
+
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
-  before(:each) do
-    @window = @session.current_window
+  let!(:orig_window) { @session.current_window }
+  before do
     @session.visit('/with_windows')
   end
-  after(:each) do
-    (@session.windows - [@window]).each do |w|
+
+  after do
+    (@session.windows - [orig_window]).each do |w|
       @session.switch_to_window w
       w.close
     end
-    @session.switch_to_window(@window)
+    @session.switch_to_window(orig_window)
   end
 
   describe '#exists?' do
-    before(:each) do
-      @other_window = @session.window_opened_by do
+    it 'should become false after window was closed' do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-    end
 
-    it "should become false after window was closed" do
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.exists? }.from(true).to(false)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change(other_window, :exists?).from(true).to(false)
     end
   end
 
   describe '#closed?' do
-    it "should become true after window was closed" do
-      @other_window = @session.window_opened_by do
+    it 'should become true after window was closed' do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
       expect do
-        @session.switch_to_window @other_window
-        @other_window.close
-      end.to change { @other_window.closed? }.from(false).to(true)
+        @session.switch_to_window other_window
+        other_window.close
+      end.to change { other_window.closed? }.from(false).to(true)
     end
   end
 
   describe '#current?' do
-    before(:each) do
-      @other_window = @session.window_opened_by do
+    let(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should become true after switching to window' do
       expect do
-        @session.switch_to_window(@other_window)
-      end.to change { @other_window.current? }.from(false).to(true)
+        @session.switch_to_window(other_window)
+      end.to change(other_window, :current?).from(false).to(true)
     end
 
     it 'should return false if window is closed' do
-      @session.switch_to_window(@other_window)
-      @other_window.close
-      expect(@other_window.current?).to eq(false)
+      @session.switch_to_window(other_window)
+      other_window.close
+      expect(other_window.current?).to eq(false)
     end
   end
 
   describe '#close' do
-    before(:each) do
-      @other_window = @session.window_opened_by do
+    let!(:other_window) do
+      @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
     end
 
     it 'should switch to original window if invoked not for current window' do
       expect(@session.windows.size).to eq(2)
-      expect(@session.current_window).to eq(@window)
-      @other_window.close
+      expect(@session.current_window).to eq(orig_window)
+      other_window.close
       expect(@session.windows.size).to eq(1)
-      expect(@session.current_window).to eq(@window)
+      expect(@session.current_window).to eq(orig_window)
     end
 
     it 'should make subsequent invocations of other methods raise no_such_window_error if invoked for current window' do
-      @session.switch_to_window(@other_window)
-      expect(@session.current_window).to eq(@other_window)
-      @other_window.close
+      @session.switch_to_window(other_window)
+      expect(@session.current_window).to eq(other_window)
+      other_window.close
       expect do
         @session.find(:css, '#some_id')
       end.to raise_error(@session.driver.no_such_window_error)
-      @session.switch_to_window(@window)
+      @session.switch_to_window(orig_window)
     end
   end
 
   describe '#size' do
-    it 'should return size of whole window', requires: [:windows, :js] do
-      expect(@session.current_window.size).to eq @session.evaluate_script("[window.outerWidth, window.outerHeight];")
+    def win_size
+      @session.evaluate_script('[window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]')
+    end
+
+    it 'should return size of whole window', requires: %i[windows js] do
+      expect(@session.current_window.size).to eq win_size
     end
 
     it 'should switch to original window if invoked not for current window' do
-      @other_window = @session.window_opened_by do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      size =
-        @session.within_window @other_window do
-          @session.evaluate_script("[window.outerWidth, window.outerHeight];")
-        end
-      expect(@other_window.size).to eq(size)
-      expect(@session.current_window).to eq(@window)
+      sleep 1
+      size = @session.within_window(other_window) do
+        win_size
+      end
+      expect(other_window.size).to eq(size)
+      expect(@session.current_window).to eq(orig_window)
     end
   end
 
   describe '#resize_to' do
-    it 'should be able to resize window', requires: [:windows, :js] do
+    let!(:initial_size) { @session.current_window.size }
 
-      width, height = @session.evaluate_script("[window.outerWidth, window.outerHeight];")
-      @session.current_window.resize_to(width-10, height-10)
-      expect(@session.evaluate_script("[window.outerWidth, window.outerHeight];")).to eq([width-10, height-10])
+    after do
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
     end
 
-    it 'should stay on current window if invoked not for current window', requires: [:windows, :js] do
+    it 'should be able to resize window', requires: %i[windows js] do
+      width, height = initial_size
+      @session.current_window.resize_to(width - 100, height - 100)
+      sleep 1
+      expect(@session.current_window.size).to eq([width - 100, height - 100])
+    end
 
-      @other_window = @session.window_opened_by do
+    it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      @other_window.resize_to(400, 300)
-      expect(@session.current_window).to eq(@window)
 
-      # #size returns values larger than availWidth, availHeight with Chromedriver
-      # expect(@other_window.size).to eq([400, 300])
-      @session.within_window(@other_window) do
-        expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq([400,300])
+      other_window.resize_to(600, 400)
+      expect(@session.current_window).to eq(orig_window)
+
+      @session.within_window(other_window) do
+        expect(@session.current_window.size).to eq([600, 400])
       end
     end
   end
 
   describe '#maximize' do
-    it 'should be able to maximize window', requires: [:windows, :js] do
-      screen_width, screen_height = @session.evaluate_script("[window.screen.availWidth, window.screen.availHeight];")
-      window = @session.current_window
-      window.resize_to(screen_width-100, screen_height-100)
-      expect(@session.evaluate_script("[window.outerWidth, window.outerHeight];")).to eq([screen_width-100, screen_height-100])
-      window.maximize
-      sleep 0.5  # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
-      expect(@session.evaluate_script("[window.outerWidth, window.outerHeight];")).to eq([screen_width, screen_height])
-    end
-
-    it 'should stay on current window if invoked not for current window', requires: [:windows, :js] do
-      @other_window = @session.window_opened_by do
+    let! :initial_size do
+      @session.current_window.size
+    end
+
+    after do
+      @session.current_window.resize_to(*initial_size)
+      sleep 0.5
+    end
+
+    it 'should be able to maximize window', requires: %i[windows js] do
+      start_width, start_height = 400, 300
+      @session.current_window.resize_to(start_width, start_height)
+      sleep 0.5
+
+      @session.current_window.maximize
+      sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
+
+      max_width, max_height = @session.current_window.size
+
+      # maximize behavior is window manage dependant, so just make sure it increases in size
+      expect(max_width).to be > start_width
+      expect(max_height).to be > start_height
+    end
+
+    it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
+      other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      @other_window.maximize
+      other_window.resize_to(400, 300)
+      sleep 0.5
+      other_window.maximize
       sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
-      expect(@session.current_window).to eq(@window)
-      # #size returns values larger than availWidth, availHeight with Chromedriver
-      # expect(@other_window.size).to eq(@session.evaluate_script("[window.screen.availWidth, window.screen.availHeight];"))
-      @session.within_window(@other_window) do
-        expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq(@session.evaluate_script("[window.screen.availWidth, window.screen.availHeight];"))
-      end
+
+      expect(@session.current_window).to eq(orig_window)
+      # Maximizing the browser affects all tabs so this may not be valid in real browsers
+      # expect(@session.current_window.size).to eq(initial_size)
+
+      ow_width, ow_height = other_window.size
+      expect(ow_width).to be > 400
+      expect(ow_height).to be > 300
+    end
+  end
+
+  describe '#fullscreen' do
+    let! :initial_size do
+      @session.current_window.size
+    end
+
+    after do
+      @session.current_window.resize_to(*initial_size)
+      sleep 1
+    end
+
+    it 'should be able to fullscreen the window' do
+      expect do
+        @session.current_window.fullscreen
+      end.not_to raise_error
     end
   end
 end

data/lib/capybara/spec/session/window/windows_spec.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
+
+# NOTE: This file uses `sleep` to sync up parts of the tests. This is only implemented like this
+# because of the methods being tested. In tests using Capybara this type of behavior should be implemented
+# using Capybara provided assertions with builtin waiting behavior.
+
 Capybara::SpecHelper.spec '#windows', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
     @session.find(:css, '#openTwoWindows').click
@@ -9,11 +14,9 @@ Capybara::SpecHelper.spec '#windows', requires: [:windows] do
       raise Capybara::CapybaraError if @session.windows.size != 3
     end
   end
-  after(:each) do
-    (@session.windows - [@window]).each do |w|
-      @session.switch_to_window w
-      w.close
-    end
+
+  after do
+    (@session.windows - [@window]).each(&:close)
     @session.switch_to_window(@window)
   end
 
@@ -21,12 +24,11 @@ Capybara::SpecHelper.spec '#windows', requires: [:windows] do
     expect(@session.windows.map { |window| window.instance_of?(Capybara::Window) }).to eq([true] * 3)
   end
 
-  it 'should switchable windows' do
+  it 'should be able to switch to windows' do
+    sleep 1 # give windows enough time to fully load
     titles = @session.windows.map do |window|
       @session.within_window(window) { @session.title }
     end
-    expect(titles).to match_array([
-      'With Windows', 'Title of the first popup', 'Title of popup two'
-    ])
+    expect(titles).to match_array(['With Windows', 'Title of the first popup', 'Title of popup two'])
   end
 end

data/lib/capybara/spec/session/window/within_window_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
-  before(:each) do
+  before do
     @window = @session.current_window
     @session.visit('/with_windows')
     @session.find(:css, '#openTwoWindows').click
@@ -9,7 +10,8 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       raise Capybara::CapybaraError if @session.windows.size != 3
     end
   end
-  after(:each) do
+
+  after do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
       w.close
@@ -17,33 +19,32 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
     @session.switch_to_window(@window)
   end
 
-  context "with an instance of Capybara::Window" do
-    it "should not invoke driver#switch_to_window when given current window" do
-      # switch_to_window is invoked in after hook
-      expect(@session.driver).to receive(:switch_to_window).exactly(3).times.and_call_original
+  context 'with an instance of Capybara::Window' do
+    it 'should not invoke driver#switch_to_window when given current window' do
+      allow(@session.driver).to receive(:switch_to_window).and_call_original
       @session.within_window @window do
         expect(@session.title).to eq('With Windows')
       end
+      expect(@session.driver).not_to have_received(:switch_to_window)
     end
 
-    it "should be able to switch to another window" do
+    it 'should be able to switch to another window' do
       window = (@session.windows - [@window]).first
-      expect(@session.driver).to receive(:switch_to_window).exactly(5).times.and_call_original
       @session.within_window window do
-        expect(['Title of the first popup', 'Title of popup two']).to include(@session.title)
+        expect(@session).to have_title(/Title of the first popup|Title of popup two/)
       end
       expect(@session.title).to eq('With Windows')
     end
 
-    it "returns value from the block" do
+    it 'returns value from the block' do
       window = (@session.windows - [@window]).first
       value = @session.within_window window do
-                43252003274489856000
-              end
+        43252003274489856000
+      end
       expect(value).to eq(43252003274489856000)
     end
 
-    it "should switch back if exception was raised inside block" do
+    it 'should switch back if exception was raised inside block' do
       window = (@session.windows - [@window]).first
       expect do
         @session.within_window(window) do
@@ -57,10 +58,10 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
       expect(@session.send(:scopes)).to eq([nil])
     end
 
-    it "should leave correct scopes after execution in case of error" do
+    it 'should leave correct scopes after execution in case of error', requires: %i[windows frames] do
       window = (@session.windows - [@window]).first
       expect do
-        @session.within 'html' do
+        @session.within_frame 'frameOne' do
           @session.within_window(window) {}
         end
       end.to raise_error(Capybara::ScopeError)
@@ -85,103 +86,72 @@ Capybara::SpecHelper.spec '#within_window', requires: [:windows] do
     end
   end
 
-  context "with lambda" do
-    it "should find the div in another window" do
-      @session.within_window(->{ @session.title == 'Title of the first popup'}) do
+  context 'with lambda' do
+    it 'should find the div in another window' do
+      @session.within_window(-> { @session.title == 'Title of the first popup' }) do
         expect(@session).to have_css('#divInPopupOne')
       end
     end
 
-    it "should find divs in both windows" do
-      @session.within_window(->{ @session.title == 'Title of popup two'}) do
+    it 'should find divs in both windows' do
+      @session.within_window(-> { @session.title == 'Title of popup two' }) do
         expect(@session).to have_css('#divInPopupTwo')
       end
-      @session.within_window(->{ @session.title == 'Title of the first popup'}) do
+      @session.within_window(-> { @session.title == 'Title of the first popup' }) do
         expect(@session).to have_css('#divInPopupOne')
       end
       expect(@session.title).to eq('With Windows')
     end
 
-    it "should raise error if window wasn't found" do
-      expect do
-        @session.within_window(->{ @session.title == 'Invalid title'}) do
+    it 'should be able to nest within_window' do
+      @session.within_window(-> { @session.title == 'Title of popup two' }) do
+        expect(@session).to have_css('#divInPopupTwo')
+        @session.within_window(-> { @session.title == 'Title of the first popup' }) do
           expect(@session).to have_css('#divInPopupOne')
         end
-      end.to raise_error(Capybara::WindowError, "Could not find a window matching block/lambda")
-      expect(@session.current_window).to eq(@window)
-      expect(@session).to have_css('#doesNotOpenWindows')
-      expect(@session.send(:scopes)).to eq([nil])
+        expect(@session).to have_css('#divInPopupTwo')
+        expect(@session).not_to have_css('divInPopupOne')
+      end
+      expect(@session).not_to have_css('#divInPopupTwo')
+      expect(@session).not_to have_css('divInPopupOne')
+      expect(@session.title).to eq('With Windows')
     end
 
-    it "returns value from the block" do
-      value = @session.within_window(->{ @session.title == 'Title of popup two'}) do
-                42
-              end
-      expect(value).to eq(42)
+    it 'should work inside a normal scope' do
+      expect(@session).to have_css('#openWindow')
+      @session.within(:css, '#scope') do
+        @session.within_window(-> { @session.title == 'Title of the first popup' }) do
+          expect(@session).to have_css('#divInPopupOne')
+        end
+        expect(@session).to have_content('My scoped content')
+        expect(@session).not_to have_css('#openWindow')
+      end
     end
 
-    it "should switch back if exception was raised inside block" do
+    it "should raise error if window wasn't found" do
       expect do
-        @session.within_window(->{ @session.title == 'Title of popup two'}) do
-          raise 'some error'
+        @session.within_window(-> { @session.title == 'Invalid title' }) do
+          expect(@session).to have_css('#divInPopupOne')
         end
-      end.to raise_error(StandardError, 'some error')
+      end.to raise_error(Capybara::WindowError, 'Could not find a window matching block/lambda')
       expect(@session.current_window).to eq(@window)
+      expect(@session).to have_css('#doesNotOpenWindows')
       expect(@session.send(:scopes)).to eq([nil])
     end
-  end
 
-  context "with string" do
-    it "should warn" do
-      expect(@session).to receive(:warn).with(/DEPRECATION WARNING/).and_call_original
-      @session.within_window('firstPopup') {}
-    end
-
-    it "should find window by handle" do
-      window = (@session.windows - [@window]).first
-      @session.within_window window.handle do
-        expect(['Title of the first popup', 'Title of popup two']).to include(@session.title)
-      end
+    it 'returns value from the block' do
+      value = @session.within_window(-> { @session.title == 'Title of popup two' }) { 42 }
+      expect(value).to eq(42)
     end
 
-    it "should find the div in firstPopup" do
-      @session.within_window("firstPopup") do
-        expect(@session.find("//*[@id='divInPopupOne']").text).to eq 'This is the text of divInPopupOne'
-      end
-    end
-    it "should find the div in secondPopup" do
-      @session.within_window("secondPopup") do
-        expect(@session.find("//*[@id='divInPopupTwo']").text).to eq 'This is the text of divInPopupTwo'
-      end
-    end
-    it "should find the divs in both popups" do
-      @session.within_window("secondPopup") do
-        expect(@session.find("//*[@id='divInPopupTwo']").text).to eq 'This is the text of divInPopupTwo'
-      end
-      @session.within_window("firstPopup") do
-        expect(@session.find("//*[@id='divInPopupOne']").text).to eq 'This is the text of divInPopupOne'
-      end
-    end
-    it "should find the div in the main window after finding a div in a popup" do
-      @session.within_window("secondPopup") do
-        expect(@session.find("//*[@id='divInPopupTwo']").text).to eq 'This is the text of divInPopupTwo'
-      end
-      expect(@session.find("//*[@id='doesNotOpenWindows']").text).to eq 'Does not open windows'
-    end
-    it "should reset scope when switching windows" do
-      @session.within(:css, '#doesNotOpenWindows') do
-        @session.within_window("secondPopup") do
-          expect(@session.find("//*[@id='divInPopupTwo']").text).to eq 'This is the text of divInPopupTwo'
-        end
-      end
-    end
-    it "should switch back if exception was raised inside block" do
+    it 'should switch back if exception was raised inside block' do
       expect do
-        @session.within_window('secondPopup') do
+        @session.within_window(-> { @session.title == 'Title of popup two' }) do
           raise 'some error'
         end
       end.to raise_error(StandardError, 'some error')
       expect(@session.current_window).to eq(@window)
+      expect(@session.send(:scopes)).to eq([nil])
     end
   end
 end