capybara 2.7.0 → 3.35.3

data/lib/capybara/spec/session/save_screenshot_spec.rb

@@ -1,53 +1,55 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#save_screenshot', requires: [:screenshot] do
-  let(:alternative_path) { File.join(Dir.pwd, "save_screenshot_tmp") }
+  let(:alternative_path) { File.join(Dir.pwd, 'save_screenshot_tmp') }
   before do
+    @old_save_path = Capybara.save_path
+    Capybara.save_path = nil
     @session.visit '/foo'
   end
 
   after do
-    Capybara.save_and_open_page_path = nil
-    Capybara.save_path = nil
+    Capybara.save_path = @old_save_path
     FileUtils.rm_rf alternative_path
   end
 
-  it "generates sensible filename" do
+  it 'generates sensible filename' do
     allow(@session.driver).to receive(:save_screenshot)
 
     @session.save_screenshot
 
-    regexp = Regexp.new(File.expand_path('capybara-\d+\.png'))
-    expect(@session.driver).to have_received(:save_screenshot).with(regexp, {})
+    regexp = Regexp.new(File.join(Dir.pwd, 'capybara-\d+\.png'))
+    expect(@session.driver).to have_received(:save_screenshot).with(regexp, any_args)
   end
 
-  it "allows to specify another path" do
+  it 'allows to specify another path' do
     allow(@session.driver).to receive(:save_screenshot)
 
     custom_path = 'screenshots/1.png'
     @session.save_screenshot(custom_path)
 
-    expect(@session.driver).to have_received(:save_screenshot).with(/#{custom_path}$/, {})
+    expect(@session.driver).to have_received(:save_screenshot).with(/#{custom_path}$/, any_args)
   end
 
-  context "with Capybara.save_path" do
-    it "file is generated in the correct location" do
+  context 'with Capybara.save_path' do
+    it 'file is generated in the correct location' do
       Capybara.save_path = alternative_path
       allow(@session.driver).to receive(:save_screenshot)
 
       @session.save_screenshot
 
-      regexp = Regexp.new(File.expand_path('capybara-\d+\.png', alternative_path))
-      expect(@session.driver).to have_received(:save_screenshot).with(regexp, {})
+      regexp = Regexp.new(File.join(alternative_path, 'capybara-\d+\.png'))
+      expect(@session.driver).to have_received(:save_screenshot).with(regexp, any_args)
     end
 
-    it "relative paths are relative to save_path" do
+    it 'relative paths are relative to save_path' do
       Capybara.save_path = alternative_path
       allow(@session.driver).to receive(:save_screenshot)
 
       custom_path = 'screenshots/2.png'
       @session.save_screenshot(custom_path)
 
-      expect(@session.driver).to have_received(:save_screenshot).with(File.expand_path(custom_path, alternative_path), {})
+      expect(@session.driver).to have_received(:save_screenshot).with(File.expand_path(custom_path, alternative_path), any_args)
     end
   end
 end

data/lib/capybara/spec/session/screenshot_spec.rb

@@ -1,14 +1,14 @@
 # coding: US-ASCII
 # frozen_string_literal: true
 
-Capybara::SpecHelper.spec "#save_screenshot" do
+Capybara::SpecHelper.spec '#save_screenshot' do
   let(:image_path) { File.join(Dir.tmpdir, 'capybara-screenshot.png') }
 
   before do
     @session.visit '/'
   end
 
-  it "should generate PNG file", :requires => [:screenshot] do
+  it 'should generate PNG file', requires: [:screenshot] do
     path = @session.save_screenshot image_path
 
     magic = File.read(image_path, 4)

data/lib/capybara/spec/session/scroll_spec.rb

@@ -0,0 +1,117 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#scroll_to', requires: [:scroll] do
+  before do
+    @session.visit('/scroll')
+  end
+
+  it 'can scroll an element to the top of the viewport' do
+    el = @session.find(:css, '#scroll')
+    @session.scroll_to(el, align: :top)
+    expect(el.evaluate_script('this.getBoundingClientRect().top')).to be_within(1).of(0)
+  end
+
+  it 'can scroll an element to the bottom of the viewport' do
+    el = @session.find(:css, '#scroll')
+    @session.scroll_to(el, align: :bottom)
+    el_bottom = el.evaluate_script('this.getBoundingClientRect().bottom')
+    viewport_bottom = el.evaluate_script('document.body.clientHeight')
+    expect(el_bottom).to be_within(1).of(viewport_bottom)
+  end
+
+  it 'can scroll an element to the center of the viewport' do
+    el = @session.find(:css, '#scroll')
+    @session.scroll_to(el, align: :center)
+    el_center = el.evaluate_script('(function(rect){return (rect.top + rect.bottom)/2})(this.getBoundingClientRect())')
+    viewport_bottom = el.evaluate_script('document.body.clientHeight')
+    expect(el_center).to be_within(2).of(viewport_bottom / 2)
+  end
+
+  it 'can scroll the window to the vertical top' do
+    @session.scroll_to :bottom
+    @session.scroll_to :top
+    expect(@session.evaluate_script('[window.scrollX || window.pageXOffset, window.scrollY || window.pageYOffset]')).to eq [0, 0]
+  end
+
+  it 'can scroll the window to the vertical bottom' do
+    @session.scroll_to :bottom
+    max_scroll = @session.evaluate_script('document.body.scrollHeight - document.body.clientHeight')
+    expect(@session.evaluate_script('[window.scrollX || window.pageXOffset, window.scrollY || window.pageYOffset]')).to eq [0, max_scroll]
+  end
+
+  it 'can scroll the window to the vertical center' do
+    @session.scroll_to :center
+    max_scroll = @session.evaluate_script('document.documentElement.scrollHeight - document.body.clientHeight')
+    expect(@session.evaluate_script('[window.scrollX || window.pageXOffset, window.scrollY || window.pageYOffset]')).to eq [0, max_scroll / 2]
+  end
+
+  it 'can scroll the window to specific location' do
+    @session.scroll_to 100, 100
+    expect(@session.evaluate_script('[window.scrollX || window.pageXOffset, window.scrollY || window.pageYOffset]')).to eq [100, 100]
+  end
+
+  it 'can scroll an element to the top of the scrolling element' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    el = scrolling_element.find(:css, '#inner')
+    scrolling_element.scroll_to(el, align: :top)
+    scrolling_element_top = scrolling_element.evaluate_script('this.getBoundingClientRect().top')
+    expect(el.evaluate_script('this.getBoundingClientRect().top')).to be_within(3).of(scrolling_element_top)
+  end
+
+  it 'can scroll an element to the bottom of the scrolling element' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    el = scrolling_element.find(:css, '#inner')
+    scrolling_element.scroll_to(el, align: :bottom)
+    el_bottom = el.evaluate_script('this.getBoundingClientRect().bottom')
+    scroller_bottom = scrolling_element.evaluate_script('this.getBoundingClientRect().top + this.clientHeight')
+    expect(el_bottom).to be_within(1).of(scroller_bottom)
+  end
+
+  it 'can scroll an element to the center of the scrolling element' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    el = scrolling_element.find(:css, '#inner')
+    scrolling_element.scroll_to(el, align: :center)
+    el_center = el.evaluate_script('(function(rect){return (rect.top + rect.bottom)/2})(this.getBoundingClientRect())')
+    scrollable_center = scrolling_element.evaluate_script('(this.clientHeight / 2) + this.getBoundingClientRect().top')
+    expect(el_center).to be_within(1).of(scrollable_center)
+  end
+
+  it 'can scroll the scrolling element to the top' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    scrolling_element.scroll_to :bottom
+    scrolling_element.scroll_to :top
+    expect(scrolling_element.evaluate_script('[this.scrollLeft, this.scrollTop]')).to eq [0, 0]
+  end
+
+  it 'can scroll the scrolling element to the bottom' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    scrolling_element.scroll_to :bottom
+    max_scroll = scrolling_element.evaluate_script('this.scrollHeight - this.clientHeight')
+    expect(scrolling_element.evaluate_script('[this.scrollLeft, this.scrollTop]')).to eq [0, max_scroll]
+  end
+
+  it 'can scroll the scrolling element to the vertical center' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    scrolling_element.scroll_to :center
+    max_scroll = scrolling_element.evaluate_script('this.scrollHeight - this.clientHeight')
+    expect(scrolling_element.evaluate_script('[this.scrollLeft, this.scrollTop]')).to eq [0, max_scroll / 2]
+  end
+
+  it 'can scroll the scrolling element to specific location' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    scrolling_element.scroll_to 100, 100
+    expect(scrolling_element.evaluate_script('[this.scrollLeft, this.scrollTop]')).to eq [100, 100]
+  end
+
+  it 'can scroll the window by a specific amount' do
+    @session.scroll_to(:current, offset: [50, 75])
+    expect(@session.evaluate_script('[window.scrollX || window.pageXOffset, window.scrollY || window.pageYOffset]')).to eq [50, 75]
+  end
+
+  it 'can scroll the scroll the scrolling element by a specific amount' do
+    scrolling_element = @session.find(:css, '#scrollable')
+    scrolling_element.scroll_to 100, 100
+    scrolling_element.scroll_to(:current, offset: [-50, 50])
+    expect(scrolling_element.evaluate_script('[this.scrollLeft, this.scrollTop]')).to eq [50, 150]
+  end
+end

data/lib/capybara/spec/session/select_spec.rb

@@ -1,202 +1,229 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec "#select" do
+
+Capybara::SpecHelper.spec '#select' do
   before do
     @session.visit('/form')
   end
 
-  it "should return value of the first option" do
+  it 'should return value of the first option' do
     expect(@session.find_field('Title').value).to eq('Mrs')
   end
 
-  it "should return value of the selected option" do
-    @session.select("Miss", :from => 'Title')
+  it 'should return value of the selected option' do
+    @session.select('Miss', from: 'Title')
     expect(@session.find_field('Title').value).to eq('Miss')
   end
 
-  it "should allow selecting options where there are inexact matches" do
-    @session.select("Mr", :from => 'Title')
+  it 'should allow selecting exact options where there are inexact matches', :exact_false do
+    @session.select('Mr', from: 'Title')
     expect(@session.find_field('Title').value).to eq('Mr')
   end
 
-  it "should allow selecting options where they are the only inexact match" do
-    @session.select("Mis", :from => 'Title')
+  it 'should allow selecting options where they are the only inexact match', :exact_false do
+    @session.select('Mis', from: 'Title')
     expect(@session.find_field('Title').value).to eq('Miss')
   end
 
-  it "should not allow selecting options where they are the only inexact match if `Capybara.exact_options = true`" do
-    Capybara.exact_options = true
+  it 'should not allow selecting options where they are the only inexact match if `exact: true` is specified' do
+    sel = @session.find(:select, 'Title')
     expect do
-      @session.select("Mis", :from => 'Title')
+      sel.select('Mis', exact: true)
     end.to raise_error(Capybara::ElementNotFound)
   end
 
-  it "should not allow selecting an option if the match is ambiguous" do
+  it 'should not allow selecting an option if the match is ambiguous', :exact_false do
     expect do
-      @session.select("M", :from => 'Title')
+      @session.select('M', from: 'Title')
     end.to raise_error(Capybara::Ambiguous)
   end
 
-  it "should return the value attribute rather than content if present" do
+  it 'should return the value attribute rather than content if present' do
     expect(@session.find_field('Locale').value).to eq('en')
   end
 
-  it "should select an option from a select box by id" do
-    @session.select("Finish", :from => 'form_locale')
+  it 'should select an option from a select box by id' do
+    @session.select('Finnish', from: 'form_locale')
     @session.click_button('awesome')
     expect(extract_results(@session)['locale']).to eq('fi')
   end
 
-  it "should select an option from a select box by label" do
-    @session.select("Finish", :from => 'Locale')
+  it 'should select an option from a select box by label' do
+    @session.select('Finnish', from: 'Locale')
     @session.click_button('awesome')
     expect(extract_results(@session)['locale']).to eq('fi')
   end
 
-  it "should select an option without giving a select box" do
-    @session.select("Swedish")
+  it 'should select an option without giving a select box' do
+    @session.select('Swedish')
     @session.click_button('awesome')
     expect(extract_results(@session)['locale']).to eq('sv')
   end
 
-  it "should escape quotes" do
-    @session.select("John's made-up language", :from => 'Locale')
+  it 'should escape quotes' do
+    @session.select("John's made-up language", from: 'Locale')
     @session.click_button('awesome')
     expect(extract_results(@session)['locale']).to eq('jo')
   end
 
-  it "should obey from" do
-    @session.select("Miss", :from => "Other title")
+  it 'should obey from' do
+    @session.select('Miss', from: 'Other title')
     @session.click_button('awesome')
     results = extract_results(@session)
-    expect(results['other_title']).to eq("Miss")
-    expect(results['title']).not_to eq("Miss")
+    expect(results['other_title']).to eq('Miss')
+    expect(results['title']).not_to eq('Miss')
   end
 
-  it "show match labels with preceding or trailing whitespace" do
-    @session.select("Lojban", :from => 'Locale')
+  it 'show match labels with preceding or trailing whitespace' do
+    @session.select('Lojban', from: 'Locale')
     @session.click_button('awesome')
     expect(extract_results(@session)['locale']).to eq('jbo')
   end
 
-  it "casts to string" do
-    @session.select(:"Miss", :from => :'Title')
+  it 'casts to string' do
+    @session.select(:Miss, from: :Title)
     expect(@session.find_field('Title').value).to eq('Miss')
   end
 
+  context 'input with datalist' do
+    it 'should select an option' do
+      @session.select('Audi', from: 'manufacturer')
+      @session.click_button('awesome')
+      expect(extract_results(@session)['manufacturer']).to eq('Audi')
+    end
+
+    it 'should not find an input without a datalist' do
+      expect do
+        @session.select('Thomas', from: 'form_first_name')
+      end.to raise_error(/Unable to find input box with datalist completion "form_first_name"/)
+    end
+
+    it "should not select an option that doesn't exist" do
+      expect do
+        @session.select('Tata', from: 'manufacturer')
+      end.to raise_error(/Unable to find datalist option "Tata"/)
+    end
+
+    it 'should not select a disabled option' do
+      expect do
+        @session.select('Mercedes', from: 'manufacturer')
+      end.to raise_error(/Unable to find datalist option "Mercedes"/)
+    end
+  end
+
   context "with a locator that doesn't exist" do
-    it "should raise an error" do
-      msg = "Unable to find select box \"does not exist\""
+    it 'should raise an error' do
+      msg = /Unable to find select box "does not exist"/
       expect do
-        @session.select('foo', :from => 'does not exist')
+        @session.select('foo', from: 'does not exist')
       end.to raise_error(Capybara::ElementNotFound, msg)
     end
   end
 
   context "with an option that doesn't exist" do
-    it "should raise an error" do
-      msg = "Unable to find option \"Does not Exist\""
+    it 'should raise an error' do
+      msg = /^Unable to find option "Does not Exist" within/
       expect do
-        @session.select('Does not Exist', :from => 'form_locale')
+        @session.select('Does not Exist', from: 'form_locale')
       end.to raise_error(Capybara::ElementNotFound, msg)
     end
   end
 
-  context "on a disabled select" do
-    it "should raise an error" do
+  context 'on a disabled select' do
+    it 'should raise an error' do
       expect do
-        @session.select('Should not see me', :from => 'Disabled Select')
+        @session.select('Should not see me', from: 'Disabled Select')
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  context "on a disabled option" do
-    it "should not select" do
-      @session.select('Other', :from => 'form_title')
+  context 'on a disabled option' do
+    it 'should not select' do
+      @session.select('Other', from: 'form_title')
       expect(@session.find_field('form_title').value).not_to eq 'Other'
     end
-
-    it "should warn" do
-      expect_any_instance_of(Capybara::Node::Element).to receive(:warn).once
-      @session.select('Other', :from => 'form_title')
-    end
   end
 
-  context "with multiple select" do
-    it "should return an empty value" do
-      expect(@session.find_field('Language').value).to eq([])
+  context 'with multiple select' do
+    it 'should return an empty value' do
+      expect(@session.find_field('Languages').value).to eq([])
     end
 
-    it "should return value of the selected options" do
-      @session.select("Ruby",       :from => 'Language')
-      @session.select("Javascript", :from => 'Language')
-      expect(@session.find_field('Language').value).to include('Ruby', 'Javascript')
+    it 'should return value of the selected options' do
+      @session.select('Ruby',       from: 'Languages')
+      @session.select('Javascript', from: 'Languages')
+      expect(@session.find_field('Languages').value).to include('Ruby', 'Javascript')
     end
 
-    it "should select one option" do
-      @session.select("Ruby", :from => 'Language')
+    it 'should select one option' do
+      @session.select('Ruby', from: 'Languages')
       @session.click_button('awesome')
       expect(extract_results(@session)['languages']).to eq(['Ruby'])
     end
 
-    it "should select multiple options" do
-      @session.select("Ruby",       :from => 'Language')
-      @session.select("Javascript", :from => 'Language')
+    it 'should select multiple options' do
+      @session.select('Ruby',       from: 'Languages')
+      @session.select('Javascript', from: 'Languages')
       @session.click_button('awesome')
       expect(extract_results(@session)['languages']).to include('Ruby', 'Javascript')
     end
 
-    it "should remain selected if already selected" do
-      @session.select("Ruby",       :from => 'Language')
-      @session.select("Javascript", :from => 'Language')
-      @session.select("Ruby",       :from => 'Language')
+    it 'should remain selected if already selected' do
+      @session.select('Ruby',       from: 'Languages')
+      @session.select('Javascript', from: 'Languages')
+      @session.select('Ruby',       from: 'Languages')
       @session.click_button('awesome')
       expect(extract_results(@session)['languages']).to include('Ruby', 'Javascript')
     end
 
-    it "should return value attribute rather than content if present" do
+    it 'should return value attribute rather than content if present' do
       expect(@session.find_field('Underwear').value).to include('thermal')
     end
   end
 
-  context "with :exact option" do
-    context "when `false`" do
-      it "can match select box approximately" do
-        @session.select("Finish", :from => "Loc", :exact => false)
-        @session.click_button("awesome")
-        expect(extract_results(@session)["locale"]).to eq("fi")
+  context 'with :exact option' do
+    context 'when `false`' do
+      it 'can match select box approximately' do
+        @session.select('Finnish', from: 'Loc', exact: false)
+        @session.click_button('awesome')
+        expect(extract_results(@session)['locale']).to eq('fi')
       end
 
-      it "can match option approximately" do
-        @session.select("Fin", :from => "Locale", :exact => false)
-        @session.click_button("awesome")
-        expect(extract_results(@session)["locale"]).to eq("fi")
+      it 'can match option approximately' do
+        @session.select('Fin', from: 'Locale', exact:  false)
+        @session.click_button('awesome')
+        expect(extract_results(@session)['locale']).to eq('fi')
       end
 
-      it "can match option approximately when :from not given" do
-        @session.select("made-up language", :exact => false)
-        @session.click_button("awesome")
-        expect(extract_results(@session)["locale"]).to eq("jo")
+      it 'can match option approximately when :from not given' do
+        @session.select('made-up language', exact:  false)
+        @session.click_button('awesome')
+        expect(extract_results(@session)['locale']).to eq('jo')
       end
     end
 
-    context "when `true`" do
-      it "can match select box approximately" do
+    context 'when `true`' do
+      it 'can match select box approximately' do
         expect do
-          @session.select("Finish", :from => "Loc", :exact => true)
+          @session.select('Finnish', from: 'Loc', exact: true)
         end.to raise_error(Capybara::ElementNotFound)
       end
 
-      it "can match option approximately" do
+      it 'can match option approximately' do
         expect do
-          @session.select("Fin", :from => "Locale", :exact => true)
+          @session.select('Fin', from: 'Locale', exact: true)
         end.to raise_error(Capybara::ElementNotFound)
       end
 
-      it "can match option approximately when :from not given" do
+      it 'can match option approximately when :from not given' do
         expect do
-          @session.select("made-up language", :exact => true)
+          @session.select('made-up language', exact: true)
         end.to raise_error(Capybara::ElementNotFound)
       end
     end
   end
+
+  it 'should error when not passed a locator for :from option' do
+    select = @session.find(:select, 'Title')
+    expect { @session.select('Mr', from: select) }.to raise_error(ArgumentError, /does not take an element/)
+  end
 end