activemerchant 1.103.0 → 1.104.0

data/lib/active_merchant/billing/gateways/trexle.rb

@@ -106,6 +106,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, creditcard, options)
         return if creditcard.kind_of?(String)
+
         address = (options[:billing_address] || options[:address])
         return unless address
 
@@ -181,6 +182,7 @@ module ActiveMerchant #:nodoc:
 
       def error_response(body)
         return invalid_response unless body['error']
+
         Response.new(
           false,
           body['error'],
@@ -207,6 +209,7 @@ module ActiveMerchant #:nodoc:
 
       def parse(body)
         return {} if body.blank?
+
         JSON.parse(body)
       end
 

data/lib/active_merchant/billing/gateways/usa_epay.rb

@@ -5,7 +5,6 @@ module ActiveMerchant #:nodoc:
     # depending on options passed to new.
     #
     class UsaEpayGateway < Gateway
-
       self.abstract_class = true
 
       ##

data/lib/active_merchant/billing/gateways/usa_epay_advanced.rb

@@ -230,21 +230,21 @@ module ActiveMerchant #:nodoc:
       } #:nodoc:
 
       AVS_RESULTS = {
-        'Y' => %w( YYY Y YYA YYD ),
-        'Z' => %w( NYZ Z ),
-        'A' => %w( YNA A YNY ),
-        'N' => %w( NNN N NN ),
-        'X' => %w( YYX X ),
-        'W' => %w( NYW W ),
-        'XXW' => %w( XXW ),
-        'XXU' => %w( XXU ),
-        'R' => %w( XXR R U E ),
-        'S' => %w( XXS S ),
-        'XXE' => %w( XXE ),
-        'G' => %w( XXG G C I ),
-        'B' => %w( YYG B M ),
-        'D' => %w( GGG D ),
-        'P' => %w( YGG P )
+        'Y' => %w(YYY Y YYA YYD),
+        'Z' => %w(NYZ Z),
+        'A' => %w(YNA A YNY),
+        'N' => %w(NNN N NN),
+        'X' => %w(YYX X),
+        'W' => %w(NYW W),
+        'XXW' => %w(XXW),
+        'XXU' => %w(XXU),
+        'R' => %w(XXR R U E),
+        'S' => %w(XXS S),
+        'XXE' => %w(XXE),
+        'G' => %w(XXG G C I),
+        'B' => %w(YYG B M),
+        'D' => %w(GGG D),
+        'P' => %w(YGG P)
       }.inject({}) do |map, (type, codes)|
         codes.each { |code| map[code] = type }
         map
@@ -1607,7 +1607,6 @@ module ActiveMerchant #:nodoc:
 
         response
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/usa_epay_transaction.rb

@@ -204,6 +204,7 @@ module ActiveMerchant #:nodoc:
           if payment.account_type
             account_type = payment.account_type.to_s.capitalize
             raise ArgumentError, 'account_type must be checking or savings' unless %w(Checking Savings).include?(account_type)
+
             post[:accounttype] = account_type
           end
           post[:account] = payment.account_number
@@ -228,6 +229,7 @@ module ActiveMerchant #:nodoc:
       # see: http://wiki.usaepay.com/developer/transactionapi#split_payments
       def add_split_payments(post, options)
         return unless options[:split_payments].is_a?(Array)
+
         options[:split_payments].each_with_index do |payment, index|
           prefix = '%02d' % (index + 2)
           post["#{prefix}key"]         = payment[:key]
@@ -241,6 +243,7 @@ module ActiveMerchant #:nodoc:
 
       def add_recurring_fields(post, options)
         return unless options[:recurring_fields].is_a?(Hash)
+
         options[:recurring_fields].each do |key, value|
           if value == true
             value = 'yes'
@@ -268,6 +271,7 @@ module ActiveMerchant #:nodoc:
       # see: https://wiki.usaepay.com/developer/transactionapi#line_item_details
       def add_line_items(post, options)
         return unless options[:line_items].is_a?(Array)
+
         options[:line_items].each_with_index do |line_item, index|
           %w(product_ref_num sku qty name description taxable tax_rate tax_amount commodity_code discount_rate discount_amount).each do |key|
             post["line#{index}#{key.delete('_')}"] = line_item[key.to_sym] if line_item.has_key?(key.to_sym)
@@ -329,6 +333,7 @@ module ActiveMerchant #:nodoc:
           return 'Success'
         else
           return 'Unspecified error' if response[:error].blank?
+
           return response[:error]
         end
       end

data/lib/active_merchant/billing/gateways/vanco.rb

@@ -108,6 +108,7 @@ module ActiveMerchant
 
       def message_from(succeeded, response)
         return 'Success' if succeeded
+
         response[:error_message]
       end
 
@@ -288,7 +289,6 @@ module ActiveMerchant
           'Content-Type' => 'text/xml'
         }
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/visanet_peru.rb

@@ -213,6 +213,7 @@ module ActiveMerchant #:nodoc:
 
       def action_code_description(response)
         return nil unless response['data']
+
         response['data']['DSC_COD_ACCION']
       end
 

data/lib/active_merchant/billing/gateways/wepay.rb

@@ -81,7 +81,7 @@ module ActiveMerchant #:nodoc:
         post[:expiration_month] = creditcard.month
         post[:expiration_year] = creditcard.year
 
-        if(billing_address = (options[:billing_address] || options[:address]))
+        if (billing_address = (options[:billing_address] || options[:address]))
           post[:address] = {}
           post[:address]['address1'] = billing_address[:address1] if billing_address[:address1]
           post[:address]['city']     = billing_address[:city] if billing_address[:city]
@@ -170,11 +170,12 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, params, options={})
         begin
-          response = parse(ssl_post(
-            ((test? ? test_url : live_url) + action),
-            params.to_json,
-            headers(options)
-          ))
+          response = parse(
+            ssl_post(
+              ((test? ? test_url : live_url) + action),
+              params.to_json,
+              headers(options)
+            ))
         rescue ResponseError => e
           response = parse(e.response.body)
         end

data/lib/active_merchant/billing/gateways/wirecard.rb

@@ -13,9 +13,9 @@ module ActiveMerchant #:nodoc:
         'xsi:noNamespaceSchemaLocation' => 'wirecard.xsd'
       }
 
-      PERMITTED_TRANSACTIONS = %w[ PREAUTHORIZATION CAPTURE PURCHASE ]
+      PERMITTED_TRANSACTIONS = %w[PREAUTHORIZATION CAPTURE PURCHASE]
 
-      RETURN_CODES = %w[ ACK NOK ]
+      RETURN_CODES = %w[ACK NOK]
 
       # Wirecard only allows phone numbers with a format like this: +xxx(yyy)zzz-zzzz-ppp, where:
       #   xxx = Country code
@@ -26,7 +26,7 @@ module ActiveMerchant #:nodoc:
       # number 5551234 within area code 202 (country code 1).
       VALID_PHONE_FORMAT = /\+\d{1,3}(\(?\d{3}\)?)?\d{3}-\d{4}-\d{3}/
 
-      self.supported_cardtypes = [ :visa, :master, :american_express, :diners_club, :jcb ]
+      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb]
       self.supported_countries = %w(AD CY GI IM MT RO CH AT DK GR IT MC SM TR BE EE HU LV NL SK GB BG FI IS LI NO SI VA FR IL LT PL ES CZ DE IE LU PT SE)
       self.homepage_url = 'http://www.wirecard.com'
       self.display_name = 'Wirecard'
@@ -263,6 +263,7 @@ module ActiveMerchant #:nodoc:
       # Includes the credit-card data to the transaction-xml
       def add_creditcard(xml, creditcard)
         raise 'Creditcard must be supplied!' if creditcard.nil?
+
         xml.tag! 'CREDIT_CARD_DATA' do
           xml.tag! 'CreditCardNumber', creditcard.number
           xml.tag! 'CVC2', creditcard.verification_value
@@ -275,6 +276,7 @@ module ActiveMerchant #:nodoc:
       # Includes the IP address of the customer to the transaction-xml
       def add_customer_data(xml, options)
         return unless options[:ip]
+
         xml.tag! 'CONTACT_DATA' do
           xml.tag! 'IPAddress', options[:ip]
         end
@@ -283,6 +285,7 @@ module ActiveMerchant #:nodoc:
       # Includes the address to the transaction-xml
       def add_address(xml, address)
         return if address.nil?
+
         xml.tag! 'CORPTRUSTCENTER_DATA' do
           xml.tag! 'ADDRESS' do
             xml.tag! 'Address1', address[:address1]

data/lib/active_merchant/billing/gateways/world_net.rb

@@ -128,6 +128,7 @@ module ActiveMerchant #:nodoc:
       def add_address(post, _creditcard, options)
         address = options[:billing_address] || options[:address]
         return unless address
+
         post[:address1] = address[:address1]
         post[:address2] = address[:address2]
         post[:city]     = address[:city]

data/lib/active_merchant/billing/gateways/worldpay.rb

@@ -379,6 +379,7 @@ module ActiveMerchant #:nodoc:
 
       def add_shopper(xml, options)
         return unless options[:execute_threed] || options[:email] || options[:customer]
+
         xml.tag! 'shopper' do
           xml.tag! 'shopperEmailAddress', options[:email] if  options[:email]
           add_authenticated_shopper_id(xml, options)
@@ -545,6 +546,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(success, raw, success_criteria)
         return 'SUCCESS' if success
+
         raw[:iso8583_return_code_description] || raw[:error] || required_status_message(raw, success_criteria)
       end
 
@@ -633,6 +635,7 @@ module ActiveMerchant #:nodoc:
 
       def credit_fund_transfer_attribute(options)
         return unless options[:credit]
+
         {'action' => 'REFUND'}
       end
 
@@ -644,6 +647,7 @@ module ActiveMerchant #:nodoc:
       def currency_exponent(currency)
         return 0 if non_fractional_currency?(currency)
         return 3 if three_decimal_currency?(currency)
+
         return 2
       end
 

data/lib/active_merchant/billing/gateways/worldpay_online_payments.rb

@@ -205,7 +205,6 @@ module ActiveMerchant #:nodoc:
       def handle_response(response)
         response.body
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/worldpay_us.rb

@@ -91,7 +91,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_data(post, options)
-        if(billing_address = (options[:billing_address] || options[:address]))
+        if (billing_address = (options[:billing_address] || options[:address]))
           post[:ci_companyname] = billing_address[:company]
           post[:ci_billaddr1]   = billing_address[:address1]
           post[:ci_billaddr2]   = billing_address[:address2]
@@ -105,7 +105,7 @@ module ActiveMerchant #:nodoc:
           post[:ci_ipaddress]   = billing_address[:ip]
         end
 
-        if(shipping_address = options[:shipping_address])
+        if (shipping_address = options[:shipping_address])
           post[:ci_shipaddr1] = shipping_address[:address1]
           post[:ci_shipaddr2] = shipping_address[:address2]
           post[:ci_shipcity] = shipping_address[:city]

data/lib/active_merchant/billing/response.rb

@@ -60,7 +60,7 @@ module ActiveMerchant #:nodoc:
         self << response
 
         unless ignore_result
-          if(@use_first_response && response.success?)
+          if @use_first_response && response.success?
             @primary_response ||= response
           else
             @primary_response = response

data/lib/active_merchant/connection.rb

@@ -62,6 +62,7 @@ module ActiveMerchant
 
     def wiredump_device=(device)
       raise ArgumentError, "can't wiredump to frozen #{device.class}" if device&.frozen?
+
       @wiredump_device = device
     end
 
@@ -86,6 +87,7 @@ module ActiveMerchant
               case method
               when :get
                 raise ArgumentError, 'GET requests do not support a request body' if body
+
                 http.get(endpoint.request_uri, headers)
               when :post
                 debug body

data/lib/active_merchant/country.rb

@@ -330,6 +330,7 @@ module ActiveMerchant #:nodoc:
         country = COUNTRIES.detect { |c| c[:name].casecmp(name).zero? }
       end
       raise InvalidCountryCodeError, "No country could be found for the country #{name}" if country.nil?
+
       Country.new(country.dup)
     end
   end

data/lib/active_merchant/net_http_ssl_connection.rb

@@ -4,6 +4,7 @@ module NetHttpSslConnection
   refine Net::HTTP do
     def ssl_connection
       return {} unless use_ssl? && @socket.present?
+
       { version: @socket.io.ssl_version, cipher: @socket.io.cipher[0] }
     end
   end

data/lib/active_merchant/post_data.rb

@@ -7,6 +7,7 @@ module ActiveMerchant
 
     def []=(key, value)
       return if value.blank? && !required?(key)
+
       super
     end
 

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = '1.103.0'
+  VERSION = '1.104.0'
 end

data/lib/support/ssl_verify.rb

@@ -2,7 +2,6 @@ require 'active_merchant'
 require 'support/gateway_support'
 
 class SSLVerify
-
   def initialize
     @gateways = GatewaySupport.new.gateways
   end
@@ -86,5 +85,4 @@ class SSLVerify
   rescue Net::HTTPBadResponse, Errno::ETIMEDOUT, EOFError, SocketError, Errno::ECONNREFUSED, Timeout::Error => ex
     return :error, ex.inspect
   end
-
 end

data/lib/support/ssl_version.rb

@@ -83,5 +83,4 @@ class SSLVersion
   rescue StandardError => ex
     return :error, ex.inspect
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.103.0
+  version: 1.104.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-02 00:00:00.000000000 Z
+date: 2020-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport