activemerchant 1.103.0 → 1.104.0

data/lib/active_merchant/billing/gateways/s5.rb

@@ -143,6 +143,7 @@ module ActiveMerchant #:nodoc:
 
       def add_customer(xml, creditcard, options)
         return unless creditcard.respond_to?(:number)
+
         address = options[:billing_address]
         xml.Customer do
           xml.Contact do

data/lib/active_merchant/billing/gateways/safe_charge.rb

@@ -207,6 +207,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(response)
         return 'Success' if success_from(response)
+
         response[:reason_codes] || response[:reason]
       end
 
@@ -240,6 +241,7 @@ module ActiveMerchant #:nodoc:
 
         params.map do |key, value|
           next if value != false && value.blank?
+
           "#{key}=#{CGI.escape(value.to_s)}"
         end.compact.join('&')
       end

data/lib/active_merchant/billing/gateways/sage.rb

@@ -115,6 +115,7 @@ module ActiveMerchant #:nodoc:
       # use the same method as in pay_conex
       def force_utf8(string)
         return nil unless string
+
         binary = string.encode('BINARY', invalid: :replace, undef: :replace, replace: '?') # Needed for Ruby 2.0 since #encode is a no-op if the string is already UTF-8. It's not needed for Ruby 2.1 and up since it's not a no-op there.
         binary.encode('UTF-8', invalid: :replace, undef: :replace, replace: '?')
       end
@@ -296,7 +297,6 @@ module ActiveMerchant #:nodoc:
       end
 
       class SageVault
-
         def initialize(options, gateway)
           @live_url = 'https://www.sagepayments.net/web_services/wsVault/wsVault.asmx'
           @options = options

data/lib/active_merchant/billing/gateways/sage_pay.rb

@@ -312,6 +312,7 @@ module ActiveMerchant #:nodoc:
 
       def sanitize_phone(phone)
         return nil unless phone
+
         cleansed = phone.to_s.gsub(/[^0-9+]/, '')
         truncate(cleansed, 20)
       end
@@ -361,11 +362,11 @@ module ActiveMerchant #:nodoc:
         when :store
           response['Token']
         else
-          [ params[:VendorTxCode],
-            response['VPSTxId'] || params[:VPSTxId],
-            response['TxAuthNo'],
-            response['SecurityKey'] || params[:SecurityKey],
-            action ].join(';')
+          [params[:VendorTxCode],
+           response['VPSTxId'] || params[:VPSTxId],
+           response['TxAuthNo'],
+           response['SecurityKey'] || params[:SecurityKey],
+           action].join(';')
         end
       end
 
@@ -389,7 +390,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_simulator_url(action)
-        endpoint = [ :purchase, :authorization ].include?(action) ? 'VSPDirectGateway.asp' : "VSPServerGateway.asp?Service=Vendor#{TRANSACTIONS[action].capitalize}Tx"
+        endpoint = [:purchase, :authorization].include?(action) ? 'VSPDirectGateway.asp' : "VSPServerGateway.asp?Service=Vendor#{TRANSACTIONS[action].capitalize}Tx"
         "#{self.simulator_url}/#{endpoint}"
       end
 
@@ -426,6 +427,7 @@ module ActiveMerchant #:nodoc:
 
       def past_purchase_reference?(payment_method)
         return false unless payment_method.is_a?(String)
+
         payment_method.split(';').last == 'purchase'
       end
     end

data/lib/active_merchant/billing/gateways/secure_net.rb

@@ -1,7 +1,6 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class SecureNetGateway < Gateway
-
       API_VERSION = '4.0'
 
       TRANSACTIONS = {
@@ -28,8 +27,8 @@ module ActiveMerchant #:nodoc:
 
       APPROVED, DECLINED = 1, 2
 
-      CARD_CODE_ERRORS = %w( N S )
-      AVS_ERRORS = %w( A E N R W Z )
+      CARD_CODE_ERRORS = %w(N S)
+      AVS_ERRORS = %w(A E N R W Z)
 
       def initialize(options = {})
         requires!(options, :login, :password)
@@ -257,7 +256,6 @@ module ActiveMerchant #:nodoc:
       def build_authorization(response)
         [response[:transactionid], response[:transactionamount], response[:last4_digits]].join('|')
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/secure_pay.rb

@@ -21,8 +21,8 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://www.securepay.com/'
       self.display_name = 'SecurePay'
 
-      CARD_CODE_ERRORS = %w( N S )
-      AVS_ERRORS = %w( A E N R W Z )
+      CARD_CODE_ERRORS = %w(N S)
+      AVS_ERRORS = %w(A E N R W Z)
       AVS_REASON_CODES = %w(27 45)
       TRANSACTION_ALREADY_ACTIONED = %w(310 311)
 

data/lib/active_merchant/billing/gateways/secure_pay_au.rb

@@ -54,7 +54,7 @@ module ActiveMerchant #:nodoc:
         :trigger          => nil
       }
 
-      SUCCESS_CODES = [ '00', '08', '11', '16', '77' ]
+      SUCCESS_CODES = ['00', '08', '11', '16', '77']
 
       def initialize(options = {})
         requires!(options, :login, :password)

data/lib/active_merchant/billing/gateways/secure_pay_tech.rb

@@ -2,7 +2,7 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class SecurePayTechGateway < Gateway
       class SecurePayTechPostData < PostData
-        self.required_fields = [ :OrderReference, :CardNumber, :CardExpiry, :CardHolderName, :CardType, :MerchantID, :MerchantKey, :Amount, :Currency ]
+        self.required_fields = [:OrderReference, :CardNumber, :CardExpiry, :CardHolderName, :CardType, :MerchantID, :MerchantKey, :Amount, :Currency]
       end
 
       self.live_url = self.test_url = 'https://tx.securepaytech.com/web/HttpPostPurchase'

data/lib/active_merchant/billing/gateways/securion_pay.rb

@@ -166,6 +166,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, options)
         return unless post[:card]&.kind_of?(Hash)
+
         if address = options[:billing_address]
           post[:card][:addressLine1] = address[:address1] if address[:address1]
           post[:card][:addressLine2] = address[:address2] if address[:address2]
@@ -214,6 +215,7 @@ module ActiveMerchant #:nodoc:
 
         params.map do |key, value|
           next if value.blank?
+
           if value.is_a?(Hash)
             h = {}
             value.each do |k, v|

data/lib/active_merchant/billing/gateways/skip_jack.rb

@@ -21,7 +21,7 @@ module ActiveMerchant #:nodoc:
 
       MONETARY_CHANGE_STATUSES = ['SETTLE', 'AUTHORIZE', 'AUTHORIZE ADDITIONAL', 'CREDIT', 'SPLITSETTLE']
 
-      CARD_CODE_ERRORS = %w( N S "" )
+      CARD_CODE_ERRORS = %w(N S "")
 
       CARD_CODE_MESSAGES = {
         'M' => 'Card verification number matched',
@@ -32,7 +32,7 @@ module ActiveMerchant #:nodoc:
         '' => 'Transaction failed because incorrect card verification number was entered or no number was entered'
       }
 
-      AVS_ERRORS = %w( A B C E I N O P R W Z )
+      AVS_ERRORS = %w(A B C E I N O P R W Z)
 
       AVS_MESSAGES = {
         'A' => 'Street address matches billing information, zip/postal code does not',
@@ -300,9 +300,9 @@ module ActiveMerchant #:nodoc:
         when :authorization
           parse_authorization_response(body)
         when :get_status
-          parse_status_response(body, [ :SerialNumber, :TransactionAmount, :TransactionStatusCode, :TransactionStatusMessage, :OrderNumber, :TransactionDateTime, :TransactionID, :ApprovalCode, :BatchNumber ])
+          parse_status_response(body, [:SerialNumber, :TransactionAmount, :TransactionStatusCode, :TransactionStatusMessage, :OrderNumber, :TransactionDateTime, :TransactionID, :ApprovalCode, :BatchNumber])
         else
-          parse_status_response(body, [ :SerialNumber, :TransactionAmount, :DesiredStatus, :StatusResponse, :StatusResponseMessage, :OrderNumber, :AuditID ])
+          parse_status_response(body, [:SerialNumber, :TransactionAmount, :DesiredStatus, :StatusResponse, :StatusResponseMessage, :OrderNumber, :AuditID])
         end
       end
 
@@ -329,7 +329,7 @@ module ActiveMerchant #:nodoc:
       def parse_status_response(body, response_keys)
         lines = split_lines(body)
 
-        keys = [ :szSerialNumber, :szErrorCode, :szNumberRecords]
+        keys = [:szSerialNumber, :szErrorCode, :szNumberRecords]
         values = split_line(lines[0])[0..2]
 
         result = Hash[*keys.zip(values).flatten]
@@ -434,6 +434,7 @@ module ActiveMerchant #:nodoc:
           return CARD_CODE_MESSAGES[response[:szCVV2ResponseCode]] if CARD_CODE_ERRORS.include?(response[:szCVV2ResponseCode])
           return AVS_MESSAGES[response[:szAVSResponseMessage]] if AVS_ERRORS.include?(response[:szAVSResponseCode])
           return RETURN_CODE_MESSAGES[response[:szReturnCode]] if response[:szReturnCode] != '1'
+
           return response[:szAuthorizationDeclinedMessage]
         end
       end

data/lib/active_merchant/billing/gateways/smart_ps.rb

@@ -3,7 +3,6 @@ require File.join(File.dirname(__FILE__), '..', 'check.rb')
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class SmartPs < Gateway #:nodoc:
-
       ##
       # This is the base gateway for processors who use the smartPS processing system
 

data/lib/active_merchant/billing/gateways/so_easy_pay.rb

@@ -189,7 +189,6 @@ module ActiveMerchant #:nodoc:
         end
         retval.target!
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/spreedly_core.rb

@@ -228,6 +228,7 @@ module ActiveMerchant #:nodoc:
 
       def extra_options_to_doc(doc, value)
         return doc.text value unless value.kind_of? Hash
+
         value.each do |k, v|
           doc.send(k) do
             extra_options_to_doc(doc, v)

data/lib/active_merchant/billing/gateways/stripe.rb

@@ -198,6 +198,7 @@ module ActiveMerchant #:nodoc:
         elsif payment.is_a?(Check)
           bank_token_response = tokenize_bank_account(payment)
           return bank_token_response unless bank_token_response.success?
+
           params = { source: bank_token_response.params['token']['id'] }
         else
           add_creditcard(params, payment, options)
@@ -431,6 +432,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, options)
         return unless post[:card]&.kind_of?(Hash)
+
         if address = options[:billing_address] || options[:address]
           post[:card][:address_line1] = address[:address1] if address[:address1]
           post[:card][:address_line2] = address[:address2] if address[:address2]
@@ -559,12 +561,14 @@ module ActiveMerchant #:nodoc:
 
       def post_data(params)
         return nil unless params
+
         flatten_params([], params).join('&')
       end
 
       def flatten_params(flattened, params, prefix = nil)
         params.each do |key, value|
           next if value != false && value.blank?
+
           flattened_key = prefix.nil? ? key : "#{prefix}[#{key}]"
           if value.is_a?(Hash)
             flatten_params(flattened, value, flattened_key)
@@ -608,6 +612,7 @@ module ActiveMerchant #:nodoc:
 
       def stripe_client_user_agent(options)
         return user_agent unless options[:application]
+
         JSON.dump(JSON.parse(user_agent).merge!({application: options[:application]}))
       end
 
@@ -761,6 +766,7 @@ module ActiveMerchant #:nodoc:
 
       def auth_minimum_amount(options)
         return 100 unless options[:currency]
+
         return MINIMUM_AUTHORIZE_AMOUNTS[options[:currency].upcase] || 100
       end
 
@@ -768,6 +774,7 @@ module ActiveMerchant #:nodoc:
         source_path ||= dest_path
         source_path.each do |key|
           return nil unless source[key]
+
           source = source[key]
         end
 

data/lib/active_merchant/billing/gateways/stripe_payment_intents.rb

@@ -5,7 +5,6 @@ module ActiveMerchant #:nodoc:
     # This gateway uses the current Stripe {Payment Intents API}[https://stripe.com/docs/api/payment_intents].
     # For the legacy API, see the Stripe gateway
     class StripePaymentIntentsGateway < StripeGateway
-
       self.supported_countries = %w(AT AU BE BR CA CH DE DK EE ES FI FR GB GR HK IE IT JP LT LU LV MX NL NO NZ PL PT SE SG SI SK US)
 
       ALLOWED_METHOD_STATES = %w[automatic manual].freeze
@@ -65,7 +64,7 @@ module ActiveMerchant #:nodoc:
 
       def update_intent(money, intent_id, payment_method, options = {})
         post = {}
-        post[:amount] = money if money
+        add_amount(post, money, options)
 
         add_payment_method_token(post, payment_method, options)
         add_payment_method_types(post, options)
@@ -91,7 +90,8 @@ module ActiveMerchant #:nodoc:
 
       def capture(money, intent_id, options = {})
         post = {}
-        post[:amount_to_capture] = money
+        currency = options[:currency] || currency(money)
+        post[:amount_to_capture] = localized_amount(money, currency)
         if options[:transfer_amount]
           post[:transfer_data] = {}
           post[:transfer_data][:amount] = options[:transfer_amount]
@@ -174,6 +174,7 @@ module ActiveMerchant #:nodoc:
 
       def add_return_url(post, options)
         return unless options[:confirm]
+
         post[:confirm] = options[:confirm]
         post[:return_url] = options[:return_url] if options[:return_url]
         post
@@ -211,19 +212,21 @@ module ActiveMerchant #:nodoc:
 
       def add_exemption(post, options = {})
         return unless options[:confirm]
+
         post[:payment_method_options] ||= {}
         post[:payment_method_options][:card] ||= {}
         post[:payment_method_options][:card][:moto] = true if options[:moto]
       end
 
       def setup_future_usage(post, options = {})
-        post[:setup_future_usage] = options[:setup_future_usage] if %w( on_session off_session ).include?(options[:setup_future_usage])
+        post[:setup_future_usage] = options[:setup_future_usage] if %w(on_session off_session).include?(options[:setup_future_usage])
         post[:off_session] = options[:off_session] if options[:off_session] && options[:confirm] == true
         post
       end
 
       def add_connected_account(post, options = {})
         return unless options[:transfer_destination]
+
         post[:transfer_data] = {}
         post[:transfer_data][:destination] = options[:transfer_destination]
         post[:transfer_data][:amount] = options[:transfer_amount] if options[:transfer_amount]
@@ -235,6 +238,7 @@ module ActiveMerchant #:nodoc:
 
       def add_billing_address(post, options = {})
         return unless billing = options[:billing_address] || options[:address]
+
         post[:billing_details] = {}
         post[:billing_details][:address] = {}
         post[:billing_details][:address][:city] = billing[:city] if billing[:city]
@@ -251,6 +255,7 @@ module ActiveMerchant #:nodoc:
 
       def add_shipping_address(post, options = {})
         return unless shipping = options[:shipping]
+
         post[:shipping] = {}
         post[:shipping][:address] = {}
         post[:shipping][:address][:line1] = shipping[:address][:line1]

data/lib/active_merchant/billing/gateways/swipe_checkout.rb

@@ -11,7 +11,7 @@ module ActiveMerchant #:nodoc:
 
       TRANSACTION_API = '/createShopifyTransaction.php'
 
-      self.supported_countries = %w[ NZ CA ]
+      self.supported_countries = %w[NZ CA]
       self.default_currency = 'NZD'
       self.supported_cardtypes = [:visa, :master]
       self.homepage_url = 'https://www.swipehq.com/checkout'

data/lib/active_merchant/billing/gateways/telr.rb

@@ -109,6 +109,7 @@ module ActiveMerchant #:nodoc:
 
       def add_payment_method(doc, payment_method, options)
         return if payment_method.is_a?(String)
+
         doc.card do
           doc.number(payment_method.number)
           doc.cvv(payment_method.verification_value)
@@ -121,6 +122,7 @@ module ActiveMerchant #:nodoc:
 
       def add_customer_data(doc, payment_method, options)
         return if payment_method.is_a?(String)
+
         doc.billing do
           doc.name do
             doc.first(payment_method.first_name)
@@ -140,6 +142,7 @@ module ActiveMerchant #:nodoc:
         doc.city(address[:city] || 'City')
         doc.line1(address[:address1] || 'Address')
         return unless address
+
         doc.line2(address[:address2]) if address[:address2]
         doc.zip(address[:zip]) if address[:zip]
         doc.region(address[:state]) if address[:state]

data/lib/active_merchant/billing/gateways/tns.rb

@@ -21,7 +21,6 @@ module ActiveMerchant
       self.supported_countries = %w(AR AU BR FR DE HK MX NZ SG GB US)
       self.default_currency = 'USD'
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb, :maestro]
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/trans_first.rb

@@ -133,6 +133,7 @@ module ActiveMerchant #:nodoc:
 
       def add_or_use_default(payment_data, default_value)
         return payment_data.capitalize if payment_data
+
         return default_value
       end
 

data/lib/active_merchant/billing/gateways/trans_first_transaction_express.rb

@@ -291,6 +291,7 @@ module ActiveMerchant #:nodoc:
         MultiResponse.run do |r|
           r.process { commit(:store, store_customer_request) }
           return r unless r.success? && r.params['custId']
+
           customer_id = r.params['custId']
 
           store_payment_method_request = build_xml_payment_storage_request do |doc|
@@ -384,6 +385,7 @@ module ActiveMerchant #:nodoc:
 
       def error_code_from(succeeded, response)
         return if succeeded
+
         response['errorCode'] || response['rspCode']
       end
 
@@ -548,7 +550,7 @@ module ActiveMerchant #:nodoc:
             doc['v1'].addrLn2 billing_address[:address2] unless billing_address[:address2].blank?
             doc['v1'].city billing_address[:city] if billing_address[:city]
             doc['v1'].state billing_address[:state] if billing_address[:state]
-            doc['v1'].zipCode billing_address[:zip] if billing_address[:zip]
+            doc['v1'].zipCode billing_address[:zip].delete('-') if billing_address[:zip]
             doc['v1'].ctry 'US'
           end
 
@@ -563,7 +565,7 @@ module ActiveMerchant #:nodoc:
               doc['v1'].addrLn2 shipping_address[:address2] unless shipping_address[:address2].blank?
               doc['v1'].city shipping_address[:city] if shipping_address[:city]
               doc['v1'].state shipping_address[:state] if shipping_address[:state]
-              doc['v1'].zipCode shipping_address[:zip] if shipping_address[:zip]
+              doc['v1'].zipCode shipping_address[:zip].delete('-') if shipping_address[:zip]
               doc['v1'].phone shipping_address[:phone].gsub(/\D/, '') if shipping_address[:phone]
               doc['v1'].email shipping_address[:email] if shipping_address[:email]
             end

data/lib/active_merchant/billing/gateways/transax.rb

@@ -16,7 +16,6 @@ module ActiveMerchant #:nodoc:
 
       # The name of the gateway
       self.display_name = 'NELiX TransaX'
-
     end
   end
 end