activemerchant 1.103.0 → 1.104.0

data/lib/active_merchant/billing/gateways/pay_gate_xml.rb

@@ -143,7 +143,7 @@ module ActiveMerchant #:nodoc:
         990028  => 'Transaction cancelled' # Customer clicks the 'Cancel' button on the payment page
       }
 
-      SUCCESS_CODES = %w( 990004 990005 990017 990012 990018 990031 )
+      SUCCESS_CODES = %w(990004 990005 990017 990012 990018 990031)
 
       TRANSACTION_CODES = {
         0 => 'Not Done',

data/lib/active_merchant/billing/gateways/pay_hub.rb

@@ -145,6 +145,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, address)
         return unless address
+
         post[:address1] = address[:address1]
         post[:address2] = address[:address2]
         post[:zip] = address[:zip]

data/lib/active_merchant/billing/gateways/pay_junction_v2.rb

@@ -168,6 +168,7 @@ module ActiveMerchant #:nodoc:
 
       def success_from(response)
         return response['response']['approved'] if response['response']
+
         false
       end
 

data/lib/active_merchant/billing/gateways/pay_secure.rb

@@ -79,7 +79,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_from(response)
-        [ response[:authnum], response[:transid] ].compact.join(';')
+        [response[:authnum], response[:transid]].compact.join(';')
       end
 
       def test_response?(response)

data/lib/active_merchant/billing/gateways/paybox_direct.rb

@@ -153,8 +153,10 @@ module ActiveMerchant #:nodoc:
         request_data = post_data(action, parameters)
         response = parse(ssl_post(test? ? self.test_url : self.live_url, request_data))
         response = parse(ssl_post(self.live_url_backup, request_data)) if service_unavailable?(response) && !test?
-        Response.new(success?(response), message_from(response), response.merge(
-          :timestamp => parameters[:dateq]),
+        Response.new(
+          success?(response),
+          message_from(response),
+          response.merge(:timestamp => parameters[:dateq]),
           :test => test?,
           :authorization => response[:numappel].to_s + response[:numtrans].to_s,
           :fraud_review => false,

data/lib/active_merchant/billing/gateways/payeezy.rb

@@ -305,6 +305,7 @@ module ActiveMerchant
 
       def post_data(params)
         return nil unless params
+
         params.reject { |k, v| v.blank? }.collect { |k, v| "#{k}=#{CGI.escape(v.to_s)}" }.join('&')
       end
 
@@ -335,6 +336,7 @@ module ActiveMerchant
 
       def error_code(response, success)
         return if success
+
         response['Error'].to_h['messages'].to_a.map { |e| e['code'] }.join(', ')
       end
 

data/lib/active_merchant/billing/gateways/payflow/payflow_common_api.rb

@@ -132,6 +132,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(xml, tag, address, options)
         return if address.nil?
+
         xml.tag! tag do
           xml.tag! 'Name', address[:name] unless address[:name].blank?
           xml.tag! 'EMail', options[:email] unless options[:email].blank?

data/lib/active_merchant/billing/gateways/payment_express.rb

@@ -13,9 +13,9 @@ module ActiveMerchant #:nodoc:
       # VISA, Mastercard, Diners Club and Farmers cards are supported
       #
       # However, regular accounts with DPS only support VISA and Mastercard
-      self.supported_cardtypes = [ :visa, :master, :american_express, :diners_club, :jcb ]
+      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb]
 
-      self.supported_countries = %w[ AU FJ GB HK IE MY NZ PG SG US ]
+      self.supported_countries = %w[AU FJ GB HK IE MY NZ PG SG US]
 
       self.homepage_url = 'http://www.paymentexpress.com/'
       self.display_name = 'PaymentExpress'

data/lib/active_merchant/billing/gateways/paymentez.rb

@@ -236,10 +236,13 @@ module ActiveMerchant #:nodoc:
       def card_success_from(response)
         return false if response.include?('error')
         return true if response['message'] == 'card deleted'
+
         response['card']['status'] == 'valid'
       end
 
       def message_from(response)
+        return response['detail'] if response['detail'].present?
+
         if !success_from(response) && response['error']
           response['error'] && response['error']['type']
         else
@@ -274,6 +277,7 @@ module ActiveMerchant #:nodoc:
 
       def error_code_from(response)
         return if success_from(response)
+
         if response['transaction']
           detail = response['transaction']['status_detail']
           return STANDARD_ERROR_CODE[STANDARD_ERROR_CODE_MAPPING[detail]] if STANDARD_ERROR_CODE_MAPPING.include?(detail)

data/lib/active_merchant/billing/gateways/paypal_digital_goods.rb

@@ -31,6 +31,7 @@ module ActiveMerchant #:nodoc:
       def build_setup_request(action, money, options)
         requires!(options, :items)
         raise ArgumentError, 'Must include at least 1 Item' unless options[:items].length > 0
+
         options[:items].each do |item|
           requires!(item, :name, :number, :quantity, :amount, :description, :category)
           raise ArgumentError, "Each of the items must have the category 'Digital'" unless item[:category] == 'Digital'
@@ -38,7 +39,6 @@ module ActiveMerchant #:nodoc:
 
         super
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/paystation.rb

@@ -1,7 +1,6 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PaystationGateway < Gateway
-
       self.live_url = self.test_url = 'https://www.paystation.co.nz/direct/paystation.dll'
 
       # an "error code" of "0" means "No error - transaction successful"
@@ -14,7 +13,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['NZ']
 
       # TODO: check this with paystation (amex and diners need to be enabled)
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club ]
+      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
 
       self.homepage_url        = 'http://paystation.co.nz'
       self.display_name        = 'Paystation'
@@ -195,7 +194,6 @@ module ActiveMerchant #:nodoc:
       def format_date(month, year)
         "#{format(year, :two_digits)}#{format(month, :two_digits)}"
       end
-
     end
 
     class PaystationResponse < Response

data/lib/active_merchant/billing/gateways/payu_in.rb

@@ -33,7 +33,7 @@ module ActiveMerchant #:nodoc:
 
         MultiResponse.run do |r|
           r.process { commit(url('purchase'), post) }
-          if(r.params['enrolled'].to_s == '0')
+          if r.params['enrolled'].to_s == '0'
             r.process { commit(r.params['post_uri'], r.params['form_post_vars']) }
           else
             r.process { handle_3dsecure(r) }

data/lib/active_merchant/billing/gateways/payu_latam.rb

@@ -180,6 +180,7 @@ module ActiveMerchant #:nodoc:
 
       def billing_address_fields(options)
         return unless address = options[:billing_address]
+
         billing_address = {}
         billing_address[:street1] = address[:address1]
         billing_address[:street2] = address[:address2]
@@ -217,6 +218,7 @@ module ActiveMerchant #:nodoc:
 
       def shipping_address_fields(options)
         return unless address = options[:shipping_address]
+
         shipping_address = {}
         shipping_address[:street1] = address[:address1]
         shipping_address[:street2] = address[:address2]
@@ -292,6 +294,7 @@ module ActiveMerchant #:nodoc:
 
       def add_process_without_cvv2(payment_method, options)
         return true if payment_method.verification_value.blank? && options[:cvv].blank?
+
         false
       end
 
@@ -379,10 +382,12 @@ module ActiveMerchant #:nodoc:
         case action
         when 'store'
           return response['code'] if success
+
           error_description = response['creditCardToken']['errorDescription'] if response['creditCardToken']
           response['error'] || error_description || 'FAILED'
         when 'verify_credentials'
           return 'VERIFIED' if success
+
           'FAILED'
         else
           if response['transactionResponse']
@@ -390,6 +395,7 @@ module ActiveMerchant #:nodoc:
             response_code = response['transactionResponse']['responseCode'] || response['transactionResponse']['pendingReason']
           end
           return response_code if success
+
           response['error'] || response_message || response_code || 'FAILED'
         end
       end

data/lib/active_merchant/billing/gateways/payway.rb

@@ -3,8 +3,8 @@ module ActiveMerchant
     class PaywayGateway < Gateway
       self.live_url = self.test_url = 'https://ccapi.client.qvalent.com/payway/ccapi'
 
-      self.supported_countries = [ 'AU' ]
-      self.supported_cardtypes = [ :visa, :master, :diners_club, :american_express, :bankcard ]
+      self.supported_countries = ['AU']
+      self.supported_cardtypes = [:visa, :master, :diners_club, :american_express, :bankcard]
       self.display_name        = 'Pay Way'
       self.homepage_url        = 'http://www.payway.com.au'
       self.default_currency    = 'AUD'
@@ -198,6 +198,7 @@ module ActiveMerchant
         )
       rescue ActiveMerchant::ResponseError => e
         raise unless e.response.code == '403'
+
         return Response.new(false, 'Invalid credentials', {}, :test => test?)
       rescue ActiveMerchant::ClientCertificateError
         return Response.new(false, 'Invalid certificate', {}, :test => test?)

data/lib/active_merchant/billing/gateways/pin.rb

@@ -101,6 +101,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, creditcard, options)
         return if creditcard.kind_of?(String)
+
         address = (options[:billing_address] || options[:address])
         return unless address
 

data/lib/active_merchant/billing/gateways/plugnpay.rb

@@ -16,7 +16,7 @@ module ActiveMerchant
         'U' => 'Issuer was not certified for card verification'
       }
 
-      CARD_CODE_ERRORS = %w( N S )
+      CARD_CODE_ERRORS = %w(N S)
 
       AVS_MESSAGES = {
         'A' => 'Street address matches billing information, zip/postal code does not',
@@ -34,7 +34,7 @@ module ActiveMerchant
         'Z' => '5-digit zip/postal code matches billing information, street address does not',
       }
 
-      AVS_ERRORS = %w( A E N R W Z )
+      AVS_ERRORS = %w(A E N R W Z)
 
       PAYMENT_GATEWAY_RESPONSES = {
         'P01' => 'AVS Mismatch Failure',
@@ -88,8 +88,8 @@ module ActiveMerchant
         :credit => 'newreturn'
       }
 
-      SUCCESS_CODES = [ 'pending', 'success' ]
-      FAILURE_CODES = [ 'badcard', 'fraud' ]
+      SUCCESS_CODES = ['pending', 'success']
+      FAILURE_CODES = ['badcard', 'fraud']
 
       self.default_currency = 'USD'
       self.supported_countries = ['US']

data/lib/active_merchant/billing/gateways/pro_pay.rb

@@ -284,6 +284,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(response)
         return 'Success' if success_from(response)
+
         message = STATUS_RESPONSE_CODES[response[:status]]
         message += " - #{TRANSACTION_RESPONSE_CODES[response[:response_code]]}" if response[:response_code]
 

data/lib/active_merchant/billing/gateways/psigate.rb

@@ -180,7 +180,7 @@ module ActiveMerchant #:nodoc:
           )
         end
 
-        if(address = (options[:billing_address] || options[:address]))
+        if (address = (options[:billing_address] || options[:address]))
           params[:Bname] = address[:name] || creditcard.name
           params[:Baddress1]    = address[:address1] unless address[:address1].blank?
           params[:Baddress2]    = address[:address2] unless address[:address2].blank?
@@ -210,6 +210,7 @@ module ActiveMerchant #:nodoc:
           return SUCCESS_MESSAGE
         else
           return FAILURE_MESSAGE if response[:errmsg].blank?
+
           return response[:errmsg].gsub(/[^\w]/, ' ').split.join(' ').capitalize
         end
       end

data/lib/active_merchant/billing/gateways/psl_card.rb

@@ -21,7 +21,7 @@ module ActiveMerchant
       # American Express, Diners Club, JCB, International Maestro,
       # Style, Clydesdale Financial Services, Other
 
-      self.supported_cardtypes = [ :visa, :master, :american_express, :diners_club, :jcb, :maestro ]
+      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb, :maestro]
       self.homepage_url = 'http://www.paymentsolutionsltd.com/'
       self.display_name = 'PSL Payment Solutions'
 

data/lib/active_merchant/billing/gateways/qbms.rb

@@ -11,8 +11,8 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://payments.intuit.com/'
       self.display_name = 'QuickBooks Merchant Services'
       self.default_currency = 'USD'
-      self.supported_cardtypes = [ :visa, :master, :discover, :american_express, :diners_club, :jcb ]
-      self.supported_countries = [ 'US' ]
+      self.supported_cardtypes = [:visa, :master, :discover, :american_express, :diners_club, :jcb]
+      self.supported_countries = ['US']
 
       TYPES = {
         :authorize => 'CustomerCreditCardAuth',

data/lib/active_merchant/billing/gateways/quantum.rb

@@ -270,7 +270,6 @@ module ActiveMerchant #:nodoc:
       def authorization_parts_from(authorization)
         authorization.split(/;/)
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/quickbooks.rb

@@ -240,6 +240,7 @@ module ActiveMerchant #:nodoc:
         return oauth_v2_headers if @options[:refresh_token]
 
         raise ArgumentError, "Invalid HTTP method: #{method}. Valid methods are :post and :get" unless [:post, :get].include?(method)
+
         request_uri = URI.parse(uri)
 
         # Following the guidelines from http://nouncer.com/oauth/authentication.html
@@ -285,6 +286,7 @@ module ActiveMerchant #:nodoc:
         return response unless @options[:refresh_token]
         return response unless options[:allow_refresh]
         return response unless response.params['code'] == 'AuthenticationFailed'
+
         refresh_access_token
         commit(endpoint, body)
       end

data/lib/active_merchant/billing/gateways/quickpay.rb

@@ -19,7 +19,6 @@ module ActiveMerchant #:nodoc:
           QuickpayV10Gateway.new(options)
         end
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/quickpay/quickpay_common.rb

@@ -140,11 +140,11 @@ module QuickpayCommon
     10 => {
       :authorize => %w(mobile_number acquirer autofee customer_id extras
                        zero_auth customer_ip),
-      :capture   => %w( extras ),
-      :cancel    => %w( extras ),
-      :refund    => %w( extras ),
-      :subscribe => %w( variables branding_id),
-      :authorize_subscription => %w( mobile_number acquirer customer_ip),
+      :capture   => %w(extras),
+      :cancel    => %w(extras),
+      :refund    => %w(extras),
+      :subscribe => %w(variables branding_id),
+      :authorize_subscription => %w(mobile_number acquirer customer_ip),
       :recurring => %w(auto_capture autofee zero_auth)
     }
   }

data/lib/active_merchant/billing/gateways/quickpay/quickpay_v10.rb

@@ -249,6 +249,7 @@ module ActiveMerchant
 
       def map_address(address)
         return {} if address.nil?
+
         requires!(address, :name, :address1, :city, :zip, :country)
         country = Country.find(address[:country])
         mapped = {

data/lib/active_merchant/billing/gateways/quickpay/quickpay_v4to7.rb

@@ -141,6 +141,7 @@ module ActiveMerchant #:nodoc:
 
       def add_testmode(post)
         return if post[:transaction].present?
+
         post[:testmode] = test? ? '1' : '0'
       end
 

data/lib/active_merchant/billing/gateways/qvalent.rb

@@ -147,6 +147,7 @@ module ActiveMerchant #:nodoc:
 
       def stored_credential_usage(post, payment_method, options)
         return unless payment_method.brand == 'visa'
+
         stored_credential = options[:stored_credential]
         if stored_credential[:initial_transaction]
           post['card.storedCredentialUsage'] = 'INITIAL_STORAGE'
@@ -222,6 +223,7 @@ module ActiveMerchant #:nodoc:
 
       def cvv_result(succeeded, raw)
         return unless succeeded
+
         code = CVV_CODE_MAPPING[raw['response.cvnResponse']] || raw['response.cvnResponse']
         CVVResult.new(code)
       end

data/lib/active_merchant/billing/gateways/realex.rb

@@ -31,7 +31,7 @@ module ActiveMerchant
 
       self.money_format = :cents
       self.default_currency = 'EUR'
-      self.supported_cardtypes = [ :visa, :master, :american_express, :diners_club ]
+      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
       self.supported_countries = %w(IE GB FR BE NL LU IT US CA ES)
       self.homepage_url = 'http://www.realexpayments.com/'
       self.display_name = 'Realex'
@@ -268,6 +268,7 @@ module ActiveMerchant
 
       def add_comments(xml, options)
         return unless options[:description]
+
         xml.tag! 'comments' do
           xml.tag! 'comment', options[:description], 'id' => 1
         end
@@ -305,6 +306,7 @@ module ActiveMerchant
 
       def add_three_d_secure(xml, options)
         return unless three_d_secure = options[:three_d_secure]
+
         version = three_d_secure.fetch(:version, '')
         xml.tag! 'mpi' do
           if version =~ /^2/

data/lib/active_merchant/billing/gateways/redsys.rb

@@ -36,7 +36,7 @@ module ActiveMerchant #:nodoc:
     #
     #
     class RedsysGateway < Gateway
-      self.live_url = 'https://sis.sermepa.es/sis/operaciones'
+      self.live_url = 'https://sis.redsys.es/sis/operaciones'
       self.test_url = 'https://sis-t.redsys.es:25443/sis/operaciones'
 
       self.supported_countries = ['ES']
@@ -44,7 +44,7 @@ module ActiveMerchant #:nodoc:
       self.money_format        = :cents
 
       # Not all card types may be activated by the bank!
-      self.supported_cardtypes = [:visa, :master, :american_express, :jcb, :diners_club]
+      self.supported_cardtypes = [:visa, :master, :american_express, :jcb, :diners_club, :unionpay]
       self.homepage_url        = 'http://www.redsys.es/'
       self.display_name        = 'Redsys'
 
@@ -521,6 +521,7 @@ module ActiveMerchant #:nodoc:
       def currency_code(currency)
         return currency if currency =~ /^\d+$/
         raise ArgumentError, "Unknown currency #{currency}" unless CURRENCY_CODES[currency]
+
         CURRENCY_CODES[currency]
       end