activemerchant 1.103.0 → 1.104.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a51e307707d9ffa9cd0d32779623b7095ea9af27f16078de9736be65fc8c0090
-  data.tar.gz: 27b16b69f6bb974795ddc1fae4d924257bee5c0620d0ab009b771b107d59be24
+  metadata.gz: e9ceb4b2da9006abdfcab980341c407f7b718ae35a424fc1e597c3cf2b189271
+  data.tar.gz: 19fe8973c00605d460cd56bcc8d0148cfa8ad7af9a33d07c9f2759da56dc5684
 SHA512:
-  metadata.gz: 6d0e03c0a615dabf2ef0299baaac647eabe906f08bfbb3343e545d3a7ee1390678a963a4a1433b24cb478264b7ad260a30c947d827e91e835f6892ca31644399
-  data.tar.gz: db9a355a166614c1ebe4b018ba1a5634448bd5be14aa34e9db55837d529b1aad4f10994cf476793e38619fb7d8c7785ab014b5dac4d2a33bcea3720da8a98689
+  metadata.gz: 94d123473e989145c5d9a34294718cc8913d231c72b415bd0398e88cfefdc81b1cd9070eaf14648be6c723de201785920de8479b8ef997454df194cfaa4f7734
+  data.tar.gz: 9567e118dd21f0779d5a8bd228ab385f2378c338f838fe027ed6ad6a245a86362fd786d91aa53cbaa65b31d3817efdc8ca299ff84f44f182140ff43018cd6f7c

data/CHANGELOG

@@ -2,6 +2,46 @@
 
 == HEAD
 
+== Version 1.104.0 (Jan 29, 2020)
+* Adyen: add `recurring_contract_type` GSF [therufs] #3460
+* Credorax: Only pass `3ds_version` parameter when required [britth] #3458
+* EBANX: Include Peru in supported countries [Ruanito] #3443
+* Bluesnap: include fraud data in response message [therufs] #3459
+* Ingenico GlobalCollect: support `airline_data` and related GSFs [therufs] #3461
+* Add UnionPay card type [leila-alderman] #3464
+* Braintree: Fix add_credit_card_to_customer in Store [molbrown] #3466
+* EBANX: Default to not send amount on capture [chinhle23] #3463
+* Latitude19: Convert money format to dollars [molbrown] #3468
+* Adyen: Fix response success for unstore [kheang] #3470
+* CyberSource: add several GSFs [therufs] #3465
+* Adyen: add `recurring_contract_type` GSF to auth [therufs] #3471
+* Stripe Payment Intents: Use localized_amount on capture [molbrown] #3475
+* dLocal: Add support for installments [kdelemme] #3456
+* Merchant Warrior: Add void operation [leila-alderman] #3474
+* Decidir: Update payment method IDs [leila-alderman] #3476
+* Adyen: Add delivery address [leila-alderman] #3477
+* Authorize.net: Correctly parse direct_response field with quotation marks [britth] #3479
+* Decidir: Add debit card payment method IDs [leila-alderman] #3480
+* CyberSource: Add issuer data+MDD to credit & void [leila-alderman] #3481
+* Credorax: add `authorization_type` and `multiple_capture_count` GSFs [therufs] #3478
+* CardStream: use localized_amount to correctly support zero-decimal currencies [britth] #3473
+* EBANX: Add additional data in post [Ruanito] #3482
+* Credorax: Omit phone when nil [leila-alderman] #3490
+* TransFirst TrExp: Remove hyphens from zip [leila-alderman] #3483
+* Mundipagg: Return acquirer code as the error code [leila-alderman] #3492
+* Braintree Blue: Remove customer hash when using a payment_method_nonce #3495
+* Credorax: Update non-standard currencies list [chinhle23] #3499
+* Redsys: Update production URL [britth] #3505
+* Moneris: include AVS and CoF fields when storing vault records [alexdunae] #3446
+* Moneris: Add support for temporary vault storage [alexdunae] #3446
+* Clearhaus: Update currencies without fractions list [chinhle23] #3506
+* Merchant Warrior: Add recurringFlag to purchase & authorize [carrigan] #3504
+* CardConnect: Remove domain port validation [leila-alderman] #3494
+* Paymentez: Correct refund and void message parsing [carrigan] #3509
+* Mercado Pago: Add taxes and net_amount gateway specific fields [carrigan] #3512
+* Moneris: use dedicated card_verification methods [alexdunae] #3428
+* Authorize.net: Trim down supported countries [fatcatt316] #3511
+
 == Version 1.103.0 (Dec 2, 2019)
 * Quickbooks: Mark transactions that returned `AuthorizationFailed` as failures [britth] #3447
 * Credorax: Add referral CFT transactions [leila-alderman] #3432
@@ -56,6 +96,7 @@
 * Rubocop: Layout/MultilineHashBraceLayout [nfarve] #3385
 * CardConnect: Always include additional_data in purchase [therufs] #3387
 * CardConnect: Add user_fields GSF [therufs] #3388
+* Moneris: Add support for stored credentials [chinhle23] #3384
 
 == Version 1.99.0 (Sep 26, 2019)
 * Adyen: Add functionality to set 3DS exemptions via API [britth] #3331

data/lib/active_merchant.rb

@@ -52,7 +52,7 @@ require 'active_merchant/country'
 module ActiveMerchant
   def self.deprecated(message, caller=Kernel.caller[1])
     warning = caller + ': ' + message
-    if(respond_to?(:logger) && logger.present?)
+    if respond_to?(:logger) && logger.present?
       logger.warn(warning)
     else
       warn(warning)

data/lib/active_merchant/billing/avs_result.rb

@@ -39,10 +39,10 @@ module ActiveMerchant
 
       # Map vendor's AVS result code to a postal match code
       POSTAL_MATCH_CODE = {
-        'Y' => %w( D H F H J L M P Q V W X Y Z ),
-        'N' => %w( A C K N O ),
-        'X' => %w( G S ),
-        nil => %w( B E I R T U )
+        'Y' => %w(D H F H J L M P Q V W X Y Z),
+        'N' => %w(A C K N O),
+        'X' => %w(G S),
+        nil => %w(B E I R T U)
       }.inject({}) do |map, (type, codes)|
         codes.each { |code| map[code] = type }
         map
@@ -50,10 +50,10 @@ module ActiveMerchant
 
       # Map vendor's AVS result code to a street match code
       STREET_MATCH_CODE = {
-        'Y' => %w( A B D H J M O Q T V X Y ),
-        'N' => %w( C K L N W Z ),
-        'X' => %w( G S ),
-        nil => %w( E F I P R U )
+        'Y' => %w(A B D H J M O Q T V X Y),
+        'N' => %w(C K L N W Z),
+        'X' => %w(G S),
+        nil => %w(E F I P R U)
       }.inject({}) do |map, (type, codes)|
         codes.each { |code| map[code] = type }
         map

data/lib/active_merchant/billing/compatibility.rb

@@ -98,7 +98,8 @@ module ActiveMerchant
             result = []
 
             self.each do |key, messages|
-              next unless(messages && !messages.empty?)
+              next unless messages && !messages.empty?
+
               if key == 'base'
                 result << messages.first.to_s
               else

data/lib/active_merchant/billing/credit_card.rb

@@ -22,6 +22,7 @@ module ActiveMerchant #:nodoc:
     # * Alelo
     # * Cabal
     # * Naranja
+    # * UnionPay
     #
     # For testing purposes, use the 'bogus' credit card brand. This skips the vast majority of
     # validations, allowing you to focus on your core concerns until you're ready to be more concerned
@@ -96,6 +97,7 @@ module ActiveMerchant #:nodoc:
       # * +'alelo'+
       # * +'cabal'+
       # * +'naranja'+
+      # * +'union_pay'+
       #
       # Or, if you wish to test your implementation, +'bogus'+.
       #
@@ -327,7 +329,7 @@ module ActiveMerchant #:nodoc:
           errors << [:last_name,  'cannot be empty'] if last_name.blank?
         end
 
-        if(empty?(month) || empty?(year))
+        if empty?(month) || empty?(year)
           errors << [:month, 'is required'] if empty?(month)
           errors << [:year,  'is required'] if empty?(year)
         else

data/lib/active_merchant/billing/credit_card_methods.rb

@@ -18,6 +18,7 @@ module ActiveMerchant #:nodoc:
         'sodexo'             => ->(num) { num =~ /^(606071|603389|606070|606069|606068|600818)\d{10}$/ },
         'vr'                 => ->(num) { num =~ /^(627416|637036)\d{10}$/ },
         'cabal'              => ->(num) { num&.size == 16 && in_bin_range?(num.slice(0, 8), CABAL_RANGES) },
+        'unionpay'           => ->(num) { (16..19).cover?(num&.size) && in_bin_range?(num.slice(0, 8), UNIONPAY_RANGES) },
         'carnet'             => lambda { |num|
           num&.size == 16 && (
             in_bin_range?(num.slice(0, 6), CARNET_RANGES) ||
@@ -123,6 +124,14 @@ module ActiveMerchant #:nodoc:
         589562..589562
       ]
 
+      # In addition to the BIN ranges listed here that all begin with 81, UnionPay cards
+      # include many ranges that start with 62.
+      # Prior to adding UnionPay, cards that start with 62 were all classified as Discover.
+      # Because UnionPay cards are able to run on Discover rails, this was kept the same.
+      UNIONPAY_RANGES = [
+        81000000..81099999, 81100000..81319999, 81320000..81519999, 81520000..81639999, 81640000..81719999
+      ]
+
       def self.included(base)
         base.extend(ClassMethods)
       end
@@ -238,6 +247,7 @@ module ActiveMerchant #:nodoc:
 
         def last_digits(number)
           return '' if number.nil?
+
           number.length <= 4 ? number : number.slice(-4..-1)
         end
 
@@ -259,11 +269,13 @@ module ActiveMerchant #:nodoc:
 
         def valid_card_number_length?(number) #:nodoc:
           return false if number.nil?
+
           number.length >= 12
         end
 
         def valid_card_number_characters?(number) #:nodoc:
           return false if number.nil?
+
           !number.match(/\D/)
         end
 

data/lib/active_merchant/billing/cvv_result.rb

@@ -4,7 +4,6 @@ module ActiveMerchant
     # http://www.bbbonline.org/eExport/doc/MerchantGuide_cvv2.pdf
     # Check additional codes from cybersource website
     class CVVResult
-
       MESSAGES = {
         'D'  =>  'CVV check flagged transaction as suspicious',
         'I'  =>  'CVV failed data validation check',

data/lib/active_merchant/billing/gateway.rb

@@ -249,6 +249,7 @@ module ActiveMerchant #:nodoc:
 
       def amount(money)
         return nil if money.nil?
+
         cents =
           if money.respond_to?(:cents)
             ActiveMerchant.deprecated 'Support for Money objects is deprecated and will be removed from a future release of ActiveMerchant. Please use an Integer value in cents'
@@ -278,6 +279,7 @@ module ActiveMerchant #:nodoc:
         amount = amount(money)
 
         return amount unless non_fractional_currency?(currency) || three_decimal_currency?(currency)
+
         if non_fractional_currency?(currency)
           if self.money_format == :cents
             sprintf('%.0f', amount.to_f / 100)
@@ -299,6 +301,7 @@ module ActiveMerchant #:nodoc:
 
       def truncate(value, max_size)
         return nil unless value
+
         value.to_s[0, max_size]
       end
 

data/lib/active_merchant/billing/gateways/adyen.rb

@@ -1,7 +1,6 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class AdyenGateway < Gateway
-
       # we recommend setting up merchant-specific endpoints.
       # https://docs.adyen.com/developers/api-manual#apiendpoints
       self.test_url = 'https://pal-test.adyen.com/pal/servlet/'
@@ -10,7 +9,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = %w(AT AU BE BG BR CH CY CZ DE DK EE ES FI FR GB GI GR HK HU IE IS IT LI LT LU LV MC MT MX NL NO PL PT RO SE SG SK SI US)
       self.default_currency = 'USD'
       self.currencies_without_fractions = %w(CVE DJF GNF IDR JPY KMF KRW PYG RWF UGX VND VUV XAF XOF XPF)
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb, :dankort, :maestro, :discover, :elo, :naranja, :cabal]
+      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb, :dankort, :maestro, :discover, :elo, :naranja, :cabal, :unionpay]
 
       self.money_format = :cents
 
@@ -51,7 +50,7 @@ module ActiveMerchant #:nodoc:
         requires!(options, :order_id)
         post = init_post(options)
         add_invoice(post, money, options)
-        add_payment(post, payment)
+        add_payment(post, payment, options)
         add_extra_data(post, payment, options)
         add_stored_credentials(post, payment, options)
         add_address(post, options)
@@ -59,6 +58,7 @@ module ActiveMerchant #:nodoc:
         add_3ds(post, options)
         add_3ds_authenticated_data(post, options)
         add_splits(post, options)
+        add_recurring_contract(post, options)
         commit('authorise', post, options)
       end
 
@@ -96,12 +96,14 @@ module ActiveMerchant #:nodoc:
         requires!(options, :order_id)
         post = init_post(options)
         add_invoice(post, 0, options)
-        add_payment(post, credit_card)
+        add_payment(post, credit_card, options)
         add_extra_data(post, credit_card, options)
         add_stored_credentials(post, credit_card, options)
-        add_recurring_contract(post, options)
         add_address(post, options)
 
+        options[:recurring_contract_type] ||= 'RECURRING'
+        add_recurring_contract(post, options)
+
         action = options[:tokenize_only] ? 'storeToken' : 'authorise'
 
         initial_response = commit(action, post, options)
@@ -226,6 +228,7 @@ module ActiveMerchant #:nodoc:
 
       def add_splits(post, options)
         return unless split_data = options[:splits]
+
         splits = []
         split_data.each do |split|
           amount = {
@@ -269,6 +272,7 @@ module ActiveMerchant #:nodoc:
 
       def add_recurring_processing_model(post, options)
         return unless options.dig(:stored_credential, :reason_type) || options[:recurring_processing_model]
+
         if options.dig(:stored_credential, :reason_type) && options[:stored_credential][:reason_type] == 'unscheduled'
           recurring_processing_model = 'CardOnFile'
         else
@@ -279,7 +283,17 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_address(post, options)
+        if address = options[:shipping_address]
+          post[:deliveryAddress] = {}
+          post[:deliveryAddress][:street] = address[:address1] || 'NA'
+          post[:deliveryAddress][:houseNumberOrName] = address[:address2] || 'NA'
+          post[:deliveryAddress][:postalCode] = address[:zip] if address[:zip]
+          post[:deliveryAddress][:city] = address[:city] || 'NA'
+          post[:deliveryAddress][:stateOrProvince] = get_state(address)
+          post[:deliveryAddress][:country] = address[:country] if address[:country]
+        end
         return unless post[:card]&.kind_of?(Hash)
+
         if (address = options[:billing_address] || options[:address]) && address[:country]
           post[:billingAddress] = {}
           post[:billingAddress][:street] = address[:address1] || 'NA'
@@ -313,11 +327,11 @@ module ActiveMerchant #:nodoc:
         post[:modificationAmount] = amount
       end
 
-      def add_payment(post, payment)
+      def add_payment(post, payment, options)
         if payment.is_a?(String)
           _, _, recurring_detail_reference = payment.split('#')
           post[:selectedRecurringDetailReference] = recurring_detail_reference
-          add_recurring_contract(post, options)
+          options[:recurring_contract_type] ||= 'RECURRING'
         else
           add_mpi_data_for_network_tokenization_card(post, payment) if payment.is_a?(NetworkTokenizationCreditCard)
           add_card(post, payment)
@@ -341,6 +355,7 @@ module ActiveMerchant #:nodoc:
 
       def capture_options(options)
         return options.merge(idempotency_key: "#{options[:idempotency_key]}-cap") if options[:idempotency_key]
+
         options
       end
 
@@ -367,8 +382,10 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_recurring_contract(post, options = {})
+        return unless options[:recurring_contract_type]
+
         recurring = {
-          contract: 'RECURRING'
+          contract: options[:recurring_contract_type]
         }
 
         post[:recurring] = recurring
@@ -396,6 +413,7 @@ module ActiveMerchant #:nodoc:
           end
         else
           return unless options[:execute_threed] || options[:threed_dynamic]
+
           post[:browserInfo] = { userAgent: options[:user_agent], acceptHeader: options[:accept_header] }
           post[:additionalData] = { executeThreeD: 'true' } if options[:execute_threed]
         end
@@ -424,7 +442,7 @@ module ActiveMerchant #:nodoc:
       def add_3ds2_authenticated_data(post, options)
         three_d_secure_options = options[:three_d_secure]
         # If the transaction was authenticated in a frictionless flow, send the transStatus from the ARes.
-        if(three_d_secure_options[:authentication_response_status].nil?)
+        if three_d_secure_options[:authentication_response_status].nil?
           authentication_response = three_d_secure_options[:directory_response_status]
         else
           authentication_response = three_d_secure_options[:authentication_response_status]
@@ -441,6 +459,7 @@ module ActiveMerchant #:nodoc:
 
       def parse(body)
         return {} if body.blank?
+
         JSON.parse(body)
       end
 
@@ -511,6 +530,8 @@ module ActiveMerchant #:nodoc:
           response['response'] == 'Authorised' || response['response'] == '[adjustAuthorisation-received]'
         when 'storeToken'
           response['result'] == 'Success'
+        when 'disable'
+          response['response'] == '[detail-successfully-disabled]'
         else
           false
         end
@@ -518,6 +539,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(action, response)
         return authorize_message_from(response) if action.to_s == 'authorise' || action.to_s == 'authorise3d'
+
         response['response'] || response['message'] || response['result']
       end
 
@@ -555,6 +577,7 @@ module ActiveMerchant #:nodoc:
 
       def add_browser_info(browser_info, post)
         return unless browser_info
+
         post[:browserInfo] = {
           acceptHeader: browser_info[:accept_header],
           colorDepth: browser_info[:depth],

data/lib/active_merchant/billing/gateways/allied_wallet.rb

@@ -141,7 +141,8 @@ module ActiveMerchant #:nodoc:
           raw_response = ssl_post(url(action), post.to_json, headers)
           response = parse(raw_response)
         rescue ResponseError => e
-          raise unless(e.response.code.to_s =~ /4\d\d/)
+          raise unless e.response.code.to_s =~ /4\d\d/
+
           response = parse(e.response.body)
         end
 
@@ -199,7 +200,6 @@ module ActiveMerchant #:nodoc:
           response['message'] || 'Unable to read error message'
         end
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/authorize_net.rb

@@ -8,7 +8,7 @@ module ActiveMerchant
       self.test_url = 'https://apitest.authorize.net/xml/v1/request.api'
       self.live_url = 'https://api2.authorize.net/xml/v1/request.api'
 
-      self.supported_countries = %w(AD AT AU BE BG CA CH CY CZ DE DK EE ES FI FR GB GI GR HU IE IL IS IT LI LT LU LV MC MT NL NO PL PT RO SE SI SK SM TR US VA)
+      self.supported_countries = %w(AU CA US)
       self.default_currency = 'USD'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb, :maestro]
@@ -390,6 +390,7 @@ module ActiveMerchant
 
       def add_payment_source(xml, source, options, action = nil)
         return unless source
+
         if source.is_a?(String)
           add_token_payment_method(xml, source, options)
         elsif card_brand(source) == 'check'
@@ -517,6 +518,7 @@ module ActiveMerchant
 
       def add_market_type_device_type(xml, payment, options)
         return if payment.is_a?(String) || card_brand(payment) == 'check' || card_brand(payment) == 'apple_pay'
+
         if valid_track_data
           xml.retail do
             xml.marketType(options[:market_type] || MARKET_TYPE[:retail])
@@ -841,17 +843,17 @@ module ActiveMerchant
 
         response = {action: action}
 
-        response[:response_code] = if(element = doc.at_xpath('//transactionResponse/responseCode'))
+        response[:response_code] = if (element = doc.at_xpath('//transactionResponse/responseCode'))
                                      empty?(element.content) ? nil : element.content.to_i
                                    end
 
-        if(element = doc.at_xpath('//errors/error'))
+        if (element = doc.at_xpath('//errors/error'))
           response[:response_reason_code] = element.at_xpath('errorCode').content[/0*(\d+)$/, 1]
           response[:response_reason_text] = element.at_xpath('errorText').content.chomp('.')
-        elsif(element = doc.at_xpath('//transactionResponse/messages/message'))
+        elsif (element = doc.at_xpath('//transactionResponse/messages/message'))
           response[:response_reason_code] = element.at_xpath('code').content[/0*(\d+)$/, 1]
           response[:response_reason_text] = element.at_xpath('description').content.chomp('.')
-        elsif(element = doc.at_xpath('//messages/message'))
+        elsif (element = doc.at_xpath('//messages/message'))
           response[:response_reason_code] = element.at_xpath('code').content[/0*(\d+)$/, 1]
           response[:response_reason_text] = element.at_xpath('text').content.chomp('.')
         else
@@ -860,7 +862,7 @@ module ActiveMerchant
         end
 
         response[:avs_result_code] =
-          if(element = doc.at_xpath('//avsResultCode'))
+          if (element = doc.at_xpath('//avsResultCode'))
             empty?(element.content) ? nil : element.content
           end
 
@@ -960,7 +962,7 @@ module ActiveMerchant
         if response[:response_code] == DECLINED
           if CARD_CODE_ERRORS.include?(cvv_result.code)
             return cvv_result.message
-          elsif(AVS_REASON_CODES.include?(response[:response_reason_code]) && AVS_ERRORS.include?(avs_result.code))
+          elsif AVS_REASON_CODES.include?(response[:response_reason_code]) && AVS_ERRORS.include?(avs_result.code)
             return avs_result.message
           end
         end
@@ -1007,7 +1009,7 @@ module ActiveMerchant
       end
 
       def parse_direct_response_elements(response, options)
-        params = response[:direct_response]
+        params = response[:direct_response]&.tr('"', '')
         return {} unless params
 
         parts = params.split(options[:delimiter] || ',')
@@ -1059,7 +1061,6 @@ module ActiveMerchant
           balance_on_card: parts[54] || '',
         }
       end
-
     end
   end
 end