activemerchant 1.103.0 → 1.104.0

data/lib/active_merchant/billing/gateways/d_local.rb

@@ -89,6 +89,7 @@ module ActiveMerchant #:nodoc:
 
       def add_country(post, card, options)
         return unless address = options[:billing_address] || options[:address]
+
         post[:country] = lookup_country_code(address[:country])
       end
 
@@ -111,6 +112,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, card, options)
         return unless address = options[:billing_address] || options[:address]
+
         address_object = {}
         address_object[:state] = address[:state] if address[:state]
         address_object[:city] = address[:city] if address[:city]
@@ -129,6 +131,8 @@ module ActiveMerchant #:nodoc:
         post[:card][:cvv] = card.verification_value
         post[:card][:descriptor] = options[:dynamic_descriptor] if options[:dynamic_descriptor]
         post[:card][:capture] = (action == 'purchase')
+        post[:card][:installments] = options[:installments] if options[:installments]
+        post[:card][:installments_id] = options[:installments_id] if options[:installments_id]
       end
 
       def parse(body)
@@ -163,6 +167,7 @@ module ActiveMerchant #:nodoc:
       # we count 100 as a success.
       def success_from(action, response)
         return false unless response['status_code']
+
         ['100', '200', '400', '600'].include? response['status_code'].to_s
       end
 
@@ -176,6 +181,7 @@ module ActiveMerchant #:nodoc:
 
       def error_code_from(action, response)
         return if success_from(action, response)
+
         code = response['status_code'] || response['code']
         code&.to_s
       end

data/lib/active_merchant/billing/gateways/data_cash.rb

@@ -6,7 +6,7 @@ module ActiveMerchant
       self.default_currency = 'GBP'
       self.supported_countries = ['GB']
 
-      self.supported_cardtypes = [ :visa, :master, :american_express, :discover, :diners_club, :jcb, :maestro ]
+      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb, :maestro]
 
       self.homepage_url = 'http://www.datacash.com/'
       self.display_name = 'DataCash'

data/lib/active_merchant/billing/gateways/decidir.rb

@@ -106,7 +106,7 @@ module ActiveMerchant #:nodoc:
       private
 
       def add_auth_purchase_params(post, money, credit_card, options)
-        post[:payment_method_id] = add_payment_method_id(credit_card)
+        post[:payment_method_id] = add_payment_method_id(credit_card, options)
         post[:site_transaction_id] = options[:order_id]
         post[:bin] = credit_card.number[0..5]
         post[:payment_type] = options[:payment_type] || 'single'
@@ -119,9 +119,25 @@ module ActiveMerchant #:nodoc:
         add_payment(post, credit_card, options)
       end
 
-      def add_payment_method_id(credit_card)
+      def add_payment_method_id(credit_card, options)
         if options[:payment_method_id]
           options[:payment_method_id].to_i
+        elsif options[:debit]
+          if CreditCard.brand?(credit_card.number) == 'visa'
+            31
+          elsif CreditCard.brand?(credit_card.number) == 'master'
+            105
+          elsif CreditCard.brand?(credit_card.number) == 'maestro'
+            106
+          elsif CreditCard.brand?(credit_card.number) == 'cabal'
+            108
+          end
+        elsif CreditCard.brand?(credit_card.number) == 'master'
+          104
+        elsif CreditCard.brand?(credit_card.number) == 'american_express'
+          65
+        elsif CreditCard.brand?(credit_card.number) == 'diners_club'
+          8
         elsif CreditCard.brand?(credit_card.number) == 'cabal'
           63
         elsif CreditCard.brand?(credit_card.number) == 'naranja'

data/lib/active_merchant/billing/gateways/digitzs.rb

@@ -188,6 +188,7 @@ module ActiveMerchant #:nodoc:
         response = parse(ssl_get(url + "/customers/#{options[:customer_id]}", headers(options)))
 
         return response.try(:[], 'data').try(:[], 'customerId') if success_from(response)
+
         return nil
       end
 
@@ -228,6 +229,7 @@ module ActiveMerchant #:nodoc:
       def message_from(response)
         return response['message'] if response['message']
         return 'Success' if success_from(response)
+
         response['errors'].map { |error_hash| error_hash['detail'] }.join(', ')
       end
 
@@ -276,6 +278,7 @@ module ActiveMerchant #:nodoc:
         return 'cardSplit' if options[:payment_type] == 'card_split'
         return 'tokenSplit' if options[:payment_type] == 'token_split'
         return 'token' if payment.is_a? String
+
         'card'
       end
 

data/lib/active_merchant/billing/gateways/ebanx.rb

@@ -4,7 +4,7 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://sandbox.ebanxpay.com/ws/'
       self.live_url = 'https://api.ebanxpay.com/ws/'
 
-      self.supported_countries = ['BR', 'MX', 'CO', 'CL', 'AR']
+      self.supported_countries = %w(BR MX CO CL AR PE)
       self.default_currency = 'USD'
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club]
 
@@ -51,6 +51,7 @@ module ActiveMerchant #:nodoc:
         add_card_or_token(post, payment)
         add_address(post, options)
         add_customer_responsible_person(post, payment, options)
+        add_additional_data(post, options)
 
         commit(:purchase, post)
       end
@@ -73,7 +74,7 @@ module ActiveMerchant #:nodoc:
         post = {}
         add_integration_key(post)
         post[:hash] = authorization
-        post[:amount] = amount(money)
+        post[:amount] = amount(money) if options[:include_capture_amount].to_s == 'true'
 
         commit(:capture, post)
       end
@@ -198,6 +199,10 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_additional_data(post, options)
+        post[:device_id] = options[:device_id] if options[:device_id]
+      end
+
       def parse(body)
         JSON.parse(body)
       end
@@ -234,6 +239,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(response)
         return response['status_message'] if response['status'] == 'ERROR'
+
         response.try(:[], 'payment').try(:[], 'transaction_status').try(:[], 'description')
       end
 
@@ -248,22 +254,26 @@ module ActiveMerchant #:nodoc:
       def post_data(action, parameters = {})
         return nil if requires_http_get(action)
         return convert_to_url_form_encoded(parameters) if action == :refund
+
         "request_body=#{parameters.to_json}"
       end
 
       def url_for(hostname, action, parameters)
         return "#{hostname}#{URL_MAP[action]}?#{convert_to_url_form_encoded(parameters)}" if requires_http_get(action)
+
         "#{hostname}#{URL_MAP[action]}"
       end
 
       def requires_http_get(action)
         return true if [:capture, :void].include?(action)
+
         false
       end
 
       def convert_to_url_form_encoded(parameters)
         parameters.map do |key, value|
           next if value != false && value.blank?
+
           "#{key}=#{value}"
         end.compact.join('&')
       end
@@ -271,6 +281,7 @@ module ActiveMerchant #:nodoc:
       def error_code_from(response, success)
         unless success
           return response['status_code'] if response['status'] == 'ERROR'
+
           response.try(:[], 'payment').try(:[], 'transaction_status').try(:[], 'code')
         end
       end

data/lib/active_merchant/billing/gateways/efsnet.rb

@@ -158,7 +158,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_from(response, params)
-        [ response[:transaction_id], params[:transaction_amount] ].compact.join(';')
+        [response[:transaction_id], params[:transaction_amount]].compact.join(';')
       end
 
       def parse(xml)
@@ -190,6 +190,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(message)
         return 'Unspecified error' if message.blank?
+
         message.gsub(/[^\w]/, ' ').split.join(' ').capitalize
       end
 
@@ -197,7 +198,7 @@ module ActiveMerchant #:nodoc:
         ACTIONS
       end
 
-      CREDIT_CARD_FIELDS = %w(AuthorizationNumber ClientIpAddress BillingAddress BillingCity BillingState BillingPostalCode BillingCountry BillingName CardVerificationValue ExpirationMonth ExpirationYear ReferenceNumber TransactionAmount AccountNumber )
+      CREDIT_CARD_FIELDS = %w(AuthorizationNumber ClientIpAddress BillingAddress BillingCity BillingState BillingPostalCode BillingCountry BillingName CardVerificationValue ExpirationMonth ExpirationYear ReferenceNumber TransactionAmount AccountNumber)
 
       ACTIONS = {
            :credit_card_authorize       => CREDIT_CARD_FIELDS,

data/lib/active_merchant/billing/gateways/elavon.rb

@@ -287,6 +287,7 @@ module ActiveMerchant #:nodoc:
 
       def custom_field?(field_name, options)
         return true if options[:custom_fields]&.include?(field_name.to_sym)
+
         field_name == :customer_number
       end
 
@@ -310,7 +311,6 @@ module ActiveMerchant #:nodoc:
         }
         resp
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/eway.rb

@@ -82,7 +82,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, options)
         if address = options[:billing_address] || options[:address]
-          post[:CustomerAddress]    = [ address[:address1], address[:address2], address[:city], address[:state], address[:country] ].compact.join(', ')
+          post[:CustomerAddress]    = [address[:address1], address[:address2], address[:city], address[:state], address[:country]].compact.join(', ')
           post[:CustomerPostcode]   = address[:zip]
         end
       end
@@ -145,6 +145,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(message)
         return '' if message.blank?
+
         MESSAGES[message[0, 2]] || message
       end
 

data/lib/active_merchant/billing/gateways/eway_managed.rb

@@ -265,7 +265,7 @@ module ActiveMerchant #:nodoc:
 
       def default_customer_fields
         hash={}
-        %w( CustomerRef Title FirstName LastName Company JobDesc Email Address Suburb State PostCode Country Phone Mobile Fax URL Comments CCNumber CCNameOnCard CCExpiryMonth CCExpiryYear ).each do |field|
+        %w(CustomerRef Title FirstName LastName Company JobDesc Email Address Suburb State PostCode Country Phone Mobile Fax URL Comments CCNumber CCNameOnCard CCExpiryMonth CCExpiryYear).each do |field|
           hash[field.to_sym]=''
         end
         return hash
@@ -273,7 +273,7 @@ module ActiveMerchant #:nodoc:
 
       def default_payment_fields
         hash={}
-        %w( managedCustomerID amount invoiceReference invoiceDescription ).each do |field|
+        %w(managedCustomerID amount invoiceReference invoiceDescription).each do |field|
           hash[field.to_sym]=''
         end
         return hash
@@ -285,7 +285,6 @@ module ActiveMerchant #:nodoc:
           @params['CreateCustomerResult']
         end
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/eway_rapid.rb

@@ -268,6 +268,7 @@ module ActiveMerchant #:nodoc:
 
       def add_credit_card(params, credit_card, options)
         return unless credit_card
+
         params['Customer'] ||= {}
         if credit_card.respond_to? :number
           card_details = params['Customer']['CardDetails'] = {}

data/lib/active_merchant/billing/gateways/exact.rb

@@ -5,8 +5,8 @@ module ActiveMerchant #:nodoc:
 
       API_VERSION = '8.5'
 
-      TEST_LOGINS = [ {:login => 'A00049-01', :password => 'test1'},
-                      {:login => 'A00427-01', :password => 'testus'} ]
+      TEST_LOGINS = [{:login => 'A00049-01', :password => 'test1'},
+                     {:login => 'A00427-01', :password => 'testus'}]
 
       TRANSACTIONS = { :sale          => '00',
                        :authorization => '01',
@@ -28,7 +28,7 @@ module ActiveMerchant #:nodoc:
 
       SUCCESS = 'true'
 
-      SENSITIVE_FIELDS = [ :verification_str2, :expiry_date, :card_number ]
+      SENSITIVE_FIELDS = [:verification_str2, :expiry_date, :card_number]
 
       self.supported_cardtypes = [:visa, :master, :american_express, :jcb, :discover]
       self.supported_countries = ['CA', 'US']

data/lib/active_merchant/billing/gateways/fat_zebra.rb

@@ -149,7 +149,8 @@ module ActiveMerchant #:nodoc:
           begin
             parse(ssl_request(method, get_url(uri), parameters.to_json, headers))
           rescue ResponseError => e
-            return Response.new(false, 'Invalid Login') if(e.response.code == '401')
+            return Response.new(false, 'Invalid Login') if e.response.code == '401'
+
             parse(e.response.body)
           end
 

data/lib/active_merchant/billing/gateways/first_giving.rb

@@ -49,7 +49,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_address(post, options)
-        if(billing_address = (options[:billing_address] || options[:address]))
+        if (billing_address = (options[:billing_address] || options[:address]))
           post[:billToAddressLine1]  = billing_address[:address1]
           post[:billToCity]          = billing_address[:city]
           post[:billToState]         = billing_address[:state]
@@ -83,6 +83,7 @@ module ActiveMerchant #:nodoc:
         end
         element.children.each do |child|
           next if child.text?
+
           response[child.name] = child.text
         end
 

data/lib/active_merchant/billing/gateways/firstdata_e4.rb

@@ -407,9 +407,9 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(response)
-        if(response[:faultcode] && response[:faultstring])
+        if response[:faultcode] && response[:faultstring]
           response[:faultstring]
-        elsif(response[:error_number] && response[:error_number] != '0')
+        elsif response[:error_number] && response[:error_number] != '0'
           response[:error_description]
         else
           result = (response[:exact_message] || '')

data/lib/active_merchant/billing/gateways/firstdata_e4_v27.rb

@@ -315,6 +315,7 @@ module ActiveMerchant #:nodoc:
 
       def add_stored_credentials(xml, card, options)
         return unless options[:stored_credential]
+
         xml.tag! 'StoredCredentials' do
           xml.tag! 'Indicator', stored_credential_indicator(xml, card, options)
           if initiator = options.dig(:stored_credential, :initiator)

data/lib/active_merchant/billing/gateways/flo2cash.rb

@@ -89,7 +89,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_data(post, options)
-        if(billing_address = (options[:billing_address] || options[:address]))
+        if (billing_address = (options[:billing_address] || options[:address]))
           post[:Email] = billing_address[:email]
         end
       end
@@ -107,7 +107,7 @@ module ActiveMerchant #:nodoc:
         begin
           raw = parse(ssl_post(url, data, headers(action)), action)
         rescue ActiveMerchant::ResponseError => e
-          if(e.response.code == '500' && e.response.body.start_with?('<?xml'))
+          if e.response.code == '500' && e.response.body.start_with?('<?xml')
             raw = parse(e.response.body, action)
           else
             raise

data/lib/active_merchant/billing/gateways/forte.rb

@@ -137,6 +137,7 @@ module ActiveMerchant #:nodoc:
 
       def add_shipping_address(post, options)
         return unless options[:shipping_address]
+
         address = options[:shipping_address]
 
         post[:shipping_address] = {}

data/lib/active_merchant/billing/gateways/garanti.rb

@@ -251,7 +251,6 @@ module ActiveMerchant #:nodoc:
       def strip_invalid_xml_chars(xml)
         xml.gsub(/&(?!(?:[a-z]+|#[0-9]+|x[a-zA-Z0-9]+);)/, '&')
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/global_collect.rb

@@ -100,6 +100,35 @@ module ActiveMerchant #:nodoc:
         post['order']['references']['invoiceData'] = {
           'invoiceNumber' => options[:invoice]
         }
+        add_airline_data(post, options) if options[:airline_data]
+      end
+
+      def add_airline_data(post, options)
+        airline_data = {}
+
+        flight_date = options[:airline_data][:flight_date]
+        passenger_name = options[:airline_data][:passenger_name]
+        code = options[:airline_data][:code]
+        name = options[:airline_data][:name]
+
+        airline_data['flightDate'] = flight_date if flight_date
+        airline_data['passengerName'] = passenger_name if passenger_name
+        airline_data['code'] = code if code
+        airline_data['name'] = name if name
+
+        flight_legs = []
+        options[:airline_data][:flight_legs]&.each do |fl|
+          leg = {}
+          leg['arrivalAirport'] = fl[:arrival_airport] if fl[:arrival_airport]
+          leg['originAirport'] = fl[:origin_airport] if fl[:origin_airport]
+          leg['date'] = fl[:date] if fl[:date]
+          leg['number'] = fl[:number] if fl[:number]
+          leg['carrierCode'] = fl[:carrier_code] if fl[:carrier_code]
+          leg['airlineClass'] = fl[:carrier_code] if fl[:airline_class]
+          flight_legs << leg
+        end
+        airline_data['flightLegs'] = flight_legs
+        post['order']['additionalInput']['airlineData'] = airline_data
       end
 
       def add_creator_info(post, options)

data/lib/active_merchant/billing/gateways/global_transport.rb

@@ -188,7 +188,6 @@ module ActiveMerchant #:nodoc:
           ExtData: ''
         }
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/hdfc.rb

@@ -196,6 +196,7 @@ EOA
 
       def escape(string, max_length=250)
         return '' unless string
+
         string = string[0...max_length] if max_length
         string.gsub(/[^A-Za-z0-9 \-_@\.\n]/, '')
       end

data/lib/active_merchant/billing/gateways/hps.rb

@@ -115,7 +115,7 @@ module ActiveMerchant #:nodoc:
           xml.hps :CardHolderEmail, options[:email] if options[:email]
           xml.hps :CardHolderPhone, options[:phone] if options[:phone]
 
-          if(billing_address = (options[:billing_address] || options[:address]))
+          if (billing_address = (options[:billing_address] || options[:address]))
             xml.hps :CardHolderAddr, billing_address[:address1] if billing_address[:address1]
             xml.hps :CardHolderCity, billing_address[:city] if billing_address[:city]
             xml.hps :CardHolderState, billing_address[:state] if billing_address[:state]
@@ -206,6 +206,7 @@ module ActiveMerchant #:nodoc:
 
       def strip_leading_zero(value)
         return value unless value[0] == '0'
+
         value[1, 1]
       end
 
@@ -248,7 +249,7 @@ module ActiveMerchant #:nodoc:
 
         doc = Nokogiri::XML(raw)
         doc.remove_namespaces!
-        if(header = doc.xpath('//Header').first)
+        if (header = doc.xpath('//Header').first)
           header.elements.each do |node|
             if node.elements.size == 0
               response[node.name] = node.text
@@ -259,12 +260,12 @@ module ActiveMerchant #:nodoc:
             end
           end
         end
-        if(transaction = doc.xpath('//Transaction/*[1]').first)
+        if (transaction = doc.xpath('//Transaction/*[1]').first)
           transaction.elements.each do |node|
             response[node.name] = node.text
           end
         end
-        if(fault = doc.xpath('//Fault/Reason/Text').first)
+        if (fault = doc.xpath('//Fault/Reason/Text').first)
           response['Fault'] = fault.text
         end
 
@@ -303,10 +304,10 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(response)
-        if(response['Fault'])
+        if response['Fault']
           response['Fault']
-        elsif(response['GatewayRspCode'] == '0')
-          if(response['RspCode'] != '00' && response['RspCode'] != '85')
+        elsif response['GatewayRspCode'] == '0'
+          if response['RspCode'] != '00' && response['RspCode'] != '85'
             issuer_message(response['RspCode'])
           else
             response['GatewayRspMsg']
@@ -337,6 +338,7 @@ module ActiveMerchant #:nodoc:
         return 'The card was declined.' if %w(02 03 04 05 41 43 44 51 56 61 62 63 65 78).include?(code)
         return 'An error occurred while processing the card.' if %w(06 07 12 15 19 12 52 53 57 58 76 77 91 96 EC).include?(code)
         return "The card's security code is incorrect." if %w(EB N7).include?(code)
+
         ISSUER_MESSAGES[code]
       end