activemerchant 1.103.0 → 1.104.0

data/lib/active_merchant/billing/gateways/authorize_net_arb.rb

@@ -230,6 +230,7 @@ module ActiveMerchant #:nodoc:
       def add_interval(xml, options)
         interval = options[:interval]
         return unless interval
+
         xml.tag!('interval') do
           # The measurement of time, in association with the Interval Unit,
           # that is used to define the frequency of the billing occurrences
@@ -244,6 +245,7 @@ module ActiveMerchant #:nodoc:
       def add_duration(xml, options)
         duration = options[:duration]
         return unless duration
+
         # The date the subscription begins
         # (also the date the initial billing occurs)
         xml.tag!('startDate', duration[:start_date]) if duration[:start_date]
@@ -253,6 +255,7 @@ module ActiveMerchant #:nodoc:
 
       def add_payment_schedule(xml, options)
         return unless options[:interval] || options[:duration]
+
         xml.tag!('paymentSchedule') do
           # Contains information about the interval of time between payments
           add_interval(xml, options)
@@ -267,6 +270,7 @@ module ActiveMerchant #:nodoc:
       # Adds customer's credit card or bank account payment information
       def add_payment(xml, options)
         return unless options[:credit_card] || options[:bank_account]
+
         xml.tag!('payment') do
           # Contains the customer’s credit card information
           add_credit_card(xml, options)
@@ -281,6 +285,7 @@ module ActiveMerchant #:nodoc:
       def add_credit_card(xml, options)
         credit_card = options[:credit_card]
         return unless credit_card
+
         xml.tag!('creditCard') do
           # The credit card number used for payment of the subscription
           xml.tag!('cardNumber', credit_card.number)
@@ -295,6 +300,7 @@ module ActiveMerchant #:nodoc:
       def add_bank_account(xml, options)
         bank_account = options[:bank_account]
         return unless bank_account
+
         xml.tag!('bankAccount') do
           # The type of bank account used for payment of the subscription
           xml.tag!('accountType', bank_account[:account_type])
@@ -317,6 +323,7 @@ module ActiveMerchant #:nodoc:
       def add_order(xml, options)
         order = options[:order]
         return unless order
+
         xml.tag!('order') do
           # Merchant-assigned invoice number for the subscription (optional)
           xml.tag!('invoiceNumber', order[:invoice_number])
@@ -329,6 +336,7 @@ module ActiveMerchant #:nodoc:
       def add_customer(xml, options)
         customer = options[:customer]
         return unless customer
+
         xml.tag!('customer') do
           xml.tag!('type', customer[:type]) if customer[:type]
           xml.tag!('id', customer[:id]) if customer[:id]
@@ -344,6 +352,7 @@ module ActiveMerchant #:nodoc:
       def add_drivers_license(xml, options)
         return unless customer = options[:customer]
         return unless drivers_license = customer[:drivers_license]
+
         xml.tag!('driversLicense') do
           # The customer's driver's license number
           xml.tag!('number', drivers_license[:number])
@@ -357,6 +366,7 @@ module ActiveMerchant #:nodoc:
       # Adds address information
       def add_address(xml, container_name, address)
         return if address.blank?
+
         xml.tag!(container_name) do
           xml.tag!('firstName', address[:first_name])
           xml.tag!('lastName', address[:last_name])

data/lib/active_merchant/billing/gateways/authorize_net_cim.rb

@@ -791,6 +791,7 @@ module ActiveMerchant #:nodoc:
       # when the payment method is credit card.
       def add_credit_card(xml, credit_card)
         return unless credit_card
+
         xml.tag!('creditCard') do
           # The credit card number used for payment of the subscription
           xml.tag!('cardNumber', full_or_masked_card_number(credit_card.number))

data/lib/active_merchant/billing/gateways/axcessms.rb

@@ -166,6 +166,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(xml, address)
         raise ArgumentError.new('Address is required') unless address
+
         xml.tag! 'Address' do
           xml.tag! 'Street', "#{address[:address1]} #{address[:address2]}".strip
           xml.tag! 'City', address[:city]

data/lib/active_merchant/billing/gateways/balanced.rb

@@ -45,7 +45,7 @@ module ActiveMerchant #:nodoc:
 
         MultiResponse.run do |r|
           identifier =
-            if(payment_method.respond_to?(:number))
+            if payment_method.respond_to?(:number)
               r.process { store(payment_method, options) }
               r.authorization
             else
@@ -63,7 +63,7 @@ module ActiveMerchant #:nodoc:
 
         MultiResponse.run do |r|
           identifier =
-            if(payment_method.respond_to?(:number))
+            if payment_method.respond_to?(:number)
               r.process { store(payment_method, options) }
               r.authorization
             else
@@ -139,7 +139,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, options)
         address = (options[:billing_address] || options[:address])
-        if(address && address[:zip].present?)
+        if address && address[:zip].present?
           post[:address] = {}
           post[:address][:line1] = address[:address1] if address[:address1]
           post[:address][:line2] = address[:address2] if address[:address2]
@@ -159,14 +159,16 @@ module ActiveMerchant #:nodoc:
       def commit(entity_name, path, post, method=:post)
         raw_response =
           begin
-            parse(ssl_request(
-              method,
-              live_url + "/#{path}",
-              post_data(post),
-              headers
-            ))
+            parse(
+              ssl_request(
+                method,
+                live_url + "/#{path}",
+                post_data(post),
+                headers
+              ))
           rescue ResponseError => e
-            raise unless(e.response.code.to_s =~ /4\d\d/)
+            raise unless e.response.code.to_s =~ /4\d\d/
+
             parse(e.response.body)
           end
 
@@ -181,13 +183,13 @@ module ActiveMerchant #:nodoc:
 
       def success_from(entity_name, raw_response)
         entity = (raw_response[entity_name] || []).first
-        if(!entity)
+        if !entity
           false
-        elsif((entity_name == 'refunds') && entity.include?('status'))
+        elsif (entity_name == 'refunds') && entity.include?('status')
           %w(succeeded pending).include?(entity['status'])
-        elsif(entity.include?('status'))
+        elsif entity.include?('status')
           (entity['status'] == 'succeeded')
-        elsif(entity_name == 'cards')
+        elsif entity_name == 'cards'
           !!entity['id']
         else
           false
@@ -195,7 +197,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(raw_response)
-        if(raw_response['errors'])
+        if raw_response['errors']
           error = raw_response['errors'].first
           (error['additional'] || error['message'] || error['description'])
         else
@@ -225,6 +227,7 @@ module ActiveMerchant #:nodoc:
 
         params.map do |key, value|
           next if value.blank?
+
           if value.is_a?(Hash)
             h = {}
             value.each do |k, v|

data/lib/active_merchant/billing/gateways/barclaycard_smartpay.rb

@@ -184,6 +184,7 @@ module ActiveMerchant #:nodoc:
         authorization = [parameters[:originalReference], response['pspReference']].compact
 
         return nil if authorization.empty?
+
         return authorization.join('#')
       end
 
@@ -238,6 +239,7 @@ module ActiveMerchant #:nodoc:
         return response['resultCode'] if response.has_key?('resultCode') # Payment request
         return response['response'] if response['response'] # Modification request
         return response['result'] if response.has_key?('result') # Store/Recurring request
+
         'Failure' # Negative fallback in case of error
       end
 
@@ -367,6 +369,7 @@ module ActiveMerchant #:nodoc:
           end
         else
           return unless options[:execute_threed] || options[:threed_dynamic]
+
           post[:browserInfo] = { userAgent: options[:user_agent], acceptHeader: options[:accept_header] }
           post[:additionalData] = { executeThreeD: 'true' } if options[:execute_threed]
         end
@@ -374,6 +377,7 @@ module ActiveMerchant #:nodoc:
 
       def add_browser_info(browser_info, post)
         return unless browser_info
+
         post[:browserInfo] = {
           acceptHeader: browser_info[:accept_header],
           colorDepth: browser_info[:depth],

data/lib/active_merchant/billing/gateways/beanstream/beanstream_core.rb

@@ -256,8 +256,9 @@ module ActiveMerchant #:nodoc:
       end
 
       def prepare_address_for_non_american_countries(options)
-        [ options[:billing_address], options[:shipping_address] ].compact.each do |address|
+        [options[:billing_address], options[:shipping_address]].compact.each do |address|
           next if empty?(address[:country])
+
           unless ['US', 'CA'].include?(address[:country])
             address[:state] = '--'
             address[:zip]   = '000000' unless address[:zip]
@@ -366,6 +367,7 @@ module ActiveMerchant #:nodoc:
           if interval.respond_to? :parts
             parts = interval.parts
             raise ArgumentError.new("Cannot recur with mixed interval (#{interval}). Use only one of: days, weeks, months or years") if parts.length > 1
+
             parts.first
           elsif interval.kind_of? Hash
             requires!(interval, :unit)

data/lib/active_merchant/billing/gateways/blue_pay.rb

@@ -10,8 +10,8 @@ module ActiveMerchant #:nodoc:
 
       self.ignore_http_status = true
 
-      CARD_CODE_ERRORS = %w( N S )
-      AVS_ERRORS = %w( A E N R W Z )
+      CARD_CODE_ERRORS = %w(N S)
+      AVS_ERRORS = %w(A E N R W Z)
       AVS_REASON_CODES = %w(27 45)
 
       FIELD_MAP = {
@@ -155,7 +155,7 @@ module ActiveMerchant #:nodoc:
       #   If the payment_object is either a CreditCard or Check object, then the transaction type will be an unmatched credit placing funds in the specified account. This is referred to a CREDIT transaction in BluePay.
       # * <tt>options</tt> -- A hash of parameters.
       def refund(money, identification, options = {})
-        if(identification && !identification.kind_of?(String))
+        if identification && !identification.kind_of?(String)
           ActiveMerchant.deprecated 'refund should only be used to refund a referenced transaction'
           return credit(money, identification, options)
         end
@@ -317,7 +317,7 @@ module ActiveMerchant #:nodoc:
       private
 
       def commit(action, money, fields, options = {})
-        fields[:AMOUNT] = amount(money) unless(fields[:TRANS_TYPE] == 'VOID' || action == 'rebill')
+        fields[:AMOUNT] = amount(money) unless fields[:TRANS_TYPE] == 'VOID' || action == 'rebill'
         fields[:MODE] = (test? ? 'TEST' : 'LIVE')
         fields[:ACCOUNT_ID] = @options[:login]
         fields[:CUSTOMER_IP] = options[:ip] if options[:ip]
@@ -372,7 +372,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(parsed)
         message = parsed[:message]
-        if(parsed[:response_code].to_i == 2)
+        if parsed[:response_code].to_i == 2
           if CARD_CODE_ERRORS.include?(parsed[:card_code])
             message = CVVResult.messages[parsed[:card_code]]
           elsif AVS_ERRORS.include?(parsed[:avs_result_code])
@@ -513,6 +513,7 @@ module ActiveMerchant #:nodoc:
 
       def handle_response(response)
         return response.body if ignore_http_status || (200...300).cover?(response.code.to_i)
+
         raise ResponseError.new(response)
       end
     end

data/lib/active_merchant/billing/gateways/blue_snap.rb

@@ -256,6 +256,7 @@ module ActiveMerchant
 
       def add_level_3_data(doc, options)
         return unless options[:customer_reference_number]
+
         doc.send('level-3-data') do
           send_when_present(doc, :customer_reference_number, options)
           send_when_present(doc, :sales_tax_amount, options)
@@ -273,6 +274,7 @@ module ActiveMerchant
 
       def send_when_present(doc, options_key, options, xml_element_name = nil)
         return unless options[options_key]
+
         xml_element_name ||= options_key.to_s
 
         doc.send(xml_element_name.dasherize, options[options_key])
@@ -380,7 +382,7 @@ module ActiveMerchant
         succeeded = success_from(action, response)
         Response.new(
           succeeded,
-          message_from(succeeded, parsed),
+          message_from(succeeded, response),
           parsed,
           authorization: authorization_from(action, parsed, payment_method_details),
           avs_result: avs_result(parsed),
@@ -412,9 +414,34 @@ module ActiveMerchant
         (200...300).cover?(response.code.to_i)
       end
 
-      def message_from(succeeded, parsed_response)
+      def message_from(succeeded, response)
         return 'Success' if succeeded
-        parsed_response['description']
+
+        parsed = parse(response)
+        if parsed.dig('error-name') == 'FRAUD_DETECTED'
+          fraud_codes_from(response)
+        else
+          parsed['description']
+        end
+      end
+
+      def fraud_codes_from(response)
+        event_summary = {}
+        doc = Nokogiri::XML(response.body)
+        fraud_events = doc.xpath('//xmlns:fraud-events', 'xmlns' => 'http://ws.plimus.com')
+        fraud_events.children.each do |child|
+          if child.children.children.any?
+            event_summary[child.name] = event_summary[child.name] || []
+            event = {}
+            child.children.each do |chi|
+              event[chi.name] = chi.text
+            end
+            event_summary[child.name] << event
+          else
+            event_summary[child.name] = child.text
+          end
+        end
+        event_summary.to_json
       end
 
       def authorization_from(action, parsed_response, payment_method_details)
@@ -423,6 +450,7 @@ module ActiveMerchant
 
       def vaulted_shopper_id(parsed_response, payment_method_details)
         return nil unless parsed_response['content-location-header']
+
         vaulted_shopper_id = parsed_response['content-location-header'].split('/').last
         vaulted_shopper_id += "|#{payment_method_details.payment_method_type}" if payment_method_details.alt_transaction?
         vaulted_shopper_id

data/lib/active_merchant/billing/gateways/borgun.rb

@@ -9,7 +9,7 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://gatewaytest.borgun.is/ws/Heimir.pub.ws:Authorization'
       self.live_url = 'https://gateway01.borgun.is/ws/Heimir.pub.ws:Authorization'
 
-      self.supported_countries = ['IS', 'GB', 'HU', 'CZ', 'DE', 'DK', 'SE' ]
+      self.supported_countries = ['IS', 'GB', 'HU', 'CZ', 'DE', 'DK', 'SE']
       self.default_currency = 'ISK'
       self.money_format = :cents
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :discover, :jcb]

data/lib/active_merchant/billing/gateways/bpoint.rb

@@ -240,7 +240,6 @@ module ActiveMerchant #:nodoc:
       end
 
       class ProcessPaymentResponse < BPointResponse
-
         private
 
         def authorization_key
@@ -257,7 +256,6 @@ module ActiveMerchant #:nodoc:
       end
 
       class AddTokenResponse < BPointResponse
-
         private
 
         def authorization_key

data/lib/active_merchant/billing/gateways/braintree/braintree_common.rb

@@ -14,6 +14,7 @@ module BraintreeCommon
 
   def scrub(transcript)
     return '' if transcript.blank?
+
     transcript.
       gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]').
       gsub(%r((&?ccnumber=)\d*(&?)), '\1[FILTERED]\2').

data/lib/active_merchant/billing/gateways/braintree_blue.rb

@@ -170,7 +170,7 @@ module ActiveMerchant #:nodoc:
 
       def unstore(customer_vault_id, options = {})
         commit do
-          if(!customer_vault_id && options[:credit_card_token])
+          if !customer_vault_id && options[:credit_card_token]
             @braintree_gateway.credit_card.delete(options[:credit_card_token])
           else
             @braintree_gateway.customer.delete(customer_vault_id)
@@ -260,7 +260,7 @@ module ActiveMerchant #:nodoc:
           }
           if options[:billing_address]
             address = map_address(options[:billing_address])
-            parameters[:credit_card][:billing_address] = address unless address.all? { |_k, v| empty?(v) }
+            parameters[:billing_address] = address unless address.all? { |_k, v| empty?(v) }
           end
 
           result = @braintree_gateway.credit_card.create(parameters)
@@ -287,10 +287,10 @@ module ActiveMerchant #:nodoc:
 
       def scrub_zip(zip)
         return nil unless zip.present?
-        return nil if(
+        return nil if
           zip.gsub(/[^a-z0-9]/i, '').length > 9 ||
           zip =~ /[^a-z0-9\- ]/i
-        )
+
         zip
       end
 
@@ -628,11 +628,17 @@ module ActiveMerchant #:nodoc:
 
         parameters[:line_items] = options[:line_items] if options[:line_items]
 
+        if options[:payment_method_nonce].is_a?(String)
+          parameters.delete(:customer)
+          parameters[:payment_method_nonce] = options[:payment_method_nonce]
+        end
+
         parameters
       end
 
       def add_3ds_info(parameters, three_d_secure_opts)
         return if empty?(three_d_secure_opts)
+
         pass_thru = {}
 
         pass_thru[:three_d_secure_version] = three_d_secure_opts[:version] if three_d_secure_opts[:version]
@@ -655,6 +661,7 @@ module ActiveMerchant #:nodoc:
 
       def add_stored_credential_data(parameters, credit_card_or_vault_id, options)
         return unless (stored_credential = options[:stored_credential])
+
         parameters[:external_vault] = {}
         if stored_credential[:initial_transaction]
           parameters[:external_vault][:status] = 'will_vault'

data/lib/active_merchant/billing/gateways/bridge_pay.rb

@@ -147,7 +147,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_data(post, options)
-        if(billing_address = (options[:billing_address] || options[:address]))
+        if (billing_address = (options[:billing_address] || options[:address]))
           post[:Street] = billing_address[:address1]
           post[:Zip]    = billing_address[:zip]
         end

data/lib/active_merchant/billing/gateways/card_connect.rb

@@ -69,7 +69,7 @@ module ActiveMerchant #:nodoc:
 
       def require_valid_domain!(options, param)
         if options[param]
-          raise ArgumentError.new('not a valid cardconnect domain') unless /\Dcardconnect.com:\d{1,}\D/ =~ options[param]
+          raise ArgumentError.new('not a valid cardconnect domain') unless /https:\/\/\D*cardconnect.com/ =~ options[param]
         end
       end
 
@@ -288,6 +288,7 @@ module ActiveMerchant #:nodoc:
         )
       rescue ResponseError => e
         return Response.new(false, 'Unable to authenticate.  Please check your credentials.', {}, :test => test?) if e.response.code == '401'
+
         raise
       end