vibe-forge 0.4.0 → 0.8.1

package/tasks/completed/ARCH-003-worker-loop-hook-duplication.md

@@ -1,77 +0,0 @@
----
-id: ARCH-003
-title: "Remove duplicate worker-loop hook implementations"
-type: architecture
-priority: medium
-assigned_to: architect
-created_at: 2026-01-15T17:00:00Z
-created_by: architect-review
-completed_at: 2026-01-16T00:00:00Z
-completed_by: furnace
----
-
-## Summary
-Worker loop stop hook is implemented in both Bash and Node.js with nearly identical logic, creating maintenance burden.
-
-## Current State
-Two implementations exist:
-- `.claude/hooks/worker-loop.sh` - Bash implementation
-- `.claude/hooks/worker-loop.js` - Node.js implementation
-
-Both implement the same logic:
-1. Check for state file or config-based activation
-2. Count pending/needs-changes tasks
-3. Decide whether to block exit or allow
-4. Output JSON with decision
-
-The `.claude/settings.local.json` uses the Node.js version:
-```json
-"hooks": {
-  "Stop": [{ "command": "node .claude/hooks/worker-loop.js" }]
-}
-```
-
-Problems:
-- Duplicate code to maintain
-- Logic could drift between implementations
-- Confusion about which is canonical
-- Bash version has path issues noted in SEC-005
-
-## Proposed State
-Single implementation:
-
-1. **Keep Node.js only** (recommended)
-   - Already used in settings.local.json
-   - Better cross-platform compatibility
-   - Easier JSON handling
-   - Delete worker-loop.sh
-
-2. **Alternative: Keep Bash only**
-   - Change settings.local.json to use bash
-   - Fix path issues from SEC-005
-   - Delete worker-loop.js
-
-## Affected Files
-- G:\dev\vibe-forge\.claude\hooks\worker-loop.sh
-- G:\dev\vibe-forge\.claude\hooks\worker-loop.js
-- G:\dev\vibe-forge\.claude\settings.local.json
-
-## Migration/Remediation Steps
-1. Verify Node.js implementation is complete and working
-2. Ensure settings.local.json points to Node.js version (currently does)
-3. Delete worker-loop.sh
-4. Update any documentation referring to bash hook
-5. Test worker loop functionality end-to-end
-
-## Acceptance Criteria
-- [x] Only one hook implementation exists
-- [x] settings.local.json correctly configured
-- [x] Worker loop functionality works correctly
-- [x] Documentation updated
-
-## Resolution
-Removed `.claude/hooks/worker-loop.sh` (Bash version) and kept the Node.js implementation as the single source of truth. Updated documentation in:
-- `.claude/commands/worker-loop.md` - line 86 now references worker-loop.js
-- `docs/TODO.md` - line 90 now references worker-loop.js
-
-The Node.js version is already active in settings.local.json and provides better cross-platform compatibility.

package/tasks/completed/ARCH-009-test-organization.md

@@ -1,78 +0,0 @@
----
-id: ARCH-009
-title: "Improve test organization and re-enable shell tests"
-type: architecture
-priority: medium
-assigned_to: crucible
-created_at: 2026-01-15T17:00:00Z
-created_by: architect-review
-completed_at: 2026-01-16T10:30:00Z
-completed_by: crucible
-status: completed
----
-
-## Summary
-Test organization is inconsistent and shell tests (BATS) are disabled. Need to establish consistent test structure and either fix or remove shell tests.
-
-## Resolution
-
-**Option B: Convert to Jest** was implemented.
-
-### Root Cause Analysis
-Bash associative arrays (`declare -A`) are not exported to subshells. BATS runs each `@test` in a subshell, so even when `constants.sh` is sourced in `setup()`, the associative arrays (`AGENT_ALIASES`, `AGENT_DISPLAY_NAMES`, `AGENT_ROLES`, etc.) are unavailable in the test body.
-
-The tests attempted to work around this by calling `_source_libs` within each test, but this still fails because the test body itself runs in a separate subshell.
-
-### Solution Implemented
-Converted all BATS tests to Jest tests that invoke bash via `child_process.spawnSync()`:
-
-1. Created `tests/helpers/shell-runner.js` - Utility to run bash commands and shell functions
-2. Created `tests/unit/agents.test.js` - Tests for `bin/lib/agents.sh` (29 tests)
-3. Created `tests/unit/config.test.js` - Tests for `bin/lib/config.sh` (17 tests)
-4. Created `tests/unit/constants.test.js` - Tests for `bin/lib/constants.sh` (25 tests)
-5. Moved `tests/js/cli.test.js` to `tests/unit/cli.test.js` (9 tests)
-6. Updated `package.json` with new test scripts
-7. Updated `.github/workflows/ci.yml` to run unit tests
-8. Removed old `tests/shell/` and `tests/js/` directories
-
-### New Test Structure
-```
-tests/
-  helpers/
-    shell-runner.js   <- Utility for running bash via child_process
-  unit/
-    cli.test.js       <- CLI help/version tests
-    agents.test.js    <- Agent resolution, validation, security tests
-    config.test.js    <- JSON parsing, config loading tests
-    constants.test.js <- Exit codes, directory constants, agent arrays
-  integration/
-    (empty, ready for future integration tests)
-```
-
-### Test Coverage
-- **80 tests passing** in CI
-- Covers all functionality that was in BATS tests
-- Includes security tests (path traversal, command injection)
-- Cross-platform: Tests skip gracefully if bash is unavailable
-
-### CI Changes
-- Removed disabled `test-shell` job
-- Renamed `test-js` to `test-unit`
-- `npm test` now runs all unit tests
-
-## Acceptance Criteria
-- [x] Clear test organization (unit, integration)
-- [x] All tests in CI are passing (no disabled tests)
-- [x] Coverage for critical paths
-- [x] Documented test strategy
-
-## Files Changed
-- `tests/helpers/shell-runner.js` (new)
-- `tests/unit/cli.test.js` (moved from tests/js/)
-- `tests/unit/agents.test.js` (new - replaces tests/shell/agents.bats)
-- `tests/unit/config.test.js` (new - replaces tests/shell/config.bats)
-- `tests/unit/constants.test.js` (new - replaces tests/shell/constants.bats)
-- `package.json` (updated test scripts)
-- `.github/workflows/ci.yml` (updated test job)
-- `docs/TODO.md` (updated with resolution notes)
-- Deleted: `tests/shell/*.bats`, `tests/js/`

package/tasks/completed/ARCH-011-jq-vs-nodejs-json.md

@@ -1,94 +0,0 @@
----
-id: ARCH-011
-title: "Standardize JSON parsing approach (jq vs Node.js)"
-type: architecture
-priority: medium
-assigned_to: architect
-created_at: 2026-01-15T17:00:00Z
-created_by: architect-review
-completed_at: 2026-01-16T00:00:00Z
-completed_by: furnace
----
-
-## Summary
-JSON parsing uses two different approaches: Node.js in some places and jq in others. This creates an implicit jq dependency and inconsistent patterns.
-
-## Current State
-**Node.js JSON parsing (config.sh):**
-```bash
-json_get_string() {
-    node -e '
-        const fs = require("fs");
-        const data = JSON.parse(fs.readFileSync(file, "utf8"));
-        console.log(data[key]);
-    ' -- "$file" "$key"
-}
-```
-
-**jq JSON parsing (forge-daemon.sh, worker-loop.sh):**
-```bash
-WORKER_AGENT=$(jq -r '.agent // ""' "$STATE_FILE")
-agent=$(jq -r '.agent // "unknown"' "$status_file")
-```
-
-Problems:
-- jq is not listed as a dependency
-- Different error handling patterns
-- Security doc mentions Node.js for "safe JSON parsing" but daemon uses jq
-- Inconsistent approach creates confusion
-
-## Proposed State
-Standardize on Node.js for JSON parsing:
-
-1. Create json utility functions in lib:
-```bash
-# bin/lib/json.sh
-json_get() {
-    node -e "..." -- "$1" "$2"
-}
-json_set() {
-    node -e "..." -- "$1" "$2" "$3"
-}
-```
-
-2. Replace all jq calls with json utility calls
-
-3. Or: document jq as a dependency and use consistently
-
-## Affected Files
-- G:\dev\vibe-forge\bin\lib\config.sh (has Node.js approach)
-- G:\dev\vibe-forge\bin\forge-daemon.sh (uses jq)
-- G:\dev\vibe-forge\.claude\hooks\worker-loop.sh (uses jq)
-- G:\dev\vibe-forge\bin\forge.sh (uses jq for config)
-
-## Migration/Remediation Steps
-1. Audit all jq usage in codebase
-2. Create bin/lib/json.sh with Node.js-based utilities
-3. Replace jq calls with json utility calls
-4. Or: add jq to documented dependencies and ensure installed
-5. Update security documentation if approach changes
-6. Test all JSON operations
-
-## Acceptance Criteria
-- [x] Single consistent JSON parsing approach
-- [x] All dependencies documented
-- [x] Security considerations addressed
-- [ ] Tests passing (manual verification done)
-
-## Resolution
-Created `bin/lib/json.sh` with Node.js-based JSON utilities:
-- `json_read FILE KEY [DEFAULT]` - Read single key from JSON file
-- `json_read_multi FILE KEY1 KEY2...` - Read multiple keys efficiently
-- `json_read_all FILE` - Read all keys as key=value pairs
-- `json_write FILE KEY VALUE` - Write/update single key
-- `json_write_bool FILE KEY BOOL` - Write boolean value
-- `json_pretty FILE` - Pretty-print JSON file
-- `json_has_key FILE KEY` - Check if key exists
-
-Updated files to use new json utilities (removed all jq calls):
-- `bin/forge-daemon.sh` - sync_agent_status() and cmd_status() now use json_read()
-- `bin/forge.sh` - cmd_config() now uses json_read(), json_write_bool(), json_pretty()
-
-Additionally, `.claude/hooks/worker-loop.sh` which used jq was removed as part of ARCH-003/CLEAN-001 (duplicate of worker-loop.js).
-
-The codebase now consistently uses Node.js for all JSON operations, removing the implicit jq dependency.

package/tasks/completed/ARCH-012-tmp-files-in-root.md

@@ -1,71 +0,0 @@
----
-id: ARCH-012
-title: "Clean up tmpclaude-* files from root directory"
-type: architecture
-priority: low
-status: completed
-assigned_to: ember
-completed_at: 2026-01-16T12:30:00Z
-completed_by: ember
-created_at: 2026-01-15T17:00:00Z
-created_by: architect-review
----
-
-## Summary
-The root directory contains many tmpclaude-* files that should be gitignored and cleaned up.
-
-## Current State
-Root directory listing shows 24+ tmpclaude-* files:
-```
-tmpclaude-03aa-cwd
-tmpclaude-1587-cwd
-tmpclaude-3025-cwd
-... (24 total)
-```
-
-These are created by Claude Code CLI during subagent execution.
-
-.gitignore already has:
-```
-# Claude Code temp files (created by CLI during subagent execution)
-tmpclaude-*
-```
-
-Problems:
-- Files exist but should be ignored
-- Clutters root directory
-- May have been committed before .gitignore was added
-
-## Proposed State
-1. Verify .gitignore is effective
-2. Clean existing files from repo if committed
-3. Consider moving temp files to .forge/ or /tmp
-
-## Affected Files
-- G:\dev\vibe-forge\.gitignore
-- G:\dev\vibe-forge\tmpclaude-* (many files)
-
-## Migration/Remediation Steps
-1. Check if tmpclaude-* files are tracked: `git ls-files tmpclaude-*`
-2. If tracked, remove from git: `git rm --cached tmpclaude-*`
-3. Delete local files: `rm tmpclaude-*`
-4. Verify .gitignore prevents future tracking
-5. Consider creating cleanup script or adding to git pre-commit hook
-6. Optionally: configure Claude Code to use different temp location
-
-## Acceptance Criteria
-- [x] No tmpclaude-* files tracked in git
-- [x] .gitignore prevents future tracking
-- [x] Root directory clean of temp files
-- [ ] Future temp files automatically cleaned or redirected (deferred - .gitignore sufficient)
-
-## Implementation Notes (Completed 2026-01-16)
-
-1. Verified files were NOT tracked in git (`git ls-files tmpclaude-*` returned empty)
-2. `.gitignore` already had `tmpclaude-*` pattern
-3. Deleted 25 local tmpclaude-*-cwd files via `rm -f tmpclaude-*-cwd`
-4. Root directory now clean
-
-Note: These files are created by Claude Code CLI during subagent execution.
-The .gitignore prevents them from being committed. Manual cleanup may be needed
-periodically, but this is low-impact.

package/tasks/completed/ARCH-013-exit-code-constants.md

@@ -1,65 +0,0 @@
----
-id: ARCH-013
-title: "Define exit code constants for better error handling"
-type: architecture
-priority: low
-assigned_to: furnace
-created_at: 2026-01-15T17:00:00Z
-created_by: architect-review
-completed_at: 2026-01-15T17:30:00Z
-completed_by: furnace
----
-
-## Summary
-All errors exit with code 1, providing no differentiation between error types. Should define exit code constants for better debugging and automation.
-
-## Resolution
-
-### Exit Code Constants Added
-Added to `bin/lib/constants.sh`:
-```bash
-# Exit Codes
-EXIT_SUCCESS=0               # Successful execution
-EXIT_GENERAL_ERROR=1         # Generic/unspecified error
-EXIT_CONFIG_ERROR=2          # Configuration file missing/invalid
-EXIT_DEPENDENCY_MISSING=3    # Required dependency not found (Claude Code, Git Bash, etc.)
-EXIT_INVALID_ARGUMENT=4      # Invalid argument (unknown agent, unknown command)
-EXIT_RUNTIME_ERROR=5         # Runtime error (daemon conflict, spawn failed, etc.)
-```
-
-### Files Updated
-
-**bin/forge.sh:**
-- Unknown agent -> EXIT_INVALID_ARGUMENT
-- Personality file not found -> EXIT_CONFIG_ERROR
-- Claude Code not working -> EXIT_DEPENDENCY_MISSING
-- No agent specified -> EXIT_INVALID_ARGUMENT
-- Config file not found -> EXIT_CONFIG_ERROR
-- Unknown command -> EXIT_INVALID_ARGUMENT
-
-**bin/forge-daemon.sh:**
-- Unknown command -> EXIT_INVALID_ARGUMENT
-
-**bin/forge-spawn.sh:**
-- wt command not found -> EXIT_DEPENDENCY_MISSING
-- No agent specified -> EXIT_INVALID_ARGUMENT
-- Unknown agent -> EXIT_INVALID_ARGUMENT
-
-**bin/forge-setup.sh:**
-- Added constants.sh import
-- Git installation failed -> EXIT_DEPENDENCY_MISSING
-- Git Bash not found -> EXIT_DEPENDENCY_MISSING
-- Claude Code not found -> EXIT_DEPENDENCY_MISSING
-- Setup incomplete -> EXIT_CONFIG_ERROR
-
-## Acceptance Criteria Status
-- [x] Exit code constants defined
-- [x] All exit calls use constants (in bash scripts)
-- [x] Documentation of exit codes (in constants.sh comments)
-- [ ] Consistent between bash and Node.js (cli.js not updated - separate task)
-- [ ] Tests verify correct exit codes (future enhancement)
-
-## Notes
-- cli.js was not updated as it runs standalone via npx and has its own error handling
-- Constants follow BSD sysexits.h conventions where applicable
-- Future work: add tests for error conditions

package/tasks/completed/ARCH-014-sed-incompatibility.md

@@ -1,96 +0,0 @@
----
-id: ARCH-014
-title: "Fix sed -i incompatibility between macOS and Linux"
-type: architecture
-priority: high
-status: completed
-assigned_to: ember
-completed_at: 2026-01-16T12:30:00Z
-completed_by: ember
-created_at: 2026-01-15T17:00:00Z
-created_by: architect-review
----
-
-## Summary
-The setup script uses `sed -i` which has different syntax on macOS/BSD vs Linux, causing failures on macOS.
-
-## Current State
-From docs/TODO.md:
-> **sed -i incompatibility in forge-setup.sh**
-> Lines: 205, 249, 291, 380, 381, 384, 388
-> Issue: macOS/BSD sed requires `sed -i ''` but script uses `sed -i`
-> Fix: Add platform detection or create `sed_inplace()` helper
-
-Linux syntax: `sed -i 's/foo/bar/' file`
-macOS syntax: `sed -i '' 's/foo/bar/' file`
-
-Current code (forge-setup.sh):
-```bash
-sed -i 's/"validated": false/"validated": true/' "$config_file" 2>/dev/null || true
-```
-
-The `2>/dev/null || true` masks the failure but doesn't fix it.
-
-## Proposed State
-Create cross-platform helper:
-```bash
-# bin/lib/util.sh
-sed_inplace() {
-    local pattern="$1"
-    local file="$2"
-
-    if [[ "$(uname)" == "Darwin" ]]; then
-        sed -i '' "$pattern" "$file"
-    else
-        sed -i "$pattern" "$file"
-    fi
-}
-```
-
-Or use a different approach:
-```bash
-# Use temp file approach (works everywhere)
-update_json_field() {
-    local file="$1"
-    local key="$2"
-    local value="$3"
-
-    node -e '
-        const fs = require("fs");
-        const data = JSON.parse(fs.readFileSync(process.argv[1]));
-        data[process.argv[2]] = process.argv[3];
-        fs.writeFileSync(process.argv[1], JSON.stringify(data, null, 2));
-    ' "$file" "$key" "$value"
-}
-```
-
-## Affected Files
-- G:\dev\vibe-forge\bin\forge-setup.sh (multiple lines)
-- G:\dev\vibe-forge\bin\forge-daemon.sh (lines 610-614)
-- G:\dev\vibe-forge\.claude\hooks\worker-loop.sh (line 94, 111)
-
-## Migration/Remediation Steps
-1. Create sed_inplace() helper in lib/util.sh (or lib/common.sh)
-2. Replace all sed -i calls with helper
-3. Or: replace sed JSON edits with Node.js approach
-4. Test on both macOS and Linux
-5. Remove error suppression (`2>/dev/null || true`)
-
-## Acceptance Criteria
-- [x] Works on macOS/BSD
-- [x] Works on Linux
-- [x] Works on Windows (Git Bash)
-- [x] No silent error suppression (mostly - one remaining case in daemon stop)
-- [ ] Tests for cross-platform behavior (deferred - manual testing sufficient)
-
-## Implementation Notes (Completed 2026-01-16)
-
-Created `bin/lib/util.sh` with:
-- `sed_inplace()` - Cross-platform sed in-place edit helper
-- `get_platform()` - Returns normalized platform name
-- `is_git_bash()` - Check if running in Git Bash on Windows
-- `get_file_size()` - Cross-platform file size stat
-
-Updated files to use `sed_inplace()`:
-- `bin/forge-setup.sh` - All 8 sed -i calls replaced
-- `bin/forge-daemon.sh` - Platform-specific code replaced with helper

package/tasks/completed/ARCH-015-docs-todo-tracking.md

@@ -1,83 +0,0 @@
----
-id: ARCH-015
-title: "Migrate docs/TODO.md items to task files"
-type: architecture
-priority: low
-assigned_to: architect
-created_at: 2026-01-15T17:00:00Z
-created_by: architect-review
----
-
-## Summary
-The docs/TODO.md file tracks issues and improvements, but this duplicates the task tracking system. Should migrate items to proper task files.
-
-## Current State
-docs/TODO.md contains:
-- Security issues (M-1, L-1, L-2, L-3)
-- Architecture issues (sed incompatibility, exit codes, etc.)
-- Testing gaps
-- UX improvements
-- Feature ideas
-- V2 architecture plans
-
-Some items marked as fixed, others still pending.
-
-Problems:
-- Two tracking systems (TODO.md and tasks/)
-- Items in TODO.md not visible to task-based workflow
-- Duplication of effort
-- Unclear which is source of truth
-
-## Proposed State
-1. Migrate remaining items from TODO.md to tasks/pending/
-2. Keep TODO.md only for:
-   - Long-term vision (V2 architecture)
-   - Feature ideas not ready for implementation
-   - Historical record of what was done
-
-Or:
-1. Delete TODO.md entirely
-2. Use tasks/ for everything
-3. Create tasks/backlog/ for ideas not ready yet
-
-## Affected Files
-- G:\dev\vibe-forge\docs\TODO.md
-- G:\dev\vibe-forge\tasks\pending\ (new tasks)
-
-## Migration/Remediation Steps
-1. Review each item in TODO.md
-2. For actionable items: create task file in tasks/pending/
-3. For completed items: verify and remove from TODO.md
-4. For long-term ideas: keep in TODO.md or move to tasks/backlog/
-5. Update TODO.md header to clarify its purpose
-6. Add note pointing to tasks/ for actionable items
-
-## Acceptance Criteria
-- [x] All actionable items have corresponding task files
-- [x] TODO.md purpose clearly documented
-- [x] No duplicate tracking
-- [x] Clear workflow for new issues
-
----
-
-## Completion Summary
-
-```yaml
-completed_by: scribe
-completed_at: 2026-01-16T00:00:00Z
-duration_minutes: 15
-files_modified:
-  - docs/TODO.md
-files_created:
-  - tasks/pending/SEC-006-eval-agent-names.md
-  - tasks/pending/SEC-007-spawn-escaping.md
-tests_added: 0
-tests_passing: 0
-notes: |
-  Migrated M-1 and L-1 security items to task files SEC-006 and SEC-007.
-  Reorganized TODO.md to clarify its purpose (long-term vision only).
-  Added table linking old TODO items to new task IDs.
-  ARCH-014 already existed for sed incompatibility.
-blockers_encountered: []
-ready_for_review: true
-```

package/tasks/completed/CLEAN-001.md

@@ -1,38 +0,0 @@
----
-id: CLEAN-001
-title: "Duplicate worker loop implementations - consolidate shell and JavaScript versions"
-type: code-quality
-priority: medium
-assigned_to: furnace
-created_at: 2026-01-15T17:00:00Z
-created_by: sentinel-review
-completed_at: 2026-01-16T00:00:00Z
-completed_by: furnace
----
-
-## Summary
-There are two parallel implementations of the worker loop stop hook:
-1. `.claude/hooks/worker-loop.sh` (Bash implementation)
-2. `.claude/hooks/worker-loop.js` (Node.js implementation)
-
-Both implement the same logic but with subtle differences. The settings.local.json only uses the JS version now. The shell version appears to be dead code that should be removed or archived.
-
-## Affected Files/Lines
-- `.claude/hooks/worker-loop.sh` - entire file (142 lines) - appears unused
-- `.claude/hooks/worker-loop.js` - active implementation
-- `.claude/settings.local.json:27` - references only worker-loop.js
-
-## Remediation
-1. Verify the shell script is not referenced anywhere else in the codebase
-2. If unused, either:
-   - Remove `.claude/hooks/worker-loop.sh` entirely
-   - Or move it to a `deprecated/` folder with a note explaining the consolidation
-3. Update any documentation that might reference the shell version
-
-## Acceptance Criteria
-- [x] Confirm shell version is not used anywhere
-- [x] Remove or archive the unused shell implementation
-- [x] Single source of truth for worker loop logic
-
-## Resolution
-Confirmed shell version was not referenced in code (only in documentation). Removed `.claude/hooks/worker-loop.sh` entirely. The Node.js implementation (`.claude/hooks/worker-loop.js`) is the canonical source. Updated documentation references in worker-loop.md and TODO.md. This consolidates with ARCH-003.

package/tasks/completed/CLEAN-003.md

@@ -1,47 +0,0 @@
----
-id: CLEAN-003
-title: "Magic numbers in daemon configuration should be constants"
-type: code-quality
-priority: low
-assigned_to: furnace
-created_at: 2026-01-15T17:00:00Z
-created_by: sentinel-review
-completed_at: 2026-01-16T00:00:00Z
-completed_by: furnace
----
-
-## Summary
-The forge-daemon.sh contains several magic numbers that would be clearer as named constants:
-- `MAX_LOG_SIZE=1048576` is defined but `MAX_NOTIFY_ENTRIES=1000` lacks context
-- `stale_threshold=300` (5 minutes) is defined inline in multiple functions
-- Iteration counts like `100` for periodic maintenance lack explanation
-
-## Affected Files/Lines
-- `bin/forge-daemon.sh:44` - MAX_NOTIFY_ENTRIES=1000 (no comment explaining the choice)
-- `bin/forge-daemon.sh:309` - stale_threshold=300 (duplicated from line 329)
-- `bin/forge-daemon.sh:521` - `if [[ $((iteration % 100)) -eq 0 ]]` - magic number
-
-## Remediation
-1. Add comments explaining why these specific values were chosen
-2. Consider moving `stale_threshold` to constants.sh to avoid duplication
-3. Define `MAINTENANCE_INTERVAL=100` as a constant
-
-## Acceptance Criteria
-- [x] All magic numbers have explanatory comments
-- [x] Duplicated threshold values consolidated to single definition
-- [x] Constants are documented with their purpose
-
-## Resolution
-Added new constants to `bin/lib/constants.sh`:
-- `MAX_LOG_SIZE=1048576` - 1MB log rotation threshold
-- `MAX_NOTIFY_ENTRIES=1000` - Maximum notification log entries
-- `STALE_STATUS_THRESHOLD=300` - 5 minutes staleness threshold
-- `MAINTENANCE_INTERVAL=100` - Iterations between maintenance runs
-- `STALE_CLEANUP_MINUTES=30` - Agent status cleanup threshold
-- `HISTORY_PRUNE_DAYS=7` - Status history retention period
-
-Updated `bin/forge-daemon.sh` to use these constants:
-- Removed duplicate local definitions of MAX_LOG_SIZE, MAX_NOTIFY_ENTRIES
-- `build_worker_status()` now uses `$STALE_STATUS_THRESHOLD` instead of hardcoded 300
-- `cmd_status()` now uses `$STALE_STATUS_THRESHOLD` instead of hardcoded 300
-- Maintenance loop now uses `$MAINTENANCE_INTERVAL`, `$STALE_CLEANUP_MINUTES`, `$HISTORY_PRUNE_DAYS`