vibe-forge 0.4.0 → 0.8.1

package/bin/lib/json.sh

@@ -1,258 +1,264 @@
-#!/usr/bin/env bash
-#
-# Vibe Forge - JSON Utilities (Node.js based)
-#
-# Provides safe JSON operations using Node.js instead of jq.
-# This standardizes JSON handling across the codebase and removes
-# the implicit jq dependency.
-#
-# SECURITY: All functions pass values as command-line arguments,
-# never interpolated into the Node.js code.
-#
-
-# =============================================================================
-# JSON Reading Functions
-# =============================================================================
-
-# json_read FILE KEY [DEFAULT]
-# Reads a single key from a JSON file.
-# Returns the value or default (empty string if not provided).
-#
-# Example: value=$(json_read config.json "name" "unknown")
-json_read() {
-    local file="$1"
-    local key="$2"
-    local default="${3:-}"
-
-    if [[ ! -f "$file" ]]; then
-        echo "$default"
-        return 1
-    fi
-
-    local result
-    result=$(node -e '
-        const fs = require("fs");
-        const file = process.argv[1];
-        const key = process.argv[2];
-        const defaultVal = process.argv[3] || "";
-        try {
-            const data = JSON.parse(fs.readFileSync(file, "utf8"));
-            const value = data[key];
-            if (value !== undefined && value !== null) {
-                console.log(String(value));
-            } else {
-                console.log(defaultVal);
-            }
-        } catch (e) {
-            console.log(defaultVal);
-            process.exit(1);
-        }
-    ' -- "$file" "$key" "$default" 2>/dev/null)
-
-    echo "$result"
-}
-
-# json_read_multi FILE KEY1 KEY2 ...
-# Reads multiple keys from a JSON file efficiently (single Node.js call).
-# Outputs tab-separated values in the order of keys provided.
-# Missing keys return empty string.
-#
-# Example: read -r name status task <<< "$(json_read_multi file.json name status task)"
-json_read_multi() {
-    local file="$1"
-    shift
-    local keys=("$@")
-
-    if [[ ! -f "$file" ]]; then
-        # Output empty strings for each key
-        local empty=""
-        for ((i=0; i<${#keys[@]}; i++)); do
-            empty+="\t"
-        done
-        echo "${empty:1}"  # Remove leading tab
-        return 1
-    fi
-
-    # Pass keys as JSON array for clean parsing
-    local keys_json
-    keys_json=$(printf '%s\n' "${keys[@]}" | node -e '
-        const lines = require("fs").readFileSync(0, "utf8").trim().split("\n");
-        console.log(JSON.stringify(lines));
-    ')
-
-    node -e '
-        const fs = require("fs");
-        const file = process.argv[1];
-        const keys = JSON.parse(process.argv[2]);
-        try {
-            const data = JSON.parse(fs.readFileSync(file, "utf8"));
-            const values = keys.map(k => {
-                const v = data[k];
-                return (v !== undefined && v !== null) ? String(v) : "";
-            });
-            console.log(values.join("\t"));
-        } catch (e) {
-            console.log(keys.map(() => "").join("\t"));
-            process.exit(1);
-        }
-    ' -- "$file" "$keys_json" 2>/dev/null
-}
-
-# json_read_all FILE
-# Reads all keys from a JSON file and outputs key=value lines.
-# Useful for loading all config values at once.
-#
-# Example: eval "$(json_read_all config.json | sed 's/^/export /')"
-json_read_all() {
-    local file="$1"
-
-    if [[ ! -f "$file" ]]; then
-        return 1
-    fi
-
-    node -e '
-        const fs = require("fs");
-        const file = process.argv[1];
-        try {
-            const data = JSON.parse(fs.readFileSync(file, "utf8"));
-            for (const [key, value] of Object.entries(data)) {
-                if (typeof value !== "object") {
-                    // Escape for shell: single quotes, backslashes
-                    const escaped = String(value).replace(/\\/g, "\\\\").replace(/"/g, "\\\"");
-                    console.log(`${key}="${escaped}"`);
-                }
-            }
-        } catch (e) {
-            process.exit(1);
-        }
-    ' -- "$file" 2>/dev/null
-}
-
-# =============================================================================
-# JSON Writing Functions
-# =============================================================================
-
-# json_write FILE KEY VALUE
-# Writes/updates a single key in a JSON file.
-# Creates the file if it does not exist.
-#
-# Example: json_write config.json "enabled" "true"
-json_write() {
-    local file="$1"
-    local key="$2"
-    local value="$3"
-
-    node -e '
-        const fs = require("fs");
-        const file = process.argv[1];
-        const key = process.argv[2];
-        const value = process.argv[3];
-        let data = {};
-        try {
-            if (fs.existsSync(file)) {
-                data = JSON.parse(fs.readFileSync(file, "utf8"));
-            }
-        } catch (e) {}
-
-        // Try to parse value as boolean or number
-        if (value === "true") {
-            data[key] = true;
-        } else if (value === "false") {
-            data[key] = false;
-        } else if (value === "null") {
-            data[key] = null;
-        } else if (!isNaN(value) && value.trim() !== "") {
-            data[key] = Number(value);
-        } else {
-            data[key] = value;
-        }
-
-        fs.writeFileSync(file, JSON.stringify(data, null, 2) + "\n");
-    ' -- "$file" "$key" "$value" 2>/dev/null
-}
-
-# json_write_bool FILE KEY BOOL_VALUE
-# Writes a boolean value (ensures proper true/false, not string).
-#
-# Example: json_write_bool config.json "enabled" true
-json_write_bool() {
-    local file="$1"
-    local key="$2"
-    local value="$3"
-
-    # Normalize to "true" or "false"
-    case "$value" in
-        true|1|on|yes|enabled) value="true" ;;
-        *) value="false" ;;
-    esac
-
-    node -e '
-        const fs = require("fs");
-        const file = process.argv[1];
-        const key = process.argv[2];
-        const value = process.argv[3] === "true";
-        let data = {};
-        try {
-            if (fs.existsSync(file)) {
-                data = JSON.parse(fs.readFileSync(file, "utf8"));
-            }
-        } catch (e) {}
-        data[key] = value;
-        fs.writeFileSync(file, JSON.stringify(data, null, 2) + "\n");
-    ' -- "$file" "$key" "$value" 2>/dev/null
-}
-
-# =============================================================================
-# JSON Display Functions
-# =============================================================================
-
-# json_pretty FILE
-# Pretty-prints a JSON file with 2-space indentation.
-#
-# Example: json_pretty config.json
-json_pretty() {
-    local file="$1"
-
-    if [[ ! -f "$file" ]]; then
-        echo "{}"
-        return 1
-    fi
-
-    node -e '
-        const fs = require("fs");
-        const file = process.argv[1];
-        try {
-            const data = JSON.parse(fs.readFileSync(file, "utf8"));
-            console.log(JSON.stringify(data, null, 2));
-        } catch (e) {
-            console.error("Invalid JSON:", e.message);
-            process.exit(1);
-        }
-    ' -- "$file" 2>/dev/null
-}
-
-# json_has_key FILE KEY
-# Checks if a key exists in a JSON file.
-# Returns 0 if key exists, 1 otherwise.
-#
-# Example: if json_has_key config.json "enabled"; then ...
-json_has_key() {
-    local file="$1"
-    local key="$2"
-
-    if [[ ! -f "$file" ]]; then
-        return 1
-    fi
-
-    node -e '
-        const fs = require("fs");
-        const file = process.argv[1];
-        const key = process.argv[2];
-        try {
-            const data = JSON.parse(fs.readFileSync(file, "utf8"));
-            process.exit(key in data ? 0 : 1);
-        } catch (e) {
-            process.exit(1);
-        }
-    ' -- "$file" "$key" 2>/dev/null
-}
+#!/usr/bin/env bash
+#
+# Vibe Forge - JSON Utilities (Node.js based)
+#
+# Provides safe JSON operations using Node.js instead of jq.
+# This standardizes JSON handling across the codebase and removes
+# the implicit jq dependency.
+#
+# SECURITY: All functions pass values as command-line arguments,
+# never interpolated into the Node.js code.
+#
+
+# =============================================================================
+# JSON Reading Functions
+# =============================================================================
+
+# json_read FILE KEY [DEFAULT]
+# Reads a single key from a JSON file.
+# Returns the value or default (empty string if not provided).
+#
+# Example: value=$(json_read config.json "name" "unknown")
+json_read() {
+    local file="$1"
+    local key="$2"
+    local default="${3:-}"
+
+    if [[ ! -f "$file" ]]; then
+        echo "$default"
+        return 1
+    fi
+
+    local result
+    result=$(node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        const key = process.argv[2];
+        const defaultVal = process.argv[3] || "";
+        try {
+            const data = JSON.parse(fs.readFileSync(file, "utf8"));
+            const value = data[key];
+            if (value !== undefined && value !== null) {
+                console.log(String(value));
+            } else {
+                console.log(defaultVal);
+            }
+        } catch (e) {
+            console.log(defaultVal);
+            process.exit(1);
+        }
+    ' -- "$file" "$key" "$default" 2>/dev/null)
+
+    echo "$result"
+}
+
+# json_read_multi FILE KEY1 KEY2 ...
+# Reads multiple keys from a JSON file efficiently (single Node.js call).
+# Outputs tab-separated values in the order of keys provided.
+# Missing keys return empty string.
+#
+# Example: read -r name status task <<< "$(json_read_multi file.json name status task)"
+json_read_multi() {
+    local file="$1"
+    shift
+    local keys=("$@")
+
+    if [[ ! -f "$file" ]]; then
+        # Output empty strings for each key
+        local empty=""
+        for ((i=0; i<${#keys[@]}; i++)); do
+            empty+="\t"
+        done
+        echo "${empty:1}"  # Remove leading tab
+        return 1
+    fi
+
+    # Pass keys as JSON array for clean parsing
+    local keys_json
+    keys_json=$(printf '%s\n' "${keys[@]}" | node -e '
+        const lines = require("fs").readFileSync(0, "utf8").trim().split("\n");
+        console.log(JSON.stringify(lines));
+    ')
+
+    node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        const keys = JSON.parse(process.argv[2]);
+        try {
+            const data = JSON.parse(fs.readFileSync(file, "utf8"));
+            const values = keys.map(k => {
+                const v = data[k];
+                return (v !== undefined && v !== null) ? String(v) : "";
+            });
+            console.log(values.join("\t"));
+        } catch (e) {
+            console.log(keys.map(() => "").join("\t"));
+            process.exit(1);
+        }
+    ' -- "$file" "$keys_json" 2>/dev/null
+}
+
+# json_read_all FILE
+# Reads all keys from a JSON file and outputs key=value lines.
+# Useful for loading all config values at once.
+#
+# SECURITY WARNING: Do NOT use this function with eval on untrusted JSON files.
+# JSON key names are NOT validated or escaped - a malicious key name like
+# "FOO=1; evil_command; export BAR" would result in arbitrary code execution.
+# Only use with fully trusted, version-controlled config files.
+#
+# Safe usage (read individual values): json_read FILE KEY
+# Unsafe pattern to avoid: eval "$(json_read_all untrusted.json | sed 's/^/export /')"
+json_read_all() {
+    local file="$1"
+
+    if [[ ! -f "$file" ]]; then
+        return 1
+    fi
+
+    node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        try {
+            const data = JSON.parse(fs.readFileSync(file, "utf8"));
+            for (const [key, value] of Object.entries(data)) {
+                if (typeof value !== "object") {
+                    // Escape for shell: single quotes, backslashes
+                    const escaped = String(value).replace(/\\/g, "\\\\").replace(/"/g, "\\\"");
+                    console.log(`${key}="${escaped}"`);
+                }
+            }
+        } catch (e) {
+            process.exit(1);
+        }
+    ' -- "$file" 2>/dev/null
+}
+
+# =============================================================================
+# JSON Writing Functions
+# =============================================================================
+
+# json_write FILE KEY VALUE
+# Writes/updates a single key in a JSON file.
+# Creates the file if it does not exist.
+#
+# Example: json_write config.json "enabled" "true"
+json_write() {
+    local file="$1"
+    local key="$2"
+    local value="$3"
+
+    node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        const key = process.argv[2];
+        const value = process.argv[3];
+        let data = {};
+        try {
+            if (fs.existsSync(file)) {
+                data = JSON.parse(fs.readFileSync(file, "utf8"));
+            }
+        } catch (e) {}
+
+        // Try to parse value as boolean or number
+        if (value === "true") {
+            data[key] = true;
+        } else if (value === "false") {
+            data[key] = false;
+        } else if (value === "null") {
+            data[key] = null;
+        } else if (!isNaN(value) && value.trim() !== "") {
+            data[key] = Number(value);
+        } else {
+            data[key] = value;
+        }
+
+        fs.writeFileSync(file, JSON.stringify(data, null, 2) + "\n");
+    ' -- "$file" "$key" "$value" 2>/dev/null
+}
+
+# json_write_bool FILE KEY BOOL_VALUE
+# Writes a boolean value (ensures proper true/false, not string).
+#
+# Example: json_write_bool config.json "enabled" true
+json_write_bool() {
+    local file="$1"
+    local key="$2"
+    local value="$3"
+
+    # Normalize to "true" or "false"
+    case "$value" in
+        true|1|on|yes|enabled) value="true" ;;
+        *) value="false" ;;
+    esac
+
+    node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        const key = process.argv[2];
+        const value = process.argv[3] === "true";
+        let data = {};
+        try {
+            if (fs.existsSync(file)) {
+                data = JSON.parse(fs.readFileSync(file, "utf8"));
+            }
+        } catch (e) {}
+        data[key] = value;
+        fs.writeFileSync(file, JSON.stringify(data, null, 2) + "\n");
+    ' -- "$file" "$key" "$value" 2>/dev/null
+}
+
+# =============================================================================
+# JSON Display Functions
+# =============================================================================
+
+# json_pretty FILE
+# Pretty-prints a JSON file with 2-space indentation.
+#
+# Example: json_pretty config.json
+json_pretty() {
+    local file="$1"
+
+    if [[ ! -f "$file" ]]; then
+        echo "{}"
+        return 1
+    fi
+
+    node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        try {
+            const data = JSON.parse(fs.readFileSync(file, "utf8"));
+            console.log(JSON.stringify(data, null, 2));
+        } catch (e) {
+            console.error("Invalid JSON:", e.message);
+            process.exit(1);
+        }
+    ' -- "$file" 2>/dev/null
+}
+
+# json_has_key FILE KEY
+# Checks if a key exists in a JSON file.
+# Returns 0 if key exists, 1 otherwise.
+#
+# Example: if json_has_key config.json "enabled"; then ...
+json_has_key() {
+    local file="$1"
+    local key="$2"
+
+    if [[ ! -f "$file" ]]; then
+        return 1
+    fi
+
+    node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        const key = process.argv[2];
+        try {
+            const data = JSON.parse(fs.readFileSync(file, "utf8"));
+            process.exit(key in data ? 0 : 1);
+        } catch (e) {
+            process.exit(1);
+        }
+    ' -- "$file" "$key" 2>/dev/null
+}