vibe-forge 0.4.0 → 0.8.1

package/bin/lib/constants.sh

@@ -1,206 +1,241 @@
-#!/usr/bin/env bash
-#
-# Vibe Forge - Shared Constants
-# Source this file in other scripts: source "$SCRIPT_DIR/lib/constants.sh"
-#
-# NOTE: Agent configuration should be loaded from config/agents.json via
-# load_agents_from_json() in config.sh. The hardcoded values below are
-# fallback defaults for when JSON loading is not possible (e.g., tests).
-#
-
-# =============================================================================
-# Exit Codes
-# =============================================================================
-# Standardized exit codes for consistent error handling across scripts
-# Based on BSD sysexits.h conventions with project-specific additions
-
-EXIT_SUCCESS=0               # Successful execution
-EXIT_GENERAL_ERROR=1         # Generic/unspecified error
-EXIT_CONFIG_ERROR=2          # Configuration file missing/invalid
-EXIT_DEPENDENCY_MISSING=3    # Required dependency not found (Claude Code, Git Bash, etc.)
-EXIT_INVALID_ARGUMENT=4      # Invalid argument (unknown agent, unknown command)
-EXIT_RUNTIME_ERROR=5         # Runtime error (daemon conflict, spawn failed, etc.)
-
-# Timing
-POLL_INTERVAL=2              # seconds between daemon task checks
-NOTIFICATION_DEBOUNCE=1      # seconds to avoid notification spam
-
-# Daemon Configuration
-MAX_LOG_SIZE=1048576         # 1MB - log rotation threshold
-MAX_NOTIFY_ENTRIES=1000      # Maximum notification log entries before trimming
-STALE_STATUS_THRESHOLD=300   # 5 minutes - when worker status is considered stale
-MAINTENANCE_INTERVAL=100     # Daemon iterations between maintenance runs
-STALE_CLEANUP_MINUTES=30     # Remove agent status older than this (minutes)
-HISTORY_PRUNE_DAYS=7         # Remove status history older than this (days)
-
-# Directory structure (relative to FORGE_ROOT)
-CONFIG_DIR=".forge"
-TASKS_DIR="tasks"
-TASKS_PENDING="$TASKS_DIR/pending"
-TASKS_IN_PROGRESS="$TASKS_DIR/in-progress"
-TASKS_COMPLETED="$TASKS_DIR/completed"
-TASKS_REVIEW="$TASKS_DIR/review"
-TASKS_APPROVED="$TASKS_DIR/approved"
-TASKS_NEEDS_CHANGES="$TASKS_DIR/needs-changes"
-TASKS_MERGED="$TASKS_DIR/merged"
-TASKS_ATTENTION="$TASKS_DIR/attention"
-CONTEXT_DIR="context"
-AGENT_STATUS_DIR="$CONTEXT_DIR/agent-status"
-AGENTS_DIR="agents"
-
-# Config files
-AGENTS_CONFIG="config/agents.json"
-
-# =============================================================================
-# Agent Configuration (Fallback Defaults)
-# =============================================================================
-# These values are overwritten when load_agents_from_json() is called.
-# They exist as fallback for contexts where JSON loading isn't available.
-
-# Flag to track if agents were loaded from JSON
-AGENTS_LOADED="${AGENTS_LOADED:-false}"
-
-# Valid agent names (whitelist for security)
-# These are the ONLY valid canonical agent names
-# NOTE: Must stay in sync with config/agents.json (which is the source of truth)
-# Last sync: 2026-01-16
-VALID_AGENTS=(
-    "hub"
-    "sentinel"
-    "anvil"
-    "furnace"
-    "crucible"
-    "scribe"
-    "herald"
-    "ember"
-    "aegis"
-    "architect"
-)
-
-# Agent aliases map (for resolve_agent)
-# Format: alias=canonical
-# NOTE: Must stay in sync with config/agents.json (which is the source of truth)
-declare -A AGENT_ALIASES=(
-    # Hub aliases (Chief Orchestrator)
-    ["hub"]="hub"
-    ["planning"]="hub"
-    ["master"]="hub"
-    ["forge-master"]="hub"
-    # Sentinel aliases (Code Reviewer)
-    ["sentinel"]="sentinel"
-    ["review"]="sentinel"
-    ["reviewer"]="sentinel"
-    ["cr"]="sentinel"
-    # Anvil aliases (Frontend)
-    ["anvil"]="anvil"
-    ["frontend"]="anvil"
-    ["ui"]="anvil"
-    ["fe"]="anvil"
-    # Furnace aliases (Backend)
-    ["furnace"]="furnace"
-    ["backend"]="furnace"
-    ["api"]="furnace"
-    ["be"]="furnace"
-    # Crucible aliases (Testing)
-    ["crucible"]="crucible"
-    ["test"]="crucible"
-    ["testing"]="crucible"
-    ["qa"]="crucible"
-    ["tester"]="crucible"
-    # Scribe aliases (Documentation)
-    ["scribe"]="scribe"
-    ["docs"]="scribe"
-    ["documentation"]="scribe"
-    ["doc"]="scribe"
-    # Herald aliases (Release)
-    ["herald"]="herald"
-    ["release"]="herald"
-    ["deploy"]="herald"
-    ["deployment"]="herald"
-    # Ember aliases (DevOps)
-    ["ember"]="ember"
-    ["devops"]="ember"
-    ["ops"]="ember"
-    ["infra"]="ember"
-    ["infrastructure"]="ember"
-    # Aegis aliases (Security)
-    ["aegis"]="aegis"
-    ["security"]="aegis"
-    ["sec"]="aegis"
-    ["appsec"]="aegis"
-    # Architect aliases (System Design)
-    ["architect"]="architect"
-    ["arch"]="architect"
-    ["design"]="architect"
-    ["sage"]="architect"
-)
-
-# Agent display names
-declare -A AGENT_DISPLAY_NAMES=(
-    ["hub"]="Planning Hub"
-    ["sentinel"]="Sentinel"
-    ["anvil"]="Anvil"
-    ["furnace"]="Furnace"
-    ["crucible"]="Crucible"
-    ["scribe"]="Scribe"
-    ["herald"]="Herald"
-    ["ember"]="Ember"
-    ["aegis"]="Aegis"
-    ["architect"]="Architect"
-)
-
-# Agent roles
-declare -A AGENT_ROLES=(
-    ["hub"]="Chief Orchestrator"
-    ["sentinel"]="Code Reviewer"
-    ["anvil"]="Frontend Developer"
-    ["furnace"]="Backend Developer"
-    ["crucible"]="Tester / QA"
-    ["scribe"]="Documentation Specialist"
-    ["herald"]="Release Manager"
-    ["ember"]="DevOps Engineer"
-    ["aegis"]="Security Specialist"
-    ["architect"]="System Architect"
-)
-
-# Agent personality files (relative to FORGE_ROOT)
-declare -A AGENT_PERSONALITY_FILES=(
-    ["hub"]="agents/planning-hub/personality.md"
-    ["sentinel"]="agents/sentinel/personality.md"
-    ["anvil"]="agents/anvil/personality.md"
-    ["furnace"]="agents/furnace/personality.md"
-    ["crucible"]="agents/crucible/personality.md"
-    ["scribe"]="agents/scribe/personality.md"
-    ["herald"]="agents/herald/personality.md"
-    ["ember"]="agents/ember/personality.md"
-    ["aegis"]="agents/aegis/personality.md"
-    ["architect"]="agents/architect/personality.md"
-)
-
-# Agent icons
-declare -A AGENT_ICONS=(
-    ["hub"]="⚒️"
-    ["sentinel"]="🛡️"
-    ["anvil"]="🔨"
-    ["furnace"]="🔥"
-    ["crucible"]="🧪"
-    ["scribe"]="📜"
-    ["herald"]="📯"
-    ["ember"]="⚙️"
-    ["aegis"]="🔒"
-    ["architect"]="🏛️"
-)
-
-# Agent tab colors for Windows Terminal (hex format)
-declare -A AGENT_TAB_COLORS=(
-    ["hub"]="#FF6B35"
-    ["sentinel"]="#8B5CF6"
-    ["anvil"]="#3B82F6"
-    ["furnace"]="#EF4444"
-    ["crucible"]="#10B981"
-    ["scribe"]="#F59E0B"
-    ["herald"]="#EC4899"
-    ["ember"]="#F97316"
-    ["aegis"]="#06B6D4"
-    ["architect"]="#6366F1"
-)
+#!/usr/bin/env bash
+#
+# Vibe Forge - Shared Constants
+# Source this file in other scripts: source "$SCRIPT_DIR/lib/constants.sh"
+#
+# NOTE: Agent configuration should be loaded from config/agents.json via
+# load_agents_from_json() in config.sh. The hardcoded values below are
+# fallback defaults for when JSON loading is not possible (e.g., tests).
+#
+
+# =============================================================================
+# Exit Codes
+# =============================================================================
+# Standardized exit codes for consistent error handling across scripts
+# Based on BSD sysexits.h conventions with project-specific additions
+
+EXIT_SUCCESS=0               # Successful execution
+EXIT_GENERAL_ERROR=1         # Generic/unspecified error
+EXIT_CONFIG_ERROR=2          # Configuration file missing/invalid
+EXIT_DEPENDENCY_MISSING=3    # Required dependency not found (Claude Code, Git Bash, etc.)
+EXIT_INVALID_ARGUMENT=4      # Invalid argument (unknown agent, unknown command)
+EXIT_RUNTIME_ERROR=5         # Runtime error (daemon conflict, spawn failed, etc.)
+
+# Timing
+POLL_INTERVAL=2              # seconds between daemon task checks
+NOTIFICATION_DEBOUNCE=1      # seconds to avoid notification spam
+
+# Daemon Configuration
+MAX_LOG_SIZE=1048576         # 1MB - log rotation threshold
+MAX_NOTIFY_ENTRIES=1000      # Maximum notification log entries before trimming
+STALE_STATUS_THRESHOLD=300   # 5 minutes - when worker status is considered stale
+MAINTENANCE_INTERVAL=100     # Daemon iterations between maintenance runs
+STALE_CLEANUP_MINUTES=30     # Remove agent status older than this (minutes)
+HISTORY_PRUNE_DAYS=7         # Remove status history older than this (days)
+
+# Directory structure (relative to FORGE_ROOT)
+CONFIG_DIR=".forge"
+TASKS_DIR="tasks"
+TASKS_PENDING="$TASKS_DIR/pending"
+TASKS_IN_PROGRESS="$TASKS_DIR/in-progress"
+TASKS_COMPLETED="$TASKS_DIR/completed"
+TASKS_REVIEW="$TASKS_DIR/review"
+TASKS_APPROVED="$TASKS_DIR/approved"
+TASKS_NEEDS_CHANGES="$TASKS_DIR/needs-changes"
+TASKS_MERGED="$TASKS_DIR/merged"
+TASKS_ATTENTION="$TASKS_DIR/attention"
+CONTEXT_DIR="context"
+AGENT_STATUS_DIR="$CONTEXT_DIR/agent-status"
+AGENTS_DIR="agents"
+
+# Config files
+AGENTS_CONFIG="config/agents.json"
+
+# =============================================================================
+# Agent Configuration (Fallback Defaults)
+# =============================================================================
+# These values are overwritten when load_agents_from_json() is called.
+# They exist as fallback for contexts where JSON loading isn't available.
+
+# Flag to track if agents were loaded from JSON
+AGENTS_LOADED="${AGENTS_LOADED:-false}"
+
+# Valid agent names (whitelist for security)
+# These are the ONLY valid canonical agent names
+# NOTE: Must stay in sync with config/agents.json (which is the source of truth)
+# Last sync: 2026-04-03 (added loki, renamed sentinel→temper)
+VALID_AGENTS=(
+    "hub"
+    "temper"
+    "anvil"
+    "furnace"
+    "crucible"
+    "scribe"
+    "herald"
+    "ember"
+    "aegis"
+    "architect"
+    "pixel"
+    "oracle"
+    "loki"
+)
+
+# Agent aliases map (for resolve_agent)
+# Format: alias=canonical
+# NOTE: Must stay in sync with config/agents.json (which is the source of truth)
+declare -A AGENT_ALIASES=(
+    # Hub aliases (Chief Orchestrator)
+    ["hub"]="hub"
+    ["planning"]="hub"
+    ["master"]="hub"
+    ["forge-master"]="hub"
+    # Temper aliases (Code Reviewer)
+    ["temper"]="temper"
+    ["review"]="temper"
+    ["reviewer"]="temper"
+    ["cr"]="temper"
+    # Anvil aliases (Frontend)
+    ["anvil"]="anvil"
+    ["frontend"]="anvil"
+    ["ui"]="anvil"
+    ["fe"]="anvil"
+    # Furnace aliases (Backend)
+    ["furnace"]="furnace"
+    ["backend"]="furnace"
+    ["api"]="furnace"
+    ["be"]="furnace"
+    # Crucible aliases (Testing)
+    ["crucible"]="crucible"
+    ["test"]="crucible"
+    ["testing"]="crucible"
+    ["qa"]="crucible"
+    ["tester"]="crucible"
+    # Scribe aliases (Documentation)
+    ["scribe"]="scribe"
+    ["docs"]="scribe"
+    ["documentation"]="scribe"
+    ["doc"]="scribe"
+    # Herald aliases (Release)
+    ["herald"]="herald"
+    ["release"]="herald"
+    ["deploy"]="herald"
+    ["deployment"]="herald"
+    # Ember aliases (DevOps)
+    ["ember"]="ember"
+    ["devops"]="ember"
+    ["ops"]="ember"
+    ["infra"]="ember"
+    ["infrastructure"]="ember"
+    # Aegis aliases (Security)
+    ["aegis"]="aegis"
+    ["security"]="aegis"
+    ["sec"]="aegis"
+    ["appsec"]="aegis"
+    # Architect aliases (System Design)
+    ["architect"]="architect"
+    ["arch"]="architect"
+    ["sage"]="architect"
+    # Pixel aliases (UX Design)
+    # NOTE: "design" intentionally removed — ambiguous with architect's technical design domain
+    ["pixel"]="pixel"
+    ["ux"]="pixel"
+    ["ui-design"]="pixel"
+    ["user-experience"]="pixel"
+    # Oracle aliases (Product / Requirements)
+    ["oracle"]="oracle"
+    ["product"]="oracle"
+    ["po"]="oracle"
+    ["requirements"]="oracle"
+    ["req"]="oracle"
+    ["analyst"]="oracle"
+    # Loki aliases (Lateral Thinker)
+    ["loki"]="loki"
+    ["trickster"]="loki"
+    ["contrarian"]="loki"
+    ["brainstorm"]="loki"
+)
+
+# Agent display names
+declare -A AGENT_DISPLAY_NAMES=(
+    ["hub"]="Planning Hub"
+    ["temper"]="Temper"
+    ["anvil"]="Anvil"
+    ["furnace"]="Furnace"
+    ["crucible"]="Crucible"
+    ["scribe"]="Scribe"
+    ["herald"]="Herald"
+    ["ember"]="Ember"
+    ["aegis"]="Aegis"
+    ["architect"]="Architect"
+    ["pixel"]="Pixel"
+    ["oracle"]="Oracle"
+    ["loki"]="Loki"
+)
+
+# Agent roles
+declare -A AGENT_ROLES=(
+    ["hub"]="Chief Orchestrator"
+    ["temper"]="Code Reviewer"
+    ["anvil"]="Frontend Developer"
+    ["furnace"]="Backend Developer"
+    ["crucible"]="Tester / QA"
+    ["scribe"]="Documentation Specialist"
+    ["herald"]="Release Manager"
+    ["ember"]="DevOps Engineer"
+    ["aegis"]="Security Specialist"
+    ["architect"]="System Architect"
+    ["pixel"]="UX Designer"
+    ["oracle"]="Product Owner / Requirements Analyst"
+    ["loki"]="Lateral Thinker"
+)
+
+# Agent personality files (relative to FORGE_ROOT)
+declare -A AGENT_PERSONALITY_FILES=(
+    ["hub"]="agents/planning-hub/personality.md"
+    ["temper"]="agents/temper/personality.md"
+    ["anvil"]="agents/anvil/personality.md"
+    ["furnace"]="agents/furnace/personality.md"
+    ["crucible"]="agents/crucible/personality.md"
+    ["scribe"]="agents/scribe/personality.md"
+    ["herald"]="agents/herald/personality.md"
+    ["ember"]="agents/ember/personality.md"
+    ["aegis"]="agents/aegis/personality.md"
+    ["architect"]="agents/architect/personality.md"
+    ["pixel"]="agents/pixel/personality.md"
+    ["oracle"]="agents/oracle/personality.md"
+    ["loki"]="agents/loki/personality.md"
+)
+
+# Agent icons
+declare -A AGENT_ICONS=(
+    ["hub"]="⚒️"
+    ["temper"]="⚖️"
+    ["anvil"]="🔨"
+    ["furnace"]="🔥"
+    ["crucible"]="🧪"
+    ["scribe"]="📜"
+    ["herald"]="📯"
+    ["ember"]="⚙️"
+    ["aegis"]="🔒"
+    ["architect"]="🏛️"
+    ["pixel"]="🎨"
+    ["oracle"]="🔮"
+    ["loki"]="🎭"
+)
+
+# Agent tab colors for Windows Terminal (hex format)
+declare -A AGENT_TAB_COLORS=(
+    ["hub"]="#FF6B35"
+    ["temper"]="#8B5CF6"
+    ["anvil"]="#3B82F6"
+    ["furnace"]="#EF4444"
+    ["crucible"]="#10B981"
+    ["scribe"]="#F59E0B"
+    ["herald"]="#EC4899"
+    ["ember"]="#F97316"
+    ["aegis"]="#06B6D4"
+    ["architect"]="#6366F1"
+    ["pixel"]="#D946EF"
+    ["oracle"]="#FBBF24"
+    ["loki"]="#7C3AED"
+)

package/bin/lib/daemon/budgets.sh

@@ -0,0 +1,107 @@
+#!/usr/bin/env bash
+#
+# bin/lib/daemon/budgets.sh
+#
+# Token budget warnings (T2-F1)
+#
+# Monitors agent session duration as a proxy for token consumption.
+# Claude Code sessions don't expose token counts externally, so we
+# estimate from how long an agent has been continuously "working" on
+# a single task. Agents working beyond the warning threshold get an
+# attention file so the user knows to check on them.
+#
+# Dependencies: database.sh, constants.sh
+# Globals required: FORGE_ROOT, FORGE_DB, TASKS_ATTENTION, LOG_FILE
+
+# Prevent double-sourcing
+[[ -n "${_DAEMON_BUDGETS_LOADED:-}" ]] && return 0
+_DAEMON_BUDGETS_LOADED=1
+
+# Thresholds (seconds)
+TOKEN_WARN_DURATION=${TOKEN_WARN_DURATION:-5400}   # 90 minutes
+TOKEN_URGENT_DURATION=${TOKEN_URGENT_DURATION:-7200} # 2 hours
+
+# Track which agents we've already warned about (reset when they go idle)
+declare -A _budget_warned 2>/dev/null || true
+
+check_token_budgets() {
+    local now_epoch
+    now_epoch=$(date +%s)
+
+    # Query agents currently in "working" status
+    local rows
+    rows=$(sqlite3 "$FORGE_DB" \
+        "SELECT agent, task, updated_at FROM agent_status WHERE status='working';" 2>/dev/null) || return 0
+
+    [[ -z "$rows" ]] && return 0
+
+    while IFS='|' read -r agent task updated; do
+        [[ -z "$agent" || -z "$updated" ]] && continue
+
+        # Calculate how long agent has been working
+        local updated_epoch duration
+        updated_epoch=$(date -d "$updated" +%s 2>/dev/null || echo "0")
+        [[ "$updated_epoch" -eq 0 ]] && continue
+        duration=$((now_epoch - updated_epoch))
+
+        # Skip if we already warned for this agent+task combo
+        local warn_key="${agent}:${task}"
+        [[ "${_budget_warned[$warn_key]:-}" == "1" ]] && continue
+
+        local urgency=""
+        if [[ "$duration" -ge "$TOKEN_URGENT_DURATION" ]]; then
+            urgency="urgent"
+        elif [[ "$duration" -ge "$TOKEN_WARN_DURATION" ]]; then
+            urgency="normal"
+        fi
+
+        [[ -z "$urgency" ]] && continue
+
+        # Create attention file
+        local attention_dir="$FORGE_ROOT/$TASKS_ATTENTION"
+        mkdir -p "$attention_dir"
+
+        local duration_min=$((duration / 60))
+        local attention_file="$attention_dir/token-budget-${agent}.md"
+
+        # Don't overwrite if attention file already exists
+        if [[ -f "$attention_file" ]]; then
+            _budget_warned[$warn_key]=1
+            continue
+        fi
+
+        cat > "$attention_file" << BUDGET
+---
+agent: $agent
+created: $(date -Iseconds)
+type: budget-warning
+urgency: $urgency
+---
+
+## Issue
+
+Token budget warning: **$agent** has been working on \`$task\` for ${duration_min} minutes.
+
+Long-running sessions risk context degradation. Consider:
+- Check if the agent is stuck or looping
+- Use \`/compact-context\` in the agent's session
+- Split remaining work into a new task for a fresh session
+BUDGET
+
+        _budget_warned[$warn_key]=1
+        echo "[$(date -Iseconds)] TOKEN BUDGET: $agent working ${duration_min}m on $task ($urgency)" >> "$LOG_FILE"
+    done <<< "$rows"
+
+    # Clear warnings for agents that are no longer working
+    for key in "${!_budget_warned[@]}"; do
+        local agent_part="${key%%:*}"
+        local still_working
+        still_working=$(sqlite3 "$FORGE_DB" \
+            "SELECT COUNT(*) FROM agent_status WHERE agent='$agent_part' AND status='working';" 2>/dev/null || echo "0")
+        if [[ "$still_working" -eq 0 ]]; then
+            unset "_budget_warned[$key]"
+            # Clean up attention file if agent finished
+            rm -f "$FORGE_ROOT/$TASKS_ATTENTION/token-budget-${agent_part}.md" 2>/dev/null
+        fi
+    done
+}