vibe-forge 0.4.0 → 0.8.1

package/.claude/commands/worker-loop.md

@@ -1,106 +1,106 @@
----
-description: Start a persistent worker loop (Ralph-style)
-argument-hint: <agent> [--max-idle 10] | stop
----
-
-# Worker Loop Command
-
-Start a persistent worker loop for the specified agent. The worker will:
-1. Check for assigned tasks
-2. Work on tasks until complete
-3. Loop back and check for more tasks
-4. Only exit after N idle checks with no work found
-
-## Activation Modes
-
-Worker Loop can be activated in two ways:
-
-### 1. Config-based (Recommended)
-
-Enable during `forge init` or toggle anytime:
-
-```bash
-forge config worker-loop on     # Enable for all workers
-forge config worker-loop off    # Disable
-forge config worker-loop        # Check status
-```
-
-When enabled, ALL workers will automatically stay running and check for new tasks.
-
-### 2. Runtime (Per-session)
-
-Use this command for fine-grained control:
-
-```
-/worker-loop anvil              # Start Anvil in persistent loop
-/worker-loop furnace --max-idle 20  # Custom idle limit
-/worker-loop stop               # Stop the current loop
-```
-
-## Arguments
-
-- `$1` - Agent name (anvil, furnace, crucible, etc.) or "stop"
-- `--max-idle N` - Exit after N checks with no tasks (default: 10)
-
-## Implementation
-
-Based on `$ARGUMENTS`:
-
-### If first argument is "stop"
-
-Remove the worker loop state file and confirm:
-
-```bash
-rm -f "${CLAUDE_LOCAL_DIR:-$HOME/.claude}/forge-worker-loop.json"
-```
-
-Output: "Worker loop stopped."
-
-### Otherwise, start a loop
-
-1. Resolve the agent name to canonical form
-2. Create state file at `${CLAUDE_LOCAL_DIR}/forge-worker-loop.json`:
-
-```json
-{
-  "agent": "<resolved-agent>",
-  "max_idle_checks": 10,
-  "idle_count": 0,
-  "poll_interval": 5,
-  "started_at": "<ISO timestamp>"
-}
-```
-
-3. Load the agent's personality file
-4. Start working with this system prompt addition:
-
-```
-You are in PERSISTENT WORKER MODE. After completing each task:
-1. Check for more tasks assigned to you in tasks/pending/ and tasks/needs-changes/
-2. If tasks found, immediately begin working
-3. If no tasks, announce you are idle and waiting
-
-Do NOT ask permission to continue - work autonomously until no tasks remain.
-```
-
-5. The stop hook (hooks/worker-loop.js) will intercept exit attempts and:
-   - If tasks exist: feed prompt to continue working
-   - If no tasks: increment idle counter
-   - If max idle reached: allow exit
-
-## How It Works
-
-The Worker Loop uses Claude Code's **Stop Hook** feature:
-
-1. When a worker tries to exit, the hook script runs
-2. It checks for pending tasks in `tasks/pending/` and `tasks/needs-changes/`
-3. If tasks found: blocks exit and feeds a prompt to continue working
-4. If no tasks: allows exit (or waits, depending on config)
-
-## Benefits
-
-- Workers stay active and pick up new tasks automatically
-- No need to manually respawn workers
-- Tasks can be added to pending/ and workers will find them
-- Config-based mode requires zero per-session setup
-- Configurable idle timeout prevents infinite waiting
+---
+description: Start a persistent worker loop (Ralph-style)
+argument-hint: <agent> [--max-idle 10] | stop
+---
+
+# Worker Loop Command
+
+Start a persistent worker loop for the specified agent. The worker will:
+1. Check for assigned tasks
+2. Work on tasks until complete
+3. Loop back and check for more tasks
+4. Only exit after N idle checks with no work found
+
+## Activation Modes
+
+Worker Loop can be activated in two ways:
+
+### 1. Config-based (Recommended)
+
+Enable during `forge init` or toggle anytime:
+
+```bash
+forge config worker-loop on     # Enable for all workers
+forge config worker-loop off    # Disable
+forge config worker-loop        # Check status
+```
+
+When enabled, ALL workers will automatically stay running and check for new tasks.
+
+### 2. Runtime (Per-session)
+
+Use this command for fine-grained control:
+
+```
+/worker-loop anvil              # Start Anvil in persistent loop
+/worker-loop furnace --max-idle 20  # Custom idle limit
+/worker-loop stop               # Stop the current loop
+```
+
+## Arguments
+
+- `$1` - Agent name (anvil, furnace, crucible, etc.) or "stop"
+- `--max-idle N` - Exit after N checks with no tasks (default: 10)
+
+## Implementation
+
+Based on `$ARGUMENTS`:
+
+### If first argument is "stop"
+
+Remove the worker loop state file and confirm:
+
+```bash
+rm -f "${CLAUDE_LOCAL_DIR:-$HOME/.claude}/forge-worker-loop.json"
+```
+
+Output: "Worker loop stopped."
+
+### Otherwise, start a loop
+
+1. Resolve the agent name to canonical form
+2. Create state file at `${CLAUDE_LOCAL_DIR}/forge-worker-loop.json`:
+
+```json
+{
+  "agent": "<resolved-agent>",
+  "max_idle_checks": 10,
+  "idle_count": 0,
+  "poll_interval": 5,
+  "started_at": "<ISO timestamp>"
+}
+```
+
+3. Load the agent's personality file
+4. Start working with this system prompt addition:
+
+```
+You are in PERSISTENT WORKER MODE. After completing each task:
+1. Check for more tasks assigned to you in tasks/pending/ and tasks/needs-changes/
+2. If tasks found, immediately begin working
+3. If no tasks, announce you are idle and waiting
+
+Do NOT ask permission to continue - work autonomously until no tasks remain.
+```
+
+5. The stop hook (hooks/worker-loop.js) will intercept exit attempts and:
+   - If tasks exist: feed prompt to continue working
+   - If no tasks: increment idle counter
+   - If max idle reached: allow exit
+
+## How It Works
+
+The Worker Loop uses Claude Code's **Stop Hook** feature:
+
+1. When a worker tries to exit, the hook script runs
+2. It checks for pending tasks in `tasks/pending/` and `tasks/needs-changes/`
+3. If tasks found: blocks exit and feeds a prompt to continue working
+4. If no tasks: allows exit (or waits, depending on config)
+
+## Benefits
+
+- Workers stay active and pick up new tasks automatically
+- No need to manually respawn workers
+- Tasks can be added to pending/ and workers will find them
+- Config-based mode requires zero per-session setup
+- Configurable idle timeout prevents infinite waiting

package/.claude/hooks/worker-loop.js

@@ -1,187 +1,217 @@
-#!/usr/bin/env node
-/**
- * Vibe Forge Worker Loop - Stop Hook (Cross-Platform)
- *
- * Implements the Ralph Loop technique for Vibe Forge workers.
- * When a worker tries to exit, this hook checks if there are pending tasks
- * and feeds the worker prompt back to continue working.
- *
- * Based on the Ralph Loop plugin by Anthropic.
- *
- * Activation modes:
- * 1. Config-based: worker_loop_enabled=true in .forge/config.json
- * 2. Runtime: State file created by /worker-loop command
- */
-
-const fs = require('fs');
-const path = require('path');
-const os = require('os');
-
-// State file location (runtime toggle)
-const claudeLocalDir = process.env.CLAUDE_LOCAL_DIR || path.join(os.homedir(), '.claude');
-const stateFile = path.join(claudeLocalDir, 'forge-worker-loop.json');
-const forgeRoot = process.env.FORGE_ROOT || process.cwd();
-
-// Helper to safely parse JSON
-function safeJsonParse(filePath, defaultValue = {}) {
-  try {
-    if (fs.existsSync(filePath)) {
-      return JSON.parse(fs.readFileSync(filePath, 'utf8'));
-    }
-  } catch (e) {
-    // Ignore parse errors
-  }
-  return defaultValue;
-}
-
-// Helper to count matching files
-function countFiles(dir, pattern = '*.md') {
-  try {
-    if (!fs.existsSync(dir)) return 0;
-    const files = fs.readdirSync(dir);
-    return files.filter(f => f.endsWith('.md')).length;
-  } catch (e) {
-    return 0;
-  }
-}
-
-// Helper to count files with specific content
-function countFilesWithContent(dir, searchPattern) {
-  try {
-    if (!fs.existsSync(dir)) return 0;
-    const files = fs.readdirSync(dir).filter(f => f.endsWith('.md'));
-    let count = 0;
-    for (const file of files) {
-      try {
-        const content = fs.readFileSync(path.join(dir, file), 'utf8');
-        if (content.includes(searchPattern)) {
-          count++;
-        }
-      } catch (e) {
-        // Skip files we can't read
-      }
-    }
-    return count;
-  } catch (e) {
-    return 0;
-  }
-}
-
-// Output result and exit
-function output(result) {
-  console.log(JSON.stringify(result));
-  process.exit(0);
-}
-
-// Main logic
-function main() {
-  let loopActive = false;
-  let workerAgent = '';
-  let maxIdleChecks = 10;
-  let idleCount = 0;
-  let pollInterval = 5;
-
-  // Check for runtime state file first (takes precedence)
-  if (fs.existsSync(stateFile)) {
-    const state = safeJsonParse(stateFile);
-    loopActive = true;
-    workerAgent = state.agent || '';
-    maxIdleChecks = state.max_idle_checks || 10;
-    idleCount = state.idle_count || 0;
-    pollInterval = state.poll_interval || 5;
-  }
-
-  // If no runtime state, check config-based setting
-  if (!loopActive) {
-    const configFile = path.join(forgeRoot, '.forge', 'config.json');
-    const config = safeJsonParse(configFile);
-    if (config.worker_loop_enabled === true) {
-      loopActive = true;
-      workerAgent = 'any';
-    }
-  }
-
-  // Check if worker loop is active
-  if (!loopActive) {
-    return output({ decision: 'approve' });
-  }
-
-  if (!workerAgent) {
-    // Invalid state, clean up and allow exit
-    try { fs.unlinkSync(stateFile); } catch (e) {}
-    return output({ decision: 'approve' });
-  }
-
-  // Check for pending tasks
-  const tasksDir = path.join(forgeRoot, '_vibe-forge', 'tasks');
-  let pendingCount = 0;
-  let needsChangesCount = 0;
-
-  const pendingDir = path.join(tasksDir, 'pending');
-  const needsChangesDir = path.join(tasksDir, 'needs-changes');
-
-  if (workerAgent === 'any') {
-    // Config mode: count all tasks
-    pendingCount = countFiles(pendingDir);
-    needsChangesCount = countFiles(needsChangesDir);
-  } else {
-    // Runtime mode: count only tasks assigned to specific worker
-    const searchPattern = `assigned_to: ${workerAgent}`;
-    pendingCount = countFilesWithContent(pendingDir, searchPattern);
-    needsChangesCount = countFilesWithContent(needsChangesDir, searchPattern);
-  }
-
-  const totalTasks = pendingCount + needsChangesCount;
-
-  if (totalTasks > 0) {
-    // Tasks found! Reset idle counter and continue
-    if (fs.existsSync(stateFile)) {
-      try {
-        const state = safeJsonParse(stateFile);
-        state.idle_count = 0;
-        fs.writeFileSync(stateFile, JSON.stringify(state, null, 2));
-      } catch (e) {}
-    }
-
-    return output({
-      decision: 'block',
-      message: `[Forge Loop] Found ${totalTasks} pending task(s). Continuing work...`,
-      prompt: 'Check _vibe-forge/tasks/pending/ and _vibe-forge/tasks/needs-changes/ for tasks assigned to you and begin working on them immediately.'
-    });
-  }
-
-  // No tasks - handle idle state
-  if (fs.existsSync(stateFile)) {
-    idleCount++;
-
-    try {
-      const state = safeJsonParse(stateFile);
-      state.idle_count = idleCount;
-      fs.writeFileSync(stateFile, JSON.stringify(state, null, 2));
-    } catch (e) {}
-
-    if (idleCount >= maxIdleChecks) {
-      // Max idle checks reached, clean up and allow exit
-      try { fs.unlinkSync(stateFile); } catch (e) {}
-      return output({
-        decision: 'approve',
-        message: `[Forge Loop] No tasks found after ${maxIdleChecks} checks. Exiting.`
-      });
-    }
-
-    // Still within idle limit - wait and check again
-    return output({
-      decision: 'block',
-      message: `[Forge Loop] No tasks available. Idle check ${idleCount}/${maxIdleChecks}. Waiting...`,
-      prompt: 'No tasks currently assigned to you. Wait briefly, then check _vibe-forge/tasks/pending/ and _vibe-forge/tasks/needs-changes/ again for new work. If still no tasks, announce you are idle and ready.'
-    });
-  }
-
-  // Config-based mode - no idle tracking, just allow exit when no tasks
-  return output({
-    decision: 'approve',
-    message: '[Forge Loop] No pending tasks. Worker exiting.'
-  });
-}
-
-main();
+#!/usr/bin/env node
+/**
+ * Vibe Forge Worker Loop - Stop Hook (Cross-Platform)
+ *
+ * Implements the Ralph Loop technique for Vibe Forge workers.
+ * When a worker tries to exit, this hook checks if there are pending tasks
+ * and feeds the worker prompt back to continue working.
+ *
+ * Based on the Ralph Loop plugin by Anthropic.
+ *
+ * Activation modes:
+ * 1. Config-based: worker_loop_enabled=true in .forge/config.json
+ * 2. Runtime: State file created by /worker-loop command
+ */
+
+const fs = require('fs');
+const path = require('path');
+const os = require('os');
+
+// State file location (runtime toggle)
+const claudeLocalDir = process.env.CLAUDE_LOCAL_DIR || path.join(os.homedir(), '.claude');
+const stateFile = path.join(claudeLocalDir, 'forge-worker-loop.json');
+// SEC-005: Validate FORGE_ROOT to prevent path traversal via attacker-controlled env
+const rawForgeRoot = process.env.FORGE_ROOT || process.cwd();
+const forgeRoot = validateForgeRoot(rawForgeRoot) ? rawForgeRoot : null;
+
+function validateForgeRoot(dir) {
+  try {
+    // Must contain tasks/ and .forge/ (or config/) to be a valid forge project
+    const hasTasksDir = fs.existsSync(path.join(dir, 'tasks'));
+    const hasForgeDir = fs.existsSync(path.join(dir, '.forge')) || fs.existsSync(path.join(dir, 'config'));
+    return hasTasksDir && hasForgeDir;
+  } catch (_) {
+    return false;
+  }
+}
+
+// Helper to safely parse JSON
+function safeJsonParse(filePath, defaultValue = {}) {
+  try {
+    if (fs.existsSync(filePath)) {
+      return JSON.parse(fs.readFileSync(filePath, 'utf8'));
+    }
+  } catch (e) {
+    // Ignore parse errors
+  }
+  return defaultValue;
+}
+
+// Helper to count matching files
+function countFiles(dir, pattern = '*.md') {
+  try {
+    if (!fs.existsSync(dir)) return 0;
+    const files = fs.readdirSync(dir);
+    return files.filter(f => f.endsWith('.md')).length;
+  } catch (e) {
+    return 0;
+  }
+}
+
+// Helper to count files with specific content
+function countFilesWithContent(dir, searchPattern) {
+  try {
+    if (!fs.existsSync(dir)) return 0;
+    const files = fs.readdirSync(dir).filter(f => f.endsWith('.md'));
+    let count = 0;
+    for (const file of files) {
+      try {
+        const content = fs.readFileSync(path.join(dir, file), 'utf8');
+        if (content.includes(searchPattern)) {
+          count++;
+        }
+      } catch (e) {
+        // Skip files we can't read
+      }
+    }
+    return count;
+  } catch (e) {
+    return 0;
+  }
+}
+
+// Output result and exit
+function output(result) {
+  console.log(JSON.stringify(result));
+  process.exit(0);
+}
+
+// Main logic
+function main() {
+  // SEC-005: Abort safely if forge root is invalid
+  if (!forgeRoot) {
+    output({ decision: 'allow' });
+    return;
+  }
+
+  let loopActive = false;
+  let workerAgent = '';
+  let maxIdleChecks = 10;
+  let idleCount = 0;
+  let pollInterval = 5;
+
+  // Check for runtime state file first (takes precedence)
+  if (fs.existsSync(stateFile)) {
+    const state = safeJsonParse(stateFile);
+    loopActive = true;
+    workerAgent = state.agent || '';
+    maxIdleChecks = state.max_idle_checks || 10;
+    idleCount = state.idle_count || 0;
+    pollInterval = state.poll_interval || 5;
+  }
+
+  // If no runtime state, check config-based setting
+  if (!loopActive) {
+    const configFile = path.join(forgeRoot, '.forge', 'config.json');
+    const config = safeJsonParse(configFile);
+    if (config.worker_loop_enabled === true) {
+      loopActive = true;
+      workerAgent = 'any';
+    }
+  }
+
+  // Check if worker loop is active
+  if (!loopActive) {
+    return output({ decision: 'approve' });
+  }
+
+  if (!workerAgent) {
+    // Invalid state, clean up and allow exit
+    try { fs.unlinkSync(stateFile); } catch (e) {}
+    return output({ decision: 'approve' });
+  }
+
+  // Determine tasks directory location
+  // When running from vibe-forge repo: tasks are at ./tasks/
+  // When running from a project using vibe-forge as submodule: tasks are at ./_vibe-forge/tasks/
+  let tasksDir = path.join(forgeRoot, 'tasks');
+  if (!fs.existsSync(tasksDir)) {
+    // Fall back to submodule location
+    tasksDir = path.join(forgeRoot, '_vibe-forge', 'tasks');
+  }
+
+  // Check for pending tasks
+  let pendingCount = 0;
+  let needsChangesCount = 0;
+
+  const pendingDir = path.join(tasksDir, 'pending');
+  const needsChangesDir = path.join(tasksDir, 'needs-changes');
+
+  if (workerAgent === 'any') {
+    // Config mode: count all tasks
+    pendingCount = countFiles(pendingDir);
+    needsChangesCount = countFiles(needsChangesDir);
+  } else {
+    // Runtime mode: count only tasks assigned to specific worker
+    const searchPattern = `assigned_to: ${workerAgent}`;
+    pendingCount = countFilesWithContent(pendingDir, searchPattern);
+    needsChangesCount = countFilesWithContent(needsChangesDir, searchPattern);
+  }
+
+  const totalTasks = pendingCount + needsChangesCount;
+
+  // Get relative task path for prompts (relative to forgeRoot)
+  const relativeTasksPath = path.relative(forgeRoot, tasksDir);
+
+  if (totalTasks > 0) {
+    // Tasks found! Reset idle counter and continue
+    if (fs.existsSync(stateFile)) {
+      try {
+        const state = safeJsonParse(stateFile);
+        state.idle_count = 0;
+        fs.writeFileSync(stateFile, JSON.stringify(state, null, 2));
+      } catch (e) {}
+    }
+
+    return output({
+      decision: 'block',
+      message: `[Forge Loop] Found ${totalTasks} pending task(s). Continuing work...`,
+      prompt: `Check ${relativeTasksPath}/pending/ and ${relativeTasksPath}/needs-changes/ for tasks assigned to you and begin working on them immediately.`
+    });
+  }
+
+  // No tasks - handle idle state
+  if (fs.existsSync(stateFile)) {
+    idleCount++;
+
+    try {
+      const state = safeJsonParse(stateFile);
+      state.idle_count = idleCount;
+      fs.writeFileSync(stateFile, JSON.stringify(state, null, 2));
+    } catch (e) {}
+
+    if (idleCount >= maxIdleChecks) {
+      // Max idle checks reached, clean up and allow exit
+      try { fs.unlinkSync(stateFile); } catch (e) {}
+      return output({
+        decision: 'approve',
+        message: `[Forge Loop] No tasks found after ${maxIdleChecks} checks. Exiting.`
+      });
+    }
+
+    // Still within idle limit - wait and check again
+    return output({
+      decision: 'block',
+      message: `[Forge Loop] No tasks available. Idle check ${idleCount}/${maxIdleChecks}. Waiting...`,
+      prompt: `No tasks currently assigned to you. Wait briefly, then check ${relativeTasksPath}/pending/ and ${relativeTasksPath}/needs-changes/ again for new work. If still no tasks, announce you are idle and ready.`
+    });
+  }
+
+  // Config-based mode - no idle tracking, just allow exit when no tasks
+  return output({
+    decision: 'approve',
+    message: '[Forge Loop] No pending tasks. Worker exiting.'
+  });
+}
+
+main();