vibe-forge 0.4.0 → 0.8.1

package/bin/lib/agents.sh

@@ -1,177 +1,177 @@
-#!/usr/bin/env bash
-#
-# Vibe Forge - Agent Resolution and Validation
-# Source this file in other scripts: source "$SCRIPT_DIR/lib/agents.sh"
-#
-# SECURITY: This module provides safe agent name resolution with whitelist validation.
-# Never pass user input directly to shell commands - always resolve through these functions.
-#
-
-# Ensure constants are loaded
-if [[ -z "${VALID_AGENTS+x}" ]]; then
-    echo "Error: constants.sh must be sourced before agents.sh" >&2
-    exit 1
-fi
-
-# resolve_agent ALIAS
-# Converts an agent alias to its canonical name.
-# Returns: canonical name on stdout, empty string if not found
-# Exit code: 0 if found, 1 if not found
-#
-# SECURITY: This function validates against a whitelist.
-# The returned value is safe to use in file paths and commands.
-resolve_agent() {
-    local input="$1"
-
-    # Normalize to lowercase for matching
-    local normalized
-    normalized=$(echo "$input" | tr '[:upper:]' '[:lower:]')
-
-    # Look up in alias map
-    local canonical="${AGENT_ALIASES[$normalized]:-}"
-
-    if [[ -n "$canonical" ]]; then
-        echo "$canonical"
-        return 0
-    fi
-
-    return 1
-}
-
-# is_valid_agent AGENT
-# Checks if an agent name is valid (either canonical or alias)
-# Returns: 0 if valid, 1 if invalid
-is_valid_agent() {
-    local agent="$1"
-    resolve_agent "$agent" >/dev/null 2>&1
-}
-
-# get_agent_personality_path FORGE_ROOT AGENT
-# Returns the path to an agent's personality file.
-# Uses AGENT_PERSONALITY_FILES from constants.sh (or loaded from agents.json)
-# SECURITY: Validates agent name before constructing path.
-# Returns: full path on stdout
-# Exit code: 0 on success, 1 if agent invalid or file missing
-get_agent_personality_path() {
-    local forge_root="$1"
-    local agent="$2"
-
-    # Resolve and validate agent
-    local canonical
-    canonical=$(resolve_agent "$agent") || {
-        return 1
-    }
-
-    # Get personality file path from configuration
-    local relative_path="${AGENT_PERSONALITY_FILES[$canonical]:-}"
-    if [[ -z "$relative_path" ]]; then
-        # Fallback: construct path if not in config
-        relative_path="agents/$canonical/personality.md"
-    fi
-
-    local personality_path="$forge_root/$relative_path"
-
-    # Validate file exists
-    if [[ ! -f "$personality_path" ]]; then
-        return 1
-    fi
-
-    # SECURITY: Verify the resolved path is within agents directory
-    local real_path
-    real_path=$(cd "$(dirname "$personality_path")" 2>/dev/null && pwd)/$(basename "$personality_path")
-    local agents_dir
-    agents_dir=$(cd "$forge_root/agents" 2>/dev/null && pwd)
-
-    if [[ "$real_path" != "$agents_dir"/* ]]; then
-        echo "Security error: Path traversal detected" >&2
-        return 1
-    fi
-
-    echo "$personality_path"
-    return 0
-}
-
-# show_available_agents
-# Prints a formatted list of available agents with aliases
-# Uses data from AGENT_DISPLAY_NAMES, AGENT_ROLES, and AGENT_ALIASES
-show_available_agents() {
-    echo "Available agents:"
-
-    # Iterate over valid agents (excluding hub for user display)
-    for agent in "${VALID_AGENTS[@]}"; do
-        if [[ "$agent" == "hub" ]]; then
-            continue
-        fi
-
-        # Get display info
-        local role="${AGENT_ROLES[$agent]:-}"
-
-        # Collect aliases for this agent
-        local aliases=()
-        for alias in "${!AGENT_ALIASES[@]}"; do
-            if [[ "${AGENT_ALIASES[$alias]}" == "$agent" && "$alias" != "$agent" ]]; then
-                aliases+=("$alias")
-            fi
-        done
-
-        # Format aliases (take first 3)
-        local alias_str=""
-        if [[ ${#aliases[@]} -gt 0 ]]; then
-            # Sort and take first 3
-            IFS=$'\n' sorted=($(printf '%s\n' "${aliases[@]}" | sort)); unset IFS
-            local display_aliases=("${sorted[@]:0:3}")
-            alias_str="($(IFS=", "; echo "${display_aliases[*]}"))"
-        fi
-
-        # Print formatted line
-        printf "  %-9s %-25s - %s\n" "$agent" "$alias_str" "$role"
-    done
-}
-
-# get_agent_display_name AGENT
-# Returns the display name for an agent (e.g., "Anvil" for "anvil")
-# Uses AGENT_DISPLAY_NAMES from constants.sh (or loaded from agents.json)
-get_agent_display_name() {
-    local agent="$1"
-    local canonical
-    canonical=$(resolve_agent "$agent") || return 1
-
-    # Look up in AGENT_DISPLAY_NAMES array
-    local display_name="${AGENT_DISPLAY_NAMES[$canonical]:-}"
-    if [[ -n "$display_name" ]]; then
-        echo "$display_name"
-    else
-        # Fallback to canonical name with first letter capitalized
-        echo "${canonical^}"
-    fi
-}
-
-# get_agent_role AGENT
-# Returns the role description for an agent
-get_agent_role() {
-    local agent="$1"
-    local canonical
-    canonical=$(resolve_agent "$agent") || return 1
-
-    echo "${AGENT_ROLES[$canonical]:-}"
-}
-
-# get_agent_icon AGENT
-# Returns the icon/emoji for an agent
-get_agent_icon() {
-    local agent="$1"
-    local canonical
-    canonical=$(resolve_agent "$agent") || return 1
-
-    echo "${AGENT_ICONS[$canonical]:-}"
-}
-
-# get_agent_tab_color AGENT
-# Returns the Windows Terminal tab color for an agent (hex format)
-get_agent_tab_color() {
-    local agent="$1"
-    local canonical
-    canonical=$(resolve_agent "$agent") || return 1
-
-    echo "${AGENT_TAB_COLORS[$canonical]:-}"
-}
+#!/usr/bin/env bash
+#
+# Vibe Forge - Agent Resolution and Validation
+# Source this file in other scripts: source "$SCRIPT_DIR/lib/agents.sh"
+#
+# SECURITY: This module provides safe agent name resolution with whitelist validation.
+# Never pass user input directly to shell commands - always resolve through these functions.
+#
+
+# Ensure constants are loaded
+if [[ -z "${VALID_AGENTS+x}" ]]; then
+    echo "Error: constants.sh must be sourced before agents.sh" >&2
+    exit 1
+fi
+
+# resolve_agent ALIAS
+# Converts an agent alias to its canonical name.
+# Returns: canonical name on stdout, empty string if not found
+# Exit code: 0 if found, 1 if not found
+#
+# SECURITY: This function validates against a whitelist.
+# The returned value is safe to use in file paths and commands.
+resolve_agent() {
+    local input="$1"
+
+    # Normalize to lowercase for matching
+    local normalized
+    normalized=$(echo "$input" | tr '[:upper:]' '[:lower:]')
+
+    # Look up in alias map
+    local canonical="${AGENT_ALIASES[$normalized]:-}"
+
+    if [[ -n "$canonical" ]]; then
+        echo "$canonical"
+        return 0
+    fi
+
+    return 1
+}
+
+# is_valid_agent AGENT
+# Checks if an agent name is valid (either canonical or alias)
+# Returns: 0 if valid, 1 if invalid
+is_valid_agent() {
+    local agent="$1"
+    resolve_agent "$agent" >/dev/null 2>&1
+}
+
+# get_agent_personality_path FORGE_ROOT AGENT
+# Returns the path to an agent's personality file.
+# Uses AGENT_PERSONALITY_FILES from constants.sh (or loaded from agents.json)
+# SECURITY: Validates agent name before constructing path.
+# Returns: full path on stdout
+# Exit code: 0 on success, 1 if agent invalid or file missing
+get_agent_personality_path() {
+    local forge_root="$1"
+    local agent="$2"
+
+    # Resolve and validate agent
+    local canonical
+    canonical=$(resolve_agent "$agent") || {
+        return 1
+    }
+
+    # Get personality file path from configuration
+    local relative_path="${AGENT_PERSONALITY_FILES[$canonical]:-}"
+    if [[ -z "$relative_path" ]]; then
+        # Fallback: construct path if not in config
+        relative_path="agents/$canonical/personality.md"
+    fi
+
+    local personality_path="$forge_root/$relative_path"
+
+    # Validate file exists
+    if [[ ! -f "$personality_path" ]]; then
+        return 1
+    fi
+
+    # SECURITY: Verify the resolved path is within agents directory
+    local real_path
+    real_path=$(cd "$(dirname "$personality_path")" 2>/dev/null && pwd)/$(basename "$personality_path")
+    local agents_dir
+    agents_dir=$(cd "$forge_root/agents" 2>/dev/null && pwd)
+
+    if [[ "$real_path" != "$agents_dir"/* ]]; then
+        echo "Security error: Path traversal detected" >&2
+        return 1
+    fi
+
+    echo "$personality_path"
+    return 0
+}
+
+# show_available_agents
+# Prints a formatted list of available agents with aliases
+# Uses data from AGENT_DISPLAY_NAMES, AGENT_ROLES, and AGENT_ALIASES
+show_available_agents() {
+    echo "Available agents:"
+
+    # Iterate over valid agents (excluding hub for user display)
+    for agent in "${VALID_AGENTS[@]}"; do
+        if [[ "$agent" == "hub" ]]; then
+            continue
+        fi
+
+        # Get display info
+        local role="${AGENT_ROLES[$agent]:-}"
+
+        # Collect aliases for this agent
+        local aliases=()
+        for alias in "${!AGENT_ALIASES[@]}"; do
+            if [[ "${AGENT_ALIASES[$alias]}" == "$agent" && "$alias" != "$agent" ]]; then
+                aliases+=("$alias")
+            fi
+        done
+
+        # Format aliases (take first 3)
+        local alias_str=""
+        if [[ ${#aliases[@]} -gt 0 ]]; then
+            # Sort and take first 3
+            IFS=$'\n' sorted=($(printf '%s\n' "${aliases[@]}" | sort)); unset IFS
+            local display_aliases=("${sorted[@]:0:3}")
+            alias_str="($(IFS=", "; echo "${display_aliases[*]}"))"
+        fi
+
+        # Print formatted line
+        printf "  %-9s %-25s - %s\n" "$agent" "$alias_str" "$role"
+    done
+}
+
+# get_agent_display_name AGENT
+# Returns the display name for an agent (e.g., "Anvil" for "anvil")
+# Uses AGENT_DISPLAY_NAMES from constants.sh (or loaded from agents.json)
+get_agent_display_name() {
+    local agent="$1"
+    local canonical
+    canonical=$(resolve_agent "$agent") || return 1
+
+    # Look up in AGENT_DISPLAY_NAMES array
+    local display_name="${AGENT_DISPLAY_NAMES[$canonical]:-}"
+    if [[ -n "$display_name" ]]; then
+        echo "$display_name"
+    else
+        # Fallback to canonical name with first letter capitalized
+        echo "${canonical^}"
+    fi
+}
+
+# get_agent_role AGENT
+# Returns the role description for an agent
+get_agent_role() {
+    local agent="$1"
+    local canonical
+    canonical=$(resolve_agent "$agent") || return 1
+
+    echo "${AGENT_ROLES[$canonical]:-}"
+}
+
+# get_agent_icon AGENT
+# Returns the icon/emoji for an agent
+get_agent_icon() {
+    local agent="$1"
+    local canonical
+    canonical=$(resolve_agent "$agent") || return 1
+
+    echo "${AGENT_ICONS[$canonical]:-}"
+}
+
+# get_agent_tab_color AGENT
+# Returns the Windows Terminal tab color for an agent (hex format)
+get_agent_tab_color() {
+    local agent="$1"
+    local canonical
+    canonical=$(resolve_agent "$agent") || return 1
+
+    echo "${AGENT_TAB_COLORS[$canonical]:-}"
+}

package/bin/lib/check-aliases.js

@@ -0,0 +1,50 @@
+#!/usr/bin/env node
+/**
+ * Agent alias collision detector.
+ *
+ * Used by:
+ *   - .husky/pre-commit (pre-commit hook)
+ *   - .github/workflows/ci.yml (CI lint job)
+ *   - bin/cli.js validateAgentsConfig() (forge init)
+ *
+ * Exit code 0: no collisions
+ * Exit code 1: collisions found (printed to stderr)
+ */
+
+const path = require('path');
+const fs = require('fs');
+
+const configPath = process.argv[2] || path.join(__dirname, '..', '..', 'config', 'agents.json');
+
+if (!fs.existsSync(configPath)) {
+    // No agents.json is fine (e.g., fresh clone before setup)
+    process.exit(0);
+}
+
+let config;
+try {
+    config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
+} catch (err) {
+    console.error(`ERROR: Failed to parse ${configPath}: ${err.message}`);
+    process.exit(1);
+}
+
+const agents = config.agents || {};
+const seen = {};
+const dupes = [];
+
+for (const [name, info] of Object.entries(agents)) {
+    for (const alias of [name, ...(info.aliases || [])]) {
+        if (seen[alias] && seen[alias] !== name) {
+            dupes.push(`${alias} (${seen[alias]} vs ${name})`);
+        }
+        seen[alias] = name;
+    }
+}
+
+if (dupes.length) {
+    console.error(`ERROR: Alias collision in agents.json: ${dupes.join(', ')}`);
+    process.exit(1);
+}
+
+console.log(`No alias collisions found (${Object.keys(agents).length} agents checked)`);

package/bin/lib/colors.sh

@@ -1,44 +1,44 @@
-#!/usr/bin/env bash
-#
-# Vibe Forge - Shared Color Definitions and Logging
-# Source this file in other scripts: source "$SCRIPT_DIR/lib/colors.sh"
-#
-
-# Colors (only if terminal supports them)
-if [[ -t 1 ]]; then
-    RED='\033[0;31m'
-    GREEN='\033[0;32m'
-    YELLOW='\033[1;33m'
-    BLUE='\033[0;34m'
-    CYAN='\033[0;36m'
-    NC='\033[0m'
-else
-    RED=''
-    GREEN=''
-    YELLOW=''
-    BLUE=''
-    CYAN=''
-    NC=''
-fi
-
-# Logging functions
-log_error() {
-    echo -e "${RED}Error: $1${NC}" >&2
-}
-
-log_success() {
-    echo -e "${GREEN}✓ $1${NC}"
-}
-
-log_info() {
-    echo -e "${BLUE}ℹ $1${NC}"
-}
-
-log_warn() {
-    echo -e "${YELLOW}⚠ $1${NC}"
-}
-
-log_header() {
-    echo -e "${YELLOW}$1${NC}"
-    echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
-}
+#!/usr/bin/env bash
+#
+# Vibe Forge - Shared Color Definitions and Logging
+# Source this file in other scripts: source "$SCRIPT_DIR/lib/colors.sh"
+#
+
+# Colors (only if terminal supports them)
+if [[ -t 1 ]]; then
+    RED='\033[0;31m'
+    GREEN='\033[0;32m'
+    YELLOW='\033[1;33m'
+    BLUE='\033[0;34m'
+    CYAN='\033[0;36m'
+    NC='\033[0m'
+else
+    RED=''
+    GREEN=''
+    YELLOW=''
+    BLUE=''
+    CYAN=''
+    NC=''
+fi
+
+# Logging functions
+log_error() {
+    echo -e "${RED}Error: $1${NC}" >&2
+}
+
+log_success() {
+    echo -e "${GREEN}✓ $1${NC}"
+}
+
+log_info() {
+    echo -e "${BLUE}ℹ $1${NC}"
+}
+
+log_warn() {
+    echo -e "${YELLOW}⚠ $1${NC}"
+}
+
+log_header() {
+    echo -e "${YELLOW}$1${NC}"
+    echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+}