pi-crew 0.9.50 → 0.9.52
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +150 -0
- package/README.md +216 -20
- package/dist/build-meta.json +2222 -1761
- package/dist/index.mjs +18636 -17603
- package/docs/actions-reference.md +431 -1
- package/package.json +19 -9
- package/schema.json +41 -0
- package/scripts/check-bundle-size.mjs +38 -0
- package/scripts/test-runner.mjs +11 -1
- package/skills/distill-software/SKILL.md +24 -1
- package/dist/index.mjs.map +0 -7
- package/docs/FEATURE_INTAKE.md +0 -126
- package/docs/HARNESS.md +0 -87
- package/docs/HARNESS_BACKLOG.md +0 -89
- package/docs/PROJECT_REVIEW.md +0 -270
- package/docs/PROJECT_REVIEW_FIXES.md +0 -342
- package/docs/PROJECT_REVIEW_ROUND4.md +0 -156
- package/docs/PROJECT_REVIEW_ROUND5.md +0 -86
- package/docs/REVIEW-FINDINGS-2026-06 +0 -357
- package/docs/REVIEW-FINDINGS-2026-07-CORE.md +0 -139
- package/docs/REVIEW-FINDINGS-2026-07.md +0 -125
- package/docs/TEST_MATRIX.md +0 -51
- package/docs/archive/README.md +0 -91
- package/docs/archive/followup-review-round3-2026-05-12.md +0 -342
- package/docs/archive/followup-review-round4-2026-05-13.md +0 -107
- package/docs/archive/pi-crew-bugs.md +0 -961
- package/docs/archive/pi-crew-test-final.md +0 -120
- package/docs/archive/pi-crew-test-results.md +0 -260
- package/docs/archive/pi-crew-test-round2.md +0 -136
- package/docs/archive/pi-crew-test-round4.md +0 -100
- package/docs/archive/pi-crew-test-round5.md +0 -70
- package/docs/archive/pi-crew-test-round6.md +0 -110
- package/docs/archive/pi-crew-v0.5.10-audit-fix-plan.md +0 -60
- package/docs/archive/pi-crew-v0.5.11-audit-fix-plan.md +0 -92
- package/docs/archive/pi-crew-v0.5.12-audit-fix-plan.md +0 -76
- package/docs/archive/pi-crew-v0.5.13-audit-fix-plan.md +0 -75
- package/docs/archive/pi-crew-v0.5.14-audit-fix-plan.md +0 -75
- package/docs/archive/pi-crew-v0.5.16-audit-fix-plan.md +0 -35
- package/docs/archive/pi-crew-v0.5.17-audit-fix-plan.md +0 -80
- package/docs/archive/pi-crew-v0.5.5-audit-fix-plan.md +0 -133
- package/docs/archive/pi-crew-v0.5.9-audit-fix-plan.md +0 -88
- package/docs/archive/pi-mono-opportunities.md +0 -969
- package/docs/archive/pi-mono-review.md +0 -291
- package/docs/archive/pi-subagent4-comparison.md +0 -261
- package/docs/archive/pi-subagents3-deep-analysis.md +0 -508
- package/docs/bugs/bug-021-notification-badge-counter-misleading.md +0 -293
- package/docs/bugs/bug-023-chain-windows-path-resolution.md +0 -106
- package/docs/bugs/bug-quota-display-truncation.md +0 -223
- package/docs/bugs/cross-session-notification-leakage.md +0 -82
- package/docs/code-review-2026-05-11.md +0 -592
- package/docs/coding-agent-optimization.md +0 -268
- package/docs/comparison-pi-subagents-vs-pi-crew.md +0 -303
- package/docs/decisions/0001-durable-state.md +0 -41
- package/docs/decisions/0002-child-process-for-async.md +0 -42
- package/docs/decisions/0003-depth-guard.md +0 -36
- package/docs/decisions/0004-execfile-over-exec.md +0 -34
- package/docs/decisions/0005-no-parameter-properties.md +0 -49
- package/docs/decisions/0006-publish-bundled-esm.md +0 -63
- package/docs/decisions/0007-active-run-binary-index.md +0 -54
- package/docs/decisions/0008-child-pi-warm-pool.md +0 -61
- package/docs/decisions/2026-07-21-broker-phase4-default-on.md +0 -77
- package/docs/decisions/2026-07-21-broker-windows-perms.md +0 -91
- package/docs/decisions/2026-07-22-broker-phase4-gated-on.md +0 -99
- package/docs/decisions/2026-07-24-oidc-trusted-publishing.md +0 -112
- package/docs/decisions/README.md +0 -26
- package/docs/deep-review-report.md +0 -384
- package/docs/distillation/cybersecurity-patterns.md +0 -294
- package/docs/feature-analysis-subagent4.md +0 -305
- package/docs/fix-plan-disabletools-exit-null.md +0 -219
- package/docs/fixes/BATCH_A_H1_H2.md +0 -86
- package/docs/fixes/bug-006-foreground-cancel-concurrent.md +0 -78
- package/docs/fixes/bug-007-async-notifier-stale-ctx.md +0 -112
- package/docs/fixes/bug-008-child-process-silent-timeout.md +0 -100
- package/docs/fixes/bug-009-executor-yield-limit-needs-attention.md +0 -75
- package/docs/fixes/bug-010-child-process-api-key-filtered.md +0 -109
- package/docs/fixes/bug-011-spawn-pi-enoent.md +0 -92
- package/docs/fixes/bug-012-essential-env-stripped.md +0 -89
- package/docs/fixes/bug-013-background-runner-death.md +0 -84
- package/docs/fixes/bug-014-infinite-retry-loop-needs-attention.md +0 -82
- package/docs/fixes/bug-015-background-runner-sigterm.md +0 -65
- package/docs/fixes/bug-017-background-runner-session-shutdown.md +0 -66
- package/docs/fixes/bug-017-background-runner-sigkill-double-fork.md +0 -28
- package/docs/fixes/bug-018-child-pi-worker-stdin-hang.md +0 -61
- package/docs/fixes/bug-019-phantom-runs-temp-workspace.md +0 -52
- package/docs/fixes/bug-020-infinite-retry-loop-needs-attention.md +0 -47
- package/docs/fixes/v0.9.10/locks-fix-verify.md +0 -3
- package/docs/fixes/v0.9.10/smoke-test.md +0 -12
- package/docs/followup-plan-2026-05-12.md +0 -463
- package/docs/followup-review-2026-05-12.md +0 -297
- package/docs/goals.md +0 -59
- package/docs/implementation-plan-top3.md +0 -333
- package/docs/issue-29-analysis.md +0 -189
- package/docs/live-mailbox-runtime.md +0 -36
- package/docs/migration/atomic-write-v2-migration.md +0 -299
- package/docs/next-upgrade-roadmap.md +0 -808
- package/docs/oh-my-pi-research.md +0 -509
- package/docs/optimization-plan-2026-07.md +0 -366
- package/docs/optimization-plan.md +0 -644
- package/docs/patterns/command-agent-skill.md +0 -71
- package/docs/perf/baseline-2026-05.md +0 -113
- package/docs/perf/final-report-2026-05.md +0 -206
- package/docs/perf/optimization-plan-2026-07-verified.md +0 -396
- package/docs/perf/performance-audit-report-2026-07.md +0 -948
- package/docs/perf/performance-review-2026-07.md +0 -287
- package/docs/perf/sprint-1-report.md +0 -71
- package/docs/perf/sprint-2-report.md +0 -81
- package/docs/perf/sprint-2.5-report.md +0 -53
- package/docs/perf/sprint-3-report.md +0 -36
- package/docs/perf/sprint-4-report.md +0 -47
- package/docs/perf/sprint-5-report.md +0 -51
- package/docs/perf/sprint-6-report.md +0 -94
- package/docs/perf/sprint-7-report.md +0 -74
- package/docs/perf/upgrade-plan-2026-05.md +0 -147
- package/docs/performance-optimization-execution-plan.md +0 -520
- package/docs/phase4-triage.md +0 -58
- package/docs/pi-crew-investigation-report.md +0 -411
- package/docs/product/README.md +0 -31
- package/docs/product/platform.md +0 -27
- package/docs/product/runtime-safety.md +0 -37
- package/docs/product/team-run.md +0 -39
- package/docs/product/team-tool.md +0 -37
- package/docs/runtime-analysis-child-vs-live.md +0 -171
- package/docs/runtime-migration-in-process-analysis.md +0 -250
- package/docs/skills/REFERENCE.md +0 -138
- package/docs/stories/README.md +0 -32
- package/docs/stories/US-DEPS-major-upgrade.md +0 -62
- package/docs/stories/backlog.md +0 -36
- package/docs/superpowers/plans/2026-06-09-fallow-patterns-adoption.md +0 -1270
- package/docs/templates/decision.md +0 -27
- package/docs/templates/story.md +0 -44
- package/docs/templates/validation-report.md +0 -32
- package/docs/ui-optimization-plan.md +0 -447
- package/src/adapters/claude-adapter.ts +0 -23
- package/src/adapters/codex-adapter.ts +0 -21
- package/src/adapters/cursor-adapter.ts +0 -17
- package/src/adapters/export-util.ts +0 -143
- package/src/adapters/index.ts +0 -15
- package/src/adapters/registry.ts +0 -18
- package/src/adapters/types.ts +0 -23
- package/src/agents/agent-config.ts +0 -194
- package/src/agents/agent-search.ts +0 -98
- package/src/agents/agent-serializer.ts +0 -38
- package/src/agents/discover-agents.ts +0 -623
- package/src/benchmark/benchmark-runner.ts +0 -313
- package/src/benchmark/feedback-loop.ts +0 -73
- package/src/config/config.ts +0 -1269
- package/src/config/defaults.ts +0 -193
- package/src/config/drift-detector.ts +0 -290
- package/src/config/markers.ts +0 -330
- package/src/config/resilient-parser.ts +0 -117
- package/src/config/role-tools.ts +0 -118
- package/src/config/suggestions.ts +0 -75
- package/src/config/types.ts +0 -278
- package/src/errors.ts +0 -194
- package/src/extension/action-suggestions.ts +0 -117
- package/src/extension/async-notifier.ts +0 -179
- package/src/extension/autonomous-policy.ts +0 -209
- package/src/extension/command-completions.ts +0 -120
- package/src/extension/context-status-injection.ts +0 -185
- package/src/extension/crew-autocomplete.ts +0 -131
- package/src/extension/crew-cleanup.ts +0 -168
- package/src/extension/crew-input-router.ts +0 -93
- package/src/extension/crew-shortcuts.ts +0 -87
- package/src/extension/crew-vibes/cat-frames.ts +0 -18
- package/src/extension/crew-vibes/config.ts +0 -195
- package/src/extension/crew-vibes/figures.ts +0 -101
- package/src/extension/crew-vibes/font-detect.ts +0 -71
- package/src/extension/crew-vibes/footer.ts +0 -292
- package/src/extension/crew-vibes/index.ts +0 -432
- package/src/extension/crew-vibes/provider-usage.ts +0 -396
- package/src/extension/crew-vibes/render.ts +0 -206
- package/src/extension/crew-vibes/speed.ts +0 -286
- package/src/extension/cross-extension-rpc.ts +0 -350
- package/src/extension/help.ts +0 -62
- package/src/extension/import-index.ts +0 -74
- package/src/extension/knowledge-injection.ts +0 -402
- package/src/extension/management.ts +0 -571
- package/src/extension/message-renderers.ts +0 -108
- package/src/extension/notification-router.ts +0 -152
- package/src/extension/notification-sink.ts +0 -54
- package/src/extension/pi-api.ts +0 -56
- package/src/extension/plan-orchestrate.ts +0 -302
- package/src/extension/project-init.ts +0 -170
- package/src/extension/register.ts +0 -113
- package/src/extension/registration/artifact-cleanup.ts +0 -20
- package/src/extension/registration/command-registration.ts +0 -58
- package/src/extension/registration/command-utils.ts +0 -58
- package/src/extension/registration/commands.ts +0 -1228
- package/src/extension/registration/compaction-guard.ts +0 -333
- package/src/extension/registration/context-builder.ts +0 -135
- package/src/extension/registration/crash-recovery-cache.ts +0 -54
- package/src/extension/registration/foreground-run-controller.ts +0 -238
- package/src/extension/registration/hook-registration.ts +0 -119
- package/src/extension/registration/lazy-configurers.ts +0 -124
- package/src/extension/registration/lifecycle-handlers.ts +0 -923
- package/src/extension/registration/lifecycle.ts +0 -259
- package/src/extension/registration/observability.ts +0 -322
- package/src/extension/registration/registration-types.ts +0 -158
- package/src/extension/registration/runtime-cleanup.ts +0 -230
- package/src/extension/registration/subagent-helpers.ts +0 -125
- package/src/extension/registration/subagent-manager-setup.ts +0 -330
- package/src/extension/registration/subagent-tools.ts +0 -456
- package/src/extension/registration/team-tool.ts +0 -220
- package/src/extension/registration/tool-registration.ts +0 -50
- package/src/extension/registration/ui.ts +0 -172
- package/src/extension/registration/viewers.ts +0 -121
- package/src/extension/registration/wire-cross-extension.ts +0 -37
- package/src/extension/result-watcher.ts +0 -139
- package/src/extension/rpc-hmac.ts +0 -256
- package/src/extension/run-bundle-schema.ts +0 -104
- package/src/extension/run-export.ts +0 -97
- package/src/extension/run-import.ts +0 -168
- package/src/extension/run-index.ts +0 -131
- package/src/extension/run-maintenance.ts +0 -190
- package/src/extension/session-summary.ts +0 -18
- package/src/extension/team-manager-command.ts +0 -153
- package/src/extension/team-onboard.ts +0 -177
- package/src/extension/team-recommendation.ts +0 -288
- package/src/extension/team-tool/anchor.ts +0 -172
- package/src/extension/team-tool/api.ts +0 -1244
- package/src/extension/team-tool/auto-summarize.ts +0 -142
- package/src/extension/team-tool/cache-control.ts +0 -19
- package/src/extension/team-tool/cancel.ts +0 -337
- package/src/extension/team-tool/chain-dispatch.ts +0 -95
- package/src/extension/team-tool/chain-executor.ts +0 -379
- package/src/extension/team-tool/config-patch.ts +0 -50
- package/src/extension/team-tool/context.ts +0 -149
- package/src/extension/team-tool/destructive-gate.ts +0 -52
- package/src/extension/team-tool/doctor.ts +0 -431
- package/src/extension/team-tool/explain.ts +0 -282
- package/src/extension/team-tool/failure-patterns.ts +0 -118
- package/src/extension/team-tool/goal-wrap.ts +0 -330
- package/src/extension/team-tool/goal.ts +0 -556
- package/src/extension/team-tool/handle-schedule.ts +0 -332
- package/src/extension/team-tool/handle-settings.ts +0 -520
- package/src/extension/team-tool/health-monitor.ts +0 -481
- package/src/extension/team-tool/inspect.ts +0 -88
- package/src/extension/team-tool/intent-policy.ts +0 -45
- package/src/extension/team-tool/lifecycle-actions.ts +0 -615
- package/src/extension/team-tool/orchestrate.ts +0 -98
- package/src/extension/team-tool/parallel-dispatch.ts +0 -183
- package/src/extension/team-tool/plan.ts +0 -50
- package/src/extension/team-tool/respond.ts +0 -150
- package/src/extension/team-tool/run-not-found.ts +0 -49
- package/src/extension/team-tool/run.ts +0 -1035
- package/src/extension/team-tool/status.ts +0 -260
- package/src/extension/team-tool/workflow-manage.ts +0 -261
- package/src/extension/team-tool-types.ts +0 -26
- package/src/extension/team-tool.ts +0 -1116
- package/src/extension/tool-result.ts +0 -16
- package/src/extension/validate-resources.ts +0 -108
- package/src/hooks/registry.ts +0 -200
- package/src/hooks/types.ts +0 -69
- package/src/i18n.ts +0 -212
- package/src/observability/correlation.ts +0 -50
- package/src/observability/event-bus.ts +0 -86
- package/src/observability/event-to-metric.ts +0 -170
- package/src/observability/exporters/adapter.ts +0 -27
- package/src/observability/exporters/otlp-exporter.ts +0 -356
- package/src/observability/exporters/prometheus-exporter.ts +0 -54
- package/src/observability/metric-registry.ts +0 -100
- package/src/observability/metric-retention.ts +0 -64
- package/src/observability/metric-sink.ts +0 -99
- package/src/observability/metrics-primitives.ts +0 -219
- package/src/plugins/plugin-define.ts +0 -6
- package/src/plugins/plugin-registry.ts +0 -32
- package/src/plugins/plugins/index.ts +0 -3
- package/src/plugins/plugins/nextjs.ts +0 -19
- package/src/plugins/plugins/vite.ts +0 -10
- package/src/plugins/plugins/vitest.ts +0 -9
- package/src/prompt/prompt-runtime.ts +0 -380
- package/src/runtime/adaptive-plan.ts +0 -563
- package/src/runtime/agent-control.ts +0 -215
- package/src/runtime/agent-memory.ts +0 -81
- package/src/runtime/agent-observability.ts +0 -122
- package/src/runtime/anchor-manager.ts +0 -475
- package/src/runtime/async-marker.ts +0 -32
- package/src/runtime/async-runner.ts +0 -381
- package/src/runtime/attention-events.ts +0 -28
- package/src/runtime/auto-summarize.ts +0 -344
- package/src/runtime/background-runner.ts +0 -837
- package/src/runtime/batch-barrier.ts +0 -147
- package/src/runtime/broker-issuer.ts +0 -37
- package/src/runtime/cancellation-token.ts +0 -99
- package/src/runtime/cancellation.ts +0 -99
- package/src/runtime/capability-inventory.ts +0 -137
- package/src/runtime/chain-parser.ts +0 -237
- package/src/runtime/chain-runner.ts +0 -606
- package/src/runtime/checkpoint.ts +0 -291
- package/src/runtime/child-pi-constants.ts +0 -42
- package/src/runtime/child-pi-kill.ts +0 -180
- package/src/runtime/child-pi-pool.ts +0 -68
- package/src/runtime/child-pi-spawn.ts +0 -287
- package/src/runtime/child-pi-steering.ts +0 -128
- package/src/runtime/child-pi-streams.ts +0 -296
- package/src/runtime/child-pi-transcript.ts +0 -169
- package/src/runtime/child-pi.ts +0 -1105
- package/src/runtime/coalesce-tasks.ts +0 -268
- package/src/runtime/code-summary.ts +0 -292
- package/src/runtime/command-trace.ts +0 -105
- package/src/runtime/compact-pipeline.ts +0 -56
- package/src/runtime/compact-stages/ansi-strip-stage.ts +0 -25
- package/src/runtime/compact-stages/blank-collapse-stage.ts +0 -31
- package/src/runtime/compact-stages/deduplicate-stage.ts +0 -34
- package/src/runtime/compact-stages/head-snap-stage.ts +0 -57
- package/src/runtime/compact-stages/index.ts +0 -23
- package/src/runtime/compact-stages/tail-capture-stage.ts +0 -77
- package/src/runtime/compact-stages/truncation-stage.ts +0 -74
- package/src/runtime/compaction-summary.ts +0 -278
- package/src/runtime/completion-guard.ts +0 -207
- package/src/runtime/concurrency.ts +0 -58
- package/src/runtime/crash-classification.ts +0 -229
- package/src/runtime/crash-recovery.ts +0 -577
- package/src/runtime/crew-agent-records.ts +0 -593
- package/src/runtime/crew-agent-runtime.ts +0 -62
- package/src/runtime/crew-broker-child.ts +0 -88
- package/src/runtime/crew-broker-client.ts +0 -673
- package/src/runtime/crew-broker-tokens.ts +0 -84
- package/src/runtime/crew-broker.ts +0 -1276
- package/src/runtime/crew-hooks.ts +0 -227
- package/src/runtime/cross-extension-rpc.ts +0 -143
- package/src/runtime/custom-tools/irc-tool.ts +0 -282
- package/src/runtime/custom-tools/submit-result-tool.ts +0 -102
- package/src/runtime/deadletter.ts +0 -47
- package/src/runtime/delivery-coordinator.ts +0 -211
- package/src/runtime/delta-conflict.ts +0 -348
- package/src/runtime/deterministic-ast.ts +0 -161
- package/src/runtime/diagnostic-export.ts +0 -171
- package/src/runtime/direct-run.ts +0 -45
- package/src/runtime/dwf-state-store.ts +0 -102
- package/src/runtime/dynamic-workflow-context.ts +0 -1016
- package/src/runtime/dynamic-workflow-runner.ts +0 -310
- package/src/runtime/effectiveness.ts +0 -90
- package/src/runtime/errors/crew-errors.ts +0 -162
- package/src/runtime/event-stream-bridge.ts +0 -98
- package/src/runtime/foreground-control.ts +0 -193
- package/src/runtime/foreground-watchdog.ts +0 -132
- package/src/runtime/global-worker-cap.ts +0 -96
- package/src/runtime/goal-achievement.ts +0 -148
- package/src/runtime/goal-evaluator.ts +0 -361
- package/src/runtime/goal-loop-runner.ts +0 -828
- package/src/runtime/goal-state-store.ts +0 -219
- package/src/runtime/green-contract.ts +0 -55
- package/src/runtime/group-join.ts +0 -267
- package/src/runtime/handoff-manager.ts +0 -598
- package/src/runtime/heartbeat-gradient.ts +0 -36
- package/src/runtime/heartbeat-watcher.ts +0 -239
- package/src/runtime/hidden-handoff.ts +0 -407
- package/src/runtime/important-line-classifier.ts +0 -140
- package/src/runtime/intercom-bridge.ts +0 -187
- package/src/runtime/iteration-hooks.ts +0 -305
- package/src/runtime/live-agent-control.ts +0 -136
- package/src/runtime/live-agent-manager.ts +0 -704
- package/src/runtime/live-control-realtime.ts +0 -56
- package/src/runtime/live-extension-bridge.ts +0 -148
- package/src/runtime/live-irc.ts +0 -97
- package/src/runtime/live-session-health.ts +0 -108
- package/src/runtime/live-session-runtime.ts +0 -1139
- package/src/runtime/loop-gates.ts +0 -128
- package/src/runtime/manifest-cache.ts +0 -375
- package/src/runtime/mcp-proxy.ts +0 -105
- package/src/runtime/metric-parser.ts +0 -36
- package/src/runtime/model-fallback.ts +0 -409
- package/src/runtime/model-resolver.ts +0 -126
- package/src/runtime/model-scope.ts +0 -158
- package/src/runtime/orphan-worker-registry.ts +0 -465
- package/src/runtime/output-validator.ts +0 -202
- package/src/runtime/overflow-recovery.ts +0 -206
- package/src/runtime/parallel-research.ts +0 -68
- package/src/runtime/parallel-utils.ts +0 -160
- package/src/runtime/parent-guard.ts +0 -134
- package/src/runtime/path-overlap.ts +0 -150
- package/src/runtime/peer-dep.ts +0 -292
- package/src/runtime/per-write-validator.ts +0 -181
- package/src/runtime/phase-progress.ts +0 -217
- package/src/runtime/phase-tracker.ts +0 -385
- package/src/runtime/pi-args.ts +0 -655
- package/src/runtime/pi-json-output.ts +0 -170
- package/src/runtime/pi-spawn.ts +0 -273
- package/src/runtime/pipeline-runner.ts +0 -523
- package/src/runtime/plan-templates.ts +0 -201
- package/src/runtime/policy-engine.ts +0 -115
- package/src/runtime/post-checks.ts +0 -142
- package/src/runtime/post-exit-stdio-guard.ts +0 -104
- package/src/runtime/process-lifecycle.ts +0 -491
- package/src/runtime/process-status.ts +0 -154
- package/src/runtime/progress-event-coalescer.ts +0 -44
- package/src/runtime/progress-tracker.ts +0 -124
- package/src/runtime/prose-compressor.ts +0 -162
- package/src/runtime/recovery-recipes.ts +0 -203
- package/src/runtime/replace.ts +0 -570
- package/src/runtime/resilient-edit.ts +0 -153
- package/src/runtime/result-extractor.ts +0 -213
- package/src/runtime/retry-executor.ts +0 -100
- package/src/runtime/retry-runner.ts +0 -336
- package/src/runtime/role-permission.ts +0 -59
- package/src/runtime/run-coalesced-task-group.ts +0 -308
- package/src/runtime/run-drift.ts +0 -219
- package/src/runtime/run-tracker.ts +0 -116
- package/src/runtime/runtime-policy.ts +0 -29
- package/src/runtime/runtime-resolver.ts +0 -172
- package/src/runtime/runtime-warmup.ts +0 -160
- package/src/runtime/scheduler.ts +0 -353
- package/src/runtime/semaphore.ts +0 -141
- package/src/runtime/sensitive-paths.ts +0 -93
- package/src/runtime/session-resources.ts +0 -25
- package/src/runtime/session-snapshot.ts +0 -59
- package/src/runtime/session-usage.ts +0 -79
- package/src/runtime/settings-store.ts +0 -155
- package/src/runtime/sidechain-output.ts +0 -35
- package/src/runtime/single-agent-compose.ts +0 -84
- package/src/runtime/skill-effectiveness.ts +0 -524
- package/src/runtime/skill-instructions.ts +0 -391
- package/src/runtime/stale-reconciler.ts +0 -680
- package/src/runtime/stream-preview.ts +0 -184
- package/src/runtime/streaming-output.ts +0 -50
- package/src/runtime/subagent-manager.ts +0 -561
- package/src/runtime/subprocess-tool-registry.ts +0 -70
- package/src/runtime/supervisor-contact.ts +0 -64
- package/src/runtime/task-display.ts +0 -52
- package/src/runtime/task-graph-scheduler.ts +0 -227
- package/src/runtime/task-graph.ts +0 -290
- package/src/runtime/task-health.ts +0 -83
- package/src/runtime/task-id.ts +0 -161
- package/src/runtime/task-output-context.ts +0 -602
- package/src/runtime/task-packet.ts +0 -268
- package/src/runtime/task-quality.ts +0 -199
- package/src/runtime/task-runner/capabilities.ts +0 -78
- package/src/runtime/task-runner/context-retrieval.ts +0 -163
- package/src/runtime/task-runner/live-executor.ts +0 -227
- package/src/runtime/task-runner/output-splitter.ts +0 -152
- package/src/runtime/task-runner/progress.ts +0 -157
- package/src/runtime/task-runner/prompt-builder.ts +0 -278
- package/src/runtime/task-runner/prompt-pipeline.ts +0 -88
- package/src/runtime/task-runner/result-utils.ts +0 -16
- package/src/runtime/task-runner/retrieval-orchestrator.ts +0 -310
- package/src/runtime/task-runner/run-projection.ts +0 -125
- package/src/runtime/task-runner/state-helpers.ts +0 -176
- package/src/runtime/task-runner/tail-read.ts +0 -34
- package/src/runtime/task-runner.ts +0 -1420
- package/src/runtime/team-runner-artifacts.ts +0 -13
- package/src/runtime/team-runner.ts +0 -1993
- package/src/runtime/tool-output-pruner.ts +0 -333
- package/src/runtime/tool-progress.ts +0 -278
- package/src/runtime/usage-tracker.ts +0 -73
- package/src/runtime/verification-gates.ts +0 -571
- package/src/runtime/verification-integrity.ts +0 -105
- package/src/runtime/verification-worktree.ts +0 -186
- package/src/runtime/worker-heartbeat.ts +0 -25
- package/src/runtime/worker-startup.ts +0 -83
- package/src/runtime/workflow-state.ts +0 -195
- package/src/runtime/workspace-lock.ts +0 -443
- package/src/runtime/workspace-tree.ts +0 -312
- package/src/runtime/yield-handler.ts +0 -224
- package/src/runtime/zombie-scanner.ts +0 -298
- package/src/schema/config-schema.ts +0 -327
- package/src/schema/team-tool-schema.ts +0 -415
- package/src/schema/validation-types.ts +0 -159
- package/src/skills/discover-skills.ts +0 -197
- package/src/skills/skill-templates.ts +0 -456
- package/src/skills/validate.ts +0 -285
- package/src/state/active-run-registry.ts +0 -439
- package/src/state/artifact-store.ts +0 -176
- package/src/state/atomic-write.ts +0 -903
- package/src/state/blob-store.ts +0 -308
- package/src/state/contracts.ts +0 -158
- package/src/state/crew-init.ts +0 -269
- package/src/state/decision-ledger.ts +0 -345
- package/src/state/event-log-rotation.ts +0 -342
- package/src/state/event-log.ts +0 -1311
- package/src/state/event-reconstructor.ts +0 -229
- package/src/state/gitignore-manager.ts +0 -46
- package/src/state/health-store.ts +0 -79
- package/src/state/hook-instinct-bridge.ts +0 -94
- package/src/state/hook-integrations.ts +0 -51
- package/src/state/instinct-store.ts +0 -275
- package/src/state/jsonl-writer.ts +0 -107
- package/src/state/locks.ts +0 -562
- package/src/state/mailbox.ts +0 -916
- package/src/state/observation-store.ts +0 -176
- package/src/state/run-cache.ts +0 -193
- package/src/state/run-graph.ts +0 -183
- package/src/state/run-metrics.ts +0 -165
- package/src/state/schedule.ts +0 -166
- package/src/state/session-state-map.ts +0 -51
- package/src/state/state-store.ts +0 -958
- package/src/state/task-claims.ts +0 -61
- package/src/state/tiered-eval.ts +0 -480
- package/src/state/types-eval.ts +0 -58
- package/src/state/types.ts +0 -440
- package/src/state/usage.ts +0 -138
- package/src/state/worker-atomic-writer.ts +0 -194
- package/src/subagents/async-entry.ts +0 -1
- package/src/subagents/index.ts +0 -3
- package/src/subagents/live/control.ts +0 -1
- package/src/subagents/live/manager.ts +0 -1
- package/src/subagents/live/realtime.ts +0 -1
- package/src/subagents/live/session-runtime.ts +0 -1
- package/src/subagents/manager.ts +0 -1
- package/src/subagents/spawn.ts +0 -1
- package/src/teams/discover-teams.ts +0 -187
- package/src/teams/team-config.ts +0 -27
- package/src/teams/team-serializer.ts +0 -38
- package/src/tools/safe-bash-extension.ts +0 -54
- package/src/tools/safe-bash.ts +0 -505
- package/src/types/diff.d.ts +0 -18
- package/src/types/new-api-types.ts +0 -35
- package/src/ui/agent-management-overlay.ts +0 -160
- package/src/ui/card-colors.ts +0 -139
- package/src/ui/crew-footer.ts +0 -102
- package/src/ui/crew-select-list.ts +0 -111
- package/src/ui/dashboard-panes/agents-pane.ts +0 -164
- package/src/ui/dashboard-panes/cancellation-pane.ts +0 -66
- package/src/ui/dashboard-panes/capability-pane.ts +0 -77
- package/src/ui/dashboard-panes/health-pane.ts +0 -31
- package/src/ui/dashboard-panes/mailbox-pane.ts +0 -35
- package/src/ui/dashboard-panes/metrics-pane.ts +0 -37
- package/src/ui/dashboard-panes/progress-pane.ts +0 -38
- package/src/ui/dashboard-panes/transcript-pane.ts +0 -10
- package/src/ui/deploy-bundled-themes.ts +0 -71
- package/src/ui/dwf-phase-display.ts +0 -151
- package/src/ui/dynamic-border.ts +0 -35
- package/src/ui/heartbeat-aggregator.ts +0 -74
- package/src/ui/key-utils.ts +0 -42
- package/src/ui/keybinding-map.ts +0 -248
- package/src/ui/layout-primitives.ts +0 -106
- package/src/ui/live-conversation-overlay.ts +0 -183
- package/src/ui/live-duration.ts +0 -55
- package/src/ui/live-run-sidebar.ts +0 -301
- package/src/ui/loaders.ts +0 -176
- package/src/ui/mascot.ts +0 -436
- package/src/ui/overlays/agent-picker-overlay.ts +0 -65
- package/src/ui/overlays/confirm-overlay.ts +0 -60
- package/src/ui/overlays/help-overlay.ts +0 -177
- package/src/ui/overlays/mailbox-compose-overlay.ts +0 -181
- package/src/ui/overlays/mailbox-compose-preview.ts +0 -78
- package/src/ui/overlays/mailbox-detail-overlay.ts +0 -154
- package/src/ui/pi-ui-compat.ts +0 -68
- package/src/ui/powerbar-publisher.ts +0 -459
- package/src/ui/render-coalescer.ts +0 -101
- package/src/ui/render-diff.ts +0 -160
- package/src/ui/render-scheduler.ts +0 -224
- package/src/ui/run-action-dispatcher.ts +0 -182
- package/src/ui/run-dashboard.ts +0 -913
- package/src/ui/run-event-bus.ts +0 -381
- package/src/ui/run-snapshot-cache.ts +0 -1057
- package/src/ui/settings-overlay.ts +0 -1067
- package/src/ui/snapshot-types.ts +0 -90
- package/src/ui/spinner.ts +0 -17
- package/src/ui/status-colors.ts +0 -143
- package/src/ui/syntax-highlight.ts +0 -136
- package/src/ui/terminal-status.ts +0 -269
- package/src/ui/theme-adapter.ts +0 -271
- package/src/ui/theme-discovery.ts +0 -199
- package/src/ui/tool-progress-formatter.ts +0 -93
- package/src/ui/tool-render.ts +0 -453
- package/src/ui/tool-renderers/brief-mode.ts +0 -225
- package/src/ui/tool-renderers/index.ts +0 -726
- package/src/ui/transcript-cache.ts +0 -128
- package/src/ui/transcript-entries.ts +0 -256
- package/src/ui/transcript-viewer.ts +0 -424
- package/src/ui/widget/index.ts +0 -357
- package/src/ui/widget/widget-formatters.ts +0 -182
- package/src/ui/widget/widget-model.ts +0 -110
- package/src/ui/widget/widget-renderer.ts +0 -182
- package/src/ui/widget/widget-types.ts +0 -36
- package/src/utils/bm25-search.ts +0 -235
- package/src/utils/completion-dedupe.ts +0 -63
- package/src/utils/conflict-detect.ts +0 -668
- package/src/utils/env-allowlist.ts +0 -30
- package/src/utils/env-filter.ts +0 -155
- package/src/utils/file-coalescer.ts +0 -98
- package/src/utils/fingerprint.ts +0 -180
- package/src/utils/frontmatter.ts +0 -70
- package/src/utils/fs-watch.ts +0 -37
- package/src/utils/gh-protocol.ts +0 -556
- package/src/utils/git.ts +0 -260
- package/src/utils/guards.ts +0 -107
- package/src/utils/ids.ts +0 -24
- package/src/utils/incremental-reader.ts +0 -220
- package/src/utils/internal-error.ts +0 -10
- package/src/utils/names.ts +0 -36
- package/src/utils/ndjson.ts +0 -115
- package/src/utils/paths.ts +0 -227
- package/src/utils/project-detector.ts +0 -160
- package/src/utils/redaction.ts +0 -347
- package/src/utils/resolve-shell.ts +0 -36
- package/src/utils/run-watcher-registry.ts +0 -152
- package/src/utils/safe-paths.ts +0 -383
- package/src/utils/scan-cache.ts +0 -144
- package/src/utils/session-utils.ts +0 -110
- package/src/utils/sleep.ts +0 -54
- package/src/utils/socket-path.ts +0 -127
- package/src/utils/sse-parser.ts +0 -129
- package/src/utils/task-name-generator.ts +0 -337
- package/src/utils/timings.ts +0 -33
- package/src/utils/token-counter.ts +0 -200
- package/src/utils/visual.ts +0 -207
- package/src/workflows/cost-estimator.ts +0 -34
- package/src/workflows/discover-workflows.ts +0 -290
- package/src/workflows/intermediate-store.ts +0 -166
- package/src/workflows/preflight-validator.ts +0 -168
- package/src/workflows/topology-analyzer.ts +0 -203
- package/src/workflows/validate-workflow.ts +0 -50
- package/src/workflows/workflow-config.ts +0 -70
- package/src/workflows/workflow-serializer.ts +0 -32
- package/src/worktree/branch-freshness.ts +0 -112
- package/src/worktree/cleanup.ts +0 -341
- package/src/worktree/worktree-manager.ts +0 -1200
|
@@ -1,61 +0,0 @@
|
|
|
1
|
-
# Bug #18 Fix: Child Pi Workers Hang on stdin with setsid+detached
|
|
2
|
-
|
|
3
|
-
## Root Cause
|
|
4
|
-
|
|
5
|
-
When `buildChildPiSpawnOptions()` in `child-pi.ts` used `stdio: ["pipe", "pipe", "pipe"]` with `detached: true` and `setsid: true`, the child process would hang indefinitely with:
|
|
6
|
-
- `toolUses: 0`
|
|
7
|
-
- `jsonEvents: 0`
|
|
8
|
-
- No stdout output ever received
|
|
9
|
-
|
|
10
|
-
The issue is that `stdin: "pipe"` creates a readable stream that the child process can block on waiting for input. Even though:
|
|
11
|
-
1. The task is passed via CLI args (`Task: ...`), not stdin
|
|
12
|
-
2. The parent never writes to the child's stdin
|
|
13
|
-
3. `child.stdin?.write()` is only called for "steer" (wrap-up message)
|
|
14
|
-
|
|
15
|
-
The combination of `setsid: true` + `detached: true` + `stdio: ["pipe", ...]` creates a state where the child's stdin pipe can hang/block, preventing the child from processing.
|
|
16
|
-
|
|
17
|
-
## The Fix
|
|
18
|
-
|
|
19
|
-
Changed `stdio: ["pipe", "pipe", "pipe"]` to `stdio: ["ignore", "pipe", "pipe"]` in `buildChildPiSpawnOptions()`.
|
|
20
|
-
|
|
21
|
-
With `stdin: "ignore"`:
|
|
22
|
-
- No stdin pipe is created at all
|
|
23
|
-
- The child immediately gets EOF on stdin (from /dev/null)
|
|
24
|
-
- Child never blocks waiting for stdin
|
|
25
|
-
- Task is delivered via CLI args as expected
|
|
26
|
-
|
|
27
|
-
## File Changed
|
|
28
|
-
|
|
29
|
-
**`/home/bom/source/my_pi/pi-crew/src/runtime/child-pi.ts`** (line ~199):
|
|
30
|
-
|
|
31
|
-
```typescript
|
|
32
|
-
return {
|
|
33
|
-
cwd,
|
|
34
|
-
env: { ...filteredEnv, PI_CREW_PARENT_PID: String(process.pid) },
|
|
35
|
-
stdio: ["ignore", "pipe", "pipe"], // stdin=ignore: child doesn't wait for input; task comes via CLI args
|
|
36
|
-
detached: process.platform !== "win32",
|
|
37
|
-
setsid: true,
|
|
38
|
-
windowsHide: true,
|
|
39
|
-
} as SpawnOptions;
|
|
40
|
-
```
|
|
41
|
-
|
|
42
|
-
## Verification
|
|
43
|
-
|
|
44
|
-
Before fix: Workers timed out at 300s with `toolUses: 0, jsonEvents: 0`
|
|
45
|
-
|
|
46
|
-
After fix: Workers actively process tasks, producing output in seconds:
|
|
47
|
-
```
|
|
48
|
-
01_explore: status=running toolUses=203 jsonEvents=1375
|
|
49
|
-
02_plan: status=running toolUses=67 jsonEvents=483
|
|
50
|
-
```
|
|
51
|
-
|
|
52
|
-
The run successfully progresses through phases (explore, plan) with active tool use and JSON event generation.
|
|
53
|
-
|
|
54
|
-
## Test Results
|
|
55
|
-
|
|
56
|
-
- **Bug #18 (worker stdin hang)**: FIXED - workers now produce output immediately
|
|
57
|
-
- **Bug #17 (background runner death at 35s)**: FIXED - runners survive indefinitely
|
|
58
|
-
|
|
59
|
-
Both bugs were related to process/session lifecycle issues but had different root causes:
|
|
60
|
-
- Bug #17: `cleanupRuntime()` killing all async runners on session_shutdown
|
|
61
|
-
- Bug #18: `stdio: ["pipe", ...]` with `setsid`+`detached` causing stdin block
|
|
@@ -1,52 +0,0 @@
|
|
|
1
|
-
# Bug #19: Phantom Runs from Temp Workspaces
|
|
2
|
-
|
|
3
|
-
## Problem
|
|
4
|
-
Runs in `/tmp/pi-crew-*/` directories were appearing in production dashboard as "running" even after processes died. This caused confusion and UI clutter with "9 running" when there was actually only 1.
|
|
5
|
-
|
|
6
|
-
## Root Cause
|
|
7
|
-
1. Test suite (npm test) creates runs in `/tmp/` with live-session or scaffold runtime
|
|
8
|
-
2. These runs don't have `async.pid` (child-process runs have it, live-session/scaffold don't)
|
|
9
|
-
3. When tests complete/crash, entries remain in `active-run-index.json`
|
|
10
|
-
4. `collectRuns()` scans temp dirs and shows stale manifests
|
|
11
|
-
5. `activeRunEntries()` was not checking timestamp for non-async runs
|
|
12
|
-
|
|
13
|
-
## Fix
|
|
14
|
-
|
|
15
|
-
### 1. `src/extension/run-index.ts` - collectRuns()
|
|
16
|
-
Added detection for temp directories and PID alive check:
|
|
17
|
-
```typescript
|
|
18
|
-
const tempDirs = [os.tmpdir(), "/var/tmp", "/tmp"];
|
|
19
|
-
const isTempRoot = tempDirs.some((t) => root.startsWith(t + path.sep));
|
|
20
|
-
|
|
21
|
-
// For runs in temp dirs, verify background process is alive
|
|
22
|
-
if (isTempRoot && (manifest.status === "running" || ...)) {
|
|
23
|
-
const asyncPidPath = path.join(path.dirname(manifest.stateRoot), "async.pid");
|
|
24
|
-
// ... check PID alive
|
|
25
|
-
}
|
|
26
|
-
```
|
|
27
|
-
|
|
28
|
-
### 2. `src/state/active-run-registry.ts` - filterAliveEntries() + activeRunEntries()
|
|
29
|
-
Added 30-minute timeout for non-async runs:
|
|
30
|
-
```typescript
|
|
31
|
-
// 2.19 — Stale non-async run: live-session/scaffold runs older than 30 min
|
|
32
|
-
if (!raw.async) {
|
|
33
|
-
const updatedAt = typeof raw.updatedAt === 'string' ? Date.parse(raw.updatedAt) : NaN;
|
|
34
|
-
if (Number.isFinite(updatedAt) && Date.now() - updatedAt > 30 * 60 * 1000) return false;
|
|
35
|
-
}
|
|
36
|
-
```
|
|
37
|
-
|
|
38
|
-
## Files Changed
|
|
39
|
-
- `src/extension/run-index.ts`: Added `os` import and temp root check in collectRuns()
|
|
40
|
-
- `src/state/active-run-registry.ts`: Added 30-min timeout for non-async runs in both filterAliveEntries() and activeRunEntries()
|
|
41
|
-
|
|
42
|
-
## Verification
|
|
43
|
-
After fix:
|
|
44
|
-
- Active-run-index is cleared of stale entries
|
|
45
|
-
- Runs older than 30 min with no async.pid are filtered out
|
|
46
|
-
- Only valid runs with alive PIDs or recent timestamps are shown
|
|
47
|
-
|
|
48
|
-
## Why Two Places?
|
|
49
|
-
- `run-index.ts` - handles scanning runs from disk (collectRuns)
|
|
50
|
-
- `active-run-registry.ts` - handles the in-memory registry of active runs
|
|
51
|
-
|
|
52
|
-
Both needed the fix because the dashboard uses both sources.
|
|
@@ -1,47 +0,0 @@
|
|
|
1
|
-
# Bug #20: Infinite Retry Loop - Mock Tasks Never Complete
|
|
2
|
-
|
|
3
|
-
## Symptom
|
|
4
|
-
When running tests with `PI_TEAMS_MOCK_CHILD_PI=json-success`, tasks were stuck in an infinite loop:
|
|
5
|
-
- Task 01_explore ran repeatedly (100+ times)
|
|
6
|
-
- Each run completed quickly but the task status stayed "needs_attention"
|
|
7
|
-
- The DAG scheduler kept re-scheduling the same task
|
|
8
|
-
|
|
9
|
-
## Root Cause
|
|
10
|
-
The DAG-based task scheduler in `team-runner.ts` uses `completedIds` to determine which tasks are "done" and can unblock downstream tasks. However, it only considered `status === "completed"` as terminal.
|
|
11
|
-
|
|
12
|
-
When a task has `yield.enabled` but the worker doesn't call `submit_result`, the task returns `status === "needs_attention"` instead of "completed". This is a terminal state (treated as such in other places), but the DAG scheduler didn't recognize it as complete.
|
|
13
|
-
|
|
14
|
-
As a result:
|
|
15
|
-
1. Task 01_explore returns "needs_attention"
|
|
16
|
-
2. The DAG still thinks 01_explore is NOT completed
|
|
17
|
-
3. The DAG returns all tasks (including 01_explore) as "ready"
|
|
18
|
-
4. 01_explore gets re-scheduled, creating an infinite loop
|
|
19
|
-
|
|
20
|
-
## Fix
|
|
21
|
-
In `src/runtime/team-runner.ts`, change `completedIds` computation to also treat "needs_attention" as a completed state:
|
|
22
|
-
|
|
23
|
-
```typescript
|
|
24
|
-
// Before
|
|
25
|
-
const completedIds = new Set(tasks.filter((t) => t.status === "completed").map((t) => t.id));
|
|
26
|
-
|
|
27
|
-
// After
|
|
28
|
-
const completedIds = new Set(tasks.filter((t) => t.status === "completed" || t.status === "needs_attention").map((t) => t.id));
|
|
29
|
-
```
|
|
30
|
-
|
|
31
|
-
This fix was applied in three places in team-runner.ts:
|
|
32
|
-
- Line 411: DAG completion check
|
|
33
|
-
- Line 422: taskResults for workflow context
|
|
34
|
-
- Line 574: taskResults for phase advancement
|
|
35
|
-
|
|
36
|
-
## Why This Works
|
|
37
|
-
- "needs_attention" is already in the `terminalStatuses` set (used for workflow phase advancement)
|
|
38
|
-
- The task graph scheduler already treats "needs_attention" as a terminal state
|
|
39
|
-
- The only missing piece was the DAG-based dependency check
|
|
40
|
-
|
|
41
|
-
## Verification
|
|
42
|
-
Run a test with the mock:
|
|
43
|
-
```bash
|
|
44
|
-
PI_TEAMS_MOCK_CHILD_PI=json-success PI_TEAMS_EXECUTE_WORKERS=1 node --test test/unit/agent-runtime-files.test.ts
|
|
45
|
-
```
|
|
46
|
-
|
|
47
|
-
Expected: Test completes in ~3 seconds with 1 pass, 0 failures, 0 skipped.
|
|
@@ -1,3 +0,0 @@
|
|
|
1
|
-
# Round 29 withFileLockSync re-entrance fix — verification
|
|
2
|
-
|
|
3
|
-
Verified the v0.9.10 `withFileLockSync` re-entrance fix against `pi-crew/src/state/locks.ts`. The `fileLockHeldByUs` re-entrance map is declared at `src/state/locks.ts:371` as `const fileLockHeldByUs = new Map<string, string>(); // lockFile -> token`; `export function withFileLockSync<T>(filePath: string, fn: () => T, options: RunLockOptions = {}): T {` is at `src/state/locks.ts:288`; the re-entrance check `const existingToken = fileLockHeldByUs.get(lockFile);` is at `src/state/locks.ts:302` (immediately followed by the `if (existingToken) { return fn(); }` fast-path). After successful acquire, `fileLockHeldByUs.set(lockFile, token);` is at `src/state/locks.ts:336`, and the matching `fileLockHeldByUs.delete(lockFile);` lives inside the `finally` block at `src/state/locks.ts:341`, immediately followed by `releaseLock(lockFile, token)` — i.e. the map entry is cleared BEFORE the actual filesystem release, guaranteeing no stale map entries can survive a thrown exception. Test `pi-crew/test/unit/round29-file-lock-reentrance.test.ts` reports **5/5 passing** (≈0.41s wall; longest sub-test 3.76ms) via `npx tsx --test`, covering nested-same-path, deeply-nested (3 levels), different-paths, post-release reacquire, and value-flow cases. Both commits confirmed in local `git log --oneline`: `7085d8d` ("Add re-entrance guard to withFileLockSync (Round 29 follow-up)") and `5876c38` ("Fix HandoffManager setInterval leak: prevent test file-level hangs"). **Verdict: VERIFIED** — no anomalies; every line citation and the test pass-count match the claim exactly.
|
|
@@ -1,12 +0,0 @@
|
|
|
1
|
-
# Smoke Test — v0.9.10 File-Level Test Hang Fixes
|
|
2
|
-
|
|
3
|
-
3 commits resolved BG2 (`verify-full2`) file-level test hangs/timeouts. All verified under a 60s timeout bound (per the 3863s lesson); `tsc --noEmit` clean.
|
|
4
|
-
|
|
5
|
-
- **cadb5b7** — `Fix CountdownTimer drift and redactSecretString ReDoS regression`
|
|
6
|
-
Correctness/perf fixes surfaced by the P1f ReDoS regression test (300KB no-dot input) and BG2 sweep; not attributed to a specific hanging test. `CountdownTimer` switched from `setInterval` to recursive `setTimeout` so a busy event loop no longer skips a second value (`src/ui/loaders.ts:109` class; `scheduleNextTick` at `:143`; `.unref()` defense-in-depth at `:157`; test `test/unit/loaders.test.ts`). `redactSecretString` (`src/utils/redaction.ts:177`) inner loop now advances past non-secret alphanumeric runs (O(n²)→O(n); FIX comment `:207-220`) and `isKeyChar` uses `charCodeAt` (`:223-232`) in place of `/[a-zA-Z0-9_-]/.test` — ~5× faster, no regex allocation.
|
|
7
|
-
|
|
8
|
-
- **5876c38** — `Fix HandoffManager setInterval leak: prevent test file-level hangs`
|
|
9
|
-
Resolves `chain-runner.test.ts` file-level hang. `HandoffManager.startCleanupTimer` (`src/runtime/handoff-manager.ts:202-213`) now calls `.unref()` on the cleanup `setInterval` at `:212-213`. Without `.unref()`, every `new HandoffManager()` in a mock helper leaked a handle that kept Node alive past test completion.
|
|
10
|
-
|
|
11
|
-
- **7085d8d** — `Add re-entrance guard to withFileLockSync (Round 29 follow-up)`
|
|
12
|
-
Resolves `orphan-worker-registry.test.ts` + `cleanup-full-flow.test.ts` hangs. Added `fileLockHeldByUs: Map<string,string>` re-entrance guard to `withFileLockSync` (`src/state/locks.ts:295` FIX comment; `:302` existingToken short-circuit; `:336` Map.set; `:341` finally delete; `:371` Map declaration) mirroring the existing `runLockHeldByUs` pattern. Without the guard, nested same-path acquisition read its own freshly-written lock file and retried for the full `staleMs` window. Regression test: `test/unit/round29-file-lock-reentrance.test.ts` (5/5 pass, 547ms; orphan-worker-registry 15/15 496ms was hanging at 30s; cleanup-full-flow 4/4 1377ms was hanging at 30s).
|
|
@@ -1,463 +0,0 @@
|
|
|
1
|
-
# Follow-up Plan — pi-crew (2026-05-12)
|
|
2
|
-
|
|
3
|
-
Author: Droid (Factory) | Related: `docs/code-review-2026-05-11.md`, commits `2aebf33`, `7c5b3c2`.
|
|
4
|
-
|
|
5
|
-
This document consolidates the outstanding items AFTER fixing BUG-001..BUG-007 + NIT-001..NIT-004, comprising:
|
|
6
|
-
1. **Minor concerns** arising from the fixes just applied.
|
|
7
|
-
2. **Newly discovered gaps** found when re-reviewing the entire `pi-crew/` codebase.
|
|
8
|
-
|
|
9
|
-
Every item includes an effort estimate, priority level, related file/code section, and a concrete fix proposal.
|
|
10
|
-
|
|
11
|
-
---
|
|
12
|
-
|
|
13
|
-
## Part A — Adjusting minor concerns from the fixes just applied
|
|
14
|
-
|
|
15
|
-
### A1 — `branchExists` only checks local ref → misses remote-tracking branches
|
|
16
|
-
|
|
17
|
-
**Severity:** Low | **Effort:** ~20 minutes | **File:** `src/worktree/worktree-manager.ts:100-107`
|
|
18
|
-
|
|
19
|
-
**Current state:**
|
|
20
|
-
```ts
|
|
21
|
-
function branchExists(repoRoot: string, branch: string): boolean {
|
|
22
|
-
try {
|
|
23
|
-
git(repoRoot, ["rev-parse", "--verify", `refs/heads/${branch}`]);
|
|
24
|
-
return true;
|
|
25
|
-
} catch { return false; }
|
|
26
|
-
}
|
|
27
|
-
```
|
|
28
|
-
|
|
29
|
-
**Problem:**
|
|
30
|
-
- Only checks `refs/heads/<branch>`. If the repo has a remote-tracking `refs/remotes/origin/<branch>` (pushed from another machine) but no local one yet, the function returns `false` → enters the `worktree add -b <branch> HEAD` branch → git may fail with "a branch named ... already exists" (because git creates a local branch from the remote) or create a local branch divergent from the remote.
|
|
31
|
-
- Rare in single-machine workflows but easily hit with CI/runner shared repos.
|
|
32
|
-
|
|
33
|
-
**Proposed fix:**
|
|
34
|
-
```ts
|
|
35
|
-
function branchExists(repoRoot: string, branch: string): { local: boolean; remoteOnly: boolean } {
|
|
36
|
-
let local = false;
|
|
37
|
-
try { git(repoRoot, ["rev-parse", "--verify", `refs/heads/${branch}`]); local = true; } catch {}
|
|
38
|
-
if (local) return { local: true, remoteOnly: false };
|
|
39
|
-
// Check remote-tracking
|
|
40
|
-
try {
|
|
41
|
-
const out = execFileSync("git", ["for-each-ref", "--format=%(refname)", `refs/remotes/*/${branch}`],
|
|
42
|
-
{ cwd: repoRoot, encoding: "utf-8" }).trim();
|
|
43
|
-
return { local: false, remoteOnly: out.length > 0 };
|
|
44
|
-
} catch { return { local: false, remoteOnly: false }; }
|
|
45
|
-
}
|
|
46
|
-
|
|
47
|
-
// In prepareTaskWorkspace:
|
|
48
|
-
const exists = branchExists(repoRoot, branch);
|
|
49
|
-
if (exists.local) {
|
|
50
|
-
git(repoRoot, ["worktree", "add", worktreePath, branch]);
|
|
51
|
-
} else if (exists.remoteOnly) {
|
|
52
|
-
// Create local from HEAD instead of remote (avoid divergent track)
|
|
53
|
-
git(repoRoot, ["worktree", "add", "-b", branch, worktreePath, "HEAD"]);
|
|
54
|
-
} else {
|
|
55
|
-
git(repoRoot, ["worktree", "add", "-b", branch, worktreePath, "HEAD"]);
|
|
56
|
-
}
|
|
57
|
-
```
|
|
58
|
-
|
|
59
|
-
**Tests to add:** `test/unit/worktree-manager.test.ts`:
|
|
60
|
-
1. Mock `git for-each-ref` returning a remote-tracking ref → assert no throw.
|
|
61
|
-
2. Branch exists in both local and remote → prefer local (reuse).
|
|
62
|
-
|
|
63
|
-
---
|
|
64
|
-
|
|
65
|
-
### A2 — `resolveJitiRegisterPath` fallback now requires an `exists()` check
|
|
66
|
-
|
|
67
|
-
**Severity:** Low | **Effort:** ~10 minutes | **File:** `src/runtime/async-runner.ts:33-39`
|
|
68
|
-
|
|
69
|
-
**Current state:**
|
|
70
|
-
```ts
|
|
71
|
-
try {
|
|
72
|
-
const fromRequire = jitiRegisterPathFromPackageJson(requireFromHere.resolve("jiti/package.json"));
|
|
73
|
-
if (exists(fromRequire)) return fromRequire; // ← added exists() check
|
|
74
|
-
} catch { /* Fall through. */ }
|
|
75
|
-
return undefined;
|
|
76
|
-
```
|
|
77
|
-
|
|
78
|
-
**Problem:**
|
|
79
|
-
- Old behavior: `require.resolve()` succeeds → push into candidates → return path (assumes `lib/jiti-register.mjs` always exists next to `package.json`).
|
|
80
|
-
- New behavior: adds an `exists()` check → if the test mock for `exists` only accepts one different path, the fallback always fails. The behavior is fine for production (file always exists), but reduces robustness with exotic jiti packaging (e.g. `lib` renamed in a distro build).
|
|
81
|
-
- Not really a bug, just a defensive change.
|
|
82
|
-
|
|
83
|
-
**Proposed fix:**
|
|
84
|
-
Keep the `exists()` check (safer), but add another fallback with `path.join(dirname, "register.mjs")` for different jiti versions, and log a diagnostic event when both miss:
|
|
85
|
-
|
|
86
|
-
```ts
|
|
87
|
-
try {
|
|
88
|
-
const pkgPath = requireFromHere.resolve("jiti/package.json");
|
|
89
|
-
const candidates = [
|
|
90
|
-
jitiRegisterPathFromPackageJson(pkgPath), // lib/jiti-register.mjs
|
|
91
|
-
path.join(path.dirname(pkgPath), "register.mjs"), // register.mjs (older jiti)
|
|
92
|
-
path.join(path.dirname(pkgPath), "dist", "register.mjs"), // dist/register.mjs (some pkg layouts)
|
|
93
|
-
];
|
|
94
|
-
for (const c of candidates) if (exists(c)) return c;
|
|
95
|
-
} catch { /* Fall through. */ }
|
|
96
|
-
return undefined;
|
|
97
|
-
```
|
|
98
|
-
|
|
99
|
-
**Tests to add:** `test/unit/async-runner.test.ts`:
|
|
100
|
-
- Case where `lib/jiti-register.mjs` is missing but `register.mjs` exists → resolver returns it.
|
|
101
|
-
|
|
102
|
-
---
|
|
103
|
-
|
|
104
|
-
### A3 — Test alias `__test__renameWithRetry*` became a `const`, may disable monkey-patching
|
|
105
|
-
|
|
106
|
-
**Severity:** Info | **Effort:** ~5 minutes | **File:** `src/state/atomic-write.ts:73, 91`
|
|
107
|
-
|
|
108
|
-
**Current state:**
|
|
109
|
-
```ts
|
|
110
|
-
export const __test__renameWithRetry = renameWithRetry;
|
|
111
|
-
```
|
|
112
|
-
|
|
113
|
-
**Problem:**
|
|
114
|
-
- If old tests do `import * as mod from "../atomic-write.ts"; mod.__test__renameWithRetry = mockFn;` → the assignment fails (read-only) or has no effect on `atomicWriteFile` (which calls the local `renameWithRetry`).
|
|
115
|
-
- Currently no test in the repo monkey-patches this field (`Grep` confirmed), so it's not a bug.
|
|
116
|
-
|
|
117
|
-
**Proposed fix:**
|
|
118
|
-
- Keep the alias as-is (zero practical impact).
|
|
119
|
-
- Or remove both aliases to reduce the API surface: only export `renameWithRetry`, `renameWithRetryAsync`. Update tests if any use the alias.
|
|
120
|
-
|
|
121
|
-
**Action:** only do this when cleaning up the API surface; not urgent.
|
|
122
|
-
|
|
123
|
-
---
|
|
124
|
-
|
|
125
|
-
## Part B — Newly discovered gaps from re-review
|
|
126
|
-
|
|
127
|
-
### B1 — `bash` hardcoded → broken on Windows (root cause of 8 test failures)
|
|
128
|
-
|
|
129
|
-
**Severity:** Medium | **Effort:** ~45 minutes | **Files:**
|
|
130
|
-
- `src/runtime/post-checks.ts:82`
|
|
131
|
-
- `src/runtime/iteration-hooks.ts:137`
|
|
132
|
-
|
|
133
|
-
**Current state:**
|
|
134
|
-
```ts
|
|
135
|
-
// post-checks.ts:82
|
|
136
|
-
const output = execFileSync("bash", [scriptPath], { ... });
|
|
137
|
-
|
|
138
|
-
// iteration-hooks.ts:137
|
|
139
|
-
const child = spawn("bash", [hookScriptPath], { ... });
|
|
140
|
-
```
|
|
141
|
-
|
|
142
|
-
**Problem:**
|
|
143
|
-
- On Windows, `bash` is usually not on the PATH (unless Git Bash/WSL is installed). All 8 currently failing tests are due to this.
|
|
144
|
-
- Hot code path (post-task check, iteration hook) → Windows users cannot use this feature.
|
|
145
|
-
- The comment in the file says "Spawns `bash <script>`" → docs need updating too.
|
|
146
|
-
|
|
147
|
-
**Proposed fix:**
|
|
148
|
-
1. Resolve bash intelligently:
|
|
149
|
-
```ts
|
|
150
|
-
function resolveBashCmd(): string {
|
|
151
|
-
if (process.platform !== "win32") return "bash";
|
|
152
|
-
// Try Git Bash locations
|
|
153
|
-
for (const cand of [
|
|
154
|
-
process.env.SHELL,
|
|
155
|
-
"C:\\Program Files\\Git\\bin\\bash.exe",
|
|
156
|
-
"C:\\Program Files (x86)\\Git\\bin\\bash.exe",
|
|
157
|
-
]) {
|
|
158
|
-
if (cand && fs.existsSync(cand)) return cand;
|
|
159
|
-
}
|
|
160
|
-
return "bash"; // last resort — let spawn fail with clearer error
|
|
161
|
-
}
|
|
162
|
-
```
|
|
163
|
-
2. Replace both `"bash"` occurrences with `resolveBashCmd()`.
|
|
164
|
-
3. On Windows, if the script is `.ps1` → use `powershell -File`; if `.cmd/.bat` → spawn directly.
|
|
165
|
-
4. Or simpler: skip the test if `!isScriptRunnable("bash")`.
|
|
166
|
-
|
|
167
|
-
**Tests to add:**
|
|
168
|
-
- On Linux CI: current tests pass.
|
|
169
|
-
- On Windows: skip if bash is unavailable, or create a `.ps1` variant.
|
|
170
|
-
- Mock test for `resolveBashCmd()` with a platform stub.
|
|
171
|
-
|
|
172
|
-
---
|
|
173
|
-
|
|
174
|
-
### B2 — Missing direct tests for `worktree-manager.ts` (covers BUG-005, BUG-006)
|
|
175
|
-
|
|
176
|
-
**Severity:** Medium | **Effort:** ~1h | **File:** missing `test/unit/worktree-manager.test.ts`
|
|
177
|
-
|
|
178
|
-
**Problem:**
|
|
179
|
-
- The BUG-005 fix (`branchExists` + `pruneStaleWorktrees`) and BUG-006 fix (`isDirectory()` check) have **no direct tests**.
|
|
180
|
-
- The code review flagged this, but the fix commit only added tests for the schema.
|
|
181
|
-
|
|
182
|
-
**Proposed fix:** create `test/unit/worktree-manager.test.ts` with (using `tmpdir` + real git):
|
|
183
|
-
|
|
184
|
-
```ts
|
|
185
|
-
import { test } from "node:test";
|
|
186
|
-
import assert from "node:assert/strict";
|
|
187
|
-
import * as fs from "node:fs";
|
|
188
|
-
import * as os from "node:os";
|
|
189
|
-
import * as path from "node:path";
|
|
190
|
-
import { execFileSync } from "node:child_process";
|
|
191
|
-
import { prepareTaskWorkspace } from "../../src/worktree/worktree-manager.ts";
|
|
192
|
-
import type { TeamRunManifest, TeamTaskState } from "../../src/state/types.ts";
|
|
193
|
-
|
|
194
|
-
function initGitRepo(dir: string) {
|
|
195
|
-
execFileSync("git", ["init", "-q", "--initial-branch=main"], { cwd: dir });
|
|
196
|
-
execFileSync("git", ["-c", "user.email=t@t", "-c", "user.name=t", "commit", "--allow-empty", "-m", "init"], { cwd: dir });
|
|
197
|
-
}
|
|
198
|
-
|
|
199
|
-
test("prepareTaskWorkspace recovers when branch exists but worktree dir is gone", () => {
|
|
200
|
-
const repo = fs.mkdtempSync(path.join(os.tmpdir(), "pi-crew-wt-"));
|
|
201
|
-
initGitRepo(repo);
|
|
202
|
-
// Pre-create the branch (simulating leftover from crashed run)
|
|
203
|
-
execFileSync("git", ["branch", "pi-crew/run1/task1"], { cwd: repo });
|
|
204
|
-
const manifest = { /* ... minimal manifest ... */ } as TeamRunManifest;
|
|
205
|
-
const task: TeamTaskState = { id: "task1", /* ... */ } as TeamTaskState;
|
|
206
|
-
const result = prepareTaskWorkspace(manifest, task);
|
|
207
|
-
assert.ok(result.worktreePath);
|
|
208
|
-
});
|
|
209
|
-
|
|
210
|
-
test("linkNodeModulesIfPresent rejects when node_modules is a file", () => {
|
|
211
|
-
// ... create file at node_modules location → assert no symlink created
|
|
212
|
-
});
|
|
213
|
-
```
|
|
214
|
-
|
|
215
|
-
---
|
|
216
|
-
|
|
217
|
-
### B3 — `artifact-store.ts` missing tests for hash/size integrity (covers BUG-002)
|
|
218
|
-
|
|
219
|
-
**Severity:** Medium | **Effort:** ~20 minutes | **File:** missing `test/unit/artifact-store.test.ts`
|
|
220
|
-
|
|
221
|
-
**Problem:**
|
|
222
|
-
- The BUG-002 fix changed the hash from `options.content` to `redactSecretString(options.content)` ensuring `contentHash` matches the bytes on disk.
|
|
223
|
-
- There is no test verifying this. There's `api-artifact-security.test.ts` but it doesn't assert the hash.
|
|
224
|
-
|
|
225
|
-
**Proposed fix:** create `test/unit/artifact-store.test.ts`:
|
|
226
|
-
```ts
|
|
227
|
-
import { test } from "node:test";
|
|
228
|
-
import assert from "node:assert/strict";
|
|
229
|
-
import * as fs from "node:fs";
|
|
230
|
-
import * as path from "node:path";
|
|
231
|
-
import * as os from "node:os";
|
|
232
|
-
import { createHash } from "node:crypto";
|
|
233
|
-
import { writeArtifact } from "../../src/state/artifact-store.ts";
|
|
234
|
-
|
|
235
|
-
test("writeArtifact: contentHash matches sha256 of bytes on disk", () => {
|
|
236
|
-
const root = fs.mkdtempSync(path.join(os.tmpdir(), "pi-crew-art-"));
|
|
237
|
-
const desc = writeArtifact(root, {
|
|
238
|
-
kind: "log", relativePath: "x.log",
|
|
239
|
-
content: "api_key=AKIA0123456789ABCDEF\nplain text",
|
|
240
|
-
producer: "test",
|
|
241
|
-
});
|
|
242
|
-
const onDisk = fs.readFileSync(desc.path);
|
|
243
|
-
const expected = createHash("sha256").update(onDisk).digest("hex");
|
|
244
|
-
assert.strictEqual(desc.contentHash, expected);
|
|
245
|
-
assert.strictEqual(desc.sizeBytes, onDisk.length);
|
|
246
|
-
assert.ok(!onDisk.toString("utf-8").includes("AKIA0123456789ABCDEF"));
|
|
247
|
-
});
|
|
248
|
-
|
|
249
|
-
test("writeArtifact: rejects path traversal", () => {
|
|
250
|
-
const root = fs.mkdtempSync(path.join(os.tmpdir(), "pi-crew-art-"));
|
|
251
|
-
assert.throws(() => writeArtifact(root, {
|
|
252
|
-
kind: "log", relativePath: "../escape.log", content: "x", producer: "t",
|
|
253
|
-
}), /Invalid artifact path/);
|
|
254
|
-
});
|
|
255
|
-
```
|
|
256
|
-
|
|
257
|
-
---
|
|
258
|
-
|
|
259
|
-
### B4 — Missing sync vs async parity test for lock retry (covers BUG-004)
|
|
260
|
-
|
|
261
|
-
**Severity:** Low | **Effort:** ~30 minutes | **File:** extend `test/unit/locks-race.test.ts`
|
|
262
|
-
|
|
263
|
-
**Problem:**
|
|
264
|
-
- The BUG-004 fix synchronized sync ↔ async behavior (both retry up to the deadline). `locks-race.test.ts` only tests superficially; there's no case for `rmSync` race + asserting the lock is acquired after retry for both sync and async.
|
|
265
|
-
|
|
266
|
-
**Proposed fix:** add 2 tests:
|
|
267
|
-
```ts
|
|
268
|
-
test("withRunLockSync retries when rmSync fails once on stale lock", async () => {
|
|
269
|
-
// Create stale lock, monkey-patch fs.rmSync first call → throw EBUSY
|
|
270
|
-
// Assert lock is acquired on retry
|
|
271
|
-
});
|
|
272
|
-
|
|
273
|
-
test("withRunLock (async) and withRunLockSync exhibit identical stale-lock recovery", async () => {
|
|
274
|
-
// Same scenario for both → both succeed
|
|
275
|
-
});
|
|
276
|
-
```
|
|
277
|
-
|
|
278
|
-
---
|
|
279
|
-
|
|
280
|
-
### B5 — `runSetupHook` doesn't filter dangerous env vars when spawning the hook
|
|
281
|
-
|
|
282
|
-
**Severity:** Low (defense-in-depth) | **Effort:** ~15 minutes | **File:** `src/worktree/worktree-manager.ts:67-88`
|
|
283
|
-
|
|
284
|
-
**Current state:**
|
|
285
|
-
```ts
|
|
286
|
-
const result = spawnSync(nodeHook ? process.execPath : hookPath, ..., {
|
|
287
|
-
cwd: worktreePath,
|
|
288
|
-
encoding: "utf-8",
|
|
289
|
-
input: JSON.stringify({...}),
|
|
290
|
-
timeout: cfg.setupHookTimeoutMs ?? 30_000,
|
|
291
|
-
shell: false,
|
|
292
|
-
// ← Does NOT pass env → spawn uses process.env (full inherit)
|
|
293
|
-
});
|
|
294
|
-
```
|
|
295
|
-
|
|
296
|
-
**Problem:**
|
|
297
|
-
- The hook runs with the full `process.env` → may leak `API_KEY`, `*_TOKEN`, `OPENAI_KEY`, etc. In contrast, `post-checks.ts` and `iteration-hooks.ts` already restrict env.
|
|
298
|
-
- AGENTS.md security baseline: "env-secret filtering before spawn".
|
|
299
|
-
|
|
300
|
-
**Proposed fix:**
|
|
301
|
-
```ts
|
|
302
|
-
import { sanitizeEnvSecrets } from "../utils/redaction.ts"; // or equivalent
|
|
303
|
-
|
|
304
|
-
const result = spawnSync(..., {
|
|
305
|
-
cwd: worktreePath,
|
|
306
|
-
encoding: "utf-8",
|
|
307
|
-
input: JSON.stringify({...}),
|
|
308
|
-
timeout: cfg.setupHookTimeoutMs ?? 30_000,
|
|
309
|
-
shell: false,
|
|
310
|
-
env: sanitizeEnvSecrets(process.env, { allowList: ["PATH", "HOME", "USERPROFILE", "TEMP", "TMP", "LANG", "PI_*"] }),
|
|
311
|
-
});
|
|
312
|
-
```
|
|
313
|
-
|
|
314
|
-
(Leverage the existing helper in `child-pi.ts` — refactor into a shared util.)
|
|
315
|
-
|
|
316
|
-
---
|
|
317
|
-
|
|
318
|
-
### B6 — `prepareTaskWorkspace` has no assertion about branch sanity after `branchExists`
|
|
319
|
-
|
|
320
|
-
**Severity:** Info | **Effort:** ~10 minutes | **File:** `src/worktree/worktree-manager.ts:127-133`
|
|
321
|
-
|
|
322
|
-
**Current state:**
|
|
323
|
-
```ts
|
|
324
|
-
pruneStaleWorktrees(repoRoot);
|
|
325
|
-
if (branchExists(repoRoot, branch)) {
|
|
326
|
-
git(repoRoot, ["worktree", "add", worktreePath, branch]);
|
|
327
|
-
}
|
|
328
|
-
```
|
|
329
|
-
|
|
330
|
-
**Problem:**
|
|
331
|
-
- If the branch is currently **checked out** in another worktree (not yet pruned), `git worktree add <path> <branch>` will fail. We should catch this and emit a clearer hint to the user.
|
|
332
|
-
|
|
333
|
-
**Proposed fix:** wrap with try/catch, parse the error message, throw an error with an actionable message:
|
|
334
|
-
```ts
|
|
335
|
-
try {
|
|
336
|
-
git(repoRoot, ["worktree", "add", worktreePath, branch]);
|
|
337
|
-
} catch (error) {
|
|
338
|
-
const msg = error instanceof Error ? error.message : String(error);
|
|
339
|
-
if (/already checked out at/.test(msg)) {
|
|
340
|
-
throw new Error(`Branch '${branch}' is checked out at another worktree. Run \`team cleanup runId=${manifest.runId} force=true\` or manually remove the conflicting worktree.`);
|
|
341
|
-
}
|
|
342
|
-
throw error;
|
|
343
|
-
}
|
|
344
|
-
```
|
|
345
|
-
|
|
346
|
-
---
|
|
347
|
-
|
|
348
|
-
### B7 — `team-tool.ts` has 1 lazy-import `handleRun` not following the `// LAZY: <reason>` style
|
|
349
|
-
|
|
350
|
-
**Severity:** Info | **Effort:** ~2 minutes | **File:** `src/extension/team-tool.ts:56-62`
|
|
351
|
-
|
|
352
|
-
**Current state:**
|
|
353
|
-
```ts
|
|
354
|
-
// Lazy-loaded: run.ts pulls in spawnBackgroundTeamRun, resolveCrewRuntime, etc.
|
|
355
|
-
// Static import fails silently in some jiti contexts (child-process), leaving handleRun undefined.
|
|
356
|
-
import type { handleRun as HandleRunFn } from "./team-tool/run.ts";
|
|
357
|
-
let _cachedHandleRun: typeof HandleRunFn | undefined;
|
|
358
|
-
async function handleRun(...args: Parameters<typeof HandleRunFn>): Promise<...> {
|
|
359
|
-
if (!_cachedHandleRun) {
|
|
360
|
-
const mod = await import("./team-tool/run.ts"); // ← missing // LAZY: marker
|
|
361
|
-
...
|
|
362
|
-
}
|
|
363
|
-
}
|
|
364
|
-
```
|
|
365
|
-
|
|
366
|
-
**Proposed fix:** add the marker to align with the other 11 already-marked sites:
|
|
367
|
-
```ts
|
|
368
|
-
async function handleRun(...) {
|
|
369
|
-
if (!_cachedHandleRun) {
|
|
370
|
-
// LAZY: run.ts pulls in spawnBackgroundTeamRun + resolveCrewRuntime; also avoids jiti import race.
|
|
371
|
-
const mod = await import("./team-tool/run.ts");
|
|
372
|
-
...
|
|
373
|
-
}
|
|
374
|
-
}
|
|
375
|
-
```
|
|
376
|
-
|
|
377
|
-
---
|
|
378
|
-
|
|
379
|
-
### B8 — `redaction-transcript-roundtrip.test.ts` doesn't exist yet (NIT-004)
|
|
380
|
-
|
|
381
|
-
**Severity:** Low | **Effort:** ~30 minutes | **File:** missing new test
|
|
382
|
-
|
|
383
|
-
**Problem:**
|
|
384
|
-
- Code review NIT-004 suggested a test verifying that the transcript on disk and the artifact result both contain no raw secrets. This test doesn't exist yet.
|
|
385
|
-
|
|
386
|
-
**Proposed fix:** create `test/unit/redaction-transcript-roundtrip.test.ts`:
|
|
387
|
-
1. Create a fake transcript JSONL with a line containing `OPENAI_API_KEY=sk-abc...`.
|
|
388
|
-
2. Call `appendTranscript` (via the `child-pi` helper export).
|
|
389
|
-
3. Read the file → assert no raw secret.
|
|
390
|
-
4. Call the recovery path → assert the artifact result is also redacted.
|
|
391
|
-
|
|
392
|
-
---
|
|
393
|
-
|
|
394
|
-
### B9 — CI grep-check to block `await import(...)` without a marker
|
|
395
|
-
|
|
396
|
-
**Severity:** Low | **Effort:** ~15 minutes | **File:** add script + GitHub Actions
|
|
397
|
-
|
|
398
|
-
**Problem:**
|
|
399
|
-
- Code review BUG-003 Option A proposed "add a grep-check in CI to block unmarked dynamic imports". Not done yet.
|
|
400
|
-
|
|
401
|
-
**Proposed fix:** create `scripts/check-lazy-imports.mjs`:
|
|
402
|
-
```js
|
|
403
|
-
import { execSync } from "node:child_process";
|
|
404
|
-
const out = execSync(
|
|
405
|
-
`git grep -nE 'await import\\(' -- 'src/**/*.ts' | grep -v '// LAZY:'`,
|
|
406
|
-
{ encoding: "utf-8" }
|
|
407
|
-
).split("\n").filter((l) => l && !l.includes("// LAZY:"));
|
|
408
|
-
// Or check that the preceding line contains `// LAZY:`
|
|
409
|
-
if (out.length > 0) {
|
|
410
|
-
console.error("Dynamic imports without `// LAZY:` marker:\n" + out.join("\n"));
|
|
411
|
-
process.exit(1);
|
|
412
|
-
}
|
|
413
|
-
```
|
|
414
|
-
Add to `package.json`:
|
|
415
|
-
```json
|
|
416
|
-
"scripts": {
|
|
417
|
-
"check:lazy-imports": "node scripts/check-lazy-imports.mjs",
|
|
418
|
-
"ci": "npm run typecheck && npm run check:lazy-imports && npm test && npm pack --dry-run"
|
|
419
|
-
}
|
|
420
|
-
```
|
|
421
|
-
|
|
422
|
-
---
|
|
423
|
-
|
|
424
|
-
## Implementation priority
|
|
425
|
-
|
|
426
|
-
| # | Item | Severity | Effort | Recommendation |
|
|
427
|
-
|---|---|---|---|---|
|
|
428
|
-
| 1 | B1 (bash portability) | Medium | 45 minutes | Current sprint — fix 8 failing tests on Windows |
|
|
429
|
-
| 2 | B2 (worktree test) | Medium | 1h | Current sprint — regression guard for BUG-005/006 |
|
|
430
|
-
| 3 | B3 (artifact-store test) | Medium | 20 minutes | Current sprint — verify BUG-002 fix |
|
|
431
|
-
| 4 | A1 (branchExists remote-tracking) | Low | 20 minutes | Next sprint |
|
|
432
|
-
| 5 | B5 (setup-hook env filter) | Low | 15 minutes | Next sprint — defense-in-depth |
|
|
433
|
-
| 6 | B6 (worktree checked-out hint) | Info | 10 minutes | Next sprint — UX |
|
|
434
|
-
| 7 | B7 (LAZY marker consistency) | Info | 2 minutes | Anytime |
|
|
435
|
-
| 8 | B4 (lock parity test) | Low | 30 minutes | Next sprint |
|
|
436
|
-
| 9 | B8 (redaction roundtrip test) | Low | 30 minutes | Next sprint |
|
|
437
|
-
| 10 | B9 (CI grep-check) | Low | 15 minutes | Next sprint |
|
|
438
|
-
| 11 | A2 (async-runner fallback robust) | Low | 10 minutes | Not urgent |
|
|
439
|
-
| 12 | A3 (test alias cleanup) | Info | 5 minutes | Optional |
|
|
440
|
-
|
|
441
|
-
**Total effort priority 1 (medium):** ~2h 5 minutes.
|
|
442
|
-
**Total effort priority 2 (low):** ~1h 50 minutes.
|
|
443
|
-
|
|
444
|
-
---
|
|
445
|
-
|
|
446
|
-
## Proposed commit batches
|
|
447
|
-
|
|
448
|
-
- **Batch 1 (must-fix):** B1 + B2 + B3 → 1 PR "test+portability hardening" (~2h).
|
|
449
|
-
- **Batch 2 (nice-to-have):** A1 + B5 + B6 + B7 + B9 → 1 PR "worktree + lazy-import polish" (~1h).
|
|
450
|
-
- **Batch 3 (test debt):** B4 + B8 → 1 PR "additional regression tests" (~1h).
|
|
451
|
-
- **Defer:** A2, A3 until there's a user-visible issue.
|
|
452
|
-
|
|
453
|
-
---
|
|
454
|
-
|
|
455
|
-
## Positive notes after round 2 review
|
|
456
|
-
|
|
457
|
-
- All 7 BUGs + 4 NITs from the prior code review have been fixed with clear commits, with tests for the schema.
|
|
458
|
-
- The `// LAZY:` comment has been consistently added at 11/12 dynamic import sites.
|
|
459
|
-
- Lock retry logic is now unified sync ↔ async (both have deadline + retry).
|
|
460
|
-
- Worktree handle crash resume works correctly (prune + branchExists fallback).
|
|
461
|
-
- Artifact `contentHash` is now verifiable via `sha256(fs.readFileSync(desc.path))`.
|
|
462
|
-
- No more `any` types in `src/` (grep confirmed).
|
|
463
|
-
- `node_modules/jiti` resolution is robust across any monorepo layout.
|