pi-crew 0.9.50 → 0.9.52

package/docs/archive/pi-crew-test-final.md

@@ -1,120 +0,0 @@
-# pi-crew v0.2.20 — Final Test Report (Bug #14 Fixed)
-
-**Date:** 2026-05-20  
-**Environment:** linux/x64, Node v22.22.0, Pi CLI v0.65.2, pi-crew v0.2.20
-
-## Test Summary
-
-| Test | Status | Notes |
-|---|---|---|
-| TypeScript compile | ✅ Pass | No errors |
-| Unit tests (stale-reconciler) | ✅ Pass | 8/8 tests pass |
-| team action='list' | ✅ Pass | 10 agents, 6 teams, 6 workflows |
-| team action='validate' | ✅ Pass | 0 errors, 0 warnings |
-| team action='doctor' | ✅ Pass | All 7 categories pass |
-| Foreground fast-fix run (3 phases) | ✅ Pass | All 3 phases completed in ~6 min |
-| needs_attention status | ✅ Confirmed | Tasks show `activityState: needs_attention` after completion |
-| Bug #14 (infinite retry loop) | ✅ Fixed | tasks no longer re-scheduled after needs_attention |
-
-## End-to-End Test: fast-fix Team Run
-
-**Run ID:** `team_20260520030711_3357160aa680cc2d`  
-**Duration:** ~6 minutes (03:07:11 → 03:13:10)  
-**Goal:** Quick test of pi-crew task completion
-
-### Task Progression
-
-| Phase | Task | Status | Duration |
-|---|---|---|---|
-| explore | 01_explore | ✅ completed | ~1.5 min |
-| execute | 02_execute | ✅ completed | ~2 min |
-| verify | 03_verify | ✅ completed | ~2.5 min |
-
-### Key Observations
-
-1. **All 3 phases completed in sequence** — Bug #14 fix prevented infinite loop
-2. **needs_attention status confirmed working** — all 3 tasks show `activityState: needs_attention` after completion (tasks completed without calling `submit_result` the first time, then correctly stayed terminal)
-3. **No infinite retry** — tasks with `needs_attention` were NOT re-scheduled (Bug #14 fix working)
-4. **Phase advancement working** — `workflow.phase_completed` events fired for each phase
-5. **Verification passed** — verifier ran tests, found 1115 passing, 26 pre-existing failures
-
-### needs_attention Behavior Confirmed
-
-From run `team_20260520030711_3357160aa680cc2d`:
-
-```
-Tasks:
-- 01_explore [completed] activityState=needs_attention jsonEvents=120
-- 02_execute [completed] activityState=needs_attention attention=completion_guard jsonEvents=616
-- 03_verify [completed] activityState=needs_attention jsonEvents=220
-
-Effectiveness:
-- needsAttention=01_explore,02_execute,03_verify
-```
-
-All 3 tasks ended with `needs_attention` status and were NOT re-scheduled — confirming Bug #14 fix is working.
-
-## All Bugs Fixed (14 Total)
-
-| # | Bug | Status |
-|---|---|---|
-| 1 | Background workers heartbeat dead (MiniMax 429) | ✅ Fixed |
-| 2 | child-pi.ts doesn't detect 429 | ✅ Fixed |
-| 3 | background.log useless | ✅ Fixed |
-| 4 | worker-startup.ts missing rate_limited classification | ✅ Fixed |
-| 5 | Stale heartbeat notifications after prune | ✅ Fixed |
-| 6 | Concurrent tool calls cancel foreground runs | ✅ Confirmed (constraint) |
-| 7 | Async notifier "stale ctx" dies | ✅ Fixed |
-| 8/10 | MINIMAX_API_KEY filtered out | ✅ Fixed |
-| 9 | Executor yield limit → needs_attention status | ✅ Fixed |
-| 10 | API key allow-list in sanitizeEnvSecrets | ✅ Fixed |
-| 11 | Background runner "spawn pi ENOENT" | ✅ Fixed |
-| 12 | Essential env vars stripped | ✅ Fixed |
-| 13 | Background runner dies after ~59s (OOM) | ✅ Fixed (3 layers) |
-| 14 | Infinite retry loop (needs_attention re-scheduled) | ✅ Fixed |
-
-## Files Modified (23 source files)
-
-```
-src/config/defaults.ts
-src/extension/async-notifier.ts
-src/observability/event-to-metric.ts
-src/runtime/async-runner.ts
-src/runtime/background-runner.ts
-src/runtime/child-pi.ts
-src/runtime/crash-recovery.ts
-src/runtime/crew-agent-runtime.ts
-src/runtime/phase-progress.ts
-src/runtime/pi-spawn.ts
-src/runtime/stale-reconciler.ts
-src/runtime/task-display.ts
-src/runtime/task-graph-scheduler.ts      ← Bug #14 fix
-src/runtime/task-runner.ts
-src/runtime/team-runner.ts
-src/state/contracts.ts
-src/state/event-reconstructor.ts
-src/ui/crew-widget.ts
-src/ui/run-event-bus.ts
-src/ui/run-snapshot-cache.ts
-src/ui/snapshot-types.ts
-```
-
-## Doctor Report
-
-```
-Runtime         - OK node=v22.22.0, pi=0.65.2, model=minimax/MiniMax-M2.7
-Filesystem      - OK .crew state at /home/bom/source/my_pi/.crew
-Discovery       - OK 10 agents, 6 teams, 6 workflows
-Resource val    - OK 0 errors, 0 warnings
-Config drift    - OK no drift
-Async/result    - OK fs.watch with polling fallback, session-stale guarded
-Worktrees       - OK dirty worktrees preserved unless force
-```
-
-## Conclusion
-
-pi-crew v0.2.20 is fully functional with all 14 bugs fixed. The system is ready for production use with:
-- Foreground execution: Fully working (fast-fix, research, parallel-research, review teams)
-- Background execution: Protected with 3-layer OOM prevention (memory limit + heartbeat + signal handlers)
-- needs_attention status: Working correctly, no infinite loops
-- All management commands: list, validate, doctor, settings, events, export, import

package/docs/archive/pi-crew-test-results.md

@@ -1,260 +0,0 @@
-# pi-crew v0.2.20 Comprehensive Test Results
-
-**Date:** 2026-05-19  
-**Tester:** Pi Agent (automated)  
-**Environment:** linux/x64, Node v22.22.0, Pi 0.75.3
-
----
-
-## Summary
-
-| Category | Tests | Pass | Fail | Partial |
-|---|---|---|---|---|
-| Resource Discovery | 5 | 5 | 0 | 0 |
-| Subagent Lifecycle | 4 | 0 | 4 | 0 |
-| Team Run Lifecycle | 4 | 1 | 2 | 1 |
-| Planning | 1 | 1 | 0 | 0 |
-| State Management | 6 | 6 | 0 | 0 |
-| Diagnostics | 3 | 3 | 0 | 0 |
-| Portability | 2 | 2 | 0 | 0 |
-| Configuration | 2 | 2 | 0 | 0 |
-| **Total** | **27** | **20** | **6** | **1** |
-
----
-
-## Phase 1: Resource Discovery & Config
-
-### 1.1 `team action='list'`
-- **Input:** list all resources
-- **Expected:** Teams, workflows, agents enumerated
-- **Actual:** 6 teams, 6 workflows, 10 agents listed correctly
-- **Result:** ✅ PASS
-
-### 1.2 `team action='get'` — team detail
-- **Input:** get team=default
-- **Expected:** Team config with roles
-- **Actual:** Returned team with 4 roles (explorer, planner, executor, verifier)
-- **Result:** ✅ PASS
-
-### 1.3 `team action='get'` — workflow detail
-- **Input:** get workflow for implementation team
-- **Expected:** Workflow steps
-- **Actual:** Returned implementation workflow with assess step
-- **Result:** ✅ PASS
-
-### 1.4 `team action='get'` — agent detail
-- **Input:** get agent=explorer
-- **Expected:** Agent config with model, description, instructions
-- **Actual:** Full agent profile with model=minimax/MiniMax-M2.7-highspeed
-- **Result:** ✅ PASS
-
-### 1.5 `team action='recommend'`
-- **Input:** goal="test all features of pi-crew"
-- **Expected:** Suggested team/workflow
-- **Actual:** Recommended implementation team with high confidence
-- **Result:** ✅ PASS
-
----
-
-## Phase 2: Subagent Lifecycle
-
-### 2.1 Agent (explorer) — background launch
-- **Input:** Agent(explorer, run_in_background=true)
-- **Expected:** Agent ID returned, result retrievable
-- **Actual:** Agent started (agent_mpc423rq_1), but returned empty output on retrieval
-- **Result:** ❌ FAIL — Agent spawned but produced no usable output
-
-### 2.2 Agent (planner) — background launch
-- **Input:** Agent(planner, run_in_background=true)
-- **Expected:** Agent ID returned, result retrievable
-- **Actual:** Agent started (agent_mpc423rv_2), but returned empty output
-- **Result:** ❌ FAIL — Same as 2.1
-
-### 2.3 Agent (analyst) — background launch
-- **Input:** Agent(analyst, run_in_background=true)
-- **Expected:** Agent ID returned, result retrievable
-- **Actual:** Agent started (agent_mpc423rw_3), but returned empty output
-- **Result:** ❌ FAIL — Same as 2.1
-
-### 2.4 crew_agent (explorer) — background launch
-- **Input:** crew_agent(explorer, run_in_background=true)
-- **Expected:** Agent ID returned, result retrievable
-- **Actual:** Agent started (agent_mpc423rw_4), but returned empty output
-- **Result:** ❌ FAIL — Same pattern; child-process background workers not producing output
-
----
-
-## Phase 3: Team Run Lifecycle
-
-### 3.1 `team action='run'` — implementation team (async)
-- **Input:** implementation team, async=true, large multi-phase goal
-- **Expected:** Run starts, tasks complete
-- **Actual:** Run started (team_20260519040558_cb5eac17edb6c951), task 01_assess (planner) heartbeat dead after 300s. Worker spawned but produced no output.
-- **Root Cause:** Child-process runtime fell back from live-session. Worker (pid 4011266) timed out after 300s with zero output.
-- **Result:** ❌ FAIL — Heartbeat timeout
-
-### 3.2 `team action='retry'`
-- **Input:** retry failed run
-- **Expected:** Failed task re-queued
-- **Actual:** Task 01_assess queued for retry successfully
-- **Result:** ✅ PASS
-
-### 3.3 `team action='run'` — fast-fix team (foreground/live-session)
-- **Input:** fast-fix team, simple goal (find TODOs)
-- **Expected:** Run completes through explore→execute→verify
-- **Actual:** Run started as live-session, 01_explore completed, but run was cancelled before execute phase
-- **Result:** ⚠️ PARTIAL — Explore completed, run cancelled mid-workflow
-
-### 3.4 `team action='cancel'`
-- **Input:** cancel a stuck run
-- **Expected:** Run status → cancelled
-- **Actual:** Run successfully cancelled
-- **Result:** ✅ PASS
-
----
-
-## Phase 4: Planning
-
-### 4.1 `team action='plan'`
-- **Input:** plan with default team, goal="Add health-check endpoint"
-- **Expected:** Plan with structured steps
-- **Actual:** Returned 4-step plan: explore → plan → execute → verify
-- **Result:** ✅ PASS
-
----
-
-## Phase 5: State Management
-
-### 5.1 `team action='status'`
-- **Input:** status of running/completed runs
-- **Expected:** Detailed run state with task graph
-- **Actual:** Full status with task graph, events, artifacts, policy decisions
-- **Result:** ✅ PASS
-
-### 5.2 `team action='events'`
-- **Input:** events for a specific run
-- **Expected:** Chronological event log
-- **Actual:** 20+ events from run.created to task.failed with timestamps and metadata
-- **Result:** ✅ PASS
-
-### 5.3 `team action='artifacts'`
-- **Input:** artifacts for a specific run
-- **Expected:** List of artifact files
-- **Actual:** 14 artifacts listed (prompts, results, metadata, logs, shared)
-- **Result:** ✅ PASS
-
-### 5.4 `team action='summary'`
-- **Input:** summary of a specific run
-- **Expected:** Concise run overview
-- **Actual:** Full summary with status, goal, tasks, and usage
-- **Result:** ✅ PASS
-
-### 5.5 `team action='prune'`
-- **Input:** prune with keep=2, confirm=true
-- **Expected:** Old runs removed, 2 kept
-- **Actual:** 9 runs pruned, 2 kept. Audit trail written to prune.jsonl
-- **Result:** ✅ PASS
-
-### 5.6 `team action='worktrees'`
-- **Input:** worktrees without runId
-- **Expected:** Error or info message
-- **Actual:** Correctly required runId parameter
-- **Result:** ✅ PASS (proper validation)
-
----
-
-## Phase 6: Diagnostics
-
-### 6.1 `team action='doctor'`
-- **Input:** full diagnostics
-- **Expected:** All checks pass
-- **Actual:** 17/17 checks OK (runtime, filesystem, discovery, validation, drift, schema, async, worktrees)
-- **Result:** ✅ PASS
-
-### 6.2 `team action='validate'`
-- **Input:** validate all resources
-- **Expected:** 0 issues
-- **Actual:** 10 agents, 6 teams, 6 workflows, 0 issues
-- **Result:** ✅ PASS
-
-### 6.3 `team action='help'`
-- **Input:** show help
-- **Expected:** Command reference
-- **Actual:** Full command reference with core, inspection, maintenance, portability, diagnostics sections
-- **Result:** ✅ PASS
-
----
-
-## Phase 7: Portability
-
-### 7.1 `team action='export'`
-- **Input:** export a completed run
-- **Expected:** JSON + Markdown export files
-- **Actual:** Both run-export.json and run-export.md created in artifacts
-- **Result:** ✅ PASS
-
-### 7.2 `team action='import'`
-- **Input:** import exported run bundle
-- **Expected:** Run imported with summary
-- **Actual:** Bundle imported to .crew/imports/ with README.md summary
-- **Result:** ✅ PASS
-
----
-
-## Phase 8: Configuration
-
-### 8.1 `team action='settings'`
-- **Input:** show effective settings
-- **Expected:** Full config display
-- **Actual:** Complete settings with agent overrides, UI config, autonomous mode
-- **Result:** ✅ PASS
-
-### 8.2 `team action='autonomy'`
-- **Input:** show autonomy profile
-- **Expected:** Current autonomy state
-- **Actual:** Profile=suggested, enabled=true, inject policy=true
-- **Result:** ✅ PASS
-
----
-
-## Critical Findings
-
-### 🚨 Issue 1: Background Child-Process Workers Silent
-- **Severity:** HIGH
-- **Symptom:** All background child-process workers (both Agent and team async runs) spawn successfully but produce zero output, leading to 300s heartbeat timeout.
-- **Affected:** Agent(run_in_background=true), crew_agent(run_in_background=true), team async runs
-- **Evidence:** 
-  - 4 background agents → all returned empty
-  - Implementation team async → 01_assess heartbeat dead
-  - Background log contains only: `[pi-crew] background loader=jiti`
-- **Root Cause Analysis (CONFIRMED):**
-  - `pi --print "say hi"` hangs indefinitely even when run directly from shell
-  - `timeout 10 pi --print "say hi"` → exits code 124 (timeout) — **100% reproducible**
-  - Pi CLI starts (prints `[context-mode] WARNING`) but blocks on provider/model connection
-  - **THIS IS NOT A PI-CREW BUG** — it's a provider connectivity issue
-  - Live-session works because it reuses the parent Pi's already-established provider connection
-  - Child-process workers start a NEW Pi instance which cannot connect to the model provider
-  - **Possible causes:** API key not inherited by child env, network/firewall issue, provider rate limiting, or model endpoint unreachable
-
-### ⚠️ Issue 2: Live-Session Runs Prematurely Cancelled
-- **Severity:** MEDIUM
-- **Symptom:** fast-fix live-session run completed explore phase but was cancelled before execute
-- **Affected:** team action='run' with live-session runtime
-- **Note:** May be related to session concurrency limits or user-initiated cancellation
-
-### ✅ Stable Features
-- Resource discovery (list, get, recommend)
-- Diagnostics (doctor, validate, help)
-- State inspection (status, events, artifacts, summary)
-- Portability (export, import)
-- Maintenance (prune, cancel)
-- Configuration (settings, autonomy)
-- Planning (plan action)
-
----
-
-## Recommendations
-
-1. **Debug child-process background workers:** Add verbose logging to background.log at jiti loader level. Check if the child Pi process receives the prompt correctly.
-2. **Add heartbeat grace period:** Consider a configurable heartbeat timeout (currently fixed at 300s).
-3. **Test live-session workflow end-to-end:** Run a foreground team to completion to verify full workflow lifecycle.

package/docs/archive/pi-crew-test-round2.md

@@ -1,136 +0,0 @@
-# pi-crew v0.2.20 — Integration Test Round 2 (Post-Restart)
-
-**Date:** 2026-05-19 (Round 2)  
-**Context:** Pi restarted, async notifier fix applied  
-
----
-
-## Summary
-
-| Category | Tests | Pass | Fail | Notes |
-|---|---|---|---|---|
-| Discovery & Diagnostics | 5 | ✅ 5 | 0 | doctor, validate, list, settings, recommend |
-| Planning | 1 | ✅ 1 | 0 | plan action |
-| State Management | 4 | ✅ 4 | 0 | events, artifacts, export, summary |
-| Portability | 2 | ✅ 2 | 0 | import, imports |
-| Configuration | 2 | ✅ 2 | 0 | autonomy, help |
-| Foreground Team (fast-fix) | 1 | ⚠️ 0 | 0 | Bug #6 reproducible: cancelled after explore |
-| Background Subagents | 2 | 0 | ❌ 2 | pid_dead after 72s |
-| Async Team Run | 1 | ✅ 1 | 0 | Research team: 2 parallel tasks spawned, alive! |
-| Cancel + Retry | 2 | ✅ 2 | 0 | cancel + retry work |
-| Prune | 1 | ✅ 1 | 0 | 6 runs pruned |
-| **Total** | **21** | **18** | **2** | **1 partial** |
-
----
-
-## Detailed Results
-
-### ✅ Phase 1: Discovery & Diagnostics — 5/5 PASS
-
-| Test | Result | Notes |
-|---|---|---|
-| `team doctor` | ✅ PASS | 17/17 checks OK |
-| `team validate` | ✅ PASS | 10 agents, 6 teams, 6 workflows, 0 issues |
-| `team list` | ✅ PASS | All resources enumerated |
-| `team settings` | ✅ PASS | Full config displayed |
-| `team recommend` | ✅ PASS | Correctly suggested implementation for "implement health check" |
-
-### ✅ Phase 2: Planning — 1/1 PASS
-
-| Test | Result | Notes |
-|---|---|---|
-| `team plan` (default) | ✅ PASS | 4 steps: explore→plan→execute→verify |
-
-### ⚠️ Phase 3: Foreground Team (fast-fix) — Bug #6 Reproduced
-
-| Test | Result | Notes |
-|---|---|---|
-| fast-fix live-session | ⚠️ PARTIAL | explore ✅ completed, then run cancelled with "caller_cancelled" |
-
-**Bug #6 confirmed reproducible:**
-- Explore task completed successfully (32s)
-- Run immediately cancelled: `"reason":{"code":"caller_cancelled","message":"This operation was aborted"}`
-- Execute and verify tasks never started
-- Same pattern as Round 1
-
-### ❌ Phase 4: Background Subagents — 2/2 FAIL
-
-| Test | Result | Notes |
-|---|---|---|
-| Agent(explorer) background | ❌ FAIL | "Stale run reconciled: PID does not exist; pid_dead" after 72s |
-| crew_agent(analyst) background | ❌ FAIL | Same: pid_dead after 72s |
-
-Different error from Round 1 (305s heartbeat). Now fails faster (72s) with pid_dead — child Pi process crashes.
-
-### ✅ Phase 5: Async Team Run — PASS
-
-| Test | Result | Notes |
-|---|---|---|
-| research team (async) | ✅ PASS | pid=71195 alive=true, 2 parallel tasks running (explorer + analyst) |
-
-**Key finding:** Async team runs DO work now! Background process spawned successfully and ran parallel tasks.
-
-### ✅ Phase 6: Cancel + Retry — 2/2 PASS
-
-| Test | Result | Notes |
-|---|---|---|
-| `team cancel` | ✅ PASS | Run cancelled, background runner detected interrupt |
-| `team retry` | ✅ PASS | 3 tasks re-queued for retry |
-
-### ✅ Phase 7: State + Portability — 4/4 PASS
-
-| Test | Result | Notes |
-|---|---|---|
-| `team events` | ✅ PASS | Full event log with timestamps |
-| `team artifacts` | ✅ PASS | 14 artifacts listed |
-| `team export` | ✅ PASS | JSON + Markdown exported |
-| `team import` | ✅ PASS | Bundle imported with README.md |
-
-### ✅ Phase 8: Config + Cleanup — 2/2 PASS
-
-| Test | Result | Notes |
-|---|---|---|
-| `team autonomy` | ✅ PASS | Profile=suggested, enabled |
-| `team prune` | ✅ PASS | 6 runs removed, 3 kept |
-
----
-
-## Bugs Found
-
-### Bug #6: Foreground team run cancelled after first task — REPRODUCED
-
-**Pattern:** Fast-fix live-session: explore completes → run immediately cancelled with "caller_cancelled"
-
-Evidence:
-```
-07:40:55.273Z live-session.prompt_done 01_explore (elapsedMs=32119)
-07:40:55.276Z live_agent.terminated 01_explore status=cancelled
-07:40:55.300Z workflow.phase_completed: explore completed
-07:40:55.304Z run.cancelled: "This operation was aborted"
-         reason: {"code":"caller_cancelled","message":"This operation was aborted"}
-```
-
-This happened twice (Round 1 and Round 2) — **100% reproducible** with fast-fix team.
-
-**Hypothesis:** The live-session runtime detects something after explore completes and aborts the run. Possibly:
-1. Agent output length is 0 (`"outputLength":0`) despite task completing → triggers "no output" abort
-2. Pi's session lifecycle cancels the continuation after the first live-agent terminates
-3. `foregroundControllers` or session cleanup aborts the next phase
-
-### Background subagent failures — Different from Round 1
-
-Round 1: 305s timeout (429 rate limit)
-Round 2: 72s pid_dead (process crash)
-
-Rate limit seems resolved, but child Pi process now **crashes** instead of hanging. Need to check child Pi stderr for crash details.
-
----
-
-## Improvement from Round 1
-
-| Aspect | Round 1 | Round 2 | Change |
-|---|---|---|---|
-| Async team runs | ❌ heartbeat dead (300s) | ✅ alive, parallel tasks running | **Fixed** |
-| Background agents | ❌ heartbeat dead (305s) | ❌ pid_dead (72s) | Faster failure, different cause |
-| Foreground teams | ⚠️ cancelled | ⚠️ cancelled (same pattern) | No change |
-| Async notifier | ❌ dies on stale ctx | (not tested yet) | Fix applied |

package/docs/archive/pi-crew-test-round4.md

@@ -1,100 +0,0 @@
-# pi-crew v0.2.20 — Round 4 Test Results
-**Date:** 2026-05-19
-**Session:** After Bug #10 (API key filtering) and Bug #11 (spawn pi ENOENT) fixes applied
-**Environment:** linux/x64, Node v22.22.0, Pi CLI v0.75.3, pi-crew v0.2.20
-
----
-
-## Tests Performed
-
-### Test 1: Foreground fast-fix team — VERIFY ✅
-**Command:** `team action='run', team='fast-fix'`
-**Goal:** Quick verification test after fixes
-
-**Result:** ✅ PASS — 3/3 phases completed
-- Phase 1 (explore): completed
-- Phase 2 (execute): completed  
-- Phase 3 (verify): completed
-- Final status: `run.completed`
-
-**Duration:** ~4 minutes
-
-**Observation:** Foreground fast-fix team works correctly after Bug #10 and #11 fixes. The fixes did NOT break foreground execution.
-
----
-
-### Test 2: Foreground default/implementation team — BLOCKED ⚠️
-**Command:** `team action='run', team='default', workflow='implementation'`
-**Goal:** Full comprehensive test with adaptive planning
-
-**Result:** ⚠️ BLOCKED — `adaptive.plan_repair_failed`, `run.blocked`
-- Planner (01_assess) completed successfully
-- Planner produced a work item plan
-- Adaptive plan repair failed → `run.blocked`
-- Final events: `run.blocked`, `live_agent.terminated`
-
-**Root cause of block:** The adaptive planning system tried to repair a missing/invalid plan but couldn't. This is a **workflow design issue**, not a code bug in the fixes applied. The implementation workflow expects the planner to produce a valid JSON plan in a specific format, and when that format is slightly off, the repair mechanism fails.
-
-**Not a regression:** This same workflow has been blocking in previous rounds. It's related to how the planner agent generates plans for the implementation workflow.
-
----
-
-## Bug Fix Verification Summary
-
-### Bug #10 (MINIMAX_API_KEY filtered) — ✅ Fix Applied
-- **File changed:** `src/runtime/child-pi.ts`
-- **Fix:** Added allow-list to `sanitizeEnvSecrets()` to preserve model provider API keys
-- **Verification:** Foreground works (uses parent env with API key intact). Background async cannot be fully verified until Pi restart due to Bug #11.
-
-### Bug #11 (spawn pi ENOENT) — ✅ Fix Applied  
-- **File changed:** `src/runtime/pi-spawn.ts`
-- **Fix:** Added `resolvePiCliScript()` call for non-Windows platforms in `getPiSpawnCommand()`
-- **Verification:** Foreground teams work because they don't need `getPiSpawnCommand()` (live-session uses same session). Background async cannot be fully verified until Pi restart.
-
----
-
-## Current Bug Status (11 bugs total)
-
-| # | Bug | Status |
-|---|---|---|
-| 1 | Background workers timeout (MiniMax 429) | ✅ Fixed |
-| 2 | child-pi.ts doesn't detect 429 | ✅ Fixed |
-| 3 | background.log useless | ✅ Fixed |
-| 4 | worker-startup.ts missing rate_limited classification | ✅ Fixed |
-| 5 | Stale heartbeat notifications after prune | ✅ Fixed |
-| 6 | Live-session cancelled by concurrent tool calls | ✅ Confirmed (no code fix needed) |
-| 7 | Async notifier "stale ctx" dies | ✅ Fixed |
-| 8/10 | Background child-process 300s timeout (MINIMAX_API_KEY filtered) | ✅ Fixed |
-| 9 | Executor hit yield limit | 🔲 Open |
-| 10 | MINIMAX_API_KEY filtered out of child env | ✅ Fixed |
-| 11 | Background runner "spawn pi ENOENT" | ✅ Fixed |
-
-**Summary:** 9/11 Fixed ✅, 1/11 Open 🔲, 1/11 Confirmed (workflow constraint) ✅
-
----
-
-## What Needs Pi Restart to Verify
-
-1. **Bug #10 fix (API key):** The fix is applied to `child-pi.ts` but Pi must restart to reload the extension. Before restart, background workers fail with `spawn pi ENOENT` (Bug #11) which masks whether Bug #10 is fixed.
-
-2. **Bug #11 fix (pi binary path):** The fix is applied to `pi-spawn.ts` but Pi must restart to reload. Before restart, background async runs fail with `spawn pi ENOENT` immediately.
-
-**After restart:** Run `team action='run', async=true, goal="test background worker"` and verify workers produce output within 60 seconds (not 300s timeout).
-
----
-
-## Key Findings This Round
-
-1. **Bug #10 root cause identified:** `sanitizeEnvSecrets()` uses deny-list that filters `*_API_KEY*` vars. `MINIMAX_API_KEY` matches `api_key` pattern → filtered out → child Pi has no API key → hangs silently.
-
-2. **Bug #11 root cause identified:** `getPiSpawnCommand()` returns bare `"pi"` on Linux/macOS (no PATH resolution), but Windows path resolution only. Detached background runner has minimal PATH → `pi` not found.
-
-3. **Foreground execution is solid:** Fast-fix team (3 phases) completed successfully. Management features (doctor, validate, list, get, plan, settings) all verified working.
-
-4. **Two separate failure modes for background workers:**
-   - OLD (Bug #10): Workers spawn, run 5 min, timeout → This is the API key issue
-   - NEW (Bug #11, current session only): Background runner can't find `pi` → `spawn pi ENOENT` immediately
-
----
-
-**Next step:** Restart Pi to reload fixes, then run background async test.

package/docs/archive/pi-crew-test-round5.md

@@ -1,70 +0,0 @@
-# pi-crew v0.2.20 — Round 5 Test Results
-**Date:** 2026-05-19
-**Session:** After Pi restart, testing Bug #10/#11 fixes
-**Environment:** linux/x64, Node v22.22.0, Pi CLI v0.75.3, pi-crew v0.2.20
-
----
-
-## Test Results
-
-### Test 1: Background async research team — FAIL ❌
-
-**Command:** `team action='run', async=true, team='research'`
-**Goal:** Verify Bug #10 (#8) and Bug #11 fixes for background workers
-
-**Result:** ❌ FAIL — Child Pi workers crash immediately
-
-**Error observed:**
-```
-Error: Failed to run npm root -g: undefined
-    at DefaultPackageManager.runNpmCommandSync
-    at DefaultPackageManager.getGlobalNpmRoot
-    at DefaultPackageManager.getNpmInstallPath
-```
-
-**Root cause identified:** Bug #12 — The fix for Bug #10 accidentally stripped out essential env vars!
-
-`buildChildPiSpawnOptions()` uses `sanitizeEnvSecrets(env, { allowList: [model API keys] })`. In allow-list mode, ONLY keys matching the allow-list are kept. All other keys (PATH, HOME, USER, etc.) are stripped.
-
-→ The child Pi process has no PATH → cannot find npm → crashes immediately
-
-**Workers spawned successfully (Bug #11 verified ✅):**
-- `worker.spawned: pid=339071, pid=339077` — spawn OK
-- `getPiSpawnCommand()` now resolves full path ✅
-
-**But crashed (Bug #12 introduced ❌):**
-- `worker.exit: exitCode=1` — child exited with error
-- `task.failed` immediately after spawn
-
----
-
-## Bugs Fixed This Round
-
-### Bug #11: "spawn pi ENOENT" — ✅ Verified Fixed
-- `getPiSpawnCommand()` now resolves full path on Linux/macOS
-- Workers spawn successfully with real PIDs
-
-### Bug #12: Essential env vars stripped (NEW — introduced by Bug #10 fix)
-- Root cause: allow-list mode strips all non-matching keys
-- Fix: added essential env vars to allow-list (PATH, HOME, USER, etc.)
-
----
-
-## Current Bug Status (12 bugs total)
-
-| # | Bug | Status |
-|---|---|---|
-| 1-7 | Various | ✅ Fixed |
-| 8/10 | Background timeout (API key filtered) | ✅ Fixed |
-| 9 | Executor hit yield limit | 🔲 Open |
-| 10 | MINIMAX_API_KEY filtered | ✅ Fixed |
-| 11 | Background runner "spawn pi ENOENT" | ✅ Fixed |
-| 12 | Essential env vars stripped | ✅ Fixed (pending Pi restart) |
-
----
-
-## Next Step
-
-**Restart Pi** to reload with the Bug #12 fix. Then test:
-1. Background async team — verify workers produce output within 60s (not 300s timeout)
-2. Foreground fast-fix team — verify all phases complete