pi-crew 0.9.50 → 0.9.52

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (609) hide show
  1. package/CHANGELOG.md +150 -0
  2. package/README.md +216 -20
  3. package/dist/build-meta.json +2222 -1761
  4. package/dist/index.mjs +18636 -17603
  5. package/docs/actions-reference.md +431 -1
  6. package/package.json +19 -9
  7. package/schema.json +41 -0
  8. package/scripts/check-bundle-size.mjs +38 -0
  9. package/scripts/test-runner.mjs +11 -1
  10. package/skills/distill-software/SKILL.md +24 -1
  11. package/dist/index.mjs.map +0 -7
  12. package/docs/FEATURE_INTAKE.md +0 -126
  13. package/docs/HARNESS.md +0 -87
  14. package/docs/HARNESS_BACKLOG.md +0 -89
  15. package/docs/PROJECT_REVIEW.md +0 -270
  16. package/docs/PROJECT_REVIEW_FIXES.md +0 -342
  17. package/docs/PROJECT_REVIEW_ROUND4.md +0 -156
  18. package/docs/PROJECT_REVIEW_ROUND5.md +0 -86
  19. package/docs/REVIEW-FINDINGS-2026-06 +0 -357
  20. package/docs/REVIEW-FINDINGS-2026-07-CORE.md +0 -139
  21. package/docs/REVIEW-FINDINGS-2026-07.md +0 -125
  22. package/docs/TEST_MATRIX.md +0 -51
  23. package/docs/archive/README.md +0 -91
  24. package/docs/archive/followup-review-round3-2026-05-12.md +0 -342
  25. package/docs/archive/followup-review-round4-2026-05-13.md +0 -107
  26. package/docs/archive/pi-crew-bugs.md +0 -961
  27. package/docs/archive/pi-crew-test-final.md +0 -120
  28. package/docs/archive/pi-crew-test-results.md +0 -260
  29. package/docs/archive/pi-crew-test-round2.md +0 -136
  30. package/docs/archive/pi-crew-test-round4.md +0 -100
  31. package/docs/archive/pi-crew-test-round5.md +0 -70
  32. package/docs/archive/pi-crew-test-round6.md +0 -110
  33. package/docs/archive/pi-crew-v0.5.10-audit-fix-plan.md +0 -60
  34. package/docs/archive/pi-crew-v0.5.11-audit-fix-plan.md +0 -92
  35. package/docs/archive/pi-crew-v0.5.12-audit-fix-plan.md +0 -76
  36. package/docs/archive/pi-crew-v0.5.13-audit-fix-plan.md +0 -75
  37. package/docs/archive/pi-crew-v0.5.14-audit-fix-plan.md +0 -75
  38. package/docs/archive/pi-crew-v0.5.16-audit-fix-plan.md +0 -35
  39. package/docs/archive/pi-crew-v0.5.17-audit-fix-plan.md +0 -80
  40. package/docs/archive/pi-crew-v0.5.5-audit-fix-plan.md +0 -133
  41. package/docs/archive/pi-crew-v0.5.9-audit-fix-plan.md +0 -88
  42. package/docs/archive/pi-mono-opportunities.md +0 -969
  43. package/docs/archive/pi-mono-review.md +0 -291
  44. package/docs/archive/pi-subagent4-comparison.md +0 -261
  45. package/docs/archive/pi-subagents3-deep-analysis.md +0 -508
  46. package/docs/bugs/bug-021-notification-badge-counter-misleading.md +0 -293
  47. package/docs/bugs/bug-023-chain-windows-path-resolution.md +0 -106
  48. package/docs/bugs/bug-quota-display-truncation.md +0 -223
  49. package/docs/bugs/cross-session-notification-leakage.md +0 -82
  50. package/docs/code-review-2026-05-11.md +0 -592
  51. package/docs/coding-agent-optimization.md +0 -268
  52. package/docs/comparison-pi-subagents-vs-pi-crew.md +0 -303
  53. package/docs/decisions/0001-durable-state.md +0 -41
  54. package/docs/decisions/0002-child-process-for-async.md +0 -42
  55. package/docs/decisions/0003-depth-guard.md +0 -36
  56. package/docs/decisions/0004-execfile-over-exec.md +0 -34
  57. package/docs/decisions/0005-no-parameter-properties.md +0 -49
  58. package/docs/decisions/0006-publish-bundled-esm.md +0 -63
  59. package/docs/decisions/0007-active-run-binary-index.md +0 -54
  60. package/docs/decisions/0008-child-pi-warm-pool.md +0 -61
  61. package/docs/decisions/2026-07-21-broker-phase4-default-on.md +0 -77
  62. package/docs/decisions/2026-07-21-broker-windows-perms.md +0 -91
  63. package/docs/decisions/2026-07-22-broker-phase4-gated-on.md +0 -99
  64. package/docs/decisions/2026-07-24-oidc-trusted-publishing.md +0 -112
  65. package/docs/decisions/README.md +0 -26
  66. package/docs/deep-review-report.md +0 -384
  67. package/docs/distillation/cybersecurity-patterns.md +0 -294
  68. package/docs/feature-analysis-subagent4.md +0 -305
  69. package/docs/fix-plan-disabletools-exit-null.md +0 -219
  70. package/docs/fixes/BATCH_A_H1_H2.md +0 -86
  71. package/docs/fixes/bug-006-foreground-cancel-concurrent.md +0 -78
  72. package/docs/fixes/bug-007-async-notifier-stale-ctx.md +0 -112
  73. package/docs/fixes/bug-008-child-process-silent-timeout.md +0 -100
  74. package/docs/fixes/bug-009-executor-yield-limit-needs-attention.md +0 -75
  75. package/docs/fixes/bug-010-child-process-api-key-filtered.md +0 -109
  76. package/docs/fixes/bug-011-spawn-pi-enoent.md +0 -92
  77. package/docs/fixes/bug-012-essential-env-stripped.md +0 -89
  78. package/docs/fixes/bug-013-background-runner-death.md +0 -84
  79. package/docs/fixes/bug-014-infinite-retry-loop-needs-attention.md +0 -82
  80. package/docs/fixes/bug-015-background-runner-sigterm.md +0 -65
  81. package/docs/fixes/bug-017-background-runner-session-shutdown.md +0 -66
  82. package/docs/fixes/bug-017-background-runner-sigkill-double-fork.md +0 -28
  83. package/docs/fixes/bug-018-child-pi-worker-stdin-hang.md +0 -61
  84. package/docs/fixes/bug-019-phantom-runs-temp-workspace.md +0 -52
  85. package/docs/fixes/bug-020-infinite-retry-loop-needs-attention.md +0 -47
  86. package/docs/fixes/v0.9.10/locks-fix-verify.md +0 -3
  87. package/docs/fixes/v0.9.10/smoke-test.md +0 -12
  88. package/docs/followup-plan-2026-05-12.md +0 -463
  89. package/docs/followup-review-2026-05-12.md +0 -297
  90. package/docs/goals.md +0 -59
  91. package/docs/implementation-plan-top3.md +0 -333
  92. package/docs/issue-29-analysis.md +0 -189
  93. package/docs/live-mailbox-runtime.md +0 -36
  94. package/docs/migration/atomic-write-v2-migration.md +0 -299
  95. package/docs/next-upgrade-roadmap.md +0 -808
  96. package/docs/oh-my-pi-research.md +0 -509
  97. package/docs/optimization-plan-2026-07.md +0 -366
  98. package/docs/optimization-plan.md +0 -644
  99. package/docs/patterns/command-agent-skill.md +0 -71
  100. package/docs/perf/baseline-2026-05.md +0 -113
  101. package/docs/perf/final-report-2026-05.md +0 -206
  102. package/docs/perf/optimization-plan-2026-07-verified.md +0 -396
  103. package/docs/perf/performance-audit-report-2026-07.md +0 -948
  104. package/docs/perf/performance-review-2026-07.md +0 -287
  105. package/docs/perf/sprint-1-report.md +0 -71
  106. package/docs/perf/sprint-2-report.md +0 -81
  107. package/docs/perf/sprint-2.5-report.md +0 -53
  108. package/docs/perf/sprint-3-report.md +0 -36
  109. package/docs/perf/sprint-4-report.md +0 -47
  110. package/docs/perf/sprint-5-report.md +0 -51
  111. package/docs/perf/sprint-6-report.md +0 -94
  112. package/docs/perf/sprint-7-report.md +0 -74
  113. package/docs/perf/upgrade-plan-2026-05.md +0 -147
  114. package/docs/performance-optimization-execution-plan.md +0 -520
  115. package/docs/phase4-triage.md +0 -58
  116. package/docs/pi-crew-investigation-report.md +0 -411
  117. package/docs/product/README.md +0 -31
  118. package/docs/product/platform.md +0 -27
  119. package/docs/product/runtime-safety.md +0 -37
  120. package/docs/product/team-run.md +0 -39
  121. package/docs/product/team-tool.md +0 -37
  122. package/docs/runtime-analysis-child-vs-live.md +0 -171
  123. package/docs/runtime-migration-in-process-analysis.md +0 -250
  124. package/docs/skills/REFERENCE.md +0 -138
  125. package/docs/stories/README.md +0 -32
  126. package/docs/stories/US-DEPS-major-upgrade.md +0 -62
  127. package/docs/stories/backlog.md +0 -36
  128. package/docs/superpowers/plans/2026-06-09-fallow-patterns-adoption.md +0 -1270
  129. package/docs/templates/decision.md +0 -27
  130. package/docs/templates/story.md +0 -44
  131. package/docs/templates/validation-report.md +0 -32
  132. package/docs/ui-optimization-plan.md +0 -447
  133. package/src/adapters/claude-adapter.ts +0 -23
  134. package/src/adapters/codex-adapter.ts +0 -21
  135. package/src/adapters/cursor-adapter.ts +0 -17
  136. package/src/adapters/export-util.ts +0 -143
  137. package/src/adapters/index.ts +0 -15
  138. package/src/adapters/registry.ts +0 -18
  139. package/src/adapters/types.ts +0 -23
  140. package/src/agents/agent-config.ts +0 -194
  141. package/src/agents/agent-search.ts +0 -98
  142. package/src/agents/agent-serializer.ts +0 -38
  143. package/src/agents/discover-agents.ts +0 -623
  144. package/src/benchmark/benchmark-runner.ts +0 -313
  145. package/src/benchmark/feedback-loop.ts +0 -73
  146. package/src/config/config.ts +0 -1269
  147. package/src/config/defaults.ts +0 -193
  148. package/src/config/drift-detector.ts +0 -290
  149. package/src/config/markers.ts +0 -330
  150. package/src/config/resilient-parser.ts +0 -117
  151. package/src/config/role-tools.ts +0 -118
  152. package/src/config/suggestions.ts +0 -75
  153. package/src/config/types.ts +0 -278
  154. package/src/errors.ts +0 -194
  155. package/src/extension/action-suggestions.ts +0 -117
  156. package/src/extension/async-notifier.ts +0 -179
  157. package/src/extension/autonomous-policy.ts +0 -209
  158. package/src/extension/command-completions.ts +0 -120
  159. package/src/extension/context-status-injection.ts +0 -185
  160. package/src/extension/crew-autocomplete.ts +0 -131
  161. package/src/extension/crew-cleanup.ts +0 -168
  162. package/src/extension/crew-input-router.ts +0 -93
  163. package/src/extension/crew-shortcuts.ts +0 -87
  164. package/src/extension/crew-vibes/cat-frames.ts +0 -18
  165. package/src/extension/crew-vibes/config.ts +0 -195
  166. package/src/extension/crew-vibes/figures.ts +0 -101
  167. package/src/extension/crew-vibes/font-detect.ts +0 -71
  168. package/src/extension/crew-vibes/footer.ts +0 -292
  169. package/src/extension/crew-vibes/index.ts +0 -432
  170. package/src/extension/crew-vibes/provider-usage.ts +0 -396
  171. package/src/extension/crew-vibes/render.ts +0 -206
  172. package/src/extension/crew-vibes/speed.ts +0 -286
  173. package/src/extension/cross-extension-rpc.ts +0 -350
  174. package/src/extension/help.ts +0 -62
  175. package/src/extension/import-index.ts +0 -74
  176. package/src/extension/knowledge-injection.ts +0 -402
  177. package/src/extension/management.ts +0 -571
  178. package/src/extension/message-renderers.ts +0 -108
  179. package/src/extension/notification-router.ts +0 -152
  180. package/src/extension/notification-sink.ts +0 -54
  181. package/src/extension/pi-api.ts +0 -56
  182. package/src/extension/plan-orchestrate.ts +0 -302
  183. package/src/extension/project-init.ts +0 -170
  184. package/src/extension/register.ts +0 -113
  185. package/src/extension/registration/artifact-cleanup.ts +0 -20
  186. package/src/extension/registration/command-registration.ts +0 -58
  187. package/src/extension/registration/command-utils.ts +0 -58
  188. package/src/extension/registration/commands.ts +0 -1228
  189. package/src/extension/registration/compaction-guard.ts +0 -333
  190. package/src/extension/registration/context-builder.ts +0 -135
  191. package/src/extension/registration/crash-recovery-cache.ts +0 -54
  192. package/src/extension/registration/foreground-run-controller.ts +0 -238
  193. package/src/extension/registration/hook-registration.ts +0 -119
  194. package/src/extension/registration/lazy-configurers.ts +0 -124
  195. package/src/extension/registration/lifecycle-handlers.ts +0 -923
  196. package/src/extension/registration/lifecycle.ts +0 -259
  197. package/src/extension/registration/observability.ts +0 -322
  198. package/src/extension/registration/registration-types.ts +0 -158
  199. package/src/extension/registration/runtime-cleanup.ts +0 -230
  200. package/src/extension/registration/subagent-helpers.ts +0 -125
  201. package/src/extension/registration/subagent-manager-setup.ts +0 -330
  202. package/src/extension/registration/subagent-tools.ts +0 -456
  203. package/src/extension/registration/team-tool.ts +0 -220
  204. package/src/extension/registration/tool-registration.ts +0 -50
  205. package/src/extension/registration/ui.ts +0 -172
  206. package/src/extension/registration/viewers.ts +0 -121
  207. package/src/extension/registration/wire-cross-extension.ts +0 -37
  208. package/src/extension/result-watcher.ts +0 -139
  209. package/src/extension/rpc-hmac.ts +0 -256
  210. package/src/extension/run-bundle-schema.ts +0 -104
  211. package/src/extension/run-export.ts +0 -97
  212. package/src/extension/run-import.ts +0 -168
  213. package/src/extension/run-index.ts +0 -131
  214. package/src/extension/run-maintenance.ts +0 -190
  215. package/src/extension/session-summary.ts +0 -18
  216. package/src/extension/team-manager-command.ts +0 -153
  217. package/src/extension/team-onboard.ts +0 -177
  218. package/src/extension/team-recommendation.ts +0 -288
  219. package/src/extension/team-tool/anchor.ts +0 -172
  220. package/src/extension/team-tool/api.ts +0 -1244
  221. package/src/extension/team-tool/auto-summarize.ts +0 -142
  222. package/src/extension/team-tool/cache-control.ts +0 -19
  223. package/src/extension/team-tool/cancel.ts +0 -337
  224. package/src/extension/team-tool/chain-dispatch.ts +0 -95
  225. package/src/extension/team-tool/chain-executor.ts +0 -379
  226. package/src/extension/team-tool/config-patch.ts +0 -50
  227. package/src/extension/team-tool/context.ts +0 -149
  228. package/src/extension/team-tool/destructive-gate.ts +0 -52
  229. package/src/extension/team-tool/doctor.ts +0 -431
  230. package/src/extension/team-tool/explain.ts +0 -282
  231. package/src/extension/team-tool/failure-patterns.ts +0 -118
  232. package/src/extension/team-tool/goal-wrap.ts +0 -330
  233. package/src/extension/team-tool/goal.ts +0 -556
  234. package/src/extension/team-tool/handle-schedule.ts +0 -332
  235. package/src/extension/team-tool/handle-settings.ts +0 -520
  236. package/src/extension/team-tool/health-monitor.ts +0 -481
  237. package/src/extension/team-tool/inspect.ts +0 -88
  238. package/src/extension/team-tool/intent-policy.ts +0 -45
  239. package/src/extension/team-tool/lifecycle-actions.ts +0 -615
  240. package/src/extension/team-tool/orchestrate.ts +0 -98
  241. package/src/extension/team-tool/parallel-dispatch.ts +0 -183
  242. package/src/extension/team-tool/plan.ts +0 -50
  243. package/src/extension/team-tool/respond.ts +0 -150
  244. package/src/extension/team-tool/run-not-found.ts +0 -49
  245. package/src/extension/team-tool/run.ts +0 -1035
  246. package/src/extension/team-tool/status.ts +0 -260
  247. package/src/extension/team-tool/workflow-manage.ts +0 -261
  248. package/src/extension/team-tool-types.ts +0 -26
  249. package/src/extension/team-tool.ts +0 -1116
  250. package/src/extension/tool-result.ts +0 -16
  251. package/src/extension/validate-resources.ts +0 -108
  252. package/src/hooks/registry.ts +0 -200
  253. package/src/hooks/types.ts +0 -69
  254. package/src/i18n.ts +0 -212
  255. package/src/observability/correlation.ts +0 -50
  256. package/src/observability/event-bus.ts +0 -86
  257. package/src/observability/event-to-metric.ts +0 -170
  258. package/src/observability/exporters/adapter.ts +0 -27
  259. package/src/observability/exporters/otlp-exporter.ts +0 -356
  260. package/src/observability/exporters/prometheus-exporter.ts +0 -54
  261. package/src/observability/metric-registry.ts +0 -100
  262. package/src/observability/metric-retention.ts +0 -64
  263. package/src/observability/metric-sink.ts +0 -99
  264. package/src/observability/metrics-primitives.ts +0 -219
  265. package/src/plugins/plugin-define.ts +0 -6
  266. package/src/plugins/plugin-registry.ts +0 -32
  267. package/src/plugins/plugins/index.ts +0 -3
  268. package/src/plugins/plugins/nextjs.ts +0 -19
  269. package/src/plugins/plugins/vite.ts +0 -10
  270. package/src/plugins/plugins/vitest.ts +0 -9
  271. package/src/prompt/prompt-runtime.ts +0 -380
  272. package/src/runtime/adaptive-plan.ts +0 -563
  273. package/src/runtime/agent-control.ts +0 -215
  274. package/src/runtime/agent-memory.ts +0 -81
  275. package/src/runtime/agent-observability.ts +0 -122
  276. package/src/runtime/anchor-manager.ts +0 -475
  277. package/src/runtime/async-marker.ts +0 -32
  278. package/src/runtime/async-runner.ts +0 -381
  279. package/src/runtime/attention-events.ts +0 -28
  280. package/src/runtime/auto-summarize.ts +0 -344
  281. package/src/runtime/background-runner.ts +0 -837
  282. package/src/runtime/batch-barrier.ts +0 -147
  283. package/src/runtime/broker-issuer.ts +0 -37
  284. package/src/runtime/cancellation-token.ts +0 -99
  285. package/src/runtime/cancellation.ts +0 -99
  286. package/src/runtime/capability-inventory.ts +0 -137
  287. package/src/runtime/chain-parser.ts +0 -237
  288. package/src/runtime/chain-runner.ts +0 -606
  289. package/src/runtime/checkpoint.ts +0 -291
  290. package/src/runtime/child-pi-constants.ts +0 -42
  291. package/src/runtime/child-pi-kill.ts +0 -180
  292. package/src/runtime/child-pi-pool.ts +0 -68
  293. package/src/runtime/child-pi-spawn.ts +0 -287
  294. package/src/runtime/child-pi-steering.ts +0 -128
  295. package/src/runtime/child-pi-streams.ts +0 -296
  296. package/src/runtime/child-pi-transcript.ts +0 -169
  297. package/src/runtime/child-pi.ts +0 -1105
  298. package/src/runtime/coalesce-tasks.ts +0 -268
  299. package/src/runtime/code-summary.ts +0 -292
  300. package/src/runtime/command-trace.ts +0 -105
  301. package/src/runtime/compact-pipeline.ts +0 -56
  302. package/src/runtime/compact-stages/ansi-strip-stage.ts +0 -25
  303. package/src/runtime/compact-stages/blank-collapse-stage.ts +0 -31
  304. package/src/runtime/compact-stages/deduplicate-stage.ts +0 -34
  305. package/src/runtime/compact-stages/head-snap-stage.ts +0 -57
  306. package/src/runtime/compact-stages/index.ts +0 -23
  307. package/src/runtime/compact-stages/tail-capture-stage.ts +0 -77
  308. package/src/runtime/compact-stages/truncation-stage.ts +0 -74
  309. package/src/runtime/compaction-summary.ts +0 -278
  310. package/src/runtime/completion-guard.ts +0 -207
  311. package/src/runtime/concurrency.ts +0 -58
  312. package/src/runtime/crash-classification.ts +0 -229
  313. package/src/runtime/crash-recovery.ts +0 -577
  314. package/src/runtime/crew-agent-records.ts +0 -593
  315. package/src/runtime/crew-agent-runtime.ts +0 -62
  316. package/src/runtime/crew-broker-child.ts +0 -88
  317. package/src/runtime/crew-broker-client.ts +0 -673
  318. package/src/runtime/crew-broker-tokens.ts +0 -84
  319. package/src/runtime/crew-broker.ts +0 -1276
  320. package/src/runtime/crew-hooks.ts +0 -227
  321. package/src/runtime/cross-extension-rpc.ts +0 -143
  322. package/src/runtime/custom-tools/irc-tool.ts +0 -282
  323. package/src/runtime/custom-tools/submit-result-tool.ts +0 -102
  324. package/src/runtime/deadletter.ts +0 -47
  325. package/src/runtime/delivery-coordinator.ts +0 -211
  326. package/src/runtime/delta-conflict.ts +0 -348
  327. package/src/runtime/deterministic-ast.ts +0 -161
  328. package/src/runtime/diagnostic-export.ts +0 -171
  329. package/src/runtime/direct-run.ts +0 -45
  330. package/src/runtime/dwf-state-store.ts +0 -102
  331. package/src/runtime/dynamic-workflow-context.ts +0 -1016
  332. package/src/runtime/dynamic-workflow-runner.ts +0 -310
  333. package/src/runtime/effectiveness.ts +0 -90
  334. package/src/runtime/errors/crew-errors.ts +0 -162
  335. package/src/runtime/event-stream-bridge.ts +0 -98
  336. package/src/runtime/foreground-control.ts +0 -193
  337. package/src/runtime/foreground-watchdog.ts +0 -132
  338. package/src/runtime/global-worker-cap.ts +0 -96
  339. package/src/runtime/goal-achievement.ts +0 -148
  340. package/src/runtime/goal-evaluator.ts +0 -361
  341. package/src/runtime/goal-loop-runner.ts +0 -828
  342. package/src/runtime/goal-state-store.ts +0 -219
  343. package/src/runtime/green-contract.ts +0 -55
  344. package/src/runtime/group-join.ts +0 -267
  345. package/src/runtime/handoff-manager.ts +0 -598
  346. package/src/runtime/heartbeat-gradient.ts +0 -36
  347. package/src/runtime/heartbeat-watcher.ts +0 -239
  348. package/src/runtime/hidden-handoff.ts +0 -407
  349. package/src/runtime/important-line-classifier.ts +0 -140
  350. package/src/runtime/intercom-bridge.ts +0 -187
  351. package/src/runtime/iteration-hooks.ts +0 -305
  352. package/src/runtime/live-agent-control.ts +0 -136
  353. package/src/runtime/live-agent-manager.ts +0 -704
  354. package/src/runtime/live-control-realtime.ts +0 -56
  355. package/src/runtime/live-extension-bridge.ts +0 -148
  356. package/src/runtime/live-irc.ts +0 -97
  357. package/src/runtime/live-session-health.ts +0 -108
  358. package/src/runtime/live-session-runtime.ts +0 -1139
  359. package/src/runtime/loop-gates.ts +0 -128
  360. package/src/runtime/manifest-cache.ts +0 -375
  361. package/src/runtime/mcp-proxy.ts +0 -105
  362. package/src/runtime/metric-parser.ts +0 -36
  363. package/src/runtime/model-fallback.ts +0 -409
  364. package/src/runtime/model-resolver.ts +0 -126
  365. package/src/runtime/model-scope.ts +0 -158
  366. package/src/runtime/orphan-worker-registry.ts +0 -465
  367. package/src/runtime/output-validator.ts +0 -202
  368. package/src/runtime/overflow-recovery.ts +0 -206
  369. package/src/runtime/parallel-research.ts +0 -68
  370. package/src/runtime/parallel-utils.ts +0 -160
  371. package/src/runtime/parent-guard.ts +0 -134
  372. package/src/runtime/path-overlap.ts +0 -150
  373. package/src/runtime/peer-dep.ts +0 -292
  374. package/src/runtime/per-write-validator.ts +0 -181
  375. package/src/runtime/phase-progress.ts +0 -217
  376. package/src/runtime/phase-tracker.ts +0 -385
  377. package/src/runtime/pi-args.ts +0 -655
  378. package/src/runtime/pi-json-output.ts +0 -170
  379. package/src/runtime/pi-spawn.ts +0 -273
  380. package/src/runtime/pipeline-runner.ts +0 -523
  381. package/src/runtime/plan-templates.ts +0 -201
  382. package/src/runtime/policy-engine.ts +0 -115
  383. package/src/runtime/post-checks.ts +0 -142
  384. package/src/runtime/post-exit-stdio-guard.ts +0 -104
  385. package/src/runtime/process-lifecycle.ts +0 -491
  386. package/src/runtime/process-status.ts +0 -154
  387. package/src/runtime/progress-event-coalescer.ts +0 -44
  388. package/src/runtime/progress-tracker.ts +0 -124
  389. package/src/runtime/prose-compressor.ts +0 -162
  390. package/src/runtime/recovery-recipes.ts +0 -203
  391. package/src/runtime/replace.ts +0 -570
  392. package/src/runtime/resilient-edit.ts +0 -153
  393. package/src/runtime/result-extractor.ts +0 -213
  394. package/src/runtime/retry-executor.ts +0 -100
  395. package/src/runtime/retry-runner.ts +0 -336
  396. package/src/runtime/role-permission.ts +0 -59
  397. package/src/runtime/run-coalesced-task-group.ts +0 -308
  398. package/src/runtime/run-drift.ts +0 -219
  399. package/src/runtime/run-tracker.ts +0 -116
  400. package/src/runtime/runtime-policy.ts +0 -29
  401. package/src/runtime/runtime-resolver.ts +0 -172
  402. package/src/runtime/runtime-warmup.ts +0 -160
  403. package/src/runtime/scheduler.ts +0 -353
  404. package/src/runtime/semaphore.ts +0 -141
  405. package/src/runtime/sensitive-paths.ts +0 -93
  406. package/src/runtime/session-resources.ts +0 -25
  407. package/src/runtime/session-snapshot.ts +0 -59
  408. package/src/runtime/session-usage.ts +0 -79
  409. package/src/runtime/settings-store.ts +0 -155
  410. package/src/runtime/sidechain-output.ts +0 -35
  411. package/src/runtime/single-agent-compose.ts +0 -84
  412. package/src/runtime/skill-effectiveness.ts +0 -524
  413. package/src/runtime/skill-instructions.ts +0 -391
  414. package/src/runtime/stale-reconciler.ts +0 -680
  415. package/src/runtime/stream-preview.ts +0 -184
  416. package/src/runtime/streaming-output.ts +0 -50
  417. package/src/runtime/subagent-manager.ts +0 -561
  418. package/src/runtime/subprocess-tool-registry.ts +0 -70
  419. package/src/runtime/supervisor-contact.ts +0 -64
  420. package/src/runtime/task-display.ts +0 -52
  421. package/src/runtime/task-graph-scheduler.ts +0 -227
  422. package/src/runtime/task-graph.ts +0 -290
  423. package/src/runtime/task-health.ts +0 -83
  424. package/src/runtime/task-id.ts +0 -161
  425. package/src/runtime/task-output-context.ts +0 -602
  426. package/src/runtime/task-packet.ts +0 -268
  427. package/src/runtime/task-quality.ts +0 -199
  428. package/src/runtime/task-runner/capabilities.ts +0 -78
  429. package/src/runtime/task-runner/context-retrieval.ts +0 -163
  430. package/src/runtime/task-runner/live-executor.ts +0 -227
  431. package/src/runtime/task-runner/output-splitter.ts +0 -152
  432. package/src/runtime/task-runner/progress.ts +0 -157
  433. package/src/runtime/task-runner/prompt-builder.ts +0 -278
  434. package/src/runtime/task-runner/prompt-pipeline.ts +0 -88
  435. package/src/runtime/task-runner/result-utils.ts +0 -16
  436. package/src/runtime/task-runner/retrieval-orchestrator.ts +0 -310
  437. package/src/runtime/task-runner/run-projection.ts +0 -125
  438. package/src/runtime/task-runner/state-helpers.ts +0 -176
  439. package/src/runtime/task-runner/tail-read.ts +0 -34
  440. package/src/runtime/task-runner.ts +0 -1420
  441. package/src/runtime/team-runner-artifacts.ts +0 -13
  442. package/src/runtime/team-runner.ts +0 -1993
  443. package/src/runtime/tool-output-pruner.ts +0 -333
  444. package/src/runtime/tool-progress.ts +0 -278
  445. package/src/runtime/usage-tracker.ts +0 -73
  446. package/src/runtime/verification-gates.ts +0 -571
  447. package/src/runtime/verification-integrity.ts +0 -105
  448. package/src/runtime/verification-worktree.ts +0 -186
  449. package/src/runtime/worker-heartbeat.ts +0 -25
  450. package/src/runtime/worker-startup.ts +0 -83
  451. package/src/runtime/workflow-state.ts +0 -195
  452. package/src/runtime/workspace-lock.ts +0 -443
  453. package/src/runtime/workspace-tree.ts +0 -312
  454. package/src/runtime/yield-handler.ts +0 -224
  455. package/src/runtime/zombie-scanner.ts +0 -298
  456. package/src/schema/config-schema.ts +0 -327
  457. package/src/schema/team-tool-schema.ts +0 -415
  458. package/src/schema/validation-types.ts +0 -159
  459. package/src/skills/discover-skills.ts +0 -197
  460. package/src/skills/skill-templates.ts +0 -456
  461. package/src/skills/validate.ts +0 -285
  462. package/src/state/active-run-registry.ts +0 -439
  463. package/src/state/artifact-store.ts +0 -176
  464. package/src/state/atomic-write.ts +0 -903
  465. package/src/state/blob-store.ts +0 -308
  466. package/src/state/contracts.ts +0 -158
  467. package/src/state/crew-init.ts +0 -269
  468. package/src/state/decision-ledger.ts +0 -345
  469. package/src/state/event-log-rotation.ts +0 -342
  470. package/src/state/event-log.ts +0 -1311
  471. package/src/state/event-reconstructor.ts +0 -229
  472. package/src/state/gitignore-manager.ts +0 -46
  473. package/src/state/health-store.ts +0 -79
  474. package/src/state/hook-instinct-bridge.ts +0 -94
  475. package/src/state/hook-integrations.ts +0 -51
  476. package/src/state/instinct-store.ts +0 -275
  477. package/src/state/jsonl-writer.ts +0 -107
  478. package/src/state/locks.ts +0 -562
  479. package/src/state/mailbox.ts +0 -916
  480. package/src/state/observation-store.ts +0 -176
  481. package/src/state/run-cache.ts +0 -193
  482. package/src/state/run-graph.ts +0 -183
  483. package/src/state/run-metrics.ts +0 -165
  484. package/src/state/schedule.ts +0 -166
  485. package/src/state/session-state-map.ts +0 -51
  486. package/src/state/state-store.ts +0 -958
  487. package/src/state/task-claims.ts +0 -61
  488. package/src/state/tiered-eval.ts +0 -480
  489. package/src/state/types-eval.ts +0 -58
  490. package/src/state/types.ts +0 -440
  491. package/src/state/usage.ts +0 -138
  492. package/src/state/worker-atomic-writer.ts +0 -194
  493. package/src/subagents/async-entry.ts +0 -1
  494. package/src/subagents/index.ts +0 -3
  495. package/src/subagents/live/control.ts +0 -1
  496. package/src/subagents/live/manager.ts +0 -1
  497. package/src/subagents/live/realtime.ts +0 -1
  498. package/src/subagents/live/session-runtime.ts +0 -1
  499. package/src/subagents/manager.ts +0 -1
  500. package/src/subagents/spawn.ts +0 -1
  501. package/src/teams/discover-teams.ts +0 -187
  502. package/src/teams/team-config.ts +0 -27
  503. package/src/teams/team-serializer.ts +0 -38
  504. package/src/tools/safe-bash-extension.ts +0 -54
  505. package/src/tools/safe-bash.ts +0 -505
  506. package/src/types/diff.d.ts +0 -18
  507. package/src/types/new-api-types.ts +0 -35
  508. package/src/ui/agent-management-overlay.ts +0 -160
  509. package/src/ui/card-colors.ts +0 -139
  510. package/src/ui/crew-footer.ts +0 -102
  511. package/src/ui/crew-select-list.ts +0 -111
  512. package/src/ui/dashboard-panes/agents-pane.ts +0 -164
  513. package/src/ui/dashboard-panes/cancellation-pane.ts +0 -66
  514. package/src/ui/dashboard-panes/capability-pane.ts +0 -77
  515. package/src/ui/dashboard-panes/health-pane.ts +0 -31
  516. package/src/ui/dashboard-panes/mailbox-pane.ts +0 -35
  517. package/src/ui/dashboard-panes/metrics-pane.ts +0 -37
  518. package/src/ui/dashboard-panes/progress-pane.ts +0 -38
  519. package/src/ui/dashboard-panes/transcript-pane.ts +0 -10
  520. package/src/ui/deploy-bundled-themes.ts +0 -71
  521. package/src/ui/dwf-phase-display.ts +0 -151
  522. package/src/ui/dynamic-border.ts +0 -35
  523. package/src/ui/heartbeat-aggregator.ts +0 -74
  524. package/src/ui/key-utils.ts +0 -42
  525. package/src/ui/keybinding-map.ts +0 -248
  526. package/src/ui/layout-primitives.ts +0 -106
  527. package/src/ui/live-conversation-overlay.ts +0 -183
  528. package/src/ui/live-duration.ts +0 -55
  529. package/src/ui/live-run-sidebar.ts +0 -301
  530. package/src/ui/loaders.ts +0 -176
  531. package/src/ui/mascot.ts +0 -436
  532. package/src/ui/overlays/agent-picker-overlay.ts +0 -65
  533. package/src/ui/overlays/confirm-overlay.ts +0 -60
  534. package/src/ui/overlays/help-overlay.ts +0 -177
  535. package/src/ui/overlays/mailbox-compose-overlay.ts +0 -181
  536. package/src/ui/overlays/mailbox-compose-preview.ts +0 -78
  537. package/src/ui/overlays/mailbox-detail-overlay.ts +0 -154
  538. package/src/ui/pi-ui-compat.ts +0 -68
  539. package/src/ui/powerbar-publisher.ts +0 -459
  540. package/src/ui/render-coalescer.ts +0 -101
  541. package/src/ui/render-diff.ts +0 -160
  542. package/src/ui/render-scheduler.ts +0 -224
  543. package/src/ui/run-action-dispatcher.ts +0 -182
  544. package/src/ui/run-dashboard.ts +0 -913
  545. package/src/ui/run-event-bus.ts +0 -381
  546. package/src/ui/run-snapshot-cache.ts +0 -1057
  547. package/src/ui/settings-overlay.ts +0 -1067
  548. package/src/ui/snapshot-types.ts +0 -90
  549. package/src/ui/spinner.ts +0 -17
  550. package/src/ui/status-colors.ts +0 -143
  551. package/src/ui/syntax-highlight.ts +0 -136
  552. package/src/ui/terminal-status.ts +0 -269
  553. package/src/ui/theme-adapter.ts +0 -271
  554. package/src/ui/theme-discovery.ts +0 -199
  555. package/src/ui/tool-progress-formatter.ts +0 -93
  556. package/src/ui/tool-render.ts +0 -453
  557. package/src/ui/tool-renderers/brief-mode.ts +0 -225
  558. package/src/ui/tool-renderers/index.ts +0 -726
  559. package/src/ui/transcript-cache.ts +0 -128
  560. package/src/ui/transcript-entries.ts +0 -256
  561. package/src/ui/transcript-viewer.ts +0 -424
  562. package/src/ui/widget/index.ts +0 -357
  563. package/src/ui/widget/widget-formatters.ts +0 -182
  564. package/src/ui/widget/widget-model.ts +0 -110
  565. package/src/ui/widget/widget-renderer.ts +0 -182
  566. package/src/ui/widget/widget-types.ts +0 -36
  567. package/src/utils/bm25-search.ts +0 -235
  568. package/src/utils/completion-dedupe.ts +0 -63
  569. package/src/utils/conflict-detect.ts +0 -668
  570. package/src/utils/env-allowlist.ts +0 -30
  571. package/src/utils/env-filter.ts +0 -155
  572. package/src/utils/file-coalescer.ts +0 -98
  573. package/src/utils/fingerprint.ts +0 -180
  574. package/src/utils/frontmatter.ts +0 -70
  575. package/src/utils/fs-watch.ts +0 -37
  576. package/src/utils/gh-protocol.ts +0 -556
  577. package/src/utils/git.ts +0 -260
  578. package/src/utils/guards.ts +0 -107
  579. package/src/utils/ids.ts +0 -24
  580. package/src/utils/incremental-reader.ts +0 -220
  581. package/src/utils/internal-error.ts +0 -10
  582. package/src/utils/names.ts +0 -36
  583. package/src/utils/ndjson.ts +0 -115
  584. package/src/utils/paths.ts +0 -227
  585. package/src/utils/project-detector.ts +0 -160
  586. package/src/utils/redaction.ts +0 -347
  587. package/src/utils/resolve-shell.ts +0 -36
  588. package/src/utils/run-watcher-registry.ts +0 -152
  589. package/src/utils/safe-paths.ts +0 -383
  590. package/src/utils/scan-cache.ts +0 -144
  591. package/src/utils/session-utils.ts +0 -110
  592. package/src/utils/sleep.ts +0 -54
  593. package/src/utils/socket-path.ts +0 -127
  594. package/src/utils/sse-parser.ts +0 -129
  595. package/src/utils/task-name-generator.ts +0 -337
  596. package/src/utils/timings.ts +0 -33
  597. package/src/utils/token-counter.ts +0 -200
  598. package/src/utils/visual.ts +0 -207
  599. package/src/workflows/cost-estimator.ts +0 -34
  600. package/src/workflows/discover-workflows.ts +0 -290
  601. package/src/workflows/intermediate-store.ts +0 -166
  602. package/src/workflows/preflight-validator.ts +0 -168
  603. package/src/workflows/topology-analyzer.ts +0 -203
  604. package/src/workflows/validate-workflow.ts +0 -50
  605. package/src/workflows/workflow-config.ts +0 -70
  606. package/src/workflows/workflow-serializer.ts +0 -32
  607. package/src/worktree/branch-freshness.ts +0 -112
  608. package/src/worktree/cleanup.ts +0 -341
  609. package/src/worktree/worktree-manager.ts +0 -1200
@@ -1,1420 +0,0 @@
1
- import * as fs from "node:fs";
2
- import * as path from "node:path";
3
- import type { AgentConfig } from "../agents/agent-config.ts";
4
- import type { CrewLimitsConfig, CrewRuntimeConfig } from "../config/config.ts";
5
- import { loadConfig } from "../config/config.ts";
6
- import { errors } from "../errors.ts";
7
- import { appendHookEvent, executeHook } from "../hooks/registry.ts";
8
- import { writeArtifact } from "../state/artifact-store.ts";
9
- import { appendEventAsync, appendEventBuffered, appendEventFireAndForget } from "../state/event-log.ts";
10
- import { withRunLock } from "../state/locks.ts";
11
- import { saveRunManifestAsync } from "../state/state-store.ts";
12
- import { createTaskClaim } from "../state/task-claims.ts";
13
- import type {
14
- ArtifactDescriptor,
15
- OperationTerminalEvidence,
16
- TeamRunManifest,
17
- TeamTaskState,
18
- VerificationEvidence,
19
- } from "../state/types.ts";
20
- import { logInternalError } from "../utils/internal-error.ts";
21
- import { resolveContainedPath, resolveRealContainedPath } from "../utils/safe-paths.ts";
22
- import type { WorkflowStep } from "../workflows/workflow-config.ts";
23
- import { captureWorktreeDiffAsync, captureWorktreeDiffStatAsync, prepareTaskWorkspaceAsync } from "../worktree/worktree-manager.ts";
24
- import { reserveControlChannel } from "./agent-control.ts";
25
- import { appendTaskAttentionEvent } from "./attention-events.ts";
26
- import { buildSyntheticTerminalEvidence, cancellationReasonFromSignal } from "./cancellation.ts";
27
- import { type ChildPiLifecycleEvent, runChildPi } from "./child-pi.ts";
28
- import { extractCommandTrace } from "./command-trace.ts";
29
- import { evaluateCompletionMutationGuard } from "./completion-guard.ts";
30
- import {
31
- appendCrewAgentEvent,
32
- appendCrewAgentOutput,
33
- emptyCrewAgentProgress,
34
- recordFromTask,
35
- upsertCrewAgent,
36
- } from "./crew-agent-records.ts";
37
- import type { CrewRuntimeKind } from "./crew-agent-runtime.ts";
38
- import { crewHooks } from "./crew-hooks.ts";
39
- import { bridgeEventFromJsonEvent, registerStreamBridge } from "./event-stream-bridge.ts";
40
- import { createVerificationEvidence } from "./green-contract.ts";
41
- import {
42
- buildConfiguredModelRouting,
43
- formatModelAttemptNote,
44
- isRetryableModelFailure,
45
- type ModelAttemptSummary,
46
- } from "./model-fallback.ts";
47
- import { readEnabledModelsPatterns } from "./model-scope.ts";
48
- import { type OutputValidationResult, validateWorkerOutput } from "./output-validator.ts";
49
- import { type ParsedPiJsonOutput, parsePiJsonOutput } from "./pi-json-output.ts";
50
- import { type ProgressEventSummary, shouldAppendProgressEventUpdate } from "./progress-event-coalescer.ts";
51
- import { permissionForRole } from "./role-permission.ts";
52
- import { awaitRuntimeWarmup } from "./runtime-warmup.ts";
53
- import { parseSessionUsage } from "./session-usage.ts";
54
- import { renderSkillInstructions } from "./skill-instructions.ts";
55
- import { parseSupervisorContactFromLine, recordSupervisorContact } from "./supervisor-contact.ts";
56
- import {
57
- collectDependencyOutputContext,
58
- renderDependencyOutputContext,
59
- writeTaskInputsArtifact,
60
- writeTaskSharedOutput,
61
- } from "./task-output-context.ts";
62
- import { buildTaskPacket } from "./task-packet.ts";
63
- import { buildWorkerCapabilityInventory } from "./task-runner/capabilities.ts";
64
- import { applyAgentProgressEvent, applyUsageToProgress, progressEventSummary, shouldFlushProgressEvent } from "./task-runner/progress.ts";
65
- import { coordinationBridgeInstructions, renderTaskPrompt } from "./task-runner/prompt-builder.ts";
66
- import { buildWorkerPromptPipeline } from "./task-runner/prompt-pipeline.ts";
67
- import { cleanResultText, isFinalChildEvent } from "./task-runner/result-utils.ts";
68
- import { checkpointTask, persistSingleTaskUpdate, updateTask } from "./task-runner/state-helpers.ts";
69
- import { tailReadWithLineSnap } from "./task-runner/tail-read.ts";
70
- import { computeGreenLevelFromResults, executeVerificationCommands } from "./verification-gates.ts";
71
- import { createWorkerHeartbeat, touchWorkerHeartbeat } from "./worker-heartbeat.ts";
72
- import { createStartupEvidence } from "./worker-startup.ts";
73
- import {
74
- DEFAULT_YIELD_CONFIG,
75
- extractYieldResult,
76
- hasYieldInOutput,
77
- isYieldEvent,
78
- registerYieldTool,
79
- type YieldResult,
80
- } from "./yield-handler.ts";
81
-
82
- // Register the submit_result tool handler so subprocess events can extract yield data.
83
- registerYieldTool();
84
-
85
- /** Async helper for writing steering events — fire-and-forget for non-blocking writes. */
86
- async function appendSteeringAsync(steeringDir: string, taskId: string, steers: string[]): Promise<void> {
87
- try {
88
- await fs.promises.mkdir(steeringDir, { recursive: true });
89
- const steeringPath = resolveContainedPath(steeringDir, `${taskId}.jsonl`);
90
- const lines = steers
91
- .map(
92
- (msg) =>
93
- JSON.stringify({
94
- type: "steer",
95
- message: msg,
96
- ts: new Date().toISOString(),
97
- }) + "\n",
98
- )
99
- .join("");
100
- await fs.promises.appendFile(steeringPath, lines, "utf-8");
101
- } catch (error) {
102
- logInternalError("task-runner.steering-write-failed", error as Error, `taskId=${taskId}`);
103
- }
104
- }
105
-
106
- /** Async helper for writing background logs — fire-and-forget for non-blocking writes. */
107
- async function appendBackgroundLogAsync(bgLogPath: string, eventLine: string): Promise<void> {
108
- try {
109
- await fs.promises.appendFile(bgLogPath, `${eventLine}\n`, "utf-8");
110
- } catch (error) {
111
- logInternalError("task-runner.background-log-write-failed", error as Error, `path=${bgLogPath}`);
112
- }
113
- }
114
-
115
- export interface TaskRunnerInput {
116
- manifest: TeamRunManifest;
117
- tasks: TeamTaskState[];
118
- task: TeamTaskState;
119
- step: WorkflowStep;
120
- agent: AgentConfig;
121
- signal?: AbortSignal;
122
- executeWorkers: boolean;
123
- runtimeKind?: CrewRuntimeKind;
124
- /** Per-role runtime override resolved from isolation policy. Takes precedence over runtimeKind. */
125
- taskRuntimeOverride?: CrewRuntimeKind;
126
- runtimeConfig?: CrewRuntimeConfig;
127
- parentContext?: string;
128
- parentModel?: unknown;
129
- modelRegistry?: unknown;
130
- modelOverride?: string;
131
- teamRoleModel?: string;
132
- teamRoleSkills?: string[] | false;
133
- skillOverride?: string[] | false;
134
- limits?: CrewLimitsConfig;
135
- dependencyContextText?: string;
136
- skillBlock?: string;
137
- skillNames?: string[];
138
- skillPaths?: string[];
139
- /** Workspace where this task run was initiated — used for session-scoped live-agent visibility. */
140
- workspaceId: string;
141
- /** Optional callback for JSON events from child Pi. Used for overflow recovery tracking. */
142
- onJsonEvent?: (taskId: string, runId: string, event: unknown) => void;
143
- }
144
-
145
- export async function runTeamTask(input: TaskRunnerInput): Promise<{ manifest: TeamRunManifest; tasks: TeamTaskState[] }> {
146
- // Cold-start race fix: ensure the hot module graph is warm before touching
147
- // any module. Under tsx, concurrent first-imports race module-record
148
- // instantiation; awaiting the registration-time warmup eliminates the window.
149
- await awaitRuntimeWarmup();
150
- let manifest = input.manifest;
151
- // H4: registerStreamBridge inside try so dispose() in finally is safe
152
- let streamBridge: ReturnType<typeof registerStreamBridge> | undefined;
153
- try {
154
- streamBridge = registerStreamBridge(manifest.runId);
155
- const workspace = await prepareTaskWorkspaceAsync(manifest, input.task, input.step.seedPaths);
156
- const worktree =
157
- workspace.worktreePath && workspace.branch
158
- ? {
159
- path: workspace.worktreePath,
160
- branch: workspace.branch,
161
- reused: workspace.reused ?? false,
162
- }
163
- : input.task.worktree;
164
- const taskPacket = buildTaskPacket({
165
- manifest,
166
- step: input.step,
167
- taskId: input.task.id,
168
- cwd: workspace.cwd,
169
- worktreePath: worktree?.path,
170
- });
171
- const dependencyContext = collectDependencyOutputContext(manifest, input.tasks, input.task, input.step);
172
- const dependencyContextText = input.dependencyContextText ?? renderDependencyOutputContext(dependencyContext);
173
- let task: TeamTaskState = {
174
- ...input.task,
175
- cwd: workspace.cwd,
176
- worktree,
177
- taskPacket,
178
- status: "running",
179
- startedAt: new Date().toISOString(),
180
- claim: createTaskClaim(`task-runner:${input.task.id}`),
181
- heartbeat: createWorkerHeartbeat(input.task.id),
182
- agentProgress: input.task.agentProgress ?? emptyCrewAgentProgress(),
183
- // Lifetime usage accumulator — survives compaction unlike session.stats
184
- lifetimeUsage: { input: 0, output: 0, cacheWrite: 0 },
185
- ...(dependencyContextText ? { dependencyContextText } : {}),
186
- // Reserve control channel before spawn so cancel/steer can target this task immediately
187
- controlReservation: reserveControlChannel(input.task.id, manifest.runId),
188
- } as TeamTaskState;
189
- let tasks = updateTask(input.tasks, task);
190
- const runtimeKind = input.taskRuntimeOverride ?? input.runtimeKind ?? (input.executeWorkers ? "child-process" : "scaffold");
191
- // A1-F7: Pre-compute whether yield-event collection is needed. For child-process
192
- // workers (the common case) this is always false, so we skip allocating/accumulating
193
- // collectedJsonEvents entirely — eliminating ~10KB memory waste per task.
194
- const collectYieldEvents = runtimeKind !== "child-process" && (input.runtimeConfig?.yield?.enabled ?? DEFAULT_YIELD_CONFIG.enabled);
195
- // FIX: Check signal before persisting state — if cancelled, skip the write.
196
- if (input.signal?.aborted) {
197
- const cancelReason = cancellationReasonFromSignal(input.signal);
198
- const cancelledTask: TeamTaskState = {
199
- ...task,
200
- status: "cancelled",
201
- error: `${cancelReason.code}: ${cancelReason.message}`,
202
- finishedAt: new Date().toISOString(),
203
- };
204
- return {
205
- manifest: input.manifest,
206
- tasks: updateTask(tasks, cancelledTask),
207
- };
208
- }
209
- tasks = persistSingleTaskUpdate(manifest, tasks, task, "started");
210
- if (runtimeKind === "child-process") ({ task, tasks } = checkpointTask(manifest, tasks, task, "started"));
211
- upsertCrewAgent(manifest, recordFromTask(manifest, task, runtimeKind));
212
- await appendEventAsync(manifest.eventsPath, {
213
- type: "task.started",
214
- runId: manifest.runId,
215
- taskId: task.id,
216
- data: {
217
- role: task.role,
218
- agent: task.agent,
219
- runtime: runtimeKind,
220
- cwd: task.cwd,
221
- worktreePath: workspace.worktreePath,
222
- worktreeBranch: workspace.branch,
223
- worktreeReused: workspace.reused,
224
- },
225
- });
226
- // Emit immediate UI notification so widget shows agent as "running" within ~100ms
227
- // instead of waiting for child process first JSON event (2-5s delay).
228
- streamBridge?.handler({
229
- runId: manifest.runId,
230
- taskId: task.id,
231
- eventType: "task.started",
232
- timestamp: Date.now(),
233
- });
234
- const permissionMode = permissionForRole(task.role);
235
- const renderedSkills =
236
- input.skillBlock === undefined
237
- ? renderSkillInstructions({
238
- cwd: task.cwd,
239
- role: task.role,
240
- agent: input.agent,
241
- teamRole: { skills: input.teamRoleSkills },
242
- step: input.step,
243
- override: input.skillOverride,
244
- runId: manifest.runId,
245
- })
246
- : undefined;
247
- const skillBlock = input.skillBlock ?? renderedSkills?.block;
248
- const skillNames = input.skillNames ?? renderedSkills?.names;
249
- const skillPaths = input.skillPaths ?? renderedSkills?.paths;
250
-
251
- // Deterministic pre-step: run script, inject stdout into worker prompt
252
- let preStepOutput: string | undefined;
253
- if (input.step.preStepScript) {
254
- const scriptTimeout = input.step.preStepTimeout ?? 30_000;
255
- const scriptArgs = input.step.preStepArgs ?? [];
256
- appendEventFireAndForget(manifest.eventsPath, {
257
- type: "hook.pre_step_started",
258
- runId: manifest.runId,
259
- taskId: task.id,
260
- data: { script: input.step.preStepScript, argCount: scriptArgs.length, timeoutMs: scriptTimeout },
261
- });
262
- // SECURITY (M-1 fix, code-review 2026-06-23): use the project's safe-path
263
- // primitive instead of a hand-rolled path.resolve + startsWith check.
264
- // The lexical check passed a symlinked ancestor, letting execFileSync
265
- // follow it and execute a script outside cwd. Throws on escape.
266
- // Keep validation outside the optional-execution catch: preStepOptional
267
- // must never bypass a path-containment failure.
268
- resolveRealContainedPath(manifest.cwd, input.step.preStepScript);
269
- try {
270
- // LAZY: defer dynamic import of node:child_process to its call site.
271
- const { execFileSync } = await import("node:child_process");
272
- preStepOutput = execFileSync(input.step.preStepScript, scriptArgs, {
273
- timeout: scriptTimeout,
274
- encoding: "utf-8",
275
- cwd: manifest.cwd,
276
- maxBuffer: 1024 * 1024, // 1MB cap
277
- });
278
- appendEventFireAndForget(manifest.eventsPath, {
279
- type: "hook.pre_step_completed",
280
- runId: manifest.runId,
281
- taskId: task.id,
282
- data: { script: input.step.preStepScript, outputBytes: Buffer.byteLength(preStepOutput, "utf8") },
283
- });
284
- } catch (err) {
285
- const msg = err instanceof Error ? err.message : String(err);
286
- const exitCode = (err as NodeJS.ErrnoException & { status?: number }).status;
287
- appendEventFireAndForget(manifest.eventsPath, {
288
- type: "hook.pre_step_failed",
289
- runId: manifest.runId,
290
- taskId: task.id,
291
- message: `pre-step hook failed (exit ${exitCode ?? "?"})`,
292
- data: { script: input.step.preStepScript, exitCode: exitCode ?? null, optional: input.step.preStepOptional === true },
293
- });
294
- // E1 (Round 15): structured CrewError with code E009 + help hint,
295
- // instead of a raw Error. Surfaces the script path, exit code, and stderr.
296
- // Round 21 (E4): if preStepOptional is set, a failing hook is NON-FATAL.
297
- // Log a warning + emit a 'warning' event, then proceed without the
298
- // pre-step output rather than aborting the task (advisory hooks).
299
- if (input.step.preStepOptional) {
300
- const warnMsg = `[preStepOptional] pre-step hook '${input.step.preStepScript}' failed (exit ${exitCode ?? "?"}) but preStepOptional=true; continuing without its output.`;
301
- try {
302
- appendEventFireAndForget(manifest.eventsPath, {
303
- type: "hook.pre_step_optional_failed",
304
- runId: manifest.runId,
305
- taskId: task.id,
306
- message: warnMsg,
307
- data: {
308
- script: input.step.preStepScript,
309
- exitCode: exitCode ?? null,
310
- },
311
- });
312
- } catch {
313
- /* best-effort event log */
314
- }
315
- preStepOutput = undefined;
316
- } else {
317
- throw errors.preStepFailed(input.step.preStepScript, exitCode, msg);
318
- }
319
- }
320
- }
321
-
322
- const promptResult = await renderTaskPrompt(manifest, input.step, task, input.agent, skillBlock);
323
- let prompt = promptResult.full;
324
-
325
- // Inject deterministic pre-step output into prompt
326
- if (preStepOutput) {
327
- prompt +=
328
- "\n\n---\n## Pre-Step Script Output\n\nThe following data was produced by a pre-step script. Use it as context for your task:\n\n<output>\n" +
329
- preStepOutput +
330
- "\n</output>\n";
331
- }
332
- const promptArtifact = writeArtifact(manifest.artifactsRoot, {
333
- kind: "prompt",
334
- relativePath: `prompts/${task.id}.md`,
335
- content: `${prompt}\n`,
336
- producer: task.id,
337
- });
338
-
339
- let resultArtifact: ArtifactDescriptor;
340
- let logArtifact: ArtifactDescriptor | undefined;
341
- let transcriptArtifact: ArtifactDescriptor | undefined;
342
- let exitCode: number | null = 0;
343
- let error: string | undefined;
344
- let modelAttempts: ModelAttemptSummary[] | undefined;
345
- let parsedOutput: ParsedPiJsonOutput | undefined;
346
- let rawFinalText: string | undefined;
347
- let intermediateFindings: string | undefined;
348
- let finalStdout = "";
349
- let transcriptPath: string | undefined;
350
- let terminalEvidence: OperationTerminalEvidence[] = [];
351
- const collectedJsonEvents: Record<string, unknown>[] | undefined = collectYieldEvents ? [] : undefined;
352
-
353
- let startupEvidence = createStartupEvidence({
354
- command: runtimeKind === "child-process" ? "pi" : runtimeKind === "live-session" ? "live-session" : "safe-scaffold",
355
- startedAt: new Date(task.startedAt ?? new Date().toISOString()),
356
- finishedAt: new Date(),
357
- promptSentAt: new Date(task.startedAt ?? new Date().toISOString()),
358
- promptAccepted: true,
359
- exitCode: 0,
360
- });
361
- const inputsArtifact = writeTaskInputsArtifact(manifest, task, dependencyContext);
362
- const skillArtifact = skillBlock
363
- ? writeArtifact(manifest.artifactsRoot, {
364
- kind: "metadata",
365
- relativePath: `metadata/${task.id}.skills.md`,
366
- content: [
367
- `Selected skills: ${skillNames?.join(", ") ?? "(none)"}`,
368
- `Skill paths passed to child Pi: ${(skillPaths ?? []).length}`,
369
- "",
370
- skillBlock,
371
- "",
372
- ].join("\n"),
373
- producer: task.id,
374
- })
375
- : undefined;
376
- const coordinationArtifact = writeArtifact(manifest.artifactsRoot, {
377
- kind: "metadata",
378
- relativePath: `metadata/${task.id}.coordination-bridge.md`,
379
- content: `${coordinationBridgeInstructions(task)}\n`,
380
- producer: task.id,
381
- });
382
- if (runtimeKind === "child-process") {
383
- const modelRoutingPlan = buildConfiguredModelRouting({
384
- overrideModel: input.modelOverride,
385
- stepModel: input.step.model,
386
- teamRoleModel: input.teamRoleModel,
387
- agentModel: input.agent.model,
388
- fallbackModels: input.agent.fallbackModels,
389
- parentModel: input.parentModel,
390
- modelRegistry: input.modelRegistry,
391
- cwd: task.cwd,
392
- scopeModelsPatterns: await resolveTaskScopeModelsPatterns(task.cwd),
393
- });
394
- const candidates = modelRoutingPlan.candidates;
395
- const attemptModels = candidates.length > 0 ? candidates : [undefined];
396
- const logs: string[] = [];
397
- let finalStderr = "";
398
- modelAttempts = [];
399
- let finalCheckpointWritten = false;
400
- let lastAgentRecordPersistedAt = 0;
401
- let lastHeartbeatPersistedAt = 0;
402
- let lastRunProgressPersistedAt = 0;
403
- let lastTaskProgressPersistedAt = 0;
404
- let lastRunProgressSummary: ProgressEventSummary | undefined;
405
- const persistHeartbeat = (force = false): void => {
406
- const now = Date.now();
407
- // Skip disk write if throttled (unless forced).
408
- if (!force && now - lastHeartbeatPersistedAt < 1000) return;
409
- try {
410
- // Write to disk first, then update in-memory.
411
- // Disk state is always <= in-memory state, so a crash never produces
412
- // a fresher in-memory heartbeat than what's on disk. This prevents the
413
- // stale reconciler from seeing a live heartbeat paired with stale task state
414
- // (which could cause false zombie detection).
415
- tasks = persistSingleTaskUpdate(manifest, tasks, task);
416
- } catch (err) {
417
- // Run state may have been deleted by prune/forget/cleanup.
418
- // This is not fatal — the run is gone, no point persisting.
419
- if ((err as NodeJS.ErrnoException).code === "ENOENT") return;
420
- throw err;
421
- }
422
- // Now update in-memory heartbeat so it is always >= persisted state.
423
- task = {
424
- ...task,
425
- heartbeat: touchWorkerHeartbeat(task.heartbeat ?? createWorkerHeartbeat(task.id)),
426
- };
427
- lastHeartbeatPersistedAt = now;
428
- };
429
- const persistChildProgress = (event: unknown, force = false): void => {
430
- const now = Date.now();
431
- if (force || shouldFlushProgressEvent(event) || now - lastAgentRecordPersistedAt >= 500) {
432
- upsertCrewAgent(manifest, recordFromTask(manifest, task, "child-process"));
433
- lastAgentRecordPersistedAt = now;
434
- }
435
- const summary = progressEventSummary(task, event);
436
- const decision = shouldAppendProgressEventUpdate({
437
- previous: lastRunProgressSummary,
438
- next: summary,
439
- nowMs: now,
440
- lastAppendMs: lastRunProgressPersistedAt || undefined,
441
- minIntervalMs: 1000,
442
- force,
443
- });
444
- if (decision.shouldAppend) {
445
- // 2.2 caller migration: high-frequency task.progress goes through
446
- // the buffered path (M7 wire); loss-on-kill is acceptable because progress
447
- // is informational and re-derivable from per-agent records.
448
- // appendEventBuffered coalesces into a single lock acquire after bufferMs,
449
- // reducing producer p95 from ~13µs (serial) to ~0µs (bench M7).
450
- void appendEventBuffered(manifest.eventsPath, {
451
- type: "task.progress",
452
- runId: manifest.runId,
453
- taskId: task.id,
454
- data: { ...summary, coalesceReason: decision.reason },
455
- });
456
- lastRunProgressSummary = summary;
457
- lastRunProgressPersistedAt = now;
458
- }
459
- };
460
- for (let i = 0; i < attemptModels.length; i++) {
461
- // M1 fix: set transcript path per attempt to avoid mixing across fallback attempts.
462
- transcriptPath = `${manifest.artifactsRoot}/transcripts/${task.id}.attempt-${i}.jsonl`;
463
- // Ensure transcripts/ subdirectory exists before child-pi appends
464
- // to it. appendTranscript uses O_APPEND (no mkdir) for security,
465
- // so the caller must create the directory.
466
- await fs.promises.mkdir(path.join(manifest.artifactsRoot, "transcripts"), {
467
- recursive: true,
468
- });
469
- const model = attemptModels[i];
470
- const attemptStartedAt = new Date();
471
- const pendingAttempt: ModelAttemptSummary = {
472
- model: model ?? "default",
473
- success: false,
474
- };
475
- task = {
476
- ...task,
477
- modelAttempts: [...modelAttempts, pendingAttempt],
478
- };
479
- tasks = updateTask(tasks, task);
480
- crewHooks.emit({
481
- type: "task_started",
482
- timestamp: new Date().toISOString(),
483
- runId: manifest.runId,
484
- taskId: task.id,
485
- data: { role: task.role, model: model ?? "default" },
486
- });
487
- upsertCrewAgent(manifest, recordFromTask(manifest, task, "child-process"));
488
- // W2 fix — wall-clock timeout per task. We create our own
489
- // AbortController, link the caller's signal to it, and abort
490
- // from a timer. The internal signal is passed to runChildPi so
491
- // the existing SIGTERM → SIGKILL escalation in child-pi.ts
492
- // handles cleanup. Prevents runaway agent loops (e.g. 11_build
493
- // in the oh-my-pi distill run that re-verified completed files
494
- // 14+ times).
495
- const taskTimeoutMs = input.runtimeConfig?.taskTimeoutMs ?? 0;
496
- const timeoutController = new AbortController();
497
- // W2 fix (memory leak) — store the listener reference so we can
498
- // removeEventListener() it in the finally block below. { once: true }
499
- // alone is NOT enough: when the timeout fires first, the listener
500
- // never fires → { once: true } never auto-removes → listener stays
501
- // attached to input.signal for the rest of the run (run-level
502
- // signal = long-lived → leak accumulates per task run).
503
- let externalAbortListener: (() => void) | undefined;
504
- if (input.signal) {
505
- if (input.signal.aborted) {
506
- timeoutController.abort(input.signal.reason);
507
- } else {
508
- externalAbortListener = () => timeoutController.abort(input.signal!.reason);
509
- input.signal.addEventListener("abort", externalAbortListener, { once: true });
510
- }
511
- }
512
- let timeoutHandle: ReturnType<typeof setTimeout> | undefined;
513
- if (taskTimeoutMs > 0 && !timeoutController.signal.aborted) {
514
- timeoutHandle = setTimeout(() => {
515
- if (!timeoutController.signal.aborted) {
516
- timeoutController.abort(new Error(`Task exceeded wall-clock timeout of ${taskTimeoutMs}ms`));
517
- }
518
- }, taskTimeoutMs);
519
- timeoutHandle.unref?.();
520
- }
521
- let childResult;
522
- try {
523
- childResult = await runChildPi({
524
- cwd: task.cwd,
525
- task: prompt,
526
- agent: input.agent,
527
- model,
528
- signal: timeoutController.signal,
529
- transcriptPath,
530
- maxDepth: input.limits?.maxTaskDepth,
531
- skillPaths,
532
- maxTurns: input.runtimeConfig?.maxTurns,
533
- graceTurns: input.runtimeConfig?.graceTurns,
534
- inheritContext: input.runtimeConfig?.inheritContext,
535
- parentContext: input.parentContext,
536
- excludeContextBash: input.runtimeConfig?.excludeContextBash,
537
- sessionId: manifest.sessionId,
538
- role: task.role,
539
- runId: manifest.runId,
540
- agentId: task.id,
541
- artifactsRoot: manifest.artifactsRoot,
542
- steeringFile: resolveContainedPath(`${manifest.artifactsRoot}/steering`, `${task.id}.jsonl`),
543
- onSpawn: (pid) => {
544
- try {
545
- ({ task, tasks } = checkpointTask(manifest, tasks, task, "child-spawned", pid));
546
- if (task.pendingSteers?.length) {
547
- const steeringDir = `${manifest.artifactsRoot}/steering`;
548
- // Fire-and-forget async write for steering events
549
- void appendSteeringAsync(steeringDir, task.id, task.pendingSteers);
550
- task.pendingSteers = [];
551
- tasks = persistSingleTaskUpdate(manifest, tasks, task);
552
- }
553
- } catch (err) {
554
- logInternalError("task-runner.on-spawn", err as Error, `pid=${pid}, taskId=${task.id}`);
555
- }
556
- },
557
- onLifecycleEvent: (event: ChildPiLifecycleEvent) => {
558
- void appendEventAsync(manifest.eventsPath, {
559
- type: `worker.${event.type}` as const,
560
- runId: manifest.runId,
561
- taskId: task.id,
562
- message: `Worker lifecycle: ${event.type}${event.error ? ` error=${event.error}` : ""}${event.exitCode != null ? ` exit=${event.exitCode}` : ""}`,
563
- data: { ...event },
564
- }).catch((error) =>
565
- logInternalError("task-runner.lifecycle-event", error, `taskId=${task.id}, type=${event.type}`),
566
- );
567
- },
568
- onStdoutLine: (line) => {
569
- appendCrewAgentOutput(manifest, task.id, line);
570
- persistHeartbeat();
571
- // Check for supervisor contact requests from child Pi
572
- const contact = parseSupervisorContactFromLine(line);
573
- if (contact) {
574
- recordSupervisorContact(manifest, {
575
- runId: manifest.runId,
576
- ...contact,
577
- });
578
- }
579
- },
580
- onJsonEvent: (event) => {
581
- // Top-level error boundary: prevent any single event from crashing the task.
582
- // Errors are logged but processing continues so subsequent events still update state.
583
- try {
584
- appendCrewAgentEvent(manifest, task.id, event);
585
- if (collectedJsonEvents && event && typeof event === "object" && !Array.isArray(event))
586
- collectedJsonEvents.push(event as Record<string, unknown>);
587
- if (collectedJsonEvents && collectedJsonEvents.length > 1000) {
588
- collectedJsonEvents.splice(0, collectedJsonEvents.length - 1000);
589
- }
590
- // Accumulate lifetime usage via message_end events (survives compaction)
591
- if (event && typeof event === "object" && (event as Record<string, unknown>).type === "message_end") {
592
- const msg = (event as Record<string, unknown>).message as Record<string, unknown> | undefined;
593
- if (msg?.role === "assistant") {
594
- const usage = msg.usage as Record<string, number> | undefined;
595
- if (usage) {
596
- task.lifetimeUsage = {
597
- input: (task.lifetimeUsage?.input ?? 0) + (usage.input ?? 0),
598
- output: (task.lifetimeUsage?.output ?? 0) + (usage.output ?? 0),
599
- cacheWrite: (task.lifetimeUsage?.cacheWrite ?? 0) + (usage.cacheWrite ?? 0),
600
- };
601
- }
602
- }
603
- }
604
- persistHeartbeat();
605
- // Bug #3 fix: Write worker JSON events to background.log for debugging when running in background mode.
606
- // This supplements the event log so developers can see what the child Pi worker produced.
607
- if (process.env.PI_CREW_BACKGROUND_MODE === "1" && event) {
608
- const bgLogPath = `${manifest.stateRoot}/background.log`;
609
- const eventLine =
610
- typeof event === "object" && !Array.isArray(event) ? JSON.stringify(event) : String(event);
611
- // Fire-and-forget async write for background log
612
- void appendBackgroundLogAsync(bgLogPath, eventLine);
613
- }
614
- // Always keep in-memory agentProgress fresh (cheap) so the UI/events see
615
- // the latest progress, but THROTTLE the disk persist. Previously this
616
- // did a full locked read-parse-write of tasks.json on EVERY child JSON
617
- // event — a 200-event task produced 200 such cycles (Round 15 P1).
618
- // Final state is force-flushed on task completion (persistHeartbeat(true)).
619
- const nextProgress = applyAgentProgressEvent(
620
- task.agentProgress ?? emptyCrewAgentProgress(),
621
- event,
622
- task.startedAt,
623
- );
624
- task = { ...task, agentProgress: nextProgress };
625
- tasks = updateTask(tasks, task);
626
- const progressNow = Date.now();
627
- if (progressNow - lastTaskProgressPersistedAt >= 500) {
628
- tasks = persistSingleTaskUpdate(manifest, tasks, task);
629
- lastTaskProgressPersistedAt = progressNow;
630
- }
631
- // Bridge event to UI event bus for near-instant updates
632
- const bridgeEvent = bridgeEventFromJsonEvent(manifest.runId, task.id, event);
633
- if (bridgeEvent) streamBridge?.handler(bridgeEvent);
634
- // Feed overflow recovery tracker
635
- if (input.onJsonEvent) {
636
- input.onJsonEvent(task.id, manifest.runId, event);
637
- }
638
- if (!finalCheckpointWritten && isFinalChildEvent(event)) {
639
- finalCheckpointWritten = true;
640
- ({ task, tasks } = checkpointTask(manifest, tasks, task, "child-stdout-final"));
641
- }
642
- persistChildProgress(event);
643
- } catch (err) {
644
- logInternalError("task-runner.on-json-event", err as Error, `taskId=${task.id}`);
645
- }
646
- },
647
- });
648
- } finally {
649
- if (timeoutHandle) clearTimeout(timeoutHandle);
650
- // W2 fix — release the listener so it doesn't leak. {once:true}
651
- // only auto-removes when the listener FIRES; if the timeout
652
- // fires first, the listener never fires and stays attached
653
- // to input.signal (run-level signal = long-lived → leak per
654
- // task). Remove explicitly here.
655
- if (externalAbortListener && input.signal) {
656
- input.signal.removeEventListener("abort", externalAbortListener);
657
- }
658
- }
659
- const evidenceStatus = childResult.exitStatus?.cancelled
660
- ? "cancelled"
661
- : childResult.error || (childResult.exitCode && childResult.exitCode !== 0)
662
- ? "failed"
663
- : "completed";
664
- terminalEvidence = [
665
- ...terminalEvidence,
666
- {
667
- operation: "worker",
668
- status: evidenceStatus,
669
- startedAt: attemptStartedAt.toISOString(),
670
- finishedAt: new Date().toISOString(),
671
- ...(input.signal?.aborted
672
- ? {
673
- reason: cancellationReasonFromSignal(input.signal),
674
- }
675
- : {}),
676
- ...(childResult.exitStatus ? { exitStatus: childResult.exitStatus } : {}),
677
- },
678
- ];
679
- if (evidenceStatus === "cancelled") {
680
- const cancelReason = input.signal?.aborted
681
- ? cancellationReasonFromSignal(input.signal)
682
- : {
683
- code: "caller_cancelled" as const,
684
- message: "Worker cancelled.",
685
- };
686
- terminalEvidence.push(buildSyntheticTerminalEvidence("tool", cancelReason, attemptStartedAt.toISOString()));
687
- await appendEventAsync(manifest.eventsPath, {
688
- type: "worker.cancelled",
689
- runId: manifest.runId,
690
- taskId: task.id,
691
- message: cancelReason.message,
692
- data: { terminalEvidence: terminalEvidence.at(-1) },
693
- });
694
- }
695
- startupEvidence = createStartupEvidence({
696
- command: "pi",
697
- startedAt: attemptStartedAt,
698
- finishedAt: new Date(),
699
- promptSentAt: attemptStartedAt,
700
- promptAccepted: childResult.exitCode === 0 && !childResult.error,
701
- stderr: childResult.stderr,
702
- error: childResult.error,
703
- exitCode: childResult.exitCode,
704
- });
705
- exitCode = childResult.exitCode;
706
- finalStdout = childResult.stdout;
707
- finalStderr = childResult.stderr;
708
- // Cap transcript read to MAX_TRANSCRIPT_BYTES to avoid OOM on huge transcripts.
709
- const MAX_TRANSCRIPT_PARSE_BYTES = 5 * 1024 * 1024;
710
- const transcriptText = tailReadWithLineSnap(transcriptPath, MAX_TRANSCRIPT_PARSE_BYTES, childResult.stdout);
711
- parsedOutput = parsePiJsonOutput(transcriptText);
712
- rawFinalText = childResult.rawFinalText;
713
- intermediateFindings = childResult.intermediateFindings;
714
- error =
715
- childResult.error ||
716
- (childResult.exitCode && childResult.exitCode !== 0
717
- ? childResult.stderr || `Child Pi exited with ${childResult.exitCode}`
718
- : undefined);
719
- // E1/E7 (Round 15): when the child timed out, surface a structured
720
- // CrewError (E007) so users get a code + actionable help hint instead
721
- // of a bare 'no new output for N ms'. We keep .message as the task error.
722
- if (childResult.exitStatus?.timedOut) {
723
- error = errors.childTimeout({
724
- taskId: task.id,
725
- stderr: childResult.stderr,
726
- }).message;
727
- }
728
- // 429/rate-limit fix (PI_CREW_TOOLING_429_NOTE.md): a worker can exit
729
- // code 0 with NO hard error, but the transcript is full of
730
- // `message_end` events with `errorMessage: "429 ... overloaded"` and
731
- // empty content. The model never produced a tool call, so the worker
732
- // "completed" without doing anything. Detect this: if no error was set
733
- // above AND the parsed output carries a retryable model-failure message
734
- // AND there is no real output text, surface it as an error so the
735
- // model-fallback chain can retry on another model.
736
- if (!error && parsedOutput) {
737
- const rateLimitErr = detectRetryableModelFailureFromOutput(parsedOutput);
738
- if (rateLimitErr) error = rateLimitErr;
739
- }
740
- persistHeartbeat(true);
741
- persistChildProgress({ type: "attempt_finished" }, true);
742
- const attempt: ModelAttemptSummary = {
743
- model: model ?? "default",
744
- success: !error,
745
- exitCode,
746
- error,
747
- };
748
- modelAttempts.push(attempt);
749
- task = { ...task, modelAttempts: [...modelAttempts] };
750
- tasks = updateTask(tasks, task);
751
- logs.push(
752
- `MODEL ATTEMPT ${i + 1}: ${attempt.model}`,
753
- `success=${attempt.success}`,
754
- `exitCode=${attempt.exitCode ?? "null"}`,
755
- attempt.error ? `error=${attempt.error}` : "",
756
- "",
757
- );
758
- if (!error) break;
759
- let nextModel = attemptModels[i + 1];
760
- // FIX 1 (task packet 01_01-agent): when the precomputed attempt
761
- // chain is exhausted but the failure is retryable, do a one-shot
762
- // re-resolve via buildConfiguredModelRouting with the failed
763
- // model as parent. This finds alternative providers/models the
764
- // original chain missed (e.g. a registry gained new fallbacks
765
- // after the precompute, or the precompute ran before the parent
766
- // model was known). If a different candidate is found, use it as
767
- // nextModel; otherwise fall through to the existing break.
768
- if (!nextModel && isRetryableModelFailure(error)) {
769
- const reResolved = buildConfiguredModelRouting({
770
- overrideModel: undefined,
771
- stepModel: undefined,
772
- teamRoleModel: undefined,
773
- agentModel: undefined,
774
- fallbackModels: undefined,
775
- parentModel: attempt.model,
776
- modelRegistry: input.modelRegistry,
777
- cwd: task.cwd,
778
- scopeModelsPatterns: await resolveTaskScopeModelsPatterns(task.cwd),
779
- });
780
- const alt = reResolved.candidates.find((c) => c !== attempt.model);
781
- if (alt) nextModel = alt;
782
- }
783
- if (!nextModel || !isRetryableModelFailure(error)) break;
784
- logs.push(formatModelAttemptNote(attempt, nextModel), "");
785
- }
786
- // E2 (Round 15): when the fallback chain was used and STILL failed, surface
787
- // that explicitly. Without this the task error only shows the last
788
- // attempt's raw failure, so users can't tell whether to fix an API key,
789
- // upgrade a plan, or change the model config. Include the chain tried +
790
- // the final reason.
791
- if (error && modelAttempts.length > 1) {
792
- // E2/E1 (Round 15): structured CrewError (E008). Build via the factory so
793
- // the error carries a code + help hint; keep its .message as the task error.
794
- error = errors.modelExhausted(
795
- modelAttempts.map((a) => a.model),
796
- error,
797
- ).message;
798
- }
799
- // NEW-8 fix: register all attempt transcripts as artifacts, not just the used one.
800
- // Earlier failed attempts' transcripts exist on disk but were invisible to the artifact system.
801
- const successfulAttemptIndex = modelAttempts.findIndex((attempt) => attempt.success);
802
- const usedAttempt = successfulAttemptIndex === -1 ? Math.max(0, modelAttempts.length - 1) : successfulAttemptIndex;
803
- for (let attemptIdx = 0; attemptIdx < modelAttempts.length; attemptIdx++) {
804
- if (attemptIdx === usedAttempt) continue;
805
- const tPath = `${manifest.artifactsRoot}/transcripts/${task.id}.attempt-${attemptIdx}.jsonl`;
806
- if (!fs.existsSync(tPath)) continue;
807
- const MAX_ATTEMPT_TRANSCRIPT = 5 * 1024 * 1024;
808
- const tContent = tailReadWithLineSnap(tPath, MAX_ATTEMPT_TRANSCRIPT, "");
809
- if (tContent) {
810
- writeArtifact(manifest.artifactsRoot, {
811
- kind: "log",
812
- relativePath: `transcripts/${task.id}.attempt-${attemptIdx}.jsonl`,
813
- content: tContent,
814
- producer: task.id,
815
- });
816
- }
817
- }
818
- resultArtifact = writeArtifact(manifest.artifactsRoot, {
819
- kind: "result",
820
- relativePath: `results/${task.id}.txt`,
821
- content:
822
- // Prefer the RAW (uncapped) final assistant text captured before the
823
- // transcript's 16K compaction — this is the authoritative worker output.
824
- // Fall back to transcript-derived finalText, then stdout/stderr, so a
825
- // missing raw capture (mock/error path) never yields empty/garbage.
826
- cleanResultText(rawFinalText) ??
827
- cleanResultText(parsedOutput?.finalText) ??
828
- cleanResultText(finalStdout) ??
829
- cleanResultText(finalStderr) ??
830
- // #7 hardening: if all real output paths are empty (worker exhausted
831
- // budget on tool calls, no assistant text), use intermediate findings.
832
- // intermediateFindings captures the last N tool-result display lines.
833
- cleanResultText(intermediateFindings) ??
834
- "(no output)",
835
- producer: task.id,
836
- });
837
- logArtifact = writeArtifact(manifest.artifactsRoot, {
838
- kind: "log",
839
- relativePath: `logs/${task.id}.log`,
840
- content: [
841
- ...logs,
842
- `finalExitCode=${exitCode ?? "null"}`,
843
- `jsonEvents=${parsedOutput?.jsonEvents ?? 0}`,
844
- parsedOutput?.usage ? `usage=${JSON.stringify(parsedOutput.usage)}` : "",
845
- "",
846
- "STDOUT:",
847
- finalStdout,
848
- "",
849
- "STDERR:",
850
- finalStderr,
851
- ].join("\n"),
852
- producer: task.id,
853
- });
854
- const resolvedModel = modelAttempts[usedAttempt]?.model ?? candidates[0] ?? "default";
855
- const fallbackReason = usedAttempt > 0 ? modelAttempts[usedAttempt - 1]?.error : undefined;
856
- task = {
857
- ...task,
858
- modelRouting: {
859
- requested: modelRoutingPlan.requested,
860
- resolved: resolvedModel,
861
- fallbackChain: candidates,
862
- reason: fallbackReason ?? modelRoutingPlan.reason,
863
- usedAttempt,
864
- },
865
- };
866
- tasks = updateTask(tasks, task);
867
- // Use the last attempt's transcript for session usage.
868
- // Safety net: transcriptPath may be undefined in edge cases (e.g., early exit before loop).
869
- // In practice it is always set inside the for loop above.
870
- const attemptFallback = `${manifest.artifactsRoot}/transcripts/${task.id}.attempt-${usedAttempt}.jsonl`;
871
- const sessionUsage = parseSessionUsage(transcriptPath ?? attemptFallback);
872
- const effectiveUsage = parsedOutput?.usage ?? sessionUsage;
873
- if (effectiveUsage) {
874
- parsedOutput = {
875
- ...(parsedOutput ?? { jsonEvents: 0, textEvents: [] }),
876
- usage: effectiveUsage,
877
- };
878
- task = {
879
- ...task,
880
- usage: effectiveUsage,
881
- agentProgress: applyUsageToProgress(task.agentProgress, effectiveUsage),
882
- };
883
- tasks = updateTask(tasks, task);
884
- upsertCrewAgent(manifest, recordFromTask(manifest, task, "child-process"));
885
- }
886
- // M2 fix: use attempt-relative path; cap content at MAX_TRANSCRIPT_ARTIFACT_BYTES.
887
- const MAX_TRANSCRIPT_ARTIFACT_BYTES = 5 * 1024 * 1024; // 5MB cap
888
- const attemptTranscriptPath = `${manifest.artifactsRoot}/transcripts/${task.id}.attempt-${usedAttempt}.jsonl`;
889
- const transcriptContent = tailReadWithLineSnap(attemptTranscriptPath, MAX_TRANSCRIPT_ARTIFACT_BYTES, "");
890
- if (transcriptContent) {
891
- transcriptArtifact = writeArtifact(manifest.artifactsRoot, {
892
- kind: "log",
893
- relativePath: `transcripts/${task.id}.attempt-${usedAttempt}.jsonl`,
894
- content: transcriptContent,
895
- producer: task.id,
896
- });
897
- }
898
- task = {
899
- ...task,
900
- resultArtifact,
901
- ...(logArtifact ? { logArtifact } : {}),
902
- ...(transcriptArtifact ? { transcriptArtifact } : {}),
903
- };
904
- tasks = updateTask(tasks, task);
905
- ({ task, tasks } = checkpointTask(manifest, tasks, task, "artifact-written"));
906
- } else if (runtimeKind === "live-session") {
907
- // LAZY: live-executor is only needed for live-session runtime branches.
908
- const { runLiveTask } = await import("./task-runner/live-executor.ts");
909
- const live = await runLiveTask({
910
- manifest,
911
- tasks,
912
- task,
913
- step: input.step,
914
- agent: input.agent,
915
- prompt,
916
- signal: input.signal,
917
- runtimeConfig: input.runtimeConfig,
918
- parentContext: input.parentContext,
919
- parentModel: input.parentModel,
920
- modelRegistry: input.modelRegistry,
921
- modelOverride: input.modelOverride,
922
- teamRoleModel: input.teamRoleModel,
923
- workspaceId: input.workspaceId,
924
- });
925
- task = live.task;
926
- tasks = live.tasks;
927
- startupEvidence = live.startupEvidence;
928
- exitCode = live.exitCode;
929
- error = live.error;
930
- parsedOutput = live.parsedOutput;
931
- // Bug #21 fix: live-session may not produce structured output via submit_result,
932
- // leaving finalText empty. Re-write resultArtifact with parsedOutput.finalText
933
- // so downstream tasks that depend on this task can read meaningful output.
934
- const liveText = cleanResultText(parsedOutput?.finalText);
935
- if (liveText) {
936
- // Re-write the artifact with the captured stdout — this is the content
937
- // downstream tasks will read via task.resultArtifact.path.
938
- resultArtifact = writeArtifact(manifest.artifactsRoot, {
939
- kind: "result",
940
- relativePath: `results/${task.id}.txt`,
941
- content: liveText,
942
- producer: task.id,
943
- });
944
- } else {
945
- resultArtifact = live.resultArtifact;
946
- }
947
- // Sync task.resultArtifact with the re-written artifact (if liveText was truthy)
948
- task = { ...task, resultArtifact };
949
- logArtifact = live.logArtifact;
950
- transcriptArtifact = live.transcriptArtifact;
951
- } else {
952
- resultArtifact = writeArtifact(manifest.artifactsRoot, {
953
- kind: "result",
954
- relativePath: `results/${task.id}.md`,
955
- content: [
956
- `# ${task.id}`,
957
- "",
958
- "Worker execution is disabled in this scaffold-safe run.",
959
- "The prompt artifact contains the exact task that will be sent to a child Pi worker when execution is enabled.",
960
- ].join("\n"),
961
- producer: task.id,
962
- });
963
- }
964
-
965
- // --- Yield-based completion contract ---
966
- // _yieldResult: preserved for future use — yield completion contract not yet wired to task.result
967
- let _yieldResult: YieldResult | undefined;
968
- let noYield = false;
969
- // Child-process workers do not have a submit_result tool — the yield contract
970
- // only applies to live-session workers where submit_result is injected by the
971
- // runtime. Skipping yield detection for child-process prevents every child
972
- // worker from incorrectly being marked needs_attention.
973
- const yieldEnabled = collectYieldEvents;
974
- if (yieldEnabled && collectedJsonEvents && collectedJsonEvents.length > 0) {
975
- if (hasYieldInOutput(collectedJsonEvents)) {
976
- const yieldEvent = collectedJsonEvents.find((e) => isYieldEvent(e));
977
- if (yieldEvent) {
978
- _yieldResult = extractYieldResult(yieldEvent);
979
- }
980
- } else if (!error) {
981
- noYield = true;
982
- await appendEventAsync(manifest.eventsPath, {
983
- type: "task.needs_attention",
984
- runId: manifest.runId,
985
- taskId: task.id,
986
- message: "Worker completed without calling submit_result tool.",
987
- data: {
988
- activityState: "needs_attention",
989
- reason: "no_yield",
990
- // Bug #21 fix: include result path so downstream tasks can read the output
991
- resultPath: resultArtifact?.path,
992
- },
993
- });
994
- }
995
- }
996
-
997
- const diffArtifact = workspace.worktreePath
998
- ? writeArtifact(manifest.artifactsRoot, {
999
- kind: "diff",
1000
- relativePath: `diffs/${task.id}.diff`,
1001
- content: await captureWorktreeDiffAsync(workspace.worktreePath),
1002
- producer: task.id,
1003
- })
1004
- : undefined;
1005
- const diffStatArtifact = workspace.worktreePath
1006
- ? writeArtifact(manifest.artifactsRoot, {
1007
- kind: "metadata",
1008
- relativePath: `metadata/${task.id}.diff-stat.json`,
1009
- content: `${JSON.stringify({ ...(await captureWorktreeDiffStatAsync(workspace.worktreePath)), syntheticPaths: workspace.syntheticPaths ?? [], nodeModulesLinked: workspace.nodeModulesLinked ?? false }, null, 2)}\n`,
1010
- producer: task.id,
1011
- })
1012
- : undefined;
1013
-
1014
- // Capture unified patches from edit tool results
1015
- const patchArtifact = parsedOutput?.patches?.length
1016
- ? writeArtifact(manifest.artifactsRoot, {
1017
- kind: "patch",
1018
- relativePath: `patches/${task.id}.patch`,
1019
- content: parsedOutput.patches.join("\n---\n"),
1020
- producer: task.id,
1021
- })
1022
- : undefined;
1023
-
1024
- const mutationGuardMode = input.runtimeConfig?.completionMutationGuard ?? "warn";
1025
- const mutationGuard =
1026
- !error && mutationGuardMode !== "off"
1027
- ? evaluateCompletionMutationGuard({
1028
- role: task.role,
1029
- taskText: `${task.title}\n${input.step.task}`,
1030
- transcriptPath: runtimeKind === "child-process" ? transcriptPath : transcriptArtifact?.path,
1031
- stdout: finalStdout,
1032
- })
1033
- : undefined;
1034
- if (mutationGuard?.reason === "no_mutation_observed") {
1035
- appendTaskAttentionEvent({
1036
- manifest,
1037
- taskId: task.id,
1038
- message: "Implementation-style task completed without an observed mutation tool call.",
1039
- data: {
1040
- activityState: "needs_attention",
1041
- reason: "completion_guard",
1042
- taskId: task.id,
1043
- agentName: task.agent,
1044
- observedTools: mutationGuard.observedTools,
1045
- suggestedAction:
1046
- mutationGuardMode === "fail"
1047
- ? "Review the worker output and rerun with a concrete implementation task."
1048
- : "Review the worker output; set runtime.completionMutationGuard='fail' to enforce this.",
1049
- },
1050
- });
1051
- task = {
1052
- ...task,
1053
- agentProgress: {
1054
- ...(task.agentProgress ?? emptyCrewAgentProgress()),
1055
- activityState: "needs_attention",
1056
- },
1057
- };
1058
- if (mutationGuardMode === "fail") {
1059
- error = "Completion mutation guard failed: implementation-style task completed without an observed mutation tool call.";
1060
- exitCode = exitCode === 0 ? 1 : exitCode;
1061
- if (modelAttempts?.length) {
1062
- modelAttempts = modelAttempts.map((attempt, index) =>
1063
- index === modelAttempts!.length - 1 ? { ...attempt, success: false, exitCode, error } : attempt,
1064
- );
1065
- }
1066
- }
1067
- tasks = updateTask(tasks, task);
1068
- }
1069
-
1070
- // --- Output format validation (caveman Phase 4) ---
1071
- // Validate worker output against the role's output contract.
1072
- // On failure: emit attention event but don't fail the task.
1073
- let outputValidation: OutputValidationResult | undefined;
1074
- if (!error) {
1075
- const outputText = parsedOutput?.finalText ?? finalStdout;
1076
- if (outputText) {
1077
- outputValidation = validateWorkerOutput(task.role, outputText);
1078
- if (!outputValidation.valid) {
1079
- await appendEventAsync(manifest.eventsPath, {
1080
- type: "task.output_validation",
1081
- runId: manifest.runId,
1082
- taskId: task.id,
1083
- data: {
1084
- valid: false,
1085
- formatMatch: outputValidation.formatMatch,
1086
- structurePreserved: outputValidation.structurePreserved,
1087
- issues: outputValidation.issues,
1088
- },
1089
- });
1090
- task = {
1091
- ...task,
1092
- agentProgress: {
1093
- ...(task.agentProgress ?? emptyCrewAgentProgress()),
1094
- activityState: "needs_attention",
1095
- },
1096
- };
1097
- tasks = updateTask(tasks, task);
1098
- }
1099
- }
1100
- }
1101
-
1102
- // --- ECC VERIFICATION_LOOP: Compute verification evidence before building task object ---
1103
- // Compute verification evidence (may be async if verification commands need to run)
1104
- const baseEvidence = createVerificationEvidence(
1105
- taskPacket.verification,
1106
- !error,
1107
- error
1108
- ? `Task failed: ${error}`
1109
- : runtimeKind === "scaffold"
1110
- ? "Safe scaffold mode; verification commands were not executed."
1111
- : `${runtimeKind} worker finished without reporting a verification failure.`,
1112
- );
1113
-
1114
- // Only execute verification commands when:
1115
- // 1. Task completed successfully (no error)
1116
- // 2. Verification contract has commands
1117
- // 3. Not in scaffold mode (scaffold mode intentionally skips execution)
1118
- let verificationEvidence: VerificationEvidence = baseEvidence;
1119
- if (runtimeKind !== "scaffold" && taskPacket.verification?.commands?.length) {
1120
- try {
1121
- const commandResults = await executeVerificationCommands(
1122
- taskPacket.verification,
1123
- task.cwd,
1124
- manifest.runId,
1125
- task.id,
1126
- manifest.artifactsRoot,
1127
- input.signal,
1128
- );
1129
-
1130
- // Compute observed green level from results
1131
- const observedGreenLevel = computeGreenLevelFromResults(commandResults, taskPacket.verification.requiredGreenLevel);
1132
-
1133
- // Determine satisfaction based on green level
1134
- const requiredLevel = taskPacket.verification.requiredGreenLevel;
1135
- const satisfied =
1136
- observedGreenLevel === "none"
1137
- ? false
1138
- : observedGreenLevel === "targeted"
1139
- ? requiredLevel === "targeted"
1140
- : observedGreenLevel === "package"
1141
- ? ["targeted", "package"].includes(requiredLevel)
1142
- : observedGreenLevel === "workspace"
1143
- ? ["targeted", "package", "workspace"].includes(requiredLevel)
1144
- : observedGreenLevel === "merge_ready";
1145
-
1146
- const allPassed = commandResults.every((r) => r.status === "passed");
1147
- const failedCount = commandResults.filter((r) => r.status === "failed").length;
1148
-
1149
- verificationEvidence = {
1150
- requiredGreenLevel: taskPacket.verification.requiredGreenLevel,
1151
- observedGreenLevel,
1152
- satisfied: satisfied && allPassed,
1153
- commands: commandResults,
1154
- notes: allPassed
1155
- ? `${commandResults.length} verification commands passed`
1156
- : `${failedCount}/${commandResults.length} verification commands failed`,
1157
- };
1158
- } catch (execError) {
1159
- // On execution error, return base evidence with error note
1160
- verificationEvidence = {
1161
- ...baseEvidence,
1162
- notes: `Verification execution failed: ${execError instanceof Error ? execError.message : String(execError)}`,
1163
- };
1164
- }
1165
- }
1166
-
1167
- task = {
1168
- ...task,
1169
- status: error ? "failed" : noYield ? "needs_attention" : "completed",
1170
- finishedAt: new Date().toISOString(),
1171
- exitCode,
1172
- modelAttempts,
1173
- usage: parsedOutput?.usage,
1174
- jsonEvents: parsedOutput?.jsonEvents,
1175
- agentProgress:
1176
- error && task.agentProgress?.currentTool
1177
- ? {
1178
- ...task.agentProgress,
1179
- failedTool: task.agentProgress.currentTool,
1180
- }
1181
- : task.agentProgress,
1182
- error,
1183
- verification: verificationEvidence,
1184
- resultArtifact,
1185
- claim: undefined,
1186
- heartbeat: touchWorkerHeartbeat(task.heartbeat ?? createWorkerHeartbeat(task.id), { alive: false }),
1187
- workerExitStatus: terminalEvidence.at(-1)?.exitStatus,
1188
- terminalEvidence: terminalEvidence.length ? [...(task.terminalEvidence ?? []), ...terminalEvidence] : task.terminalEvidence,
1189
- ...(logArtifact ? { logArtifact } : {}),
1190
- ...(transcriptArtifact ? { transcriptArtifact } : {}),
1191
- };
1192
- tasks = updateTask(tasks, task);
1193
-
1194
- // Emit task completion hooks (100% reliable, fire-and-forget)
1195
- const hookType = task.status === "completed" ? "task_completed" : task.status === "failed" ? "task_failed" : "task_started";
1196
- // T10: attach the VERBATIM command trace (mechanically derived from
1197
- // recorded tool-call history, never from the worker's self-report) so
1198
- // event viewers + the orchestrator see exactly which commands ran.
1199
- const commandTrace = extractCommandTrace(task.agentProgress?.recentTools);
1200
- crewHooks.emit({
1201
- type: hookType,
1202
- timestamp: task.finishedAt ?? new Date().toISOString(),
1203
- runId: manifest.runId,
1204
- taskId: task.id,
1205
- data: {
1206
- status: task.status,
1207
- role: task.role,
1208
- error: task.error,
1209
- exitCode: task.exitCode,
1210
- usage: task.usage,
1211
- commandTrace,
1212
- },
1213
- });
1214
-
1215
- const packetArtifact = writeArtifact(manifest.artifactsRoot, {
1216
- kind: "metadata",
1217
- relativePath: `metadata/${task.id}.task-packet.json`,
1218
- content: `${JSON.stringify(task.taskPacket, null, 2)}\n`,
1219
- producer: task.id,
1220
- });
1221
- const verificationArtifact = writeArtifact(manifest.artifactsRoot, {
1222
- kind: "metadata",
1223
- relativePath: `metadata/${task.id}.verification.json`,
1224
- content: `${JSON.stringify(task.verification, null, 2)}\n`,
1225
- producer: task.id,
1226
- });
1227
- const sharedOutputArtifact = writeTaskSharedOutput(manifest, input.step, task);
1228
- const startupArtifact = writeArtifact(manifest.artifactsRoot, {
1229
- kind: "metadata",
1230
- relativePath: `metadata/${task.id}.startup-evidence.json`,
1231
- content: `${JSON.stringify(startupEvidence, null, 2)}\n`,
1232
- producer: task.id,
1233
- });
1234
- const permissionArtifact = writeArtifact(manifest.artifactsRoot, {
1235
- kind: "metadata",
1236
- relativePath: `metadata/${task.id}.permission.json`,
1237
- content: `${JSON.stringify({ role: task.role, permissionMode }, null, 2)}\n`,
1238
- producer: task.id,
1239
- });
1240
- const capabilityArtifact = writeArtifact(manifest.artifactsRoot, {
1241
- kind: "metadata",
1242
- relativePath: `metadata/${task.id}.capabilities.json`,
1243
- content: `${JSON.stringify(buildWorkerCapabilityInventory({ taskId: task.id, role: task.role, agent: input.agent, runtime: runtimeKind, permissionMode, skillNames, skillPaths, skillsDisabled: input.skillOverride === false || input.teamRoleSkills === false, modelOverride: input.modelOverride, teamRoleModel: input.teamRoleModel, stepModel: input.step.model }), null, 2)}\n`,
1244
- producer: task.id,
1245
- });
1246
- const promptPipelineArtifact = writeArtifact(manifest.artifactsRoot, {
1247
- kind: "metadata",
1248
- relativePath: `metadata/${task.id}.prompt-pipeline.json`,
1249
- content: `${JSON.stringify(buildWorkerPromptPipeline({ artifactsRoot: manifest.artifactsRoot, taskId: task.id, promptArtifact, inputsArtifact, skillArtifact, capabilityArtifact, coordinationArtifact, skillInstructionCount: skillNames?.length ?? 0, skillsDisabled: input.skillOverride === false || input.teamRoleSkills === false }), null, 2)}\n`,
1250
- producer: task.id,
1251
- });
1252
- const outputValidationArtifact = outputValidation
1253
- ? writeArtifact(manifest.artifactsRoot, {
1254
- kind: "metadata",
1255
- relativePath: `metadata/${task.id}.output-validation.json`,
1256
- content: `${JSON.stringify(outputValidation, null, 2)}\n`,
1257
- producer: task.id,
1258
- })
1259
- : undefined;
1260
- manifest = {
1261
- ...manifest,
1262
- updatedAt: new Date().toISOString(),
1263
- artifacts: [
1264
- ...manifest.artifacts,
1265
- promptArtifact,
1266
- resultArtifact,
1267
- inputsArtifact,
1268
- coordinationArtifact,
1269
- ...(skillArtifact ? [skillArtifact] : []),
1270
- packetArtifact,
1271
- verificationArtifact,
1272
- startupArtifact,
1273
- permissionArtifact,
1274
- capabilityArtifact,
1275
- promptPipelineArtifact,
1276
- ...(outputValidationArtifact ? [outputValidationArtifact] : []),
1277
- ...(sharedOutputArtifact ? [sharedOutputArtifact] : []),
1278
- ...(logArtifact ? [logArtifact] : []),
1279
- ...(transcriptArtifact ? [transcriptArtifact] : []),
1280
- ...(diffArtifact ? [diffArtifact] : []),
1281
- ...(diffStatArtifact ? [diffStatArtifact] : []),
1282
- ...(patchArtifact ? [patchArtifact] : []),
1283
- ],
1284
- };
1285
- // NEW-C3: persist manifest + tasks atomically under the run lock. Without this,
1286
- // the unlocked saveRunManifest here races with the team-runner batch merge path
1287
- // (which writes the manifest under withRunLock) — a parallel batch could read a
1288
- // stale manifest and overwrite this task's freshly-written artifacts, silently
1289
- // losing them. persistSingleTaskUpdate is re-entrance-safe (runLockHeldByUs guard),
1290
- // so nesting it inside this lock is a no-op re-acquire, not a deadlock.
1291
- // ST-7: this is a terminal transition (task.status is completed/failed/needs_attention),
1292
- // pass skipCoalesce=true so the terminal update is durable — a SIGKILL in the
1293
- // 50ms coalesce window must NOT leave tasks.json showing the prior non-terminal
1294
- // status, otherwise crash recovery would see inconsistency between tasks.json
1295
- // (running) and events.jsonl (terminal).
1296
- tasks = await withRunLock(manifest, async () => {
1297
- await saveRunManifestAsync(manifest);
1298
- return persistSingleTaskUpdate(manifest, tasks, task, undefined, true);
1299
- });
1300
- upsertCrewAgent(manifest, recordFromTask(manifest, task, runtimeKind));
1301
- // Execute task_result hook before emitting terminal event
1302
- const hookReport = await executeHook("task_result", {
1303
- runId: manifest.runId,
1304
- taskId: task.id,
1305
- cwd: manifest.cwd,
1306
- });
1307
- appendHookEvent(manifest, hookReport);
1308
- await appendEventAsync(manifest.eventsPath, {
1309
- type: error ? "task.failed" : noYield ? "task.needs_attention" : "task.completed",
1310
- runId: manifest.runId,
1311
- taskId: task.id,
1312
- message: error,
1313
- });
1314
-
1315
- // Execute after_task_complete lifecycle hook (non-blocking)
1316
- const afterTaskReport = await executeHook("after_task_complete", {
1317
- runId: manifest.runId,
1318
- taskId: task.id,
1319
- cwd: manifest.cwd,
1320
- status: error ? "failed" : noYield ? "needs_attention" : "completed",
1321
- });
1322
- appendHookEvent(manifest, afterTaskReport);
1323
-
1324
- return { manifest, tasks };
1325
- } finally {
1326
- streamBridge?.dispose();
1327
- }
1328
- }
1329
-
1330
- /**
1331
- * F7: resolve the enabledModels allowlist for the child-process spawn path,
1332
- * but only if `runtime.reliability.scopeModels` is ON. Returns [] (no-op)
1333
- * when the toggle is off or the allowlist is empty. Best-effort: any failure
1334
- * to read config or the allowlist silently disables the gate so spawn is
1335
- * never blocked by a misconfiguration.
1336
- */
1337
- async function resolveTaskScopeModelsPatterns(cwd: string): Promise<string[]> {
1338
- let scopeModels = false;
1339
- try {
1340
- scopeModels = loadConfig(cwd).config.reliability?.scopeModels === true;
1341
- } catch {
1342
- return [];
1343
- }
1344
- if (!scopeModels) return [];
1345
- return readEnabledModelsPatterns(cwd);
1346
- }
1347
-
1348
- /**
1349
- * 429/rate-limit detection (PI_CREW_TOOLING_429_NOTE.md).
1350
- *
1351
- * A worker can exit code 0 with no hard error, yet the transcript is full of
1352
- * `message_end` events carrying `errorMessage: "429 ... overloaded"` (or any
1353
- * retryable model-failure pattern) and empty content arrays. The model never
1354
- * produced a tool call, so the worker "completed" without doing anything.
1355
- *
1356
- * This helper inspects a ParsedPiJsonOutput and, if the run produced only
1357
- * retryable model-failure messages AND no real output text (no finalText, no
1358
- * text events, no patches), returns a surfaced error string so the
1359
- * model-fallback chain (isRetryableModelFailure) can retry on another model.
1360
- * Returns undefined when the run has real output (the 429s were recovered from)
1361
- * or when there are no retryable error messages.
1362
- */
1363
- export function detectRetryableModelFailureFromOutput(parsed: ParsedPiJsonOutput): string | undefined {
1364
- // Primary signal: pre-extracted `errorMessages` (from pi-json-output parser).
1365
- // The parser already filters to non-empty trimmed strings from message_end
1366
- // events.
1367
- const messages = parsed.errorMessages;
1368
- if (messages && messages.length > 0) {
1369
- // Find the first retryable model-failure message
1370
- // (429 / rate-limit / overloaded / 5xx / ...).
1371
- const retryable = messages.find((m) => isRetryableModelFailure(m));
1372
- if (retryable) {
1373
- // Did the run actually produce real output despite the transient errors?
1374
- // If finalText / textEvents / patches exist, the model recovered and we
1375
- // should NOT mark the run as failed — only flag it when the worker
1376
- // yielded nothing (the 429-only case from the bug report).
1377
- const hasRealOutput =
1378
- (parsed.finalText?.trim().length ?? 0) > 0 ||
1379
- parsed.textEvents.some((t) => t.trim().length > 0) ||
1380
- (parsed.patches?.length ?? 0) > 0;
1381
- if (hasRealOutput) return undefined;
1382
- return `Model returned only retryable errors and no output: ${retryable}`;
1383
- }
1384
- }
1385
- // Secondary signal (FIX 3, task packet 01_01-agent): inspect a raw
1386
- // `messageEndEvents` (or `transcript`) array on the parsed output. The
1387
- // ParsedPiJsonOutput type does not currently declare this field, so we
1388
- // read it through a local extension cast. Callers that pass it (tests, a
1389
- // future parser that captures the full event stream) get a second chance
1390
- // to surface retryable failures. Primary path still wins when it matches.
1391
- const raw = parsed as ParsedPiJsonOutput & {
1392
- messageEndEvents?: unknown;
1393
- transcript?: unknown;
1394
- };
1395
- const eventSource = Array.isArray(raw.messageEndEvents)
1396
- ? raw.messageEndEvents
1397
- : Array.isArray(raw.transcript)
1398
- ? raw.transcript
1399
- : undefined;
1400
- if (!eventSource || eventSource.length === 0) return undefined;
1401
- for (const candidate of eventSource) {
1402
- if (!candidate || typeof candidate !== "object") continue;
1403
- const event = candidate as {
1404
- stopReason?: unknown;
1405
- errorMessage?: unknown;
1406
- };
1407
- if (event.stopReason !== "error") continue;
1408
- if (typeof event.errorMessage !== "string" || event.errorMessage.length === 0) continue;
1409
- if (!isRetryableModelFailure(event.errorMessage)) continue;
1410
- // Same real-output gate as the primary signal — don't flag runs that
1411
- // recovered with real final text / patches.
1412
- const hasRealOutput =
1413
- (parsed.finalText?.trim().length ?? 0) > 0 ||
1414
- parsed.textEvents.some((t) => t.trim().length > 0) ||
1415
- (parsed.patches?.length ?? 0) > 0;
1416
- if (hasRealOutput) return undefined;
1417
- return `Model returned only retryable errors and no output: ${event.errorMessage}`;
1418
- }
1419
- return undefined;
1420
- }